chrome-devtools-frontend 1.0.1000934 → 1.0.1002543

package/front_end/generated/protocol.ts

@@ -963,11 +963,9 @@ export namespace Audits {
 
   export const enum AttributionReportingIssueType {
     PermissionPolicyDisabled = 'PermissionPolicyDisabled',
-    InvalidAttributionSourceEventId = 'InvalidAttributionSourceEventId',
     AttributionSourceUntrustworthyOrigin = 'AttributionSourceUntrustworthyOrigin',
     AttributionUntrustworthyOrigin = 'AttributionUntrustworthyOrigin',
-    InvalidAttributionSourceExpiry = 'InvalidAttributionSourceExpiry',
-    InvalidAttributionSourcePriority = 'InvalidAttributionSourcePriority',
+    InvalidHeader = 'InvalidHeader',
   }
 
   /**
@@ -1038,10 +1036,7 @@ export namespace Audits {
     GetUserMediaInsecureOrigin = 'GetUserMediaInsecureOrigin',
     HostCandidateAttributeGetter = 'HostCandidateAttributeGetter',
     InsecurePrivateNetworkSubresourceRequest = 'InsecurePrivateNetworkSubresourceRequest',
-    LegacyConstraintGoogCpuOveruseDetection = 'LegacyConstraintGoogCpuOveruseDetection',
     LegacyConstraintGoogIPv6 = 'LegacyConstraintGoogIPv6',
-    LegacyConstraintGoogScreencastMinBitrate = 'LegacyConstraintGoogScreencastMinBitrate',
-    LegacyConstraintGoogSuspendBelowMinBitrate = 'LegacyConstraintGoogSuspendBelowMinBitrate',
     LocalCSSFileExtensionRejected = 'LocalCSSFileExtensionRejected',
     MediaElementAudioSourceNode = 'MediaElementAudioSourceNode',
     MediaSourceAbortRemove = 'MediaSourceAbortRemove',
@@ -1068,16 +1063,13 @@ export namespace Audits {
     RTCConstraintEnableDtlsSrtpTrue = 'RTCConstraintEnableDtlsSrtpTrue',
     RTCPeerConnectionComplexPlanBSdpUsingDefaultSdpSemantics =
         'RTCPeerConnectionComplexPlanBSdpUsingDefaultSdpSemantics',
-    RTCPeerConnectionLegacyCreateWithMediaConstraints = 'RTCPeerConnectionLegacyCreateWithMediaConstraints',
     RTCPeerConnectionSdpSemanticsPlanB = 'RTCPeerConnectionSdpSemanticsPlanB',
     RtcpMuxPolicyNegotiate = 'RtcpMuxPolicyNegotiate',
     RTPDataChannel = 'RTPDataChannel',
-    SelectionAddRangeIntersect = 'SelectionAddRangeIntersect',
     SharedArrayBufferConstructedWithoutIsolation = 'SharedArrayBufferConstructedWithoutIsolation',
     TextToSpeech_DisallowedByAutoplay = 'TextToSpeech_DisallowedByAutoplay',
     V8SharedArrayBufferConstructedInExtensionWithoutIsolation =
         'V8SharedArrayBufferConstructedInExtensionWithoutIsolation',
-    WebCodecsVideoFrameDefaultTimestamp = 'WebCodecsVideoFrameDefaultTimestamp',
     XHRJSONEncodingDetection = 'XHRJSONEncodingDetection',
     XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload = 'XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload',
     XRSupportsSession = 'XRSupportsSession',
@@ -4939,6 +4931,8 @@ export namespace DOMSnapshot {
  */
 export namespace DOMStorage {
 
+  export type SerializedStorageKey = string;
+
   /**
    * DOM Storage identifier.
    */
@@ -4946,7 +4940,11 @@ export namespace DOMStorage {
     /**
      * Security origin for the storage.
      */
-    securityOrigin: string;
+    securityOrigin?: string;
+    /**
+     * Represents a key by which DOM Storage keys its CachedStorageAreas
+     */
+    storageKey?: SerializedStorageKey;
     /**
      * Whether the storage is local storage (not session storage).
      */
@@ -4981,6 +4979,14 @@ export namespace DOMStorage {
     value: string;
   }
 
+  export interface GetStorageKeyForFrameRequest {
+    frameId: Page.FrameId;
+  }
+
+  export interface GetStorageKeyForFrameResponse extends ProtocolResponseWithError {
+    storageKey: SerializedStorageKey;
+  }
+
   export interface DomStorageItemAddedEvent {
     storageId: StorageId;
     key: string;
@@ -10978,6 +10984,38 @@ export namespace Page {
    */
   export const enum PrerenderFinalStatus {
     Activated = 'Activated',
+    Destroyed = 'Destroyed',
+    LowEndDevice = 'LowEndDevice',
+    CrossOriginRedirect = 'CrossOriginRedirect',
+    CrossOriginNavigation = 'CrossOriginNavigation',
+    InvalidSchemeRedirect = 'InvalidSchemeRedirect',
+    InvalidSchemeNavigation = 'InvalidSchemeNavigation',
+    InProgressNavigation = 'InProgressNavigation',
+    NavigationRequestBlockedByCsp = 'NavigationRequestBlockedByCsp',
+    MainFrameNavigation = 'MainFrameNavigation',
+    MojoBinderPolicy = 'MojoBinderPolicy',
+    RendererProcessCrashed = 'RendererProcessCrashed',
+    RendererProcessKilled = 'RendererProcessKilled',
+    Download = 'Download',
+    TriggerDestroyed = 'TriggerDestroyed',
+    NavigationNotCommitted = 'NavigationNotCommitted',
+    NavigationBadHttpStatus = 'NavigationBadHttpStatus',
+    ClientCertRequested = 'ClientCertRequested',
+    NavigationRequestNetworkError = 'NavigationRequestNetworkError',
+    MaxNumOfRunningPrerendersExceeded = 'MaxNumOfRunningPrerendersExceeded',
+    CancelAllHostsForTesting = 'CancelAllHostsForTesting',
+    DidFailLoad = 'DidFailLoad',
+    Stop = 'Stop',
+    SslCertificateError = 'SslCertificateError',
+    LoginAuthRequested = 'LoginAuthRequested',
+    UaChangeRequiresReload = 'UaChangeRequiresReload',
+    BlockedByClient = 'BlockedByClient',
+    AudioOutputDeviceRequested = 'AudioOutputDeviceRequested',
+    MixedContent = 'MixedContent',
+    TriggerBackgrounded = 'TriggerBackgrounded',
+    EmbedderTriggeredAndSameOriginRedirected = 'EmbedderTriggeredAndSameOriginRedirected',
+    EmbedderTriggeredAndCrossOriginRedirected = 'EmbedderTriggeredAndCrossOriginRedirected',
+    EmbedderTriggeredAndDestroyed = 'EmbedderTriggeredAndDestroyed',
   }
 
   export interface AddScriptToEvaluateOnLoadRequest {
@@ -12661,6 +12699,8 @@ export namespace ServiceWorker {
 
 export namespace Storage {
 
+  export type SerializedStorageKey = string;
+
   /**
    * Enum of possible storage types.
    */

package/front_end/models/bindings/BreakpointManager.ts

@@ -560,13 +560,17 @@ export class Breakpoint implements SDK.TargetManager.SDKModelObserver<SDK.Debugg
         Array.from(this.#modelBreakpoints.values()).map(modelBreakpoint => modelBreakpoint.scheduleUpdateInDebugger()));
   }
 
-  remove(keepInStorage: boolean): void {
+  async remove(keepInStorage: boolean): Promise<void> {
     this.isRemoved = true;
     const removeFromStorage = !keepInStorage;
+
+    // Await removing for all targets.
+    const updatePromises: Promise<void>[] = [];
     for (const modelBreakpoint of this.#modelBreakpoints.values()) {
-      void modelBreakpoint.scheduleUpdateInDebugger();
       modelBreakpoint.removeEventListeners();
+      updatePromises.push(modelBreakpoint.scheduleUpdateInDebugger());
     }
+    await Promise.all(updatePromises);
 
     this.breakpointManager.removeBreakpoint(this, removeFromStorage);
     this.breakpointManager.targetManager.unobserveModels(SDK.DebuggerModel.DebuggerModel, this);
@@ -578,13 +582,6 @@ export class Breakpoint implements SDK.TargetManager.SDKModelObserver<SDK.Debugg
         this.urlInternal, this.#lineNumberInternal, this.#columnNumberInternal);
   }
 
-  private resetLocations(): void {
-    this.clearUISourceCodes();
-    for (const modelBreakpoint of this.#modelBreakpoints.values()) {
-      modelBreakpoint.resetLocations();
-    }
-  }
-
   private defaultUILocation(uiSourceCode: Workspace.UISourceCode.UISourceCode): Workspace.UISourceCode.UILocation {
     return uiSourceCode.uiLocation(this.#lineNumberInternal, this.#columnNumberInternal);
   }
@@ -782,7 +779,11 @@ export class ModelBreakpoint {
     }
 
     if (!breakpointIds.length) {
-      this.#breakpoint.remove(true);
+      // Do not await the remove, as we otherwise will create a circular
+      // dependency. Removing breakpoints will call `scheduleUpdateInDebugger` again.
+      // Calling it again would cause it to await this current run of `scheduleInDebugger`, which
+      // will then deadlock.
+      void this.#breakpoint.remove(true);
       return;
     }
 
@@ -844,7 +845,7 @@ export class ModelBreakpoint {
     const breakpointLocation = this.#breakpoint.breakpointManager.findBreakpoint(uiLocation);
     if (breakpointLocation && breakpointLocation.breakpoint !== this.#breakpoint) {
       // location clash
-      this.#breakpoint.remove(false /* keepInStorage */);
+      await this.#breakpoint.remove(false /* keepInStorage */);
       return;
     }
     await this.#debuggerWorkspaceBinding.createLiveLocation(

package/front_end/models/bindings/CompilerScriptMapping.ts

@@ -124,7 +124,7 @@ export class CompilerScriptMapping implements DebuggerSourceMapping {
     await this.#debuggerWorkspaceBinding.updateLocations(script);
   }
 
-  static uiSourceCodeOrigin(uiSourceCode: Workspace.UISourceCode.UISourceCode): string[] {
+  static uiSourceCodeOrigin(uiSourceCode: Workspace.UISourceCode.UISourceCode): Platform.DevToolsPath.UrlString[] {
     const binding = uiSourceCodeToBinding.get(uiSourceCode);
     if (binding) {
       return binding.getReferringSourceMaps().map((sourceMap: SDK.SourceMap.SourceMap) => sourceMap.compiledURL());

package/front_end/models/issues_manager/AttributionReportingIssue.ts

@@ -10,31 +10,25 @@ import type {MarkdownIssueDescription} from './MarkdownIssueDescription.js';
 
 export const enum IssueCode {
   PermissionPolicyDisabled = 'AttributionReportingIssue::PermissionPolicyDisabled',
-  InvalidAttributionSourceEventId = 'AttributionReportingIssue::InvalidAttributionSourceEventId',
   AttributionSourceUntrustworthyFrameOrigin = 'AttributionReportingIssue::AttributionSourceUntrustworthyFrameOrigin',
   AttributionSourceUntrustworthyOrigin = 'AttributionReportingIssue::AttributionSourceUntrustworthyOrigin',
   AttributionUntrustworthyFrameOrigin = 'AttributionReportingIssue::AttributionUntrustworthyFrameOrigin',
   AttributionUntrustworthyOrigin = 'AttributionReportingIssue::AttributionUntrustworthyOrigin',
-  InvalidAttributionSourceExpiry = 'AttributionReportingIssue::InvalidAttributionSourceExpiry',
-  InvalidAttributionSourcePriority = 'AttributionReportingIssue::InvalidAttributionSourcePriority',
+  InvalidHeader = 'AttributionReportingIssue::InvalidHeader',
 }
 
 function getIssueCode(details: Protocol.Audits.AttributionReportingIssueDetails): IssueCode {
   switch (details.violationType) {
     case Protocol.Audits.AttributionReportingIssueType.PermissionPolicyDisabled:
       return IssueCode.PermissionPolicyDisabled;
-    case Protocol.Audits.AttributionReportingIssueType.InvalidAttributionSourceEventId:
-      return IssueCode.InvalidAttributionSourceEventId;
     case Protocol.Audits.AttributionReportingIssueType.AttributionSourceUntrustworthyOrigin:
       return details.frame !== undefined ? IssueCode.AttributionSourceUntrustworthyFrameOrigin :
                                            IssueCode.AttributionSourceUntrustworthyOrigin;
     case Protocol.Audits.AttributionReportingIssueType.AttributionUntrustworthyOrigin:
       return details.frame !== undefined ? IssueCode.AttributionUntrustworthyFrameOrigin :
                                            IssueCode.AttributionUntrustworthyOrigin;
-    case Protocol.Audits.AttributionReportingIssueType.InvalidAttributionSourceExpiry:
-      return IssueCode.InvalidAttributionSourceExpiry;
-    case Protocol.Audits.AttributionReportingIssueType.InvalidAttributionSourcePriority:
-      return IssueCode.InvalidAttributionSourcePriority;
+    case Protocol.Audits.AttributionReportingIssueType.InvalidHeader:
+      return IssueCode.InvalidHeader;
   }
 }
 
@@ -58,15 +52,6 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
           file: 'arPermissionPolicyDisabled.md',
           links: [],
         };
-      case IssueCode.InvalidAttributionSourceEventId:
-        return {
-          file: 'arInvalidAttributionSourceEventId.md',
-          links: [{
-            link:
-                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionsourceeventid-required',
-            linkTitle: 'attributionsourceeventid attribute',
-          }],
-        };
       case IssueCode.AttributionSourceUntrustworthyFrameOrigin:
         return {
           file: 'arAttributionSourceUntrustworthyFrameOrigin.md',
@@ -98,24 +83,8 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
           file: 'arAttributionUntrustworthyOrigin.md',
           links: [],
         };
-      case IssueCode.InvalidAttributionSourceExpiry:
-        return {
-          file: 'arInvalidAttributionSourceExpiry.md',
-          links: [{
-            link:
-                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionexpiry',
-            linkTitle: 'attributionexpiry attribute',
-          }],
-        };
-      case IssueCode.InvalidAttributionSourcePriority:
-        return {
-          file: 'arInvalidAttributionSourcePriority.md',
-          links: [{
-            link:
-                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionsourcepriority',
-            linkTitle: 'attributionsourcepriority attribute',
-          }],
-        };
+      case IssueCode.InvalidHeader:
+        return null;
     }
   }