chrome-devtools-frontend 1.0.1000934 → 1.0.1002543

package/front_end/ui/components/panel_feedback/FeedbackButton.ts

@@ -4,7 +4,7 @@
 
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
+import * as Platform from '../../../core/platform/platform.js';
 import * as ComponentHelpers from '../../components/helpers/helpers.js';
 import * as LitHtml from '../../lit-html/lit-html.js';
 import * as Buttons from '../buttons/buttons.js';
@@ -22,7 +22,7 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const feedbackIconUrl = new URL('../../../Images/feedback_button_icon.svg', import.meta.url).toString();
 
 export interface FeedbackButtonData {
-  feedbackUrl: string;
+  feedbackUrl: Platform.DevToolsPath.UrlString;
 }
 export class FeedbackButton extends HTMLElement {
   static readonly litTagName = LitHtml.literal`devtools-feedback-button`;
@@ -30,7 +30,7 @@ export class FeedbackButton extends HTMLElement {
   readonly #boundRender = this.#render.bind(this);
 
   #props: FeedbackButtonData = {
-    feedbackUrl: '',
+    feedbackUrl: Platform.DevToolsPath.EmptyUrlString,
   };
 
   set data(data: FeedbackButtonData) {
@@ -39,9 +39,7 @@ export class FeedbackButton extends HTMLElement {
   }
 
   #onFeedbackClick(): void {
-    // TODO(crbug.com/1253323): Cast to UrlString will be removed when migration to branded types is complete.
-    Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
-        this.#props.feedbackUrl as Platform.DevToolsPath.UrlString);
+    Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(this.#props.feedbackUrl);
   }
 
   #render(): void {

package/front_end/ui/components/panel_feedback/PanelFeedback.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import * as Platform from '../../../core/platform/platform.js';
 import * as ComponentHelpers from '../../components/helpers/helpers.js';
 import * as LitHtml from '../../lit-html/lit-html.js';
 import * as IconButton from '../icon_button/icon_button.js';
@@ -35,8 +36,8 @@ const previewFeatureUrl = new URL('../../../Images/ic_preview_feature.svg', impo
 const videoThumbnailUrl = new URL('../../../Images/preview_feature_video_thumbnail.svg', import.meta.url).toString();
 
 export interface PanelFeedbackData {
-  feedbackUrl: string;
-  quickStartUrl: string;
+  feedbackUrl: Platform.DevToolsPath.UrlString;
+  quickStartUrl: Platform.DevToolsPath.UrlString;
   quickStartLinkText: string;
 }
 export class PanelFeedback extends HTMLElement {
@@ -45,8 +46,8 @@ export class PanelFeedback extends HTMLElement {
   readonly #boundRender = this.#render.bind(this);
 
   #props: PanelFeedbackData = {
-    feedbackUrl: '',
-    quickStartUrl: '',
+    feedbackUrl: Platform.DevToolsPath.EmptyUrlString,
+    quickStartUrl: Platform.DevToolsPath.EmptyUrlString,
     quickStartLinkText: '',
   };
 

package/front_end/ui/components/request_link_icon/RequestLinkIcon.ts

@@ -45,7 +45,7 @@ export interface RequestLinkIconData {
   revealOverride?: (revealable: Object|null, omitFocus?: boolean|undefined) => Promise<void>;
 }
 
-export const extractShortPath = (path: string): string => {
+export const extractShortPath = (path: Platform.DevToolsPath.UrlString): string => {
   // 1st regex matches everything after last '/'
   // if path ends with '/', 2nd regex returns everything between the last two '/'
   return (/[^/]+$/.exec(path) || /[^/]+\/$/.exec(path) || [''])[0];
@@ -163,14 +163,14 @@ export class RequestLinkIcon extends HTMLElement {
     return i18nString(UIStrings.requestUnavailableInTheNetwork);
   }
 
-  #getUrlForDisplaying(): string|undefined {
+  #getUrlForDisplaying(): Platform.DevToolsPath.UrlString|undefined {
     if (!this.#request) {
-      return this.#affectedRequest?.url;
+      return this.#affectedRequest?.url as Platform.DevToolsPath.UrlString;
     }
     return this.#request.url();
   }
 
-  #maybeRenderURL(): LitHtml.TemplateResult|{} {
+  #maybeRenderURL(): LitHtml.LitTemplate {
     if (!this.#displayURL) {
       return LitHtml.nothing;
     }

package/front_end/ui/legacy/EmptyWidget.ts

@@ -29,6 +29,7 @@
  */
 
 import * as i18n from '../../core/i18n/i18n.js';
+import type * as Platform from '../../core/platform/platform.js';
 
 import emptyWidgetStyles from './emptyWidget.css.legacy.js';
 import {VBox} from './Widget.js';
@@ -59,7 +60,7 @@ export class EmptyWidget extends VBox {
     return this.contentElement.createChild('p');
   }
 
-  appendLink(link: string): HTMLElement {
+  appendLink(link: Platform.DevToolsPath.UrlString): HTMLElement {
     return this.contentElement.appendChild(XLink.create(link, i18nString(UIStrings.learnMore))) as HTMLElement;
   }
 

package/front_end/ui/legacy/UIUtils.ts

@@ -1490,25 +1490,25 @@ let measureTextWidthCache: Map<string, Map<string, number>>|null = null;
 /**
  * Adds a 'utm_source=devtools' as query parameter to the url.
  */
-export function addReferrerToURL(url: string): string {
+export function addReferrerToURL(url: Platform.DevToolsPath.UrlString): Platform.DevToolsPath.UrlString {
   if (/(\?|&)utm_source=devtools/.test(url)) {
     return url;
   }
   if (url.indexOf('?') === -1) {
     // If the URL does not contain a query, add the referrer query after path
     // and before (potential) anchor.
-    return url.replace(/^([^#]*)(#.*)?$/g, '$1?utm_source=devtools$2');
+    return url.replace(/^([^#]*)(#.*)?$/g, '$1?utm_source=devtools$2') as Platform.DevToolsPath.UrlString;
   }
   // If the URL already contains a query, add the referrer query after the last query
   // and before (potential) anchor.
-  return url.replace(/^([^#]*)(#.*)?$/g, '$1&utm_source=devtools$2');
+  return url.replace(/^([^#]*)(#.*)?$/g, '$1&utm_source=devtools$2') as Platform.DevToolsPath.UrlString;
 }
 
 /**
  * We want to add a referrer query param to every request to
  * 'web.dev' or 'developers.google.com'.
  */
-export function addReferrerToURLIfNecessary(url: string): string {
+export function addReferrerToURLIfNecessary(url: Platform.DevToolsPath.UrlString): Platform.DevToolsPath.UrlString {
   if (/(\/\/developers.google.com\/|\/\/web.dev\/|\/\/developer.chrome.com\/)/.test(url)) {
     return addReferrerToURL(url);
   }

package/front_end/ui/legacy/XLink.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// TODO(crbug.com/1253323): Casts to UrlString will be removed from this file when migration to branded types is complete.
-
 import * as Host from '../../core/host/host.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as ComponentHelpers from '../components/helpers/helpers.js';
@@ -22,7 +20,7 @@ import {
 import {XElement} from './XElement.js';
 
 export class XLink extends XElement {
-  hrefInternal: string|null;
+  hrefInternal: Platform.DevToolsPath.UrlString|null;
   private clickable: boolean;
   private readonly onClick: (arg0: Event) => void;
   private readonly onKeyDown: (arg0: Event) => void;
@@ -54,15 +52,17 @@ export class XLink extends XElement {
 
     this.onClick = (event: Event): void => {
       event.consume(true);
-      Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
-          (this.hrefInternal as Platform.DevToolsPath.UrlString));
+      if (this.hrefInternal) {
+        Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(this.hrefInternal);
+      }
       this.dispatchEvent(new Event('x-link-invoke'));
     };
     this.onKeyDown = (event: Event): void => {
       if (isEnterOrSpaceKey(event)) {
         event.consume(true);
-        Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
-            (this.hrefInternal as Platform.DevToolsPath.UrlString));
+        if (this.hrefInternal) {
+          Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(this.hrefInternal);
+        }
       }
       this.dispatchEvent(new Event('x-link-invoke'));
     };
@@ -73,7 +73,7 @@ export class XLink extends XElement {
     return XElement.observedAttributes.concat(['href', 'no-click']);
   }
 
-  get href(): string|null {
+  get href(): Platform.DevToolsPath.UrlString|null {
     return this.hrefInternal;
   }
 
@@ -89,11 +89,11 @@ export class XLink extends XElement {
       if (!newValue) {
         newValue = '';
       }
-      let href: string|null = null;
+      let href: Platform.DevToolsPath.UrlString|null = null;
       let url: URL|null = null;
       try {
-        url = new URL(addReferrerToURLIfNecessary(newValue));
-        href = url.toString();
+        url = new URL(addReferrerToURLIfNecessary(newValue as Platform.DevToolsPath.UrlString));
+        href = url.toString() as Platform.DevToolsPath.UrlString;
       } catch {
       }
       if (url && url.protocol === 'javascript:') {
@@ -147,8 +147,7 @@ export class ContextMenuProvider implements Provider {
     const node: XLink = targetNode;
     contextMenu.revealSection().appendItem(openLinkExternallyLabel(), () => {
       if (node.href) {
-        Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
-            node.href as Platform.DevToolsPath.UrlString);
+        Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(node.href);
       }
     });
     contextMenu.revealSection().appendItem(copyLinkAddressLabel(), () => {

package/front_end/ui/legacy/components/color_picker/ContrastDetails.ts

@@ -359,10 +359,8 @@ export class ContrastDetails extends Common.ObjectWrapper.ObjectWrapper<EventTyp
   }
 
   private static showHelp(): void {
-    // TODO(crbug.com/1253323): Cast to UrlString will be removed when migration to branded types is complete.
-    Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
-        UI.UIUtils.addReferrerToURL('https://web.dev/color-and-contrast-accessibility/') as
-        Platform.DevToolsPath.UrlString);
+    Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(UI.UIUtils.addReferrerToURL(
+        'https://web.dev/color-and-contrast-accessibility/' as Platform.DevToolsPath.UrlString));
   }
 
   setVisible(visible: boolean): void {

package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts

@@ -392,7 +392,7 @@ export class ObjectPropertiesSection extends UI.TreeOutline.TreeOutlineInShadow
       const rawLocation = value.debuggerModel().createRawLocationByScriptId(
           value.value.scriptId, value.value.lineNumber, value.value.columnNumber);
       if (rawLocation && linkifier) {
-        return new ObjectPropertyValue(linkifier.linkifyRawLocation(rawLocation, ''));
+        return new ObjectPropertyValue(linkifier.linkifyRawLocation(rawLocation, Platform.DevToolsPath.EmptyUrlString));
       }
       propertyValue = new ObjectPropertyValue(createUnknownInternalLocationElement());
     } else if (type === 'string' && typeof description === 'string') {

package/front_end/ui/legacy/components/perf_ui/LineLevelProfile.ts

@@ -9,8 +9,6 @@ import * as SourceFrame from '../source_frame/source_frame.js';
 import type * as Platform from '../../../../core/platform/platform.js';
 import type * as Protocol from '../../../../generated/protocol.js';
 
-// TODO(crbug.com/1253323): Casts to UrlString will be removed from this file when migration to branded types is complete.
-
 let performanceInstance: Performance;
 
 export class Performance {

package/front_end/ui/legacy/components/utils/ImagePreview.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// TODO(crbug.com/1253323): Casts to UrlString will be removed from this file when migration to branded types is complete.
-
 import * as Common from '../../../../core/common/common.js';
 import * as Host from '../../../../core/host/host.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
@@ -116,8 +114,7 @@ export class ImagePreview {
 
         // Open image in new tab.
         link.addEventListener('click', () => {
-          Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
-              imageURL as Platform.DevToolsPath.UrlString);
+          Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(imageURL);
         });
 
         const intrinsicWidth = imageElement.naturalWidth;
@@ -162,8 +159,7 @@ export class ImagePreview {
              HTMLLinkElement);
         sourceLink.textContent = sourceText;
         sourceLink.addEventListener('click', () => {
-          Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
-              imageURL as Platform.DevToolsPath.UrlString);
+          Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(imageURL);
         });
         resolve(shadowBoundary);
       }
@@ -196,7 +192,7 @@ export class ImagePreview {
     }
   }
 
-  static defaultAltTextForImageURL(url: string): string {
+  static defaultAltTextForImageURL(url: Platform.DevToolsPath.UrlString): string {
     const parsedImageURL = new Common.ParsedURL.ParsedURL(url);
     const imageSourceText = parsedImageURL.isValid ? parsedImageURL.displayName : i18nString(UIStrings.unknownSource);
     return i18nString(UIStrings.imageFromS, {PH1: imageSourceText});

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -28,12 +28,10 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-// TODO(crbug.com/1253323): Casts to UrlString will be removed from this file when migration to branded types is complete.
-
 import * as Common from '../../../../core/common/common.js';
 import * as Host from '../../../../core/host/host.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
-import type * as Platform from '../../../../core/platform/platform.js';
+import * as Platform from '../../../../core/platform/platform.js';
 import * as SDK from '../../../../core/sdk/sdk.js';
 import * as Bindings from '../../../../models/bindings/bindings.js';
 import * as TextUtils from '../../../../models/text_utils/text_utils.js';
@@ -195,8 +193,9 @@ export class Linkifier implements SDK.TargetManager.Observer {
   }
 
   maybeLinkifyScriptLocation(
-      target: SDK.Target.Target|null, scriptId: Protocol.Runtime.ScriptId|null, sourceURL: string,
-      lineNumber: number|undefined, options?: LinkifyOptions): HTMLElement|null {
+      target: SDK.Target.Target|null, scriptId: Protocol.Runtime.ScriptId|null,
+      sourceURL: Platform.DevToolsPath.UrlString, lineNumber: number|undefined, options?: LinkifyOptions): HTMLElement
+      |null {
     let fallbackAnchor: HTMLElement|null = null;
     const linkifyURLOptions: LinkifyURLOptions = {
       lineNumber,
@@ -267,8 +266,8 @@ export class Linkifier implements SDK.TargetManager.Observer {
   }
 
   linkifyScriptLocation(
-      target: SDK.Target.Target|null, scriptId: Protocol.Runtime.ScriptId|null, sourceURL: string,
-      lineNumber: number|undefined, options?: LinkifyOptions): HTMLElement {
+      target: SDK.Target.Target|null, scriptId: Protocol.Runtime.ScriptId|null,
+      sourceURL: Platform.DevToolsPath.UrlString, lineNumber: number|undefined, options?: LinkifyOptions): HTMLElement {
     const scriptLink = this.maybeLinkifyScriptLocation(target, scriptId, sourceURL, lineNumber, options);
     const linkifyURLOptions: LinkifyURLOptions = {
       lineNumber,
@@ -283,7 +282,9 @@ export class Linkifier implements SDK.TargetManager.Observer {
     return scriptLink || Linkifier.linkifyURL(sourceURL, linkifyURLOptions);
   }
 
-  linkifyRawLocation(rawLocation: SDK.DebuggerModel.Location, fallbackUrl: string, className?: string): Element {
+  linkifyRawLocation(
+      rawLocation: SDK.DebuggerModel.Location, fallbackUrl: Platform.DevToolsPath.UrlString,
+      className?: string): Element {
     return this.linkifyScriptLocation(
         rawLocation.debuggerModel.target(), rawLocation.scriptId, fallbackUrl, rawLocation.lineNumber, {
           columnNumber: rawLocation.columnNumber,
@@ -303,7 +304,8 @@ export class Linkifier implements SDK.TargetManager.Observer {
       className: options?.className,
     };
     return this.maybeLinkifyScriptLocation(
-        target, callFrame.scriptId, callFrame.url, callFrame.lineNumber, linkifyOptions);
+        target, callFrame.scriptId, callFrame.url as Platform.DevToolsPath.UrlString, callFrame.lineNumber,
+        linkifyOptions);
   }
 
   linkifyStackTraceTopFrame(target: SDK.Target.Target, stackTrace: Protocol.Runtime.StackTrace, className?: string):
@@ -311,7 +313,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
     console.assert(stackTrace.callFrames.length > 0);
 
     const {url, lineNumber, columnNumber} = stackTrace.callFrames[0];
-    const fallbackAnchor = Linkifier.linkifyURL(url, {
+    const fallbackAnchor = Linkifier.linkifyURL(url as Platform.DevToolsPath.UrlString, {
       className,
       lineNumber,
       columnNumber,
@@ -478,7 +480,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
     info.icon = icon;
   }
 
-  static linkifyURL(url: string, options?: LinkifyURLOptions): HTMLElement {
+  static linkifyURL(url: Platform.DevToolsPath.UrlString, options?: LinkifyURLOptions): HTMLElement {
     options = options || {
       showColumnNumber: false,
       inlineFrameIndex: 0,
@@ -500,7 +502,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
       return element;
     }
 
-    let linkText = text || Bindings.ResourceUtils.displayNameForURL(url as Platform.DevToolsPath.UrlString);
+    let linkText = text || Bindings.ResourceUtils.displayNameForURL(url);
     if (typeof lineNumber === 'number' && !text) {
       linkText += ':' + (lineNumber + 1);
       if (showColumnNumber && typeof columnNumber === 'number') {
@@ -508,7 +510,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
       }
     }
     const title = linkText !== url ? url : '';
-    const linkOptions = {maxLength, title, href: url, preventClick, tabStop: options.tabStop, bypassURLTrimming};
+    const linkOptions = {maxLength, title, href: (url), preventClick, tabStop: options.tabStop, bypassURLTrimming};
     const {link, linkInfo} = Linkifier.createLink(linkText, className, linkOptions);
     if (lineNumber) {
       linkInfo.lineNumber = lineNumber;
@@ -520,11 +522,11 @@ export class Linkifier implements SDK.TargetManager.Observer {
   }
 
   static linkifyRevealable(
-      revealable: Object, text: string|HTMLElement, fallbackHref?: string, title?: string,
+      revealable: Object, text: string|HTMLElement, fallbackHref?: Platform.DevToolsPath.UrlString, title?: string,
       className?: string): HTMLElement {
     const createLinkOptions: _CreateLinkOptions = {
       maxLength: UI.UIUtils.MaxLengthForDisplayedURLs,
-      href: fallbackHref,
+      href: (fallbackHref),
       title,
     };
     const {link, linkInfo} = Linkifier.createLink(text, className || '', createLinkOptions);
@@ -708,20 +710,19 @@ export class Linkifier implements SDK.TargetManager.Observer {
       return result;
     }
 
-    let url = '';
+    let url = Platform.DevToolsPath.EmptyUrlString;
     let uiLocation: Workspace.UISourceCode.UILocation|(Workspace.UISourceCode.UILocation | null)|null = null;
     if (info.uiLocation) {
       uiLocation = info.uiLocation;
       url = uiLocation.uiSourceCode.contentURL();
     } else if (info.url) {
       url = info.url;
-      const uiSourceCode =
-          Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodeForURL(url as Platform.DevToolsPath.UrlString) ||
+      const uiSourceCode = Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodeForURL(url) ||
           Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodeForURL(
               Common.ParsedURL.ParsedURL.urlWithoutHash(url) as Platform.DevToolsPath.UrlString);
       uiLocation = uiSourceCode ? uiSourceCode.uiLocation(info.lineNumber || 0, info.columnNumber || 0) : null;
     }
-    const resource = url ? Bindings.ResourceUtils.resourceForURL(url as Platform.DevToolsPath.UrlString) : null;
+    const resource = url ? Bindings.ResourceUtils.resourceForURL(url) : null;
     const contentProvider = uiLocation ? uiLocation.uiSourceCode : resource;
 
     const revealable = info.revealable || uiLocation || resource;
@@ -756,8 +757,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
       result.push({
         section: 'reveal',
         title: UI.UIUtils.openLinkExternallyLabel(),
-        handler: (): void => Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
-            url as Platform.DevToolsPath.UrlString),
+        handler: (): void => Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(url),
       });
       result.push({
         section: 'clipboard',
@@ -953,7 +953,7 @@ export interface _LinkInfo {
   enableDecorator: boolean;
   uiLocation: Workspace.UISourceCode.UILocation|null;
   liveLocation: Bindings.LiveLocation.LiveLocation|null;
-  url: string|null;
+  url: Platform.DevToolsPath.UrlString|null;
   lineNumber: number|null;
   columnNumber: number|null;
   inlineFrameIndex: number;
@@ -987,7 +987,7 @@ export interface LinkifyOptions {
 export interface _CreateLinkOptions {
   maxLength?: number;
   title?: string;
-  href?: string;
+  href?: Platform.DevToolsPath.UrlString;
   preventClick?: boolean;
   tabStop?: boolean;
   bypassURLTrimming?: boolean;

package/front_end/ui/legacy/toolbar.css

@@ -180,7 +180,7 @@ it. */
 .toolbar-button.copied-to-clipboard::after {
   content: attr(data-content);
   position: fixed;
-  top: var(--toolbar-height);
+  margin-top: calc(2 * var(--toolbar-height));
   padding: 3px 5px;
   color: var(--color-text-secondary);
   background: var(--color-background-elevation-1);

package/front_end/ui/lit-html/lit-html.ts

@@ -9,6 +9,8 @@ export {Directive, type TemplateResult} from '../../third_party/lit-html/lit-htm
 const {render, svg, Directives, nothing, noChange} = LitHtml;
 const {html, literal, flattenTemplate} = Static;
 
+type LitTemplate = LitHtml.TemplateResult|typeof nothing;
+
 export {
   render,
   Directives,
@@ -18,4 +20,5 @@ export {
   html,
   literal,
   flattenTemplate,  // Exposed for unit testing.
+  type LitTemplate,
 };

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1000934"
+  "version": "1.0.1002543"
 }

package/scripts/eslint_rules/lib/lit_template_result_or_nothing.js

@@ -116,6 +116,10 @@ module.exports = {
     }
 
     function checkFunctionDeclarationOrExpressionForUnionType(node) {
+      if (!node.returnType) {
+        return;
+      }
+
       if (node.returnType.type !== 'TSTypeAnnotation') {
         return;
       }

package/scripts/eslint_rules/tests/lit_template_result_or_nothing_test.js

@@ -31,6 +31,19 @@ ruleTester.run('lit_template_result_or_nothing', rule, {
       code: 'function foo(): LitHtml.TemplateResult|string {}',
       filename: 'front_end/components/datagrid.ts',
     },
+    {
+      // No return type in class method should be valid
+      code: `class Foo {
+        constructor() {
+        }
+      }`,
+      filename: 'front_end/components/datagrid.ts',
+    },
+    {
+      // No return type in class method should be valid
+      code: 'function foo() {}',
+      filename: 'front_end/components/datagrid.ts',
+    },
   ],
   invalid: [
     {

package/front_end/models/issues_manager/descriptions/arInvalidAttributionSourceEventId.md

@@ -1,3 +0,0 @@
-# Ensure Attribution Source Event Id is a valid 64-bit integer
-
-An attribution source event was not recorded because the provided `attributionSourceEventId` is not a valid integer under 64 bits.

package/front_end/models/issues_manager/descriptions/arInvalidAttributionSourceExpiry.md

@@ -1,4 +0,0 @@
-# Ensure attribution source expiry is a valid number
-
-The expiry associated with an attribution source was defaulted to 30 days.
-This happens if the provided value is not a valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/arInvalidAttributionSourcePriority.md

@@ -1,4 +0,0 @@
-# Ensure attribution source priority is a valid number
-
-The priority associated with an attribution source was defaulted to `0`.
-This happens if the provided value is not a valid 64-bit signed integer.