cc-safe-setup 29.8.0 → 30.0.4

package/tests/test-skills-settings-validator.sh

@@ -0,0 +1,242 @@
+#!/bin/bash
+# Tests for skills-settings-validator.sh
+# Hook addresses issue #62421 (fabricated Skills-related settings fields).
+set -u
+
+HOOK="$(dirname "$0")/../examples/skills-settings-validator.sh"
+PASS=0
+FAIL=0
+
+TMP=$(mktemp -d /tmp/test-skills-validator.XXXXXX)
+trap 'rm -rf "$TMP"' EXIT
+
+# --- Test 1: no settings files produce no output ---
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/missing.json" bash "$HOOK")
+if [ -z "$output" ]; then
+    echo "  PASS: missing settings file produces no output"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: missing file should produce no output: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 2: empty JSON produces no output ---
+echo '{}' > "$TMP/empty.json"
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/empty.json" bash "$HOOK")
+if [ -z "$output" ]; then
+    echo "  PASS: empty JSON produces no output"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: empty JSON should produce no output: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 3: valid schema fields produce no output ---
+cat > "$TMP/valid.json" <<'EOF'
+{
+  "permissions": {"allow": [], "deny": []},
+  "env": {"FOO": "bar"},
+  "hooks": {}
+}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/valid.json" bash "$HOOK")
+if [ -z "$output" ]; then
+    echo "  PASS: valid schema fields produce no output"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: valid fields should produce no output: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 4: disabledSkills (canonical fabrication) detected ---
+cat > "$TMP/fab1.json" <<'EOF'
+{
+  "permissions": {"allow": []},
+  "disabledSkills": ["mcp-builder", "pdf"]
+}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/fab1.json" bash "$HOOK")
+if echo "$output" | grep -q "disabledSkills"; then
+    echo "  PASS: disabledSkills is flagged"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: disabledSkills should be flagged. Output: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 5: output is valid JSON ---
+if echo "$output" | jq empty 2>/dev/null; then
+    echo "  PASS: output is valid JSON"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: output is not valid JSON: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 6: output references issue #62421 ---
+if echo "$output" | grep -q "62421"; then
+    echo "  PASS: output references issue #62421"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: output should reference issue #62421"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 7: output has hookSpecificOutput.additionalContext ---
+context=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext // empty' 2>/dev/null)
+if [ -n "$context" ]; then
+    echo "  PASS: output has hookSpecificOutput.additionalContext"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: output missing hookSpecificOutput.additionalContext"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 8: enabledSkills also detected ---
+cat > "$TMP/fab2.json" <<'EOF'
+{"enabledSkills": ["only-this-one"]}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/fab2.json" bash "$HOOK")
+if echo "$output" | grep -q "enabledSkills"; then
+    echo "  PASS: enabledSkills is flagged"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: enabledSkills should be flagged"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 9: skillsConfig also detected ---
+cat > "$TMP/fab3.json" <<'EOF'
+{"skillsConfig": {"defaultEnabled": false}}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/fab3.json" bash "$HOOK")
+if echo "$output" | grep -q "skillsConfig"; then
+    echo "  PASS: skillsConfig is flagged"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: skillsConfig should be flagged"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 10: multiple fabricated fields all detected ---
+cat > "$TMP/fab4.json" <<'EOF'
+{
+  "disabledSkills": [],
+  "enabledSkills": [],
+  "skillRouting": {}
+}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/fab4.json" bash "$HOOK")
+if echo "$output" | grep -q "disabledSkills" && \
+   echo "$output" | grep -q "enabledSkills" && \
+   echo "$output" | grep -q "skillRouting"; then
+    echo "  PASS: multiple fabricated fields all flagged"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: not all fabricated fields flagged. Output: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 11: multiple files scanned ---
+cat > "$TMP/fab5a.json" <<'EOF'
+{"disabledSkills": []}
+EOF
+cat > "$TMP/fab5b.json" <<'EOF'
+{"skillFilter": ""}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/fab5a.json:$TMP/fab5b.json" bash "$HOOK")
+if echo "$output" | grep -q "disabledSkills" && \
+   echo "$output" | grep -q "skillFilter"; then
+    echo "  PASS: multiple files all scanned"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: multiple files not all scanned. Output: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 12: file path included in findings ---
+if echo "$output" | grep -q "fab5a.json" && \
+   echo "$output" | grep -q "fab5b.json"; then
+    echo "  PASS: file path included in findings"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: file path missing from findings"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 13: invalid JSON file silently skipped ---
+echo "not valid json" > "$TMP/broken.json"
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/broken.json" bash "$HOOK")
+if [ -z "$output" ]; then
+    echo "  PASS: invalid JSON silently skipped"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: invalid JSON should be silently skipped: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 14: invalid + valid mix only flags the valid ---
+cat > "$TMP/fab6.json" <<'EOF'
+{"disabledSkills": []}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/broken.json:$TMP/fab6.json" bash "$HOOK")
+if echo "$output" | grep -q "fab6.json: disabledSkills" && \
+   ! echo "$output" | grep -q "broken.json"; then
+    echo "  PASS: invalid skipped, valid flagged"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: mix handling incorrect. Output: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 15: extra patterns via env var detected ---
+cat > "$TMP/fab7.json" <<'EOF'
+{"customSkillField": "x"}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/fab7.json" CC_SKILLS_EXTRA_PATTERNS="customSkillField" bash "$HOOK")
+if echo "$output" | grep -q "customSkillField"; then
+    echo "  PASS: extra pattern via env var detected"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: extra pattern not detected. Output: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 16: extra patterns coexist with defaults ---
+cat > "$TMP/fab8.json" <<'EOF'
+{"disabledSkills": [], "myCustomField": "y"}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/fab8.json" CC_SKILLS_EXTRA_PATTERNS="myCustomField" bash "$HOOK")
+if echo "$output" | grep -q "disabledSkills" && \
+   echo "$output" | grep -q "myCustomField"; then
+    echo "  PASS: extra patterns coexist with defaults"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: extra+default coexist failed. Output: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Test 17: nested non-top-level skills key not flagged ---
+cat > "$TMP/nested.json" <<'EOF'
+{
+  "permissions": {
+    "allow": ["Skill(foo)"],
+    "deny": []
+  },
+  "env": {"disabledSkills_unused": "1"}
+}
+EOF
+output=$(echo '{}' | CC_SKILLS_SETTINGS_FILES="$TMP/nested.json" bash "$HOOK")
+if [ -z "$output" ]; then
+    echo "  PASS: nested skills mentions are not flagged"
+    PASS=$((PASS + 1))
+else
+    echo "  FAIL: nested skills mentions should not be flagged: $output"
+    FAIL=$((FAIL + 1))
+fi
+
+# --- Summary ---
+echo ""
+echo "Tests passed: $PASS"
+echo "Tests failed: $FAIL"
+[ "$FAIL" -eq 0 ]

package/tests/test-sonnet-45-deprecation-helper.sh

@@ -0,0 +1,150 @@
+#!/bin/bash
+# Tests for sonnet-45-deprecation-helper.sh
+HOOK="$(dirname "$0")/../examples/sonnet-45-deprecation-helper.sh"
+PASS=0
+FAIL=0
+
+run_test() {
+  local desc="$1"
+  local result="$2"
+  if [ "$result" = "pass" ]; then
+    echo "  PASS: $desc"
+    PASS=$((PASS + 1))
+  else
+    echo "  FAIL: $desc"
+    FAIL=$((FAIL + 1))
+  fi
+}
+
+echo "Testing sonnet-45-deprecation-helper.sh"
+echo "========================================"
+
+# Test 1: QUIET=1 always silences, regardless of other state
+OUT=$(CC_SONNET_45_HELPER_QUIET=1 CC_SONNET_45_HELPER_REMIND=1 \
+  bash "$HOOK" 2>&1)
+EXIT=$?
+if [ "$EXIT" = "0" ] && [ -z "$OUT" ]; then
+  run_test "QUIET=1 silences even with REMIND=1" pass
+else
+  run_test "QUIET=1 silences even with REMIND=1 (exit=$EXIT, out_len=${#OUT})" fail
+fi
+
+# Test 2: ANTHROPIC_MODEL explicitly set to 4.5 → silent
+OUT=$(unset CC_SONNET_45_HELPER_REMIND CC_SONNET_45_HELPER_QUIET; \
+  ANTHROPIC_MODEL=claude-sonnet-4-5-20250929 bash "$HOOK" 2>&1)
+EXIT=$?
+if [ "$EXIT" = "0" ] && [ -z "$OUT" ]; then
+  run_test "ANTHROPIC_MODEL=4.5 silences" pass
+else
+  run_test "ANTHROPIC_MODEL=4.5 silences (exit=$EXIT, out_len=${#OUT})" fail
+fi
+
+# Test 3: ANTHROPIC_MODEL explicitly set to 4.6 → silent
+OUT=$(unset CC_SONNET_45_HELPER_REMIND CC_SONNET_45_HELPER_QUIET; \
+  ANTHROPIC_MODEL=claude-sonnet-4-6 bash "$HOOK" 2>&1)
+EXIT=$?
+if [ "$EXIT" = "0" ] && [ -z "$OUT" ]; then
+  run_test "ANTHROPIC_MODEL=4.6 silences" pass
+else
+  run_test "ANTHROPIC_MODEL=4.6 silences (exit=$EXIT, out_len=${#OUT})" fail
+fi
+
+# Test 4: ANTHROPIC_MODEL set to any non-empty value → silent (treated as deliberate)
+OUT=$(unset CC_SONNET_45_HELPER_REMIND CC_SONNET_45_HELPER_QUIET; \
+  ANTHROPIC_MODEL=claude-opus-4-7 bash "$HOOK" 2>&1)
+EXIT=$?
+if [ "$EXIT" = "0" ] && [ -z "$OUT" ]; then
+  run_test "ANTHROPIC_MODEL=opus silences (any non-empty value)" pass
+else
+  run_test "ANTHROPIC_MODEL=opus silences (exit=$EXIT, out_len=${#OUT})" fail
+fi
+
+# Test 5: ANTHROPIC_MODEL unset and REMIND unset → silent (opt-in only, default off)
+OUT=$(unset ANTHROPIC_MODEL CC_SONNET_45_HELPER_REMIND CC_SONNET_45_HELPER_QUIET; \
+  bash "$HOOK" 2>&1)
+EXIT=$?
+if [ "$EXIT" = "0" ] && [ -z "$OUT" ]; then
+  run_test "ANTHROPIC_MODEL unset, REMIND unset → silent (opt-in default)" pass
+else
+  run_test "ANTHROPIC_MODEL unset, REMIND unset → silent (exit=$EXIT, out_len=${#OUT})" fail
+fi
+
+# Test 6: ANTHROPIC_MODEL unset and REMIND=1 → emit reminder
+OUT=$(unset ANTHROPIC_MODEL CC_SONNET_45_HELPER_QUIET; \
+  CC_SONNET_45_HELPER_REMIND=1 bash "$HOOK" 2>&1)
+EXIT=$?
+if [ "$EXIT" = "0" ] && echo "$OUT" | grep -q "ANTHROPIC_MODEL is unset"; then
+  run_test "ANTHROPIC_MODEL unset, REMIND=1 → reminder emitted" pass
+else
+  run_test "ANTHROPIC_MODEL unset, REMIND=1 → reminder emitted (exit=$EXIT, out=$OUT)" fail
+fi
+
+# Test 7: Reminder includes the 4.5 model ID
+OUT=$(unset ANTHROPIC_MODEL CC_SONNET_45_HELPER_QUIET; \
+  CC_SONNET_45_HELPER_REMIND=1 bash "$HOOK" 2>&1)
+if echo "$OUT" | grep -q "claude-sonnet-4-5-20250929"; then
+  run_test "Reminder contains the 4.5 model ID for explicit pinning" pass
+else
+  run_test "Reminder contains the 4.5 model ID" fail
+fi
+
+# Test 8: Reminder mentions the QUIET env var for suppression
+OUT=$(unset ANTHROPIC_MODEL CC_SONNET_45_HELPER_QUIET; \
+  CC_SONNET_45_HELPER_REMIND=1 bash "$HOOK" 2>&1)
+if echo "$OUT" | grep -q "CC_SONNET_45_HELPER_QUIET"; then
+  run_test "Reminder explains how to suppress" pass
+else
+  run_test "Reminder explains how to suppress" fail
+fi
+
+# Test 9: Reminder references the operator-side paths Gist
+OUT=$(unset ANTHROPIC_MODEL CC_SONNET_45_HELPER_QUIET; \
+  CC_SONNET_45_HELPER_REMIND=1 bash "$HOOK" 2>&1)
+if echo "$OUT" | grep -q "gist.github.com/yurukusa/29d9c3ba62aa514450ba04fccc566161"; then
+  run_test "Reminder links to the 5-paths Gist" pass
+else
+  run_test "Reminder links to the 5-paths Gist" fail
+fi
+
+# Test 10: ANTHROPIC_MODEL set to empty string is treated as unset (per [-n] semantics)
+OUT=$(unset CC_SONNET_45_HELPER_QUIET; ANTHROPIC_MODEL="" CC_SONNET_45_HELPER_REMIND=1 bash "$HOOK" 2>&1)
+EXIT=$?
+if [ "$EXIT" = "0" ] && echo "$OUT" | grep -q "ANTHROPIC_MODEL is unset"; then
+  run_test "ANTHROPIC_MODEL='' (empty) → reminder emitted (treated as unset)" pass
+else
+  run_test "ANTHROPIC_MODEL='' (empty) → reminder emitted (exit=$EXIT)" fail
+fi
+
+# Test 11: Multiple invocations are idempotent (no state leaked between runs)
+OUT1=$(unset ANTHROPIC_MODEL CC_SONNET_45_HELPER_QUIET; \
+  CC_SONNET_45_HELPER_REMIND=1 bash "$HOOK" 2>&1)
+OUT2=$(unset ANTHROPIC_MODEL CC_SONNET_45_HELPER_QUIET; \
+  CC_SONNET_45_HELPER_REMIND=1 bash "$HOOK" 2>&1)
+if [ "$OUT1" = "$OUT2" ]; then
+  run_test "Idempotent: two invocations produce identical output" pass
+else
+  run_test "Idempotent: two invocations produce identical output" fail
+fi
+
+# Test 12: Hook never blocks (always exits 0)
+EXIT_CODES=""
+for case in "QUIET=1" "ANTHROPIC_MODEL=4.5" "ANTHROPIC_MODEL=4.6" "all-unset" "REMIND=1"; do
+  case "$case" in
+    "QUIET=1") OUT=$(CC_SONNET_45_HELPER_QUIET=1 bash "$HOOK" 2>&1); EXIT=$? ;;
+    "ANTHROPIC_MODEL=4.5") OUT=$(unset CC_SONNET_45_HELPER_REMIND CC_SONNET_45_HELPER_QUIET; ANTHROPIC_MODEL=claude-sonnet-4-5-20250929 bash "$HOOK" 2>&1); EXIT=$? ;;
+    "ANTHROPIC_MODEL=4.6") OUT=$(unset CC_SONNET_45_HELPER_REMIND CC_SONNET_45_HELPER_QUIET; ANTHROPIC_MODEL=claude-sonnet-4-6 bash "$HOOK" 2>&1); EXIT=$? ;;
+    "all-unset") OUT=$(unset ANTHROPIC_MODEL CC_SONNET_45_HELPER_REMIND CC_SONNET_45_HELPER_QUIET; bash "$HOOK" 2>&1); EXIT=$? ;;
+    "REMIND=1") OUT=$(unset ANTHROPIC_MODEL CC_SONNET_45_HELPER_QUIET; CC_SONNET_45_HELPER_REMIND=1 bash "$HOOK" 2>&1); EXIT=$? ;;
+  esac
+  EXIT_CODES="$EXIT_CODES $EXIT"
+done
+NONZERO=$(echo "$EXIT_CODES" | tr ' ' '\n' | grep -v "^$" | grep -v "^0$" | head -1)
+if [ -z "$NONZERO" ]; then
+  run_test "Hook never blocks (all paths exit 0)" pass
+else
+  run_test "Hook never blocks (exit codes: $EXIT_CODES)" fail
+fi
+
+echo "========================================"
+echo "Results: $PASS passed, $FAIL failed"
+[ "$FAIL" = "0" ] && exit 0 || exit 1

package/tests/test-spurious-malformed-notice-detector.sh

@@ -0,0 +1,290 @@
+#!/bin/bash
+# Tests for spurious-malformed-notice-detector.sh
+HOOK="examples/spurious-malformed-notice-detector.sh"
+PASS=0 FAIL=0
+TMPDIR=$(mktemp -d)
+STATE_DIR="$TMPDIR/state"
+trap "rm -rf $TMPDIR" EXIT
+
+assert_contains() { if echo "$2" | grep -q "$3"; then PASS=$((PASS+1)); else FAIL=$((FAIL+1)); echo "FAIL: $1 (expected '$3' in output)"; fi; }
+assert_not_contains() { if ! echo "$2" | grep -q "$3"; then PASS=$((PASS+1)); else FAIL=$((FAIL+1)); echo "FAIL: $1 (unexpected '$3' in output)"; fi; }
+assert_exit() { if [ "$2" = "$3" ]; then PASS=$((PASS+1)); else FAIL=$((FAIL+1)); echo "FAIL: $1 (expected exit $3, got $2)"; fi; }
+
+HOOK_ABS="$PWD/$HOOK"
+
+reset_state() { rm -rf "$STATE_DIR"; mkdir -p "$STATE_DIR"; }
+
+mk_input() {
+    local transcript="$1" sid="${2:-test-session}"
+    printf '{"transcript_path":"%s","session_id":"%s"}' "$transcript" "$sid"
+}
+
+# A user-turn line carrying a successful tool_result block
+# (no is_error, or is_error=false). This is the "tool actually
+# succeeded" half of the 12C signature.
+mk_success_result() {
+    printf '{"message":{"role":"user","content":[{"type":"tool_result","tool_use_id":"t1","content":"ok"}]}}\n'
+}
+
+# A user-turn line carrying a tool_result with is_error=false
+# explicitly set. Must still count as success.
+mk_success_result_explicit() {
+    printf '{"message":{"role":"user","content":[{"type":"tool_result","tool_use_id":"t1","content":"ok","is_error":false}]}}\n'
+}
+
+# A user-turn line carrying a tool_result with is_error=true.
+# Must NOT count as success.
+mk_failed_result() {
+    printf '{"message":{"role":"user","content":[{"type":"tool_result","tool_use_id":"t1","content":"err","is_error":true}]}}\n'
+}
+
+# A top-level (non-.message) tool_result line — must be detected too.
+mk_success_result_top() {
+    printf '{"role":"user","content":[{"type":"tool_result","tool_use_id":"t2","content":"ok"}]}\n'
+}
+
+# A system-style line carrying the spurious-malformed marker.
+mk_marker() {
+    printf '{"role":"system","content":"Your tool call was malformed and could not be parsed. Please retry."}\n'
+}
+
+# An ordinary assistant turn with no marker.
+mk_plain() {
+    printf '{"message":{"role":"assistant","content":"hello"}}\n'
+}
+
+# Test 1: No transcript path → silent pass
+reset_state
+OUT=$(echo '{}' | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "no transcript silent" "$OUT" "sub-pattern 12C"
+assert_exit "no transcript exit 0" "$RC" "0"
+
+# Test 2: Missing transcript file → silent pass
+reset_state
+OUT=$(mk_input "/nonexistent/transcript.jsonl" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "missing transcript silent" "$OUT" "sub-pattern 12C"
+assert_exit "missing transcript exit 0" "$RC" "0"
+
+# Test 3: No marker, only successes → silent pass
+reset_state
+TR="$TMPDIR/t3.jsonl"
+mk_success_result > "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "no marker silent" "$OUT" "sub-pattern 12C"
+assert_exit "no marker exit 0" "$RC" "0"
+
+# Test 4: Marker present but no successful tool_results → silent
+# (this is the 12A-shaped state — let the 12A hook handle it)
+reset_state
+TR="$TMPDIR/t4.jsonl"
+mk_marker > "$TR"
+mk_marker >> "$TR"
+mk_failed_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "marker without success silent" "$OUT" "sub-pattern 12C"
+assert_exit "marker without success exit 0" "$RC" "0"
+
+# Test 5: One marker + one success → 12C advisory fires
+reset_state
+TR="$TMPDIR/t5.jsonl"
+mk_marker > "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_contains "marker + success fires advisory" "$OUT" "sub-pattern 12C"
+assert_contains "advisory cites #62700" "$OUT" "#62700"
+assert_contains "advisory cites #62123" "$OUT" "#62123"
+assert_contains "advisory differentiates from 12A" "$OUT" "12A"
+assert_contains "advisory differentiates from 12B" "$OUT" "12B"
+assert_contains "advisory warns not to /clear" "$OUT" "Do NOT /clear"
+assert_contains "advisory cites cluster tracker" "$OUT" "cluster-tracker"
+assert_exit "marker + success exit 0" "$RC" "0"
+
+# Test 6: Multiple markers and at least as many successes → fires
+reset_state
+TR="$TMPDIR/t6.jsonl"
+mk_marker > "$TR"
+mk_success_result >> "$TR"
+mk_marker >> "$TR"
+mk_success_result >> "$TR"
+mk_marker >> "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_contains "3 markers + 3 successes fires" "$OUT" "sub-pattern 12C"
+assert_contains "advisory shows marker count" "$OUT" "3 \"malformed"
+assert_contains "advisory shows success count" "$OUT" "3 successful"
+assert_exit "3+3 exit 0" "$RC" "0"
+
+# Test 7: Marker count > success count → silent (the 12A case)
+reset_state
+TR="$TMPDIR/t7.jsonl"
+mk_marker > "$TR"
+mk_marker >> "$TR"
+mk_marker >> "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "3 markers + 1 success silent" "$OUT" "sub-pattern 12C"
+assert_exit "3+1 exit 0" "$RC" "0"
+
+# Test 8: Equal marker and success counts → fires (boundary)
+reset_state
+TR="$TMPDIR/t8.jsonl"
+mk_marker > "$TR"
+mk_marker >> "$TR"
+mk_success_result >> "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_contains "equal counts fires" "$OUT" "sub-pattern 12C"
+assert_exit "equal counts exit 0" "$RC" "0"
+
+# Test 9: Disabled via env → silent even with signature
+reset_state
+TR="$TMPDIR/t9.jsonl"
+mk_marker > "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_DISABLE=1 CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "disable env silences" "$OUT" "sub-pattern 12C"
+assert_exit "disable env exit 0" "$RC" "0"
+
+# Test 10: Threshold raised to 2 with only 1 marker → silent
+reset_state
+TR="$TMPDIR/t10.jsonl"
+mk_marker > "$TR"
+mk_success_result >> "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_THRESHOLD=2 CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "threshold 2 with 1 marker silent" "$OUT" "sub-pattern 12C"
+assert_exit "threshold 2 with 1 exit 0" "$RC" "0"
+
+# Test 11: Explicit is_error=false counted as success
+reset_state
+TR="$TMPDIR/t11.jsonl"
+mk_marker > "$TR"
+mk_success_result_explicit >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_contains "explicit is_error=false counted" "$OUT" "sub-pattern 12C"
+assert_exit "explicit is_error=false exit 0" "$RC" "0"
+
+# Test 12: is_error=true does NOT count as success
+reset_state
+TR="$TMPDIR/t12.jsonl"
+mk_marker > "$TR"
+mk_failed_result >> "$TR"
+mk_failed_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "is_error=true not counted" "$OUT" "sub-pattern 12C"
+assert_exit "is_error=true exit 0" "$RC" "0"
+
+# Test 13: Top-level (non-.message) shape detected
+reset_state
+TR="$TMPDIR/t13.jsonl"
+mk_marker > "$TR"
+mk_success_result_top >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_contains "top-level shape detected" "$OUT" "sub-pattern 12C"
+assert_exit "top-level shape exit 0" "$RC" "0"
+
+# Test 14: Cooldown — second call within cooldown stays silent
+reset_state
+TR="$TMPDIR/t14.jsonl"
+mk_marker > "$TR"
+mk_success_result >> "$TR"
+OUT1=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1)
+OUT2=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1)
+assert_contains "first call fires" "$OUT1" "sub-pattern 12C"
+assert_not_contains "second call within cooldown silent" "$OUT2" "sub-pattern 12C"
+
+# Test 15: Cooldown — past cooldown refires
+reset_state
+TR="$TMPDIR/t15.jsonl"
+mk_marker > "$TR"
+mk_success_result >> "$TR"
+OUT1=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_COOLDOWN=2 CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1)
+# Two no-op calls advance the counter (force silent via high threshold)
+mk_input "$TR" | CC_SPURIOUS_MALFORMED_COOLDOWN=2 CC_SPURIOUS_MALFORMED_THRESHOLD=999 CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>/dev/null
+mk_input "$TR" | CC_SPURIOUS_MALFORMED_COOLDOWN=2 CC_SPURIOUS_MALFORMED_THRESHOLD=999 CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>/dev/null
+OUT2=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_COOLDOWN=2 CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1)
+assert_contains "first call fires" "$OUT1" "sub-pattern 12C"
+assert_contains "third call past cooldown refires" "$OUT2" "sub-pattern 12C"
+
+# Test 16: Different sessions have independent state
+reset_state
+TR="$TMPDIR/t16.jsonl"
+mk_marker > "$TR"
+mk_success_result >> "$TR"
+OUT_A=$(mk_input "$TR" "session-A" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1)
+OUT_B=$(mk_input "$TR" "session-B" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1)
+assert_contains "session A fires" "$OUT_A" "sub-pattern 12C"
+assert_contains "session B fires independently" "$OUT_B" "sub-pattern 12C"
+
+# Test 17: Lookback window excludes earlier markers
+reset_state
+TR="$TMPDIR/t17.jsonl"
+mk_marker > "$TR"
+mk_success_result >> "$TR"
+for i in $(seq 1 50); do
+    mk_plain >> "$TR"
+done
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_LOOKBACK=10 CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "lookback excludes old signature" "$OUT" "sub-pattern 12C"
+assert_exit "lookback exclude exit 0" "$RC" "0"
+
+# Test 18: Lookback window includes recent signature
+reset_state
+TR="$TMPDIR/t18.jsonl"
+for i in $(seq 1 5); do
+    mk_plain >> "$TR"
+done
+mk_marker >> "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_LOOKBACK=5 CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_contains "lookback includes recent" "$OUT" "sub-pattern 12C"
+assert_exit "lookback include exit 0" "$RC" "0"
+
+# Test 19: Non-JSON lines tolerated; signature still detected
+reset_state
+TR="$TMPDIR/t19.jsonl"
+echo "garbage line not json" > "$TR"
+mk_marker >> "$TR"
+echo "more garbage" >> "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_contains "non-json lines tolerated" "$OUT" "sub-pattern 12C"
+assert_exit "non-json tolerated exit 0" "$RC" "0"
+
+# Test 20: Mixed successful and failed results — only successes count
+reset_state
+TR="$TMPDIR/t20.jsonl"
+mk_marker > "$TR"
+mk_marker >> "$TR"
+mk_success_result >> "$TR"
+mk_failed_result >> "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_contains "mixed results fires (2 success >= 2 markers)" "$OUT" "sub-pattern 12C"
+assert_contains "shows accurate success count" "$OUT" "2 successful"
+assert_exit "mixed results exit 0" "$RC" "0"
+
+# Test 21: Plain assistant turns without tool_result blocks ignored
+reset_state
+TR="$TMPDIR/t21.jsonl"
+mk_marker > "$TR"
+mk_plain >> "$TR"
+mk_plain >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1); RC=$?
+assert_not_contains "marker + plain assistant silent" "$OUT" "sub-pattern 12C"
+assert_exit "marker + plain assistant exit 0" "$RC" "0"
+
+# Test 22: Advisory explains verification path
+reset_state
+TR="$TMPDIR/t22.jsonl"
+mk_marker > "$TR"
+mk_success_result >> "$TR"
+OUT=$(mk_input "$TR" | CC_SPURIOUS_MALFORMED_STATE_DIR="$STATE_DIR" bash "$HOOK_ABS" 2>&1)
+assert_contains "advisory mentions verification path" "$OUT" "Verify"
+assert_contains "advisory mentions continue workaround" "$OUT" "continue"
+
+echo ""
+echo "PASSED: $PASS"
+echo "FAILED: $FAIL"
+[ "$FAIL" -eq 0 ]