canvas-datagrid 0.25.4 → 0.26.0

package/lib/touch.js

@@ -144,41 +144,6 @@ export default function (self) {
   self.touchEditCell = function (cell) {
     self.beginEditAt(cell.columnIndex, cell.rowIndex);
   };
-  self.touchCell = function (e) {
-    return function () {
-      clearInterval(self.calculatePPSTimer);
-      var i,
-        pos = self.getTouchPos(e);
-      if (
-        Math.abs(self.touchDelta.x) + Math.abs(self.touchDelta.y) <
-        self.attributes.touchDeadZone
-      ) {
-        i = self.getCellAt(pos.x, pos.y);
-        if (!i) {
-          return;
-        }
-        if (
-          self.touchingCell &&
-          self.touchingCell.rowIndex === i.rowIndex &&
-          self.touchingCell.columnIndex === i.columnIndex
-        ) {
-          self.touchEditCell(i);
-          return;
-        }
-        if (self.input && self.input.editCell) {
-          self.endEdit();
-        }
-        self.touchingCell = i;
-        self.selectArea({
-          top: i.rowIndex,
-          bottom: i.rowIndex,
-          left: i.columnIndex,
-          right: i.columnIndex,
-        });
-        self.draw(true);
-      }
-    };
-  };
   self.touchstart = function (e) {
     if (e.changedTouches[0]) {
       self.touchStart = self.getTouchPos(e);
@@ -187,6 +152,10 @@ export default function (self) {
         self.touchStart.y,
         true,
       );
+    } else {
+      // nothing to start from (#554)
+      self.startingCell = undefined;
+      return;
     }
     if (
       self.dispatchEvent('touchstart', {
@@ -203,7 +172,6 @@ export default function (self) {
     self.stopAnimation = true;
     self.animationFrames = 0;
     self.stopPropagation(e);
-    e.preventDefault();
     if (e.touches.length === 1 && e.changedTouches[0] && !self.zoomAltered) {
       self.touchLength = 1;
       self.touchStart = self.touchStart || self.touchStart1;
@@ -245,7 +213,7 @@ export default function (self) {
         return;
       }
       self.hasFocus = true;
-      if (self.startingCell.isHeader) {
+      if (self.startingCell && self.startingCell.isHeader) {
         if (self.startingCell.isRowHeader) {
           self.selectArea({
             top: self.startingCell.rowIndex,
@@ -264,10 +232,13 @@ export default function (self) {
             }
             self.order(self.startingCell.header.name, self.orderDirection);
           }
-          if (self.attributes.columnHeaderClickBehavior === 'select') {
+          if (
+            self.attributes.columnHeaderClickBehavior === 'select' &&
+            self.attributes.allowColumnSelection
+          ) {
             self.selectArea({
               top: 0,
-              bottom: self.data.length - 1,
+              bottom: self.viewData.length - 1,
               left: self.startingCell.columnIndex,
               right: self.startingCell.columnIndex,
             });
@@ -425,21 +396,24 @@ export default function (self) {
     ) {
       touchScroll();
     }
-    if (/vertical-scroll-/.test(self.startingCell.style)) {
+    // the starting cell can be missing when the touch began off-grid (#554)
+    var startingCellStyle =
+      (self.startingCell && self.startingCell.style) || '';
+    if (/vertical-scroll-/.test(startingCellStyle)) {
       self.scrollBox.scrollTop =
         self.scrollBox.scrollHeight *
         ((self.touchPosition.y - ch - sbw) /
           (self.scrollBox.height - sbw - ch));
       return;
     }
-    if (/horizontal-scroll-/.test(self.startingCell.style)) {
+    if (/horizontal-scroll-/.test(startingCellStyle)) {
       self.scrollBox.scrollLeft =
         self.scrollBox.scrollWidth *
         ((self.touchPosition.x - rw - sbw) / (self.scrollBox.width - sbw - rw));
       return;
     }
-    if (/selection-handle-/.test(self.startingCell.style)) {
-      self.touchSelect(self.currentCell, self.startingCell.style);
+    if (/selection-handle-/.test(startingCellStyle)) {
+      self.touchSelect(self.currentCell, startingCellStyle);
       return;
     }
     self.scrollBox.scrollTo(
@@ -509,13 +483,12 @@ export default function (self) {
     self.touchAnimateTo.y =
       self.yPPS * self.attributes.touchReleaseAcceleration;
     self.calculatePPSTimed();
-    if (dz && !self.contextMenu) {
-      self.touchCell(self.touchStartEvent)();
-    } else if (
+    if (
+      !dz &&
       self.animationFrames === 0 &&
       (Math.abs(self.xPPST) > self.attributes.scrollAnimationPPSThreshold ||
         Math.abs(self.yPPST) > self.attributes.scrollAnimationPPSThreshold) &&
-      !/-scroll-/.test(self.startingCell.style) &&
+      !/-scroll-/.test((self.startingCell && self.startingCell.style) || '') &&
       !dz
     ) {
       self.stopAnimation = false;

package/package.json

@@ -1,17 +1,25 @@
 {
   "name": "canvas-datagrid",
-  "version": "0.25.4",
-  "description": "Canvas based data grid web component.  Capable of displaying millions of contiguous hierarchical rows and columns without paging or loading, on a single canvas element.",
+  "version": "0.26.0",
+  "description": "Canvas based data grid web component. Capable of displaying millions of contiguous hierarchical rows and columns without paging or loading, on a single canvas element.",
   "main": "./dist/canvas-datagrid.js",
   "module": "./dist/canvas-datagrid.module.js",
   "scripts": {
     "build": "rollup -c && webpack",
-    "build-docs": "rm -rf docs; npm run build; jsdoc -c ./jsdoc.conf.js; cp dist/canvas-datagrid.* docs/; cp -r tutorials/* images docs/",
+    "postbuild": "npm run build:types",
+    "prebuild:docs": "node docs/jsdoc-to-md.js",
+    "build:docs": "cd docs && npm run build",
     "format": "prettier lib/**/*.js --write",
     "lint": "eslint lib",
-    "test": "npm run build; karma start",
-    "watch": "webpack --watch"
+    "test": "npm run build && npm run test:types && npm run test:bundle && karma start",
+    "test:watch": "karma start --no-single-run",
+    "watch": "webpack --watch",
+    "build:types": "jsdoc -c ./jsdoc.ts.conf.js && node ./scripts/finalize-types.js",
+    "start": "webpack serve --open",
+    "test:types": "tsc -p ./test/types/tsconfig.json",
+    "test:bundle": "node ./scripts/check-no-eval.js"
   },
+  "types": "./dist/types.d.ts",
   "files": [
     "dist/*",
     "lib/*",
@@ -34,7 +42,8 @@
     "component"
   ],
   "browserslist": [
-    "defaults"
+    "defaults",
+    "not IE 11"
   ],
   "author": "Tony Germaneri <Tony.Germaneri@gmail.com>",
   "contributors": [
@@ -66,26 +75,31 @@
     "@rollup/plugin-node-resolve": "^10.0.0",
     "@rollup/plugin-replace": "^2.3.4",
     "babel-loader": "^8.2.1",
+    "chai": "^4.2.0",
     "eslint": "^7.14.0",
     "eslint-config-prettier": "^6.15.0",
     "eslint-plugin-prettier": "^3.1.4",
-    "husky": "^4.3.0",
+    "husky": "^8.0.3",
     "istanbul": "^0.4.5",
     "jsdoc": "^3.6.6",
-    "karma": "^5.2.3",
+    "karma": "^6.3.14",
+    "karma-chai": "^0.1.0",
     "karma-chrome-launcher": "^3.1.0",
     "karma-coverage": "^2.0.2",
     "karma-coverage-istanbul-reporter": "^3.0.2",
     "karma-mocha": "^2.0.1",
-    "lint-staged": "^10.5.2",
+    "lint-staged": "^13.2.1",
     "marked": "^1.2.5",
     "mocha": "^8.2.1",
     "prettier": "^2.2.0",
     "rollup": "^2.33.3",
     "rollup-plugin-clear": "^2.0.7",
     "rollup-plugin-terser": "^7.0.2",
+    "tsd-jsdoc": "^2.5.0",
+    "typescript": "^5.9.3",
     "webpack": "^5.6.0",
-    "webpack-cli": "^4.2.0"
+    "webpack-cli": "^4.2.0",
+    "webpack-dev-server": "^3.11.1"
   },
   "dependencies": {
     "is-printable-key-event": "1.0.0"