bmad-plus 0.12.0 → 0.12.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (160) hide show
  1. package/CHANGELOG.md +612 -554
  2. package/README.md +557 -577
  3. package/osint-agent-package/agents/osint-investigator.md +12 -0
  4. package/osint-agent-package/skills/bmad-osint-investigate/osint/SKILL.md +491 -482
  5. package/osint-agent-package/skills/bmad-osint-investigate/osint/assets/dossier-template.md +126 -126
  6. package/osint-agent-package/skills/bmad-osint-investigate/osint/assets/lawful-basis-record.md +48 -48
  7. package/osint-agent-package/skills/bmad-osint-investigate/osint/references/content-extraction.md +100 -100
  8. package/osint-agent-package/skills/bmad-osint-investigate/osint/references/gdpr-osint.md +48 -48
  9. package/osint-agent-package/skills/bmad-osint-investigate/osint/references/platforms.md +130 -130
  10. package/osint-agent-package/skills/bmad-osint-investigate/osint/references/psychoprofile.md +69 -69
  11. package/osint-agent-package/skills/bmad-osint-investigate/osint/references/tools.md +281 -281
  12. package/osint-agent-package/skills/bmad-osint-investigate/osint/scripts/mcp-client.py +136 -136
  13. package/package.json +104 -91
  14. package/readme-international/README.de.md +596 -589
  15. package/readme-international/README.es.md +613 -606
  16. package/readme-international/README.fr.md +611 -604
  17. package/src/bmad-plus/agents/agent-shadow/SKILL.md +18 -0
  18. package/src/bmad-plus/data/role-triggers.yaml +52 -0
  19. package/src/bmad-plus/module.yaml +283 -283
  20. package/src/bmad-plus/packs/pack-animated/animated-website-agent.md +325 -325
  21. package/src/bmad-plus/packs/pack-animated/templates/animated-website-workflow.md +55 -55
  22. package/src/bmad-plus/packs/pack-backup/backup-agent.md +71 -71
  23. package/src/bmad-plus/packs/pack-backup/templates/backup-workflow.md +51 -51
  24. package/src/bmad-plus/packs/pack-dev-studio/README.md +162 -162
  25. package/src/bmad-plus/packs/pack-dev-studio/categories/analysis/analyst-agent.md +73 -73
  26. package/src/bmad-plus/packs/pack-dev-studio/categories/analysis/document-project.md +61 -61
  27. package/src/bmad-plus/packs/pack-dev-studio/categories/analysis/domain-research.md +95 -95
  28. package/src/bmad-plus/packs/pack-dev-studio/categories/analysis/market-research.md +95 -95
  29. package/src/bmad-plus/packs/pack-dev-studio/categories/analysis/prfaq.md +134 -134
  30. package/src/bmad-plus/packs/pack-dev-studio/categories/analysis/product-brief.md +80 -80
  31. package/src/bmad-plus/packs/pack-dev-studio/categories/analysis/tech-writer-agent.md +73 -73
  32. package/src/bmad-plus/packs/pack-dev-studio/categories/analysis/technical-research.md +95 -95
  33. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/architect-agent.md +73 -73
  34. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/create-architecture.md +73 -73
  35. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/create-epics-stories.md +92 -92
  36. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/generate-project-context.md +80 -80
  37. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/implementation-readiness.md +90 -90
  38. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/steps/step-01-init.md +153 -153
  39. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/steps/step-01b-continue.md +173 -173
  40. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/steps/step-02-context.md +224 -224
  41. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/steps/step-03-starter.md +329 -329
  42. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/steps/step-04-decisions.md +318 -318
  43. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/steps/step-05-patterns.md +359 -359
  44. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/steps/step-06-structure.md +379 -379
  45. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/steps/step-07-validation.md +361 -361
  46. package/src/bmad-plus/packs/pack-dev-studio/categories/architecture/steps/step-08-complete.md +81 -81
  47. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/checkpoint-preview.md +67 -67
  48. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/code-review-steps/step-01-gather-context.md +85 -85
  49. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/code-review-steps/step-02-review.md +35 -35
  50. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/code-review-steps/step-03-triage.md +49 -49
  51. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/code-review-steps/step-04-present.md +131 -131
  52. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/code-review.md +89 -89
  53. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/correct-course.md +300 -300
  54. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/create-story.md +428 -428
  55. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/dev-agent.md +73 -73
  56. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/dev-story-checklist.md +80 -80
  57. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/dev-story.md +484 -484
  58. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/investigate.md +193 -193
  59. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/qa-e2e-tests.md +175 -175
  60. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/quick-dev.md +110 -110
  61. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/retrospective.md +1511 -1511
  62. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/sprint-planning.md +298 -298
  63. package/src/bmad-plus/packs/pack-dev-studio/categories/implementation/sprint-status.md +296 -296
  64. package/src/bmad-plus/packs/pack-dev-studio/categories/planning/create-prd.md +29 -29
  65. package/src/bmad-plus/packs/pack-dev-studio/categories/planning/create-ux-design.md +74 -74
  66. package/src/bmad-plus/packs/pack-dev-studio/categories/planning/edit-prd.md +29 -29
  67. package/src/bmad-plus/packs/pack-dev-studio/categories/planning/pm-agent.md +73 -73
  68. package/src/bmad-plus/packs/pack-dev-studio/categories/planning/prd.md +89 -89
  69. package/src/bmad-plus/packs/pack-dev-studio/categories/planning/ux-designer-agent.md +73 -73
  70. package/src/bmad-plus/packs/pack-dev-studio/categories/planning/validate-prd.md +29 -29
  71. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/advanced-elicitation.md +141 -141
  72. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/adversarial-review.md +37 -37
  73. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/bmad-help.md +75 -75
  74. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/brainstorming.md +6 -6
  75. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/customize.md +110 -110
  76. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/distillator.md +176 -176
  77. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/edge-case-hunter.md +67 -67
  78. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/editorial-review-prose.md +86 -86
  79. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/editorial-review-structure.md +179 -179
  80. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/index-docs.md +66 -66
  81. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/party-mode.md +127 -127
  82. package/src/bmad-plus/packs/pack-dev-studio/categories/utilities/shard-doc.md +105 -105
  83. package/src/bmad-plus/packs/pack-dev-studio/dev-studio-orchestrator.md +120 -120
  84. package/src/bmad-plus/packs/pack-dev-studio/shared/architecture-decision-template.md +12 -12
  85. package/src/bmad-plus/packs/pack-dev-studio/shared/bwml-spec.md +328 -328
  86. package/src/bmad-plus/packs/pack-dev-studio/shared/module-help.csv +32 -32
  87. package/src/bmad-plus/packs/pack-dev-studio/upstream-sync.yaml +81 -81
  88. package/src/bmad-plus/packs/pack-memory/shared/memory-protocol.md +14 -0
  89. package/src/bmad-plus/packs/pack-seo/SKILL.md +171 -171
  90. package/src/bmad-plus/packs/pack-seo/checklist.md +140 -140
  91. package/src/bmad-plus/packs/pack-seo/pagespeed-playbook.md +320 -320
  92. package/src/bmad-plus/packs/pack-seo/ref/audit-schema.json +187 -187
  93. package/src/bmad-plus/packs/pack-seo/ref/cwv-thresholds.md +87 -87
  94. package/src/bmad-plus/packs/pack-seo/ref/eeat-criteria.md +123 -123
  95. package/src/bmad-plus/packs/pack-seo/ref/geo-signals.md +167 -167
  96. package/src/bmad-plus/packs/pack-seo/ref/hreflang-rules.md +153 -153
  97. package/src/bmad-plus/packs/pack-seo/ref/quality-gates.md +133 -133
  98. package/src/bmad-plus/packs/pack-seo/ref/schema-catalog.md +91 -91
  99. package/src/bmad-plus/packs/pack-seo/ref/schema-templates.json +356 -356
  100. package/src/bmad-plus/packs/pack-seo/requirements.txt +17 -0
  101. package/src/bmad-plus/packs/pack-seo/scripts/seo_apis.py +456 -0
  102. package/src/bmad-plus/packs/pack-seo/scripts/seo_crawl.py +359 -0
  103. package/src/bmad-plus/packs/pack-seo/scripts/seo_fetch.py +304 -0
  104. package/src/bmad-plus/packs/pack-seo/scripts/seo_parse.py +255 -0
  105. package/src/bmad-plus/packs/pack-seo/scripts/seo_report.py +410 -0
  106. package/src/bmad-plus/packs/pack-seo/scripts/seo_screenshot.py +202 -0
  107. package/src/bmad-plus/packs/pack-seo/seo-chief.md +294 -294
  108. package/src/bmad-plus/packs/pack-seo/seo-judge.md +241 -241
  109. package/src/bmad-plus/packs/pack-seo/seo-scout.md +171 -171
  110. package/src/bmad-plus/packs/pack-seo/templates/seo-audit-workflow.md +241 -241
  111. package/src/bmad-plus/packs/pack-shield/README.md +6 -6
  112. package/src/bmad-plus/packs/pack-shield/SKILL.md +2 -2
  113. package/src/bmad-plus/packs/pack-shield/categories/accessibility-esg/csrd-agent.md +11 -11
  114. package/src/bmad-plus/packs/pack-shield/categories/accessibility-esg/section508-agent.md +11 -11
  115. package/src/bmad-plus/packs/pack-shield/categories/accessibility-esg/wcag-agent.md +11 -11
  116. package/src/bmad-plus/packs/pack-shield/categories/ai-governance/eu-ai-act-agent.md +11 -11
  117. package/src/bmad-plus/packs/pack-shield/categories/ai-governance/iso42001-agent.md +11 -11
  118. package/src/bmad-plus/packs/pack-shield/categories/ai-governance/nist-ai-rmf-agent.md +11 -11
  119. package/src/bmad-plus/packs/pack-shield/categories/cybersecurity/cis-controls-agent.md +11 -11
  120. package/src/bmad-plus/packs/pack-shield/categories/cybersecurity/ism-agent.md +11 -11
  121. package/src/bmad-plus/packs/pack-shield/categories/cybersecurity/iso27001-agent.md +11 -11
  122. package/src/bmad-plus/packs/pack-shield/categories/cybersecurity/nis2-agent.md +11 -11
  123. package/src/bmad-plus/packs/pack-shield/categories/cybersecurity/nist-800-53-agent.md +11 -11
  124. package/src/bmad-plus/packs/pack-shield/categories/cybersecurity/nist-csf-agent.md +11 -11
  125. package/src/bmad-plus/packs/pack-shield/categories/defense-export/cmmc-agent.md +11 -11
  126. package/src/bmad-plus/packs/pack-shield/categories/defense-export/ear-agent.md +11 -11
  127. package/src/bmad-plus/packs/pack-shield/categories/defense-export/itar-agent.md +11 -11
  128. package/src/bmad-plus/packs/pack-shield/categories/defense-export/tsa-agent.md +11 -11
  129. package/src/bmad-plus/packs/pack-shield/categories/industry-compliance/dora-agent.md +11 -11
  130. package/src/bmad-plus/packs/pack-shield/categories/industry-compliance/fedramp-agent.md +11 -11
  131. package/src/bmad-plus/packs/pack-shield/categories/industry-compliance/hipaa-agent.md +11 -11
  132. package/src/bmad-plus/packs/pack-shield/categories/industry-compliance/pci-dss-agent.md +11 -11
  133. package/src/bmad-plus/packs/pack-shield/categories/industry-compliance/soc2-agent.md +11 -11
  134. package/src/bmad-plus/packs/pack-shield/categories/industry-compliance/swift-csp-agent.md +11 -11
  135. package/src/bmad-plus/packs/pack-shield/shield-orchestrator.md +1 -1
  136. package/tools/build/check-counts.js +628 -0
  137. package/tools/build/generated-adapters/.codex/AGENTS.md +1 -1
  138. package/tools/build/generated-adapters/.cursor/rules/bmad-plus.mdc +1 -1
  139. package/tools/build/generated-adapters/.opencode/AGENTS.md +1 -1
  140. package/tools/build/generated-adapters/AGENTS.md +1 -1
  141. package/tools/build/generated-adapters/CLAUDE.md +1 -1
  142. package/tools/build/generated-adapters/CONVENTIONS.md +1 -1
  143. package/tools/build/generated-adapters/GEMINI.md +1 -1
  144. package/tools/cli/commands/autoconfig.js +470 -472
  145. package/tools/cli/commands/doctor.js +233 -233
  146. package/tools/cli/commands/install.js +598 -495
  147. package/tools/cli/commands/memory-journal-cmd.js +311 -311
  148. package/tools/cli/commands/memory.js +195 -195
  149. package/tools/cli/commands/scan.js +348 -364
  150. package/tools/cli/commands/uninstall.js +101 -101
  151. package/tools/cli/commands/update.js +134 -134
  152. package/tools/cli/i18n.js +845 -845
  153. package/tools/cli/lib/README-memory-journal.md +125 -125
  154. package/tools/cli/lib/ide-config.js +267 -259
  155. package/tools/cli/lib/memory-init.js +204 -113
  156. package/tools/cli/lib/packs.js +209 -209
  157. package/tools/cli/lib/path-hash.js +39 -0
  158. package/tools/cli/lib/python-provision.js +508 -508
  159. package/tools/cli/lib/stack-detect.js +102 -102
  160. package/tools/cli/lib/validate.js +50 -50
@@ -1,49 +1,49 @@
1
- ---
2
- ---
3
-
4
- # Step 3: Triage
5
-
6
- ## RULES
7
-
8
- - YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}`
9
- - Be precise. When uncertain between categories, prefer the more conservative classification.
10
-
11
- ## INSTRUCTIONS
12
-
13
- 1. **Normalize** findings into a common format. Expected input formats:
14
- - Adversarial (Blind Hunter): markdown list of descriptions
15
- - Edge Case Hunter: JSON array with `location`, `trigger_condition`, `guard_snippet`, `potential_consequence` fields
16
- - Acceptance Auditor: markdown list with title, AC/constraint reference, and evidence
17
-
18
- If a layer's output does not match its expected format, attempt best-effort parsing. Note any parsing issues for the user.
19
-
20
- Convert all to a unified list where each finding has:
21
- - `id` -- sequential integer
22
- - `source` -- `blind`, `edge`, `auditor`, or merged sources (e.g., `blind+edge`)
23
- - `title` -- one-line summary
24
- - `detail` -- full description
25
- - `location` -- file and line reference (if available)
26
-
27
- 2. **Deduplicate.** If two or more findings describe the same issue, merge them into one:
28
- - Use the most specific finding as the base (prefer edge-case JSON with location over adversarial prose).
29
- - Append any unique detail, reasoning, or location references from the other finding(s) into the surviving `detail` field.
30
- - Set `source` to the merged sources (e.g., `blind+edge`).
31
-
32
- 3. **Classify** each finding into exactly one bucket:
33
- - **decision_needed** -- There is an ambiguous choice that requires human input. The code cannot be correctly patched without knowing the user's intent. Only possible if `{review_mode}` = `"full"`.
34
- - **patch** -- Code issue that is fixable without human input. The correct fix is unambiguous.
35
- - **defer** -- Pre-existing issue not caused by the current change. Real but not actionable now.
36
- - **dismiss** -- Noise, false positive, or handled elsewhere.
37
-
38
- If `{review_mode}` = `"no-spec"` and a finding would otherwise be `decision_needed`, reclassify it as `patch` (if the fix is unambiguous) or `defer` (if not).
39
-
40
- 4. **Drop** all `dismiss` findings. Record the dismiss count for the summary.
41
-
42
- 5. If `{failed_layers}` is non-empty, report which layers failed before announcing results. If zero findings remain after dropping dismissed AND `{failed_layers}` is non-empty, warn the user that the review may be incomplete rather than announcing a clean review.
43
-
44
- 6. If zero findings remain after triage (all rejected or none raised): state "✅ Clean review — all layers passed." (Step 3 already warned if any review layers failed via `{failed_layers}`.)
45
-
46
-
47
- ## NEXT
48
-
49
- Read fully and follow `./step-04-present.md`
1
+ ---
2
+ ---
3
+
4
+ # Step 3: Triage
5
+
6
+ ## RULES
7
+
8
+ - YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}`
9
+ - Be precise. When uncertain between categories, prefer the more conservative classification.
10
+
11
+ ## INSTRUCTIONS
12
+
13
+ 1. **Normalize** findings into a common format. Expected input formats:
14
+ - Adversarial (Blind Hunter): markdown list of descriptions
15
+ - Edge Case Hunter: JSON array with `location`, `trigger_condition`, `guard_snippet`, `potential_consequence` fields
16
+ - Acceptance Auditor: markdown list with title, AC/constraint reference, and evidence
17
+
18
+ If a layer's output does not match its expected format, attempt best-effort parsing. Note any parsing issues for the user.
19
+
20
+ Convert all to a unified list where each finding has:
21
+ - `id` -- sequential integer
22
+ - `source` -- `blind`, `edge`, `auditor`, or merged sources (e.g., `blind+edge`)
23
+ - `title` -- one-line summary
24
+ - `detail` -- full description
25
+ - `location` -- file and line reference (if available)
26
+
27
+ 2. **Deduplicate.** If two or more findings describe the same issue, merge them into one:
28
+ - Use the most specific finding as the base (prefer edge-case JSON with location over adversarial prose).
29
+ - Append any unique detail, reasoning, or location references from the other finding(s) into the surviving `detail` field.
30
+ - Set `source` to the merged sources (e.g., `blind+edge`).
31
+
32
+ 3. **Classify** each finding into exactly one bucket:
33
+ - **decision_needed** -- There is an ambiguous choice that requires human input. The code cannot be correctly patched without knowing the user's intent. Only possible if `{review_mode}` = `"full"`.
34
+ - **patch** -- Code issue that is fixable without human input. The correct fix is unambiguous.
35
+ - **defer** -- Pre-existing issue not caused by the current change. Real but not actionable now.
36
+ - **dismiss** -- Noise, false positive, or handled elsewhere.
37
+
38
+ If `{review_mode}` = `"no-spec"` and a finding would otherwise be `decision_needed`, reclassify it as `patch` (if the fix is unambiguous) or `defer` (if not).
39
+
40
+ 4. **Drop** all `dismiss` findings. Record the dismiss count for the summary.
41
+
42
+ 5. If `{failed_layers}` is non-empty, report which layers failed before announcing results. If zero findings remain after dropping dismissed AND `{failed_layers}` is non-empty, warn the user that the review may be incomplete rather than announcing a clean review.
43
+
44
+ 6. If zero findings remain after triage (all rejected or none raised): state "✅ Clean review — all layers passed." (Step 3 already warned if any review layers failed via `{failed_layers}`.)
45
+
46
+
47
+ ## NEXT
48
+
49
+ Read fully and follow `./step-04-present.md`
@@ -1,132 +1,132 @@
1
- ---
2
- deferred_work_file: '{implementation_artifacts}/deferred-work.md'
3
- ---
4
-
5
- # Step 4: Present and Act
6
-
7
- ## RULES
8
-
9
- - YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}`
10
- - When `{spec_file}` is set, always write findings to the story file before offering action choices.
11
- - `decision-needed` findings must be resolved before handling `patch` findings.
12
-
13
- ## INSTRUCTIONS
14
-
15
- ### 1. Clean review shortcut
16
-
17
- If zero findings remain after triage (all dismissed or none raised): state that and proceed to section 6 (Sprint Status Update).
18
-
19
- ### 2. Write findings to the story file
20
-
21
- If `{spec_file}` exists and contains a Tasks/Subtasks section, append a `### Review Findings` subsection. Write all findings in this order:
22
-
23
- 1. **`decision-needed`** findings (unchecked):
24
- `- [ ] [Review][Decision] <Title> — <Detail>`
25
-
26
- 2. **`patch`** findings (unchecked):
27
- `- [ ] [Review][Patch] <Title> [<file>:<line>]`
28
-
29
- 3. **`defer`** findings (checked off, marked deferred):
30
- `- [x] [Review][Defer] <Title> [<file>:<line>] — deferred, pre-existing`
31
-
32
- Also append each `defer` finding to `{deferred_work_file}` under a heading `## Deferred from: code review ({date})`. If `{spec_file}` is set, include its basename in the heading (e.g., `code review of story-3.3 (2026-03-18)`). One bullet per finding with description.
33
-
34
- ### 3. Present summary
35
-
36
- Announce what was written:
37
-
38
- > **Code review complete.** <D> `decision-needed`, <P> `patch`, <W> `defer`, <R> dismissed as noise.
39
-
40
- If `{spec_file}` is set, add: `Findings written to the review findings section in {spec_file}.`
41
- Otherwise add: `Findings are listed above. No story file was provided, so nothing was persisted.`
42
-
43
- ### 4. Resolve decision-needed findings
44
-
45
- If `decision_needed` findings exist, present each one with its detail and the options available. The user must decide — the correct fix is ambiguous without their input. Walk through each finding (or batch related ones) and get the user's call. Once resolved, each becomes a `patch`, `defer`, or is dismissed.
46
-
47
- If the user chooses to defer, ask: Quick one-line reason for deferring this item? (helps future reviews): — then append that reason to both the story file bullet and the `{deferred_work_file}` entry.
48
-
49
- **HALT** — I am waiting for your numbered choice. Reply with only the number. Do not proceed until you select an option.
50
-
51
- ### 5. Handle `patch` findings
52
-
53
- If `patch` findings exist (including any resolved from step 4), HALT. Ask the user:
54
-
55
- If `{spec_file}` is set, present all three options:
56
-
57
- > **How would you like to handle the `<P>` `patch` findings?**
58
- > 1. **Apply every patch** — fix all of them now, no per-finding confirmation. Defer and decision-needed items are not touched.
59
- > 2. **Leave as action items** — they are already in the story file
60
- > 3. **Walk through each patch** — show details for each before deciding
61
-
62
- If `{spec_file}` is **not** set, present only options 1 and 2 (omit "Leave as action items" — findings were not written to a file):
63
-
64
- > **How would you like to handle the `<P>` `patch` findings?**
65
- > 1. **Apply every patch** — fix all of them now, no per-finding confirmation. Defer and decision-needed items are not touched.
66
- > 2. **Walk through each patch** — show details for each before deciding
67
-
68
- **HALT** — I am waiting for your numbered choice. Reply with only the number. Do not proceed until you select an option.
69
-
70
- - **Apply every patch**: Apply every patch finding without per-finding confirmation. Do not modify defer or decision-needed items. After all patches are applied, present a summary of changes made. If `{spec_file}` is set, check off the patch items in the story file (leave defer items as-is).
71
- - **Leave as action items** (only when `{spec_file}` is set): Done — findings are already written to the story.
72
- - **Walk through each patch**: Present each finding with full detail, diff context, and suggested fix. After walkthrough, re-offer the applicable options above.
73
-
74
- **HALT** — I am waiting for your numbered choice. Do not proceed until you select an option.
75
-
76
- **✅ Code review actions complete**
77
-
78
- - Decision-needed resolved: <D>
79
- - Patches handled: <P>
80
- - Deferred: <W>
81
- - Dismissed: <R>
82
-
83
- ### 6. Update story status and sync sprint tracking
84
-
85
- Skip this section if `{spec_file}` is not set.
86
-
87
- #### Determine new status based on review outcome
88
-
89
- - If all `decision-needed` and `patch` findings were resolved (fixed or dismissed) AND no unresolved HIGH/MEDIUM issues remain: set `{new_status}` = `done`. Update the story file Status section to `done`.
90
- - If `patch` findings were left as action items, or unresolved issues remain: set `{new_status}` = `in-progress`. Update the story file Status section to `in-progress`.
91
-
92
- Save the story file.
93
-
94
- #### Sync sprint-status.yaml
95
-
96
- If `{story_key}` is not set, skip this subsection and note that sprint status was not synced because no story key was available.
97
-
98
- If `{sprint_status}` file exists:
99
-
100
- 1. Load the FULL `{sprint_status}` file.
101
- 2. Find the `development_status` entry matching `{story_key}`.
102
- 3. If found: update `development_status[{story_key}]` to `{new_status}`. Update `last_updated` to current date. Save the file, preserving ALL comments and structure including STATUS DEFINITIONS.
103
- 4. If `{story_key}` not found in sprint status: warn the user that the story file was updated but sprint-status sync failed.
104
-
105
- If `{sprint_status}` file does not exist, note that story status was updated in the story file only.
106
-
107
- #### Completion summary
108
-
109
- > **Review Complete!**
110
- >
111
- > **Story Status:** `{new_status}`
112
- > **Issues Fixed:** <fixed_count>
113
- > **Action Items Created:** <action_count>
114
- > **Deferred:** <W>
115
- > **Dismissed:** <R>
116
-
117
- ### 7. Next steps
118
-
119
- Present the user with follow-up options:
120
-
121
- > **What would you like to do next?**
122
- > 1. **Start the next story** — run `dev-story` to pick up the next `ready-for-dev` story
123
- > 2. **Re-run code review** — address findings and review again
124
- > 3. **Done** — end the workflow
125
-
126
- **HALT** — I am waiting for your choice. Do not proceed until the user selects an option.
127
-
128
- ## On Complete
129
-
130
- <!-- Adapted for BMAD+: original script dependency removed -->
131
-
1
+ ---
2
+ deferred_work_file: '{implementation_artifacts}/deferred-work.md'
3
+ ---
4
+
5
+ # Step 4: Present and Act
6
+
7
+ ## RULES
8
+
9
+ - YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}`
10
+ - When `{spec_file}` is set, always write findings to the story file before offering action choices.
11
+ - `decision-needed` findings must be resolved before handling `patch` findings.
12
+
13
+ ## INSTRUCTIONS
14
+
15
+ ### 1. Clean review shortcut
16
+
17
+ If zero findings remain after triage (all dismissed or none raised): state that and proceed to section 6 (Sprint Status Update).
18
+
19
+ ### 2. Write findings to the story file
20
+
21
+ If `{spec_file}` exists and contains a Tasks/Subtasks section, append a `### Review Findings` subsection. Write all findings in this order:
22
+
23
+ 1. **`decision-needed`** findings (unchecked):
24
+ `- [ ] [Review][Decision] <Title> — <Detail>`
25
+
26
+ 2. **`patch`** findings (unchecked):
27
+ `- [ ] [Review][Patch] <Title> [<file>:<line>]`
28
+
29
+ 3. **`defer`** findings (checked off, marked deferred):
30
+ `- [x] [Review][Defer] <Title> [<file>:<line>] — deferred, pre-existing`
31
+
32
+ Also append each `defer` finding to `{deferred_work_file}` under a heading `## Deferred from: code review ({date})`. If `{spec_file}` is set, include its basename in the heading (e.g., `code review of story-3.3 (2026-03-18)`). One bullet per finding with description.
33
+
34
+ ### 3. Present summary
35
+
36
+ Announce what was written:
37
+
38
+ > **Code review complete.** <D> `decision-needed`, <P> `patch`, <W> `defer`, <R> dismissed as noise.
39
+
40
+ If `{spec_file}` is set, add: `Findings written to the review findings section in {spec_file}.`
41
+ Otherwise add: `Findings are listed above. No story file was provided, so nothing was persisted.`
42
+
43
+ ### 4. Resolve decision-needed findings
44
+
45
+ If `decision_needed` findings exist, present each one with its detail and the options available. The user must decide — the correct fix is ambiguous without their input. Walk through each finding (or batch related ones) and get the user's call. Once resolved, each becomes a `patch`, `defer`, or is dismissed.
46
+
47
+ If the user chooses to defer, ask: Quick one-line reason for deferring this item? (helps future reviews): — then append that reason to both the story file bullet and the `{deferred_work_file}` entry.
48
+
49
+ **HALT** — I am waiting for your numbered choice. Reply with only the number. Do not proceed until you select an option.
50
+
51
+ ### 5. Handle `patch` findings
52
+
53
+ If `patch` findings exist (including any resolved from step 4), HALT. Ask the user:
54
+
55
+ If `{spec_file}` is set, present all three options:
56
+
57
+ > **How would you like to handle the `<P>` `patch` findings?**
58
+ > 1. **Apply every patch** — fix all of them now, no per-finding confirmation. Defer and decision-needed items are not touched.
59
+ > 2. **Leave as action items** — they are already in the story file
60
+ > 3. **Walk through each patch** — show details for each before deciding
61
+
62
+ If `{spec_file}` is **not** set, present only options 1 and 2 (omit "Leave as action items" — findings were not written to a file):
63
+
64
+ > **How would you like to handle the `<P>` `patch` findings?**
65
+ > 1. **Apply every patch** — fix all of them now, no per-finding confirmation. Defer and decision-needed items are not touched.
66
+ > 2. **Walk through each patch** — show details for each before deciding
67
+
68
+ **HALT** — I am waiting for your numbered choice. Reply with only the number. Do not proceed until you select an option.
69
+
70
+ - **Apply every patch**: Apply every patch finding without per-finding confirmation. Do not modify defer or decision-needed items. After all patches are applied, present a summary of changes made. If `{spec_file}` is set, check off the patch items in the story file (leave defer items as-is).
71
+ - **Leave as action items** (only when `{spec_file}` is set): Done — findings are already written to the story.
72
+ - **Walk through each patch**: Present each finding with full detail, diff context, and suggested fix. After walkthrough, re-offer the applicable options above.
73
+
74
+ **HALT** — I am waiting for your numbered choice. Do not proceed until you select an option.
75
+
76
+ **✅ Code review actions complete**
77
+
78
+ - Decision-needed resolved: <D>
79
+ - Patches handled: <P>
80
+ - Deferred: <W>
81
+ - Dismissed: <R>
82
+
83
+ ### 6. Update story status and sync sprint tracking
84
+
85
+ Skip this section if `{spec_file}` is not set.
86
+
87
+ #### Determine new status based on review outcome
88
+
89
+ - If all `decision-needed` and `patch` findings were resolved (fixed or dismissed) AND no unresolved HIGH/MEDIUM issues remain: set `{new_status}` = `done`. Update the story file Status section to `done`.
90
+ - If `patch` findings were left as action items, or unresolved issues remain: set `{new_status}` = `in-progress`. Update the story file Status section to `in-progress`.
91
+
92
+ Save the story file.
93
+
94
+ #### Sync sprint-status.yaml
95
+
96
+ If `{story_key}` is not set, skip this subsection and note that sprint status was not synced because no story key was available.
97
+
98
+ If `{sprint_status}` file exists:
99
+
100
+ 1. Load the FULL `{sprint_status}` file.
101
+ 2. Find the `development_status` entry matching `{story_key}`.
102
+ 3. If found: update `development_status[{story_key}]` to `{new_status}`. Update `last_updated` to current date. Save the file, preserving ALL comments and structure including STATUS DEFINITIONS.
103
+ 4. If `{story_key}` not found in sprint status: warn the user that the story file was updated but sprint-status sync failed.
104
+
105
+ If `{sprint_status}` file does not exist, note that story status was updated in the story file only.
106
+
107
+ #### Completion summary
108
+
109
+ > **Review Complete!**
110
+ >
111
+ > **Story Status:** `{new_status}`
112
+ > **Issues Fixed:** <fixed_count>
113
+ > **Action Items Created:** <action_count>
114
+ > **Deferred:** <W>
115
+ > **Dismissed:** <R>
116
+
117
+ ### 7. Next steps
118
+
119
+ Present the user with follow-up options:
120
+
121
+ > **What would you like to do next?**
122
+ > 1. **Start the next story** — run `dev-story` to pick up the next `ready-for-dev` story
123
+ > 2. **Re-run code review** — address findings and review again
124
+ > 3. **Done** — end the workflow
125
+
126
+ **HALT** — I am waiting for your choice. Do not proceed until the user selects an option.
127
+
128
+ ## On Complete
129
+
130
+ <!-- Adapted for BMAD+: original script dependency removed -->
131
+
132
132
  If the resolved `workflow.on_complete` is non-empty, follow it as the final terminal instruction before exiting.
@@ -1,90 +1,90 @@
1
- ---
2
- name: bmad-code-review
3
- description: 'Review code changes adversarially using parallel review layers (Blind Hunter, Edge Case Hunter, Acceptance Auditor) with structured triage into actionable categories. Use when the user says "run code review" or "review this code"'
4
- ---
5
-
6
- # Code Review Workflow
7
-
8
- **Goal:** Review code changes adversarially using parallel review layers and structured triage.
9
-
10
- **Your Role:** You are an elite code reviewer. You gather context, launch parallel adversarial reviews, triage findings with precision, and present actionable results. No noise, no filler.
11
-
12
- ## Conventions
13
-
14
- - Bare paths (e.g. `checklist.md`) resolve from the skill root.
15
- - `this skill directory` resolves to this skill's installed directory (where `agent configuration` lives).
16
- - `{project-root}`-prefixed paths resolve from the project working directory.
17
- - `{skill-name}` resolves to the skill directory's basename.
18
-
19
- ## On Activation
20
-
21
- ### Step 1: Resolve the Workflow Block
22
-
23
- <!-- Adapted for BMAD+: original script dependency removed -->
24
-
25
- **If the script fails**, resolve the `workflow` block yourself by reading these three files in base → team → user order and applying the same structural merge rules as the resolver:
26
-
27
- 1. `this skill file` — defaults
28
- 2. `{project-root}/custom/{skill-name}.toml` — team overrides
29
- 3. `{project-root}/custom/{skill-name}.user.toml` — personal overrides
30
-
31
- Any missing file is skipped. Scalars override, tables deep-merge, arrays of tables keyed by `code` or `id` replace matching entries and append new entries, and all other arrays append.
32
-
33
- ### Step 2: Execute Prepend Steps
34
-
35
- Execute each entry in `{workflow.activation_steps_prepend}` in order before proceeding.
36
-
37
- ### Step 3: Load Persistent Facts
38
-
39
- Treat every entry in `{workflow.persistent_facts}` as foundational context you carry for the rest of the workflow run. Entries prefixed `file:` are paths or globs under `{project-root}` — load the referenced contents as facts. All other entries are facts verbatim.
40
-
41
- ### Step 4: Load Config
42
-
43
- Load config from `{project-root}/project config` and resolve:
44
-
45
- - `project_name`, `planning_artifacts`, `implementation_artifacts`, `user_name`
46
- - `communication_language`, `document_output_language`, `user_skill_level`
47
- - `date` as system-generated current datetime
48
- - `sprint_status` = `{implementation_artifacts}/sprint-status.yaml`
49
- - `project_context` = `**/project-context.md` (load if exists)
50
- - CLAUDE.md / memory files (load if exist)
51
- - YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}`
52
-
53
- ### Step 5: Greet the User
54
-
55
- Greet `{user_name}`, speaking in `{communication_language}`.
56
-
57
- ### Step 6: Execute Append Steps
58
-
59
- Execute each entry in `{workflow.activation_steps_append}` in order.
60
-
61
- Activation is complete. Begin the workflow below.
62
-
63
- ## WORKFLOW ARCHITECTURE
64
-
65
- This uses **step-file architecture** for disciplined execution:
66
-
67
- - **Micro-file Design**: Each step is self-contained and followed exactly
68
- - **Just-In-Time Loading**: Only load the current step file
69
- - **Sequential Enforcement**: Complete steps in order, no skipping
70
- - **State Tracking**: Persist progress via in-memory variables
71
- - **Append-Only Building**: Build artifacts incrementally
72
-
73
- ### Step Processing Rules
74
-
75
- 1. **READ COMPLETELY**: Read the entire step file before acting
76
- 2. **FOLLOW SEQUENCE**: Execute sections in order
77
- 3. **WAIT FOR INPUT**: Halt at checkpoints and wait for human
78
- 4. **LOAD NEXT**: When directed, read fully and follow the next step file
79
-
80
- ### Critical Rules (NO EXCEPTIONS)
81
-
82
- - **NEVER** load multiple step files simultaneously
83
- - **ALWAYS** read entire step file before execution
84
- - **NEVER** skip steps or optimize the sequence
85
- - **ALWAYS** follow the exact instructions in the step file
86
- - **ALWAYS** halt at checkpoints and wait for human input
87
-
88
- ## FIRST STEP
89
-
1
+ ---
2
+ name: bmad-code-review
3
+ description: 'Review code changes adversarially using parallel review layers (Blind Hunter, Edge Case Hunter, Acceptance Auditor) with structured triage into actionable categories. Use when the user says "run code review" or "review this code"'
4
+ ---
5
+
6
+ # Code Review Workflow
7
+
8
+ **Goal:** Review code changes adversarially using parallel review layers and structured triage.
9
+
10
+ **Your Role:** You are an elite code reviewer. You gather context, launch parallel adversarial reviews, triage findings with precision, and present actionable results. No noise, no filler.
11
+
12
+ ## Conventions
13
+
14
+ - Bare paths (e.g. `checklist.md`) resolve from the skill root.
15
+ - `this skill directory` resolves to this skill's installed directory (where `agent configuration` lives).
16
+ - `{project-root}`-prefixed paths resolve from the project working directory.
17
+ - `{skill-name}` resolves to the skill directory's basename.
18
+
19
+ ## On Activation
20
+
21
+ ### Step 1: Resolve the Workflow Block
22
+
23
+ <!-- Adapted for BMAD+: original script dependency removed -->
24
+
25
+ **If the script fails**, resolve the `workflow` block yourself by reading these three files in base → team → user order and applying the same structural merge rules as the resolver:
26
+
27
+ 1. `this skill file` — defaults
28
+ 2. `{project-root}/custom/{skill-name}.toml` — team overrides
29
+ 3. `{project-root}/custom/{skill-name}.user.toml` — personal overrides
30
+
31
+ Any missing file is skipped. Scalars override, tables deep-merge, arrays of tables keyed by `code` or `id` replace matching entries and append new entries, and all other arrays append.
32
+
33
+ ### Step 2: Execute Prepend Steps
34
+
35
+ Execute each entry in `{workflow.activation_steps_prepend}` in order before proceeding.
36
+
37
+ ### Step 3: Load Persistent Facts
38
+
39
+ Treat every entry in `{workflow.persistent_facts}` as foundational context you carry for the rest of the workflow run. Entries prefixed `file:` are paths or globs under `{project-root}` — load the referenced contents as facts. All other entries are facts verbatim.
40
+
41
+ ### Step 4: Load Config
42
+
43
+ Load config from `{project-root}/project config` and resolve:
44
+
45
+ - `project_name`, `planning_artifacts`, `implementation_artifacts`, `user_name`
46
+ - `communication_language`, `document_output_language`, `user_skill_level`
47
+ - `date` as system-generated current datetime
48
+ - `sprint_status` = `{implementation_artifacts}/sprint-status.yaml`
49
+ - `project_context` = `**/project-context.md` (load if exists)
50
+ - CLAUDE.md / memory files (load if exist)
51
+ - YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}`
52
+
53
+ ### Step 5: Greet the User
54
+
55
+ Greet `{user_name}`, speaking in `{communication_language}`.
56
+
57
+ ### Step 6: Execute Append Steps
58
+
59
+ Execute each entry in `{workflow.activation_steps_append}` in order.
60
+
61
+ Activation is complete. Begin the workflow below.
62
+
63
+ ## WORKFLOW ARCHITECTURE
64
+
65
+ This uses **step-file architecture** for disciplined execution:
66
+
67
+ - **Micro-file Design**: Each step is self-contained and followed exactly
68
+ - **Just-In-Time Loading**: Only load the current step file
69
+ - **Sequential Enforcement**: Complete steps in order, no skipping
70
+ - **State Tracking**: Persist progress via in-memory variables
71
+ - **Append-Only Building**: Build artifacts incrementally
72
+
73
+ ### Step Processing Rules
74
+
75
+ 1. **READ COMPLETELY**: Read the entire step file before acting
76
+ 2. **FOLLOW SEQUENCE**: Execute sections in order
77
+ 3. **WAIT FOR INPUT**: Halt at checkpoints and wait for human
78
+ 4. **LOAD NEXT**: When directed, read fully and follow the next step file
79
+
80
+ ### Critical Rules (NO EXCEPTIONS)
81
+
82
+ - **NEVER** load multiple step files simultaneously
83
+ - **ALWAYS** read entire step file before execution
84
+ - **NEVER** skip steps or optimize the sequence
85
+ - **ALWAYS** follow the exact instructions in the step file
86
+ - **ALWAYS** halt at checkpoints and wait for human input
87
+
88
+ ## FIRST STEP
89
+
90
90
  Read fully and follow: `./steps/step-01-gather-context.md`