bmad-enhanced 1.5.2 → 1.6.0

package/scripts/update/lib/config-merger.js

@@ -2,6 +2,7 @@
 
 const fs = require('fs-extra');
 const yaml = require('js-yaml');
+const { AGENT_IDS, WORKFLOW_NAMES } = require('./agent-registry');
 
 /**
  * Config Merger for BMAD-Enhanced
@@ -22,7 +23,8 @@ async function mergeConfig(currentConfigPath, newVersion, updates = {}) {
   if (fs.existsSync(currentConfigPath)) {
     try {
       const currentContent = fs.readFileSync(currentConfigPath, 'utf8');
-      current = yaml.load(currentContent);
+      const parsed = yaml.load(currentContent);
+      current = (parsed && typeof parsed === 'object') ? parsed : {};
     } catch (_error) {
       console.warn('Warning: Could not parse current config.yaml, using defaults');
       current = {};
@@ -35,9 +37,11 @@ async function mergeConfig(currentConfigPath, newVersion, updates = {}) {
   // Seed with required structural defaults for fresh installs
   const defaults = {
     submodule_name: '_vortex',
-    description: 'Vortex Framework - Contextualize, Empathize, Externalize, and Systematize streams',
+    description: 'Vortex Pattern - Contextualize, Empathize, Synthesize, Hypothesize, Externalize, Sensitize, and Systematize streams',
     module: 'bme',
-    output_folder: '{project-root}/_bmad-output/vortex-artifacts'
+    output_folder: '{project-root}/_bmad-output/vortex-artifacts',
+    agents: [...AGENT_IDS],
+    workflows: [...WORKFLOW_NAMES]
   };
 
   // Start with defaults, overlay current config (preserves existing values)
@@ -79,7 +83,7 @@ function extractUserPreferences(config) {
     prefs.user_name = config.user_name;
   }
 
-  if (config.communication_language && config.communication_language !== 'en') {
+  if (config.communication_language) {
     prefs.communication_language = config.communication_language;
   }
 
@@ -98,6 +102,34 @@ function extractUserPreferences(config) {
   return prefs;
 }
 
+/**
+ * Declarative config schema.
+ * Each entry declares a field's type, whether it's required, and an optional
+ * validation function that receives the value and returns an error string or null.
+ */
+const CONFIG_SCHEMA = [
+  { field: 'submodule_name', type: 'string', required: true },
+  { field: 'description',   type: 'string', required: true },
+  { field: 'module',        type: 'string', required: true },
+  { field: 'version',       type: 'string', required: true,
+    validate: v => /^\d+\.\d+\.\d+$/.test(v) ? null : `Invalid version format: ${v} (expected x.x.x)` },
+  { field: 'output_folder', type: 'string', required: true },
+  { field: 'agents',        type: 'array',  required: true, items: 'string' },
+  { field: 'workflows',     type: 'array',  required: true, items: 'string' },
+  { field: 'communication_language', type: 'string',  required: false },
+  { field: 'party_mode_enabled',     type: 'boolean', required: false },
+  { field: 'migration_history',      type: 'array',   required: false,
+    validate: (arr) => {
+      for (let i = 0; i < arr.length; i++) {
+        const e = arr[i];
+        if (!e.timestamp || !e.from_version || !e.to_version) {
+          return `migration_history[${i}] missing required fields`;
+        }
+      }
+      return null;
+    }},
+];
+
 /**
  * Validate merged config structure
  * @param {object} config - Config to validate
@@ -106,48 +138,39 @@ function extractUserPreferences(config) {
 function validateConfig(config) {
   const errors = [];
 
-  // Required fields
-  const requiredFields = [
-    'submodule_name',
-    'description',
-    'module',
-    'version',
-    'output_folder',
-    'agents',
-    'workflows'
-  ];
-
-  for (const field of requiredFields) {
-    if (!Object.prototype.hasOwnProperty.call(config, field)) {
-      errors.push(`Missing required field: ${field}`);
-    }
-  }
-
-  // Validate version format (x.x.x)
-  if (config.version && !/^\d+\.\d+\.\d+$/.test(config.version)) {
-    errors.push(`Invalid version format: ${config.version} (expected x.x.x)`);
-  }
+  for (const rule of CONFIG_SCHEMA) {
+    const has = Object.prototype.hasOwnProperty.call(config, rule.field);
 
-  // Validate agents is array
-  if (config.agents && !Array.isArray(config.agents)) {
-    errors.push('agents must be an array');
-  }
-
-  // Validate workflows is array
-  if (config.workflows && !Array.isArray(config.workflows)) {
-    errors.push('workflows must be an array');
-  }
+    if (!has) {
+      if (rule.required) errors.push(`Missing required field: ${rule.field}`);
+      continue;
+    }
 
-  // Validate migration_history structure
-  if (config.migration_history) {
-    if (!Array.isArray(config.migration_history)) {
-      errors.push('migration_history must be an array');
-    } else {
-      config.migration_history.forEach((entry, index) => {
-        if (!entry.timestamp || !entry.from_version || !entry.to_version) {
-          errors.push(`migration_history[${index}] missing required fields`);
+    const value = config[rule.field];
+
+    // Type check
+    if (rule.type === 'array') {
+      if (!Array.isArray(value)) {
+        errors.push(`${rule.field} must be an array`);
+        continue;
+      }
+      // Item type check
+      if (rule.items) {
+        for (let i = 0; i < value.length; i++) {
+          if (typeof value[i] !== rule.items) {
+            errors.push(`${rule.field}[${i}] must be a ${rule.items}`);
+          }
         }
-      });
+      }
+    } else if (typeof value !== rule.type) {
+      errors.push(`${rule.field} must be a ${rule.type}`);
+      continue;
+    }
+
+    // Custom validation
+    if (rule.validate) {
+      const err = rule.validate(value);
+      if (err) errors.push(err);
     }
   }
 
@@ -197,6 +220,7 @@ function addMigrationHistory(config, fromVersion, toVersion, migrationsApplied)
 }
 
 module.exports = {
+  CONFIG_SCHEMA,
   mergeConfig,
   extractUserPreferences,
   validateConfig,

package/scripts/update/lib/migration-runner.js

@@ -10,6 +10,7 @@ const configMerger = require('./config-merger');
 const validator = require('./validator');
 const { refreshInstallation } = require('./refresh-installation');
 const registry = require('../migrations/registry');
+const { WORKFLOW_NAMES } = require('./agent-registry');
 
 /**
  * Migration Runner for BMAD-Enhanced
@@ -216,7 +217,7 @@ async function previewMigrations(migrations) {
   console.log('');
   console.log(chalk.white('After deltas, installation will be refreshed:'));
   console.log(chalk.gray('  - Refresh agent files'));
-  console.log(chalk.gray('  - Refresh 7 workflow directories'));
+  console.log(chalk.gray(`  - Refresh ${WORKFLOW_NAMES.length} workflow directories`));
   console.log(chalk.gray('  - Update config.yaml (preserving user preferences)'));
   console.log(chalk.gray('  - Update user guides (with .bak backup)'));
   console.log('');

package/scripts/update/lib/refresh-installation.js

@@ -4,6 +4,7 @@ const fs = require('fs-extra');
 const path = require('path');
 const { getPackageVersion } = require('./utils');
 const configMerger = require('./config-merger');
+const { AGENT_FILES, AGENT_IDS, WORKFLOW_NAMES, USER_GUIDES } = require('./agent-registry');
 
 /**
  * Refresh Installation for BMAD-Enhanced
@@ -13,40 +14,6 @@ const configMerger = require('./config-merger');
  * or directly by the install script.
  */
 
-const AGENT_FILES = [
-  'contextualization-expert.md',
-  'lean-experiments-specialist.md',
-  'discovery-empathy-expert.md',
-  'learning-decision-expert.md'
-];
-
-const WORKFLOWS = [
-  // Emma — Contextualize Stream
-  'lean-persona',
-  'product-vision',
-  'contextualize-scope',
-  // Wade — Externalize Stream
-  'mvp',
-  'lean-experiment',
-  'proof-of-concept',
-  'proof-of-value',
-  // Isla — Empathize Stream
-  'empathy-map',
-  'user-interview',
-  'user-discovery',
-  // Max — Systematize Stream
-  'learning-card',
-  'pivot-patch-persevere',
-  'vortex-navigation'
-];
-
-const USER_GUIDES = [
-  'EMMA-USER-GUIDE.md',
-  'WADE-USER-GUIDE.md',
-  'ISLA-USER-GUIDE.md',
-  'MAX-USER-GUIDE.md'
-];
-
 /**
  * Refresh all installation files from the package to the project.
  *
@@ -94,7 +61,7 @@ async function refreshInstallation(projectRoot, options = {}) {
   const workflowsTarget = path.join(targetVortex, 'workflows');
   await fs.ensureDir(workflowsTarget);
 
-  for (const wf of WORKFLOWS) {
+  for (const wf of WORKFLOW_NAMES) {
     const src = path.join(workflowsSource, wf);
     if (fs.existsSync(src)) {
       await fs.copy(src, path.join(workflowsTarget, wf), { overwrite: true });
@@ -108,8 +75,8 @@ async function refreshInstallation(projectRoot, options = {}) {
   await fs.ensureDir(path.dirname(configPath));
 
   const updates = {
-    agents: ['contextualization-expert', 'lean-experiments-specialist', 'discovery-empathy-expert', 'learning-decision-expert'],
-    workflows: WORKFLOWS
+    agents: AGENT_IDS,
+    workflows: WORKFLOW_NAMES
   };
 
   const merged = await configMerger.mergeConfig(configPath, version, updates);

package/scripts/update/lib/validator.js

@@ -5,6 +5,7 @@ const path = require('path');
 const yaml = require('js-yaml');
 const configMerger = require('./config-merger');
 const { countUserDataFiles } = require('./utils');
+const { AGENT_FILES, AGENT_IDS, WORKFLOW_NAMES, WAVE3_WORKFLOW_NAMES } = require('./agent-registry');
 
 /**
  * Validator for BMAD-Enhanced
@@ -40,6 +41,9 @@ async function validateInstallation(preMigrationData = {}, projectRoot) {
   // 6. Deprecated workflows validation (if applicable)
   checks.push(await validateDeprecatedWorkflows(projectRoot));
 
+  // 7. Workflow step structure validation (P17 count + P20 filenames)
+  checks.push(await validateWorkflowStepStructure(projectRoot));
+
   const allPassed = checks.every(c => c.passed);
 
   return {
@@ -101,12 +105,7 @@ async function validateAgentFiles(projectRoot) {
 
   try {
     const agentsDir = path.join(projectRoot, '_bmad/bme/_vortex/agents');
-    const requiredAgents = [
-      'contextualization-expert.md',
-      'lean-experiments-specialist.md',
-      'discovery-empathy-expert.md',
-      'learning-decision-expert.md'
-    ];
+    const requiredAgents = AGENT_FILES;
 
     if (!fs.existsSync(agentsDir)) {
       check.error = 'agents/ directory not found';
@@ -148,15 +147,7 @@ async function validateWorkflows(projectRoot) {
 
   try {
     const workflowsDir = path.join(projectRoot, '_bmad/bme/_vortex/workflows');
-    const requiredWorkflows = [
-      'lean-persona',
-      'product-vision',
-      'contextualize-scope',
-      'mvp',
-      'lean-experiment',
-      'proof-of-concept',
-      'proof-of-value'
-    ];
+    const requiredWorkflows = WORKFLOW_NAMES;
 
     if (!fs.existsSync(workflowsDir)) {
       check.error = 'workflows/ directory not found';
@@ -208,12 +199,11 @@ async function validateManifest(projectRoot) {
 
     const manifestContent = fs.readFileSync(manifestPath, 'utf8');
 
-    // Check for BMAD-Enhanced agents
-    const hasEmma = manifestContent.includes('contextualization-expert');
-    const hasWade = manifestContent.includes('lean-experiments-specialist');
+    // Check for all BMAD-Enhanced agents
+    const missingFromManifest = AGENT_IDS.filter(id => !manifestContent.includes(id));
 
-    if (!hasEmma || !hasWade) {
-      check.error = 'Agent manifest missing BMAD-Enhanced agents';
+    if (missingFromManifest.length > 0) {
+      check.error = `Agent manifest missing: ${missingFromManifest.join(', ')}`;
       return check;
     }
 
@@ -301,6 +291,63 @@ async function validateDeprecatedWorkflows(projectRoot) {
   return check;
 }
 
+/**
+ * Validate workflow step structure (P17 count + P20 filenames)
+ * @param {string} projectRoot - Absolute path to project root
+ * @returns {Promise<object>} Validation check result
+ */
+async function validateWorkflowStepStructure(projectRoot) {
+  const check = {
+    name: 'Workflow step structure',
+    passed: true,
+    error: null
+  };
+
+  try {
+    const workflowsDir = path.join(projectRoot, '_bmad/bme/_vortex/workflows');
+    const issues = [];
+
+    for (const workflow of WORKFLOW_NAMES) {
+      const stepsDir = path.join(workflowsDir, workflow, 'steps');
+
+      if (!fs.existsSync(stepsDir)) {
+        continue; // Placeholder workflows without steps/ are valid
+      }
+
+      const files = fs.readdirSync(stepsDir).filter(f => f.endsWith('.md'));
+
+      // P17: step count must be 4-6
+      if (files.length < 4 || files.length > 6) {
+        issues.push(`${workflow}: ${files.length} step files (expected 4-6)`);
+        continue;
+      }
+
+      // P20: standardized filenames (Wave 3 workflows only)
+      if (WAVE3_WORKFLOW_NAMES.has(workflow)) {
+        if (!files.includes('step-01-setup.md')) {
+          issues.push(`${workflow}: missing step-01-setup.md`);
+        }
+        if (!files.includes('step-02-context.md')) {
+          issues.push(`${workflow}: missing step-02-context.md`);
+        }
+        if (!files.some(f => f.endsWith('-synthesize.md'))) {
+          issues.push(`${workflow}: missing *-synthesize.md final step`);
+        }
+      }
+    }
+
+    if (issues.length > 0) {
+      check.passed = false;
+      check.error = `Step structure issues: ${issues.join('; ')}`;
+    }
+  } catch (error) {
+    check.error = error.message;
+    check.passed = false;
+  }
+
+  return check;
+}
+
 module.exports = {
   validateInstallation,
   validateConfigStructure,
@@ -308,5 +355,6 @@ module.exports = {
   validateWorkflows,
   validateManifest,
   validateUserDataIntegrity,
-  validateDeprecatedWorkflows
+  validateDeprecatedWorkflows,
+  validateWorkflowStepStructure
 };

package/scripts/update/migrations/1.5.x-to-1.6.0.js

@@ -0,0 +1,95 @@
+const fs = require('fs-extra');
+const path = require('path');
+const yaml = require('js-yaml');
+const { AGENTS, AGENT_IDS, WAVE3_WORKFLOW_NAMES } = require('../lib/agent-registry');
+
+/**
+ * Migration: 1.5.x → current version (v1.6.0)
+ * Appends Wave 3 agents and workflows to existing config.
+ * refreshInstallation() handles file copying (agents, workflows, guides).
+ *
+ * Wave 3 agents: Mila (Synthesize), Liam (Hypothesize), Noah (Sensitize)
+ * Wave 3 workflows: 9 new workflows (3 per agent)
+ */
+
+// Wave 1/2 agent IDs (pre-1.6.0)
+const WAVE12_AGENT_IDS = new Set([
+  'contextualization-expert',
+  'discovery-empathy-expert',
+  'lean-experiments-specialist',
+  'learning-decision-expert'
+]);
+
+// Wave 3 agent IDs derived from registry; workflow names from WAVE3_WORKFLOW_NAMES set
+const WAVE3_AGENT_IDS = AGENT_IDS.filter(id => !WAVE12_AGENT_IDS.has(id));
+const WAVE3_WORKFLOWS = [...WAVE3_WORKFLOW_NAMES];
+
+module.exports = {
+  name: '1.5.x-to-1.6.0',
+  fromVersion: '1.5.x',
+  breaking: false,
+
+  async preview() {
+    const wave3Agents = AGENTS.filter(a => WAVE3_AGENT_IDS.includes(a.id));
+    const agentDesc = wave3Agents.map(a => `${a.name} (${a.id})`).join(', ');
+    return {
+      actions: [
+        `Append Wave 3 agents to config: ${agentDesc}`,
+        `Append ${WAVE3_WORKFLOWS.length} Wave 3 workflows to config: ${WAVE3_WORKFLOWS.join(', ')}`,
+        'File copying handled by refreshInstallation()'
+      ]
+    };
+  },
+
+  /**
+   * Apply migration: append Wave 3 agents and workflows to config.
+   * Idempotent — skips entries already present.
+   * @param {string} projectRoot - Absolute path to project root
+   * @returns {Promise<Array<string>>} List of changes made
+   */
+  async apply(projectRoot) {
+    const changes = [];
+    const configPath = path.join(projectRoot, '_bmad', 'bme', '_vortex', 'config.yaml');
+
+    if (!await fs.pathExists(configPath)) {
+      changes.push('No config.yaml found — refreshInstallation will create it');
+      return changes;
+    }
+
+    const configContent = await fs.readFile(configPath, 'utf8');
+    const config = yaml.load(configContent) || {};
+
+    // Ensure arrays exist
+    if (!Array.isArray(config.agents)) {
+      config.agents = [];
+    }
+    if (!Array.isArray(config.workflows)) {
+      config.workflows = [];
+    }
+
+    // Append missing Wave 3 agents (idempotent)
+    const newAgents = WAVE3_AGENT_IDS.filter(id => !config.agents.includes(id));
+    if (newAgents.length > 0) {
+      config.agents.push(...newAgents);
+      changes.push(`Appended ${newAgents.length} Wave 3 agent(s): ${newAgents.join(', ')}`);
+    } else {
+      changes.push('Wave 3 agents already present in config');
+    }
+
+    // Append missing Wave 3 workflows (idempotent)
+    const newWorkflows = WAVE3_WORKFLOWS.filter(name => !config.workflows.includes(name));
+    if (newWorkflows.length > 0) {
+      config.workflows.push(...newWorkflows);
+      changes.push(`Appended ${newWorkflows.length} Wave 3 workflow(s): ${newWorkflows.join(', ')}`);
+    } else {
+      changes.push('Wave 3 workflows already present in config');
+    }
+
+    // Write updated config back
+    if (newAgents.length > 0 || newWorkflows.length > 0) {
+      await fs.writeFile(configPath, yaml.dump(config, { indent: 2, lineWidth: -1, noRefs: true }), 'utf8');
+    }
+
+    return changes;
+  }
+};

package/scripts/update/migrations/registry.js

@@ -46,6 +46,13 @@ const MIGRATIONS = [
     breaking: false,
     description: 'No-op delta (refresh handles Wave 2 agents and workflows)',
     module: null
+  },
+  {
+    name: '1.5.x-to-1.6.0',
+    fromVersion: '1.5.x',
+    breaking: false,
+    description: 'Add Wave 3 agents (Mila, Liam, Noah) and 9 workflows to config',
+    module: null
   }
   // Future migrations: append here. Only add delta logic for version-specific changes.
 ];

package/scripts/install-emma.js

@@ -1,14 +0,0 @@
-#!/usr/bin/env node
-
-/**
- * bmad-install-emma — Deprecated. Use bmad-install-vortex-agents instead.
- */
-const YELLOW = '\x1b[33m';
-const RESET = '\x1b[0m';
-
-console.log('');
-console.log(`${YELLOW}⚠  bmad-install-emma is deprecated as of v1.5.0.${RESET}`);
-console.log(`${YELLOW}   Use: npx bmad-install-vortex-agents${RESET}`);
-console.log('');
-
-require('./install-vortex-agents.js');

package/scripts/install-wade.js

@@ -1,14 +0,0 @@
-#!/usr/bin/env node
-
-/**
- * bmad-install-wade — Deprecated. Use bmad-install-vortex-agents instead.
- */
-const YELLOW = '\x1b[33m';
-const RESET = '\x1b[0m';
-
-console.log('');
-console.log(`${YELLOW}⚠  bmad-install-wade is deprecated as of v1.5.0.${RESET}`);
-console.log(`${YELLOW}   Use: npx bmad-install-vortex-agents${RESET}`);
-console.log('');
-
-require('./install-vortex-agents.js');