azeroth-shell 0.2.0 → 0.4.0

package/src/cli/tui.mjs

@@ -9,7 +9,7 @@ import { createCommands } from './repl.mjs';
 import { makeTabs, deathView } from './tuiViews.mjs';
 import { cityAccess, bankDialog, auctionDialog, mailDialog } from './tuiCity.mjs';
 import { startFight, startAutopilot } from './tuiFight.mjs';
-import { openRun } from './tuiDungeon.mjs';
+import { openRun, runCleared, holdRunLonger } from './tuiDungeon.mjs';
 import { openLoot } from './tuiLoot.mjs';
 import { fightPaneRule, fightPaneLines, cycleFightPane, nextPaneId, fightPane } from './tuiFightPanes.mjs';
 import { MemoryPrefs, FilePrefs } from './prefs.mjs';
@@ -24,7 +24,7 @@ import { honorDialog, weeklyHonorPass } from './tuiHonor.mjs';
 import { devCommand } from './tuiDev.mjs';
 import { savePicker } from './tuiSaves.mjs';
 import { wikiDialog } from './tuiWiki.mjs';
-import { bold, dim, cyan, yellow, green, red, inverse, fit, vis, cut, bar, pct, brightYellow, magenta, brightBlue, strip, qualityPaint } from './text.mjs';
+import { bold, dim, cyan, yellow, green, red, inverse, fit, vis, cut, bar, pct, brightYellow, magenta, brightBlue, strip, qualityPaint, coinText } from './text.mjs';
 import { iconsOn, iconArt, iconBlank, wrapIconLines } from './iconArt.mjs';
 import { createGame } from '../engine/game.ts';
 import { toSave } from '../persistence/saveShape.ts';
@@ -33,7 +33,7 @@ import { characterCreation } from './tuiCreate.mjs';
 import { missingHdBytes, downloadHdArt, downloadDir } from './hdArt.mjs';
 import { forgetHdArt } from './modelArt.mjs';
 import { sixelOn } from './sixel.mjs';
-import { moneyText, coinsText } from '../domain/economy/money.ts';
+import { coinsText } from '../domain/economy/money.ts';
 import { maxHealth, maxPower } from '../domain/character/character.ts';
 import { powerType } from '../domain/character/characterStats.ts';
 import { addItem } from '../domain/items/inventory.ts';
@@ -55,6 +55,7 @@ const HELP_LINES = [
   '                           a in the search (or S on World) widens it to the whole world. Enter goes or opens.',
   '  z                        sit and rest 30 s       ?               this help',
   '  Ctrl-C / :quit           save and leave          Ctrl-L          repaint a garbled screen',
+  '  c (World tab) / :logout  save and go back to the character list',
   '',
   'In the world',
   '  Enter on a creature starts a live fight; f fights it instantly. Enter on a quest, vendor, trainer or',
@@ -75,22 +76,24 @@ const HELP_LINES = [
   '  W walks the floor instead: pick a place, the party walks the nav mesh, patrols walk, and what sees you pulls.',
   '',
   'Gear and bags',
-  '  Gear tab: Enter on a slot lists everything in your bags (and the bank, in a bank town) that fits it.',
+  '  Character tab: your gear around you. Enter on a slot lists everything in your bags (and the bank, in a bank town) that fits it.',
+  '  Your stats sit under the tooltip; s opens the rest: weapon skills, professions, auras, home, pet, honor, reputation.',
   '  ▲ marks an upgrade the equipment helper found; u puts on every upgrade at once, x takes a piece off.',
   '  r repairs one piece, R everything; o opens the Outfitter (gear sets). :outfit <name> wears a set from anywhere.',
-  '  In a big enough window the Gear tab is a character sheet (the Talents tab the three trees): Up and Down walk the icons in order, Shift+arrows move across them.',
+  '  In a big enough window the Character tab is a paperdoll (the Talents tab the three trees): Up and Down walk the icons in order, Shift+arrows move across them.',
   '  Bags tab: Enter uses, equips, opens, unwraps or learns; m lists every verb for the stack. s sells to the open',
   '  vendor, j sells junk, b opens the bank, d destroys, S sorts, / splits a stack, [ ] move it, A uses the whole stack.',
   '  D lists every green, blue or epic the group can disenchant; L lists every book someone can learn. G runs it.',
+  '  X marks several stacks to destroy at once; Q marks the quest items left over from quests you turned in. G destroys.',
   '  :dev item|quest|recipe|prof skips the rules (testing). New character offers a random world bot.',
-  '  :settings sets auto-loot, the upgrade helper, auto-disenchant, the junk rules and which nodes get gathered.',
+  '  Settings tab (or :settings) sets auto-loot, the upgrade helper, auto-disenchant, the junk rules and which nodes get gathered.',
   '  Spells tab: b edits your action bars, m your macros. :macro <name> runs one; a macro on bar 1 fires by its key in a fight.',
   '  Loot: with :autoloot off a corpse opens the loot window. Enter takes a row, a takes all, Esc leaves the rest.',
   '',
   'In a fight',
   '  1-9 press an ability    a toggle auto-play    space pause    + - speed    l log    Esc run away',
   '  t gives a companion an order: attack a target, cast one ability, or hold ground (the fight waits).',
-  '  c cancels one of your buffs (also from the Character tab, out of a fight).',
+  '  c cancels one of your buffs (also from s on the Character tab, out of a fight).',
   '  r (in a fight you started with Enter) fights the same creature again after each win, until r again or Esc.',
   '  The ability bar runs along the bottom of the stage with its cooldowns; a takes the keys off the rotation.',
   '',
@@ -188,10 +191,11 @@ export class App {
     this.tabs = makeTabs(this);
     this.stack = [];
     this.lastActivity = g.state.activity[0] ?? null;
+    this.inRunId = g.state.instance?.dungeonId ?? null; // holdRunLonger's last seen run, per character
     this.say(bold(`Welcome${isNew ? '' : ' back'}, ${g.state.char.name}.`) + dim('  Press ? for the keys.'));
     if (awayMs >= 60_000) this.offlineRest(Math.floor(awayMs / 1000));
     weeklyHonorPass(this); // a maintenance day passed while away scores that week
-    if (g.state.instance) openRun(this);
+    if (g.state.instance && !runCleared(this)) openRun(this);
     openLoot(this); // an opened bag item's remainder is still claimable after a reload
     if (!this.term.isTTY) return;
     // Out-of-combat regeneration ticks in real time, like standing still in the world.
@@ -239,6 +243,22 @@ export class App {
     this.onQuit?.();
   }
 
+  /** Save, let go of the character and go back to the character picker. Not in the middle of a fight or a run. */
+  async logout() {
+    if (!this.g) return;
+    if (this.fight || this.auto) { this.flashMsg('Finish the fight or stop the run first.'); this.render(); return; }
+    for (const t of this.timers) this.term.clearInterval(t);
+    this.timers = [];
+    await this.persist();
+    if (this.slot != null) this.repo.unlock?.(this.slot);
+    this.say(dim(`Saved ${this.g.state.char.name}.`));
+    this.g = null; this.slot = null; this.cmds = null; this.vendor = null;
+    this.tabs = []; this.tab = 0; this.stack = [];
+    this.meter = null; this.lootTally = null; this.lastActivity = null;
+    await this.toPicker?.();
+    this.render();
+  }
+
   // ---- small helpers the views lean on -------------------------------------------------------------
 
   get ch() { return this.g.state.char; }
@@ -291,7 +311,7 @@ export class App {
   pick(title, options, onPick, { hint, keepOpen } = {}) {
     const view = {
       id: 'pick', title, hint: hint ?? 'Enter: choose   Esc: back',
-      rows: () => options.map((o) => ({ text: o.label, data: o.value, detail: o.detail ? () => (typeof o.detail === 'function' ? o.detail() : o.detail) : undefined, act: () => { if (!keepOpen) this.pop(); onPick(o.value, o); } })),
+      rows: () => options.map((o) => ({ text: o.label, icon: o.icon, sub: o.sub, data: o.value, detail: o.detail ? () => (typeof o.detail === 'function' ? o.detail() : o.detail) : undefined, act: () => { if (!keepOpen) this.pop(); onPick(o.value, o); } })),
       noDetail: !options.some((o) => o.detail),
     };
     this.push(view);
@@ -481,6 +501,7 @@ export class App {
   /** After any state-changing key: pull activity, save, repaint. */
   afterAction() {
     journeyTick(this);
+    holdRunLonger(this);
     this.flushActivity();
     if (this.g) void this.persist();
     if (this.g && this.isDead() && this.top()?.id !== 'death' && !this.fight) this.push(deathView(this));
@@ -502,6 +523,7 @@ export class App {
     const [, cmd = '', args = ''] = line.match(/^(\S+)\s*(.*)$/) ?? [];
     const c = cmd.toLowerCase();
     if (c === 'quit' || c === 'exit' || c === 'q') { await this.quit(); return; }
+    if (c === 'logout' || c === 'characters') { await this.logout(); return; }
     if (c === 'auto') { const m = args.match(/^(\d+)?\s*(?:farm\s+(.+))?$/i); startAutopilot(this, m?.[1] ? Number(m[1]) : Infinity, m?.[2]); return; }
     if (c === 'art') {
       const missing = missingHdBytes();
@@ -601,7 +623,7 @@ export class App {
   headerLines(L) {
     if (!this.g) {
       const crumbs = this.stack.map((v) => bold(v.title ?? '')).join(dim(' › '));
-      return [bold(' azsh') + dim('  Azeroth shell. WoW Classic 1.12 via CMaNGOS data.'), crumbs ? cut(` ${crumbs}`, L.W) : '', '', dim('─'.repeat(L.W))];
+      return [bold(' azsh') + dim('  Azeroth Shell'), crumbs ? cut(` ${crumbs}`, L.W) : '', '', dim('─'.repeat(L.W))];
     }
     // Watching a run, the name, bars and tabs go: the panel has your frame, and the XP line is what a run is for.
     if (this.compactHeader()) return [runHeaderLine(this, L.W), dim('─'.repeat(L.W))];
@@ -610,7 +632,7 @@ export class App {
     const dead = this.isDead() ? red(bold('  DEAD')) : ch.mountedItem != null ? dim('  mounted') : '';
     const title = ` ${bold(ch.name)} ${dim(`L${ch.level} ${raceName(ch.race)} ${className(ch.cls)}`)}${dead}`;
     const road = journeyHeader(this);
-    const right = `${road ? yellow(road) : cyan(z?.name ?? ch.zoneId)}  ${yellow(moneyText(ch.gold) || '0c')} `;
+    const right = `${road ? yellow(road) : cyan(z?.name ?? ch.zoneId)}  ${coinText(ch.gold)} `;
     const l0 = fit(title, L.W - vis(right)) + right;
     // In a fight the bars follow the live session, so the header is the player's frame and no panel needs another.
     const live = this.fight?.session?.playerView?.() ?? null;
@@ -690,7 +712,11 @@ export class App {
     if (showDetail) {
       const d = cursorRow?.detail?.(this, cursorRow) ?? view.detail?.(this, cursorRow) ?? [];
       detailLines = wrapIconLines(d, L.detailW - 2);
-      if (detailLines.length > L.mainH) detailLines = detailLines.slice(0, L.mainH - 1).concat(dim('…'));
+      // A view's foot (the Character tab's stats) sits at the bottom of the pane when the tooltip keeps room above it.
+      const foot = view.detailFoot ? wrapIconLines(view.detailFoot(this, L.detailW - 2), L.detailW - 2) : [];
+      const room = foot.length && L.mainH - foot.length >= 16 ? L.mainH - foot.length - 1 : L.mainH;
+      if (detailLines.length > room) detailLines = detailLines.slice(0, room - 1).concat(dim('…'));
+      if (room < L.mainH) detailLines = [...detailLines, ...Array(L.mainH - foot.length - detailLines.length).fill(''), ...foot];
     }
     for (let i = 0; i < L.mainH; i++) {
       const left = fit(listLines[i] ?? '', listW);
@@ -745,7 +771,7 @@ export class App {
 export async function runTui({ term = new RealTerm(), argv = [] } = {}) {
   term.open();
   // The tables take a second or two to load: say so, stage by stage, instead of leaving the screen blank.
-  const loading = (stage) => term.draw([bold(' azsh') + dim('  Azeroth shell. WoW Classic 1.12 via CMaNGOS data.'), '', dim(`  Loading ${stage}…`)]);
+  const loading = (stage) => term.draw([bold(' azsh') + dim('  Azeroth Shell'), '', dim(`  Loading ${stage}…`)]);
   loading('the game');
   await new Promise((r) => setImmediate(r)); // the first frame leaves before the synchronous load holds the loop
   const ds = bootDataStore(loading);
@@ -766,6 +792,7 @@ export async function runTui({ term = new RealTerm(), argv = [] } = {}) {
     app.render();
   };
   const reopenPicker = () => savePicker(app, { onPlay: (save) => { void begin(save); }, onNew: createFlow });
+  app.toPicker = reopenPicker;
   const createFlow = () => characterCreation(app, (state) => {
     app.stack = [];
     app.startGame(state, `${state.char.name.toLowerCase()}-${Date.now().toString(36)}`, Date.now(), true);

package/src/cli/tuiAutopilot.mjs

@@ -2,12 +2,12 @@
 // you browse, the run panel between fights (now, next, quests, this run's numbers, what stops it), the Run
 // pane at the bottom (one row per planner step) and the end card. The run itself is the controller in
 // tuiFight.mjs (startAutopilot); the planner is repl.mjs createAutopilot. Everything here only reads.
-import { bold, dim, cyan, yellow, green, red, magenta, inverse, fit, vis, cut, bar, strip, pct, secondsText, wrapLines } from './text.mjs';
+import { bold, dim, cyan, yellow, green, red, magenta, inverse, fit, vis, cut, bar, strip, pct, secondsText, wrapLines, coinText } from './text.mjs';
 import { idlePlayerFrame, startAutopilot, fightArt, flankArt } from './tuiFight.mjs';
 import { objectiveLines, questDialog } from './tuiViews.mjs';
 import { autopilotSettingsDialog } from './tuiAutopilotSettings.mjs';
 import { squadModeOf } from './squad.mjs';
-import { moneyText } from '../domain/economy/money.ts';
+import { iconsOn, iconArt, iconBlank } from './iconArt.mjs';
 import { maxHealth, maxPower } from '../domain/character/character.ts';
 
 const H = (text) => ({ text, header: true, plain: true });
@@ -15,7 +15,7 @@ const H = (text) => ({ text, header: true, plain: true });
 const wrapRows = (lead, text, W) => wrapLines(text, Math.max(20, W - 13)).map((l, i) => H(`${i ? ' '.repeat(11) : lead}${l}`));
 const num = (n) => Math.round(n).toLocaleString('en-US');
 const clock = (ms) => { const s = Math.max(0, Math.floor(ms / 1000)); return `${Math.floor(s / 60)}:${String(s % 60).padStart(2, '0')}`; };
-const signedMoney = (copper) => (copper < 0 ? `-${moneyText(-copper)}` : `+${moneyText(copper) || '0c'}`);
+const signedMoney = (copper) => (copper < 0 ? `-${coinText(-copper)}` : `+${coinText(copper)}`);
 
 /** "questing in Redridge Mountains", "farming Redridge Mystic in …", "doing A Baying of Gnolls". */
 export function runWhat(app, ctl) {
@@ -149,14 +149,23 @@ export function bagsPaneLines(app, L) {
   const items = rows.map((r, i) => i).filter((i) => !rows[i].header);
   if (!items.length) return [` ${bold('Bags')}`, dim(' Nothing in your bags.')];
   if (!items.includes(st.cursor)) st.cursor = items.find((i) => i >= st.cursor) ?? items[items.length - 1];
-  const room = L.logH - 1;
+  // With icons a row is two lines like the Bags tab's list: the icon down the left, the name beside the top
+  // and the row's kind and price beside the bottom.
+  const icons = iconsOn() && L.W >= 40;
+  const room = Math.floor((L.logH - 1) / (icons ? 2 : 1));
   const at = items.indexOf(st.cursor);
   const start = Math.max(0, Math.min(at - Math.floor(room / 2), items.length - room));
   const lines = [` ${bold('Bags')}   ${dim('Up Down: pick   Enter: use, equip, open   the run plays on')}`];
   for (const i of items.slice(start, start + room)) {
-    const r = rows[i];
-    const text = fit(i === st.cursor ? `▶ ${r.text}` : `  ${r.text}`, L.W - 1);
-    lines.push(i === st.cursor ? inverse(text) : ` ${text}`);
+    const r = rows[i], sel = i === st.cursor;
+    if (icons) {
+      const art = iconArt(r.icon, 4) ?? iconBlank(4);
+      const t1 = fit(` ${r.text}`, L.W - 6), t2 = fit(` ${r.sub ?? ''}`, L.W - 6);
+      lines.push(`${sel ? '▶' : ' '}${art[0]}${sel ? inverse(t1) : t1}`, ` ${art[1]}${sel ? inverse(t2) : t2}`);
+      continue;
+    }
+    const text = fit(sel ? `▶ ${r.text}` : `  ${r.text}`, L.W - 1);
+    lines.push(sel ? inverse(text) : ` ${text}`);
   }
   return lines;
 }
@@ -229,7 +238,7 @@ function runLine(app, ctl) {
 // ---- the Run pane ----------------------------------------------------------------------------------
 
 const GLYPH = {
-  fight: red('⚔'), wait: dim('~'), consume: dim('~'), cannibalize: dim('~'), turnin: green('✓'), accept: green('+'), travel: cyan('→'),
+  fight: red('⚔'), buff: cyan('↑'), wait: dim('~'), consume: dim('~'), cannibalize: dim('~'), turnin: green('✓'), accept: green('+'), travel: cyan('→'),
   gather: yellow('⚒'), skin: yellow('⚒'), buy: yellow('$'), equip: green('▲'), skip: yellow('✗'), dead: red('☠'), stop: yellow('■'),
 };
 

package/src/cli/tuiBags.mjs

@@ -3,17 +3,23 @@
 // held-item menu (panels/heldItemMenu.ts) is the reference; every verb is a Game facade call.
 import { bold, dim, yellow, green, red, qualityPaint, itemText } from './text.mjs';
 import { autoLootOn, openLoot, takeAll } from './tuiLoot.mjs';
-import { SLOT_LABEL, bagCapacity } from '../domain/items/equipment.ts';
+import { SLOT_LABEL, bagCapacity, equipSlotPickTargets, DUAL_WIELD_SPELL_ID } from '../domain/items/equipment.ts';
+import { equippedEntry } from '../domain/items/itemInstance.ts';
+import { knows } from '../domain/character/spellbook.ts';
+import { isDisenchantable, disenchantRuleFor } from '../domain/professions/enchanting.ts';
+import { resolveRosterEnchanters, groupHasEnchanting, partyDisenchantCheck } from '../domain/professions/partyDisenchant.ts';
 import { freeSlots, isWrappingPaper, isFilledGift, canWrapTarget } from '../domain/items/inventory.ts';
 import { isOpenableContainer } from '../domain/items/itemContainer.ts';
 import { isAmmoItem } from '../domain/items/ammo.ts';
 import { itemTeachIntent } from '../domain/items/itemTeaches.ts';
 import { junkListOptions } from './tuiSettings.mjs';
-import { isMountItem, toggleMount } from './tuiWorld.mjs';
-import { questDialog } from './tuiViews.mjs';
+import { isMountItem, toggleMount, afterDeparture } from './tuiWorld.mjs';
+import { questDialog, landOnTab } from './tuiViews.mjs';
 import { useItemWithPicker, isPermanentEnchantItem } from './tuiEnchantTarget.mjs';
 import { bagQuestStartState } from '../quests/quests.ts';
 
+const HEARTHSTONE_ITEM_ENTRY = 6948; // phonecraft src/ui/map/travelUi.ts
+
 const stacks = (app) => app.g.state.inventory.stacks;
 const hasLoot = (app) => (entry) => app.ds.lootTable(`item:${entry}`).length > 0;
 const isContainer = (app, it) => isOpenableContainer(it, hasLoot(app));
@@ -55,7 +61,8 @@ export function useStack(app, slot) {
   }
   if (isWrappingPaper(it)) { wrapWith(app, slot); return; }
   if (isContainer(app, it)) { openContainer(app, slot); return; }
-  if (it?.slot) { const r = app.g.equip(s.item); app.result(r, r.ok ? (it.slot === 'bag' ? `You equip ${itemText(it)} as ${SLOT_LABEL[r.slot] ?? r.slot}.` : `You equip ${itemText(it)}.`) : ''); return; }
+  if (s.item === HEARTHSTONE_ITEM_ENTRY) { const r = app.g.castHearth(); if (app.result(r)) { app.vendor = null; afterDeparture(app, () => `You hearth to ${app.zone()?.name}.`); landOnTab(app); } return; }
+  if (it?.slot) { equipFromBags(app, it); return; }
   if (isAmmoItem(it)) {
     if (app.ch.ammoItem === it.entry) app.result(app.g.clearAmmo(), 'You put your ammo away.');
     else app.result(app.g.setAmmo(s.item), `You load ${itemText(it)}.`);
@@ -67,6 +74,30 @@ export function useStack(app, slot) {
   useItemWithPicker(app, s.item, (r) => (r.learned ? green(`You learn ${r.learned.name}.`) : green(`You use ${itemText(it)}.  HP ${app.hpText()}  ${app.pwText()}`)));
 }
 
+/** Equip from the bags. With both rings, both trinkets or both hands full it asks which to replace rather than
+ * overwrite the first (phonecraft equipSlotPicker.ts); an empty one of the pair still fills by itself. */
+function equipFromBags(app, it) {
+  const done = (r) => app.result(r, r.ok ? (it.slot === 'bag' ? `You equip ${itemText(it)} as ${SLOT_LABEL[r.slot] ?? r.slot}.` : `You equip ${itemText(it)}.`) : '');
+  const ch = app.ch, slots = equipSlotPickTargets(ch, it, { canDualWield: knows(app.g.state.spellbook, DUAL_WIELD_SPELL_ID) });
+  if (slots.length < 2) { done(app.g.equip(it.entry)); return; }
+  const opts = slots.map((slot) => { const cur = equippedEntry(ch.equipped[slot]); return { label: `${SLOT_LABEL[slot] ?? slot}: ${cur != null ? itemText(app.ds.item(cur)) : dim('empty')}`, value: slot }; });
+  app.pick(`Equip ${itemText(it)}: replace which?`, opts, (slot) => done(app.g.equip(it.entry, slot)));
+}
+
+/** Disenchant on one stack, for anyone in the group with the skill: hidden when nobody has Enchanting or the item
+ * yields nothing, the reason shown when the group is short of the skill. Ref heldItemMenu.ts disenchantRow. */
+function disenchantOption(app, slot, s, it) {
+  if (!it || !isDisenchantable(it) || it.quality < 2 || !disenchantRuleFor(it, app.ds)) return null;
+  const g = app.g, enchanters = resolveRosterEnchanters(app.ch, g.state.squad, g.state.botRoster, g.state.raidRoster?.members, app.ds);
+  if (!groupHasEnchanting(enchanters)) return null;
+  const chk = partyDisenchantCheck(s.item, g.state.inventory, app.ds, enchanters);
+  if (!chk.ok) return chk.kind === 'skill' ? { label: `Disenchant  ${dim(chk.reason)}`, value: () => app.flashMsg(chk.reason) } : null;
+  return { label: `Disenchant${chk.who.kind === 'companion' ? dim(`  ${chk.who.name}, Enchanting ${chk.who.skill}`) : ''}`, value: () => {
+    const r = g.disenchantStack(slot);
+    if (app.result(r)) app.say(green(`${r.worker ? `${r.worker} breaks down` : 'You break down'} ${itemText(it)}: ${r.yielded.map((y) => `${app.itemLabel(y.item)}${y.count > 1 ? ` x${y.count}` : ''}`).join(', ') || 'nothing'}.`) + (r.skillUp != null && !r.worker ? dim(`  Enchanting ${r.skillUp}`) : ''));
+  } };
+}
+
 /** Open a clam, crate or lockbox into the loot window; auto-loot takes what fits straight away. */
 export function openContainer(app, slot) {
   const name = app.itemLabel(stacks(app)[slot]?.item);
@@ -159,6 +190,8 @@ export function itemMenu(app, slot) {
   if (slot > 0) opts.push({ label: `Move up  ${dim('[')}`, value: () => moveStack(app, slot, -1) });
   if (slot < stacks(app).length - 1) opts.push({ label: `Move down  ${dim(']')}`, value: () => moveStack(app, slot, +1) });
   opts.push({ label: `Move to the end`, value: () => app.result(app.g.moveItem(slot, stacks(app).length)) });
+  const de = disenchantOption(app, slot, s, it);
+  if (de) opts.push(de);
   opts.push(...junkListOptions(app, s.item));
   opts.push({ label: red(`Destroy  ${dim('d')}`), value: () => destroyStack(app, slot) });
   app.pick(`${itemText(it, 'Item')}${countText(s)}`, opts, (fn) => fn());

package/src/cli/tuiBulk.mjs

@@ -1,13 +1,14 @@
-// The two bulk bag verbs from phonecraft's bag bar (panels/bagBulkPanel.ts, app/appInteractBulkBags.ts): break
-// down a quality band, and read every recipe, formula and book in the bags onto whoever can take it. Both list
-// first; Enter switches a row off or on, G runs what is on. Rows a quest still needs or that are still an upgrade
+// The bulk bag verbs from phonecraft's bag bar (panels/bagBulkPanel.ts, app/appInteractBulkBags.ts): break
+// down a quality band, read every recipe, formula and book in the bags onto whoever can take it, and destroy
+// several stacks at once (the trash skull's multi-select, and the leftover-quest-items sweep). All list first;
+// Enter switches a row off or on, G runs what is on. Rows a quest still needs or that are still an upgrade
 // start off. p switches between your bags and the whole party's. The runs go through the same engine verbs a
 // single press uses, so a bulk pass never accepts what one-at-a-time would refuse.
 import { bold, dim, yellow, green, red, qualityPaint, plural, itemText } from './text.mjs';
 import { planBulkDisenchant, resolveRosterEnchanters, activeBulkDisenchantRows, bulkDisenchantRowKey } from '../domain/professions/partyDisenchant.ts';
 import { companionsForUpgradeGuard, partyUpgradeEntries, playerEquipOptsFrom } from '../domain/professions/autoDisenchant.ts';
 import { planLearnAllFromBags, activeLearnAllRows } from '../domain/professions/learnAllRecipes.ts';
-import { questNeededItems } from '../domain/quests/questlog.ts';
+import { questNeededItems, leftoverQuestItems } from '../domain/quests/questlog.ts';
 import { itemTeachIntent } from '../domain/items/itemTeaches.ts';
 import { learnOnCompanionPool } from '../domain/spells/learnOnTargets.ts';
 
@@ -160,3 +161,81 @@ function runLearnAll(app, state) {
   const spare = rows.reduce((n, r) => n + r.spare, 0);
   app.say(green(`Learned ${plural(learned, 'book')}.`) + (spare ? dim(`  ${spare} duplicate${spare === 1 ? '' : 's'} left to sell.`) : '') + (firstRefusal ? yellow(`  One refused: ${firstRefusal}.`) : ''));
 }
+
+const DESTROY_TABS = [['all', 'Everything'], ['quest', 'Leftover quest items']];
+
+/** Every stack in scope with its owner, plus the quests a leftover one belonged to (turned in, not repeatable,
+ * not wanted by an open quest: phonecraft's leftoverQuestItems). */
+function destroyCandidates(app, scope) {
+  const st = app.g.state, out = [];
+  for (const { inventory, owner } of bagsInScope(app.g, scope)) {
+    const left = new Map(leftoverQuestItems(st.questlog, inventory, (e) => app.ds.quest(e), (e) => app.ds.item(e), app.ds.quests()).map((r) => [r.slot, r.quests]));
+    inventory.stacks.forEach((stack, slot) => { if (stack) out.push({ stack, owner, quests: left.get(slot) ?? null }); });
+  }
+  return out;
+}
+
+/** Destroy several stacks at once: the trash skull's multi-select from phonecraft's bags (bagsPanel.ts
+ * destroySelectMode) and its leftover-quest-items sweep in one list. Marks are the stack objects themselves,
+ * so a slot shifting under a destroy never lands on the wrong item. */
+export function destroyManyDialog(app, tab = 'all', scope = 'player') {
+  const state = { tab, scope, marked: new Set() };
+  const shown = (a) => destroyCandidates(a, state.scope).filter((c) => state.tab === 'all' || c.quests);
+  const markLeftovers = (a) => { for (const c of destroyCandidates(a, state.scope)) if (c.quests) state.marked.add(c.stack); };
+  if (tab === 'quest') markLeftovers(app);
+  return {
+    id: 'destroy-many', title: 'Destroy', hint: 'Enter: mark / unmark',
+    keys: {
+      G: { hint: 'destroy', fn: (a) => confirmDestroyMany(a, state) },
+      tab: { hint: 'everything / quest leftovers', fn: (a) => { state.tab = state.tab === 'all' ? 'quest' : 'all'; a.top().cursor = 0; } },
+      a: { hint: 'mark all shown', fn: (a) => { for (const c of shown(a)) state.marked.add(c.stack); } },
+      c: { hint: 'clear', fn: () => state.marked.clear() },
+      p: { hint: 'yours / party', fn: (a) => { state.scope = state.scope === 'party' ? 'player' : 'party'; state.marked.clear(); if (state.tab === 'quest') markLeftovers(a); } },
+    },
+    rows(a) {
+      const all = destroyCandidates(a, state.scope);
+      const rows = state.tab === 'all' ? all : all.filter((c) => c.quests);
+      const on = all.filter((c) => state.marked.has(c.stack));
+      const tabs = DESTROY_TABS.map(([t, label]) => (t === state.tab ? bold(`[${label}]`) : dim(label))).join('  ');
+      const out = [H(`${tabs}   ${dim(state.scope === 'party' ? 'the party\'s bags' : 'your bags')}`), H(on.length ? red(`${plural(on.length, 'stack')} (${plural(on.reduce((n, c) => n + c.stack.count, 0), 'item')}) marked. G: destroy`) : dim('Nothing marked. Enter marks a stack, a marks every one shown.')), H('')];
+      if (!rows.length) out.push(H(dim(state.tab === 'quest' ? '  No quest items left over from quests you have turned in.' : '  The bags are empty.')));
+      for (const c of rows) {
+        const it = a.ds.item(c.stack.item);
+        const isOn = state.marked.has(c.stack);
+        const from = c.quests ? c.quests.map((q) => q.title).join(', ') : '';
+        out.push({
+          text: `${isOn ? red('✗') : dim('·')} ${qualityPaint(it?.quality)(it?.name ?? c.stack.item)}${c.stack.count > 1 ? ` x${c.stack.count}` : ''}${c.owner ? dim(`  ${c.owner.name}'s bags`) : ''}${from ? dim(`  ${from}`) : ''}`,
+          detail: () => [bold(itemText(it, '')), ...(from ? ['', dim(`Left over from ${from}.`)] : []), '', dim(isOn ? 'Enter: keep it' : 'Enter: mark it to destroy')],
+          act: () => { if (isOn) state.marked.delete(c.stack); else state.marked.add(c.stack); },
+        });
+      }
+      return out;
+    },
+  };
+}
+
+function confirmDestroyMany(app, state) {
+  // Slots resolved now, before anything splices: highest first per owner, as phonecraft's doDiscardSelected.
+  const targets = [];
+  for (const { inventory, owner } of bagsInScope(app.g, state.scope)) {
+    inventory.stacks.forEach((s, slot) => { if (state.marked.has(s)) targets.push({ owner: owner?.id, slot, item: s.item, count: s.count }); });
+  }
+  if (!targets.length) { app.flashMsg('Nothing marked.'); return; }
+  const pieces = targets.reduce((n, t) => n + t.count, 0);
+  const what = targets.length === 1 ? `${app.itemLabel(targets[0].item)}${pieces > 1 ? ` x${pieces}` : ''}` : `${plural(targets.length, 'stack')} (${plural(pieces, 'item')})`;
+  app.confirm(`Destroy ${what}? This cannot be undone.`, () => {
+    const g = app.g;
+    let stacks = 0, gone = 0, firstRefusal = '';
+    targets.sort((a, b) => (a.owner ?? '').localeCompare(b.owner ?? '') || b.slot - a.slot);
+    for (const t of targets) {
+      const bags = t.owner ? bagsInScope(g, 'party').find((b) => b.owner.id === t.owner)?.inventory : g.state.inventory;
+      if (bags?.stacks[t.slot]?.item !== t.item) continue;
+      const r = t.owner ? g.discardCompanionBagStack(t.owner, t.slot) : g.discardBagStack(t.slot);
+      if (!r.ok) { firstRefusal ||= r.reason ?? 'Cannot destroy'; continue; }
+      stacks++; gone += r.discarded;
+    }
+    state.marked.clear();
+    if (!stacks) { app.say(red(firstRefusal || 'Nothing was destroyed.')); return; }
+    app.say(green(stacks === 1 ? `Destroyed ${what}.` : `Destroyed ${plural(stacks, 'stack')} (${plural(gone, 'item')}).`) + (firstRefusal ? yellow(`  One refused: ${firstRefusal}.`) : ''));
+  });
+}