axe-core 4.3.4 → 4.3.5-canary.b451f2e

package/CHANGELOG.md

@@ -2,6 +2,52 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [4.3.5-canary.b451f2e](https://github.com/dequelabs/axe-core/compare/v4.3.5...v4.3.5-canary.b451f2e) (2021-11-05)
+
+
+### Features
+
+* add new ARIA roles ([#3138](https://github.com/dequelabs/axe-core/issues/3138)) ([61be7e5](https://github.com/dequelabs/axe-core/commit/61be7e555152d89c6770679fd6fdac10038f7cd3))
+* **aria-allowed-attr:** report violations for non-global ARIA attributes on elements without a role ([#3102](https://github.com/dequelabs/axe-core/issues/3102)) ([87cfc0b](https://github.com/dequelabs/axe-core/commit/87cfc0b4f4d998a88a2d534438e4f2ccf9427a86))
+
+
+### Bug Fixes
+
+* **aria-allowed-attr:** check for invalid `aria-attributes` for `role="row"` ([#3160](https://github.com/dequelabs/axe-core/issues/3160)) ([cfa900d](https://github.com/dequelabs/axe-core/commit/cfa900d57265907b638dad36ba405a5b40dbde9c))
+* **aria-allowed-attr:** revert violation for non-global ARIA attrs on element without role ([#3243](https://github.com/dequelabs/axe-core/issues/3243)) ([112b960](https://github.com/dequelabs/axe-core/commit/112b960ee95b6a6abfb38a15b7092d9847512f0f))
+* **aria-allowed-children,aria-allowed-parent:** allow group role in listbox ([#3195](https://github.com/dequelabs/axe-core/issues/3195)) ([cb01975](https://github.com/dequelabs/axe-core/commit/cb019755d9cb52b997aae340f406ac26d0cf90e5))
+* **aria-allowed-roles:** update role allowances for section element ([#3238](https://github.com/dequelabs/axe-core/issues/3238)) ([99676ec](https://github.com/dequelabs/axe-core/commit/99676ece547be39d71e776a5b9cae2da41c31572)), closes [#3237](https://github.com/dequelabs/axe-core/issues/3237)
+* **aria-allowed-role:** Update allowed roles based on ARIA spec updates ([#3124](https://github.com/dequelabs/axe-core/issues/3124)) ([00f6efc](https://github.com/dequelabs/axe-core/commit/00f6efcd55eb0a4c56cc3ca1acc7c79e3d22f58d))
+* **aria-allowed-role:** updates the allowed roles for the wbr element to none and presentation ([#3192](https://github.com/dequelabs/axe-core/issues/3192)) ([2f439b3](https://github.com/dequelabs/axe-core/commit/2f439b3fdb7e7fa3228e663c5313af0f08aa4327)), closes [#3177](https://github.com/dequelabs/axe-core/issues/3177)
+* **aria-prohibited-attr:** update metadata message ([#3206](https://github.com/dequelabs/axe-core/issues/3206)) ([d1a768e](https://github.com/dequelabs/axe-core/commit/d1a768eaefe6d1c95e925174bc979bc7a95ee7d9))
+* **autocomplete-valid:** Allow custom autocomplete attribute values ([#3225](https://github.com/dequelabs/axe-core/issues/3225)) ([6076ee8](https://github.com/dequelabs/axe-core/commit/6076ee8a7ba7527c9886916db1eda5d90cd26259))
+* **axe.configure:** do not remove newline characters from locale doT strings ([#3216](https://github.com/dequelabs/axe-core/issues/3216)) ([ea2ce17](https://github.com/dequelabs/axe-core/commit/ea2ce171fd7562e6b85471e72dddc84be23a4297))
+* **axe.run:** add option to increase iframe ping timeout ([#3233](https://github.com/dequelabs/axe-core/issues/3233)) ([ec937e3](https://github.com/dequelabs/axe-core/commit/ec937e3e147274cbdbba2b046a651c90623130e4))
+* check for hidden elements on `aria-errormessage`           ([#3156](https://github.com/dequelabs/axe-core/issues/3156)) ([95d37dd](https://github.com/dequelabs/axe-core/commit/95d37dd794dc8552d731fabf45244b260da53d8f))
+* **color-contrast:** account for 0 width scroll regions with children ([#3172](https://github.com/dequelabs/axe-core/issues/3172)) ([5908f0d](https://github.com/dequelabs/axe-core/commit/5908f0d644c20e7091329bd8bbeb191837d27feb))
+* **color-contrast:** account for elements that do not fill entire bounding size ([#3186](https://github.com/dequelabs/axe-core/issues/3186)) ([699697b](https://github.com/dequelabs/axe-core/commit/699697bc237b6c69050e4572ba5cfdc5f338f450))
+* **color-contrast:** correctly apply page background color ([#3207](https://github.com/dequelabs/axe-core/issues/3207)) ([fbc581d](https://github.com/dequelabs/axe-core/commit/fbc581d77e457fe092ecc2b95015e667292f1a08))
+* **color-contrast:** correctly compute color-contrast of truncated children ([#3203](https://github.com/dequelabs/axe-core/issues/3203)) ([ac7b2b5](https://github.com/dequelabs/axe-core/commit/ac7b2b5ec402e9de91c50ef39aefd5843f0d62bb))
+* **color-contrast:** correctly handle nested scroll regions ([#3212](https://github.com/dequelabs/axe-core/issues/3212)) ([22db29c](https://github.com/dequelabs/axe-core/commit/22db29ca7e9964a8447392fba45a09057a926ab9))
+* **color-contrast:** correctly work with positioned elements without z-index ([#3209](https://github.com/dequelabs/axe-core/issues/3209)) ([725a20c](https://github.com/dequelabs/axe-core/commit/725a20c91b9006e64009059f0ab9d1a0098d29df))
+* **color-contrast:** properly blend multiple alpha colors ([#3193](https://github.com/dequelabs/axe-core/issues/3193)) ([e930a70](https://github.com/dequelabs/axe-core/commit/e930a7081d4308549370f74e9d341badd9661584))
+* **d.ts:** Add PartialResults type ([#3126](https://github.com/dequelabs/axe-core/issues/3126)) ([544b6d5](https://github.com/dequelabs/axe-core/commit/544b6d579f3eecf8e102a53a911bbce0bd53b74f))
+* greater consistency of help / description text ([#3204](https://github.com/dequelabs/axe-core/issues/3204)) ([0677565](https://github.com/dequelabs/axe-core/commit/0677565941486cf339e7267760d4e533d4a29a05))
+* **is-visible:** do not error if window.Node does not exist ([#3168](https://github.com/dequelabs/axe-core/issues/3168)) ([4046087](https://github.com/dequelabs/axe-core/commit/404608773abf7b4d069a64931adf4ac7e942b663))
+* **label-title-only:** allow hidden labels ([#3183](https://github.com/dequelabs/axe-core/issues/3183)) ([cad3994](https://github.com/dequelabs/axe-core/commit/cad39949c29bc3f83863e3484feef82e89e12118))
+* **nativeSelectValue:** update selected value on change ([#3154](https://github.com/dequelabs/axe-core/issues/3154)) ([1ee88cb](https://github.com/dequelabs/axe-core/commit/1ee88cb4bb557560f10eab136464c321d4dee81e))
+* **nested-interactive:** add message for negative tabindex ([#3194](https://github.com/dequelabs/axe-core/issues/3194)) ([b445291](https://github.com/dequelabs/axe-core/commit/b44529130568347816fa810c959b68f980161241)), closes [#2466](https://github.com/dequelabs/axe-core/issues/2466) [#2934](https://github.com/dequelabs/axe-core/issues/2934) [/github.com/dequelabs/axe-core/issues/3163#issuecomment-949804464](https://github.com/dequelabs//github.com/dequelabs/axe-core/issues/3163/issues/issuecomment-949804464)
+* **p-as-heading:** `p-as-heading` rule to account for `textContent` length ([#3145](https://github.com/dequelabs/axe-core/issues/3145)) ([400a230](https://github.com/dequelabs/axe-core/commit/400a2308510246d64d37fac3db375201610cd7e7))
+* **reporter:** Run inside isolated contexts ([#3129](https://github.com/dequelabs/axe-core/issues/3129)) ([afe6675](https://github.com/dequelabs/axe-core/commit/afe6675d2452089602dcc6c9e931987936e9a55a))
+* Separate Level AAA rules from A and best-practices ([#3191](https://github.com/dequelabs/axe-core/issues/3191)) ([828e526](https://github.com/dequelabs/axe-core/commit/828e526fd06ee596df73f4825e750aad459ca75e))
+* **typescript:** allow passing a NodeList to ElementContext ([#3161](https://github.com/dequelabs/axe-core/issues/3161)) ([ad4b165](https://github.com/dequelabs/axe-core/commit/ad4b165a0e019cd65f70fa5d085d83cea3e7338c))
+
+### [4.3.5](https://github.com/dequelabs/axe-core/compare/v4.3.4...v4.3.5) (2021-10-29)
+
+### Bug Fixes
+
+- **aria-allowed-attr:** revert violation for non-global ARIA attrs on element without role ([#3243](https://github.com/dequelabs/axe-core/issues/3243)) ([e138fd6](https://github.com/dequelabs/axe-core/commit/e138fd6a00a8da6c48a74a614adc5dae8f2044e1))
+
 ### [4.3.4](https://github.com/dequelabs/axe-core/compare/v4.3.3...v4.3.4) (2021-10-22)
 
 ### Bug Fixes

package/README.md

@@ -6,7 +6,7 @@
 [![Commits](https://img.shields.io/github/commit-activity/y/dequelabs/axe-core.svg)](https://github.com/dequelabs/axe-core/commits/develop)
 [![GitHub contributors](https://img.shields.io/github/contributors/dequelabs/axe-core.svg)](https://github.com/dequelabs/axe-core/graphs/contributors)
 [![Join our Slack chat](https://img.shields.io/badge/slack-chat-purple.svg?logo=slack)](https://accessibility.deque.com/axe-community)
-[![Package Quality](http://npm.packagequality.com/shield/axe-core.svg)](http://packagequality.com/#?package=axe-core)
+[![Package Quality](https://npm.packagequality.com/shield/axe-core.svg)](https://packagequality.com/#?package=axe-core)
 
 Axe is an accessibility testing engine for websites and other HTML-based user interfaces. It's fast, secure, lightweight, and was built to seamlessly integrate with any existing test environment so you can automate accessibility testing alongside your regular functional testing.
 

package/axe.js

@@ -1,4 +1,4 @@
-/*! axe v4.3.4
+/*! axe v4.3.5-canary.b451f2e
  * Copyright (c) 2021 Deque Systems, Inc.
  *
  * Your use of this Source Code Form is subject to the terms of the Mozilla Public
@@ -27,7 +27,7 @@
     return _typeof(obj);
   }
   var axe = axe || {};
-  axe.version = '4.3.4';
+  axe.version = '4.3.5-canary.b451f2e';
   if (typeof define === 'function' && define.amd) {
     define('axe-core', [], function() {
       return axe;
@@ -8474,6 +8474,11 @@
         allowedAttrs: [ 'aria-expanded' ],
         superclassRole: [ 'landmark' ]
       },
+      comment: {
+        type: 'structure',
+        allowedAttrs: [ 'aria-level', 'aria-posinset', 'aria-setsize' ],
+        superclassRole: [ 'article' ]
+      },
       definition: {
         type: 'structure',
         allowedAttrs: [ 'aria-expanded' ],
@@ -8664,6 +8669,11 @@
         accessibleNameRequired: true,
         childrenPresentational: true
       },
+      mark: {
+        type: 'structure',
+        superclassRole: [ 'section' ],
+        prohibitedAttrs: [ 'aria-label', 'aria-labelledby' ]
+      },
       navigation: {
         type: 'landmark',
         allowedAttrs: [ 'aria-expanded' ],
@@ -8843,6 +8853,12 @@
         nameFromContent: true,
         childrenPresentational: true
       },
+      suggestion: {
+        type: 'structure',
+        requiredOwned: [ 'insertion', 'deletion' ],
+        superclassRole: [ 'section' ],
+        prohibitedAttrs: [ 'aria-label', 'aria-labelledby' ]
+      },
       tab: {
         type: 'widget',
         requiredContext: [ 'tablist' ],
@@ -9717,7 +9733,7 @@
       },
       section: {
         contentTypes: [ 'sectioning', 'flow' ],
-        allowedRoles: [ 'alert', 'alertdialog', 'application', 'banner', 'complementary', 'contentinfo', 'dialog', 'document', 'feed', 'log', 'main', 'marquee', 'navigation', 'none', 'note', 'presentation', 'search', 'status', 'tabpanel', 'doc-abstract', 'doc-acknowledgments', 'doc-afterword', 'doc-appendix', 'doc-bibliography', 'doc-chapter', 'doc-colophon', 'doc-conclusion', 'doc-credit', 'doc-credits', 'doc-dedication', 'doc-endnotes', 'doc-epigraph', 'doc-epilogue', 'doc-errata', 'doc-example', 'doc-foreword', 'doc-glossary', 'doc-index', 'doc-introduction', 'doc-notice', 'doc-pagelist', 'doc-part', 'doc-preface', 'doc-prologue', 'doc-pullquote', 'doc-qna', 'doc-toc' ],
+        allowedRoles: [ 'alert', 'alertdialog', 'application', 'banner', 'complementary', 'contentinfo', 'dialog', 'document', 'feed', 'group', 'log', 'main', 'marquee', 'navigation', 'none', 'note', 'presentation', 'search', 'status', 'tabpanel', 'doc-abstract', 'doc-acknowledgments', 'doc-afterword', 'doc-appendix', 'doc-bibliography', 'doc-chapter', 'doc-colophon', 'doc-conclusion', 'doc-credit', 'doc-credits', 'doc-dedication', 'doc-endnotes', 'doc-epigraph', 'doc-epilogue', 'doc-errata', 'doc-example', 'doc-foreword', 'doc-glossary', 'doc-index', 'doc-introduction', 'doc-notice', 'doc-pagelist', 'doc-part', 'doc-preface', 'doc-prologue', 'doc-pullquote', 'doc-qna', 'doc-toc' ],
         shadowRoot: true
       },
       select: {
@@ -15828,7 +15844,7 @@
       ariaAttr.forEach(function(attr) {
         preChecks[attr] = validateRowAttrs;
       });
-      if (allowed) {
+      if (role && allowed) {
         for (var _i14 = 0; _i14 < attrs.length; _i14++) {
           var _preChecks$attrName;
           var attrName = attrs[_i14];
@@ -17886,7 +17902,7 @@
     function internalLinkPresentEvaluate(node, options, virtualNode) {
       var links = query_selector_all_default(virtualNode, 'a[href]');
       return links.some(function(vLink) {
-        return /^#[^/!]/.test(vLink.actualNode.getAttribute('href'));
+        return /^#[^/!]/.test(vLink.attr('href'));
       });
     }
     var internal_link_present_evaluate_default = internalLinkPresentEvaluate;
@@ -18620,7 +18636,7 @@
         return focusableDescendants(child);
       });
     }
-    function noFocusbleContentEvaluate(node, options, virtualNode) {
+    function frameFocusableContentEvaluate(node, options, virtualNode) {
       if (!virtualNode.children) {
         return void 0;
       }
@@ -18632,7 +18648,49 @@
         return void 0;
       }
     }
-    var no_focusable_content_evaluate_default = noFocusbleContentEvaluate;
+    var frame_focusable_content_evaluate_default = frameFocusableContentEvaluate;
+    function getFocusableDescendants(vNode) {
+      if (!vNode.children) {
+        if (vNode.props.nodeType === 1) {
+          throw new Error('Cannot determine children');
+        }
+        return [];
+      }
+      var retVal = [];
+      vNode.children.forEach(function(child) {
+        if (is_focusable_default(child)) {
+          retVal.push(child);
+        } else {
+          retVal.push.apply(retVal, _toConsumableArray(getFocusableDescendants(child)));
+        }
+      });
+      return retVal;
+    }
+    function usesUnreliableHidingStrategy(vNode) {
+      var tabIndex = parseInt(vNode.attr('tabindex'), 10);
+      return !isNaN(tabIndex) && tabIndex < 0;
+    }
+    function noFocusableContentEvaluate(node, options, virtualNode) {
+      if (!virtualNode.children) {
+        return void 0;
+      }
+      try {
+        var focusableDescendants2 = getFocusableDescendants(virtualNode);
+        if (focusableDescendants2.length > 0) {
+          var notHiddenElements = focusableDescendants2.filter(usesUnreliableHidingStrategy);
+          if (notHiddenElements.length > 0) {
+            this.data({
+              messageKey: 'notHidden'
+            });
+            this.relatedNodes(notHiddenElements);
+          }
+        }
+        return focusableDescendants2.length === 0;
+      } catch (e) {
+        return void 0;
+      }
+    }
+    var no_focusable_content_evaluate_default = noFocusableContentEvaluate;
     function tabindexEvaluate(node, options, virtualNode) {
       var tabIndex = parseInt(virtualNode.attr('tabindex'), 10);
       return isNaN(tabIndex) ? true : tabIndex <= 0;
@@ -19667,6 +19725,7 @@
       'focusable-no-name-evaluate': focusable_no_name_evaluate_default,
       'focusable-not-tabbable-evaluate': focusable_not_tabbable_evaluate_default,
       'landmark-is-top-level-evaluate': landmark_is_top_level_evaluate_default,
+      'frame-focusable-content-evaluate': frame_focusable_content_evaluate_default,
       'no-focusable-content-evaluate': no_focusable_content_evaluate_default,
       'tabindex-evaluate': tabindex_evaluate_default,
       'alt-space-value-evaluate': alt_space_value_evaluate_default,
@@ -21850,7 +21909,7 @@
           help: 'Zooming and scaling should not be disabled'
         },
         'nested-interactive': {
-          description: 'Ensure controls are not nested as they are not announced by screen readers',
+          description: 'Ensures interactive controls are not nested as they are not always announced by screen readers or can cause focus problems for assistive technologies',
           help: 'Interactive controls must not be nested'
         },
         'no-autoplay-audio': {
@@ -22272,7 +22331,10 @@
           impact: 'serious',
           messages: {
             pass: 'Element does not have focusable descendants',
-            fail: 'Element has focusable descendants',
+            fail: {
+              default: 'Element has focusable descendants',
+              notHidden: 'Using a negative tabindex on an element inside an interactive control does not prevent a screen reader from focusing the element (even with \'aria-hidden=true\')'
+            },
             incomplete: 'Could not determine if element has descendants'
           }
         },
@@ -23126,7 +23188,12 @@
       matches: 'autocomplete-matches',
       tags: [ 'cat.forms', 'wcag21aa', 'wcag135' ],
       actIds: [ '73f2c2' ],
-      all: [ 'autocomplete-valid' ],
+      all: [ {
+        options: {
+          stateTerms: [ 'none', 'false', 'true', 'disabled', 'enabled', 'undefined', 'null' ]
+        },
+        id: 'autocomplete-valid'
+      } ],
       any: [],
       none: []
     }, {
@@ -24065,7 +24132,10 @@
       deprecated: true
     }, {
       id: 'autocomplete-valid',
-      evaluate: 'autocomplete-valid-evaluate'
+      evaluate: 'autocomplete-valid-evaluate',
+      options: {
+        stateTerms: [ 'none', 'false', 'true', 'disabled', 'enabled', 'undefined', 'null' ]
+      }
     }, {
       id: 'accesskeys',
       evaluate: 'accesskeys-evaluate',
@@ -24090,7 +24160,7 @@
       evaluate: 'focusable-not-tabbable-evaluate'
     }, {
       id: 'frame-focusable-content',
-      evaluate: 'no-focusable-content-evaluate'
+      evaluate: 'frame-focusable-content-evaluate'
     }, {
       id: 'landmark-is-top-level',
       evaluate: 'landmark-is-top-level-evaluate'