autosnippet 3.0.1 → 3.0.2

package/lib/service/skills/SkillAdvisor.js

@@ -57,37 +57,37 @@ export class SkillAdvisor {
     try {
       const guardInsights = this.#analyzeGuardPatterns();
       analysisContext.guard = guardInsights.summary;
-      suggestions.push(...guardInsights.suggestions.filter(
-        s => !existingSkills.has(s.name),
-      ));
-    } catch { /* silent */ }
+      suggestions.push(...guardInsights.suggestions.filter((s) => !existingSkills.has(s.name)));
+    } catch {
+      /* silent */
+    }
 
     // ── 维度 2: Memory 偏好积累 ──
     try {
       const memoryInsights = this.#analyzeMemoryPatterns();
       analysisContext.memory = memoryInsights.summary;
-      suggestions.push(...memoryInsights.suggestions.filter(
-        s => !existingSkills.has(s.name),
-      ));
-    } catch { /* silent */ }
+      suggestions.push(...memoryInsights.suggestions.filter((s) => !existingSkills.has(s.name)));
+    } catch {
+      /* silent */
+    }
 
     // ── 维度 3: Recipe 分布与使用 ──
     try {
       const recipeInsights = this.#analyzeRecipePatterns();
       analysisContext.recipes = recipeInsights.summary;
-      suggestions.push(...recipeInsights.suggestions.filter(
-        s => !existingSkills.has(s.name),
-      ));
-    } catch { /* silent */ }
+      suggestions.push(...recipeInsights.suggestions.filter((s) => !existingSkills.has(s.name)));
+    } catch {
+      /* silent */
+    }
 
     // ── 维度 4: 候选积压 ──
     try {
       const candidateInsights = this.#analyzeCandidatePatterns();
       analysisContext.candidates = candidateInsights.summary;
-      suggestions.push(...candidateInsights.suggestions.filter(
-        s => !existingSkills.has(s.name),
-      ));
-    } catch { /* silent */ }
+      suggestions.push(...candidateInsights.suggestions.filter((s) => !existingSkills.has(s.name)));
+    } catch {
+      /* silent */
+    }
 
     // 按优先级排序：high > medium > low
     const priorityOrder = { high: 0, medium: 1, low: 2 };
@@ -97,9 +97,10 @@ export class SkillAdvisor {
       suggestions,
       existingProjectSkills: [...existingSkills],
       analysisContext,
-      hint: suggestions.length > 0
-        ? `发现 ${suggestions.length} 个 Skill 创建建议。你可以使用 autosnippet_skill({ operation: "create" }) 直接创建，也可以根据 rationale 自行判断是否需要。`
-        : '当前项目使用模式暂无明确的 Skill 创建建议。继续使用后会积累更多信号。',
+      hint:
+        suggestions.length > 0
+          ? `发现 ${suggestions.length} 个 Skill 创建建议。你可以使用 autosnippet_skill({ operation: "create" }) 直接创建，也可以根据 rationale 自行判断是否需要。`
+          : '当前项目使用模式暂无明确的 Skill 创建建议。继续使用后会积累更多信号。',
     };
   }
 
@@ -109,11 +110,14 @@ export class SkillAdvisor {
 
   #analyzeGuardPatterns() {
     const suggestions = [];
-    if (!this.#db) return { summary: 'DB 不可用', suggestions };
+    if (!this.#db) {
+      return { summary: 'DB 不可用', suggestions };
+    }
 
     try {
       // 查询 Guard 违规记录（audit_logs 中 action LIKE 'guard%' + result='violation'）
-      const rows = this.#db.prepare(`
+      const rows = this.#db
+        .prepare(`
         SELECT json_extract(operation_data, '$.ruleName') as ruleName,
                COUNT(*) as cnt
         FROM audit_logs
@@ -123,7 +127,8 @@ export class SkillAdvisor {
         HAVING cnt >= 3
         ORDER BY cnt DESC
         LIMIT 5
-      `).all();
+      `)
+        .all();
 
       if (rows.length > 0) {
         const topRule = rows[0];
@@ -160,17 +165,29 @@ export class SkillAdvisor {
 
     try {
       const raw = fs.readFileSync(memoryPath, 'utf-8').trim();
-      if (!raw) return { summary: '无 Memory 记录', suggestions };
+      if (!raw) {
+        return { summary: '无 Memory 记录', suggestions };
+      }
 
-      const entries = raw.split('\n')
-        .map(l => { try { return JSON.parse(l); } catch { return null; } })
+      const entries = raw
+        .split('\n')
+        .map((l) => {
+          try {
+            return JSON.parse(l);
+          } catch {
+            return null;
+          }
+        })
         .filter(Boolean);
 
-      const preferences = entries.filter(e => e.type === 'preference');
+      const preferences = entries.filter((e) => e.type === 'preference');
 
       if (preferences.length >= 5) {
         // 有足够多的偏好积累 → 建议归纳为 Skill
-        const sample = preferences.slice(-5).map(p => p.content).join('\n- ');
+        const sample = preferences
+          .slice(-5)
+          .map((p) => p.content)
+          .join('\n- ');
         suggestions.push({
           name: 'project-conventions',
           description: `项目约定总结 — 基于 ${preferences.length} 条团队偏好自动推荐`,
@@ -196,26 +213,32 @@ export class SkillAdvisor {
 
   #analyzeRecipePatterns() {
     const suggestions = [];
-    if (!this.#db) return { summary: 'DB 不可用', suggestions };
+    if (!this.#db) {
+      return { summary: 'DB 不可用', suggestions };
+    }
 
     try {
       // 按 category 分布
-      const categories = this.#db.prepare(`
+      const categories = this.#db
+        .prepare(`
         SELECT category, COUNT(*) as cnt
         FROM knowledge_entries
         WHERE lifecycle = 'active' AND category IS NOT NULL AND category != ''
         GROUP BY category
         ORDER BY cnt DESC
-      `).all();
+      `)
+        .all();
 
       // 按 language 分布
-      const languages = this.#db.prepare(`
+      const languages = this.#db
+        .prepare(`
         SELECT language, COUNT(*) as cnt
         FROM knowledge_entries
         WHERE lifecycle = 'active' AND language IS NOT NULL AND language != ''
         GROUP BY language
         ORDER BY cnt DESC
-      `).all();
+      `)
+        .all();
 
       // 高频使用但无自定义 Skill 的 category
       const topCategory = categories[0];
@@ -227,14 +250,19 @@ export class SkillAdvisor {
           rationale: `项目中 ${topCategory.category} 类 Recipe 高达 ${topCategory.cnt} 条，占比最大。创建一个 Skill 汇总此类别的核心设计模式、常见用法和注意事项，让 AI 在处理相关代码时有更精准的参考。`,
           source: 'recipe_distribution',
           priority: 'low',
-          signals: { category: topCategory.category, recipeCount: topCategory.cnt, allCategories: categories },
+          signals: {
+            category: topCategory.category,
+            recipeCount: topCategory.cnt,
+            allCategories: categories,
+          },
         });
       }
 
       // 高使用量 Recipe 统计（V3: stats JSON 中的 adoptions + applications）
       let hotRecipes = [];
       try {
-        hotRecipes = this.#db.prepare(`
+        hotRecipes = this.#db
+          .prepare(`
           SELECT title, category,
                  (COALESCE(json_extract(stats, '$.adoptions'), 0) + COALESCE(json_extract(stats, '$.applications'), 0)) as total_usage
           FROM knowledge_entries
@@ -242,8 +270,11 @@ export class SkillAdvisor {
             AND (COALESCE(json_extract(stats, '$.adoptions'), 0) + COALESCE(json_extract(stats, '$.applications'), 0)) >= 5
           ORDER BY total_usage DESC
           LIMIT 10
-        `).all();
-      } catch { /* 查询失败时降级为空 */ }
+        `)
+          .all();
+      } catch {
+        /* 查询失败时降级为空 */
+      }
 
       return {
         summary: { categories: categories.length, languages, hotRecipeCount: hotRecipes.length },
@@ -260,17 +291,21 @@ export class SkillAdvisor {
 
   #analyzeCandidatePatterns() {
     const suggestions = [];
-    if (!this.#db) return { summary: 'DB 不可用', suggestions };
+    if (!this.#db) {
+      return { summary: 'DB 不可用', suggestions };
+    }
 
     try {
       // V3: candidates 已合并到 knowledge_entries，ifecycle='pending' 即为候选
-      const stats = this.#db.prepare(`
+      const stats = this.#db
+        .prepare(`
         SELECT
           COUNT(*) as total,
           SUM(CASE WHEN lifecycle='pending' THEN 1 ELSE 0 END) as pending,
           SUM(CASE WHEN lifecycle='deprecated' THEN 1 ELSE 0 END) as rejected
         FROM knowledge_entries
-      `).get();
+      `)
+        .get();
 
       // 大量被拒绝 → 提示候选质量 Skill
       if (stats && stats.rejected >= 10) {
@@ -305,9 +340,11 @@ export class SkillAdvisor {
     const dir = getProjectSkillsPath(this.#projectRoot);
     try {
       fs.readdirSync(dir, { withFileTypes: true })
-        .filter(d => d.isDirectory())
-        .forEach(d => names.add(d.name));
-    } catch { /* no project skills */ }
+        .filter((d) => d.isDirectory())
+        .forEach((d) => names.add(d.name));
+    } catch {
+      /* no project skills */
+    }
     return names;
   }
 }

package/lib/service/skills/SkillHooks.js

@@ -16,8 +16,8 @@
 import fs from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
-import Logger from '../../infrastructure/logging/Logger.js';
 import { getProjectSkillsPath } from '../../infrastructure/config/Paths.js';
+import Logger from '../../infrastructure/logging/Logger.js';
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const SKILLS_DIR = path.resolve(__dirname, '../../../skills');
@@ -31,18 +31,13 @@ function _getProjectSkillsDir() {
   return getProjectSkillsPath(projectRoot);
 }
 
-const HOOK_NAMES = [
-  'onCandidateSubmit',
-  'onRecipeCreated',
-  'onGuardCheck',
-  'onBootstrapComplete',
-];
+const HOOK_NAMES = ['onCandidateSubmit', 'onRecipeCreated', 'onGuardCheck', 'onBootstrapComplete'];
 
 export class SkillHooks {
   constructor() {
     this.logger = Logger.getInstance();
     /** @type {Map<string, Function[]>} hookName → [handler, ...] */
-    this.hooks = new Map(HOOK_NAMES.map(n => [n, []]));
+    this.hooks = new Map(HOOK_NAMES.map((n) => [n, []]));
   }
 
   /**
@@ -83,14 +78,18 @@ export class SkillHooks {
    */
   async run(hookName, ...args) {
     const handlers = this.hooks.get(hookName);
-    if (!handlers || handlers.length === 0) return undefined;
+    if (!handlers || handlers.length === 0) {
+      return undefined;
+    }
 
     let result;
     for (const handler of handlers) {
       try {
         result = await handler(...args);
         // 如果是 blocking hook 且返回 block=true，立即中断
-        if (result?.block) return result;
+        if (result?.block) {
+          return result;
+        }
       } catch (err) {
         this.logger.warn(`SkillHook error in ${hookName}`, { error: err.message });
       }
@@ -111,16 +110,19 @@ export class SkillHooks {
   async #loadFromDir(dir, loaded) {
     let dirs;
     try {
-      dirs = fs.readdirSync(dir, { withFileTypes: true })
-        .filter(d => d.isDirectory())
-        .map(d => d.name);
+      dirs = fs
+        .readdirSync(dir, { withFileTypes: true })
+        .filter((d) => d.isDirectory())
+        .map((d) => d.name);
     } catch {
       return; // 目录不存在
     }
 
     for (const name of dirs) {
       const hooksPath = path.join(dir, name, 'hooks.js');
-      if (!fs.existsSync(hooksPath)) continue;
+      if (!fs.existsSync(hooksPath)) {
+        continue;
+      }
       try {
         const mod = await import(hooksPath);
         loaded.set(name, mod.default || mod);

package/lib/service/snippet/PlaceholderConverter.js

@@ -0,0 +1,5 @@
+/**
+ * @deprecated Moved to lib/platform/ios/snippet/PlaceholderConverter.js
+ * This re-export shim maintains backward compatibility.
+ */
+export { PlaceholderConverter } from '../../platform/ios/snippet/PlaceholderConverter.js';

package/lib/service/snippet/SnippetFactory.js

@@ -1,56 +1,58 @@
 /**
- * SnippetFactory — Xcode .codesnippet 生成工厂
- * 纯内存 Recipe → XML 转换器，不依赖 DB
+ * SnippetFactory — IDE 无关的 Snippet 生成工厂
  *
- * Snippet 是 Recipe 的附属产物：从 Recipe 取出 → 生成 XML → 同步 Xcode → 不再使用
+ * 职责:
+ *   1. Recipe → SnippetSpec (IDE 无关的中间表示)
+ *   2. 查询/列表操作 (listSnippets, getSnippet)
+ *   3. 委托 Codec 生成最终 IDE 格式 (generate, generateBatch)
+ *
+ * Codec 注册:
+ *   factory.registerCodec(codec)  — 注册 XcodeCodec / VSCodeCodec
+ *   factory.generate(spec, 'xcode')  — 按 target 生成
  */
 
-const TEMPLATE_TOKENS = ['{identifier}', '{title}', '{completion}', '{summary}', '{content}', '{language}'];
-
-const LANGUAGE_MAP = {
-  swift:           'Xcode.SourceCodeLanguage.Swift',
-  'objective-c':   'Xcode.SourceCodeLanguage.Objective-C',
-  objc:            'Xcode.SourceCodeLanguage.Objective-C',
-  c:               'Xcode.SourceCodeLanguage.C',
-  'c++':           'Xcode.SourceCodeLanguage.C-Plus-Plus',
-  javascript:      'Xcode.SourceCodeLanguage.JavaScript',
-};
-
-const SNIPPET_TEMPLATE = `<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
-\t<key>IDECodeSnippetCompletionPrefix</key>
-\t<string>{completion}</string>
-\t<key>IDECodeSnippetCompletionScopes</key>
-\t<array>
-\t\t<string>All</string>
-\t</array>
-\t<key>IDECodeSnippetContents</key>
-\t<string>{content}</string>
-\t<key>IDECodeSnippetIdentifier</key>
-\t<string>{identifier}</string>
-\t<key>IDECodeSnippetLanguage</key>
-\t<string>{language}</string>
-\t<key>IDECodeSnippetSummary</key>
-\t<string>{summary}</string>
-\t<key>IDECodeSnippetTitle</key>
-\t<string>{title}</string>
-\t<key>IDECodeSnippetUserSnippet</key>
-\t<true/>
-\t<key>IDECodeSnippetVersion</key>
-\t<integer>2</integer>
-</dict>
-</plist>`;
+import { XcodeCodec } from './codecs/XcodeCodec.js';
 
 export class SnippetFactory {
+  /** @type {Map<string, import('./codecs/SnippetCodec.js').SnippetCodec>} */
+  #codecs = new Map();
+
   /**
-   * @param {object} [knowledgeRepository] — KnowledgeRepositoryImpl（可选，用于列表查询）
+   * @param {object} [knowledgeRepository] — KnowledgeRepositoryImpl（可选）
    */
   constructor(knowledgeRepository) {
     this._recipeRepo = knowledgeRepository || null;
   }
 
+  // ─────────────── Codec 注册 ───────────────
+
+  /**
+   * 注册一个 IDE codec
+   * @param {import('./codecs/SnippetCodec.js').SnippetCodec} codec
+   */
+  registerCodec(codec) {
+    this.#codecs.set(codec.id, codec);
+  }
+
+  /**
+   * 获取已注册的 codec
+   * @param {string} target — 'xcode' | 'vscode'
+   * @returns {import('./codecs/SnippetCodec.js').SnippetCodec|undefined}
+   */
+  getCodec(target) {
+    return this.#codecs.get(target);
+  }
+
+  /**
+   * 获取所有已注册 codec 的 ID 列表
+   * @returns {string[]}
+   */
+  getRegisteredTargets() {
+    return [...this.#codecs.keys()];
+  }
+
+  // ─────────────── 依赖注入 ───────────────
+
   /**
    * 运行时注入 knowledgeRepository（用于延迟绑定场景）
    */
@@ -61,17 +63,23 @@ export class SnippetFactory {
   // ─────────────── Recipe → Snippet 查询 ───────────────
 
   /**
-   * 从 Recipe 列表实时生成 Snippet 列表（取代原 DB CRUD）
+   * 从 Recipe 列表实时生成 Snippet 列表
    * @param {object} [filters] — { language, category, keyword }
    * @param {object} [pagination]
    * @returns {Promise<Array>}
    */
   async listSnippets(filters = {}, pagination = { page: 1, pageSize: 50 }) {
-    if (!this._recipeRepo) return [];
+    if (!this._recipeRepo) {
+      return [];
+    }
 
     const dbFilters = { status: 'active' };
-    if (filters.language) dbFilters.language = filters.language;
-    if (filters.category) dbFilters.category = filters.category;
+    if (filters.language) {
+      dbFilters.language = filters.language;
+    }
+    if (filters.category) {
+      dbFilters.category = filters.category;
+    }
 
     let result;
     if (filters.keyword) {
@@ -81,55 +89,70 @@ export class SnippetFactory {
     }
 
     const recipes = result?.data || result?.items || [];
-    return recipes.map(r => this.fromRecipe(r));
+    return recipes.map((r) => this.fromRecipe(r));
   }
 
   /**
    * 从单个 Recipe ID 实时生成 Snippet
    */
   async getSnippet(recipeId) {
-    if (!this._recipeRepo) return null;
+    if (!this._recipeRepo) {
+      return null;
+    }
     const recipe = await this._recipeRepo.findById(recipeId);
-    if (!recipe) return null;
+    if (!recipe) {
+      return null;
+    }
     return this.fromRecipe(recipe);
   }
 
-  // ─────────────── XML 生成 ───────────────
+  // ─────────────── Codec 委托生成 ───────────────
 
   /**
-   * 从 spec 数据生成 .codesnippet XML 内容
-   * @param {object} spec
-   *   @param {string} spec.identifier — 唯一标识 (如 "com.autosnippet.xxx")
-   *   @param {string} spec.title — 片段标题
-   *   @param {string} spec.completion — 触发补全前缀
-   *   @param {string} spec.summary — 描述
-   *   @param {string|string[]} spec.code — 代码内容（字符串或行数组）
-   *   @param {string} spec.language — 语言标识符
-   * @returns {string} — XML plist 内容
+   * 使用指定 codec 从 spec 生成 IDE 格式内容
+   * @param {object} spec — SnippetSpec
+   * @param {string} [target='xcode'] — codec ID
+   * @returns {string}
    */
-  generate(spec) {
-    if (!spec?.identifier || !spec?.code) {
-      throw new Error('Snippet spec must have identifier and code');
-    }
+  generate(spec, target = 'xcode') {
+    const codec = this.#resolveCodec(target);
+    return codec.generate(spec);
+  }
 
-    const content = Array.isArray(spec.code) ? spec.code.join('\n') : spec.code;
-    const languageKey = LANGUAGE_MAP[(spec.language || 'swift').toLowerCase()] || LANGUAGE_MAP.swift;
+  /**
+   * 批量生成 (委托 codec)
+   * @param {Array} recipes
+   * @param {string} [target='xcode']
+   * @returns {Array<{ filename: string, content: string, spec: object }> | { filename: string, content: string, specs: object[] }}
+   */
+  generateBatch(recipes, target = 'xcode') {
+    const codec = this.#resolveCodec(target);
+    const specs = recipes.map((r) => this.fromRecipe(r));
 
-    let xml = SNIPPET_TEMPLATE;
-    xml = xml.replace('{identifier}', this.#escapeXml(spec.identifier));
-    xml = xml.replace('{title}', this.#escapeXml(spec.title || spec.identifier));
-    xml = xml.replace('{completion}', this.#escapeXml(spec.completion || spec.identifier));
-    xml = xml.replace('{summary}', this.#escapeXml(spec.summary || ''));
-    xml = xml.replace('{content}', this.#escapeXml(content));
-    xml = xml.replace('{language}', languageKey);
+    const bundleFilename = codec.getBundleFilename();
+    if (bundleFilename) {
+      // VSCode 模式: 单 bundle 文件
+      return {
+        filename: bundleFilename,
+        content: codec.generateBundle(specs),
+        specs,
+      };
+    }
 
-    return xml;
+    // Xcode 模式: 每个 snippet 一个文件
+    return specs.map((spec) => ({
+      filename: `${spec.identifier}${codec.fileExtension}`,
+      content: codec.generate(spec),
+      spec,
+    }));
   }
 
+  // ─────────────── Recipe → SnippetSpec ───────────────
+
   /**
-   * 从 Recipe/Candidate 生成 snippet spec
+   * 从 Recipe/Candidate 生成 IDE 无关的 snippet spec
    * @param {object} recipe — { id, title, trigger, code, description, language }
-   * @returns {object} — snippet spec
+   * @returns {object} — SnippetSpec
    */
   fromRecipe(recipe) {
     return {
@@ -138,38 +161,32 @@ export class SnippetFactory {
       completion: recipe.trigger || this.#slugify(recipe.title),
       summary: recipe.description || recipe.summary || '',
       code: recipe.code,
-      language: recipe.language || 'swift',
+      language: recipe.language || 'unknown',
     };
   }
 
+  // ─────────────── Private ───────────────
+
   /**
-   * 批量生成
-   * @param {Array} recipes
-   * @returns {Array<{ filename: string, content: string, spec: object }>}
+   * @param {string} target
+   * @returns {import('./codecs/SnippetCodec.js').SnippetCodec}
    */
-  generateBatch(recipes) {
-    return recipes.map(recipe => {
-      const spec = this.fromRecipe(recipe);
-      return {
-        filename: `${spec.identifier}.codesnippet`,
-        content: this.generate(spec),
-        spec,
-      };
-    });
-  }
-
-  #escapeXml(str) {
-    if (!str) return '';
-    return String(str)
-      .replace(/&/g, '&amp;')
-      .replace(/</g, '&lt;')
-      .replace(/>/g, '&gt;')
-      .replace(/"/g, '&quot;')
-      .replace(/'/g, '&apos;');
+  #resolveCodec(target) {
+    const codec = this.#codecs.get(target);
+    if (!codec) {
+      throw new Error(`No codec registered for target "${target}". Available: [${this.getRegisteredTargets().join(', ')}]`);
+    }
+    return codec;
   }
 
   #slugify(str) {
-    if (!str) return 'unnamed';
-    return str.toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/(^-|-$)/g, '').slice(0, 50);
+    if (!str) {
+      return 'unnamed';
+    }
+    return str
+      .toLowerCase()
+      .replace(/[^a-z0-9]+/g, '-')
+      .replace(/(^-|-$)/g, '')
+      .slice(0, 50);
   }
 }