autosnippet 3.0.1 → 3.0.2

package/lib/service/knowledge/KnowledgeService.js

@@ -1,7 +1,7 @@
 import { KnowledgeEntry } from '../../domain/knowledge/KnowledgeEntry.js';
-import { Lifecycle, inferKind } from '../../domain/knowledge/Lifecycle.js';
+import { inferKind, Lifecycle } from '../../domain/knowledge/Lifecycle.js';
 import Logger from '../../infrastructure/logging/Logger.js';
-import { ValidationError, ConflictError, NotFoundError } from '../../shared/errors/index.js';
+import { ConflictError, NotFoundError, ValidationError } from '../../shared/errors/index.js';
 
 /**
  * KnowledgeService — 统一知识服务
@@ -26,15 +26,15 @@ export class KnowledgeService {
    * @param {import('../quality/QualityScorer.js').QualityScorer} [options.qualityScorer]
    */
   constructor(repository, auditLogger, gateway, knowledgeGraphService, options = {}) {
-    this.repository           = repository;
-    this.auditLogger          = auditLogger;
-    this.gateway              = gateway;
+    this.repository = repository;
+    this.auditLogger = auditLogger;
+    this.gateway = gateway;
     this._knowledgeGraphService = knowledgeGraphService || null;
-    this._fileWriter          = options.fileWriter || null;
-    this._skillHooks          = options.skillHooks || null;
-    this._confidenceRouter    = options.confidenceRouter || null;
-    this._qualityScorer       = options.qualityScorer || null;
-    this.logger               = Logger.getInstance();
+    this._fileWriter = options.fileWriter || null;
+    this._skillHooks = options.skillHooks || null;
+    this._confidenceRouter = options.confidenceRouter || null;
+    this._qualityScorer = options.qualityScorer || null;
+    this.logger = Logger.getInstance();
   }
 
   /* ═══ CRUD ══════════════════════════════════════════════ */
@@ -56,9 +56,9 @@ export class KnowledgeService {
 
       const entry = KnowledgeEntry.fromJSON({
         ...data,
-        lifecycle:  Lifecycle.PENDING,
-        source:     data.source || 'manual',
-        createdBy:  context.userId,
+        lifecycle: Lifecycle.PENDING,
+        source: data.source || 'manual',
+        createdBy: context.userId,
       });
 
       if (!entry.isValid()) {
@@ -90,7 +90,7 @@ export class KnowledgeService {
       this._syncRelationsToGraph(saved.id, saved.relations);
 
       // 自动发现同域条目建立 related 边（best effort, 不阻塞）
-      this._autoDiscoverRelations(saved.id, saved).catch(err =>
+      this._autoDiscoverRelations(saved.id, saved).catch((err) =>
         this.logger.warn('_autoDiscoverRelations error', { id: saved.id, error: err.message })
       );
 
@@ -113,9 +113,13 @@ export class KnowledgeService {
 
       // ── SkillHooks: onKnowledgeCreated (fire-and-forget) ──
       if (this._skillHooks) {
-        this._skillHooks.run('onKnowledgeCreated', saved, {
-          userId: context.userId,
-        }).catch(err => this.logger.warn('SkillHook onKnowledgeCreated error', { error: err.message }));
+        this._skillHooks
+          .run('onKnowledgeCreated', saved, {
+            userId: context.userId,
+          })
+          .catch((err) =>
+            this.logger.warn('SkillHook onKnowledgeCreated error', { error: err.message })
+          );
       }
 
       return saved;
@@ -150,22 +154,43 @@ export class KnowledgeService {
    */
   async update(id, data, context) {
     try {
-      const entry = await this._findOrThrow(id);
+      const _entry = await this._findOrThrow(id);
 
       const UPDATABLE = [
-        'title', 'description', 'trigger', 'language', 'category',
-        'knowledgeType', 'complexity', 'scope', 'difficulty',
-        'content', 'relations', 'constraints', 'reasoning',
-        'tags', 'headers', 'headerPaths', 'moduleName', 'includeHeaders',
-        'agentNotes', 'aiInsight',
+        'title',
+        'description',
+        'trigger',
+        'language',
+        'category',
+        'knowledgeType',
+        'complexity',
+        'scope',
+        'difficulty',
+        'content',
+        'relations',
+        'constraints',
+        'reasoning',
+        'tags',
+        'headers',
+        'headerPaths',
+        'moduleName',
+        'includeHeaders',
+        'agentNotes',
+        'aiInsight',
         // Cursor 交付字段
-        'topicHint', 'whenClause', 'doClause', 'dontClause', 'coreCode',
+        'topicHint',
+        'whenClause',
+        'doClause',
+        'dontClause',
+        'coreCode',
       ];
 
       const dbUpdates = {};
 
       for (const key of UPDATABLE) {
-        if (data[key] === undefined) continue;
+        if (data[key] === undefined) {
+          continue;
+        }
 
         switch (key) {
           // 标量字段直传
@@ -232,13 +257,16 @@ export class KnowledgeService {
       });
 
       this.logger.info('Knowledge entry updated', {
-        id, updatedBy: context.userId, fields: Object.keys(dbUpdates),
+        id,
+        updatedBy: context.userId,
+        fields: Object.keys(dbUpdates),
       });
 
       return updated;
     } catch (error) {
       this.logger.error('Error updating knowledge entry', {
-        id, error: error.message,
+        id,
+        error: error.message,
       });
       throw error;
     }
@@ -267,13 +295,16 @@ export class KnowledgeService {
       });
 
       this.logger.info('Knowledge entry deleted', {
-        id, deletedBy: context.userId, title: entry.title,
+        id,
+        deletedBy: context.userId,
+        title: entry.title,
       });
 
       return { success: true, id };
     } catch (error) {
       this.logger.error('Error deleting knowledge entry', {
-        id, error: error.message,
+        id,
+        error: error.message,
       });
       throw error;
     }
@@ -305,7 +336,9 @@ export class KnowledgeService {
         const container = getServiceContainer();
         if (container.services.cursorDeliveryPipeline) {
           const pipeline = container.get('cursorDeliveryPipeline');
-          pipeline.deliver().catch(() => { /* ignore */ });
+          pipeline.deliver().catch(() => {
+            /* ignore */
+          });
         }
       })
       .catch(() => {
@@ -335,22 +368,34 @@ export class KnowledgeService {
   // ── 向后兼容别名 ──
 
   /** @deprecated 简化后所有条目直接进 pending */
-  async submit(id, context) { return this.get(id); }
+  async submit(id, context) {
+    return this.get(id);
+  }
 
   /** @deprecated 简化后 approve = publish */
-  async approve(id, context) { return this.publish(id, context); }
+  async approve(id, context) {
+    return this.publish(id, context);
+  }
 
   /** @deprecated 简化后无需 autoApprove */
-  async autoApprove(id, context) { return this.get(id); }
+  async autoApprove(id, context) {
+    return this.get(id);
+  }
 
   /** @deprecated 简化后 reject = deprecate */
-  async reject(id, reason, context) { return this.deprecate(id, reason, context); }
+  async reject(id, reason, context) {
+    return this.deprecate(id, reason, context);
+  }
 
   /** @deprecated 简化后 toDraft = reactivate */
-  async toDraft(id, context) { return this.reactivate(id, context); }
+  async toDraft(id, context) {
+    return this.reactivate(id, context);
+  }
 
   /** @deprecated 简化后 fastTrack = publish */
-  async fastTrack(id, context) { return this.publish(id, context); }
+  async fastTrack(id, context) {
+    return this.publish(id, context);
+  }
 
   /* ═══ 查询 ══════════════════════════════════════════════ */
 
@@ -365,19 +410,36 @@ export class KnowledgeService {
       const { page = 1, pageSize = 20 } = pagination;
 
       const dbFilters = {};
-      if (lifecycle)     dbFilters.lifecycle = lifecycle;
-      if (kind)          dbFilters.kind = kind;
-      if (language)      dbFilters.language = language;
-      if (category)      dbFilters.category = category;
-      if (knowledgeType) dbFilters.knowledgeType = knowledgeType;
-      if (source)        dbFilters.source = source;
-      if (scope)         dbFilters.scope = scope;
-      if (tag)           dbFilters._tagLike = tag;
+      if (lifecycle) {
+        dbFilters.lifecycle = lifecycle;
+      }
+      if (kind) {
+        dbFilters.kind = kind;
+      }
+      if (language) {
+        dbFilters.language = language;
+      }
+      if (category) {
+        dbFilters.category = category;
+      }
+      if (knowledgeType) {
+        dbFilters.knowledgeType = knowledgeType;
+      }
+      if (source) {
+        dbFilters.source = source;
+      }
+      if (scope) {
+        dbFilters.scope = scope;
+      }
+      if (tag) {
+        dbFilters._tagLike = tag;
+      }
 
       return this.repository.findWithPagination(dbFilters, { page, pageSize });
     } catch (error) {
       this.logger.error('Error listing knowledge entries', {
-        error: error.message, filters,
+        error: error.message,
+        filters,
       });
       throw error;
     }
@@ -405,7 +467,8 @@ export class KnowledgeService {
       return this.repository.search(keyword, { page, pageSize });
     } catch (error) {
       this.logger.error('Error searching knowledge', {
-        keyword, error: error.message,
+        keyword,
+        error: error.message,
       });
       throw error;
     }
@@ -453,7 +516,8 @@ export class KnowledgeService {
       return entry;
     } catch (error) {
       this.logger.error(`Error incrementing knowledge ${type}`, {
-        id, error: error.message,
+        id,
+        error: error.message,
       });
       throw error;
     }
@@ -479,11 +543,11 @@ export class KnowledgeService {
       // 更新 Quality 值对象
       await this.repository.update(id, {
         quality: JSON.stringify({
-          completeness:  result.dimensions.completeness,
-          adaptation:    result.dimensions.metadata,
+          completeness: result.dimensions.completeness,
+          adaptation: result.dimensions.metadata,
           documentation: result.dimensions.format,
-          overall:       result.score,
-          grade:         result.grade,
+          overall: result.score,
+          grade: result.grade,
         }),
         updatedAt: Math.floor(Date.now() / 1000),
       });
@@ -496,13 +560,16 @@ export class KnowledgeService {
       }
 
       this.logger.info('Knowledge quality updated', {
-        id, score: result.score, grade: result.grade,
+        id,
+        score: result.score,
+        grade: result.grade,
       });
 
       return result;
     } catch (error) {
       this.logger.error('Error updating knowledge quality', {
-        id, error: error.message,
+        id,
+        error: error.message,
       });
       throw error;
     }
@@ -522,30 +589,39 @@ export class KnowledgeService {
       const result = entry[method](...entityArgs);
 
       if (!result.success) {
-        throw new ConflictError(
-          result.error,
-          `Lifecycle ${method} failed for ${id}`,
-        );
+        throw new ConflictError(result.error, `Lifecycle ${method} failed for ${id}`);
       }
 
       // 构建 DB 更新
-      // 注意: 不在此处 JSON.stringify — repository.update() 内部 
+      // 注意: 不在此处 JSON.stringify — repository.update() 内部
       // 通过 _entityToRow() 统一执行序列化, 传入原始值即可
       const dbUpdates = {
-        lifecycle:         entry.lifecycle,
-        lifecycleHistory:  entry.lifecycleHistory,
-        updatedAt:         entry.updatedAt,
+        lifecycle: entry.lifecycle,
+        lifecycleHistory: entry.lifecycleHistory,
+        updatedAt: entry.updatedAt,
       };
 
       // 审核字段
-      if (entry.reviewedBy) dbUpdates.reviewedBy = entry.reviewedBy;
-      if (entry.reviewedAt) dbUpdates.reviewedAt = entry.reviewedAt;
-      if (entry.rejectionReason !== null) dbUpdates.rejectionReason = entry.rejectionReason;
+      if (entry.reviewedBy) {
+        dbUpdates.reviewedBy = entry.reviewedBy;
+      }
+      if (entry.reviewedAt) {
+        dbUpdates.reviewedAt = entry.reviewedAt;
+      }
+      if (entry.rejectionReason !== null) {
+        dbUpdates.rejectionReason = entry.rejectionReason;
+      }
 
       // 发布字段
-      if (entry.publishedAt) dbUpdates.publishedAt = entry.publishedAt;
-      if (entry.publishedBy) dbUpdates.publishedBy = entry.publishedBy;
-      if (entry.autoApprovable !== undefined) dbUpdates.autoApprovable = entry.autoApprovable ? 1 : 0;
+      if (entry.publishedAt) {
+        dbUpdates.publishedAt = entry.publishedAt;
+      }
+      if (entry.publishedBy) {
+        dbUpdates.publishedBy = entry.publishedBy;
+      }
+      if (entry.autoApprovable !== undefined) {
+        dbUpdates.autoApprovable = entry.autoApprovable ? 1 : 0;
+      }
 
       const updated = await this.repository.update(id, dbUpdates);
 
@@ -555,7 +631,8 @@ export class KnowledgeService {
           this._fileWriter.moveOnLifecycleChange(updated);
         } catch (err) {
           this.logger.warn('moveOnLifecycleChange failed (non-blocking)', {
-            id, error: err.message,
+            id,
+            error: err.message,
           });
         }
       }
@@ -566,14 +643,17 @@ export class KnowledgeService {
       });
 
       this.logger.info(`Knowledge entry ${method}`, {
-        id, from: prevLifecycle, to: entry.lifecycle,
+        id,
+        from: prevLifecycle,
+        to: entry.lifecycle,
         actor: context.userId,
       });
 
       return updated;
     } catch (error) {
       this.logger.error(`Error in lifecycle ${method}`, {
-        id, error: error.message,
+        id,
+        error: error.message,
       });
       throw error;
     }
@@ -611,15 +691,15 @@ export class KnowledgeService {
    */
   _adaptForScorer(entry) {
     return {
-      title:      entry.title,
-      trigger:    entry.trigger,
-      code:       entry.content?.pattern || entry.content?.markdown || '',
-      language:   entry.language,
-      category:   entry.category,
-      summary:    entry.description || '',
+      title: entry.title,
+      trigger: entry.trigger,
+      code: entry.content?.pattern || entry.content?.markdown || '',
+      language: entry.language,
+      category: entry.category,
+      summary: entry.description || '',
       usageGuide: entry.content?.markdown || entry.doClause || '',
-      headers:    entry.headers || [],
-      tags:       entry.tags || [],
+      headers: entry.headers || [],
+      tags: entry.tags || [],
     };
   }
 
@@ -632,30 +712,37 @@ export class KnowledgeService {
    */
   async _autoDiscoverRelations(id, entry) {
     const gs = this._knowledgeGraphService;
-    if (!gs) return;
+    if (!gs) {
+      return;
+    }
 
     try {
       const candidates = [];
 
-      // 按 moduleName 查同模块条目
+      // 仅与已发布 Recipe（active）建立关联，不与其他候选（pending）互关联
+      const activeOnly = { lifecycle: Lifecycle.ACTIVE };
+
+      // 按 moduleName 查同模块已发布条目
       if (entry.moduleName) {
         const sameModule = await this.repository.findWithPagination(
-          { moduleName: entry.moduleName },
-          { page: 1, pageSize: 20 },
+          { ...activeOnly, moduleName: entry.moduleName },
+          { page: 1, pageSize: 20 }
         );
         for (const r of sameModule.data) {
-          if (r.id !== id) candidates.push({ target: r.id, relation: 'related', weight: 0.8 });
+          if (r.id !== id) {
+            candidates.push({ target: r.id, relation: 'related', weight: 0.8 });
+          }
         }
       }
 
-      // 按 category 查同类条目（弱关联）
+      // 按 category 查同类已发布条目（弱关联）
       if (entry.category && candidates.length < 10) {
         const sameCat = await this.repository.findWithPagination(
-          { category: entry.category },
-          { page: 1, pageSize: 10 },
+          { ...activeOnly, category: entry.category },
+          { page: 1, pageSize: 10 }
         );
         for (const r of sameCat.data) {
-          if (r.id !== id && !candidates.some(c => c.target === r.id)) {
+          if (r.id !== id && !candidates.some((c) => c.target === r.id)) {
             candidates.push({ target: r.id, relation: 'related', weight: 0.4 });
           }
         }
@@ -665,19 +752,25 @@ export class KnowledgeService {
       for (const c of candidates.slice(0, 10)) {
         try {
           gs.addEdge(id, 'knowledge', c.target, 'knowledge', c.relation, { weight: c.weight });
-        } catch { /* ignore duplicates */ }
+        } catch {
+          /* ignore duplicates */
+        }
       }
 
       // 将发现的关系写回 entry 的 relations 字段
       if (candidates.length > 0) {
-        const relatedItems = candidates.slice(0, 10).map(c => ({
+        const relatedItems = candidates.slice(0, 10).map((c) => ({
           target: c.target,
           description: 'auto-discovered',
         }));
-        const existingRelations = typeof entry.relations?.toJSON === 'function'
-          ? entry.relations.toJSON()
-          : (entry.relations || {});
-        const merged = { ...existingRelations, related: [...(existingRelations.related || []), ...relatedItems] };
+        const existingRelations =
+          typeof entry.relations?.toJSON === 'function'
+            ? entry.relations.toJSON()
+            : entry.relations || {};
+        const merged = {
+          ...existingRelations,
+          related: [...(existingRelations.related || []), ...relatedItems],
+        };
         await this.repository.update(id, {
           relations: JSON.stringify(merged),
           updatedAt: Math.floor(Date.now() / 1000),
@@ -685,7 +778,8 @@ export class KnowledgeService {
       }
     } catch (err) {
       this.logger.warn('Auto-discover relations failed (non-blocking)', {
-        id, error: err.message,
+        id,
+        error: err.message,
       });
     }
   }
@@ -695,20 +789,26 @@ export class KnowledgeService {
    */
   _syncRelationsToGraph(id, relations) {
     const gs = this._knowledgeGraphService;
-    if (!gs) return;
+    if (!gs) {
+      return;
+    }
 
     try {
-      gs.db.prepare(
-        `DELETE FROM knowledge_edges WHERE from_id = ? AND from_type = 'knowledge'`
-      ).run(id);
+      gs.db
+        .prepare(`DELETE FROM knowledge_edges WHERE from_id = ? AND from_type = 'knowledge'`)
+        .run(id);
 
-      if (!relations || typeof relations !== 'object') return;
+      if (!relations || typeof relations !== 'object') {
+        return;
+      }
 
       // Relations 可能是 Relations 值对象或普通对象
       const relObj = typeof relations.toJSON === 'function' ? relations.toJSON() : relations;
 
       for (const [relType, targets] of Object.entries(relObj)) {
-        if (!Array.isArray(targets)) continue;
+        if (!Array.isArray(targets)) {
+          continue;
+        }
         for (const t of targets) {
           const targetId = t.target || t.id || (typeof t === 'string' ? t : null);
           if (targetId) {
@@ -720,7 +820,8 @@ export class KnowledgeService {
       }
     } catch (err) {
       this.logger.warn('Failed to sync relations to knowledge_edges', {
-        id, error: err.message,
+        id,
+        error: err.message,
       });
     }
   }
@@ -730,12 +831,12 @@ export class KnowledgeService {
    */
   _removeAllEdges(id) {
     const gs = this._knowledgeGraphService;
-    if (!gs) return;
+    if (!gs) {
+      return;
+    }
 
     try {
-      gs.db.prepare(
-        `DELETE FROM knowledge_edges WHERE from_id = ? OR to_id = ?`
-      ).run(id, id);
+      gs.db.prepare(`DELETE FROM knowledge_edges WHERE from_id = ? OR to_id = ?`).run(id, id);
     } catch (err) {
       this.logger.warn('Failed to remove edges', { id, error: err.message });
     }
@@ -747,20 +848,24 @@ export class KnowledgeService {
    * 落盘到 .md 文件 + 回写 sourceFile
    */
   _persistToFile(entry) {
-    if (!this._fileWriter) return;
+    if (!this._fileWriter) {
+      return;
+    }
     try {
       const oldSourceFile = entry.sourceFile;
       this._fileWriter.persist(entry);
       if (entry.sourceFile && entry.sourceFile !== oldSourceFile) {
-        this.repository.update(entry.id, { sourceFile: entry.sourceFile }).catch(err => {
+        this.repository.update(entry.id, { sourceFile: entry.sourceFile }).catch((err) => {
           this.logger.warn('Failed to update sourceFile in DB', {
-            id: entry.id, error: err.message,
+            id: entry.id,
+            error: err.message,
           });
         });
       }
     } catch (err) {
       this.logger.warn('Knowledge file persist failed (non-blocking)', {
-        id: entry?.id, error: err.message,
+        id: entry?.id,
+        error: err.message,
       });
     }
   }
@@ -769,12 +874,15 @@ export class KnowledgeService {
    * 删除 .md 文件
    */
   _removeFile(entry) {
-    if (!this._fileWriter) return;
+    if (!this._fileWriter) {
+      return;
+    }
     try {
       this._fileWriter.remove(entry);
     } catch (err) {
       this.logger.warn('Knowledge file remove failed (non-blocking)', {
-        id: entry?.id, error: err.message,
+        id: entry?.id,
+        error: err.message,
       });
     }
   }
@@ -795,7 +903,9 @@ export class KnowledgeService {
       });
     } catch (err) {
       this.logger.warn('Audit log failed (non-blocking)', {
-        action, id, error: err.message,
+        action,
+        id,
+        error: err.message,
       });
     }
   }