anyone-can-architect 0.2.0 → 0.3.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (124) hide show
  1. package/README.md +6 -4
  2. package/README.zh-CN.md +4 -2
  3. package/VERSION +1 -1
  4. package/axioms/README.md +1 -1
  5. package/axioms/writing.md +1 -1
  6. package/dist/antigravity/aca/SKILL.md +3 -2
  7. package/dist/antigravity/aca-design/SKILL.md +1 -1
  8. package/dist/antigravity/aca-implement/SKILL.md +90 -109
  9. package/dist/antigravity/aca-release/SKILL.md +4 -3
  10. package/dist/antigravity/aca-repo-audit/SKILL.md +11 -9
  11. package/dist/antigravity/aca-review/SKILL.md +114 -115
  12. package/dist/antigravity/aca-test/SKILL.md +110 -0
  13. package/dist/antigravity/aca-walkthrough/SKILL.md +1 -1
  14. package/dist/antigravity-cli/aca/SKILL.md +3 -2
  15. package/dist/antigravity-cli/aca-design/SKILL.md +1 -1
  16. package/dist/antigravity-cli/aca-implement/SKILL.md +90 -109
  17. package/dist/antigravity-cli/aca-release/SKILL.md +4 -3
  18. package/dist/antigravity-cli/aca-repo-audit/SKILL.md +11 -9
  19. package/dist/antigravity-cli/aca-review/SKILL.md +114 -115
  20. package/dist/antigravity-cli/aca-test/SKILL.md +110 -0
  21. package/dist/antigravity-cli/aca-walkthrough/SKILL.md +1 -1
  22. package/dist/codex/aca/SKILL.md +3 -2
  23. package/dist/codex/aca-design/SKILL.md +1 -1
  24. package/dist/codex/aca-implement/SKILL.md +90 -109
  25. package/dist/codex/aca-release/SKILL.md +4 -3
  26. package/dist/codex/aca-repo-audit/SKILL.md +11 -9
  27. package/dist/codex/aca-review/SKILL.md +114 -115
  28. package/dist/codex/aca-test/SKILL.md +110 -0
  29. package/dist/codex/aca-walkthrough/SKILL.md +1 -1
  30. package/dist/cursor/aca/SKILL.md +3 -2
  31. package/dist/cursor/aca-design/SKILL.md +1 -1
  32. package/dist/cursor/aca-implement/SKILL.md +90 -109
  33. package/dist/cursor/aca-release/SKILL.md +4 -3
  34. package/dist/cursor/aca-repo-audit/SKILL.md +11 -9
  35. package/dist/cursor/aca-review/SKILL.md +114 -115
  36. package/dist/cursor/aca-test/SKILL.md +111 -0
  37. package/dist/cursor/aca-walkthrough/SKILL.md +1 -1
  38. package/dist/grok/aca/SKILL.md +3 -2
  39. package/dist/grok/aca-design/SKILL.md +1 -1
  40. package/dist/grok/aca-implement/SKILL.md +90 -109
  41. package/dist/grok/aca-release/SKILL.md +4 -3
  42. package/dist/grok/aca-repo-audit/SKILL.md +11 -9
  43. package/dist/grok/aca-review/SKILL.md +114 -115
  44. package/dist/grok/aca-test/SKILL.md +110 -0
  45. package/dist/grok/aca-walkthrough/SKILL.md +1 -1
  46. package/doc-design/document-sets/module.md +6 -2
  47. package/doc-design/documents/class-design.md +7 -4
  48. package/doc-design/documents/integration-guide.md +7 -5
  49. package/doc-design/documents/release.md +5 -3
  50. package/meta-skills/aca/SKILL.md +3 -2
  51. package/meta-skills/aca/SKILL.md.tmpl +3 -2
  52. package/package.json +1 -1
  53. package/skills/aca-design/SKILL.md +1 -1
  54. package/skills/aca-implement/SKILL.md +90 -109
  55. package/skills/aca-implement/SKILL.md.tmpl +91 -110
  56. package/skills/aca-release/SKILL.md +4 -3
  57. package/skills/aca-release/SKILL.md.tmpl +4 -3
  58. package/skills/aca-repo-audit/SKILL.md +11 -9
  59. package/skills/aca-repo-audit/SKILL.md.tmpl +10 -8
  60. package/skills/aca-review/SKILL.md +114 -115
  61. package/skills/aca-review/SKILL.md.tmpl +115 -116
  62. package/skills/aca-test/SKILL.md +110 -0
  63. package/skills/aca-test/SKILL.md.tmpl +108 -0
  64. package/skills/aca-walkthrough/SKILL.md +1 -1
  65. package/zh-CN/axioms/README.md +1 -1
  66. package/zh-CN/axioms/writing.md +1 -1
  67. package/zh-CN/dist/antigravity/aca/SKILL.md +3 -2
  68. package/zh-CN/dist/antigravity/aca-design/SKILL.md +1 -1
  69. package/zh-CN/dist/antigravity/aca-implement/SKILL.md +89 -108
  70. package/zh-CN/dist/antigravity/aca-release/SKILL.md +62 -52
  71. package/zh-CN/dist/antigravity/aca-repo-audit/SKILL.md +37 -29
  72. package/zh-CN/dist/antigravity/aca-review/SKILL.md +112 -113
  73. package/zh-CN/dist/antigravity/aca-test/SKILL.md +110 -0
  74. package/zh-CN/dist/antigravity/aca-walkthrough/SKILL.md +1 -1
  75. package/zh-CN/dist/antigravity-cli/aca/SKILL.md +3 -2
  76. package/zh-CN/dist/antigravity-cli/aca-design/SKILL.md +1 -1
  77. package/zh-CN/dist/antigravity-cli/aca-implement/SKILL.md +89 -108
  78. package/zh-CN/dist/antigravity-cli/aca-release/SKILL.md +62 -52
  79. package/zh-CN/dist/antigravity-cli/aca-repo-audit/SKILL.md +37 -29
  80. package/zh-CN/dist/antigravity-cli/aca-review/SKILL.md +112 -113
  81. package/zh-CN/dist/antigravity-cli/aca-test/SKILL.md +110 -0
  82. package/zh-CN/dist/antigravity-cli/aca-walkthrough/SKILL.md +1 -1
  83. package/zh-CN/dist/codex/aca/SKILL.md +3 -2
  84. package/zh-CN/dist/codex/aca-design/SKILL.md +1 -1
  85. package/zh-CN/dist/codex/aca-implement/SKILL.md +89 -108
  86. package/zh-CN/dist/codex/aca-release/SKILL.md +62 -52
  87. package/zh-CN/dist/codex/aca-repo-audit/SKILL.md +37 -29
  88. package/zh-CN/dist/codex/aca-review/SKILL.md +112 -113
  89. package/zh-CN/dist/codex/aca-test/SKILL.md +110 -0
  90. package/zh-CN/dist/codex/aca-walkthrough/SKILL.md +1 -1
  91. package/zh-CN/dist/cursor/aca/SKILL.md +3 -2
  92. package/zh-CN/dist/cursor/aca-design/SKILL.md +1 -1
  93. package/zh-CN/dist/cursor/aca-implement/SKILL.md +89 -108
  94. package/zh-CN/dist/cursor/aca-release/SKILL.md +62 -52
  95. package/zh-CN/dist/cursor/aca-repo-audit/SKILL.md +37 -29
  96. package/zh-CN/dist/cursor/aca-review/SKILL.md +112 -113
  97. package/zh-CN/dist/cursor/aca-test/SKILL.md +111 -0
  98. package/zh-CN/dist/cursor/aca-walkthrough/SKILL.md +1 -1
  99. package/zh-CN/dist/grok/aca/SKILL.md +3 -2
  100. package/zh-CN/dist/grok/aca-design/SKILL.md +1 -1
  101. package/zh-CN/dist/grok/aca-implement/SKILL.md +89 -108
  102. package/zh-CN/dist/grok/aca-release/SKILL.md +62 -52
  103. package/zh-CN/dist/grok/aca-repo-audit/SKILL.md +37 -29
  104. package/zh-CN/dist/grok/aca-review/SKILL.md +112 -113
  105. package/zh-CN/dist/grok/aca-test/SKILL.md +110 -0
  106. package/zh-CN/dist/grok/aca-walkthrough/SKILL.md +1 -1
  107. package/zh-CN/doc-design/document-sets/module.md +6 -2
  108. package/zh-CN/doc-design/documents/class-design.md +7 -4
  109. package/zh-CN/doc-design/documents/integration-guide.md +7 -5
  110. package/zh-CN/doc-design/documents/release.md +5 -3
  111. package/zh-CN/meta-skills/aca/SKILL.md +3 -2
  112. package/zh-CN/meta-skills/aca/SKILL.md.tmpl +3 -2
  113. package/zh-CN/skills/aca-design/SKILL.md +1 -1
  114. package/zh-CN/skills/aca-implement/SKILL.md +89 -108
  115. package/zh-CN/skills/aca-implement/SKILL.md.tmpl +89 -108
  116. package/zh-CN/skills/aca-release/SKILL.md +62 -52
  117. package/zh-CN/skills/aca-release/SKILL.md.tmpl +62 -52
  118. package/zh-CN/skills/aca-repo-audit/SKILL.md +37 -29
  119. package/zh-CN/skills/aca-repo-audit/SKILL.md.tmpl +36 -28
  120. package/zh-CN/skills/aca-review/SKILL.md +112 -113
  121. package/zh-CN/skills/aca-review/SKILL.md.tmpl +111 -112
  122. package/zh-CN/skills/aca-test/SKILL.md +110 -0
  123. package/zh-CN/skills/aca-test/SKILL.md.tmpl +108 -0
  124. package/zh-CN/skills/aca-walkthrough/SKILL.md +1 -1
@@ -9,7 +9,7 @@ disable-model-invocation: true
9
9
  # aca-review
10
10
 
11
11
  Review the design docs or code implementation in the current scope and determine pass, needs changes, or incomplete
12
- Do not modify design docs, project source code, or test code
12
+ Do not modify design docs, project source code, or test code, and do not run the code or tests under review
13
13
  Use `/aca-repo-audit` for the repository-wide audit before release
14
14
 
15
15
  ## 1 Principles
@@ -18,11 +18,11 @@ Use `/aca-repo-audit` for the repository-wide audit before release
18
18
 
19
19
  1. **Source-driven review**
20
20
  Review the design against confirmed requirements and applicable rules
21
- Review the implementation against the confirmed design
21
+ Review the code and test implementation against the confirmed design
22
22
  2. **Independent judgment**
23
23
  Form conclusions independently for each review task
24
24
  3. **Evidence-based verdict**
25
- Determine issues and review conclusions from item-by-item verification results and evidence
25
+ Determine issues and review conclusions from item-by-item verification results and facts in code and docs
26
26
  4. **Scope constraints**
27
27
  Limit review conclusions to the current scope
28
28
 
@@ -37,7 +37,7 @@ The writing axiom applies to reviews of design doc prose and the wording of revi
37
37
  - Present the whole first, then expand on the details, see the [Pyramid Principle](~/.cursor/skills/aca/SSOT.md#2-structure)
38
38
  - When stating a judgment, give the conclusion first, then the supporting evidence
39
39
  - Merge heading levels that add no information
40
- - Use numbered lists for items with a sequence or priority, and indent multiple attributes under each item
40
+ - Use numbered lists for items with a sequence or priority; when a step contains sub-items, start the step with a bold phrase stating its purpose and indent specific operations and conditional branches under it
41
41
  - Use tables only for content with multiple rows of the same structure, more than two attributes per row, and no sequence between rows
42
42
  - Write list items as complete sentences
43
43
  - When an item has branches, indent the branches under that item
@@ -81,7 +81,7 @@ Reference: [ASD-STE100](~/.cursor/skills/aca/SSOT.md#1-writing-rules)
81
81
  ```mermaid
82
82
  flowchart TD
83
83
  Start([Receive review request]) --> Scope["Confirm review scope and execution models · §3"]
84
- Scope --> Check["Determine review type and run the corresponding checks · §4"]
84
+ Scope --> Check["Determine review type and prepare sources · §4"]
85
85
  Check --> Audit["Orchestrate and run independent reviews for the selected review type · §5"]
86
86
  Audit --> Verify["Recheck and summarize · §6"]
87
87
  Verify --> Issues{"Confirmed must-fix items exist · §7"}
@@ -95,81 +95,78 @@ flowchart TD
95
95
 
96
96
  ### 3.1 Subject, Scope, and Prerequisites
97
97
 
98
- 1. If the developer has specified the review subject and scope, follow that specification first
99
- Otherwise, use the review subject and scope already specified by the caller
100
- 2. If the subject or scope is unclear, determine it from current workspace changes and recent relevant commits
101
- Read the descriptions and diffs of recent relevant commits to understand the intent and content of the changes
102
- 3. If the review subject or scope is still unclear, ask the developer to specify it
103
- 4. Record the review subject, scope, and comparison baseline
104
- Specify the commits under review and any uncommitted changes included in the review
105
- 5. Run `bash ~/.cursor/skills/aca/bin/aca-repo-type-check` to check the repo type
106
- If the repo type is missing or invalid, mark the repo-type spec check as incomplete and recommend running `/aca-init`
107
- If the repo type is not yet supported, mark the repo-type spec check as incomplete and note that the corresponding rules are missing
108
- 6. If the input does not include the design doc location, locate it through the documentation entry in the root README
109
- If the review source material or files under review cannot be located, ask the developer to provide their locations
110
- Until the locations are clear, mark checks that depend on this content as incomplete
111
-
112
- 7. Read the general review source material
113
- Read the confirmed problems, goals, and change scope for this review
114
- If the repo type is valid and supported, read the corresponding Repo Type rules
115
- Read `CONTEXT.md` and check the business concepts and definitions involved in this review
116
- Read the design docs for the current scope and follow references to read any additional docs needed for understanding and verification
98
+ 1. **Confirm the review subject and scope**
99
+ - Developer has specified the review subject and scope: follow that specification first
100
+ - Developer has not specified them: use the review subject and scope already specified by the caller
101
+ - Subject or scope is still unclear: determine it from current workspace changes and recent relevant commits, reading the descriptions and diffs of recent relevant commits
102
+ - Review subject or scope still cannot be determined: ask the developer to specify it
103
+ 2. **Record the comparison baseline**
104
+ - Record the review subject, scope, and comparison baseline
105
+ - Specify the commits under review and any uncommitted changes included in the review
106
+ 3. **Check the repo type**
107
+ - Run `bash ~/.cursor/skills/aca/bin/aca-repo-type-check` to check the repo type
108
+ - Repo type is missing or invalid: mark the repo-type spec check as incomplete and recommend running `/aca-init`
109
+ - Repo type is not yet supported: mark the repo-type spec check as incomplete and note that the corresponding rules are missing
110
+ 4. **Locate and read general review sources**
111
+ - When the input does not include the design doc location, locate it from the documentation entry in the root README, or ask the developer for its location if it cannot be located and mark checks that depend on this content as incomplete until the location is clear
112
+ - Read the confirmed problems, goals, and change scope for this review
113
+ - If the repo type is valid and supported, read the corresponding Repo Type rules
114
+ - Read `CONTEXT.md` and check the business concepts and definitions involved in this review
115
+ - Read the design docs for the current scope and follow references to read any additional docs needed for understanding and verification
117
116
 
118
117
  ### 3.2 Agent and Model Selection
119
118
 
120
- 1. Scan the current AI Agent environment and other AI Agent environments already available on this machine
121
- Record the Agent tool types and actual model identifiers in each environment and compare them with the main agent
122
- Use existing tool entry points, configuration, and model lists to verify invocation methods and availability
123
- Installation or configuration alone does not prove that an environment can be invoked
124
- Mark information that cannot be verified as unknown
125
- 2. Propose execution combinations based on the scan results
126
- Prefer callable flagship models and assess flagship status using information that can currently be verified
127
- Prefer combinations whose Agent environment and model both differ from those of the main agent
128
- Do not prescribe a brand, model, or order of attempts
129
- If no other suitable and callable candidate is available, propose using the current model
130
- 3. Show each candidate's Agent, model, availability, invocation method, and differences from the main agent
131
- Explain the recommendation and available alternative combinations, and ask the developer to confirm
132
- Run the review only after the developer confirms
133
- Reuse the existing confirmation if the confirmed selection and availability conditions have not changed
134
- 4. Use the confirmed execution combinations for [task orchestration](#53-model-and-task-orchestration)
135
- If the selected combination cannot be invoked, use a confirmed alternative
136
- If no alternative has been confirmed, report the change and ask the developer to confirm a new combination
137
- Record the actual selection, fallback, and reasons in the report
119
+ 1. **Scan available Agent environments and models**
120
+ - Scan the current AI Agent environment and other AI Agent environments already available on this machine
121
+ - Record the Agent tool types and actual model identifiers in each environment and compare them with the main agent
122
+ - Use existing tool entry points, configuration, and model lists to verify invocation methods and availability
123
+ - Installation or configuration alone does not prove that an environment can be invoked, and information that cannot be verified is marked as unknown
124
+ 2. **Propose execution combinations**
125
+ - Prefer callable flagship models and assess flagship status using information that can currently be verified
126
+ - Prefer combinations whose Agent environment and model both differ from those of the main agent, without prescribing a brand, model, or order of attempts
127
+ - If no other suitable and callable candidate is available, propose using the current model
128
+ 3. **Confirm execution combinations**
129
+ - Show each candidate's Agent, model, availability, invocation method, and differences from the main agent
130
+ - Explain the recommendation and available alternative combinations, and ask the developer to confirm before running the review
131
+ - Reuse the existing confirmation if the confirmed selection and availability conditions have not changed
132
+ 4. **Handle execution fallback**
133
+ - Use the confirmed execution combinations for [Model and Task Orchestration](#53-model-and-task-orchestration)
134
+ - If the selected combination cannot be invoked, use a confirmed alternative, or report the change and ask the developer to confirm a new combination if no alternative has been confirmed
135
+ - Record the actual selection, fallback, and reasons in the report
138
136
 
139
137
  ## 4 Read Source Material and Run Checks
140
138
 
141
139
  ```mermaid
142
140
  flowchart TD
143
- Kind["Determine review type · §4.1"] -- Design review --> Design["Design review · §4.2"]
144
- Kind -- Implementation review --> Implementation["Implementation review · §4.3"]
141
+ Kind["Determine review type · §4.1"] -- Design review --> Design["Design review preparation and mechanical checks · §4.2"]
142
+ Kind -- Implementation review --> Implementation["Implementation review source preparation · §4.3"]
145
143
  Design --> Results["Handle check results · §4.4"]
146
- Implementation --> Results
144
+ Implementation --> Next(["Proceed to independent review orchestration · §5"])
145
+ Results --> Next
147
146
  ```
148
147
 
149
148
  ### 4.1 Determine Review Type
150
149
 
151
- 1. If the developer has specified the review type, follow that specification first
152
- Otherwise, use the review type already specified by the caller
153
- 2. If the review type is unclear, determine it from the subject under review and the actual changes
154
- - Design docs: run a design review
155
- - Code, tests, or runtime configuration: run an implementation review
156
- - Both design and implementation: run both review types separately
157
- 3. If the review type is still unclear, ask the developer to specify it
150
+ 1. **Determine the review type for this run**
151
+ - Developer has specified the review type: follow that specification first
152
+ - Developer has not specified it: use the review type already specified by the caller
153
+ - Review type is not specified: determine it from the subject under review and the actual changes (run a design review for design docs, run an implementation review for code, tests, or runtime configuration, and run both review types separately when both are involved)
154
+ - Review type still cannot be determined: ask the developer to specify it
158
155
 
159
- Run both check branches when both review types are selected
156
+ Run both branches when both review types are selected
160
157
 
161
158
  ### 4.2 Design Review
162
159
 
163
- 1. Read the document set, Doc Design, and Patterns actually used for the current scope
164
- Extract their applicable checklist items as the basis for item-by-item verification
165
- 2. Determine target paths for mechanical checks based on the current review scope
166
- Prose checks cover all docs under review, including project-level records within the review scope
167
- For the doc graph check, select a doc tree that includes the docs under review and has a README entry
168
- Mechanical checks for Context verify structure and formatting, while content is verified against the corresponding Doc Design checklist
169
- 3. Run or reuse mechanical checks
170
- Existing mechanical check results from this session can be reused if they cover the same scope and the relevant files, check rules, and tools have not changed
171
- When reusing results, state the original check results and the reuse conditions met in this review in the report
172
- If the reuse conditions are not met, replace the placeholder paths in the following commands with the actual paths determined in step 2 and run them
160
+ 1. **Extract applicable checklist items**
161
+ - Read the document set, Doc Design, and Patterns actually used for the current scope
162
+ - Extract their applicable checklist items as the basis for item-by-item verification
163
+ 2. **Determine target paths for mechanical checks**
164
+ - Prose checks cover all docs under review, including project-level records within the review scope
165
+ - For the doc graph check, select a doc tree that includes the docs under review and has a README entry
166
+ - Mechanical checks for Context verify structure and formatting, while content is verified against the corresponding Doc Design checklist
167
+ 3. **Run or reuse mechanical checks**
168
+ - Existing mechanical check results from this session can be reused if they cover the same scope and the relevant files, check rules, and tools have not changed, stating the original results and reuse conditions in the report
169
+ - If the reuse conditions are not met, replace the placeholder paths in the following commands with the actual paths determined in step 2 and run them
173
170
 
174
171
  ```bash
175
172
  bash ~/.cursor/skills/aca/bin/aca-doc-graph-check <doc directory>
@@ -179,22 +176,19 @@ Run both check branches when both review types are selected
179
176
 
180
177
  ### 4.3 Implementation Review
181
178
 
182
- 1. Read the confirmed design, test design, and repository implementation conventions for the current scope
183
- 2. Read the current diff and changed files against the established comparison baseline
184
- Read affected callers and dependency code
185
- Read the functions, classes, and related call chains containing the changes to understand their execution context
186
- 3. Map the implementation and tests to the design conventions and test scenarios respectively
187
- 4. Based on the impact scope of the current changes, run or reuse the tests, builds, and static checks required by the design and repository conventions
188
- Verify behavior that the design requires checking through actual execution by running the corresponding test cases
189
- Existing verification results can be reused if they cover the same content under review and the test cases, fixtures, configuration, and dependency environment have not changed
190
- When reusing results, state the original verification results and the reuse conditions met in this review in the report
191
- Run the corresponding checks if verification evidence is insufficient or reuse conditions are not met
192
- Use an isolated verification environment as specified by the test design
193
- Do not modify commit history during verification
179
+ 1. **Read design and implementation conventions**
180
+ - Read the confirmed design, test design, and repository implementation conventions for the current scope
181
+ 2. **Read code and tests under review**
182
+ - Read the current diff and changed files against the established comparison baseline
183
+ - Read affected callers and dependency code
184
+ - Read the functions, classes, test files, and related call chains containing the changes to understand their execution context
185
+ 3. **Map design to implementation**
186
+ - Map the production code implementation and test code implementation to the design conventions and test scenarios respectively for item-by-item static review in Chapter 5
187
+ - Implementation review does not run code, tests, or builds directly, and runtime verification is executed by `/aca-test` after the review passes
194
188
 
195
189
  ### 4.4 Handle Check Results
196
190
 
197
- Handle tool checks for both review types as specified in this section
191
+ Handle mechanical checks for design reviews as specified in this section
198
192
 
199
193
  | Check status | Action |
200
194
  | --- | --- |
@@ -226,62 +220,67 @@ Handle tool checks for both review types as specified in this section
226
220
 
227
221
  ### 5.2 Implementation Review Dimensions
228
222
 
229
- Check the following items individually against the confirmed design docs
223
+ Statically check the following items individually against the confirmed design docs
230
224
 
231
225
  1. **Structural setup**
232
226
  Check whether the division of modules and files, responsibility assignments, interface definitions, and dependencies conform to the design
233
227
  2. **Detailed logic implementation**
234
228
  Check whether inputs, outputs, and processing flows conform to the design
235
229
  Check whether data and state changes, error handling, and boundary behavior conform to the design
236
- Check whether fixtures, scenarios, and expected results in black-box and white-box tests conform to the corresponding test design
230
+ Check whether fixtures, scenarios, and assertions in black-box and white-box test code completely cover the corresponding test design
237
231
  Check whether test assertions can detect deviations between actual behavior and expected results
238
232
  3. **Overall structural implementation**
239
233
  Check whether module assembly, call chains, and collaboration methods conform to the overall architecture design
240
- Check whether integrated behavior conforms to the cross-module flows and acceptance criteria in the design
234
+ Check whether cross-module wiring conforms to the flows and contract boundaries in the design
241
235
 
242
236
  ### 5.3 Model and Task Orchestration
243
237
 
244
- 1. Create independent review tasks for the selected review type
245
- For design reviews, assign an independent sub-agent to each perspective
246
- For implementation reviews, assign independent sub-agents to structural setup, detailed logic implementation, and overall structural implementation
247
- Each sub-agent forms conclusions independently without reading other sub-agents' review results beforehand
248
- 2. Arrange execution using the combinations confirmed in [Agent and Model Selection](#32-agent-and-model-selection)
249
- Keep review tasks independent even when using the current model
250
- 3. Provide task context to each sub-agent
238
+ 1. **Create independent review tasks**
239
+ - For design reviews, assign an independent sub-agent to each perspective
240
+ - For implementation reviews, assign independent sub-agents to structural setup, detailed logic implementation, and overall structural implementation
241
+ - Each sub-agent forms conclusions independently without reading other sub-agents' review results beforehand
242
+ 2. **Arrange execution models**
243
+ - Arrange execution using the combinations confirmed in [Agent and Model Selection](#32-agent-and-model-selection)
244
+ - Keep review tasks independent even when using the current model
245
+ 3. **Provide task context**
251
246
  - Assigned review items and applicable checklist items
252
247
  - Review subject, scope, and comparison baseline, including commits under review and uncommitted changes included in the review
253
248
  - Locations of the content under review and the corresponding design source material
254
- - Existing check results and evidence from chapter 4, with the basis for execution or reuse
255
- - The diff, changed files, affected callers and dependency code, and repository implementation conventions needed for the implementation review
249
+ - Existing mechanical check results and evidence from Chapter 4
250
+ - The diff, changed files, test files, affected callers and dependency code, and repository implementation conventions needed for the implementation review
256
251
 
257
252
  ### 5.4 Run the Review
258
253
 
259
- 1. Each sub-agent verifies its assigned checklist items individually
260
- If a checklist item does not apply to the current scope, record it as not applicable and state the basis
261
- 2. For each check, record the verification result, corresponding file location, and basis for judgment
262
- 3. For each issue, record the location, problem, impact, and recommended changes using the issue format in [Review Report](#81-review-report)
263
- 4. Return the complete check records, issue list, and incomplete items to the main agent
254
+ 1. **Verify checklist items individually**
255
+ - Each sub-agent verifies its assigned checklist items individually
256
+ - If a checklist item does not apply to the current scope, record it as not applicable and state the basis
257
+ 2. **Record verification results and issues**
258
+ - For each check, record the verification result, corresponding file location, and basis for judgment
259
+ - For each issue, record the location, problem, impact, and recommended changes using the issue format in [Review Report](#81-review-report)
260
+ 3. **Return summary to the main agent**
261
+ - Return the complete check records, issue list, and incomplete items to the main agent
264
262
 
265
263
  ## 6 Recheck and Summarize
266
264
 
267
- 1. The main agent reads each sub-agent's check records
268
- Check whether tool checks and verification evidence correspond to the current content under review
269
- 2. Check the files and evidence for each issue and include it in the report only after confirming it
270
- Exclude disproven issues
271
- Mark issues with insufficient evidence as incomplete verification
272
- The main agent can add issues it finds independently after applying the same evidence verification
273
- Merge duplicate issues while retaining their locations, evidence, and impact
274
- 3. Summarize the check records for all review items and check each checklist item's applicability and verification result
275
- If a sub-agent did not cover its assigned scope, omitted checks, or lacked verification evidence, assign the corresponding supplementary checks
276
- The main agent rechecks the supplementary results
277
- Mark review items or checks that still cannot be completed as incomplete and state the reasons
278
- 4. Summarize confirmed issues and check completion status as the basis for the verdict
265
+ 1. **Read sub-agent check records**
266
+ - The main agent reads each sub-agent's check records and checks whether the check evidence corresponds to the current content under review
267
+ 2. **Recheck and merge issues**
268
+ - Check the files and evidence for each issue and include it in the report only after confirming it
269
+ - Exclude disproven issues and mark issues with insufficient evidence as incomplete verification
270
+ - The main agent can add issues it finds independently after applying the same evidence verification
271
+ - Merge duplicate issues while retaining their locations, evidence, and impact
272
+ 3. **Check review coverage**
273
+ - Summarize the check records for all review items and check each checklist item's applicability and verification result
274
+ - If a sub-agent did not cover its assigned scope, omitted checks, or lacked verification evidence, assign the corresponding supplementary checks and recheck the results
275
+ - Mark review items or checks that still cannot be completed as incomplete and state the reasons
276
+ 4. **Form the basis for the verdict**
277
+ - Summarize confirmed issues and check completion status as the basis for the verdict
279
278
 
280
279
  ## 7 Verdict
281
280
 
282
281
  | Verdict | Criteria |
283
282
  | --- | --- |
284
- | Pass | All selected review tasks are complete, all applicable checklist items have passed verification, all applicable tool checks have passed, and there are no must-fix items |
283
+ | Pass | All selected review tasks are complete, all applicable checklist items have passed verification, all applicable mechanical checks have passed, and there are no must-fix items |
285
284
  | Needs changes | Confirmed must-fix items exist |
286
285
  | Incomplete | Pass criteria are not met and there are no confirmed must-fix items |
287
286
 
@@ -305,7 +304,7 @@ Output the review results in the current conversation using the following templa
305
304
  | Baseline | <comparison baseline, commits under review, and uncommitted changes> |
306
305
  | Verdict basis | <how pass criteria are met, or issues and incomplete checks preventing a pass> |
307
306
  | Must fix | <issue count and main impact / none> |
308
- | Tool checks | <pass, failure, and incomplete status of tests, builds, or mechanical checks> |
307
+ | Tool checks | <pass, failure, and incomplete status of design review mechanical checks / not applicable for implementation review> |
309
308
  | Incomplete | <incomplete review tasks and checks within the current scope, and reasons / none> |
310
309
  | Next step | <one immediately actionable step> |
311
310
 
@@ -324,7 +323,7 @@ Output the review results in the current conversation using the following templa
324
323
 
325
324
  - Read: <files actually read in this review>
326
325
  - Checklist: <criteria and sources, item-by-item verification results, basis for non-applicability, and reasons for incomplete checks>
327
- - Tools: <commands actually run and their results, or original results reused and basis for reuse>
326
+ - Tools: <mechanical check commands actually run and their results, or original results reused and basis for reuse / not applicable for implementation review>
328
327
 
329
328
  | Review item | Agent environment | Model | Completion status | Notes |
330
329
  | --- | --- | --- | --- | --- |
@@ -340,12 +339,12 @@ Select the next step based on the review verdict and progress in the current rou
340
339
 
341
340
  | Verdict | Situation | Next step |
342
341
  | --- | --- | --- |
343
- | Incomplete | Inputs, verification environment, or verification conditions are missing | Report the conditions for resuming and continue this review through `/aca-review` once they are met |
344
- | Needs changes | Implementation issues | Fix and verify through `/aca-implement` |
345
- | Needs changes | The design solution still needs reasoning or decisions | Extend or revise the solution through `/aca-specify` |
346
- | Needs changes | The solution is clear and only design docs need revision | Revise the docs through `/aca-design` |
347
- | Pass | Only the design review has passed and implementation is needed in this round | `/aca-implement` |
348
- | Pass | The implementation review has passed and implementation tasks remain in this round | Continue implementation through `/aca-implement` |
349
- | Pass | All work in this round is complete and all required reviews have passed | Proceed to `/aca-release` according to the confirmed version progression plan |
342
+ | Incomplete | Inputs or verification conditions are missing | Report the conditions for resuming and continue this review through `/aca-review` once they are met |
343
+ | Needs changes | The design solution still needs reasoning or decisions | `/aca-specify` Extend or revise the solution |
344
+ | Needs changes | The solution is clear and only design docs need revision | `/aca-design` Revise the docs |
345
+ | Needs changes | Code or test implementation issues | `/aca-implement` Fix the implementation |
346
+ | Pass | Design review passed and code implementation is needed in this round | `/aca-implement` |
347
+ | Pass | Design review passed and only design docs are changed in this round | Proceed to `/aca-release` according to the confirmed version progression plan |
348
+ | Pass | Implementation review passed | `/aca-test` Run test verification for the current scope |
350
349
 
351
350
  After design or implementation corrections, review the affected scope again through `/aca-review`
@@ -0,0 +1,111 @@
1
+ ---
2
+ name: aca-test
3
+ description: Select and run minimal tests based on the current implementation or change blast radius, testing only without modifying files
4
+ disable-model-invocation: true
5
+ ---
6
+ <!-- AUTO-GENERATED from SKILL.md.tmpl — do not edit directly -->
7
+ <!-- Regenerate: bash scripts/build-skills.sh --host cursor -->
8
+
9
+ # aca-test
10
+
11
+ Select and run the corresponding minimal tests based on the current implementation scope or the design boundary crossed by changes
12
+ Run tests and verification only, without modifying design docs, production code, or test code
13
+
14
+ ## 1 Principles
15
+
16
+ 1. **Blast-Radius Scoping**
17
+ Determine the minimal test scope from the contract boundaries and dependencies of the current implementation or changes
18
+ 2. **Test Only, No Edits**
19
+ Run tests and verify results only, without modifying design docs, production code, or test code
20
+ 3. **Evidence Binding**
21
+ Bind test results to the commit under test, test scope, and commands actually executed for direct reuse by downstream stages
22
+
23
+ ## 2 Workflow
24
+
25
+ ```mermaid
26
+ flowchart TD
27
+ Start([Receive test request]) --> Scope["Determine test scope · §3"]
28
+ Scope --> Reuse{"Result reuse conditions met? · §3"}
29
+ Reuse -- Yes --> Report(["Output and next step · §5"])
30
+ Reuse -- No --> Ready{"Test environment and prerequisites ready? · §3"}
31
+ Ready -- No --> Report
32
+ Ready -- Yes --> Run["Run tests and recheck anomalies · §4"]
33
+ Run --> Report
34
+ ```
35
+
36
+ ## 3 Determine Test Scope
37
+
38
+ 1. **Identify the subject under test and scope of changes**
39
+ - Developer or upstream caller has specified the scope to test: use that scope directly
40
+ - Scope not specified: read current workspace changes and recent commits, and locate the modules, commands, or events to which the changes belong against the design docs
41
+ - Record the commit under test and any uncommitted changes included in verification
42
+ 2. **Select the minimal test set by the design boundary crossed by changes**
43
+ - Only internal implementation of a module, command, or event is added or modified, and the module `interface`, command routing, and event dispatch contracts are unchanged: select only the unit's own white-box and black-box tests
44
+ - Module `interface`, command routing, event dispatch, or cross-unit collaboration is modified: select this unit's tests, tests of modules or commands and events that call this contract, and black-box tests in project-level `testcase` whose design basis links to this unit
45
+ - Shared foundation across modules such as common infrastructure, global configuration, data migration, build, or deployment is modified: select all affected tests and the corresponding environment verification
46
+ - When the repository `release` doc specifies additional verification for the current scope, include it as well
47
+ 3. **Check reuse conditions and execution environment**
48
+ - Existing test results cover the selected scope and the content under test, test code, fixtures, configuration, and dependency environment have not changed: reuse the results directly, record the basis, and proceed to [Output and Next Step](#5-output-and-next-step)
49
+ - Test execution required: check the readiness of the required environment, fixtures, and real dependencies or test doubles according to the test design
50
+ - Environment or dependencies not ready: record the missing conditions and report incomplete according to [Output and Next Step](#5-output-and-next-step)
51
+
52
+ ## 4 Run and Recheck
53
+
54
+ 1. **Control concurrency and resource isolation**
55
+ - Set up fixtures and an isolated environment according to the test design
56
+ - When shared or heavy resources such as containers, databases, real platforms, or model evaluations are involved, limit concurrency and isolate resources to prevent timeouts caused by parallel contention
57
+ 2. **Run the selected tests**
58
+ - Run the test cases selected in [Determine Test Scope](#3-determine-test-scope) along with required builds or static checks
59
+ - After execution completes, clean up test data and temporary resources created in this run according to the fixture rules
60
+ - Do not modify design docs, production code, test code, or commit history during verification
61
+ 3. **Recheck failures and distinguish causes**
62
+ - All pass: record the executed commands, number of passing test cases, and elapsed time
63
+ - Failures occur: check the failure logs and diagnostics
64
+ - Suspected timeout caused by high host load or resource contention: rerun the failed items individually under low-concurrency isolated conditions to verify
65
+ - Individual rerun passes consistently and is confirmed to be caused by environment load: record the initial anomaly, rerun command, and passing result
66
+ - Failure confirmed to be caused by code or test implementation issues: record the failing test cases, error diagnostics, and corresponding locations
67
+ - Environment failure or diagnostics cannot be verified: mark the corresponding verification as incomplete and record the reason
68
+
69
+ ## 5 Output and Next Step
70
+
71
+ ### 5.1 Verdict
72
+
73
+ | Verdict | Criteria |
74
+ | --- | --- |
75
+ | Pass | All tests and required checks in the selected scope pass (including reused results or timeout rechecks), with no failing or incomplete items |
76
+ | Fail | Confirmed code or test failures exist |
77
+ | Incomplete | Environment is missing, execution is impossible, or diagnostics cannot be verified, and no confirmed failures exist |
78
+
79
+ When both confirmed failures and incomplete items exist, the verdict is fail, and the incomplete items must be listed
80
+
81
+ ### 5.2 Test Report
82
+
83
+ Output the test results in the current conversation using the following template
84
+
85
+ ```markdown
86
+ # 🧪 Test: <pass / fail / incomplete>
87
+
88
+ | Item | Result |
89
+ | --- | --- |
90
+ | Scope | <unit or change scope under test> |
91
+ | Baseline | <commit under test and uncommitted changes included in verification> |
92
+ | Selection basis | <upstream scope / intra-unit tests with unchanged contract / dependency-chain tests for contract change / full tests for global foundation> |
93
+ | Commands | <actual test and check commands run, or basis for reuse> |
94
+ | Result | <pass count, fail count, and elapsed time> |
95
+ | Anomaly recheck | <individual rerun verification result for timeouts / none> |
96
+ | Failures | <failing test cases, causes, and corresponding locations / none> |
97
+ | Incomplete | <unexecuted verification, reasons, and conditions for resuming / none> |
98
+ | Next step | <one immediately actionable step> |
99
+ ```
100
+
101
+ ### 5.3 Follow-Up Actions
102
+
103
+ Select the next step based on the test verdict and progress in the current round
104
+
105
+ | Verdict | Situation | Next step |
106
+ | --- | --- | --- |
107
+ | Incomplete | Test environment, fixtures, or external dependencies are missing | Supply the environment conditions and verify again through `/aca-test` |
108
+ | Fail | Code or test implementation issues | Fix through `/aca-implement`, review through `/aca-review`, then run `/aca-test` |
109
+ | Fail | Missing design or contract conflict | Revise the design through `/aca-specify` or `/aca-design` |
110
+ | Pass | Subsequent implementation tasks remain in this round | Continue implementing the next scope through `/aca-implement` |
111
+ | Pass | All implementation scopes in this round have passed verification | Proceed to `/aca-release` according to the version progression plan or conclude the current task |
@@ -34,7 +34,7 @@ Confirm design decisions unit by unit and correct identified issues on the spot
34
34
  - Present the whole first, then expand on the details, see the [Pyramid Principle](~/.cursor/skills/aca/SSOT.md#2-structure)
35
35
  - When stating a judgment, give the conclusion first, then the supporting evidence
36
36
  - Merge heading levels that add no information
37
- - Use numbered lists for items with a sequence or priority, and indent multiple attributes under each item
37
+ - Use numbered lists for items with a sequence or priority; when a step contains sub-items, start the step with a bold phrase stating its purpose and indent specific operations and conditional branches under it
38
38
  - Use tables only for content with multiple rows of the same structure, more than two attributes per row, and no sequence between rows
39
39
  - Write list items as complete sentences
40
40
  - When an item has branches, indent the branches under that item
@@ -43,8 +43,9 @@ flowchart TD
43
43
  | `/aca-specify` | Reason through new requirements or improve existing designs, then proceed to Design after confirming the solution |
44
44
  | `/aca-design` | Write and check design docs within the current scope, then determine the next scope or complete the overall closeout |
45
45
  | `/aca-walkthrough` | Walk through design docs in business language, confirm design decisions unit by unit, and correct identified issues on the spot after confirmation |
46
- | `/aca-review` | Determine the review subject and scope, review the design or check implementation compliance with the design, without modifying the docs or code under review |
47
- | `/aca-implement` | Plan the file structure based on the design, then implement and verify code and tests according to module dependencies |
46
+ | `/aca-review` | Determine the review subject and scope, statically review the design or code and test implementation, without modifying the docs or code under review or running code |
47
+ | `/aca-implement` | Plan the file structure based on the design, then write production code and test code according to module dependencies |
48
+ | `/aca-test` | Select and run minimal tests based on the current implementation scope or the design boundary crossed by changes, testing only without modifying files |
48
49
  | `/aca-repo-audit` | Check repository documentation and verify the implementation as needed, with read-only access and no changes |
49
50
  | `/aca-release` | Close out according to the repository release workflow, merge into main, and lock in an annotated Tag |
50
51
  | `/aca-feedback` | Collect deviations from governance rules and submit an Issue after explicit authorization |
@@ -22,7 +22,7 @@ Change only documentation, not code
22
22
  - Present the whole first, then expand on the details, see the [Pyramid Principle](~/.grok/skills/aca/SSOT.md#2-structure)
23
23
  - When stating a judgment, give the conclusion first, then the supporting evidence
24
24
  - Merge heading levels that add no information
25
- - Use numbered lists for items with a sequence or priority, and indent multiple attributes under each item
25
+ - Use numbered lists for items with a sequence or priority; when a step contains sub-items, start the step with a bold phrase stating its purpose and indent specific operations and conditional branches under it
26
26
  - Use tables only for content with multiple rows of the same structure, more than two attributes per row, and no sequence between rows
27
27
  - Write list items as complete sentences
28
28
  - When an item has branches, indent the branches under that item