anyone-can-architect 0.2.0 → 0.3.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +6 -4
- package/README.zh-CN.md +4 -2
- package/VERSION +1 -1
- package/axioms/README.md +1 -1
- package/axioms/writing.md +1 -1
- package/dist/antigravity/aca/SKILL.md +3 -2
- package/dist/antigravity/aca-design/SKILL.md +1 -1
- package/dist/antigravity/aca-implement/SKILL.md +90 -109
- package/dist/antigravity/aca-release/SKILL.md +4 -3
- package/dist/antigravity/aca-repo-audit/SKILL.md +11 -9
- package/dist/antigravity/aca-review/SKILL.md +114 -115
- package/dist/antigravity/aca-test/SKILL.md +110 -0
- package/dist/antigravity/aca-walkthrough/SKILL.md +1 -1
- package/dist/antigravity-cli/aca/SKILL.md +3 -2
- package/dist/antigravity-cli/aca-design/SKILL.md +1 -1
- package/dist/antigravity-cli/aca-implement/SKILL.md +90 -109
- package/dist/antigravity-cli/aca-release/SKILL.md +4 -3
- package/dist/antigravity-cli/aca-repo-audit/SKILL.md +11 -9
- package/dist/antigravity-cli/aca-review/SKILL.md +114 -115
- package/dist/antigravity-cli/aca-test/SKILL.md +110 -0
- package/dist/antigravity-cli/aca-walkthrough/SKILL.md +1 -1
- package/dist/codex/aca/SKILL.md +3 -2
- package/dist/codex/aca-design/SKILL.md +1 -1
- package/dist/codex/aca-implement/SKILL.md +90 -109
- package/dist/codex/aca-release/SKILL.md +4 -3
- package/dist/codex/aca-repo-audit/SKILL.md +11 -9
- package/dist/codex/aca-review/SKILL.md +114 -115
- package/dist/codex/aca-test/SKILL.md +110 -0
- package/dist/codex/aca-walkthrough/SKILL.md +1 -1
- package/dist/cursor/aca/SKILL.md +3 -2
- package/dist/cursor/aca-design/SKILL.md +1 -1
- package/dist/cursor/aca-implement/SKILL.md +90 -109
- package/dist/cursor/aca-release/SKILL.md +4 -3
- package/dist/cursor/aca-repo-audit/SKILL.md +11 -9
- package/dist/cursor/aca-review/SKILL.md +114 -115
- package/dist/cursor/aca-test/SKILL.md +111 -0
- package/dist/cursor/aca-walkthrough/SKILL.md +1 -1
- package/dist/grok/aca/SKILL.md +3 -2
- package/dist/grok/aca-design/SKILL.md +1 -1
- package/dist/grok/aca-implement/SKILL.md +90 -109
- package/dist/grok/aca-release/SKILL.md +4 -3
- package/dist/grok/aca-repo-audit/SKILL.md +11 -9
- package/dist/grok/aca-review/SKILL.md +114 -115
- package/dist/grok/aca-test/SKILL.md +110 -0
- package/dist/grok/aca-walkthrough/SKILL.md +1 -1
- package/doc-design/document-sets/module.md +6 -2
- package/doc-design/documents/class-design.md +7 -4
- package/doc-design/documents/integration-guide.md +7 -5
- package/doc-design/documents/release.md +5 -3
- package/meta-skills/aca/SKILL.md +3 -2
- package/meta-skills/aca/SKILL.md.tmpl +3 -2
- package/package.json +1 -1
- package/skills/aca-design/SKILL.md +1 -1
- package/skills/aca-implement/SKILL.md +90 -109
- package/skills/aca-implement/SKILL.md.tmpl +91 -110
- package/skills/aca-release/SKILL.md +4 -3
- package/skills/aca-release/SKILL.md.tmpl +4 -3
- package/skills/aca-repo-audit/SKILL.md +11 -9
- package/skills/aca-repo-audit/SKILL.md.tmpl +10 -8
- package/skills/aca-review/SKILL.md +114 -115
- package/skills/aca-review/SKILL.md.tmpl +115 -116
- package/skills/aca-test/SKILL.md +110 -0
- package/skills/aca-test/SKILL.md.tmpl +108 -0
- package/skills/aca-walkthrough/SKILL.md +1 -1
- package/zh-CN/axioms/README.md +1 -1
- package/zh-CN/axioms/writing.md +1 -1
- package/zh-CN/dist/antigravity/aca/SKILL.md +3 -2
- package/zh-CN/dist/antigravity/aca-design/SKILL.md +1 -1
- package/zh-CN/dist/antigravity/aca-implement/SKILL.md +89 -108
- package/zh-CN/dist/antigravity/aca-release/SKILL.md +62 -52
- package/zh-CN/dist/antigravity/aca-repo-audit/SKILL.md +37 -29
- package/zh-CN/dist/antigravity/aca-review/SKILL.md +112 -113
- package/zh-CN/dist/antigravity/aca-test/SKILL.md +110 -0
- package/zh-CN/dist/antigravity/aca-walkthrough/SKILL.md +1 -1
- package/zh-CN/dist/antigravity-cli/aca/SKILL.md +3 -2
- package/zh-CN/dist/antigravity-cli/aca-design/SKILL.md +1 -1
- package/zh-CN/dist/antigravity-cli/aca-implement/SKILL.md +89 -108
- package/zh-CN/dist/antigravity-cli/aca-release/SKILL.md +62 -52
- package/zh-CN/dist/antigravity-cli/aca-repo-audit/SKILL.md +37 -29
- package/zh-CN/dist/antigravity-cli/aca-review/SKILL.md +112 -113
- package/zh-CN/dist/antigravity-cli/aca-test/SKILL.md +110 -0
- package/zh-CN/dist/antigravity-cli/aca-walkthrough/SKILL.md +1 -1
- package/zh-CN/dist/codex/aca/SKILL.md +3 -2
- package/zh-CN/dist/codex/aca-design/SKILL.md +1 -1
- package/zh-CN/dist/codex/aca-implement/SKILL.md +89 -108
- package/zh-CN/dist/codex/aca-release/SKILL.md +62 -52
- package/zh-CN/dist/codex/aca-repo-audit/SKILL.md +37 -29
- package/zh-CN/dist/codex/aca-review/SKILL.md +112 -113
- package/zh-CN/dist/codex/aca-test/SKILL.md +110 -0
- package/zh-CN/dist/codex/aca-walkthrough/SKILL.md +1 -1
- package/zh-CN/dist/cursor/aca/SKILL.md +3 -2
- package/zh-CN/dist/cursor/aca-design/SKILL.md +1 -1
- package/zh-CN/dist/cursor/aca-implement/SKILL.md +89 -108
- package/zh-CN/dist/cursor/aca-release/SKILL.md +62 -52
- package/zh-CN/dist/cursor/aca-repo-audit/SKILL.md +37 -29
- package/zh-CN/dist/cursor/aca-review/SKILL.md +112 -113
- package/zh-CN/dist/cursor/aca-test/SKILL.md +111 -0
- package/zh-CN/dist/cursor/aca-walkthrough/SKILL.md +1 -1
- package/zh-CN/dist/grok/aca/SKILL.md +3 -2
- package/zh-CN/dist/grok/aca-design/SKILL.md +1 -1
- package/zh-CN/dist/grok/aca-implement/SKILL.md +89 -108
- package/zh-CN/dist/grok/aca-release/SKILL.md +62 -52
- package/zh-CN/dist/grok/aca-repo-audit/SKILL.md +37 -29
- package/zh-CN/dist/grok/aca-review/SKILL.md +112 -113
- package/zh-CN/dist/grok/aca-test/SKILL.md +110 -0
- package/zh-CN/dist/grok/aca-walkthrough/SKILL.md +1 -1
- package/zh-CN/doc-design/document-sets/module.md +6 -2
- package/zh-CN/doc-design/documents/class-design.md +7 -4
- package/zh-CN/doc-design/documents/integration-guide.md +7 -5
- package/zh-CN/doc-design/documents/release.md +5 -3
- package/zh-CN/meta-skills/aca/SKILL.md +3 -2
- package/zh-CN/meta-skills/aca/SKILL.md.tmpl +3 -2
- package/zh-CN/skills/aca-design/SKILL.md +1 -1
- package/zh-CN/skills/aca-implement/SKILL.md +89 -108
- package/zh-CN/skills/aca-implement/SKILL.md.tmpl +89 -108
- package/zh-CN/skills/aca-release/SKILL.md +62 -52
- package/zh-CN/skills/aca-release/SKILL.md.tmpl +62 -52
- package/zh-CN/skills/aca-repo-audit/SKILL.md +37 -29
- package/zh-CN/skills/aca-repo-audit/SKILL.md.tmpl +36 -28
- package/zh-CN/skills/aca-review/SKILL.md +112 -113
- package/zh-CN/skills/aca-review/SKILL.md.tmpl +111 -112
- package/zh-CN/skills/aca-test/SKILL.md +110 -0
- package/zh-CN/skills/aca-test/SKILL.md.tmpl +108 -0
- package/zh-CN/skills/aca-walkthrough/SKILL.md +1 -1
|
@@ -8,7 +8,7 @@ description: Review the design docs or code implementation in the current scope,
|
|
|
8
8
|
# aca-review
|
|
9
9
|
|
|
10
10
|
Review the design docs or code implementation in the current scope and determine pass, needs changes, or incomplete
|
|
11
|
-
Do not modify design docs, project source code, or test code
|
|
11
|
+
Do not modify design docs, project source code, or test code, and do not run the code or tests under review
|
|
12
12
|
Use `/aca-repo-audit` for the repository-wide audit before release
|
|
13
13
|
|
|
14
14
|
## 1 Principles
|
|
@@ -17,11 +17,11 @@ Use `/aca-repo-audit` for the repository-wide audit before release
|
|
|
17
17
|
|
|
18
18
|
1. **Source-driven review**
|
|
19
19
|
Review the design against confirmed requirements and applicable rules
|
|
20
|
-
Review the implementation against the confirmed design
|
|
20
|
+
Review the code and test implementation against the confirmed design
|
|
21
21
|
2. **Independent judgment**
|
|
22
22
|
Form conclusions independently for each review task
|
|
23
23
|
3. **Evidence-based verdict**
|
|
24
|
-
Determine issues and review conclusions from item-by-item verification results and
|
|
24
|
+
Determine issues and review conclusions from item-by-item verification results and facts in code and docs
|
|
25
25
|
4. **Scope constraints**
|
|
26
26
|
Limit review conclusions to the current scope
|
|
27
27
|
|
|
@@ -36,7 +36,7 @@ The writing axiom applies to reviews of design doc prose and the wording of revi
|
|
|
36
36
|
- Present the whole first, then expand on the details, see the [Pyramid Principle](~/.gemini/config/skills/aca/SSOT.md#2-structure)
|
|
37
37
|
- When stating a judgment, give the conclusion first, then the supporting evidence
|
|
38
38
|
- Merge heading levels that add no information
|
|
39
|
-
- Use numbered lists for items with a sequence or priority, and indent
|
|
39
|
+
- Use numbered lists for items with a sequence or priority; when a step contains sub-items, start the step with a bold phrase stating its purpose and indent specific operations and conditional branches under it
|
|
40
40
|
- Use tables only for content with multiple rows of the same structure, more than two attributes per row, and no sequence between rows
|
|
41
41
|
- Write list items as complete sentences
|
|
42
42
|
- When an item has branches, indent the branches under that item
|
|
@@ -80,7 +80,7 @@ Reference: [ASD-STE100](~/.gemini/config/skills/aca/SSOT.md#1-writing-rules)
|
|
|
80
80
|
```mermaid
|
|
81
81
|
flowchart TD
|
|
82
82
|
Start([Receive review request]) --> Scope["Confirm review scope and execution models · §3"]
|
|
83
|
-
Scope --> Check["Determine review type and
|
|
83
|
+
Scope --> Check["Determine review type and prepare sources · §4"]
|
|
84
84
|
Check --> Audit["Orchestrate and run independent reviews for the selected review type · §5"]
|
|
85
85
|
Audit --> Verify["Recheck and summarize · §6"]
|
|
86
86
|
Verify --> Issues{"Confirmed must-fix items exist · §7"}
|
|
@@ -94,81 +94,78 @@ flowchart TD
|
|
|
94
94
|
|
|
95
95
|
### 3.1 Subject, Scope, and Prerequisites
|
|
96
96
|
|
|
97
|
-
1.
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
101
|
-
|
|
102
|
-
|
|
103
|
-
|
|
104
|
-
|
|
105
|
-
|
|
106
|
-
|
|
107
|
-
|
|
108
|
-
|
|
109
|
-
|
|
110
|
-
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
Read
|
|
115
|
-
Read the design docs for the current scope and follow references to read any additional docs needed for understanding and verification
|
|
97
|
+
1. **Confirm the review subject and scope**
|
|
98
|
+
- Developer has specified the review subject and scope: follow that specification first
|
|
99
|
+
- Developer has not specified them: use the review subject and scope already specified by the caller
|
|
100
|
+
- Subject or scope is still unclear: determine it from current workspace changes and recent relevant commits, reading the descriptions and diffs of recent relevant commits
|
|
101
|
+
- Review subject or scope still cannot be determined: ask the developer to specify it
|
|
102
|
+
2. **Record the comparison baseline**
|
|
103
|
+
- Record the review subject, scope, and comparison baseline
|
|
104
|
+
- Specify the commits under review and any uncommitted changes included in the review
|
|
105
|
+
3. **Check the repo type**
|
|
106
|
+
- Run `bash ~/.gemini/config/skills/aca/bin/aca-repo-type-check` to check the repo type
|
|
107
|
+
- Repo type is missing or invalid: mark the repo-type spec check as incomplete and recommend running `/aca-init`
|
|
108
|
+
- Repo type is not yet supported: mark the repo-type spec check as incomplete and note that the corresponding rules are missing
|
|
109
|
+
4. **Locate and read general review sources**
|
|
110
|
+
- When the input does not include the design doc location, locate it from the documentation entry in the root README, or ask the developer for its location if it cannot be located and mark checks that depend on this content as incomplete until the location is clear
|
|
111
|
+
- Read the confirmed problems, goals, and change scope for this review
|
|
112
|
+
- If the repo type is valid and supported, read the corresponding Repo Type rules
|
|
113
|
+
- Read `CONTEXT.md` and check the business concepts and definitions involved in this review
|
|
114
|
+
- Read the design docs for the current scope and follow references to read any additional docs needed for understanding and verification
|
|
116
115
|
|
|
117
116
|
### 3.2 Agent and Model Selection
|
|
118
117
|
|
|
119
|
-
1. Scan
|
|
120
|
-
|
|
121
|
-
|
|
122
|
-
|
|
123
|
-
|
|
124
|
-
2. Propose execution combinations
|
|
125
|
-
Prefer callable flagship models and assess flagship status using information that can currently be verified
|
|
126
|
-
Prefer combinations whose Agent environment and model both differ from those of the main agent
|
|
127
|
-
|
|
128
|
-
|
|
129
|
-
|
|
130
|
-
Explain the recommendation and available alternative combinations, and ask the developer to confirm
|
|
131
|
-
|
|
132
|
-
|
|
133
|
-
|
|
134
|
-
If the selected combination cannot be invoked, use a confirmed alternative
|
|
135
|
-
|
|
136
|
-
Record the actual selection, fallback, and reasons in the report
|
|
118
|
+
1. **Scan available Agent environments and models**
|
|
119
|
+
- Scan the current AI Agent environment and other AI Agent environments already available on this machine
|
|
120
|
+
- Record the Agent tool types and actual model identifiers in each environment and compare them with the main agent
|
|
121
|
+
- Use existing tool entry points, configuration, and model lists to verify invocation methods and availability
|
|
122
|
+
- Installation or configuration alone does not prove that an environment can be invoked, and information that cannot be verified is marked as unknown
|
|
123
|
+
2. **Propose execution combinations**
|
|
124
|
+
- Prefer callable flagship models and assess flagship status using information that can currently be verified
|
|
125
|
+
- Prefer combinations whose Agent environment and model both differ from those of the main agent, without prescribing a brand, model, or order of attempts
|
|
126
|
+
- If no other suitable and callable candidate is available, propose using the current model
|
|
127
|
+
3. **Confirm execution combinations**
|
|
128
|
+
- Show each candidate's Agent, model, availability, invocation method, and differences from the main agent
|
|
129
|
+
- Explain the recommendation and available alternative combinations, and ask the developer to confirm before running the review
|
|
130
|
+
- Reuse the existing confirmation if the confirmed selection and availability conditions have not changed
|
|
131
|
+
4. **Handle execution fallback**
|
|
132
|
+
- Use the confirmed execution combinations for [Model and Task Orchestration](#53-model-and-task-orchestration)
|
|
133
|
+
- If the selected combination cannot be invoked, use a confirmed alternative, or report the change and ask the developer to confirm a new combination if no alternative has been confirmed
|
|
134
|
+
- Record the actual selection, fallback, and reasons in the report
|
|
137
135
|
|
|
138
136
|
## 4 Read Source Material and Run Checks
|
|
139
137
|
|
|
140
138
|
```mermaid
|
|
141
139
|
flowchart TD
|
|
142
|
-
Kind["Determine review type · §4.1"] -- Design review --> Design["Design review · §4.2"]
|
|
143
|
-
Kind -- Implementation review --> Implementation["Implementation review · §4.3"]
|
|
140
|
+
Kind["Determine review type · §4.1"] -- Design review --> Design["Design review preparation and mechanical checks · §4.2"]
|
|
141
|
+
Kind -- Implementation review --> Implementation["Implementation review source preparation · §4.3"]
|
|
144
142
|
Design --> Results["Handle check results · §4.4"]
|
|
145
|
-
Implementation -->
|
|
143
|
+
Implementation --> Next(["Proceed to independent review orchestration · §5"])
|
|
144
|
+
Results --> Next
|
|
146
145
|
```
|
|
147
146
|
|
|
148
147
|
### 4.1 Determine Review Type
|
|
149
148
|
|
|
150
|
-
1.
|
|
151
|
-
|
|
152
|
-
|
|
153
|
-
-
|
|
154
|
-
-
|
|
155
|
-
- Both design and implementation: run both review types separately
|
|
156
|
-
3. If the review type is still unclear, ask the developer to specify it
|
|
149
|
+
1. **Determine the review type for this run**
|
|
150
|
+
- Developer has specified the review type: follow that specification first
|
|
151
|
+
- Developer has not specified it: use the review type already specified by the caller
|
|
152
|
+
- Review type is not specified: determine it from the subject under review and the actual changes (run a design review for design docs, run an implementation review for code, tests, or runtime configuration, and run both review types separately when both are involved)
|
|
153
|
+
- Review type still cannot be determined: ask the developer to specify it
|
|
157
154
|
|
|
158
|
-
Run both
|
|
155
|
+
Run both branches when both review types are selected
|
|
159
156
|
|
|
160
157
|
### 4.2 Design Review
|
|
161
158
|
|
|
162
|
-
1.
|
|
163
|
-
|
|
164
|
-
|
|
165
|
-
|
|
166
|
-
|
|
167
|
-
|
|
168
|
-
|
|
169
|
-
|
|
170
|
-
|
|
171
|
-
If the reuse conditions are not met, replace the placeholder paths in the following commands with the actual paths determined in step 2 and run them
|
|
159
|
+
1. **Extract applicable checklist items**
|
|
160
|
+
- Read the document set, Doc Design, and Patterns actually used for the current scope
|
|
161
|
+
- Extract their applicable checklist items as the basis for item-by-item verification
|
|
162
|
+
2. **Determine target paths for mechanical checks**
|
|
163
|
+
- Prose checks cover all docs under review, including project-level records within the review scope
|
|
164
|
+
- For the doc graph check, select a doc tree that includes the docs under review and has a README entry
|
|
165
|
+
- Mechanical checks for Context verify structure and formatting, while content is verified against the corresponding Doc Design checklist
|
|
166
|
+
3. **Run or reuse mechanical checks**
|
|
167
|
+
- Existing mechanical check results from this session can be reused if they cover the same scope and the relevant files, check rules, and tools have not changed, stating the original results and reuse conditions in the report
|
|
168
|
+
- If the reuse conditions are not met, replace the placeholder paths in the following commands with the actual paths determined in step 2 and run them
|
|
172
169
|
|
|
173
170
|
```bash
|
|
174
171
|
bash ~/.gemini/config/skills/aca/bin/aca-doc-graph-check <doc directory>
|
|
@@ -178,22 +175,19 @@ Run both check branches when both review types are selected
|
|
|
178
175
|
|
|
179
176
|
### 4.3 Implementation Review
|
|
180
177
|
|
|
181
|
-
1. Read
|
|
182
|
-
|
|
183
|
-
|
|
184
|
-
Read the
|
|
185
|
-
|
|
186
|
-
|
|
187
|
-
|
|
188
|
-
|
|
189
|
-
|
|
190
|
-
Run the corresponding checks if verification evidence is insufficient or reuse conditions are not met
|
|
191
|
-
Use an isolated verification environment as specified by the test design
|
|
192
|
-
Do not modify commit history during verification
|
|
178
|
+
1. **Read design and implementation conventions**
|
|
179
|
+
- Read the confirmed design, test design, and repository implementation conventions for the current scope
|
|
180
|
+
2. **Read code and tests under review**
|
|
181
|
+
- Read the current diff and changed files against the established comparison baseline
|
|
182
|
+
- Read affected callers and dependency code
|
|
183
|
+
- Read the functions, classes, test files, and related call chains containing the changes to understand their execution context
|
|
184
|
+
3. **Map design to implementation**
|
|
185
|
+
- Map the production code implementation and test code implementation to the design conventions and test scenarios respectively for item-by-item static review in Chapter 5
|
|
186
|
+
- Implementation review does not run code, tests, or builds directly, and runtime verification is executed by `/aca-test` after the review passes
|
|
193
187
|
|
|
194
188
|
### 4.4 Handle Check Results
|
|
195
189
|
|
|
196
|
-
Handle
|
|
190
|
+
Handle mechanical checks for design reviews as specified in this section
|
|
197
191
|
|
|
198
192
|
| Check status | Action |
|
|
199
193
|
| --- | --- |
|
|
@@ -225,62 +219,67 @@ Handle tool checks for both review types as specified in this section
|
|
|
225
219
|
|
|
226
220
|
### 5.2 Implementation Review Dimensions
|
|
227
221
|
|
|
228
|
-
|
|
222
|
+
Statically check the following items individually against the confirmed design docs
|
|
229
223
|
|
|
230
224
|
1. **Structural setup**
|
|
231
225
|
Check whether the division of modules and files, responsibility assignments, interface definitions, and dependencies conform to the design
|
|
232
226
|
2. **Detailed logic implementation**
|
|
233
227
|
Check whether inputs, outputs, and processing flows conform to the design
|
|
234
228
|
Check whether data and state changes, error handling, and boundary behavior conform to the design
|
|
235
|
-
Check whether fixtures, scenarios, and
|
|
229
|
+
Check whether fixtures, scenarios, and assertions in black-box and white-box test code completely cover the corresponding test design
|
|
236
230
|
Check whether test assertions can detect deviations between actual behavior and expected results
|
|
237
231
|
3. **Overall structural implementation**
|
|
238
232
|
Check whether module assembly, call chains, and collaboration methods conform to the overall architecture design
|
|
239
|
-
Check whether
|
|
233
|
+
Check whether cross-module wiring conforms to the flows and contract boundaries in the design
|
|
240
234
|
|
|
241
235
|
### 5.3 Model and Task Orchestration
|
|
242
236
|
|
|
243
|
-
1. Create independent review tasks
|
|
244
|
-
For design reviews, assign an independent sub-agent to each perspective
|
|
245
|
-
For implementation reviews, assign independent sub-agents to structural setup, detailed logic implementation, and overall structural implementation
|
|
246
|
-
Each sub-agent forms conclusions independently without reading other sub-agents' review results beforehand
|
|
247
|
-
2. Arrange execution
|
|
248
|
-
|
|
249
|
-
|
|
237
|
+
1. **Create independent review tasks**
|
|
238
|
+
- For design reviews, assign an independent sub-agent to each perspective
|
|
239
|
+
- For implementation reviews, assign independent sub-agents to structural setup, detailed logic implementation, and overall structural implementation
|
|
240
|
+
- Each sub-agent forms conclusions independently without reading other sub-agents' review results beforehand
|
|
241
|
+
2. **Arrange execution models**
|
|
242
|
+
- Arrange execution using the combinations confirmed in [Agent and Model Selection](#32-agent-and-model-selection)
|
|
243
|
+
- Keep review tasks independent even when using the current model
|
|
244
|
+
3. **Provide task context**
|
|
250
245
|
- Assigned review items and applicable checklist items
|
|
251
246
|
- Review subject, scope, and comparison baseline, including commits under review and uncommitted changes included in the review
|
|
252
247
|
- Locations of the content under review and the corresponding design source material
|
|
253
|
-
- Existing check results and evidence from
|
|
254
|
-
- The diff, changed files, affected callers and dependency code, and repository implementation conventions needed for the implementation review
|
|
248
|
+
- Existing mechanical check results and evidence from Chapter 4
|
|
249
|
+
- The diff, changed files, test files, affected callers and dependency code, and repository implementation conventions needed for the implementation review
|
|
255
250
|
|
|
256
251
|
### 5.4 Run the Review
|
|
257
252
|
|
|
258
|
-
1.
|
|
259
|
-
|
|
260
|
-
|
|
261
|
-
|
|
262
|
-
|
|
253
|
+
1. **Verify checklist items individually**
|
|
254
|
+
- Each sub-agent verifies its assigned checklist items individually
|
|
255
|
+
- If a checklist item does not apply to the current scope, record it as not applicable and state the basis
|
|
256
|
+
2. **Record verification results and issues**
|
|
257
|
+
- For each check, record the verification result, corresponding file location, and basis for judgment
|
|
258
|
+
- For each issue, record the location, problem, impact, and recommended changes using the issue format in [Review Report](#81-review-report)
|
|
259
|
+
3. **Return summary to the main agent**
|
|
260
|
+
- Return the complete check records, issue list, and incomplete items to the main agent
|
|
263
261
|
|
|
264
262
|
## 6 Recheck and Summarize
|
|
265
263
|
|
|
266
|
-
1.
|
|
267
|
-
|
|
268
|
-
2.
|
|
269
|
-
|
|
270
|
-
|
|
271
|
-
The main agent can add issues it finds independently after applying the same evidence verification
|
|
272
|
-
Merge duplicate issues while retaining their locations, evidence, and impact
|
|
273
|
-
3.
|
|
274
|
-
|
|
275
|
-
|
|
276
|
-
Mark review items or checks that still cannot be completed as incomplete and state the reasons
|
|
277
|
-
4.
|
|
264
|
+
1. **Read sub-agent check records**
|
|
265
|
+
- The main agent reads each sub-agent's check records and checks whether the check evidence corresponds to the current content under review
|
|
266
|
+
2. **Recheck and merge issues**
|
|
267
|
+
- Check the files and evidence for each issue and include it in the report only after confirming it
|
|
268
|
+
- Exclude disproven issues and mark issues with insufficient evidence as incomplete verification
|
|
269
|
+
- The main agent can add issues it finds independently after applying the same evidence verification
|
|
270
|
+
- Merge duplicate issues while retaining their locations, evidence, and impact
|
|
271
|
+
3. **Check review coverage**
|
|
272
|
+
- Summarize the check records for all review items and check each checklist item's applicability and verification result
|
|
273
|
+
- If a sub-agent did not cover its assigned scope, omitted checks, or lacked verification evidence, assign the corresponding supplementary checks and recheck the results
|
|
274
|
+
- Mark review items or checks that still cannot be completed as incomplete and state the reasons
|
|
275
|
+
4. **Form the basis for the verdict**
|
|
276
|
+
- Summarize confirmed issues and check completion status as the basis for the verdict
|
|
278
277
|
|
|
279
278
|
## 7 Verdict
|
|
280
279
|
|
|
281
280
|
| Verdict | Criteria |
|
|
282
281
|
| --- | --- |
|
|
283
|
-
| Pass | All selected review tasks are complete, all applicable checklist items have passed verification, all applicable
|
|
282
|
+
| Pass | All selected review tasks are complete, all applicable checklist items have passed verification, all applicable mechanical checks have passed, and there are no must-fix items |
|
|
284
283
|
| Needs changes | Confirmed must-fix items exist |
|
|
285
284
|
| Incomplete | Pass criteria are not met and there are no confirmed must-fix items |
|
|
286
285
|
|
|
@@ -304,7 +303,7 @@ Output the review results in the current conversation using the following templa
|
|
|
304
303
|
| Baseline | <comparison baseline, commits under review, and uncommitted changes> |
|
|
305
304
|
| Verdict basis | <how pass criteria are met, or issues and incomplete checks preventing a pass> |
|
|
306
305
|
| Must fix | <issue count and main impact / none> |
|
|
307
|
-
| Tool checks | <pass, failure, and incomplete status of
|
|
306
|
+
| Tool checks | <pass, failure, and incomplete status of design review mechanical checks / not applicable for implementation review> |
|
|
308
307
|
| Incomplete | <incomplete review tasks and checks within the current scope, and reasons / none> |
|
|
309
308
|
| Next step | <one immediately actionable step> |
|
|
310
309
|
|
|
@@ -323,7 +322,7 @@ Output the review results in the current conversation using the following templa
|
|
|
323
322
|
|
|
324
323
|
- Read: <files actually read in this review>
|
|
325
324
|
- Checklist: <criteria and sources, item-by-item verification results, basis for non-applicability, and reasons for incomplete checks>
|
|
326
|
-
- Tools: <commands actually run and their results, or original results reused and basis for reuse>
|
|
325
|
+
- Tools: <mechanical check commands actually run and their results, or original results reused and basis for reuse / not applicable for implementation review>
|
|
327
326
|
|
|
328
327
|
| Review item | Agent environment | Model | Completion status | Notes |
|
|
329
328
|
| --- | --- | --- | --- | --- |
|
|
@@ -339,12 +338,12 @@ Select the next step based on the review verdict and progress in the current rou
|
|
|
339
338
|
|
|
340
339
|
| Verdict | Situation | Next step |
|
|
341
340
|
| --- | --- | --- |
|
|
342
|
-
| Incomplete | Inputs
|
|
343
|
-
| Needs changes |
|
|
344
|
-
| Needs changes | The
|
|
345
|
-
| Needs changes |
|
|
346
|
-
| Pass |
|
|
347
|
-
| Pass |
|
|
348
|
-
| Pass |
|
|
341
|
+
| Incomplete | Inputs or verification conditions are missing | Report the conditions for resuming and continue this review through `/aca-review` once they are met |
|
|
342
|
+
| Needs changes | The design solution still needs reasoning or decisions | `/aca-specify` Extend or revise the solution |
|
|
343
|
+
| Needs changes | The solution is clear and only design docs need revision | `/aca-design` Revise the docs |
|
|
344
|
+
| Needs changes | Code or test implementation issues | `/aca-implement` Fix the implementation |
|
|
345
|
+
| Pass | Design review passed and code implementation is needed in this round | `/aca-implement` |
|
|
346
|
+
| Pass | Design review passed and only design docs are changed in this round | Proceed to `/aca-release` according to the confirmed version progression plan |
|
|
347
|
+
| Pass | Implementation review passed | `/aca-test` Run test verification for the current scope |
|
|
349
348
|
|
|
350
349
|
After design or implementation corrections, review the affected scope again through `/aca-review`
|
|
@@ -0,0 +1,110 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: aca-test
|
|
3
|
+
description: Select and run minimal tests based on the current implementation or change blast radius, testing only without modifying files
|
|
4
|
+
---
|
|
5
|
+
<!-- AUTO-GENERATED from SKILL.md.tmpl — do not edit directly -->
|
|
6
|
+
<!-- Regenerate: bash scripts/build-skills.sh --host antigravity -->
|
|
7
|
+
|
|
8
|
+
# aca-test
|
|
9
|
+
|
|
10
|
+
Select and run the corresponding minimal tests based on the current implementation scope or the design boundary crossed by changes
|
|
11
|
+
Run tests and verification only, without modifying design docs, production code, or test code
|
|
12
|
+
|
|
13
|
+
## 1 Principles
|
|
14
|
+
|
|
15
|
+
1. **Blast-Radius Scoping**
|
|
16
|
+
Determine the minimal test scope from the contract boundaries and dependencies of the current implementation or changes
|
|
17
|
+
2. **Test Only, No Edits**
|
|
18
|
+
Run tests and verify results only, without modifying design docs, production code, or test code
|
|
19
|
+
3. **Evidence Binding**
|
|
20
|
+
Bind test results to the commit under test, test scope, and commands actually executed for direct reuse by downstream stages
|
|
21
|
+
|
|
22
|
+
## 2 Workflow
|
|
23
|
+
|
|
24
|
+
```mermaid
|
|
25
|
+
flowchart TD
|
|
26
|
+
Start([Receive test request]) --> Scope["Determine test scope · §3"]
|
|
27
|
+
Scope --> Reuse{"Result reuse conditions met? · §3"}
|
|
28
|
+
Reuse -- Yes --> Report(["Output and next step · §5"])
|
|
29
|
+
Reuse -- No --> Ready{"Test environment and prerequisites ready? · §3"}
|
|
30
|
+
Ready -- No --> Report
|
|
31
|
+
Ready -- Yes --> Run["Run tests and recheck anomalies · §4"]
|
|
32
|
+
Run --> Report
|
|
33
|
+
```
|
|
34
|
+
|
|
35
|
+
## 3 Determine Test Scope
|
|
36
|
+
|
|
37
|
+
1. **Identify the subject under test and scope of changes**
|
|
38
|
+
- Developer or upstream caller has specified the scope to test: use that scope directly
|
|
39
|
+
- Scope not specified: read current workspace changes and recent commits, and locate the modules, commands, or events to which the changes belong against the design docs
|
|
40
|
+
- Record the commit under test and any uncommitted changes included in verification
|
|
41
|
+
2. **Select the minimal test set by the design boundary crossed by changes**
|
|
42
|
+
- Only internal implementation of a module, command, or event is added or modified, and the module `interface`, command routing, and event dispatch contracts are unchanged: select only the unit's own white-box and black-box tests
|
|
43
|
+
- Module `interface`, command routing, event dispatch, or cross-unit collaboration is modified: select this unit's tests, tests of modules or commands and events that call this contract, and black-box tests in project-level `testcase` whose design basis links to this unit
|
|
44
|
+
- Shared foundation across modules such as common infrastructure, global configuration, data migration, build, or deployment is modified: select all affected tests and the corresponding environment verification
|
|
45
|
+
- When the repository `release` doc specifies additional verification for the current scope, include it as well
|
|
46
|
+
3. **Check reuse conditions and execution environment**
|
|
47
|
+
- Existing test results cover the selected scope and the content under test, test code, fixtures, configuration, and dependency environment have not changed: reuse the results directly, record the basis, and proceed to [Output and Next Step](#5-output-and-next-step)
|
|
48
|
+
- Test execution required: check the readiness of the required environment, fixtures, and real dependencies or test doubles according to the test design
|
|
49
|
+
- Environment or dependencies not ready: record the missing conditions and report incomplete according to [Output and Next Step](#5-output-and-next-step)
|
|
50
|
+
|
|
51
|
+
## 4 Run and Recheck
|
|
52
|
+
|
|
53
|
+
1. **Control concurrency and resource isolation**
|
|
54
|
+
- Set up fixtures and an isolated environment according to the test design
|
|
55
|
+
- When shared or heavy resources such as containers, databases, real platforms, or model evaluations are involved, limit concurrency and isolate resources to prevent timeouts caused by parallel contention
|
|
56
|
+
2. **Run the selected tests**
|
|
57
|
+
- Run the test cases selected in [Determine Test Scope](#3-determine-test-scope) along with required builds or static checks
|
|
58
|
+
- After execution completes, clean up test data and temporary resources created in this run according to the fixture rules
|
|
59
|
+
- Do not modify design docs, production code, test code, or commit history during verification
|
|
60
|
+
3. **Recheck failures and distinguish causes**
|
|
61
|
+
- All pass: record the executed commands, number of passing test cases, and elapsed time
|
|
62
|
+
- Failures occur: check the failure logs and diagnostics
|
|
63
|
+
- Suspected timeout caused by high host load or resource contention: rerun the failed items individually under low-concurrency isolated conditions to verify
|
|
64
|
+
- Individual rerun passes consistently and is confirmed to be caused by environment load: record the initial anomaly, rerun command, and passing result
|
|
65
|
+
- Failure confirmed to be caused by code or test implementation issues: record the failing test cases, error diagnostics, and corresponding locations
|
|
66
|
+
- Environment failure or diagnostics cannot be verified: mark the corresponding verification as incomplete and record the reason
|
|
67
|
+
|
|
68
|
+
## 5 Output and Next Step
|
|
69
|
+
|
|
70
|
+
### 5.1 Verdict
|
|
71
|
+
|
|
72
|
+
| Verdict | Criteria |
|
|
73
|
+
| --- | --- |
|
|
74
|
+
| Pass | All tests and required checks in the selected scope pass (including reused results or timeout rechecks), with no failing or incomplete items |
|
|
75
|
+
| Fail | Confirmed code or test failures exist |
|
|
76
|
+
| Incomplete | Environment is missing, execution is impossible, or diagnostics cannot be verified, and no confirmed failures exist |
|
|
77
|
+
|
|
78
|
+
When both confirmed failures and incomplete items exist, the verdict is fail, and the incomplete items must be listed
|
|
79
|
+
|
|
80
|
+
### 5.2 Test Report
|
|
81
|
+
|
|
82
|
+
Output the test results in the current conversation using the following template
|
|
83
|
+
|
|
84
|
+
```markdown
|
|
85
|
+
# 🧪 Test: <pass / fail / incomplete>
|
|
86
|
+
|
|
87
|
+
| Item | Result |
|
|
88
|
+
| --- | --- |
|
|
89
|
+
| Scope | <unit or change scope under test> |
|
|
90
|
+
| Baseline | <commit under test and uncommitted changes included in verification> |
|
|
91
|
+
| Selection basis | <upstream scope / intra-unit tests with unchanged contract / dependency-chain tests for contract change / full tests for global foundation> |
|
|
92
|
+
| Commands | <actual test and check commands run, or basis for reuse> |
|
|
93
|
+
| Result | <pass count, fail count, and elapsed time> |
|
|
94
|
+
| Anomaly recheck | <individual rerun verification result for timeouts / none> |
|
|
95
|
+
| Failures | <failing test cases, causes, and corresponding locations / none> |
|
|
96
|
+
| Incomplete | <unexecuted verification, reasons, and conditions for resuming / none> |
|
|
97
|
+
| Next step | <one immediately actionable step> |
|
|
98
|
+
```
|
|
99
|
+
|
|
100
|
+
### 5.3 Follow-Up Actions
|
|
101
|
+
|
|
102
|
+
Select the next step based on the test verdict and progress in the current round
|
|
103
|
+
|
|
104
|
+
| Verdict | Situation | Next step |
|
|
105
|
+
| --- | --- | --- |
|
|
106
|
+
| Incomplete | Test environment, fixtures, or external dependencies are missing | Supply the environment conditions and verify again through `/aca-test` |
|
|
107
|
+
| Fail | Code or test implementation issues | Fix through `/aca-implement`, review through `/aca-review`, then run `/aca-test` |
|
|
108
|
+
| Fail | Missing design or contract conflict | Revise the design through `/aca-specify` or `/aca-design` |
|
|
109
|
+
| Pass | Subsequent implementation tasks remain in this round | Continue implementing the next scope through `/aca-implement` |
|
|
110
|
+
| Pass | All implementation scopes in this round have passed verification | Proceed to `/aca-release` according to the version progression plan or conclude the current task |
|
|
@@ -33,7 +33,7 @@ Confirm design decisions unit by unit and correct identified issues on the spot
|
|
|
33
33
|
- Present the whole first, then expand on the details, see the [Pyramid Principle](~/.gemini/config/skills/aca/SSOT.md#2-structure)
|
|
34
34
|
- When stating a judgment, give the conclusion first, then the supporting evidence
|
|
35
35
|
- Merge heading levels that add no information
|
|
36
|
-
- Use numbered lists for items with a sequence or priority, and indent
|
|
36
|
+
- Use numbered lists for items with a sequence or priority; when a step contains sub-items, start the step with a bold phrase stating its purpose and indent specific operations and conditional branches under it
|
|
37
37
|
- Use tables only for content with multiple rows of the same structure, more than two attributes per row, and no sequence between rows
|
|
38
38
|
- Write list items as complete sentences
|
|
39
39
|
- When an item has branches, indent the branches under that item
|
|
@@ -43,8 +43,9 @@ flowchart TD
|
|
|
43
43
|
| `/aca-specify` | Reason through new requirements or improve existing designs, then proceed to Design after confirming the solution |
|
|
44
44
|
| `/aca-design` | Write and check design docs within the current scope, then determine the next scope or complete the overall closeout |
|
|
45
45
|
| `/aca-walkthrough` | Walk through design docs in business language, confirm design decisions unit by unit, and correct identified issues on the spot after confirmation |
|
|
46
|
-
| `/aca-review` | Determine the review subject and scope, review the design or
|
|
47
|
-
| `/aca-implement` | Plan the file structure based on the design, then
|
|
46
|
+
| `/aca-review` | Determine the review subject and scope, statically review the design or code and test implementation, without modifying the docs or code under review or running code |
|
|
47
|
+
| `/aca-implement` | Plan the file structure based on the design, then write production code and test code according to module dependencies |
|
|
48
|
+
| `/aca-test` | Select and run minimal tests based on the current implementation scope or the design boundary crossed by changes, testing only without modifying files |
|
|
48
49
|
| `/aca-repo-audit` | Check repository documentation and verify the implementation as needed, with read-only access and no changes |
|
|
49
50
|
| `/aca-release` | Close out according to the repository release workflow, merge into main, and lock in an annotated Tag |
|
|
50
51
|
| `/aca-feedback` | Collect deviations from governance rules and submit an Issue after explicit authorization |
|
|
@@ -22,7 +22,7 @@ Change only documentation, not code
|
|
|
22
22
|
- Present the whole first, then expand on the details, see the [Pyramid Principle](~/.gemini/antigravity-cli/skills/aca/SSOT.md#2-structure)
|
|
23
23
|
- When stating a judgment, give the conclusion first, then the supporting evidence
|
|
24
24
|
- Merge heading levels that add no information
|
|
25
|
-
- Use numbered lists for items with a sequence or priority, and indent
|
|
25
|
+
- Use numbered lists for items with a sequence or priority; when a step contains sub-items, start the step with a bold phrase stating its purpose and indent specific operations and conditional branches under it
|
|
26
26
|
- Use tables only for content with multiple rows of the same structure, more than two attributes per row, and no sequence between rows
|
|
27
27
|
- Write list items as complete sentences
|
|
28
28
|
- When an item has branches, indent the branches under that item
|