amqplib 0.5.2 → 0.5.3

package/test/channel.js

@@ -30,10 +30,10 @@ function baseChannelTest(client, server) {
     });
 
     pair.server.read(8); // discard the protocol header
-    var s = util.runServer(pair.server, function(send, await) {
-      conn_handshake(send, await)
+    var s = util.runServer(pair.server, function(send, wait) {
+      conn_handshake(send, wait)
         .then(function() {
-          server(send, await, bothDone);
+          server(send, wait, bothDone);
         }, fail(bothDone));
     });
   };
@@ -46,18 +46,18 @@ function channelTest(client, server) {
       if (LOG_ERRORS) ch.on('error', console.warn);
       client(ch, done, conn);
     },
-    function(send, await, done) {
-      channel_handshake(send, await)
+    function(send, wait, done) {
+      channel_handshake(send, wait)
       .then(function(ch) {
-        return server(send, await, done, ch);
+        return server(send, wait, done, ch);
       }).then(null, fail(done)); // so you can return a promise to let
                                  // errors bubble out
     }
   );
 };
 
-function channel_handshake(send, await) {
-  return await(defs.ChannelOpen)()
+function channel_handshake(send, wait) {
+  return wait(defs.ChannelOpen)()
     .then(function(open) {
       assert.notEqual(0, open.channel);
       send(defs.ChannelOpenOk, {channelId: Buffer.from('')}, open.channel);
@@ -91,7 +91,7 @@ test("open", channelTest(
   function(ch, done) {
     open(ch).then(succeed(done), fail(done));
   },
-  function(send, await, done) {
+  function(send, wait, done) {
     done();
   }));
 
@@ -100,8 +100,8 @@ test("bad server", baseChannelTest(
     var ch = new Channel(c);
     open(ch).then(fail(done), succeed(done));
   },
-  function(send, await, done) {
-    return await(defs.ChannelOpen)()
+  function(send, wait, done) {
+    return wait(defs.ChannelOpen)()
       .then(function(open) {
         send(defs.ChannelCloseOk, {}, open.channel);
       }).then(succeed(done), fail(done));
@@ -117,8 +117,8 @@ test("open, close", channelTest(
       })
       .then(succeed(done), fail(done));
   },
-  function(send, await, done, ch) {
-    return await(defs.ChannelClose)()
+  function(send, wait, done, ch) {
+    return wait(defs.ChannelClose)()
       .then(function(close) {
         send(defs.ChannelCloseOk, {}, ch);
       }).then(succeed(done), fail(done));
@@ -128,17 +128,19 @@ test("server close", channelTest(
   function(ch, done) {
     ch.on('error', function(error) {
       assert.strictEqual(504, error.code);
+      assert.strictEqual(0, error.classId);
+      assert.strictEqual(0, error.methodId);
       succeed(done)();
     });
     open(ch);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     send(defs.ChannelClose, {
       replyText: 'Forced close',
       replyCode: defs.constants.CHANNEL_ERROR,
       classId: 0, methodId: 0
     }, ch);
-    await(defs.ChannelCloseOk)()
+    wait(defs.ChannelCloseOk)()
       .then(succeed(done), fail(done));
   }));
 
@@ -151,8 +153,8 @@ test("overlapping channel/server close", channelTest(
       ch.closeBecause("Bye", defs.constants.REPLY_SUCCESS);
     }, fail(both));
   },
-  function(send, await, done, ch) {
-    await(defs.ChannelClose)()
+  function(send, wait, done, ch) {
+    wait(defs.ChannelClose)()
       .then(function() {
         send(defs.ConnectionClose, {
           replyText: 'Got there first',
@@ -160,7 +162,7 @@ test("overlapping channel/server close", channelTest(
           classId: 0, methodId: 0
         }, 0);
       })
-      .then(await(defs.ConnectionCloseOk))
+      .then(wait(defs.ConnectionCloseOk))
       .then(succeed(done), fail(done));
   }));
 
@@ -174,8 +176,8 @@ test("double close", channelTest(
       });
     }).then(succeed(done), fail(done));
   },
-  function(send, await, done, ch) {
-    await(defs.ChannelClose)()
+  function(send, wait, done, ch) {
+    wait(defs.ChannelClose)()
       .then(function() {
         send(defs.ChannelCloseOk, {
         }, ch);
@@ -208,16 +210,16 @@ test("RPC", channelTest(
       ch._rpc(defs.BasicQos, fields, defs.BasicQosOk, wheeboom);
     }).then(null, fail(rpcLatch));
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     function sendOk(f) {
       send(defs.BasicQosOk, {}, ch);
     }
 
-    return await(defs.BasicQos)()
+    return wait(defs.BasicQos)()
       .then(sendOk)
-      .then(await(defs.BasicQos))
+      .then(wait(defs.BasicQos))
       .then(sendOk)
-      .then(await(defs.BasicQos))
+      .then(wait(defs.BasicQos))
       .then(sendOk)
       .then(succeed(done), fail(done));
   }));
@@ -229,6 +231,8 @@ test("Bad RPC", channelTest(
     var errLatch = latch(2, done);
     ch.on('error', function(error) {
       assert.strictEqual(505, error.code);
+      assert.strictEqual(60, error.classId);
+      assert.strictEqual(72, error.methodId);
       succeed(errLatch)();
     });
 
@@ -241,12 +245,12 @@ test("Bad RPC", channelTest(
                 });
       }, fail(errLatch));
   },
-  function(send, await, done, ch) {
-    return await()()
+  function(send, wait, done, ch) {
+    return wait()()
       .then(function() {
         send(defs.BasicGetEmpty, {clusterId: ''}, ch);
       }) // oh wait! that was wrong! expect a channel close
-      .then(await(defs.ChannelClose))
+      .then(wait(defs.ChannelClose))
       .then(function() {
         send(defs.ChannelCloseOk, {}, ch);
       }).then(succeed(done), fail(done));
@@ -259,6 +263,8 @@ test("RPC on closed channel", channelTest(
     var close = new Promise(function(resolve) {
         ch.on('error', function(error) {
           assert.strictEqual(504, error.code);
+          assert.strictEqual(0, error.classId);
+          assert.strictEqual(0, error.methodId);
           resolve();
       });
     });
@@ -284,15 +290,15 @@ test("RPC on closed channel", channelTest(
       .then(succeed(done))
       .catch(fail(done));
   },
-  function(send, await, done, ch) {
-    await(defs.BasicRecover)()
+  function(send, wait, done, ch) {
+    wait(defs.BasicRecover)()
       .then(function() {
         send(defs.ChannelClose, {
           replyText: 'Nuh-uh!',
           replyCode: defs.constants.CHANNEL_ERROR,
           methodId: 0, classId: 0
         }, ch);
-        return await(defs.ChannelCloseOk);
+        return wait(defs.ChannelCloseOk);
       })
       .then(succeed(done))
       .catch(fail(done));
@@ -309,10 +315,10 @@ test("publish all < single chunk threshold", channelTest(
       })
       .then(succeed(done), fail(done));
   },
-  function(send, await, done, ch) {
-    await(defs.BasicPublish)()
-      .then(await(defs.BasicProperties))
-      .then(await(undefined)) // content frame
+  function(send, wait, done, ch) {
+    wait(defs.BasicPublish)()
+      .then(wait(defs.BasicProperties))
+      .then(wait(undefined)) // content frame
       .then(function(f) {
         assert.equal('foobar', f.content.toString());
       }).then(succeed(done), fail(done));
@@ -328,10 +334,10 @@ test("publish content > single chunk threshold", channelTest(
       }, {}, Buffer.alloc(3000));
     }, done);
   },
-  function(send, await, done, ch) {
-    await(defs.BasicPublish)()
-      .then(await(defs.BasicProperties))
-      .then(await(undefined)) // content frame
+  function(send, wait, done, ch) {
+    wait(defs.BasicPublish)()
+      .then(wait(defs.BasicProperties))
+      .then(wait(undefined)) // content frame
       .then(function(f) {
         assert.equal(3000, f.content.length);
       }).then(succeed(done), fail(done));
@@ -349,10 +355,10 @@ test("publish method & headers > threshold", channelTest(
       }, Buffer.from('foobar'));
     }, done);
   },
-  function(send, await, done, ch) {
-    await(defs.BasicPublish)()
-      .then(await(defs.BasicProperties))
-      .then(await(undefined)) // content frame
+  function(send, wait, done, ch) {
+    wait(defs.BasicPublish)()
+      .then(wait(defs.BasicProperties))
+      .then(wait(undefined)) // content frame
       .then(function(f) {
         assert.equal('foobar', f.content.toString());
       }).then(succeed(done), fail(done));
@@ -372,11 +378,11 @@ test("publish zero-length message", channelTest(
       }, {}, Buffer.alloc(0));
     }, done);
   },
-  function(send, await, done, ch) {
-    await(defs.BasicPublish)()
-      .then(await(defs.BasicProperties))
+  function(send, wait, done, ch) {
+    wait(defs.BasicPublish)()
+      .then(wait(defs.BasicProperties))
     // no content frame for a zero-length message
-      .then(await(defs.BasicPublish))
+      .then(wait(defs.BasicPublish))
       .then(succeed(done), fail(done));
   }));
 
@@ -389,7 +395,7 @@ test("delivery", channelTest(
       }, done);
     });
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     completes(function() {
       send(defs.BasicDeliver, DELIVER_FIELDS, ch, Buffer.from('barfoo'));
     }, done);
@@ -404,7 +410,7 @@ test("zero byte msg", channelTest(
       }, done);
     });
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     completes(function() {
       send(defs.BasicDeliver, DELIVER_FIELDS, ch, Buffer.from(''));
     }, done);
@@ -415,16 +421,18 @@ test("bad delivery", channelTest(
     var errorAndClose = latch(2, done);
     ch.on('error', function(error) {
       assert.strictEqual(505, error.code);
+      assert.strictEqual(60, error.classId);
+      assert.strictEqual(60, error.methodId);
       succeed(errorAndClose)();
     });
     ch.on('close', succeed(errorAndClose));
     open(ch);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     send(defs.BasicDeliver, DELIVER_FIELDS, ch);
     // now send another deliver without having sent the content
     send(defs.BasicDeliver, DELIVER_FIELDS, ch);
-    return await(defs.ChannelClose)()
+    return wait(defs.ChannelClose)()
       .then(function() {
         send(defs.ChannelCloseOk, {}, ch);
       }).then(succeed(done), fail(done));
@@ -441,7 +449,7 @@ test("bad content send", channelTest(
       });
     }, done);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     done();
   }));
 
@@ -457,7 +465,7 @@ test("bad properties send", channelTest(
       });
     }, done);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     done();
   }));
 
@@ -469,14 +477,16 @@ test("bad consumer", channelTest(
     });
     ch.on('error', function(error) {
       assert.strictEqual(541, error.code);
+      assert.strictEqual(undefined, error.classId);
+      assert.strictEqual(undefined, error.methodId);
       succeed(errorAndClose)();
     });
     ch.on('close', succeed(errorAndClose));
     open(ch);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     send(defs.BasicDeliver, DELIVER_FIELDS, ch, Buffer.from('barfoo'));
-    return await(defs.ChannelClose)()
+    return wait(defs.ChannelClose)()
       .then(function() {
         send(defs.ChannelCloseOk, {}, ch);
       }).then(succeed(done), fail(done));
@@ -488,6 +498,8 @@ test("bad send in consumer", channelTest(
     ch.on('close', succeed(errorAndClose));
     ch.on('error', function(error) {
       assert.strictEqual(541, error.code);
+      assert.strictEqual(undefined, error.classId);
+      assert.strictEqual(undefined, error.methodId);
       succeed(errorAndClose)();
     });
 
@@ -499,12 +511,12 @@ test("bad send in consumer", channelTest(
 
     open(ch);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     completes(function() {
       send(defs.BasicDeliver, DELIVER_FIELDS, ch,
            Buffer.from('barfoo'));
     }, done);
-    return await(defs.ChannelClose)()
+    return wait(defs.ChannelClose)()
       .then(function() {
         send(defs.ChannelCloseOk, {}, ch);
       }).then(succeed(done), fail(done));
@@ -519,7 +531,7 @@ test("return", channelTest(
     });
     open(ch);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     completes(function() {
       send(defs.BasicReturn, DELIVER_FIELDS, ch, Buffer.from('barfoo'));
     }, done);
@@ -534,7 +546,7 @@ test("cancel", channelTest(
     });
     open(ch);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     completes(function() {
       send(defs.BasicCancel, {
         consumerTag: 'product of society',
@@ -553,7 +565,7 @@ function confirmTest(variety, Method) {
       });
       open(ch);
     },
-    function(send, await, done, ch) {
+    function(send, wait, done, ch) {
       completes(function() {
         send(Method, {
           deliveryTag: 1,
@@ -579,7 +591,7 @@ test("out-of-order acks", channelTest(
     ch.pushConfirmCallback(allConfirms);
     open(ch);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     completes(function() {
       send(defs.BasicAck, {deliveryTag: 2, multiple: false}, ch);
       send(defs.BasicAck, {deliveryTag: 3, multiple: false}, ch);
@@ -602,7 +614,7 @@ test("not all out-of-order acks", channelTest(
     });
     open(ch);
   },
-  function(send, await, done, ch) {
+  function(send, wait, done, ch) {
     completes(function() {
       send(defs.BasicAck, {deliveryTag: 2, multiple: false}, ch);
       send(defs.BasicAck, {deliveryTag: 1, multiple: false}, ch);

package/test/connect.js

@@ -13,6 +13,8 @@ var format = require('util').format;
 
 var URL = process.env.URL || 'amqp://localhost';
 
+var urlparse = require('url-parse');
+
 suite("Credentials", function() {
 
   function checkCreds(creds, user, pass, done) {
@@ -27,29 +29,29 @@ suite("Credentials", function() {
   }
 
   test("no creds", function(done) {
-    var parts = {auth: ''};
+    var parts = urlparse('amqp://localhost');
     var creds = credentialsFromUrl(parts);
     checkCreds(creds, 'guest', 'guest', done);
   });
   test("usual user:pass", function(done) {
-    var parts = {auth: 'user:pass'};
+    var parts = urlparse('amqp://user:pass@localhost')
     var creds = credentialsFromUrl(parts);
     checkCreds(creds, 'user', 'pass', done);
   });
   test("missing user", function(done) {
-    var parts = {auth: ':password'};
+    var parts = urlparse('amqps://:password@localhost');
     var creds = credentialsFromUrl(parts);
     checkCreds(creds, '', 'password', done);
   });
   test("missing password", function(done) {
-    var parts = {auth: 'username'};
+    var parts = urlparse('amqps://username:@localhost');
     var creds = credentialsFromUrl(parts);
     checkCreds(creds, 'username', '', done);
   });
-  test("colon in password", function(done) {
-    var parts = {auth: 'username:pass:word'};
+  test("escaped colons", function(done) {
+    var parts = urlparse('amqp://user%3Aname:pass%3Aword@localhost')
     var creds = credentialsFromUrl(parts);
-    checkCreds(creds, 'username', 'pass:word', done);
+    checkCreds(creds, 'user:name', 'pass:word', done);
   });
 });
 
@@ -77,6 +79,17 @@ suite("Connect API", function() {
     connect(u, {}, kCallback(fail(done), succeed(done)));
   });
 
+  test("serverProperties", function(done) {
+    var url = require('url');
+    var parts = url.parse(URL, true);
+    var config = parts.query || {};
+    connect(config, {}, function(err, connection) {
+      if (err) { return done(err); }
+      assert.equal(connection.serverProperties.product, 'RabbitMQ');
+      done();
+    });
+  });
+
   test("using custom heartbeat option", function(done) {
     var url = require('url');
     var parts = url.parse(URL, true);
@@ -105,6 +118,18 @@ suite("Connect API", function() {
             kCallback(succeed(done), fail(done)));
   });
 
+  test("using amqplain credentials", function(done) {
+    var url = require('url');
+    var parts = url.parse(URL, true);
+    var u = 'guest', p = 'guest';
+    if (parts.auth) {
+      var auth = parts.auth.split(":");
+      u = auth[0], p = auth[1];
+    }
+    connect(URL, {credentials: require('../lib/credentials').amqplain(u, p)},
+            kCallback(succeed(done), fail(done)));
+  });
+
   test("using unsupported mechanism", function(done) {
     var creds = {
       mechanism: 'UNSUPPORTED',