amqplib 0.5.2 → 0.5.3

package/CHANGELOG.md

@@ -1,5 +1,49 @@
 # Change log for amqplib
 
+## Changes in v0.5.3
+
+    git log v0.5.2..v0.5.3
+
+ * Bump bitsyntax to remove some `Buffer` misuse deprecation notices
+ ([PR 480])(https://github.com/squaremo/amqp.node/pull/480)
+ * Test on node 11.1
+  ([PR 473])(https://github.com/squaremo/amqp.node/pull/464); thanks
+  @kibertoad
+ * Updated various dependencies
+ * Support queue mode during assertQueue
+   ([PR 464])(https://github.com/squaremo/amqp.node/pull/464); thanks
+   @JoeTheFkingFrypan
+ * Expose serverProperties in the connection object
+   ([PR 452])(https://github.com/squaremo/amqp.node/pull/452); thanks
+   @jfromaniello
+ * Test on Node 10
+   ([PR 454])(https://github.com/squaremo/amqp.node/pull/454); thanks
+   @kibertoad
+ * Support amqplain credentials
+   ([PR 451])(https://github.com/squaremo/amqp.node/pull/451); thanks
+   @jfromaniello
+ * Decorate channel errors with methodId and classId
+   ([PR 447])(https://github.com/squaremo/amqp.node/pull/447); thanks
+   @MitMaro
+ * Resolve issues caused by Node 10 `readable` changes
+   ([PR 442])(https://github.com/squaremo/amqp.node/pull/442)
+ * Bump uglify to 2.6.x and node to 9.1 due to nodejs/node#16781.
+   ([PR 439])(https://github.com/squaremo/amqp.node/pull/439)
+ * Updated README with more modern Buffer syntax
+   ([PR 438](https://github.com/squaremo/amqp.node/pull/438); thanks
+   @ravshansbox    
+ * Support overflow option to assert queue
+   ([PR 436])(https://github.com/squaremo/amqp.node/pull/436); thanks
+   to @honestserpent
+ * Replace instances of keyword `await`
+   ([PR 396])(https://github.com/squaremo/amqp.node/pull/396),
+   as discussed in
+   [issue 235](https://github.com/squaremo/amqp.node/issues/235)
+ * Use 3rd party url for better decoding of username/password
+   ([PR 395])(https://github.com/squaremo/amqp.node/pull/395),
+   as discussed in
+   [issue 385](https://github.com/squaremo/amqp.node/issues/385))
+
 ## Changes in v0.5.2
 
     git log v0.5.1..v0.5.2

package/Makefile

@@ -2,7 +2,8 @@ RABBITMQ_SRC_VERSION=rabbitmq_v3_2_1
 JSON=amqp-rabbitmq-0.9.1.json
 RABBITMQ_CODEGEN=https://raw.githubusercontent.com/rabbitmq/rabbitmq-codegen
 AMQP_JSON=$(RABBITMQ_CODEGEN)/$(RABBITMQ_SRC_VERSION)/$(JSON)
-NODEJS_VERSIONS='0.8' '0.9' '0.10' '0.11' '0.12' '1.6' '2.5' '3.3' '4.2' '5.5' '6.2' '8.9' '9.1'
+
+NODEJS_VERSIONS='0.8' '0.9' '0.10' '0.11' '0.12' '1.6' '2.5' '3.3' '4.2' '5.5' '6.2' '8.9' '9.11' '10.7' '11.1'
 
 MOCHA=./node_modules/.bin/mocha
 _MOCHA=./node_modules/.bin/_mocha

package/README.md

@@ -47,7 +47,7 @@ function publisher(conn) {
   function on_open(err, ch) {
     if (err != null) bail(err);
     ch.assertQueue(q);
-    ch.sendToQueue(q, new Buffer('something to do'));
+    ch.sendToQueue(q, Buffer.from('something to do'));
   }
 }
 
@@ -86,7 +86,7 @@ open.then(function(conn) {
   return conn.createChannel();
 }).then(function(ch) {
   return ch.assertQueue(q).then(function(ok) {
-    return ch.sendToQueue(q, new Buffer('something to do'));
+    return ch.sendToQueue(q, Buffer.from('something to do'));
   });
 }).catch(console.warn);
 

package/lib/api_args.js

@@ -58,6 +58,8 @@ Args.assertQueue = function(queue, options) {
                options.deadLetterRoutingKey);
   setIfDefined(argt, 'x-max-length', options.maxLength);
   setIfDefined(argt, 'x-max-priority', options.maxPriority);
+  setIfDefined(argt, 'x-overflow', options.overflow);
+  setIfDefined(argt, 'x-queue-mode', options.queueMode);
 
   return {
     queue: queue,

package/lib/channel.js

@@ -103,9 +103,10 @@ C._rpc = function(method, fields, expect, cb) {
         // We have detected a problem, so it's up to us to close the
         // channel
         var expectedName = methodName(expect);
+
         var e = new Error(fmt("Expected %s; got %s",
                               expectedName, inspect(f, false)));
-        self.closeWithError(fmt('Expected %s; got %s',
+        self.closeWithError(f.id, fmt('Expected %s; got %s',
                                 expectedName, methodName(f.id)),
                             defs.constants.UNEXPECTED_FRAME, e);
         return cb(e);
@@ -124,7 +125,11 @@ C._rpc = function(method, fields, expect, cb) {
         ? fmt("Operation failed: %s; %s",
               methodName(method), closeMsg(err))
         : fmt("Channel closed by server: %s", closeMsg(err));
-      return cb(new Error(e));
+      var closeFrameError = new Error(e);
+      closeFrameError.code = err.fields.replyCode;
+      closeFrameError.classId = err.fields.classId;
+      closeFrameError.methodId = err.fields.methodId;
+      return cb(closeFrameError);
     }
   }
 
@@ -186,7 +191,7 @@ C.toClosing = function(capturedStack, k) {
 };
 
 C._rejectPending = function() {
-  function rej(r) { 
+  function rej(r) {
     r(new Error("Channel ended, no reply will be forthcoming"));
   }
   if (this.reply !== null) rej(this.reply);
@@ -210,10 +215,15 @@ C.closeBecause = function(reason, code, k) {
 // If we close because there's been an error, we need to distinguish
 // between what we tell the server (`reason`) and what we report as
 // the cause in the client (`error`).
-C.closeWithError = function(reason, code, error) {
+C.closeWithError = function(id, reason, code, error) {
   var self = this;
   this.closeBecause(reason, code, function() {
     error.code = code;
+    // content frames and consumer errors do not provide a method a class/method ID
+    if (id) {
+      error.classId = defs.info(id).classId;
+      error.methodId = defs.info(id).methodId;
+    }
     self.emit('error', error);
   });
 };
@@ -232,15 +242,15 @@ C.acceptMessageFrame = function(f) {
   }
   catch (msg) {
     if (typeof msg === 'string') {
-      this.closeWithError(msg, defs.constants.UNEXPECTED_FRAME,
+      this.closeWithError(f.id, msg, defs.constants.UNEXPECTED_FRAME,
                           new Error(msg));
     }
     else if (msg instanceof Error) {
-      this.closeWithError('Error while processing message',
+      this.closeWithError(f.id, 'Error while processing message',
                           defs.constants.INTERNAL_ERROR, msg);
     }
     else {
-      this.closeWithError('Internal error while processing message',
+      this.closeWithError(f.id, 'Internal error while processing message',
                           defs.constants.INTERNAL_ERROR,
                           new Error(msg.toString()));
     }
@@ -283,7 +293,7 @@ function acceptMessage(continuation) {
     if (f.id === defs.BasicProperties) {
       message.properties = f.fields;
       totalSize = remaining = f.size;
-      
+
       // for zero-length messages, content frames aren't required.
       if (totalSize === 0) {
         message.content = Buffer.alloc(0);
@@ -291,7 +301,7 @@ function acceptMessage(continuation) {
         return acceptDeliveryOrReturn;
       }
       else {
-        return content;        
+        return content;
       }
     }
     else {
@@ -405,6 +415,8 @@ C.accept = function(f) {
 
     var error = new Error(emsg);
     error.code = f.fields.replyCode;
+    error.classId = f.fields.classId;
+    error.methodId = f.fields.methodId;
     this.emit('error', error);
 
     var s = stackCapture(emsg);
@@ -413,7 +425,7 @@ C.accept = function(f) {
 
   case defs.BasicFlow:
     // RabbitMQ doesn't send this, it just blocks the TCP socket
-    return this.closeWithError("Flow not implemented",
+    return this.closeWithError(f.id, "Flow not implemented",
                                defs.constants.NOT_IMPLEMENTED,
                                new Error('Flow not implemented'));
 

package/lib/connect.js

@@ -6,7 +6,7 @@
 
 'use strict';
 
-var URL = require('url');
+var URL = require('url-parse');
 var QS = require('querystring');
 var Connection = require('./connection').Connection;
 var fmt = require('util').format;
@@ -76,22 +76,12 @@ function openFrames(vhost, query, credentials, extraClientProperties) {
   };
 }
 
-// Decide on credentials based on what we're supplied. Note that in a
-// parsed URL, the auth part is already URL-decoded, so e.g., '%3a' in
-// the URL is already decoded to ':'. This is a bit unhelpful, as it
-// means we can't tell whether a colon is a separator, or part of the
-// username. Assume no colons in usernames.
+// Decide on credentials based on what we're supplied.
 function credentialsFromUrl(parts) {
   var user = 'guest', passwd = 'guest';
-  if (parts.auth) {
-    var colon = parts.auth.indexOf(':')
-    if (colon == -1) {
-      user = parts.auth;
-      passwd = '';
-    } else {
-      user = parts.auth.substring(0, colon);
-      passwd = parts.auth.substring(colon+1);
-    }
+  if (parts.username != '' || parts.password != '') {
+    user = (parts.username) ? unescape(parts.username) : '';
+    passwd = (parts.password) ? unescape(parts.password) : '';
   }
   return credentials.plain(user, passwd);
 }
@@ -137,7 +127,7 @@ function connect(url, socketOptions, openCallback) {
 
     fields = openFrames(url.vhost, config, sockopts.credentials || credentials.plain(user, pass), extraClientProperties);
   } else {
-    var parts = URL.parse(url, true); // yes, parse the query string
+    var parts = URL(url, true); // yes, parse the query string
     protocol = parts.protocol;
     sockopts.host = parts.hostname;
     sockopts.port = parseInt(parts.port) || ((protocol === 'amqp:') ? 5672 : 5671);

package/lib/connection.js

@@ -205,6 +205,7 @@ C.open = function(allFields, openCallback0) {
                          allFields.mechanism)));
       return;
     }
+    self.serverProperties = start.fields.serverProperties;
     send(defs.ConnectionStartOk);
     wait(afterStartOk);
   }
@@ -465,7 +466,7 @@ C.freshChannel = function(channel, options) {
 C.releaseChannel = function(channel) {
   this.freeChannels.clear(channel);
   var buffer = this.channels[channel].buffer;
-  this.muxer.unpipeFrom(buffer);
+  buffer.end(); // will also cause it to be unpiped
   this.channels[channel] = null;
 };
 

package/lib/credentials.js

@@ -9,6 +9,7 @@
 //  * EXTERNAL (assume the server will figure out who you are from
 //    context, i.e., your SSL certificate)
 var Buffer = require('safe-buffer').Buffer
+var codec = require('./codec')
 
 module.exports.plain = function(user, passwd) {
   return {
@@ -21,6 +22,19 @@ module.exports.plain = function(user, passwd) {
   }
 }
 
+module.exports.amqplain = function(user, passwd) {
+  return {
+    mechanism: 'AMQPLAIN',
+    response: function() {
+      const buffer = Buffer.alloc(16384);
+      const size = codec.encodeTable(buffer, { LOGIN: user, PASSWORD: passwd}, 0);
+      return buffer.slice(4, size);
+    },
+    username: user,
+    password: passwd
+  }
+}
+
 module.exports.external = function() {
   return {
     mechanism: 'EXTERNAL',