aiwcli 0.12.7 → 0.12.8
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/templates/CLAUDE.md +27 -0
- package/dist/templates/_shared/.claude/{commands/handoff.md → skills/handoff/SKILL.md} +3 -2
- package/dist/templates/_shared/.claude/{commands/handoff-resume.md → skills/handoff-resume/SKILL.md} +2 -1
- package/dist/templates/_shared/handoff-system/CLAUDE.md +433 -421
- package/dist/templates/_shared/lib-ts/CLAUDE.md +3 -3
- package/dist/templates/_shared/lib-ts/base/constants.ts +324 -306
- package/dist/templates/_shared/lib-ts/base/inference.ts +3 -3
- package/dist/templates/_shared/lib-ts/context/CLAUDE.md +134 -0
- package/dist/templates/_shared/scripts/status_line.ts +26 -29
- package/dist/templates/cc-native/.claude/commands/cc-native/specdev.md +1 -1
- package/dist/templates/cc-native/.claude/settings.json +3 -2
- package/dist/templates/cc-native/_cc-native/artifacts/CLAUDE.md +64 -0
- package/dist/templates/cc-native/_cc-native/{lib-ts/artifacts → artifacts/lib}/format.ts +597 -597
- package/dist/templates/cc-native/_cc-native/{lib-ts/artifacts → artifacts/lib}/index.ts +26 -26
- package/dist/templates/cc-native/_cc-native/{lib-ts/artifacts → artifacts/lib}/tracker.ts +107 -107
- package/dist/templates/cc-native/_cc-native/{lib-ts/artifacts → artifacts/lib}/write.ts +119 -119
- package/dist/templates/cc-native/_cc-native/hooks/CLAUDE.md +237 -247
- package/dist/templates/cc-native/_cc-native/hooks/cc-native-plan-review.ts +76 -76
- package/dist/templates/cc-native/_cc-native/hooks/validate_task_prompt.ts +76 -0
- package/dist/templates/cc-native/_cc-native/lib-ts/aggregate-agents.ts +163 -156
- package/dist/templates/cc-native/_cc-native/lib-ts/index.ts +116 -116
- package/dist/templates/cc-native/_cc-native/lib-ts/settings.ts +1 -1
- package/dist/templates/cc-native/_cc-native/lib-ts/types.ts +329 -329
- package/dist/templates/cc-native/_cc-native/plan-review/CLAUDE.md +149 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/CLAUDE.md +143 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/PLAN-ORCHESTRATOR.md +213 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-questions/PLAN-QUESTIONER.md +70 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/ARCH-EVOLUTION.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/ARCH-PATTERNS.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/ARCH-STRUCTURE.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/ASSUMPTION-TRACER.md +56 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/CLARITY-AUDITOR.md +53 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/COMPLETENESS-FEASIBILITY.md +66 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/COMPLETENESS-GAPS.md +70 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/COMPLETENESS-ORDERING.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/CONSTRAINT-VALIDATOR.md +72 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/DESIGN-ADR-VALIDATOR.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/DESIGN-SCALE-MATCHER.md +64 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/DEVILS-ADVOCATE.md +56 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/DOCUMENTATION-PHILOSOPHY.md +86 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/HANDOFF-READINESS.md +59 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/HIDDEN-COMPLEXITY.md +58 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/INCREMENTAL-DELIVERY.md +66 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/RISK-DEPENDENCY.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/RISK-FMEA.md +66 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/RISK-PREMORTEM.md +71 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/RISK-REVERSIBILITY.md +74 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/SCOPE-BOUNDARY.md +77 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/SIMPLICITY-GUARDIAN.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/SKEPTIC.md +68 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TESTDRIVEN-BEHAVIOR-AUDITOR.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TESTDRIVEN-CHARACTERIZATION.md +71 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TESTDRIVEN-FIRST-VALIDATOR.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TESTDRIVEN-PYRAMID-ANALYZER.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TRADEOFF-COSTS.md +67 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TRADEOFF-STAKEHOLDERS.md +65 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/VERIFY-COVERAGE.md +74 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/VERIFY-STRENGTH.md +69 -0
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/agent-selection.ts +163 -163
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/corroboration.ts +119 -119
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/graduation.ts +132 -132
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/orchestrator.ts +70 -70
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/output-builder.ts +130 -130
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/plan-questions.ts +102 -102
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/review-pipeline.ts +511 -511
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/agent.ts +74 -74
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/base/base-agent.ts +217 -217
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/index.ts +12 -12
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/providers/claude-agent.ts +66 -66
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/providers/codex-agent.ts +185 -185
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/providers/gemini-agent.ts +39 -39
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/providers/orchestrator-claude-agent.ts +196 -196
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/schemas.ts +201 -201
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/types.ts +23 -23
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/verdict.ts +72 -72
- package/dist/templates/cc-native/_cc-native/{workflows → plan-review/workflows}/specdev.md +9 -9
- package/oclif.manifest.json +1 -1
- package/package.json +1 -1
- package/dist/templates/cc-native/_cc-native/lib-ts/artifacts.ts +0 -21
|
@@ -1,329 +1,329 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* CC-Native plan review type definitions.
|
|
3
|
-
* All interfaces, schemas, and prompt constants for the plan review engine.
|
|
4
|
-
* See cc-native-plan-review-spec.md §3
|
|
5
|
-
*/
|
|
6
|
-
|
|
7
|
-
// Re-export shared types used by cc-native consumers
|
|
8
|
-
export type { ContextState, HookInput, HookOutput } from "../../_shared/lib-ts/types.js";
|
|
9
|
-
|
|
10
|
-
// ---------------------------------------------------------------------------
|
|
11
|
-
// Verdict & Decision Types
|
|
12
|
-
// ---------------------------------------------------------------------------
|
|
13
|
-
|
|
14
|
-
/** Verdict from a single reviewer */
|
|
15
|
-
export type Verdict = "pass" | "warn" | "fail" | "error" | "skip";
|
|
16
|
-
|
|
17
|
-
/** Decision after aggregating all verdicts */
|
|
18
|
-
export type ReviewDecision = "allow" | "deny";
|
|
19
|
-
|
|
20
|
-
/** Complexity level assigned by orchestrator */
|
|
21
|
-
export type ComplexityCategory = "simple" | "medium" | "high";
|
|
22
|
-
|
|
23
|
-
// ---------------------------------------------------------------------------
|
|
24
|
-
// Review Data Structures
|
|
25
|
-
// ---------------------------------------------------------------------------
|
|
26
|
-
|
|
27
|
-
/** Dimension classification for corroboration-based verdict */
|
|
28
|
-
export type IssueDimension =
|
|
29
|
-
| "completeness"
|
|
30
|
-
| "simplicity"
|
|
31
|
-
| "security"
|
|
32
|
-
| "performance"
|
|
33
|
-
| "reliability"
|
|
34
|
-
| "maintainability"
|
|
35
|
-
| "testability"
|
|
36
|
-
| "scope"
|
|
37
|
-
| "feasibility"
|
|
38
|
-
| "clarity";
|
|
39
|
-
|
|
40
|
-
/** A single issue found during review */
|
|
41
|
-
export interface ReviewIssue {
|
|
42
|
-
severity: "high" | "medium" | "low";
|
|
43
|
-
category: string;
|
|
44
|
-
issue: string;
|
|
45
|
-
suggested_fix: string;
|
|
46
|
-
dimension?: IssueDimension;
|
|
47
|
-
}
|
|
48
|
-
|
|
49
|
-
/** A group of issues in one dimension, classified as blocking or solo */
|
|
50
|
-
export interface DimensionGroup {
|
|
51
|
-
dimension: IssueDimension;
|
|
52
|
-
issues: Array<{ agent: string; issue: ReviewIssue }>;
|
|
53
|
-
agentCount: number;
|
|
54
|
-
threshold: number; // 2 × agentCount
|
|
55
|
-
}
|
|
56
|
-
|
|
57
|
-
/** Corroborated (blocking) group — threshold exceeded */
|
|
58
|
-
export type CorroboratedGroup = DimensionGroup;
|
|
59
|
-
|
|
60
|
-
/** Solo finding — below threshold, informational only */
|
|
61
|
-
export type SoloFinding = DimensionGroup;
|
|
62
|
-
|
|
63
|
-
/** Result of corroboration-based verdict computation */
|
|
64
|
-
export interface CorroborationResult {
|
|
65
|
-
blocking: CorroboratedGroup[];
|
|
66
|
-
solo: SoloFinding[];
|
|
67
|
-
unclassified: Array<{ agent: string; issue: ReviewIssue }>;
|
|
68
|
-
verdict: "pass" | "warn" | "fail";
|
|
69
|
-
}
|
|
70
|
-
|
|
71
|
-
/** Normalized review data from any reviewer */
|
|
72
|
-
export interface ReviewData {
|
|
73
|
-
verdict: Verdict;
|
|
74
|
-
summary: string;
|
|
75
|
-
summary_source: "reviewer" | "default";
|
|
76
|
-
issues: ReviewIssue[];
|
|
77
|
-
missing_sections: string[];
|
|
78
|
-
questions: string[];
|
|
79
|
-
}
|
|
80
|
-
|
|
81
|
-
/** Result from a single plan reviewer (Codex, Gemini, or Claude agent) */
|
|
82
|
-
export interface ReviewerResult {
|
|
83
|
-
name: string;
|
|
84
|
-
ok: boolean;
|
|
85
|
-
verdict: Verdict;
|
|
86
|
-
data: Record<string, unknown>;
|
|
87
|
-
raw: string;
|
|
88
|
-
err: string;
|
|
89
|
-
}
|
|
90
|
-
|
|
91
|
-
/** Result from the plan orchestrator */
|
|
92
|
-
export interface OrchestratorResult {
|
|
93
|
-
complexity: ComplexityCategory;
|
|
94
|
-
category: string;
|
|
95
|
-
selected_agents: string[];
|
|
96
|
-
reasoning: string;
|
|
97
|
-
skip_reason?: string;
|
|
98
|
-
error?: string;
|
|
99
|
-
}
|
|
100
|
-
|
|
101
|
-
/** Combined result from all review phases */
|
|
102
|
-
export interface CombinedReviewResult {
|
|
103
|
-
plan_hash: string;
|
|
104
|
-
overall_verdict: Verdict;
|
|
105
|
-
orchestration: OrchestratorResult | null;
|
|
106
|
-
agents: Record<string, ReviewerResult>;
|
|
107
|
-
timestamp: string;
|
|
108
|
-
}
|
|
109
|
-
|
|
110
|
-
/** Result from verdict aggregation */
|
|
111
|
-
export interface ReviewDecisionResult {
|
|
112
|
-
should_deny: boolean;
|
|
113
|
-
reason: string; // "fail_veto" | "acceptable" | "no_signal"
|
|
114
|
-
score: number;
|
|
115
|
-
}
|
|
116
|
-
|
|
117
|
-
// ---------------------------------------------------------------------------
|
|
118
|
-
// Agent & Orchestrator Configuration
|
|
119
|
-
// ---------------------------------------------------------------------------
|
|
120
|
-
|
|
121
|
-
/** Configuration for a Claude Code review agent */
|
|
122
|
-
export interface AgentConfig {
|
|
123
|
-
name: string;
|
|
124
|
-
model: string;
|
|
125
|
-
provider: string; // e.g. "claude" | "codex" — assigned at runtime by assignModelsToAgents()
|
|
126
|
-
focus: string;
|
|
127
|
-
categories: string[];
|
|
128
|
-
description: string;
|
|
129
|
-
system_prompt: string; // Markdown body content for --system-prompt
|
|
130
|
-
}
|
|
131
|
-
|
|
132
|
-
/** Configuration for the plan orchestrator */
|
|
133
|
-
export interface OrchestratorConfig {
|
|
134
|
-
enabled: boolean;
|
|
135
|
-
model: string;
|
|
136
|
-
timeout: number;
|
|
137
|
-
}
|
|
138
|
-
|
|
139
|
-
/** Configuration for a model provider (Claude, Codex, etc.) */
|
|
140
|
-
export interface ProviderConfig {
|
|
141
|
-
enabled: boolean;
|
|
142
|
-
models: string[];
|
|
143
|
-
}
|
|
144
|
-
|
|
145
|
-
/** Model provider pool configuration */
|
|
146
|
-
export interface ModelsConfig {
|
|
147
|
-
providers: Record<string, ProviderConfig>;
|
|
148
|
-
}
|
|
149
|
-
|
|
150
|
-
// ---------------------------------------------------------------------------
|
|
151
|
-
// State Interfaces
|
|
152
|
-
// ---------------------------------------------------------------------------
|
|
153
|
-
|
|
154
|
-
/** A single iteration history entry */
|
|
155
|
-
export interface IterationEntry {
|
|
156
|
-
hash: string;
|
|
157
|
-
verdict: string;
|
|
158
|
-
timestamp: string;
|
|
159
|
-
}
|
|
160
|
-
|
|
161
|
-
/** Iteration tracking state (stored adjacent to plan file) */
|
|
162
|
-
export interface IterationState {
|
|
163
|
-
current: number;
|
|
164
|
-
max: number;
|
|
165
|
-
complexity: string;
|
|
166
|
-
history: IterationEntry[];
|
|
167
|
-
graduated: string[];
|
|
168
|
-
passStreaks: Record<string, number>;
|
|
169
|
-
lastPlanHash: string;
|
|
170
|
-
lastPlanPath: string;
|
|
171
|
-
sessionId: string;
|
|
172
|
-
}
|
|
173
|
-
|
|
174
|
-
/** CC-native state stored in context state.json under cc_native key */
|
|
175
|
-
export interface CcNativeState {
|
|
176
|
-
plan_review?: PlanReviewState;
|
|
177
|
-
questions_asked?: QuestionsAskedState;
|
|
178
|
-
stuck_detection?: StuckDetectionState;
|
|
179
|
-
[key: string]: unknown;
|
|
180
|
-
}
|
|
181
|
-
|
|
182
|
-
/** Plan review state within cc_native */
|
|
183
|
-
export interface PlanReviewState {
|
|
184
|
-
plan_hash: string;
|
|
185
|
-
reviewed_at: string;
|
|
186
|
-
decision: string;
|
|
187
|
-
iteration?: {
|
|
188
|
-
current: number;
|
|
189
|
-
max: number;
|
|
190
|
-
complexity: string;
|
|
191
|
-
latest_verdict?: string;
|
|
192
|
-
};
|
|
193
|
-
}
|
|
194
|
-
|
|
195
|
-
/** Questions-asked tracking state */
|
|
196
|
-
export interface QuestionsAskedState {
|
|
197
|
-
asked: boolean; // Backward-compatible: true if either phase asked
|
|
198
|
-
asked_at: string;
|
|
199
|
-
early_questions_asked?: {
|
|
200
|
-
asked: boolean;
|
|
201
|
-
asked_at: string;
|
|
202
|
-
};
|
|
203
|
-
plan_questions_agent_asked?: {
|
|
204
|
-
asked: boolean;
|
|
205
|
-
asked_at: string;
|
|
206
|
-
};
|
|
207
|
-
}
|
|
208
|
-
|
|
209
|
-
/** Stuck detection state — tracks repeated errors, file edits, and test failures */
|
|
210
|
-
export interface StuckDetectionState {
|
|
211
|
-
error_hashes: Record<string, number>;
|
|
212
|
-
file_edits: Record<string, number>;
|
|
213
|
-
test_failures: number;
|
|
214
|
-
tool_calls_since_suggestion: number;
|
|
215
|
-
suggestion_count: number;
|
|
216
|
-
}
|
|
217
|
-
|
|
218
|
-
// ---------------------------------------------------------------------------
|
|
219
|
-
// Configuration
|
|
220
|
-
// ---------------------------------------------------------------------------
|
|
221
|
-
|
|
222
|
-
/** Display settings for review output formatting */
|
|
223
|
-
export interface DisplaySettings {
|
|
224
|
-
maxIssues: number;
|
|
225
|
-
maxMissingSections: number;
|
|
226
|
-
maxQuestions: number;
|
|
227
|
-
}
|
|
228
|
-
|
|
229
|
-
/** Full plan review configuration (from cc-native.config.json) */
|
|
230
|
-
export interface PlanReviewConfig {
|
|
231
|
-
planReview?: {
|
|
232
|
-
enabled?: boolean;
|
|
233
|
-
reviewers?: {
|
|
234
|
-
codex?: { enabled?: boolean; timeout?: number; model?: string };
|
|
235
|
-
gemini?: { enabled?: boolean; timeout?: number; model?: string };
|
|
236
|
-
};
|
|
237
|
-
agentReview?: {
|
|
238
|
-
enabled?: boolean;
|
|
239
|
-
timeout?: number;
|
|
240
|
-
orchestrator?: { enabled?: boolean; model?: string; timeout?: number };
|
|
241
|
-
agentSelection?: Record<string, unknown>;
|
|
242
|
-
complexityCategories?: string[];
|
|
243
|
-
};
|
|
244
|
-
display?: Partial<DisplaySettings>;
|
|
245
|
-
reviewIterations?: Record<string, number>;
|
|
246
|
-
earlyExitOnAllPass?: boolean;
|
|
247
|
-
};
|
|
248
|
-
display?: Partial<DisplaySettings>;
|
|
249
|
-
[key: string]: unknown;
|
|
250
|
-
}
|
|
251
|
-
|
|
252
|
-
// ---------------------------------------------------------------------------
|
|
253
|
-
// Reviewer Interface
|
|
254
|
-
// ---------------------------------------------------------------------------
|
|
255
|
-
|
|
256
|
-
/** Options passed to reviewer implementations */
|
|
257
|
-
export interface ReviewOptions {
|
|
258
|
-
timeout: number;
|
|
259
|
-
context_path?: string;
|
|
260
|
-
session_name?: string;
|
|
261
|
-
}
|
|
262
|
-
|
|
263
|
-
/** Interface all reviewers must implement */
|
|
264
|
-
export interface Reviewer {
|
|
265
|
-
review(
|
|
266
|
-
plan: string,
|
|
267
|
-
schema: Record<string, unknown>,
|
|
268
|
-
options: ReviewOptions,
|
|
269
|
-
): Promise<ReviewerResult>;
|
|
270
|
-
}
|
|
271
|
-
|
|
272
|
-
// ---------------------------------------------------------------------------
|
|
273
|
-
// JSON Schemas (moved to reviewers/schemas.ts)
|
|
274
|
-
// ---------------------------------------------------------------------------
|
|
275
|
-
// Re-export for backwards compatibility
|
|
276
|
-
export { REVIEW_SCHEMA, ORCHESTRATOR_SCHEMA, REVIEW_PROMPT_PREFIX, AGENT_REVIEW_PROMPT_PREFIX } from "
|
|
277
|
-
|
|
278
|
-
// ---------------------------------------------------------------------------
|
|
279
|
-
// Display Defaults
|
|
280
|
-
// ---------------------------------------------------------------------------
|
|
281
|
-
|
|
282
|
-
export const DEFAULT_DISPLAY: DisplaySettings = {
|
|
283
|
-
maxIssues: 12,
|
|
284
|
-
maxMissingSections: 12,
|
|
285
|
-
maxQuestions: 12,
|
|
286
|
-
};
|
|
287
|
-
|
|
288
|
-
export const DEFAULT_SANITIZATION = {
|
|
289
|
-
maxSessionIdLength: 32,
|
|
290
|
-
maxTitleLength: 50,
|
|
291
|
-
};
|
|
292
|
-
|
|
293
|
-
// ---------------------------------------------------------------------------
|
|
294
|
-
// Pipeline Types (review-pipeline.ts)
|
|
295
|
-
// ---------------------------------------------------------------------------
|
|
296
|
-
|
|
297
|
-
/** Discovered plan file with content and hash */
|
|
298
|
-
export interface DiscoveredPlan {
|
|
299
|
-
path: string;
|
|
300
|
-
content: string;
|
|
301
|
-
hash: string;
|
|
302
|
-
}
|
|
303
|
-
|
|
304
|
-
/** Input to the review pipeline */
|
|
305
|
-
export interface PipelineInput {
|
|
306
|
-
sessionId: string;
|
|
307
|
-
base: string;
|
|
308
|
-
aiwcliDir: string;
|
|
309
|
-
transcriptPath?: string;
|
|
310
|
-
payload: Record<string, unknown>;
|
|
311
|
-
}
|
|
312
|
-
|
|
313
|
-
/** Result from the review pipeline */
|
|
314
|
-
export type PipelineResult =
|
|
315
|
-
| { action: "skip"; reason: string }
|
|
316
|
-
| { action: "block"; contextText: string; blockReason: string };
|
|
317
|
-
|
|
318
|
-
/** Result of agent selection phase */
|
|
319
|
-
export interface AgentSelectionResult {
|
|
320
|
-
selectedAgents: AgentConfig[];
|
|
321
|
-
mandatoryNames: Set<string>;
|
|
322
|
-
detectedComplexity: string;
|
|
323
|
-
}
|
|
324
|
-
|
|
325
|
-
/** Result of iteration advancement after review */
|
|
326
|
-
export interface IterationAdvancement {
|
|
327
|
-
updatedState: IterationState;
|
|
328
|
-
newGraduates: string[];
|
|
329
|
-
}
|
|
1
|
+
/**
|
|
2
|
+
* CC-Native plan review type definitions.
|
|
3
|
+
* All interfaces, schemas, and prompt constants for the plan review engine.
|
|
4
|
+
* See cc-native-plan-review-spec.md §3
|
|
5
|
+
*/
|
|
6
|
+
|
|
7
|
+
// Re-export shared types used by cc-native consumers
|
|
8
|
+
export type { ContextState, HookInput, HookOutput } from "../../_shared/lib-ts/types.js";
|
|
9
|
+
|
|
10
|
+
// ---------------------------------------------------------------------------
|
|
11
|
+
// Verdict & Decision Types
|
|
12
|
+
// ---------------------------------------------------------------------------
|
|
13
|
+
|
|
14
|
+
/** Verdict from a single reviewer */
|
|
15
|
+
export type Verdict = "pass" | "warn" | "fail" | "error" | "skip";
|
|
16
|
+
|
|
17
|
+
/** Decision after aggregating all verdicts */
|
|
18
|
+
export type ReviewDecision = "allow" | "deny";
|
|
19
|
+
|
|
20
|
+
/** Complexity level assigned by orchestrator */
|
|
21
|
+
export type ComplexityCategory = "simple" | "medium" | "high";
|
|
22
|
+
|
|
23
|
+
// ---------------------------------------------------------------------------
|
|
24
|
+
// Review Data Structures
|
|
25
|
+
// ---------------------------------------------------------------------------
|
|
26
|
+
|
|
27
|
+
/** Dimension classification for corroboration-based verdict */
|
|
28
|
+
export type IssueDimension =
|
|
29
|
+
| "completeness"
|
|
30
|
+
| "simplicity"
|
|
31
|
+
| "security"
|
|
32
|
+
| "performance"
|
|
33
|
+
| "reliability"
|
|
34
|
+
| "maintainability"
|
|
35
|
+
| "testability"
|
|
36
|
+
| "scope"
|
|
37
|
+
| "feasibility"
|
|
38
|
+
| "clarity";
|
|
39
|
+
|
|
40
|
+
/** A single issue found during review */
|
|
41
|
+
export interface ReviewIssue {
|
|
42
|
+
severity: "high" | "medium" | "low";
|
|
43
|
+
category: string;
|
|
44
|
+
issue: string;
|
|
45
|
+
suggested_fix: string;
|
|
46
|
+
dimension?: IssueDimension;
|
|
47
|
+
}
|
|
48
|
+
|
|
49
|
+
/** A group of issues in one dimension, classified as blocking or solo */
|
|
50
|
+
export interface DimensionGroup {
|
|
51
|
+
dimension: IssueDimension;
|
|
52
|
+
issues: Array<{ agent: string; issue: ReviewIssue }>;
|
|
53
|
+
agentCount: number;
|
|
54
|
+
threshold: number; // 2 × agentCount
|
|
55
|
+
}
|
|
56
|
+
|
|
57
|
+
/** Corroborated (blocking) group — threshold exceeded */
|
|
58
|
+
export type CorroboratedGroup = DimensionGroup;
|
|
59
|
+
|
|
60
|
+
/** Solo finding — below threshold, informational only */
|
|
61
|
+
export type SoloFinding = DimensionGroup;
|
|
62
|
+
|
|
63
|
+
/** Result of corroboration-based verdict computation */
|
|
64
|
+
export interface CorroborationResult {
|
|
65
|
+
blocking: CorroboratedGroup[];
|
|
66
|
+
solo: SoloFinding[];
|
|
67
|
+
unclassified: Array<{ agent: string; issue: ReviewIssue }>;
|
|
68
|
+
verdict: "pass" | "warn" | "fail";
|
|
69
|
+
}
|
|
70
|
+
|
|
71
|
+
/** Normalized review data from any reviewer */
|
|
72
|
+
export interface ReviewData {
|
|
73
|
+
verdict: Verdict;
|
|
74
|
+
summary: string;
|
|
75
|
+
summary_source: "reviewer" | "default";
|
|
76
|
+
issues: ReviewIssue[];
|
|
77
|
+
missing_sections: string[];
|
|
78
|
+
questions: string[];
|
|
79
|
+
}
|
|
80
|
+
|
|
81
|
+
/** Result from a single plan reviewer (Codex, Gemini, or Claude agent) */
|
|
82
|
+
export interface ReviewerResult {
|
|
83
|
+
name: string;
|
|
84
|
+
ok: boolean;
|
|
85
|
+
verdict: Verdict;
|
|
86
|
+
data: Record<string, unknown>;
|
|
87
|
+
raw: string;
|
|
88
|
+
err: string;
|
|
89
|
+
}
|
|
90
|
+
|
|
91
|
+
/** Result from the plan orchestrator */
|
|
92
|
+
export interface OrchestratorResult {
|
|
93
|
+
complexity: ComplexityCategory;
|
|
94
|
+
category: string;
|
|
95
|
+
selected_agents: string[];
|
|
96
|
+
reasoning: string;
|
|
97
|
+
skip_reason?: string;
|
|
98
|
+
error?: string;
|
|
99
|
+
}
|
|
100
|
+
|
|
101
|
+
/** Combined result from all review phases */
|
|
102
|
+
export interface CombinedReviewResult {
|
|
103
|
+
plan_hash: string;
|
|
104
|
+
overall_verdict: Verdict;
|
|
105
|
+
orchestration: OrchestratorResult | null;
|
|
106
|
+
agents: Record<string, ReviewerResult>;
|
|
107
|
+
timestamp: string;
|
|
108
|
+
}
|
|
109
|
+
|
|
110
|
+
/** Result from verdict aggregation */
|
|
111
|
+
export interface ReviewDecisionResult {
|
|
112
|
+
should_deny: boolean;
|
|
113
|
+
reason: string; // "fail_veto" | "acceptable" | "no_signal"
|
|
114
|
+
score: number;
|
|
115
|
+
}
|
|
116
|
+
|
|
117
|
+
// ---------------------------------------------------------------------------
|
|
118
|
+
// Agent & Orchestrator Configuration
|
|
119
|
+
// ---------------------------------------------------------------------------
|
|
120
|
+
|
|
121
|
+
/** Configuration for a Claude Code review agent */
|
|
122
|
+
export interface AgentConfig {
|
|
123
|
+
name: string;
|
|
124
|
+
model: string;
|
|
125
|
+
provider: string; // e.g. "claude" | "codex" — assigned at runtime by assignModelsToAgents()
|
|
126
|
+
focus: string;
|
|
127
|
+
categories: string[];
|
|
128
|
+
description: string;
|
|
129
|
+
system_prompt: string; // Markdown body content for --system-prompt
|
|
130
|
+
}
|
|
131
|
+
|
|
132
|
+
/** Configuration for the plan orchestrator */
|
|
133
|
+
export interface OrchestratorConfig {
|
|
134
|
+
enabled: boolean;
|
|
135
|
+
model: string;
|
|
136
|
+
timeout: number;
|
|
137
|
+
}
|
|
138
|
+
|
|
139
|
+
/** Configuration for a model provider (Claude, Codex, etc.) */
|
|
140
|
+
export interface ProviderConfig {
|
|
141
|
+
enabled: boolean;
|
|
142
|
+
models: string[];
|
|
143
|
+
}
|
|
144
|
+
|
|
145
|
+
/** Model provider pool configuration */
|
|
146
|
+
export interface ModelsConfig {
|
|
147
|
+
providers: Record<string, ProviderConfig>;
|
|
148
|
+
}
|
|
149
|
+
|
|
150
|
+
// ---------------------------------------------------------------------------
|
|
151
|
+
// State Interfaces
|
|
152
|
+
// ---------------------------------------------------------------------------
|
|
153
|
+
|
|
154
|
+
/** A single iteration history entry */
|
|
155
|
+
export interface IterationEntry {
|
|
156
|
+
hash: string;
|
|
157
|
+
verdict: string;
|
|
158
|
+
timestamp: string;
|
|
159
|
+
}
|
|
160
|
+
|
|
161
|
+
/** Iteration tracking state (stored adjacent to plan file) */
|
|
162
|
+
export interface IterationState {
|
|
163
|
+
current: number;
|
|
164
|
+
max: number;
|
|
165
|
+
complexity: string;
|
|
166
|
+
history: IterationEntry[];
|
|
167
|
+
graduated: string[];
|
|
168
|
+
passStreaks: Record<string, number>;
|
|
169
|
+
lastPlanHash: string;
|
|
170
|
+
lastPlanPath: string;
|
|
171
|
+
sessionId: string;
|
|
172
|
+
}
|
|
173
|
+
|
|
174
|
+
/** CC-native state stored in context state.json under cc_native key */
|
|
175
|
+
export interface CcNativeState {
|
|
176
|
+
plan_review?: PlanReviewState;
|
|
177
|
+
questions_asked?: QuestionsAskedState;
|
|
178
|
+
stuck_detection?: StuckDetectionState;
|
|
179
|
+
[key: string]: unknown;
|
|
180
|
+
}
|
|
181
|
+
|
|
182
|
+
/** Plan review state within cc_native */
|
|
183
|
+
export interface PlanReviewState {
|
|
184
|
+
plan_hash: string;
|
|
185
|
+
reviewed_at: string;
|
|
186
|
+
decision: string;
|
|
187
|
+
iteration?: {
|
|
188
|
+
current: number;
|
|
189
|
+
max: number;
|
|
190
|
+
complexity: string;
|
|
191
|
+
latest_verdict?: string;
|
|
192
|
+
};
|
|
193
|
+
}
|
|
194
|
+
|
|
195
|
+
/** Questions-asked tracking state */
|
|
196
|
+
export interface QuestionsAskedState {
|
|
197
|
+
asked: boolean; // Backward-compatible: true if either phase asked
|
|
198
|
+
asked_at: string;
|
|
199
|
+
early_questions_asked?: {
|
|
200
|
+
asked: boolean;
|
|
201
|
+
asked_at: string;
|
|
202
|
+
};
|
|
203
|
+
plan_questions_agent_asked?: {
|
|
204
|
+
asked: boolean;
|
|
205
|
+
asked_at: string;
|
|
206
|
+
};
|
|
207
|
+
}
|
|
208
|
+
|
|
209
|
+
/** Stuck detection state — tracks repeated errors, file edits, and test failures */
|
|
210
|
+
export interface StuckDetectionState {
|
|
211
|
+
error_hashes: Record<string, number>;
|
|
212
|
+
file_edits: Record<string, number>;
|
|
213
|
+
test_failures: number;
|
|
214
|
+
tool_calls_since_suggestion: number;
|
|
215
|
+
suggestion_count: number;
|
|
216
|
+
}
|
|
217
|
+
|
|
218
|
+
// ---------------------------------------------------------------------------
|
|
219
|
+
// Configuration
|
|
220
|
+
// ---------------------------------------------------------------------------
|
|
221
|
+
|
|
222
|
+
/** Display settings for review output formatting */
|
|
223
|
+
export interface DisplaySettings {
|
|
224
|
+
maxIssues: number;
|
|
225
|
+
maxMissingSections: number;
|
|
226
|
+
maxQuestions: number;
|
|
227
|
+
}
|
|
228
|
+
|
|
229
|
+
/** Full plan review configuration (from cc-native.config.json) */
|
|
230
|
+
export interface PlanReviewConfig {
|
|
231
|
+
planReview?: {
|
|
232
|
+
enabled?: boolean;
|
|
233
|
+
reviewers?: {
|
|
234
|
+
codex?: { enabled?: boolean; timeout?: number; model?: string };
|
|
235
|
+
gemini?: { enabled?: boolean; timeout?: number; model?: string };
|
|
236
|
+
};
|
|
237
|
+
agentReview?: {
|
|
238
|
+
enabled?: boolean;
|
|
239
|
+
timeout?: number;
|
|
240
|
+
orchestrator?: { enabled?: boolean; model?: string; timeout?: number };
|
|
241
|
+
agentSelection?: Record<string, unknown>;
|
|
242
|
+
complexityCategories?: string[];
|
|
243
|
+
};
|
|
244
|
+
display?: Partial<DisplaySettings>;
|
|
245
|
+
reviewIterations?: Record<string, number>;
|
|
246
|
+
earlyExitOnAllPass?: boolean;
|
|
247
|
+
};
|
|
248
|
+
display?: Partial<DisplaySettings>;
|
|
249
|
+
[key: string]: unknown;
|
|
250
|
+
}
|
|
251
|
+
|
|
252
|
+
// ---------------------------------------------------------------------------
|
|
253
|
+
// Reviewer Interface
|
|
254
|
+
// ---------------------------------------------------------------------------
|
|
255
|
+
|
|
256
|
+
/** Options passed to reviewer implementations */
|
|
257
|
+
export interface ReviewOptions {
|
|
258
|
+
timeout: number;
|
|
259
|
+
context_path?: string;
|
|
260
|
+
session_name?: string;
|
|
261
|
+
}
|
|
262
|
+
|
|
263
|
+
/** Interface all reviewers must implement */
|
|
264
|
+
export interface Reviewer {
|
|
265
|
+
review(
|
|
266
|
+
plan: string,
|
|
267
|
+
schema: Record<string, unknown>,
|
|
268
|
+
options: ReviewOptions,
|
|
269
|
+
): Promise<ReviewerResult>;
|
|
270
|
+
}
|
|
271
|
+
|
|
272
|
+
// ---------------------------------------------------------------------------
|
|
273
|
+
// JSON Schemas (moved to reviewers/schemas.ts)
|
|
274
|
+
// ---------------------------------------------------------------------------
|
|
275
|
+
// Re-export for backwards compatibility
|
|
276
|
+
export { REVIEW_SCHEMA, ORCHESTRATOR_SCHEMA, REVIEW_PROMPT_PREFIX, AGENT_REVIEW_PROMPT_PREFIX } from "../plan-review/lib/reviewers/schemas.js";
|
|
277
|
+
|
|
278
|
+
// ---------------------------------------------------------------------------
|
|
279
|
+
// Display Defaults
|
|
280
|
+
// ---------------------------------------------------------------------------
|
|
281
|
+
|
|
282
|
+
export const DEFAULT_DISPLAY: DisplaySettings = {
|
|
283
|
+
maxIssues: 12,
|
|
284
|
+
maxMissingSections: 12,
|
|
285
|
+
maxQuestions: 12,
|
|
286
|
+
};
|
|
287
|
+
|
|
288
|
+
export const DEFAULT_SANITIZATION = {
|
|
289
|
+
maxSessionIdLength: 32,
|
|
290
|
+
maxTitleLength: 50,
|
|
291
|
+
};
|
|
292
|
+
|
|
293
|
+
// ---------------------------------------------------------------------------
|
|
294
|
+
// Pipeline Types (review-pipeline.ts)
|
|
295
|
+
// ---------------------------------------------------------------------------
|
|
296
|
+
|
|
297
|
+
/** Discovered plan file with content and hash */
|
|
298
|
+
export interface DiscoveredPlan {
|
|
299
|
+
path: string;
|
|
300
|
+
content: string;
|
|
301
|
+
hash: string;
|
|
302
|
+
}
|
|
303
|
+
|
|
304
|
+
/** Input to the review pipeline */
|
|
305
|
+
export interface PipelineInput {
|
|
306
|
+
sessionId: string;
|
|
307
|
+
base: string;
|
|
308
|
+
aiwcliDir: string;
|
|
309
|
+
transcriptPath?: string;
|
|
310
|
+
payload: Record<string, unknown>;
|
|
311
|
+
}
|
|
312
|
+
|
|
313
|
+
/** Result from the review pipeline */
|
|
314
|
+
export type PipelineResult =
|
|
315
|
+
| { action: "skip"; reason: string }
|
|
316
|
+
| { action: "block"; contextText: string; blockReason: string };
|
|
317
|
+
|
|
318
|
+
/** Result of agent selection phase */
|
|
319
|
+
export interface AgentSelectionResult {
|
|
320
|
+
selectedAgents: AgentConfig[];
|
|
321
|
+
mandatoryNames: Set<string>;
|
|
322
|
+
detectedComplexity: string;
|
|
323
|
+
}
|
|
324
|
+
|
|
325
|
+
/** Result of iteration advancement after review */
|
|
326
|
+
export interface IterationAdvancement {
|
|
327
|
+
updatedState: IterationState;
|
|
328
|
+
newGraduates: string[];
|
|
329
|
+
}
|