aiwcli 0.12.7 → 0.12.8
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/templates/CLAUDE.md +27 -0
- package/dist/templates/_shared/.claude/{commands/handoff.md → skills/handoff/SKILL.md} +3 -2
- package/dist/templates/_shared/.claude/{commands/handoff-resume.md → skills/handoff-resume/SKILL.md} +2 -1
- package/dist/templates/_shared/handoff-system/CLAUDE.md +433 -421
- package/dist/templates/_shared/lib-ts/CLAUDE.md +3 -3
- package/dist/templates/_shared/lib-ts/base/constants.ts +324 -306
- package/dist/templates/_shared/lib-ts/base/inference.ts +3 -3
- package/dist/templates/_shared/lib-ts/context/CLAUDE.md +134 -0
- package/dist/templates/_shared/scripts/status_line.ts +26 -29
- package/dist/templates/cc-native/.claude/commands/cc-native/specdev.md +1 -1
- package/dist/templates/cc-native/.claude/settings.json +3 -2
- package/dist/templates/cc-native/_cc-native/artifacts/CLAUDE.md +64 -0
- package/dist/templates/cc-native/_cc-native/{lib-ts/artifacts → artifacts/lib}/format.ts +597 -597
- package/dist/templates/cc-native/_cc-native/{lib-ts/artifacts → artifacts/lib}/index.ts +26 -26
- package/dist/templates/cc-native/_cc-native/{lib-ts/artifacts → artifacts/lib}/tracker.ts +107 -107
- package/dist/templates/cc-native/_cc-native/{lib-ts/artifacts → artifacts/lib}/write.ts +119 -119
- package/dist/templates/cc-native/_cc-native/hooks/CLAUDE.md +237 -247
- package/dist/templates/cc-native/_cc-native/hooks/cc-native-plan-review.ts +76 -76
- package/dist/templates/cc-native/_cc-native/hooks/validate_task_prompt.ts +76 -0
- package/dist/templates/cc-native/_cc-native/lib-ts/aggregate-agents.ts +163 -156
- package/dist/templates/cc-native/_cc-native/lib-ts/index.ts +116 -116
- package/dist/templates/cc-native/_cc-native/lib-ts/settings.ts +1 -1
- package/dist/templates/cc-native/_cc-native/lib-ts/types.ts +329 -329
- package/dist/templates/cc-native/_cc-native/plan-review/CLAUDE.md +149 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/CLAUDE.md +143 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/PLAN-ORCHESTRATOR.md +213 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-questions/PLAN-QUESTIONER.md +70 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/ARCH-EVOLUTION.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/ARCH-PATTERNS.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/ARCH-STRUCTURE.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/ASSUMPTION-TRACER.md +56 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/CLARITY-AUDITOR.md +53 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/COMPLETENESS-FEASIBILITY.md +66 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/COMPLETENESS-GAPS.md +70 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/COMPLETENESS-ORDERING.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/CONSTRAINT-VALIDATOR.md +72 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/DESIGN-ADR-VALIDATOR.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/DESIGN-SCALE-MATCHER.md +64 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/DEVILS-ADVOCATE.md +56 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/DOCUMENTATION-PHILOSOPHY.md +86 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/HANDOFF-READINESS.md +59 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/HIDDEN-COMPLEXITY.md +58 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/INCREMENTAL-DELIVERY.md +66 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/RISK-DEPENDENCY.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/RISK-FMEA.md +66 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/RISK-PREMORTEM.md +71 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/RISK-REVERSIBILITY.md +74 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/SCOPE-BOUNDARY.md +77 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/SIMPLICITY-GUARDIAN.md +62 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/SKEPTIC.md +68 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TESTDRIVEN-BEHAVIOR-AUDITOR.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TESTDRIVEN-CHARACTERIZATION.md +71 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TESTDRIVEN-FIRST-VALIDATOR.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TESTDRIVEN-PYRAMID-ANALYZER.md +61 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TRADEOFF-COSTS.md +67 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/TRADEOFF-STAKEHOLDERS.md +65 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/VERIFY-COVERAGE.md +74 -0
- package/dist/templates/cc-native/_cc-native/plan-review/agents/plan-review/VERIFY-STRENGTH.md +69 -0
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/agent-selection.ts +163 -163
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/corroboration.ts +119 -119
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/graduation.ts +132 -132
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/orchestrator.ts +70 -70
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/output-builder.ts +130 -130
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/plan-questions.ts +102 -102
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/review-pipeline.ts +511 -511
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/agent.ts +74 -74
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/base/base-agent.ts +217 -217
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/index.ts +12 -12
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/providers/claude-agent.ts +66 -66
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/providers/codex-agent.ts +185 -185
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/providers/gemini-agent.ts +39 -39
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/providers/orchestrator-claude-agent.ts +196 -196
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/schemas.ts +201 -201
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/types.ts +23 -23
- package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/verdict.ts +72 -72
- package/dist/templates/cc-native/_cc-native/{workflows → plan-review/workflows}/specdev.md +9 -9
- package/oclif.manifest.json +1 -1
- package/package.json +1 -1
- package/dist/templates/cc-native/_cc-native/lib-ts/artifacts.ts +0 -21
|
@@ -1,74 +1,74 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* Agent-based plan reviewer with multi-provider support.
|
|
3
|
-
* Routes to provider-specific implementations (Claude, Codex, Gemini).
|
|
4
|
-
* See cc-native-plan-review-spec.md §4.10
|
|
5
|
-
*/
|
|
6
|
-
|
|
7
|
-
import { logWarn } from "
|
|
8
|
-
import type { AgentConfig, ReviewerResult, ReviewOptions } from "
|
|
9
|
-
import { ClaudeAgent } from "./providers/claude-agent.js";
|
|
10
|
-
import { CodexAgent } from "./providers/codex-agent.js";
|
|
11
|
-
import { GeminiAgent } from "./providers/gemini-agent.js";
|
|
12
|
-
import type { Reviewer } from "./types.js";
|
|
13
|
-
import { makeResult } from "./types.js";
|
|
14
|
-
|
|
15
|
-
/**
|
|
16
|
-
* Agent reviewer — runs a CLI instance with a custom persona.
|
|
17
|
-
*/
|
|
18
|
-
export class AgentReviewer implements Reviewer {
|
|
19
|
-
constructor(private agent: AgentConfig) {}
|
|
20
|
-
|
|
21
|
-
async review(
|
|
22
|
-
plan: string,
|
|
23
|
-
schema: Record<string, unknown>,
|
|
24
|
-
options: ReviewOptions,
|
|
25
|
-
): Promise<ReviewerResult> {
|
|
26
|
-
return runAgentReview(
|
|
27
|
-
plan,
|
|
28
|
-
this.agent,
|
|
29
|
-
schema,
|
|
30
|
-
options.timeout,
|
|
31
|
-
options.context_path,
|
|
32
|
-
options.session_name ?? "unknown",
|
|
33
|
-
);
|
|
34
|
-
}
|
|
35
|
-
}
|
|
36
|
-
|
|
37
|
-
/**
|
|
38
|
-
* Run a single agent to review the plan.
|
|
39
|
-
* Routes to provider-specific implementation based on agent.provider.
|
|
40
|
-
* Never throws — returns error ReviewerResult on failure.
|
|
41
|
-
*/
|
|
42
|
-
export async function runAgentReview(
|
|
43
|
-
plan: string,
|
|
44
|
-
agent: AgentConfig,
|
|
45
|
-
schema: Record<string, unknown>,
|
|
46
|
-
timeout: number,
|
|
47
|
-
contextPath?: string,
|
|
48
|
-
sessionName = "unknown",
|
|
49
|
-
): Promise<ReviewerResult> {
|
|
50
|
-
try {
|
|
51
|
-
let reviewer;
|
|
52
|
-
|
|
53
|
-
switch (agent.provider) {
|
|
54
|
-
case "codex": {
|
|
55
|
-
reviewer = new CodexAgent(agent, schema, timeout, contextPath, sessionName);
|
|
56
|
-
break;
|
|
57
|
-
}
|
|
58
|
-
case "gemini": {
|
|
59
|
-
reviewer = new GeminiAgent(agent, schema, timeout, contextPath, sessionName);
|
|
60
|
-
break;
|
|
61
|
-
}
|
|
62
|
-
case "claude":
|
|
63
|
-
default: {
|
|
64
|
-
reviewer = new ClaudeAgent(agent, schema, timeout, contextPath, sessionName);
|
|
65
|
-
break;
|
|
66
|
-
}
|
|
67
|
-
}
|
|
68
|
-
|
|
69
|
-
return await reviewer.review(plan);
|
|
70
|
-
} catch (error) {
|
|
71
|
-
logWarn(agent.name, `Unexpected error creating reviewer: ${error}`);
|
|
72
|
-
return makeResult(agent.name, false, "error", {}, "", `Failed: ${error}`);
|
|
73
|
-
}
|
|
74
|
-
}
|
|
1
|
+
/**
|
|
2
|
+
* Agent-based plan reviewer with multi-provider support.
|
|
3
|
+
* Routes to provider-specific implementations (Claude, Codex, Gemini).
|
|
4
|
+
* See cc-native-plan-review-spec.md §4.10
|
|
5
|
+
*/
|
|
6
|
+
|
|
7
|
+
import { logWarn } from "../../../../_shared/lib-ts/base/logger.js";
|
|
8
|
+
import type { AgentConfig, ReviewerResult, ReviewOptions } from "../../../lib-ts/types.js";
|
|
9
|
+
import { ClaudeAgent } from "./providers/claude-agent.js";
|
|
10
|
+
import { CodexAgent } from "./providers/codex-agent.js";
|
|
11
|
+
import { GeminiAgent } from "./providers/gemini-agent.js";
|
|
12
|
+
import type { Reviewer } from "./types.js";
|
|
13
|
+
import { makeResult } from "./types.js";
|
|
14
|
+
|
|
15
|
+
/**
|
|
16
|
+
* Agent reviewer — runs a CLI instance with a custom persona.
|
|
17
|
+
*/
|
|
18
|
+
export class AgentReviewer implements Reviewer {
|
|
19
|
+
constructor(private agent: AgentConfig) {}
|
|
20
|
+
|
|
21
|
+
async review(
|
|
22
|
+
plan: string,
|
|
23
|
+
schema: Record<string, unknown>,
|
|
24
|
+
options: ReviewOptions,
|
|
25
|
+
): Promise<ReviewerResult> {
|
|
26
|
+
return runAgentReview(
|
|
27
|
+
plan,
|
|
28
|
+
this.agent,
|
|
29
|
+
schema,
|
|
30
|
+
options.timeout,
|
|
31
|
+
options.context_path,
|
|
32
|
+
options.session_name ?? "unknown",
|
|
33
|
+
);
|
|
34
|
+
}
|
|
35
|
+
}
|
|
36
|
+
|
|
37
|
+
/**
|
|
38
|
+
* Run a single agent to review the plan.
|
|
39
|
+
* Routes to provider-specific implementation based on agent.provider.
|
|
40
|
+
* Never throws — returns error ReviewerResult on failure.
|
|
41
|
+
*/
|
|
42
|
+
export async function runAgentReview(
|
|
43
|
+
plan: string,
|
|
44
|
+
agent: AgentConfig,
|
|
45
|
+
schema: Record<string, unknown>,
|
|
46
|
+
timeout: number,
|
|
47
|
+
contextPath?: string,
|
|
48
|
+
sessionName = "unknown",
|
|
49
|
+
): Promise<ReviewerResult> {
|
|
50
|
+
try {
|
|
51
|
+
let reviewer;
|
|
52
|
+
|
|
53
|
+
switch (agent.provider) {
|
|
54
|
+
case "codex": {
|
|
55
|
+
reviewer = new CodexAgent(agent, schema, timeout, contextPath, sessionName);
|
|
56
|
+
break;
|
|
57
|
+
}
|
|
58
|
+
case "gemini": {
|
|
59
|
+
reviewer = new GeminiAgent(agent, schema, timeout, contextPath, sessionName);
|
|
60
|
+
break;
|
|
61
|
+
}
|
|
62
|
+
case "claude":
|
|
63
|
+
default: {
|
|
64
|
+
reviewer = new ClaudeAgent(agent, schema, timeout, contextPath, sessionName);
|
|
65
|
+
break;
|
|
66
|
+
}
|
|
67
|
+
}
|
|
68
|
+
|
|
69
|
+
return await reviewer.review(plan);
|
|
70
|
+
} catch (error) {
|
|
71
|
+
logWarn(agent.name, `Unexpected error creating reviewer: ${error}`);
|
|
72
|
+
return makeResult(agent.name, false, "error", {}, "", `Failed: ${error}`);
|
|
73
|
+
}
|
|
74
|
+
}
|
package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/reviewers/base/base-agent.ts
RENAMED
|
@@ -1,217 +1,217 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* Abstract base class for CLI-based agent reviewers.
|
|
3
|
-
* Implements template method pattern for subprocess execution flow.
|
|
4
|
-
* Provider-specific implementations (Claude, Codex, Gemini) extend this class.
|
|
5
|
-
*/
|
|
6
|
-
|
|
7
|
-
import { logDebug, logInfo, logWarn, logError } from "
|
|
8
|
-
import { getInternalSubprocessEnv, findExecutable, execFileAsync } from "
|
|
9
|
-
import { debugLog, debugRaw } from "
|
|
10
|
-
import type { AgentConfig } from "
|
|
11
|
-
|
|
12
|
-
/** Result from execFileAsync */
|
|
13
|
-
export interface ExecResult {
|
|
14
|
-
stdout: string;
|
|
15
|
-
stderr: string;
|
|
16
|
-
exitCode: number | null;
|
|
17
|
-
signal: string | null;
|
|
18
|
-
killed: boolean;
|
|
19
|
-
}
|
|
20
|
-
|
|
21
|
-
/**
|
|
22
|
-
* Abstract base class for all CLI agent subprocess invocations.
|
|
23
|
-
* Parameterized over return type T — ReviewerResult for reviewers,
|
|
24
|
-
* OrchestratorResult for the orchestrator.
|
|
25
|
-
* Subclasses implement provider-specific details.
|
|
26
|
-
*/
|
|
27
|
-
export abstract class BaseCliAgent<T> {
|
|
28
|
-
protected agent: AgentConfig;
|
|
29
|
-
protected contextPath?: string;
|
|
30
|
-
protected schema: Record<string, unknown>;
|
|
31
|
-
protected sessionName: string;
|
|
32
|
-
protected timeout: number;
|
|
33
|
-
|
|
34
|
-
constructor(
|
|
35
|
-
agent: AgentConfig,
|
|
36
|
-
schema: Record<string, unknown>,
|
|
37
|
-
timeout: number,
|
|
38
|
-
contextPath?: string,
|
|
39
|
-
sessionName = "unknown",
|
|
40
|
-
) {
|
|
41
|
-
this.agent = agent;
|
|
42
|
-
this.schema = schema;
|
|
43
|
-
this.timeout = timeout;
|
|
44
|
-
this.contextPath = contextPath;
|
|
45
|
-
this.sessionName = sessionName;
|
|
46
|
-
}
|
|
47
|
-
|
|
48
|
-
/** Build the command-line arguments for the CLI */
|
|
49
|
-
protected abstract buildCliArgs(): string[];
|
|
50
|
-
|
|
51
|
-
// ─── Abstract Methods (Subclass Implements) ────────────────────────────
|
|
52
|
-
|
|
53
|
-
/** Build the stdin prompt for the CLI */
|
|
54
|
-
protected abstract buildPrompt(plan: string): string;
|
|
55
|
-
|
|
56
|
-
/** Optional cleanup after subprocess execution */
|
|
57
|
-
protected async cleanup(): Promise<void> {
|
|
58
|
-
// Default: no-op. Subclasses override if needed (e.g., Codex temp files).
|
|
59
|
-
}
|
|
60
|
-
|
|
61
|
-
/** Coerce parsed JSON into the result type T */
|
|
62
|
-
protected abstract coerceResult(obj: Record<string, unknown> | null, raw: string, err: string): T;
|
|
63
|
-
|
|
64
|
-
/** Extract stdout/stderr from subprocess result. Override for file-based output (Codex). */
|
|
65
|
-
protected extractOutput(result: ExecResult): { raw: string; err: string } {
|
|
66
|
-
return {
|
|
67
|
-
raw: result.stdout.trim(),
|
|
68
|
-
err: result.stderr.trim(),
|
|
69
|
-
};
|
|
70
|
-
}
|
|
71
|
-
|
|
72
|
-
/** Find the CLI executable. Override for custom search logic. */
|
|
73
|
-
protected findCli(): string | null {
|
|
74
|
-
return findExecutable(this.getCliName());
|
|
75
|
-
}
|
|
76
|
-
|
|
77
|
-
// ─── Template Methods (Subclass Can Override) ──────────────────────────
|
|
78
|
-
|
|
79
|
-
/** Get the CLI executable name (e.g., "claude", "codex") */
|
|
80
|
-
protected abstract getCliName(): string;
|
|
81
|
-
|
|
82
|
-
/** Get default error message for coerceToReview */
|
|
83
|
-
protected getDefaultErrorMessage(): string {
|
|
84
|
-
return `Retry or check ${this.getCliName()} configuration.`;
|
|
85
|
-
}
|
|
86
|
-
|
|
87
|
-
/** Handle non-zero exit with no output */
|
|
88
|
-
protected handleExitError(result: ExecResult): T {
|
|
89
|
-
const msg = `${this.agent.name} failed to run (exit ${result.exitCode})`;
|
|
90
|
-
logError(this.agent.name, `Process exited with code ${result.exitCode} and no output`);
|
|
91
|
-
return this.makeErrorResult("error", msg);
|
|
92
|
-
}
|
|
93
|
-
|
|
94
|
-
/** Handle timeout scenario */
|
|
95
|
-
protected handleTimeout(): T {
|
|
96
|
-
const msg = `${this.getCliName()} TIMEOUT after ${this.timeout}s`;
|
|
97
|
-
logWarn(this.agent.name, msg);
|
|
98
|
-
return this.makeErrorResult("error", `${this.agent.name} timed out after ${this.timeout}s`);
|
|
99
|
-
}
|
|
100
|
-
|
|
101
|
-
// ─── Shared Infrastructure ──────────────────────────────────────────────
|
|
102
|
-
|
|
103
|
-
/** Log parsed JSON result */
|
|
104
|
-
protected logParsedResult(obj: Record<string, unknown> | null): void {
|
|
105
|
-
if (this.contextPath && obj) {
|
|
106
|
-
debugLog(this.contextPath, this.sessionName, `agent:${this.agent.name}`, "parsed_result", {
|
|
107
|
-
parsed_keys: Object.keys(obj),
|
|
108
|
-
verdict: obj.verdict ?? null,
|
|
109
|
-
has_summary: Boolean(obj.summary),
|
|
110
|
-
issues_count: Array.isArray(obj.issues) ? (obj.issues as unknown[]).length : 0,
|
|
111
|
-
});
|
|
112
|
-
}
|
|
113
|
-
|
|
114
|
-
if (obj) {
|
|
115
|
-
logInfo(this.agent.name, `Parsed JSON successfully, verdict: ${obj.verdict ?? "N/A"}`);
|
|
116
|
-
} else {
|
|
117
|
-
logWarn(this.agent.name, "Failed to parse JSON from output");
|
|
118
|
-
}
|
|
119
|
-
}
|
|
120
|
-
|
|
121
|
-
/** Log subprocess execution results */
|
|
122
|
-
protected logSubprocessResult(result: ExecResult, raw: string, err: string): void {
|
|
123
|
-
logDebug(this.agent.name, `Exit code: ${result.exitCode}`);
|
|
124
|
-
logDebug(this.agent.name, `stdout length: ${raw.length} chars`);
|
|
125
|
-
if (err) logDebug(this.agent.name, `stderr: ${err.slice(0, 500)}`);
|
|
126
|
-
|
|
127
|
-
// Debug logging
|
|
128
|
-
if (this.contextPath) {
|
|
129
|
-
debugRaw(this.contextPath, this.sessionName, `agent:${this.agent.name}`, "stdout", raw);
|
|
130
|
-
if (err) {
|
|
131
|
-
debugRaw(this.contextPath, this.sessionName, `agent:${this.agent.name}`, "stderr", err);
|
|
132
|
-
}
|
|
133
|
-
debugLog(this.contextPath, this.sessionName, `agent:${this.agent.name}`, "subprocess_info", {
|
|
134
|
-
exit_code: result.exitCode,
|
|
135
|
-
stdout_len: raw.length,
|
|
136
|
-
stderr_len: err.length,
|
|
137
|
-
model: this.agent.model,
|
|
138
|
-
provider: this.agent.provider,
|
|
139
|
-
timeout: this.timeout,
|
|
140
|
-
});
|
|
141
|
-
}
|
|
142
|
-
|
|
143
|
-
if (raw) logDebug(this.agent.name, `stdout preview: ${raw.slice(0, 500)}`);
|
|
144
|
-
}
|
|
145
|
-
|
|
146
|
-
/** Construct a T for error/skip/timeout scenarios. Subclasses define shape. */
|
|
147
|
-
protected abstract makeErrorResult(type: "skip" | "error", message: string): T;
|
|
148
|
-
|
|
149
|
-
/** Create skip result when CLI not found */
|
|
150
|
-
protected makeSkipResult(reason: string): T {
|
|
151
|
-
logWarn(this.agent.name, reason);
|
|
152
|
-
return this.makeErrorResult("skip", reason);
|
|
153
|
-
}
|
|
154
|
-
|
|
155
|
-
/** Parse JSON from CLI output */
|
|
156
|
-
protected abstract parseOutput(raw: string, result: ExecResult): Record<string, unknown> | null;
|
|
157
|
-
|
|
158
|
-
/**
|
|
159
|
-
* Template method - orchestrates the review flow.
|
|
160
|
-
* Subclasses override abstract methods to customize behavior.
|
|
161
|
-
*/
|
|
162
|
-
async review(plan: string): Promise<T> {
|
|
163
|
-
// 1. Find CLI executable
|
|
164
|
-
const cliPath = this.findCli();
|
|
165
|
-
if (!cliPath) {
|
|
166
|
-
return this.makeSkipResult(`${this.getCliName()} CLI not found on PATH`);
|
|
167
|
-
}
|
|
168
|
-
|
|
169
|
-
logDebug(this.agent.name, `Found ${this.getCliName()} CLI at: ${cliPath}`);
|
|
170
|
-
|
|
171
|
-
// 2. Build prompt and args (provider-specific)
|
|
172
|
-
const prompt = this.buildPrompt(plan);
|
|
173
|
-
const args = this.buildCliArgs();
|
|
174
|
-
|
|
175
|
-
logInfo(this.agent.name, `Running ${this.getCliName()} with model: ${this.agent.model}, timeout: ${this.timeout}s`);
|
|
176
|
-
|
|
177
|
-
// 3. Execute subprocess
|
|
178
|
-
const env = getInternalSubprocessEnv();
|
|
179
|
-
const result = await execFileAsync(cliPath, args, {
|
|
180
|
-
input: prompt,
|
|
181
|
-
timeout: this.timeout * 1000,
|
|
182
|
-
env: env as Record<string, string>,
|
|
183
|
-
maxBuffer: 10 * 1024 * 1024,
|
|
184
|
-
shell: process.platform === "win32",
|
|
185
|
-
});
|
|
186
|
-
|
|
187
|
-
// 4. Handle timeout
|
|
188
|
-
if (result.killed || result.signal === "SIGTERM") {
|
|
189
|
-
return this.handleTimeout();
|
|
190
|
-
}
|
|
191
|
-
|
|
192
|
-
// 5. Extract output (provider-specific)
|
|
193
|
-
const { raw, err } = this.extractOutput(result);
|
|
194
|
-
|
|
195
|
-
// 6. Handle exit errors
|
|
196
|
-
if (!raw && !err && result.exitCode !== 0) {
|
|
197
|
-
return this.handleExitError(result);
|
|
198
|
-
}
|
|
199
|
-
|
|
200
|
-
// 7. Log subprocess results
|
|
201
|
-
this.logSubprocessResult(result, raw, err);
|
|
202
|
-
|
|
203
|
-
// 8. Parse JSON output (provider-specific)
|
|
204
|
-
const obj = this.parseOutput(raw, result);
|
|
205
|
-
|
|
206
|
-
// 9. Log parsed result
|
|
207
|
-
this.logParsedResult(obj);
|
|
208
|
-
|
|
209
|
-
// 10. Coerce to result type T (provider-specific)
|
|
210
|
-
const coerced = this.coerceResult(obj, raw, err);
|
|
211
|
-
|
|
212
|
-
// 11. Cleanup (optional override)
|
|
213
|
-
await this.cleanup();
|
|
214
|
-
|
|
215
|
-
return coerced;
|
|
216
|
-
}
|
|
217
|
-
}
|
|
1
|
+
/**
|
|
2
|
+
* Abstract base class for CLI-based agent reviewers.
|
|
3
|
+
* Implements template method pattern for subprocess execution flow.
|
|
4
|
+
* Provider-specific implementations (Claude, Codex, Gemini) extend this class.
|
|
5
|
+
*/
|
|
6
|
+
|
|
7
|
+
import { logDebug, logInfo, logWarn, logError } from "../../../../../_shared/lib-ts/base/logger.js";
|
|
8
|
+
import { getInternalSubprocessEnv, findExecutable, execFileAsync } from "../../../../../_shared/lib-ts/base/subprocess-utils.js";
|
|
9
|
+
import { debugLog, debugRaw } from "../../../../lib-ts/debug.js";
|
|
10
|
+
import type { AgentConfig } from "../../../../lib-ts/types.js";
|
|
11
|
+
|
|
12
|
+
/** Result from execFileAsync */
|
|
13
|
+
export interface ExecResult {
|
|
14
|
+
stdout: string;
|
|
15
|
+
stderr: string;
|
|
16
|
+
exitCode: number | null;
|
|
17
|
+
signal: string | null;
|
|
18
|
+
killed: boolean;
|
|
19
|
+
}
|
|
20
|
+
|
|
21
|
+
/**
|
|
22
|
+
* Abstract base class for all CLI agent subprocess invocations.
|
|
23
|
+
* Parameterized over return type T — ReviewerResult for reviewers,
|
|
24
|
+
* OrchestratorResult for the orchestrator.
|
|
25
|
+
* Subclasses implement provider-specific details.
|
|
26
|
+
*/
|
|
27
|
+
export abstract class BaseCliAgent<T> {
|
|
28
|
+
protected agent: AgentConfig;
|
|
29
|
+
protected contextPath?: string;
|
|
30
|
+
protected schema: Record<string, unknown>;
|
|
31
|
+
protected sessionName: string;
|
|
32
|
+
protected timeout: number;
|
|
33
|
+
|
|
34
|
+
constructor(
|
|
35
|
+
agent: AgentConfig,
|
|
36
|
+
schema: Record<string, unknown>,
|
|
37
|
+
timeout: number,
|
|
38
|
+
contextPath?: string,
|
|
39
|
+
sessionName = "unknown",
|
|
40
|
+
) {
|
|
41
|
+
this.agent = agent;
|
|
42
|
+
this.schema = schema;
|
|
43
|
+
this.timeout = timeout;
|
|
44
|
+
this.contextPath = contextPath;
|
|
45
|
+
this.sessionName = sessionName;
|
|
46
|
+
}
|
|
47
|
+
|
|
48
|
+
/** Build the command-line arguments for the CLI */
|
|
49
|
+
protected abstract buildCliArgs(): string[];
|
|
50
|
+
|
|
51
|
+
// ─── Abstract Methods (Subclass Implements) ────────────────────────────
|
|
52
|
+
|
|
53
|
+
/** Build the stdin prompt for the CLI */
|
|
54
|
+
protected abstract buildPrompt(plan: string): string;
|
|
55
|
+
|
|
56
|
+
/** Optional cleanup after subprocess execution */
|
|
57
|
+
protected async cleanup(): Promise<void> {
|
|
58
|
+
// Default: no-op. Subclasses override if needed (e.g., Codex temp files).
|
|
59
|
+
}
|
|
60
|
+
|
|
61
|
+
/** Coerce parsed JSON into the result type T */
|
|
62
|
+
protected abstract coerceResult(obj: Record<string, unknown> | null, raw: string, err: string): T;
|
|
63
|
+
|
|
64
|
+
/** Extract stdout/stderr from subprocess result. Override for file-based output (Codex). */
|
|
65
|
+
protected extractOutput(result: ExecResult): { raw: string; err: string } {
|
|
66
|
+
return {
|
|
67
|
+
raw: result.stdout.trim(),
|
|
68
|
+
err: result.stderr.trim(),
|
|
69
|
+
};
|
|
70
|
+
}
|
|
71
|
+
|
|
72
|
+
/** Find the CLI executable. Override for custom search logic. */
|
|
73
|
+
protected findCli(): string | null {
|
|
74
|
+
return findExecutable(this.getCliName());
|
|
75
|
+
}
|
|
76
|
+
|
|
77
|
+
// ─── Template Methods (Subclass Can Override) ──────────────────────────
|
|
78
|
+
|
|
79
|
+
/** Get the CLI executable name (e.g., "claude", "codex") */
|
|
80
|
+
protected abstract getCliName(): string;
|
|
81
|
+
|
|
82
|
+
/** Get default error message for coerceToReview */
|
|
83
|
+
protected getDefaultErrorMessage(): string {
|
|
84
|
+
return `Retry or check ${this.getCliName()} configuration.`;
|
|
85
|
+
}
|
|
86
|
+
|
|
87
|
+
/** Handle non-zero exit with no output */
|
|
88
|
+
protected handleExitError(result: ExecResult): T {
|
|
89
|
+
const msg = `${this.agent.name} failed to run (exit ${result.exitCode})`;
|
|
90
|
+
logError(this.agent.name, `Process exited with code ${result.exitCode} and no output`);
|
|
91
|
+
return this.makeErrorResult("error", msg);
|
|
92
|
+
}
|
|
93
|
+
|
|
94
|
+
/** Handle timeout scenario */
|
|
95
|
+
protected handleTimeout(): T {
|
|
96
|
+
const msg = `${this.getCliName()} TIMEOUT after ${this.timeout}s`;
|
|
97
|
+
logWarn(this.agent.name, msg);
|
|
98
|
+
return this.makeErrorResult("error", `${this.agent.name} timed out after ${this.timeout}s`);
|
|
99
|
+
}
|
|
100
|
+
|
|
101
|
+
// ─── Shared Infrastructure ──────────────────────────────────────────────
|
|
102
|
+
|
|
103
|
+
/** Log parsed JSON result */
|
|
104
|
+
protected logParsedResult(obj: Record<string, unknown> | null): void {
|
|
105
|
+
if (this.contextPath && obj) {
|
|
106
|
+
debugLog(this.contextPath, this.sessionName, `agent:${this.agent.name}`, "parsed_result", {
|
|
107
|
+
parsed_keys: Object.keys(obj),
|
|
108
|
+
verdict: obj.verdict ?? null,
|
|
109
|
+
has_summary: Boolean(obj.summary),
|
|
110
|
+
issues_count: Array.isArray(obj.issues) ? (obj.issues as unknown[]).length : 0,
|
|
111
|
+
});
|
|
112
|
+
}
|
|
113
|
+
|
|
114
|
+
if (obj) {
|
|
115
|
+
logInfo(this.agent.name, `Parsed JSON successfully, verdict: ${obj.verdict ?? "N/A"}`);
|
|
116
|
+
} else {
|
|
117
|
+
logWarn(this.agent.name, "Failed to parse JSON from output");
|
|
118
|
+
}
|
|
119
|
+
}
|
|
120
|
+
|
|
121
|
+
/** Log subprocess execution results */
|
|
122
|
+
protected logSubprocessResult(result: ExecResult, raw: string, err: string): void {
|
|
123
|
+
logDebug(this.agent.name, `Exit code: ${result.exitCode}`);
|
|
124
|
+
logDebug(this.agent.name, `stdout length: ${raw.length} chars`);
|
|
125
|
+
if (err) logDebug(this.agent.name, `stderr: ${err.slice(0, 500)}`);
|
|
126
|
+
|
|
127
|
+
// Debug logging
|
|
128
|
+
if (this.contextPath) {
|
|
129
|
+
debugRaw(this.contextPath, this.sessionName, `agent:${this.agent.name}`, "stdout", raw);
|
|
130
|
+
if (err) {
|
|
131
|
+
debugRaw(this.contextPath, this.sessionName, `agent:${this.agent.name}`, "stderr", err);
|
|
132
|
+
}
|
|
133
|
+
debugLog(this.contextPath, this.sessionName, `agent:${this.agent.name}`, "subprocess_info", {
|
|
134
|
+
exit_code: result.exitCode,
|
|
135
|
+
stdout_len: raw.length,
|
|
136
|
+
stderr_len: err.length,
|
|
137
|
+
model: this.agent.model,
|
|
138
|
+
provider: this.agent.provider,
|
|
139
|
+
timeout: this.timeout,
|
|
140
|
+
});
|
|
141
|
+
}
|
|
142
|
+
|
|
143
|
+
if (raw) logDebug(this.agent.name, `stdout preview: ${raw.slice(0, 500)}`);
|
|
144
|
+
}
|
|
145
|
+
|
|
146
|
+
/** Construct a T for error/skip/timeout scenarios. Subclasses define shape. */
|
|
147
|
+
protected abstract makeErrorResult(type: "skip" | "error", message: string): T;
|
|
148
|
+
|
|
149
|
+
/** Create skip result when CLI not found */
|
|
150
|
+
protected makeSkipResult(reason: string): T {
|
|
151
|
+
logWarn(this.agent.name, reason);
|
|
152
|
+
return this.makeErrorResult("skip", reason);
|
|
153
|
+
}
|
|
154
|
+
|
|
155
|
+
/** Parse JSON from CLI output */
|
|
156
|
+
protected abstract parseOutput(raw: string, result: ExecResult): Record<string, unknown> | null;
|
|
157
|
+
|
|
158
|
+
/**
|
|
159
|
+
* Template method - orchestrates the review flow.
|
|
160
|
+
* Subclasses override abstract methods to customize behavior.
|
|
161
|
+
*/
|
|
162
|
+
async review(plan: string): Promise<T> {
|
|
163
|
+
// 1. Find CLI executable
|
|
164
|
+
const cliPath = this.findCli();
|
|
165
|
+
if (!cliPath) {
|
|
166
|
+
return this.makeSkipResult(`${this.getCliName()} CLI not found on PATH`);
|
|
167
|
+
}
|
|
168
|
+
|
|
169
|
+
logDebug(this.agent.name, `Found ${this.getCliName()} CLI at: ${cliPath}`);
|
|
170
|
+
|
|
171
|
+
// 2. Build prompt and args (provider-specific)
|
|
172
|
+
const prompt = this.buildPrompt(plan);
|
|
173
|
+
const args = this.buildCliArgs();
|
|
174
|
+
|
|
175
|
+
logInfo(this.agent.name, `Running ${this.getCliName()} with model: ${this.agent.model}, timeout: ${this.timeout}s`);
|
|
176
|
+
|
|
177
|
+
// 3. Execute subprocess
|
|
178
|
+
const env = getInternalSubprocessEnv();
|
|
179
|
+
const result = await execFileAsync(cliPath, args, {
|
|
180
|
+
input: prompt,
|
|
181
|
+
timeout: this.timeout * 1000,
|
|
182
|
+
env: env as Record<string, string>,
|
|
183
|
+
maxBuffer: 10 * 1024 * 1024,
|
|
184
|
+
shell: process.platform === "win32",
|
|
185
|
+
});
|
|
186
|
+
|
|
187
|
+
// 4. Handle timeout
|
|
188
|
+
if (result.killed || result.signal === "SIGTERM") {
|
|
189
|
+
return this.handleTimeout();
|
|
190
|
+
}
|
|
191
|
+
|
|
192
|
+
// 5. Extract output (provider-specific)
|
|
193
|
+
const { raw, err } = this.extractOutput(result);
|
|
194
|
+
|
|
195
|
+
// 6. Handle exit errors
|
|
196
|
+
if (!raw && !err && result.exitCode !== 0) {
|
|
197
|
+
return this.handleExitError(result);
|
|
198
|
+
}
|
|
199
|
+
|
|
200
|
+
// 7. Log subprocess results
|
|
201
|
+
this.logSubprocessResult(result, raw, err);
|
|
202
|
+
|
|
203
|
+
// 8. Parse JSON output (provider-specific)
|
|
204
|
+
const obj = this.parseOutput(raw, result);
|
|
205
|
+
|
|
206
|
+
// 9. Log parsed result
|
|
207
|
+
this.logParsedResult(obj);
|
|
208
|
+
|
|
209
|
+
// 10. Coerce to result type T (provider-specific)
|
|
210
|
+
const coerced = this.coerceResult(obj, raw, err);
|
|
211
|
+
|
|
212
|
+
// 11. Cleanup (optional override)
|
|
213
|
+
await this.cleanup();
|
|
214
|
+
|
|
215
|
+
return coerced;
|
|
216
|
+
}
|
|
217
|
+
}
|
|
@@ -1,12 +1,12 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* Reviewers package — re-exports all reviewer implementations.
|
|
3
|
-
* See cc-native-plan-review-spec.md §4.9
|
|
4
|
-
*/
|
|
5
|
-
|
|
6
|
-
export { AgentReviewer, runAgentReview } from "./agent.js";
|
|
7
|
-
export { BaseCliAgent } from "./base/base-agent.js";
|
|
8
|
-
export { ClaudeAgent } from "./providers/claude-agent.js";
|
|
9
|
-
export { CodexAgent } from "./providers/codex-agent.js";
|
|
10
|
-
export { GeminiAgent } from "./providers/gemini-agent.js";
|
|
11
|
-
export type { Reviewer, ReviewerResult, ReviewOptions } from "./types.js";
|
|
12
|
-
export { makeResult } from "./types.js";
|
|
1
|
+
/**
|
|
2
|
+
* Reviewers package — re-exports all reviewer implementations.
|
|
3
|
+
* See cc-native-plan-review-spec.md §4.9
|
|
4
|
+
*/
|
|
5
|
+
|
|
6
|
+
export { AgentReviewer, runAgentReview } from "./agent.js";
|
|
7
|
+
export { BaseCliAgent } from "./base/base-agent.js";
|
|
8
|
+
export { ClaudeAgent } from "./providers/claude-agent.js";
|
|
9
|
+
export { CodexAgent } from "./providers/codex-agent.js";
|
|
10
|
+
export { GeminiAgent } from "./providers/gemini-agent.js";
|
|
11
|
+
export type { Reviewer, ReviewerResult, ReviewOptions } from "./types.js";
|
|
12
|
+
export { makeResult } from "./types.js";
|