aidevops 2.52.1

package/.agent/scripts/pre-commit-hook.sh

@@ -0,0 +1,259 @@
+#!/bin/bash
+# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
+# Pre-commit hook for multi-platform quality validation
+# Install with: cp .agent/scripts/pre-commit-hook.sh .git/hooks/pre-commit && chmod +x .git/hooks/pre-commit
+
+set -euo pipefail
+
+# Color codes for output
+readonly RED='\033[0;31m'
+readonly GREEN='\033[0;32m'
+readonly YELLOW='\033[1;33m'
+readonly BLUE='\033[0;34m'
+readonly NC='\033[0m' # No Color
+
+print_success() {
+    local message="$1"
+    echo -e "${GREEN}✅ $message${NC}"
+    return 0
+}
+
+print_warning() {
+    local message="$1"
+    echo -e "${YELLOW}⚠️  $message${NC}"
+    return 0
+}
+
+print_error() {
+    local message="$1"
+    echo -e "${RED}❌ $message${NC}"
+    return 0
+}
+
+print_info() {
+    local message="$1"
+    echo -e "${BLUE}ℹ️  $message${NC}"
+    return 0
+}
+
+# Get list of modified shell files
+get_modified_shell_files() {
+    git diff --cached --name-only --diff-filter=ACM | grep '\.sh$' || true
+    return 0
+}
+
+validate_return_statements() {
+    local violations=0
+    
+    print_info "Validating return statements..."
+    
+    for file in "$@"; do
+        if [[ -f "$file" ]]; then
+            # Check for functions without return statements
+            local functions
+            functions=$(grep -c "^[a-zA-Z_][a-zA-Z0-9_]*() {" "$file" || echo "0")
+            local returns
+            returns=$(grep -c "return [01]" "$file" || echo "0")
+            
+            if [[ $functions -gt 0 && $returns -lt $functions ]]; then
+                print_error "Missing return statements in $file"
+                ((violations++))
+            fi
+        fi
+    done
+    
+    return $violations
+}
+
+validate_positional_parameters() {
+    local violations=0
+
+    print_info "Validating positional parameters..."
+
+    for file in "$@"; do
+        if [[ -f "$file" ]] && grep -n '\$[1-9]' "$file" | grep -v 'local.*=.*\$[1-9]' > /dev/null; then
+            print_error "Direct positional parameter usage in $file"
+            grep -n '\$[1-9]' "$file" | grep -v 'local.*=.*\$[1-9]' | head -3
+            ((violations++))
+        fi
+    done
+    
+    return $violations
+}
+
+validate_string_literals() {
+    local violations=0
+
+    print_info "Validating string literals..."
+
+    for file in "$@"; do
+        if [[ -f "$file" ]]; then
+            # Check for repeated string literals
+            local repeated
+            repeated=$(grep -o '"[^"]*"' "$file" | sort | uniq -c | awk '$1 >= 3' | wc -l || echo "0")
+            
+            if [[ $repeated -gt 0 ]]; then
+                print_warning "Repeated string literals in $file (consider using constants)"
+                grep -o '"[^"]*"' "$file" | sort | uniq -c | awk '$1 >= 3 {print "  " $1 "x: " $2}' | head -3
+                ((violations++))
+            fi
+        fi
+    done
+    
+    return $violations
+}
+
+run_shellcheck() {
+    local violations=0
+
+    print_info "Running ShellCheck validation..."
+
+    for file in "$@"; do
+        if [[ -f "$file" ]] && ! shellcheck "$file"; then
+            print_error "ShellCheck violations in $file"
+            ((violations++))
+        fi
+    done
+    
+    return $violations
+}
+
+check_secrets() {
+    local violations=0
+    
+    print_info "Checking for exposed secrets (Secretlint)..."
+    
+    # Get staged files
+    local staged_files
+    staged_files=$(git diff --cached --name-only --diff-filter=ACMR | tr '\n' ' ')
+    
+    if [[ -z "$staged_files" ]]; then
+        print_info "No files to check for secrets"
+        return 0
+    fi
+    
+    # Check if secretlint is available
+    if command -v secretlint &> /dev/null; then
+        if echo "$staged_files" | xargs secretlint --format compact 2>/dev/null; then
+            print_success "No secrets detected in staged files"
+        else
+            print_error "Potential secrets detected in staged files!"
+            print_info "Review the findings and either:"
+            print_info "  1. Remove the secrets from your code"
+            print_info "  2. Add to .secretlintignore if false positive"
+            print_info "  3. Use // secretlint-disable-line comment"
+            ((violations++))
+        fi
+    elif [[ -f "node_modules/.bin/secretlint" ]]; then
+        if echo "$staged_files" | xargs ./node_modules/.bin/secretlint --format compact 2>/dev/null; then
+            print_success "No secrets detected in staged files"
+        else
+            print_error "Potential secrets detected in staged files!"
+            ((violations++))
+        fi
+    elif command -v npx &> /dev/null && [[ -f ".secretlintrc.json" ]]; then
+        if echo "$staged_files" | xargs npx secretlint --format compact 2>/dev/null; then
+            print_success "No secrets detected in staged files"
+        else
+            print_error "Potential secrets detected in staged files!"
+            ((violations++))
+        fi
+    else
+        print_warning "Secretlint not available (install: npm install secretlint --save-dev)"
+    fi
+    
+    return $violations
+}
+
+check_quality_standards() {
+    print_info "Checking current quality standards..."
+    
+    # Check SonarCloud status if curl is available
+    if command -v curl &> /dev/null && command -v jq &> /dev/null; then
+        local response
+        if response=$(curl -s --max-time 10 "https://sonarcloud.io/api/issues/search?componentKeys=marcusquinn_aidevops&impactSoftwareQualities=MAINTAINABILITY&resolved=false&ps=1" 2>/dev/null); then
+            local total_issues
+            total_issues=$(echo "$response" | jq -r '.total // 0' 2>/dev/null || echo "unknown")
+
+            if [[ "$total_issues" != "unknown" ]]; then
+                print_info "Current SonarCloud issues: $total_issues"
+
+                if [[ $total_issues -gt 200 ]]; then
+                    print_warning "High issue count detected. Consider running quality fixes."
+                fi
+            fi
+        fi
+    fi
+    return 0
+}
+
+main() {
+    echo -e "${BLUE}🎯 Pre-commit Quality Validation${NC}"
+    echo -e "${BLUE}================================${NC}"
+    
+    # Get modified shell files
+    local modified_files
+    mapfile -t modified_files < <(get_modified_shell_files)
+    
+    if [[ ${#modified_files[@]} -eq 0 ]]; then
+        print_info "No shell files modified, skipping quality checks"
+        return 0
+    fi
+    
+    print_info "Checking ${#modified_files[@]} modified shell files:"
+    printf '  %s\n' "${modified_files[@]}"
+    echo ""
+    
+    local total_violations=0
+    
+    # Run validation checks
+    validate_return_statements "${modified_files[@]}" || ((total_violations += $?))
+    echo ""
+    
+    validate_positional_parameters "${modified_files[@]}" || ((total_violations += $?))
+    echo ""
+    
+    validate_string_literals "${modified_files[@]}" || ((total_violations += $?))
+    echo ""
+    
+    run_shellcheck "${modified_files[@]}" || ((total_violations += $?))
+    echo ""
+    
+    check_secrets || ((total_violations += $?))
+    echo ""
+    
+    check_quality_standards
+    echo ""
+
+    # Optional CodeRabbit CLI review (if available)
+    if [[ -f ".agent/scripts/coderabbit-cli.sh" ]] && command -v coderabbit &> /dev/null; then
+        print_info "🤖 Running CodeRabbit CLI review..."
+        if bash .agent/scripts/coderabbit-cli.sh review > /dev/null 2>&1; then
+            print_success "CodeRabbit CLI review completed"
+        else
+            print_info "CodeRabbit CLI review skipped (setup required)"
+        fi
+        echo ""
+    fi
+
+    # Final decision
+    if [[ $total_violations -eq 0 ]]; then
+        print_success "🎉 All quality checks passed! Commit approved."
+        return 0
+    else
+        print_error "❌ Quality violations detected ($total_violations total)"
+        echo ""
+        print_info "To fix issues automatically, run:"
+        print_info "  ./.agent/scripts/quality-fix.sh"
+        echo ""
+        print_info "To check current status, run:"
+        print_info "  ./.agent/scripts/linters-local.sh"
+        echo ""
+        print_info "To bypass this check (not recommended), use:"
+        print_info "  git commit --no-verify"
+
+        return 1
+    fi
+}
+
+main "$@"

package/.agent/scripts/pre-edit-check.sh

@@ -0,0 +1,169 @@
+#!/bin/bash
+# =============================================================================
+# Pre-Edit Git Branch Check
+# =============================================================================
+# Run this BEFORE any file edit to enforce the git workflow.
+# Returns exit code 1 if on main/master branch (should create branch first).
+#
+# Usage:
+#   ~/.aidevops/agents/scripts/pre-edit-check.sh
+#   ~/.aidevops/agents/scripts/pre-edit-check.sh --loop-mode --task "description"
+#
+# Exit codes:
+#   0 - OK to proceed (on feature branch, or docs-only on main in loop mode)
+#   1 - STOP (on protected branch, interactive mode)
+#   2 - Create worktree (loop mode detected code task on main)
+#
+# AI assistants should call this before any Edit/Write tool and STOP if it
+# returns a warning about being on main branch.
+# =============================================================================
+
+set -euo pipefail
+
+# =============================================================================
+# Loop Mode Support
+# =============================================================================
+# When --loop-mode is passed, the script auto-decides based on task description:
+# - Docs-only tasks (README, CHANGELOG, docs/) -> stay on main (exit 0)
+# - Code tasks (feature, fix, implement, etc.) -> signal worktree needed (exit 2)
+
+LOOP_MODE=false
+TASK_DESC=""
+
+while [[ $# -gt 0 ]]; do
+    case $1 in
+        --loop-mode)
+            LOOP_MODE=true
+            shift
+            ;;
+        --task)
+            TASK_DESC="$2"
+            shift 2
+            ;;
+        *)
+            shift
+            ;;
+    esac
+done
+
+# Function to detect if task is docs-only
+is_docs_only() {
+    local task="$1"
+    # Use tr for lowercase (portable across bash versions including macOS default bash 3.x)
+    local task_lower
+    task_lower=$(echo "$task" | tr '[:upper:]' '[:lower:]')
+    
+    # Code change indicators (negative match - if present, NOT docs-only)
+    # These take precedence over docs patterns
+    local code_patterns="feature|fix|bug|implement|refactor|add.*function|update.*code|create.*script|modify.*config|change.*logic|new.*api|endpoint|enhance|port|ssl|helper"
+    
+    # Docs-only indicators (positive match)
+    local docs_patterns="^readme|^changelog|^documentation|docs/|typo|spelling|comment only|license only|^update readme|^update changelog|^update docs"
+    
+    # Check for code patterns first (takes precedence)
+    if echo "$task_lower" | grep -qE "$code_patterns"; then
+        return 1  # Not docs-only
+    fi
+    
+    # Check for docs patterns
+    if echo "$task_lower" | grep -qE "$docs_patterns"; then
+        return 0  # Is docs-only
+    fi
+    
+    # Default: not docs-only (safer to create branch)
+    return 1
+}
+
+# Colors
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+BOLD='\033[1m'
+NC='\033[0m'
+
+# Check if we're in a git repository
+if ! git rev-parse --is-inside-work-tree &>/dev/null; then
+    echo -e "${YELLOW}Not in a git repository - no branch check needed${NC}"
+    exit 0
+fi
+
+# Get current branch
+current_branch=$(git branch --show-current 2>/dev/null || echo "")
+
+if [[ -z "$current_branch" ]]; then
+    echo -e "${YELLOW}Detached HEAD state - consider creating a branch${NC}"
+    exit 0
+fi
+
+# Check if on main or master
+if [[ "$current_branch" == "main" || "$current_branch" == "master" ]]; then
+    # Loop mode: auto-decide based on task description
+    if [[ "$LOOP_MODE" == "true" ]]; then
+        if is_docs_only "$TASK_DESC"; then
+            echo -e "${YELLOW}LOOP-AUTO${NC}: Docs-only task detected, staying on $current_branch"
+            echo "LOOP_DECISION=stay"
+            exit 0
+        else
+            # Auto-create worktree for code changes
+            echo -e "${YELLOW}LOOP-AUTO${NC}: Code task detected, worktree required"
+            echo "LOOP_DECISION=worktree"
+            exit 2  # Special exit code for "create worktree"
+        fi
+    fi
+    
+    # Interactive mode: show warning and exit
+    echo ""
+    echo -e "${RED}${BOLD}======================================================${NC}"
+    echo -e "${RED}${BOLD}  STOP - ON PROTECTED BRANCH: $current_branch${NC}"
+    echo -e "${RED}${BOLD}======================================================${NC}"
+    echo ""
+    echo -e "${YELLOW}You must create a branch before making changes.${NC}"
+    echo ""
+    echo "Suggested branch names based on change type:"
+    echo "  feature/description  - New functionality"
+    echo "  bugfix/description   - Bug fixes"
+    echo "  chore/description    - Maintenance, docs, config"
+    echo "  hotfix/description   - Urgent production fixes"
+    echo "  refactor/description - Code restructuring"
+    echo ""
+    echo -e "${BOLD}Create a worktree (keeps main repo on main):${NC}"
+    echo ""
+    echo "    ~/.aidevops/agents/scripts/worktree-helper.sh add {type}/{description}"
+    echo "    cd ../{repo}-{type}-{description}"
+    echo ""
+    echo -e "${YELLOW}Why worktrees? The main repo directory should ALWAYS stay on main.${NC}"
+    echo -e "${YELLOW}Using 'git checkout -b' here leaves the repo on a feature branch,${NC}"
+    echo -e "${YELLOW}which breaks parallel sessions and causes merge conflicts.${NC}"
+    echo ""
+    echo -e "${RED}DO NOT proceed with edits until on a feature branch.${NC}"
+    echo ""
+    exit 1
+else
+    # Check if this is the main repo directory (not a worktree) on a feature branch
+    # This is a warning - the main repo should stay on main
+    git_common_dir=$(git rev-parse --git-common-dir 2>/dev/null)
+    git_dir=$(git rev-parse --git-dir 2>/dev/null)
+    
+    # If git-dir equals git-common-dir, this is the main worktree (not a linked worktree)
+    is_main_worktree=false
+    if [[ "$git_dir" == "$git_common_dir" ]] || [[ "$git_dir" == ".git" ]]; then
+        is_main_worktree=true
+    fi
+    
+    if [[ "$is_main_worktree" == "true" ]]; then
+        echo -e "${YELLOW}WARNING${NC} - Main repo is on feature branch: ${BOLD}$current_branch${NC}"
+        echo -e "${YELLOW}The main repo directory should stay on 'main' for parallel safety.${NC}"
+        echo -e "${YELLOW}Consider using a worktree instead, or switch back to main when done.${NC}"
+        echo ""
+    else
+        echo -e "${GREEN}OK${NC} - On branch: ${BOLD}$current_branch${NC}"
+    fi
+    
+    # Sync terminal tab title with repo/branch (silent, non-blocking)
+    SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit
+    if [[ -x "$SCRIPT_DIR/terminal-title-helper.sh" ]]; then
+        "$SCRIPT_DIR/terminal-title-helper.sh" sync 2>/dev/null || true
+    fi
+    
+    exit 0
+fi