aidevops 2.52.1

package/.agent/scripts/commands/remember.md

@@ -0,0 +1,132 @@
+---
+description: Store a memory entry for cross-session recall
+agent: Build+
+mode: subagent
+---
+
+Store knowledge, patterns, or learnings for future sessions.
+
+Content to remember: $ARGUMENTS
+
+## Memory Types
+
+| Type | Use For | Example |
+|------|---------|---------|
+| `WORKING_SOLUTION` | Fixes that worked | "Fixed CORS by adding headers to nginx" |
+| `FAILED_APPROACH` | What didn't work (avoid repeating) | "Don't use sync fs in Lambda" |
+| `CODEBASE_PATTERN` | Project conventions | "All API routes use /api/v1 prefix" |
+| `USER_PREFERENCE` | Developer preferences | "Prefers tabs over spaces" |
+| `TOOL_CONFIG` | Tool setup notes | "SonarCloud needs SONAR_TOKEN in CI" |
+| `DECISION` | Architecture decisions | "Chose SQLite over Postgres for simplicity" |
+| `CONTEXT` | Background info | "Legacy API deprecated in Q3" |
+
+## Workflow
+
+### Step 1: Analyze Content
+
+From the conversation or $ARGUMENTS, extract:
+- **Content**: What to remember (concise, actionable)
+- **Type**: Best matching type from above
+- **Tags**: Relevant keywords (comma-separated)
+- **Project**: Current project name (optional)
+
+### Step 2: Confirm with User
+
+```text
+Storing memory:
+
+Type: {type}
+Content: "{content}"
+Tags: {tags}
+Project: {project or "global"}
+
+1. Confirm
+2. Change type
+3. Edit content
+4. Cancel
+```
+
+### Step 3: Store Memory
+
+After confirmation, run:
+
+```bash
+~/.aidevops/agents/scripts/memory-helper.sh store --type "{type}" --content "{content}" --tags "{tags}" --project "{project}"
+```
+
+### Step 4: Confirm Storage
+
+```text
+Remembered: "{content}" ({type})
+Tags: {tags}
+
+Recall anytime with: /recall {keyword}
+```
+
+## Examples
+
+**Storing a working solution:**
+
+```text
+User: /remember The CORS fix was adding Access-Control-Allow-Origin to nginx.conf
+AI: Storing memory:
+    Type: WORKING_SOLUTION
+    Content: "Fixed CORS by adding Access-Control-Allow-Origin header to nginx.conf location block"
+    Tags: cors,nginx,headers
+    Project: api-gateway
+    
+    1. Confirm  2. Change type  3. Edit  4. Cancel
+User: 1
+AI: Remembered: "Fixed CORS by adding..." (WORKING_SOLUTION)
+    Recall anytime with: /recall cors
+```
+
+**Storing a failed approach:**
+
+```text
+User: /remember Don't use moment.js - it's huge and deprecated
+AI: Storing memory:
+    Type: FAILED_APPROACH
+    Content: "Avoid moment.js - large bundle size (300KB+) and deprecated. Use date-fns or dayjs instead"
+    Tags: javascript,dates,bundle-size
+    Project: global
+    
+    1. Confirm  2. Change type  3. Edit  4. Cancel
+User: 1
+AI: Remembered: "Avoid moment.js..." (FAILED_APPROACH)
+```
+
+**Storing a user preference:**
+
+```text
+User: /remember I prefer conventional commits
+AI: Storing memory:
+    Type: USER_PREFERENCE
+    Content: "Use conventional commit format: type(scope): description"
+    Tags: git,commits,style
+    Project: global
+    
+    1. Confirm  2. Change type  3. Edit  4. Cancel
+```
+
+## Auto-Remember Triggers
+
+AI assistants should proactively suggest `/remember` when:
+
+1. A solution is found after debugging
+2. User explicitly states a preference
+3. A workaround is discovered for a tool limitation
+4. An architecture decision is made
+5. A failed approach is identified
+
+```text
+AI: That fixed it! Want me to remember this solution for future sessions?
+    /remember {suggested content}
+```
+
+## Storage Location
+
+Memories are stored in SQLite with FTS5 for fast search:
+`~/.aidevops/.agent-workspace/memory/memory.db`
+
+View stats: `~/.aidevops/agents/scripts/memory-helper.sh stats`

package/.agent/scripts/commands/save-todo.md

@@ -0,0 +1,175 @@
+---
+description: Save current discussion as task or plan (auto-detects complexity)
+agent: Plan+
+mode: subagent
+---
+
+Analyze the current conversation and save appropriately based on complexity.
+
+Topic/context: $ARGUMENTS
+
+## Auto-Detection Logic
+
+Analyze the conversation for complexity signals:
+
+| Signal | Indicates | Action |
+|--------|-----------|--------|
+| Single action item | Simple | TODO.md only |
+| < 2 hour estimate | Simple | TODO.md only |
+| User says "quick" or "simple" | Simple | TODO.md only |
+| Multiple distinct steps | Complex | PLANS.md + TODO.md |
+| Research/design needed | Complex | PLANS.md + TODO.md |
+| > 2 hour estimate | Complex | PLANS.md + TODO.md |
+| Multi-session work | Complex | PLANS.md + TODO.md |
+| PRD mentioned or needed | Complex | PLANS.md + TODO.md + PRD |
+
+## Workflow
+
+### Step 1: Analyze Conversation
+
+Extract from the discussion:
+- **Title**: Concise task/plan name
+- **Description**: What needs to be done
+- **Estimate**: Time estimate with breakdown `~Xh (ai:Xh test:Xh read:Xm)`
+- **Tags**: Relevant categories (#seo, #security, #feature, etc.)
+- **Context**: Key decisions, research findings, constraints discussed
+
+### Step 2: Determine Complexity
+
+Based on signals above, classify as Simple or Complex.
+
+### Step 3: Save with Confirmation
+
+**For Simple tasks** (TODO.md only):
+
+```text
+Saving to TODO.md: "{title}" ~{estimate}
+
+1. Confirm
+2. Add more details first
+3. Create full plan instead (PLANS.md)
+```
+
+After confirmation, add to TODO.md Backlog:
+
+```markdown
+- [ ] {title} #{tag} ~{estimate} logged:{YYYY-MM-DD}
+```
+
+Respond:
+
+```text
+Saved: "{title}" to TODO.md (~{estimate})
+Start anytime with: "Let's work on {title}"
+```
+
+**For Complex work** (PLANS.md + TODO.md):
+
+```text
+This looks like complex work. Creating execution plan.
+
+Title: {title}
+Estimate: ~{estimate}
+Phases: {count} identified
+
+1. Confirm and create plan
+2. Simplify to TODO.md only
+3. Add more context first
+```
+
+After confirmation:
+
+1. Create entry in `todo/PLANS.md`:
+
+```markdown
+### [{YYYY-MM-DD}] {Title}
+
+**Status:** Planning
+**Estimate:** ~{estimate}
+**PRD:** [todo/tasks/prd-{slug}.md](tasks/prd-{slug}.md) (if needed)
+**Tasks:** [todo/tasks/tasks-{slug}.md](tasks/tasks-{slug}.md) (if needed)
+
+#### Purpose
+
+{Why this work matters - from conversation context}
+
+#### Progress
+
+- [ ] ({timestamp}) Phase 1: {description} ~{est}
+- [ ] ({timestamp}) Phase 2: {description} ~{est}
+
+#### Context from Discussion
+
+{Key decisions, research findings, constraints from conversation}
+
+#### Decision Log
+
+(To be populated during implementation)
+
+#### Surprises & Discoveries
+
+(To be populated during implementation)
+```
+
+2. Add reference to TODO.md Backlog:
+
+```markdown
+- [ ] {title} #plan → [todo/PLANS.md#{slug}] ~{estimate} logged:{YYYY-MM-DD}
+```
+
+3. Optionally create PRD/tasks files if scope warrants
+
+Respond:
+
+```text
+Saved: "{title}"
+- Plan: todo/PLANS.md
+- Reference: TODO.md
+{- PRD: todo/tasks/prd-{slug}.md (if created)}
+{- Tasks: todo/tasks/tasks-{slug}.md (if created)}
+
+Start anytime with: "Let's work on {title}"
+```
+
+## Context Preservation
+
+Always capture from the conversation:
+- Decisions made and their rationale
+- Research findings
+- Constraints identified
+- Open questions
+- Related links or references mentioned
+
+This context goes into the PLANS.md entry under "Context from Discussion" so future sessions have full context.
+
+## Examples
+
+**Simple task:**
+
+```text
+User: We discussed adding a CSV export button
+AI: Saving to TODO.md: "Add CSV export button" ~2h (ai:1.5h test:30m)
+    1. Confirm  2. More details  3. Full plan
+User: 1
+AI: Saved: "Add CSV export button" to TODO.md (~2h)
+    Start anytime with: "Let's work on CSV export"
+```
+
+**Complex work:**
+
+```text
+User: We discussed the authentication overhaul with OAuth, session management, and migration
+AI: This looks like complex work. Creating execution plan.
+    Title: Authentication Overhaul
+    Estimate: ~2w (ai:1w test:0.5w read:0.5w)
+    Phases: 4 identified (OAuth, sessions, migration, testing)
+    
+    1. Confirm and create plan  2. Simplify to TODO.md  3. Add context
+User: 1
+AI: Saved: "Authentication Overhaul"
+    - Plan: todo/PLANS.md
+    - Reference: TODO.md
+    - PRD: todo/tasks/prd-auth-overhaul.md
+    
+    Start anytime with: "Let's work on auth overhaul"
+```

package/.agent/scripts/commands/session-review.md

@@ -0,0 +1,154 @@
+---
+description: Review session for completeness, best practices, and knowledge capture
+agent: Build+
+mode: subagent
+---
+
+Review the current session for completeness and aidevops workflow adherence.
+
+Focus area: $ARGUMENTS
+
+## Review Process
+
+### Step 1: Gather Context
+
+Run the helper script to collect session data:
+
+```bash
+~/.aidevops/agents/scripts/session-review-helper.sh gather
+```
+
+### Step 2: Analyze Objectives
+
+Review what was accomplished in this session:
+
+1. **Initial Request**: What did the user originally ask for?
+2. **Branch Purpose**: Does the branch name reflect the work done?
+3. **Commits Made**: Do commits align with the objective?
+4. **Outstanding Items**: What remains incomplete?
+
+Calculate completion score:
+- 100%: All objectives met, no outstanding items
+- 75-99%: Primary objective met, minor items remain
+- 50-74%: Partial completion, significant work remains
+- <50%: Major objectives incomplete
+
+### Step 3: Check Workflow Adherence
+
+Verify aidevops best practices:
+
+| Practice | Check | Required |
+|----------|-------|----------|
+| Feature branch | Not on main/master | Yes |
+| Pre-edit check | Ran before first edit | Yes |
+| Atomic commits | Each commit is focused | Yes |
+| TODO tracking | Tasks logged appropriately | Recommended |
+| Quality checks | Linters run before commit | Recommended |
+
+### Step 4: Identify Knowledge to Capture
+
+Look for learnings that should be preserved:
+
+1. **Corrections Made**: Did the AI make mistakes that were corrected?
+2. **New Patterns**: Were new approaches discovered?
+3. **Tool Issues**: Did any tools not work as expected?
+4. **User Preferences**: Did the user express preferences?
+
+For each learning, suggest where to document:
+- Agent improvements → `@agent-review`
+- Code patterns → Code comments or docs
+- User preferences → `memory/` files
+- Temporary workarounds → TODO.md
+
+### Step 5: Session Health Assessment
+
+Determine recommendation:
+
+**End Session When:**
+- All objectives complete
+- PR merged
+- Blocked on external factors
+- Context becoming stale (long session)
+- Topic shift to unrelated work
+
+**Continue Session When:**
+- More work in scope
+- User wants to continue
+- Related follow-up tasks
+
+**Start New Session For:**
+- Unrelated topics
+- Clean context needed
+- Parallel work on different branch
+
+## Output Format
+
+```text
+# Session Review
+
+**Branch**: {branch-name}
+**Duration**: {approximate}
+**Date**: {YYYY-MM-DD}
+
+---
+
+## Objective Completion: {score}%
+
+### Completed
+- [x] {item 1}
+- [x] {item 2}
+
+### Outstanding
+- [ ] {item} - {reason/next step}
+
+---
+
+## Workflow Adherence
+
+### Followed
+- [x] {practice}
+
+### Improvements Needed
+- [ ] {practice} - {recommendation}
+
+---
+
+## Knowledge Capture
+
+### Should Document
+- {learning}: {suggested location}
+
+### Action Items
+1. {specific action}
+
+---
+
+## Session Recommendation
+
+**Verdict**: {Continue | End Session | Start New Session}
+
+### Immediate Actions
+1. {action}
+
+### For Future Sessions
+- {topic}: suggest branch `{type}/{name}`
+
+---
+
+*Review generated by /session-review*
+```
+
+## Quick Review (Summary Only)
+
+For a quick status check without full analysis:
+
+```bash
+~/.aidevops/agents/scripts/session-review-helper.sh summary
+```
+
+## Integration Points
+
+- **Before PR**: Run to ensure nothing forgotten
+- **Before ending session**: Capture learnings
+- **After Ralph loop**: Verify completion promise was truly met
+- **On topic shift**: Decide whether to continue or start fresh

package/.agent/scripts/comprehensive-quality-fix.sh

@@ -0,0 +1,106 @@
+#!/bin/bash
+# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
+
+# Comprehensive script to fix remaining SonarCloud issues
+# Targets: S7679 (positional parameters), S7682 (return statements), S1192 (string literals)
+
+cd providers || exit
+
+echo "🚀 Starting comprehensive quality fix..."
+
+# Function to fix misplaced return statements
+fix_misplaced_returns() {
+    local file="$1"
+    echo "Fixing misplaced returns in $file..."
+    
+    # Remove return statements that are not at the end of functions
+    sed -i '/^    return 0$/d' "$file"
+    
+    # Add return statements to function endings that need them
+    # This is a more targeted approach based on SonarCloud line numbers
+    return 0
+}
+
+# Function to replace string literals with constants
+replace_string_literals() {
+    local file="$1"
+    echo "Replacing string literals in $file..."
+    
+    case "$file" in
+        "mainwp-helper.sh")
+            # Replace remaining "Site ID is required" occurrences
+            sed -i 's/"Site ID is required"/"$ERROR_SITE_ID_REQUIRED"/g' "$file"
+            sed -i 's/"At least one site ID is required"/"$ERROR_AT_LEAST_ONE_SITE_ID"/g' "$file"
+            ;;
+        "code-audit-helper.sh")
+            # Already done in previous commit
+            ;;
+        "dns-helper.sh")
+            # Replace remaining cloudflare occurrences in case statements
+            sed -i "s/\"namecheap\"/\"\$PROVIDER_NAMECHEAP\"/g" "$file"
+            sed -i "s/\"route53\"/\"\$PROVIDER_ROUTE53\"/g" "$file"
+            ;;
+        "git-platforms-helper.sh")
+            # Replace remaining platform occurrences
+            sed -i "s/\"gitea\"/\"\$PLATFORM_GITEA\"/g" "$file"
+            ;;
+        *)
+            echo "No string literal replacements needed for $file"
+            ;;
+    esac
+    return 0
+}
+
+# Function to add return statements to functions that need them
+add_missing_returns() {
+    local file="$1"
+    echo "Adding missing return statements to $file..."
+    
+    # Find function endings and add return statements
+    # This targets the specific line numbers from SonarCloud
+    case "$file" in
+        "closte-helper.sh")
+            # Lines 134, 249
+            sed -i '133a\    return 0' "$file"
+            sed -i '248a\    return 0' "$file"
+            ;;
+        "cloudron-helper.sh")
+            # Lines 74, 202
+            sed -i '73a\    return 0' "$file"
+            sed -i '201a\    return 0' "$file"
+            ;;
+        "coolify-helper.sh")
+            # Line 236
+            sed -i '235a\    return 0' "$file"
+            ;;
+        "dns-helper.sh")
+            # Lines 95, 259
+            sed -i '94a\    return 0' "$file"
+            sed -i '258a\    return 0' "$file"
+            ;;
+   
+        *)
+            echo "Unknown option: $file"
+            return 1
+            ;;
+    esac
+    return 0
+}
+
+# Process each file
+for file in *.sh; do
+    if [[ -f "$file" ]]; then
+        echo "Processing $file..."
+        
+        # Fix misplaced returns first
+        fix_misplaced_returns "$file"
+        
+        # Replace string literals
+        replace_string_literals "$file"
+        
+        # Add missing return statements
+        add_missing_returns "$file"
+    fi
+done
+
+echo "✅ Comprehensive quality fix completed!"