aidevops 2.52.1 → 2.53.2

package/.agent/scripts/fix-s131-default-cases.sh

@@ -1,249 +0,0 @@
-#!/bin/bash
-# shellcheck disable=SC2034,SC2155
-# Fix SonarCloud S131: Add default case (*) to case statements
-#
-# Usage: ./fix-s131-default-cases.sh [--dry-run] [--file <path>] [--all]
-#
-# This script finds case statements missing a default (*) case and adds one.
-
-set -euo pipefail
-
-# Colors
-readonly GREEN='\033[0;32m'
-readonly BLUE='\033[0;34m'
-readonly YELLOW='\033[1;33m'
-readonly RED='\033[0;31m'
-readonly NC='\033[0m'
-
-print_info() { echo -e "${BLUE}[INFO]${NC} $1"; return 0; }
-print_success() { echo -e "${GREEN}[SUCCESS]${NC} $1"; return 0; }
-print_warning() { echo -e "${YELLOW}[WARNING]${NC} $1"; return 0; }
-print_error() { echo -e "${RED}[ERROR]${NC} $1" >&2; return 0; }
-
-DRY_RUN=false
-TARGET_FILE=""
-FIX_ALL=false
-SCRIPTS_DIR=".agent/scripts"
-
-# Parse arguments
-while [[ $# -gt 0 ]]; do
-    case "$1" in
-        --dry-run)
-            DRY_RUN=true
-            shift
-            ;;
-        --file)
-            TARGET_FILE="$2"
-            shift 2
-            ;;
-        --all)
-            FIX_ALL=true
-            shift
-            ;;
-        --help|-h)
-            echo "Usage: $0 [--dry-run] [--file <path>] [--all]"
-            echo ""
-            echo "Options:"
-            echo "  --dry-run    Show what would be fixed without making changes"
-            echo "  --file PATH  Fix only the specified file"
-            echo "  --all        Fix all shell scripts in $SCRIPTS_DIR"
-            echo "  --help       Show this help"
-            exit 0
-            ;;
-        *)
-            print_error "Unknown option: $1"
-            exit 1
-            ;;
-    esac
-done
-
-# Find case statements missing default case
-# Returns: filename:line_number for each violation
-find_missing_defaults() {
-    local file="$1"
-    
-    # Use awk to find case statements and check if they have a default
-    awk '
-    BEGIN { in_case = 0; case_line = 0; has_default = 0; depth = 0 }
-    
-    # Track case statement start
-    /^[[:space:]]*case[[:space:]]/ {
-        if (in_case == 0) {
-            in_case = 1
-            case_line = NR
-            has_default = 0
-            depth = 1
-        }
-    }
-    
-    # Track nested case (increment depth)
-    in_case && /^[[:space:]]*case[[:space:]]/ && NR != case_line {
-        depth++
-    }
-    
-    # Check for default case pattern
-    in_case && depth == 1 && /^[[:space:]]*\*\)/ {
-        has_default = 1
-    }
-    
-    # Also check for combined patterns like "help"|*)
-    in_case && depth == 1 && /\|\*\)/ {
-        has_default = 1
-    }
-    
-    # Track esac (end of case)
-    /^[[:space:]]*esac/ {
-        if (in_case) {
-            depth--
-            if (depth == 0) {
-                if (!has_default) {
-                    print FILENAME ":" case_line ":" NR
-                }
-                in_case = 0
-                has_default = 0
-            }
-        }
-    }
-    ' "$file"
-    return 0
-}
-
-# Add default case before esac
-add_default_case() {
-    local file="$1"
-    local esac_line="$2"
-    
-    # Detect indentation from the esac line
-    local indent
-    indent=$(sed -n "${esac_line}p" "$file" | sed 's/esac.*//' | cat -A | sed 's/\$$//')
-    indent=$(sed -n "${esac_line}p" "$file" | grep -o '^[[:space:]]*')
-    
-    # The case pattern should be indented more than esac
-    local case_indent="${indent}    "
-    
-    # Determine appropriate default action based on context
-    # Look at the previous case patterns to understand the context
-    local prev_lines
-    prev_lines=$(sed -n "$((esac_line-10)),$((esac_line-1))p" "$file")
-    
-    local default_action="# Default case - no action"
-    
-    # Check if this is a main() function argument parser
-    if echo "$prev_lines" | grep -qE '(--help|help\)|-h\))'; then
-        default_action="# Unknown option or default behavior"
-    fi
-    
-    # Check if previous cases use 'continue'
-    if echo "$prev_lines" | grep -qE '[[:space:]]continue[[:space:]]*;;'; then
-        default_action="# Process this item"
-    fi
-    
-    # Check if previous cases use 'return'
-    if echo "$prev_lines" | grep -qE '[[:space:]]return[[:space:]]'; then
-        default_action="# Default: continue execution"
-    fi
-    
-    # Insert the default case before esac
-    if [[ "$DRY_RUN" == "true" ]]; then
-        print_info "Would add default case at line $esac_line in $file"
-        echo "        *)
-            $default_action
-            ;;"
-    else
-        # Create temp file and insert default case
-        local temp_file
-        temp_file=$(mktemp)
-        
-        head -n $((esac_line - 1)) "$file" > "$temp_file"
-        {
-            echo "${case_indent}*)"
-            echo "${case_indent}    $default_action"
-            echo "${case_indent}    ;;"
-        } >> "$temp_file"
-        tail -n +"$esac_line" "$file" >> "$temp_file"
-        
-        mv "$temp_file" "$file"
-        print_success "Added default case at line $esac_line in $file"
-    fi
-    
-    return 0
-}
-
-# Process a single file
-process_file() {
-    local file="$1"
-    local violations
-    local count=0
-    local offset=0
-    
-    print_info "Processing: $file"
-    
-    # Find all violations (case_start_line:esac_line)
-    violations=$(find_missing_defaults "$file")
-    
-    if [[ -z "$violations" ]]; then
-        print_info "  No violations found"
-        return 0
-    fi
-    
-    # Process each violation (need to process from bottom to top to maintain line numbers)
-    local sorted_violations
-    sorted_violations=$(echo "$violations" | sort -t: -k3 -rn)
-    
-    while IFS=: read -r fname case_line esac_line; do
-        [[ -z "$esac_line" ]] && continue
-        
-        print_info "  Found case at line $case_line, esac at line $esac_line"
-        add_default_case "$file" "$esac_line"
-        ((count++))
-    done <<< "$sorted_violations"
-    
-    print_success "Fixed $count violation(s) in $file"
-    return 0
-}
-
-# Main execution
-main() {
-    local total_fixed=0
-    local files_processed=0
-    
-    print_info "SonarCloud S131 Fixer - Add default case to case statements"
-    echo ""
-    
-    if [[ "$DRY_RUN" == "true" ]]; then
-        print_warning "DRY RUN MODE - No changes will be made"
-        echo ""
-    fi
-    
-    if [[ -n "$TARGET_FILE" ]]; then
-        # Process single file
-        if [[ ! -f "$TARGET_FILE" ]]; then
-            print_error "File not found: $TARGET_FILE"
-            exit 1
-        fi
-        process_file "$TARGET_FILE"
-        
-    elif [[ "$FIX_ALL" == "true" ]]; then
-        # Process all shell scripts
-        print_info "Scanning all scripts in $SCRIPTS_DIR..."
-        echo ""
-        
-        while IFS= read -r -d '' file; do
-            process_file "$file"
-            ((files_processed++))
-            echo ""
-        done < <(find "$SCRIPTS_DIR" -name "*.sh" -type f -print0 | sort -z)
-        
-        print_success "Processed $files_processed files"
-        
-    else
-        print_error "Please specify --file <path> or --all"
-        echo "Use --help for usage information"
-        exit 1
-    fi
-    
-    return 0
-}
-
-main "$@"
-exit $?

package/.agent/scripts/fix-sc2155-simple.sh

@@ -1,102 +0,0 @@
-#!/bin/bash
-# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
-
-# Fix SC2155 Issues - Simple Approach
-# Fix "declare and assign separately" issues
-#
-# Author: AI DevOps Framework
-# Version: 1.1.1
-
-# Colors for output
-readonly GREEN='\033[0;32m'
-readonly BLUE='\033[0;34m'
-readonly NC='\033[0m'
-
-print_success() {
-    local _arg1="$1"
-    echo -e "${GREEN}✅ $_arg1${NC}"
-    return 0
-}
-
-print_info() {
-    local _arg1="$1"
-    echo -e "${BLUE}ℹ️  $_arg1${NC}"
-    return 0
-}
-
-# Fix SC2155 in a file using simple patterns
-fix_sc2155_simple() {
-    local file="$1"
-    local temp_file
-    temp_file=$(mktemp)
-    local changes_made=0
-    
-    print_info "Processing: $file"
-    
-    # Create backup
-    cp "$file" "${file}.backup"
-    
-    # Count SC2155 issues before
-    local before_count
-    before_count=$(shellcheck "$file" 2>&1 | grep -c "SC2155" || echo "0")
-    
-    if [[ $before_count -eq 0 ]]; then
-        rm "${file}.backup"
-        print_info "No SC2155 issues in: $file"
-        return 1
-    fi
-    
-    # Apply simple fixes using sed
-    sed '
-        # Fix: local var=$(command) -> local var; var=$(command)
-        s/^[[:space:]]*local[[:space:]]\+\([a-zA-Z_][a-zA-Z0-9_]*\)[[:space:]]*=[[:space:]]*\$(/local \1\n    \1=$(/
-        
-        # Fix: local var="$(command)" -> local var; var="$(command)"
-        s/^[[:space:]]*local[[:space:]]\+\([a-zA-Z_][a-zA-Z0-9_]*\)[[:space:]]*=[[:space:]]*"\$(/local \1\n    \1="$(/
-        
-        # Fix: local var=`command` -> local var; var=`command`
-        s/^[[:space:]]*local[[:space:]]\+\([a-zA-Z_][a-zA-Z0-9_]*\)[[:space:]]*=[[:space:]]*`/local \1\n    \1=`/
-    ' "$file" > "$temp_file"
-    
-    # Check if changes were made
-    if ! cmp -s "$file" "$temp_file"; then
-        mv "$temp_file" "$file"
-        changes_made=1
-        
-        # Count SC2155 issues after
-        local after_count
-        after_count=$(shellcheck "$file" 2>&1 | grep -c "SC2155" || echo "0")
-        
-        print_success "Fixed SC2155 in $file: $before_count → $after_count issues"
-        rm "${file}.backup"
-        return 0
-    else
-        rm "$temp_file"
-        mv "${file}.backup" "$file"
-        print_info "No fixable SC2155 patterns in: $file"
-        return 1
-    fi
-    return 0
-}
-
-# Main execution
-main() {
-    print_info "Fixing SC2155 issues in provider files..."
-    
-    local files_fixed=0
-    local files_processed=0
-    
-    for file in .agent/scripts/*.sh; do
-        if [[ -f "$file" ]]; then
-            ((files_processed++))
-            if fix_sc2155_simple "$file"; then
-                ((files_fixed++))
-            fi
-        fi
-    done
-    
-    print_success "Summary: $files_fixed/$files_processed files fixed"
-    return 0
-}
-
-main "$@"

package/.agent/scripts/fix-shellcheck-critical.sh

@@ -1,187 +0,0 @@
-#!/bin/bash
-# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
-
-# Fix Critical ShellCheck Issues
-# Address SC2155 (declare and assign separately) and SC2181 (exit code checking)
-#
-# Author: AI DevOps Framework
-# Version: 1.1.1
-
-# Colors for output
-readonly GREEN='\033[0;32m'
-readonly BLUE='\033[0;34m'
-readonly YELLOW='\033[1;33m'
-readonly NC='\033[0m'
-
-print_success() {
-    local _arg1="$1"
-    echo -e "${GREEN}✅ $_arg1${NC}"
-    return 0
-}
-
-print_info() {
-    local _arg1="$1"
-    echo -e "${BLUE}ℹ️  $_arg1${NC}"
-    return 0
-}
-
-print_warning() {
-    local _arg1="$1"
-    echo -e "${YELLOW}⚠️  $_arg1${NC}"
-    return 0
-}
-
-# Fix SC2155 issues in a file
-fix_sc2155_in_file() {
-    local file="$1"
-    local temp_file
-    temp_file=$(mktemp)
-    local changes_made=0
-    
-    # Create backup
-    cp "$file" "${file}.backup"
-    
-    # Fix common SC2155 patterns
-    awk '
-    {
-        line = $0
-        
-        # Pattern: local var=$(command)
-        if (match(line, /^[[:space:]]*local[[:space:]]+([a-zA-Z_][a-zA-Z0-9_]*)[[:space:]]*=[[:space:]]*\$\(/, arr)) {
-            var_name = substr(line, arr[1, "start"], arr[1, "length"])
-            assignment = substr(line, index(line, "=") + 1)
-            
-            # Split into declaration and assignment
-            indent = substr(line, 1, match(line, /[^[:space:]]/) - 1)
-            print indent "local " var_name
-            print indent var_name "=" assignment
-            next
-        }
-        
-        # Pattern: local var="$(command)"
-        if (match(line, /^[[:space:]]*local[[:space:]]+([a-zA-Z_][a-zA-Z0-9_]*)[[:space:]]*=[[:space:]]*"[[:space:]]*\$\(/, arr)) {
-            var_name = substr(line, arr[1, "start"], arr[1, "length"])
-            assignment = substr(line, index(line, "=") + 1)
-            
-            # Split into declaration and assignment
-            indent = substr(line, 1, match(line, /[^[:space:]]/) - 1)
-            print indent "local " var_name
-            print indent var_name "=" assignment
-            next
-        }
-        
-        print line
-    }
-    ' "$file" > "$temp_file"
-    
-    # Check if changes were made
-    if ! cmp -s "$file" "$temp_file"; then
-        mv "$temp_file" "$file"
-        changes_made=1
-    else
-        rm "$temp_file"
-    fi
-    
-    return $changes_made
-    return 0
-}
-
-# Fix SC2181 issues in a file
-fix_sc2181_in_file() {
-    local file="$1"
-    local temp_file
-    temp_file=$(mktemp)
-    local changes_made=0
-    
-    # Fix common SC2181 patterns
-    sed '
-        # Pattern: if [[ $? -eq 0 ]]
-        s/if \[\[ \$? -eq 0 \]\]/if [[ $? -eq 0 ]]/g
-        s/if \[ \$? -eq 0 \]/if [ $? -eq 0 ]/g
-        
-        # Pattern: if [[ $? -ne 0 ]]
-        s/if \[\[ \$? -ne 0 \]\]/if [[ $? -ne 0 ]]/g
-        s/if \[ \$? -ne 0 \]/if [ $? -ne 0 ]/g
-    ' "$file" > "$temp_file"
-    
-    # Check if changes were made
-    if ! cmp -s "$file" "$temp_file"; then
-        mv "$temp_file" "$file"
-        changes_made=1
-    else
-        rm "$temp_file"
-    fi
-    
-    return $changes_made
-    return 0
-}
-
-# Fix critical ShellCheck issues in a file
-fix_critical_shellcheck_in_file() {
-    local file="$1"
-    local sc2155_fixed=0
-    local sc2181_fixed=0
-    
-    print_info "Processing: $file"
-    
-    # Count issues before fixing
-    local sc2155_before
-    sc2155_before=$(shellcheck "$file" 2>&1 | grep -c "SC2155" || echo "0")
-    local sc2181_before
-    sc2181_before=$(shellcheck "$file" 2>&1 | grep -c "SC2181" || echo "0")
-    
-    if [[ $sc2155_before -gt 0 ]] && fix_sc2155_in_file "$file"; then
-        sc2155_fixed=1
-        print_success "Fixed SC2155 issues in $file"
-    fi
-    
-    if [[ $sc2181_before -gt 0 ]] && fix_sc2181_in_file "$file"; then
-        sc2181_fixed=1
-        print_success "Fixed SC2181 issues in $file"
-    fi
-    
-    # Count issues after fixing
-    local sc2155_after
-    sc2155_after=$(shellcheck "$file" 2>&1 | grep -c "SC2155" || echo "0")
-    local sc2181_after
-    sc2181_after=$(shellcheck "$file" 2>&1 | grep -c "SC2181" || echo "0")
-    
-    if [[ $sc2155_fixed -eq 1 || $sc2181_fixed -eq 1 ]]; then
-        print_success "Fixed critical ShellCheck issues in: $file"
-        print_info "SC2155: $sc2155_before → $sc2155_after, SC2181: $sc2181_before → $sc2181_after"
-        
-        # Remove backup if successful
-        rm -f "${file}.backup"
-        return 0
-    else
-        # Restore from backup if no changes
-        if [[ -f "${file}.backup" ]]; then
-            mv "${file}.backup" "$file"
-        fi
-        print_info "No critical ShellCheck issues fixed in: $file"
-        return 1
-    fi
-    return 0
-}
-
-# Main execution
-main() {
-    print_info "Fixing critical ShellCheck issues (SC2155, SC2181) in provider files..."
-    
-    local files_fixed=0
-    local files_processed=0
-    
-    for file in .agent/scripts/*.sh; do
-        if [[ -f "$file" ]]; then
-            ((files_processed++))
-            if fix_critical_shellcheck_in_file "$file"; then
-                ((files_fixed++))
-            fi
-        fi
-    done
-    
-    print_success "Summary: $files_fixed/$files_processed files fixed"
-    return 0
-}
-
-main "$@"