aidevops 2.52.1 → 2.53.2

package/.agent/scripts/fix-content-type.sh

@@ -1,100 +0,0 @@
-#!/bin/bash
-# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
-
-# Fix Content-Type String Literals
-# Replace repeated "Content-Type: application/json" with constants
-#
-# Author: AI DevOps Framework
-# Version: 1.1.1
-
-# Colors for output
-readonly GREEN='\033[0;32m'
-readonly BLUE='\033[0;34m'
-readonly NC='\033[0m'
-
-print_success() {
-    local _arg1="$1"
-    echo -e "${GREEN}✅ $_arg1${NC}"
-    return 0
-}
-
-print_info() {
-    local _arg1="$1"
-    echo -e "${BLUE}ℹ️  $_arg1${NC}"
-    return 0
-}
-
-# Fix Content-Type in a file
-fix_content_type_in_file() {
-    local file="$1"
-    local count
-    count=$(grep -c "Content-Type: application/json" "$file" 2>/dev/null || echo "0")
-    count=${count//[^0-9]/}
-    
-    if [[ $count -ge 2 ]]; then
-        print_info "Fixing $count occurrences in: $file"
-        
-        # Add constant if not present
-        if ! grep -q "CONTENT_TYPE_JSON" "$file"; then
-            # Find where to insert the constant (after colors, before functions)
-            if grep -q "NC=.*No Color" "$file"; then
-                sed -i '' '/NC=.*No Color/a\
-\
-# Common constants\
-readonly CONTENT_TYPE_JSON="Content-Type: application/json"
-' "$file"
-            elif grep -q "readonly.*NC=" "$file"; then
-                sed -i '' '/readonly.*NC=/a\
-\
-# Common constants\
-readonly CONTENT_TYPE_JSON="Content-Type: application/json"
-' "$file"
-            fi
-        fi
-        
-        # Replace occurrences
-        sed -i '' 's/"Content-Type: application\/json"/$CONTENT_TYPE_JSON/g' "$file"
-        
-        # Verify
-        local new_count
-        new_count=$(grep -c "Content-Type: application/json" "$file" 2>/dev/null || echo "0")
-        new_count=${new_count//[^0-9]/}
-        local const_count
-        const_count=$(grep -c "CONTENT_TYPE_JSON" "$file" 2>/dev/null || echo "0")
-        const_count=${const_count//[^0-9]/}
-        
-        if [[ $new_count -eq 0 && $const_count -gt 0 ]]; then
-            print_success "Fixed $file: $count → 0 literals, $const_count constant usages"
-            return 0
-        else
-            print_info "Partial fix in $file: $new_count literals remaining"
-            return 1
-        fi
-    else
-        print_info "Skipping $file: only $count occurrences (need 2+)"
-        return 1
-    fi
-    return 0
-}
-
-# Main execution
-main() {
-    print_info "Fixing Content-Type string literals in provider files..."
-    
-    local files_fixed=0
-    local files_processed=0
-    
-    for file in .agent/scripts/*.sh; do
-        if [[ -f "$file" ]]; then
-            ((files_processed++))
-            if fix_content_type_in_file "$file"; then
-                ((files_fixed++))
-            fi
-        fi
-    done
-    
-    print_success "Summary: $files_fixed/$files_processed files fixed"
-    return 0
-}
-
-main "$@"

package/.agent/scripts/fix-error-messages.sh

@@ -1,130 +0,0 @@
-#!/bin/bash
-# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
-
-# Fix Common Error Message String Literals
-# Replace repeated error message patterns with constants
-#
-# Author: AI DevOps Framework
-# Version: 1.1.1
-
-# Colors for output
-readonly GREEN='\033[0;32m'
-readonly BLUE='\033[0;34m'
-readonly NC='\033[0m'
-
-print_success() {
-    local _arg1="$1"
-    echo -e "${GREEN}✅ $_arg1${NC}"
-    return 0
-}
-
-print_info() {
-    local _arg1="$1"
-    echo -e "${BLUE}ℹ️  $_arg1${NC}"
-    return 0
-}
-
-# Fix error messages in a file
-fix_error_messages_in_file() {
-    local file="$1"
-    local changes_made=0
-    
-    print_info "Processing: $file"
-    
-    # Check for common error patterns
-    local unknown_cmd_count
-    unknown_cmd_count=$(grep -c "Unknown command" "$file" 2>/dev/null || echo "0")
-    
-    local usage_count
-    usage_count=$(grep -c "Usage:" "$file" 2>/dev/null || echo "0")
-    
-    local help_count
-    help_count=$(grep -c "help.*Show this help" "$file" 2>/dev/null || echo "0")
-    
-    # Add constants section if needed
-    if [[ $unknown_cmd_count -ge 1 || $usage_count -ge 2 || $help_count -ge 2 ]]; then
-        if ! grep -q "# Error message constants\|# Common constants" "$file"; then
-            # Find where to insert constants
-            if grep -q "readonly.*NC=" "$file"; then
-                sed -i '' '/readonly.*NC=/a\
-\
-# Error message constants
-' "$file"
-            elif grep -q "NC=.*No Color" "$file"; then
-                sed -i '' '/NC=.*No Color/a\
-\
-# Error message constants
-' "$file"
-            fi
-        fi
-        
-        # Fix Unknown command pattern
-        if [[ $unknown_cmd_count -ge 1 ]]; then
-            if ! grep -q "ERROR_UNKNOWN_COMMAND" "$file"; then
-                sed -i '' '/# Error message constants/a\
-readonly ERROR_UNKNOWN_COMMAND="Unknown command:"
-' "$file"
-                changes_made=1
-            fi
-            sed -i '' "s/\"Unknown command: \\\$command\"/\"\$ERROR_UNKNOWN_COMMAND \$command\"/g" "$file"
-            sed -i '' "s/\"Unknown command: \$command\"/\"\$ERROR_UNKNOWN_COMMAND \$command\"/g" "$file"
-            print_success "Fixed $unknown_cmd_count Unknown command messages"
-        fi
-        
-        # Fix Usage pattern
-        if [[ $usage_count -ge 2 ]]; then
-            if ! grep -q "USAGE_PREFIX" "$file"; then
-                sed -i '' '/# Error message constants/a\
-readonly USAGE_PREFIX="Usage:"
-' "$file"
-                changes_made=1
-            fi
-            sed -i '' "s/\"Usage: \\\$0\"/\"\$USAGE_PREFIX \$0\"/g" "$file"
-            sed -i '' "s/\"Usage: \$0\"/\"\$USAGE_PREFIX \$0\"/g" "$file"
-            print_success "Fixed $usage_count Usage messages"
-        fi
-        
-        # Fix help message pattern
-        if [[ $help_count -ge 2 ]]; then
-            if ! grep -q "HELP_MESSAGE_SUFFIX" "$file"; then
-                sed -i '' '/# Error message constants/a\
-readonly HELP_MESSAGE_SUFFIX="Show this help message"
-' "$file"
-                changes_made=1
-            fi
-            sed -i '' "s/\".*help.*- Show this help message\"/\"  help                 - \$HELP_MESSAGE_SUFFIX\"/g" "$file"
-            print_success "Fixed $help_count help messages"
-        fi
-    fi
-    
-    if [[ $changes_made -gt 0 ]]; then
-        print_success "Fixed error messages in: $file"
-        return 0
-    else
-        print_info "No error message patterns requiring fixes in: $file"
-        return 1
-    fi
-    return 0
-}
-
-# Main execution
-main() {
-    print_info "Fixing error message string literals in provider files..."
-    
-    local files_fixed=0
-    local files_processed=0
-    
-    for file in .agent/scripts/*.sh; do
-        if [[ -f "$file" ]]; then
-            ((files_processed++))
-            if fix_error_messages_in_file "$file"; then
-                ((files_fixed++))
-            fi
-        fi
-    done
-    
-    print_success "Summary: $files_fixed/$files_processed files fixed"
-    return 0
-}
-
-main "$@"

package/.agent/scripts/fix-misplaced-returns.sh

@@ -1,74 +0,0 @@
-#!/bin/bash
-# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
-
-# Script to fix misplaced return statements in mainwp-helper.sh
-# These were introduced by the earlier mass fix script
-
-cd providers || exit
-
-echo "🔧 Fixing misplaced return statements in mainwp-helper.sh..."
-
-# Remove misplaced return statements that are not at the end of functions
-# These are typically in the middle of functions or before other statements
-
-# Fix specific patterns where return 0 appears before other statements
-sed -i '' '
-# Remove return 0 that appears before exit statements
-/return 0$/{
-    N
-    /return 0\n        exit 1/c\
-        exit 1
-}
-' mainwp-helper.sh
-
-# Remove return 0 that appears before print statements
-sed -i '' '
-/return 0$/{
-    N
-    /return 0\n    print_/c\
-    print_info "$(echo "$0" | sed "s/.*print_info \"//" | sed "s/\"$//")"
-    return 0
-}
-' mainwp-helper.sh
-
-# Remove return 0 that appears before local variable declarations
-sed -i '' '
-/return 0$/{
-    N
-    /return 0\n    local /c\
-    local $(echo "$0" | sed "s/.*local //" | sed "s/$/")
-    return 0
-}
-' mainwp-helper.sh
-
-# Remove return 0 that appears before if statements
-sed -i '' '
-/return 0$/{
-    N
-    /return 0\n    if /c\
-    if $(echo "$0" | sed "s/.*if //")
-    return 0
-}
-' mainwp-helper.sh
-
-# Remove return 0 that appears before jq commands
-sed -i '' '
-/return 0$/{
-    N
-    /return 0\n    jq /c\
-    jq $(echo "$0" | sed "s/.*jq //")
-    return 0
-}
-' mainwp-helper.sh
-
-# Remove return 0 that appears before echo statements
-sed -i '' '
-/return 0$/{
-    N
-    /return 0\n    echo /c\
-    echo $(echo "$0" | sed "s/.*echo //")
-    return 0
-}
-' mainwp-helper.sh
-
-echo "✅ Fixed misplaced return statements in mainwp-helper.sh"

package/.agent/scripts/fix-remaining-literals.sh

@@ -1,152 +0,0 @@
-#!/bin/bash
-# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
-
-# Fix Remaining String Literals
-# Target specific high-impact string literal patterns
-#
-# Author: AI DevOps Framework
-# Version: 1.1.1
-
-# Colors for output
-readonly GREEN='\033[0;32m'
-readonly BLUE='\033[0;34m'
-readonly NC='\033[0m'
-
-print_success() {
-    local _arg1="$1"
-    echo -e "${GREEN}✅ $_arg1${NC}"
-    return 0
-}
-
-print_info() {
-    local _arg1="$1"
-    echo -e "${BLUE}ℹ️  $_arg1${NC}"
-    return 0
-}
-
-# Fix remaining string literals in a file
-fix_remaining_literals_in_file() {
-    local file="$1"
-    local changes_made=0
-    
-    print_info "Processing: $file"
-    
-    # Check for patterns that need constants
-    local help_usage_count
-    help_usage_count=$(grep -c "Use '\$0 help' for usage information" "$file" 2>/dev/null || echo "0")
-    
-    local usage_pattern_count
-    usage_pattern_count=$(grep -c "Usage: \$0 \[command\]" "$file" 2>/dev/null || echo "0")
-    
-    local help_show_count
-    help_show_count=$(grep -c "help.*- Show this help" "$file" 2>/dev/null || echo "0")
-    
-    # Add constants if patterns found
-    if [[ $help_usage_count -ge 1 || $usage_pattern_count -ge 1 || $help_show_count -ge 1 ]]; then
-        # Check if constants section exists
-        if ! grep -q "# Common message constants\|# Error message constants" "$file"; then
-            # Find where to insert constants
-            if grep -q "readonly.*NC=" "$file"; then
-                sed -i '' '/readonly.*NC=/a\
-\
-# Common message constants
-' "$file"
-            elif grep -q "NC=.*No Color" "$file"; then
-                sed -i '' '/NC=.*No Color/a\
-\
-# Common message constants
-' "$file"
-            fi
-        fi
-        
-        # Add specific constants
-        if [[ $help_usage_count -ge 1 ]]; then
-            if ! grep -q "HELP_USAGE_INFO" "$file"; then
-                sed -i '' '/# Common message constants/a\
-readonly HELP_USAGE_INFO="Use '\''$0 help'\'' for usage information"
-' "$file"
-                changes_made=1
-            fi
-            sed -i '' 's|"Use '\''$0 help'\'' for usage information"|"$HELP_USAGE_INFO"|g' "$file"
-        fi
-        
-        if [[ $usage_pattern_count -ge 1 ]]; then
-            if ! grep -q "USAGE_COMMAND_OPTIONS" "$file"; then
-                sed -i '' '/# Common message constants/a\
-readonly USAGE_COMMAND_OPTIONS="Usage: $0 [command] [options]"
-' "$file"
-                changes_made=1
-            fi
-            sed -i '' 's|"Usage: $0 \[command\] \[options\]"|"$USAGE_COMMAND_OPTIONS"|g' "$file"
-        fi
-        
-        if [[ $help_show_count -ge 1 ]]; then
-            if ! grep -q "HELP_SHOW_MESSAGE" "$file"; then
-                sed -i '' '/# Common message constants/a\
-readonly HELP_SHOW_MESSAGE="Show this help"
-' "$file"
-                changes_made=1
-            fi
-            sed -i '' 's|".*help.*- Show this help.*"|"  help                 - $HELP_SHOW_MESSAGE"|g' "$file"
-        fi
-    fi
-    
-    # Fix remaining Content-Type literals if any
-    local content_type_count
-    content_type_count=$(grep -c "Content-Type: application/json" "$file" 2>/dev/null || echo "0")
-    if [[ $content_type_count -ge 1 ]] && ! grep -q "CONTENT_TYPE_JSON" "$file"; then
-        if ! grep -q "# Common message constants\|# Common constants" "$file" && grep -q "readonly.*NC=" "$file"; then
-            sed -i '' '/readonly.*NC=/a\
-\
-# Common constants
-' "$file"
-        fi
-        
-        sed -i '' '/# Common.*constants/a\
-readonly CONTENT_TYPE_JSON="Content-Type: application/json"
-' "$file"
-        sed -i '' 's|"Content-Type: application/json"|"$CONTENT_TYPE_JSON"|g' "$file"
-        changes_made=1
-    fi
-    
-    if [[ $changes_made -eq 1 ]]; then
-        print_success "Fixed string literals in: $file"
-        return 0
-    else
-        print_info "No string literal fixes needed in: $file"
-        return 1
-    fi
-    return 0
-}
-
-# Main execution
-main() {
-    local target="${1:-.agent/scripts/}"
-    
-    print_info "Fixing remaining string literals..."
-    
-    local files_fixed=0
-    local files_processed=0
-    
-    if [[ -f "$target" && "$target" == *.sh ]]; then
-        ((files_processed++))
-        if fix_remaining_literals_in_file "$target"; then
-            ((files_fixed++))
-        fi
-    elif [[ -d "$target" ]]; then
-        find "$target" -name "*.sh" -type f | while read -r file; do
-            ((files_processed++))
-            if fix_remaining_literals_in_file "$file"; then
-                ((files_fixed++))
-            fi
-        done
-    else
-        print_info "Invalid target: $target"
-        return 1
-    fi
-    
-    print_success "Summary: $files_fixed/$files_processed files fixed"
-    return 0
-}
-
-main "$@"

package/.agent/scripts/fix-return-statements.sh

@@ -1,41 +0,0 @@
-#!/bin/bash
-# shellcheck disable=SC2034,SC2155,SC2317,SC2329,SC2016,SC2181,SC1091,SC2154,SC2015,SC2086,SC2129,SC2030,SC2031,SC2119,SC2120,SC2001,SC2162,SC2088,SC2089,SC2090,SC2029,SC2006,SC2153
-
-# Script to add return statements to functions that need them
-# Based on SonarCloud S7682 issues
-
-FILE=".agent/scripts/101domains-helper.sh"
-
-# Function to add return statement before closing brace
-add_return_statement() {
-    local line_num=$1
-    sed -i "${line_num}i\\    return 0" "$FILE"
-    return 0
-}
-
-# Lines where functions end (based on SonarCloud analysis)
-# These are the line numbers where we need to add return statements
-FUNCTION_END_LINES=(
-    256   # purchase_domain
-    283   # get_nameservers  
-    303   # update_nameservers
-    329   # delete_dns_record
-    357   # check_availability
-    377   # get_contacts
-    406   # update_nameservers
-    426   # lock_domain
-    446   # get_transfer_status
-    475   # monitor_expiration
-    508   # help
-    528   # main function
-    565   # end of file
-)
-
-# Add return statements in reverse order to avoid line number shifts
-for ((i=${#FUNCTION_END_LINES[@]}-1; i>=0; i--)); do
-    line_num=${FUNCTION_END_LINES[i]}
-    echo "Adding return statement before line $line_num"
-    add_return_statement "$line_num"
-done
-
-echo "Return statements added to all functions in $FILE"