ai-engineering-loop 1.0.13 → 1.0.15

package/policies/tdd-policy.md

@@ -14,20 +14,39 @@ No test is written at an unconfirmed seam. If the contract omitted seams and gri
 
 The test reads like a specification of behavior at the seam. Names use `.ai-engineering-loop/glossary.md`. The test survives an internal rewrite. Expected values come from the Goal Contract or a known-good literal, not from re-running the implementation.
 
+## Failure table
+
+The Goal Contract's AC-1..N **are** the test list. Each row is one red test at the named seam. Do not invent a parallel "comprehensive suite" of only positive cases.
+
+Default rows unless the contract marked them N/A with one sentence:
+
+1. Happy path
+2. Empty / omitted / null
+3. Boundary (min, max, off-by-one, locked vs open)
+4. Sibling / isolation (other entities in the same parent must not change)
+5. Error / denied / unauthorized / invalid input
+
+Do not stop after the first green test. A suite that never asserts a failure mode does not cover the feature.
+
 ## Loop
 
-1. **Red.** Write one failing test for one AC slice. Confirm it fails for the right reason.
+1. **Red.** Write one failing test for one AC row. Confirm it fails for the right reason.
 2. **Green.** Write the smallest production change that passes that test.
-3. Repeat one slice at a time (vertical). Do not write the whole suite first.
-4. After slices covering AC-1..N, run the full verification commands in `.ai-engineering-loop/verification.md` and keep the Evidence Contract.
+3. Repeat one row at a time (vertical). Do not write the whole suite first.
+4. After AC-1..N are green, run the full verification commands in `.ai-engineering-loop/verification.md` and keep the Evidence Contract.
+5. **Coverage as a map, not a score.** If a coverage command exists, use the report to find branches that map to a written AC and are still untested. Add tests only for those. Do not chase 90% with tautological asserts. Line coverage without a failure table is invalid evidence.
+6. **Mutation (optional).** If `.ai-engineering-loop/verification.md` names a mutation tool (Stryker, mutmut, PIT, cargo-mutants), run it on the files this task touched. Surviving mutants on an AC path are ITERATE. Do not add mutation as a new stage or a global 90% gate.
+7. **Property-based (optional).** When the input space is broad (ids, dates, strings, amounts), one property per invariant beats a pile of copied positives. Not required for every task.
 
 ## Forbidden tests
 
 - **Implementation-coupled:** mocks internal collaborators, tests private methods, or asserts through a side channel (raw DB) instead of the seam.
 - **Tautological:** expected value is computed the same way as the code (`expect(add(a,b)).toBe(a+b)`).
 - **Source grep:** `grep -q 'featureFlag' src/file` is not a test of the AC. Prove behavior at the named seam or on the named artifact.
+- **Happy-path only:** every test is a success case while the contract listed empty, boundary, sibling, or error rows.
+- **Coverage theater:** raising percent with `toBeDefined()`, snapshot-without-oracle, or tests that cannot fail.
 - **Horizontal slicing:** all tests first, then all implementation.
 
 ## Evidence
 
-Stage 5 still requires command, exit code 0, stdout, test counts, and assertionEvidence mapped to AC ids. "We did TDD" is not evidence. A red-then-green story without logs is invalid.
+Stage 5 still requires command, exit code 0, stdout, test counts, and assertionEvidence mapped to AC ids. "We did TDD" is not evidence. A red-then-green story without logs is invalid. assertionEvidence must cite at least one non-happy-path AC when the failure table has one.

package/tests/no-company-leak.test.js

@@ -0,0 +1,82 @@
+'use strict';
+
+const test = require('node:test');
+const assert = require('node:assert');
+const fs = require('fs');
+const path = require('path');
+
+const ROOT = path.join(__dirname, '..');
+
+const SKIP_DIR = new Set([
+  '.git',
+  'node_modules',
+  '.serena',
+  '.DS_Store'
+]);
+
+function walk(dir, out = []) {
+  for (const name of fs.readdirSync(dir)) {
+    if (SKIP_DIR.has(name)) continue;
+    const abs = path.join(dir, name);
+    const st = fs.lstatSync(abs);
+    if (st.isSymbolicLink()) continue;
+    if (st.isDirectory()) walk(abs, out);
+    else if (st.isFile()) out.push(abs);
+  }
+  return out;
+}
+
+function rel(abs) {
+  return path.relative(ROOT, abs).split(path.sep).join('/');
+}
+
+const FINGERPRINTS = [
+  { re: /dotify/i, label: 'dotify' },
+  { re: /bikin-rindu/i, label: 'bikin-rindu' },
+  { re: /hasNormalHours/, label: 'hasNormalHours' },
+  { re: /overtimeNote/, label: 'overtimeNote' },
+  { re: /attendanceConfirmation/i, label: 'attendanceConfirmation' },
+  { re: /internal-dotify/, label: 'internal-dotify' },
+  { re: /hanaaaca/, label: 'coworker handle' },
+  { re: /ulfa\.mufida/, label: 'coworker handle' },
+  { re: /kontribusi\/mattermost-agent/, label: 'local mattermost-agent checkout' },
+  { re: /dot-system\//, label: 'dot-system/' },
+  { re: /timeEntities/, label: 'timeEntities' },
+  { re: /resolveAttendanceConfirmation/, label: 'resolveAttendanceConfirmation' },
+  { re: /attendance-confirmations/, label: 'attendance-confirmations' }
+];
+
+test('packaged files do not embed real client tickets, schema, or machine paths', () => {
+  const files = walk(ROOT).filter((abs) => {
+    const r = rel(abs);
+    return !r.startsWith('tests/no-company-leak.test.js');
+  });
+  const hits = [];
+  for (const abs of files) {
+    const r = rel(abs);
+    let text;
+    try {
+      text = fs.readFileSync(abs, 'utf8');
+    } catch {
+      continue;
+    }
+    if (text.includes('\u0000')) continue;
+
+    if (r !== 'bin/ai-engineering-loop.js' && /gitlab\.dot\.co\.id/.test(text)) {
+      hits.push(`${r}: gitlab.dot.co.id (allowed only as adapter auto-detect in bin/)`);
+    }
+    if (r === 'bin/ai-engineering-loop.js' && /gitlab\.dot\.co\.id\/.+/.test(text)) {
+      hits.push(`${r}: gitlab.dot.co.id with a path (ticket URL)`);
+    }
+
+    const inSensitiveTree = r.startsWith('adapters/') || r.startsWith('examples/');
+    if (inSensitiveTree && /\/Users\/egagofur/.test(text)) {
+      hits.push(`${r}: /Users/egagofur`);
+    }
+
+    for (const { re, label } of FINGERPRINTS) {
+      if (re.test(text)) hits.push(`${r}: ${label}`);
+    }
+  }
+  assert.deepStrictEqual(hits, []);
+});

package/tests/skill-host-compat.test.js

@@ -166,17 +166,33 @@ test('Gemini Antigravity skill matches the loop and never uses Grok spawn keys o
   assert.match(gemini, /TRUE_INDEPENDENT_AGENT/);
 });
 
-test('DOT adapter locates task-impact-inquiry on Antigravity Gemini skills, not Claude', () => {
+test('task-impact-inquiry is Claude-safe and ships to Claude, Grok, and Gemini', () => {
+  const skill = readRepo('adapters/dot/skills/task-impact-inquiry/SKILL.md');
+  const { fm } = parseFrontmatter(skill, 'task-impact-inquiry');
+  assert.doesNotMatch(fm, /^description:\s*>-?/m);
+  assert.doesNotMatch(skill, /```mermaid/);
+  assert.doesNotMatch(skill, /\$\\/);
+  assert.doesNotMatch(skill, /spawn_subagent/);
+  assert.match(skill, /lifecycle/);
+  assert.match(skill, /ASCII/);
+  assert.match(skill, /failure table/);
+  assert.match(skill, /Do not interview again/);
+  assert.match(skill, /Passing unit tests are not isolation proof|Green unit tests/);
+  assert.match(skill, /New-dev briefing/);
+  assert.match(skill, /Hit map|Where it hits/);
+  assert.match(skill, /Do not generate an FSD/);
+  const grill = readRepo('core/grill-policy.md');
+  assert.match(grill, /Business blast radius/);
+  assert.match(grill, /~\/\.claude\/skills\/task-impact-inquiry/);
+  assert.match(grill, /~\/\.grok\/skills\/task-impact-inquiry/);
+  assert.match(grill, /~\/\.gemini\/config\/skills\/task-impact-inquiry/);
   const readme = readRepo('adapters/dot/README.md');
-  assert.match(readme, /~\/\.gemini\/config\/skills/);
   assert.match(readme, /task-impact-inquiry/);
-  assert.match(readme, /not from `~\/\.claude\/skills\/`/);
-  assert.doesNotMatch(readme, /and `~\/\.claude\/skills\/`/);
-  const grill = readRepo('core/grill-policy.md');
-  assert.match(grill, /task-impact-inquiry/);
-  assert.match(grill, /Do not skip grill/);
+  assert.match(readme, /~\/\.claude\/skills\//);
+  assert.doesNotMatch(readme, /not from `~\/\.claude\/skills\/`/);
   const wf = readRepo('.agents/workflows/ai-engineering-loop.md');
   assert.match(wf, /task-impact-inquiry/);
+  assert.match(wf, /blast radius: lifecycle sketch/);
 });
 
 test('DOT router sends commit-bound work to ai-engineering-loop; workflow is Stage 8 only', () => {
@@ -233,6 +249,37 @@ test('Grill freeze gate and idea menu are in the loop, not a parallel product',
   }
 });
 
+test('Failure table is required to freeze, TDD, verify, and Judge', () => {
+  const grill = readRepo('core/grill-policy.md');
+  assert.match(grill, /failure table/);
+  assert.match(grill, /sunny path is not frozen/);
+  const contract = readRepo('core/goal-contract.md');
+  assert.match(contract, /The Happy-Path Contract/);
+  assert.match(contract, /Empty \/ omitted field/);
+  const tdd = readRepo('policies/tdd-policy.md');
+  assert.match(tdd, /Coverage as a map, not a score/);
+  assert.match(tdd, /Happy-path only/);
+  assert.match(tdd, /Coverage theater/);
+  const verif = readRepo('core/verification-loop.md');
+  assert.match(verif, /non-happy-path AC/);
+  const judge = readRepo('agents/shared/judge.body.md');
+  assert.match(judge, /happy-path-only/);
+  const da = readRepo('agents/shared/devil-advocate.body.md');
+  assert.match(da, /happy-path-only suite vs written failure table/);
+  for (const rel of [
+    '.claude/skills/ai-engineering-loop/SKILL.md',
+    '.grok/skills/ai-engineering-loop/SKILL.md',
+    '.gemini/skills/ai-engineering-loop/SKILL.md',
+    '.agents/workflows/ai-engineering-loop.md'
+  ]) {
+    const text = readRepo(rel);
+    assert.match(text, /failure table/, rel);
+    assert.match(text, /One red test per AC row/, rel);
+    assert.match(text, /Do not freeze sunny-path-only/, rel);
+    assert.match(text, /blast radius: lifecycle sketch/, rel);
+  }
+});
+
 test('Host skills absorb grill, TDD, glossary, and two-axis review without splitting the loop', () => {
   for (const rel of [
     '.claude/skills/ai-engineering-loop/SKILL.md',

package/tests/sync-hosts.test.js

@@ -47,9 +47,27 @@ test('sync upserts Claude AEL files but does not invent DOT skills', () => {
   assert.ok(fs.existsSync(path.join(home, '.claude/agents/judge.md')));
   assert.ok(fs.existsSync(path.join(home, '.claude/commands/ai-engineering-loop.md')));
   assert.ok(!fs.existsSync(path.join(home, '.claude/skills/dot-dev-workflow/SKILL.md')));
+  assert.ok(fs.existsSync(path.join(home, '.claude/skills/task-impact-inquiry/SKILL.md')));
   assert.ok(!fs.existsSync(path.join(home, '.claude/settings.local.json')));
 });
 
+test('sync upserts task-impact-inquiry onto Claude, Grok, and Gemini', () => {
+  const home = tmpHome();
+  fs.mkdirSync(path.join(home, '.claude'));
+  fs.mkdirSync(path.join(home, '.grok'));
+  fs.mkdirSync(path.join(home, '.gemini'));
+  applyHostSync({ packageRoot: ROOT, home });
+  const claude = fs.readFileSync(path.join(home, '.claude/skills/task-impact-inquiry/SKILL.md'), 'utf8');
+  const grok = fs.readFileSync(path.join(home, '.grok/skills/task-impact-inquiry/SKILL.md'), 'utf8');
+  const gemini = fs.readFileSync(path.join(home, '.gemini/config/skills/task-impact-inquiry/SKILL.md'), 'utf8');
+  assert.match(claude, /name: task-impact-inquiry/);
+  assert.doesNotMatch(claude, /```mermaid/);
+  assert.match(claude, /New-dev briefing/);
+  assert.match(grok, /^user-invocable: true$/m);
+  assert.match(grok, /Where it hits/);
+  assert.match(gemini, /Business blast radius|blast radius/);
+});
+
 test('DOT skills update only when already installed', () => {
   const home = tmpHome();
   const dest = path.join(home, '.claude/skills/dot-dev-workflow/SKILL.md');
@@ -84,7 +102,7 @@ test('dry-run does not write; second apply is current', () => {
   assert.ok(!fs.existsSync(path.join(home, '.gemini/config/skills/ai-engineering-loop/SKILL.md')));
   applyHostSync({ packageRoot: ROOT, home });
   const again = applyHostSync({ packageRoot: ROOT, home });
-  assert.strictEqual(summarizeHostSync(again.filter((item) => item.id === 'gemini')).current, 1);
+  assert.strictEqual(summarizeHostSync(again.filter((item) => item.id === 'gemini')).current, 2);
   assert.strictEqual(summarizeHostSync(again.filter((item) => item.id === 'gemini')).copy, 0);
 });
 

package/examples/dot/attendance-confirmation/README.md

@@ -1,22 +0,0 @@
-# Reference Example: Attendance Confirmation Status Fix
-
-## 1. Context & Scenario
-
-This reference walkthrough demonstrates how a complex real-world bug in the DOT ecosystem moves through the complete **AI Engineering Loop** and is subsequently delivered via the **DOT Delivery Adapter**.
-
-### The Problem
-In the Dotify employee portal, attendance confirmation cards displayed an incorrect status (`"PENDING"`) for employees working overtime or on weekends, even when all underlying time logs had already been approved or rejected. Furthermore, non-normal hours employees (shift workers) had their records mistakenly treated under standard 9-to-5 rules.
-
----
-
-## 2. Walkthrough Stages & Artifacts
-
-1. **[Stage 1: Goal Contract (`goal-contract.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/dot/attendance-confirmation/goal-contract.md)**:
-   - Formalized objective, acceptance criteria (normal hours, weekends, non-normal hours, null values), and verification plan.
-2. **[Stage 2: Adversarial Review & Triage (`review-findings.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/dot/attendance-confirmation/review-findings.md)**:
-   - Independent Devil's Advocate review flagging a timezone offset bug (`COR-001`) and an invalid nitpick (`MAINT-001`).
-   - Maker Agent triage and surgical resolution.
-3. **[Stage 3: Judge Evaluation & Verdict (`judge-verdict.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/dot/attendance-confirmation/judge-verdict.md)**:
-   - Audit of unit test results, typecheck logs, finding resolutions, and issuance of `PASS` verdict.
-4. **[Stage 4: DOT Delivery Pipeline (`delivery-report.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/dot/attendance-confirmation/delivery-report.md)**:
-   - Creation of GitLab Issue #307, base MR !946, multi-branch propagation to `staging` (!947) and `develop` (!948), Coreview bot triage, and automated Mattermost channel notification.

package/examples/dot/attendance-confirmation/delivery-report.md

@@ -1,51 +0,0 @@
-# DOT Delivery Report: Attendance Confirmation Fix
-
-## 1. Summary of Delivery Actions
-
-Upon receiving the `PASS` verdict from the Judge Agent, the DOT Delivery Adapter executed the following release actions:
-
-1. **GitLab Issue Created**: [Issue #307 - [BE] [Attendance] Fix Attendance Confirmation Display Status](https://gitlab.dot.co.id/dot-system/dotify-new/-/issues/307).
-2. **Primary MR Created**: [MR !946 targeting `main`](https://gitlab.dot.co.id/dot-system/dotify-new/-/merge_requests/946).
-3. **Multi-Branch Cherry-Pick**:
-   - [MR !947 targeting `staging`](https://gitlab.dot.co.id/dot-system/dotify-new/-/merge_requests/947).
-   - [MR !948 targeting `develop`](https://gitlab.dot.co.id/dot-system/dotify-new/-/merge_requests/948).
-4. **Coreview Bot Triage**:
-   - Comments fetched on MR !948. Zero blocking comments found.
-5. **Mattermost Notification**:
-   - Resolved repository `dot-system/dotify-new` to channel `"internal-dotify"`.
-   - Dispatched Markdown report via MCP `mattermost_send_message` with `from: "AI Agent"`.
-
----
-
-## 2. GitLab Links
-
-| Artifact | Branch | Link |
-|---|---|---|
-| **GitLab Issue** | — | `[Issue #307](https://gitlab.dot.co.id/dot-system/dotify-new/-/issues/307)` |
-| **Merge Request DEV** | `develop` | `[MR !948](https://gitlab.dot.co.id/dot-system/dotify-new/-/merge_requests/948)` |
-| **Merge Request STAGING** | `staging` | `[MR !947](https://gitlab.dot.co.id/dot-system/dotify-new/-/merge_requests/947)` |
-| **Merge Request MAIN** | `main` | `[MR !946](https://gitlab.dot.co.id/dot-system/dotify-new/-/merge_requests/946)` |
-
----
-
-## 3. Dispatched Mattermost Notification
-
-```text
-[MR DEV] https://gitlab.dot.co.id/dot-system/dotify-new/-/merge_requests/948
-Changes log 
-- Include user.type.hasNormalHours and timeEntities.overtimeNote in attendanceConfirmationPagination Prisma query.
-- Create resolveAttendanceConfirmationDisplayStatus utility to properly evaluate hasPendingTimeEntities by checking overtimeNote, isWeekend, duration > 8, non-normal hours employees, and null statuses.
-- Add comprehensive unit tests in src/server/attendance-confirmations/utils/resolve-display-status.test.ts covering all status permutations.
-
-[MR STAGING] https://gitlab.dot.co.id/dot-system/dotify-new/-/merge_requests/947
-Changes log 
-- Include user.type.hasNormalHours and timeEntities.overtimeNote in attendanceConfirmationPagination Prisma query.
-- Create resolveAttendanceConfirmationDisplayStatus utility to properly evaluate hasPendingTimeEntities by checking overtimeNote, isWeekend, duration > 8, non-normal hours employees, and null statuses.
-- Add comprehensive unit tests in src/server/attendance-confirmations/utils/resolve-display-status.test.ts covering all status permutations.
-
-[MR MAIN] https://gitlab.dot.co.id/dot-system/dotify-new/-/merge_requests/946
-Changes log 
-- Include user.type.hasNormalHours and timeEntities.overtimeNote in attendanceConfirmationPagination Prisma query.
-- Create resolveAttendanceConfirmationDisplayStatus utility to properly evaluate hasPendingTimeEntities by checking overtimeNote, isWeekend, duration > 8, non-normal hours employees, and null statuses.
-- Add comprehensive unit tests in src/server/attendance-confirmations/utils/resolve-display-status.test.ts covering all status permutations.
-```

package/examples/dot/attendance-confirmation/goal-contract.md

@@ -1,39 +0,0 @@
-# Goal Contract: Attendance Confirmation Display Status Fix
-
-## 1. Objective
-Fix the incorrect calculation of attendance confirmation display statuses across list and pagination endpoints when time entities contain overtime notes, weekend logs, non-normal hours employees, or null record states.
-
-## 2. Business Outcome & User Lifecycle Impact
-- **Employees**: View accurate confirmation statuses (APPROVED, REJECTED, NEED_APPROVAL) reflecting their true attendance record.
-- **Managers / Reviewers**: Stop receiving false-positive pending approval notifications for already-settled weekend logs.
-- **HR & Payroll**: Accurate cumulative duration calculations for payroll export.
-
-## 3. Acceptance Criteria (AC)
-- [ ] **AC-1**: If an employee has `hasNormalHours = true` and `duration <= 8` on a standard weekday without overtime notes, display status must resolve to `APPROVED` or `NEED_APPROVAL` strictly based on clock-in/out presence.
-- [ ] **AC-2**: If `overtimeNote` exists or `duration > 8` or `isWeekend = true`, evaluate pending status across all associated `timeEntities`.
-- [ ] **AC-3**: Non-normal hours employees (`user.type.hasNormalHours = false`) must not be evaluated under 8-hour weekday thresholds.
-- [ ] **AC-4**: Null or missing time entity collections must default safely to `APPROVED` without throwing runtime `TypeError`.
-- [ ] **AC-5**: Backward compatibility of the tRPC/REST response contract must be strictly preserved.
-
-## 4. Technical Constraints
-- Preserve existing Prisma query schemas in `attendanceConfirmationPagination`.
-- Centralize logic in a pure, testable utility function: `resolveAttendanceConfirmationDisplayStatus`.
-- No new external runtime dependencies (use existing `dayjs` and `lodash` packages).
-- 0 TypeScript compiler errors on `tsc --noEmit`.
-
-## 5. Out of Scope
-- Modifying the UI frontend component layouts in `dotify-new/web`.
-- Database schema migrations or alter table statements.
-- Changing payroll export report generation scripts.
-
-## 6. Verification Requirements
-- **Unit Tests**: Comprehensive Jest test suite in `src/server/attendance-confirmations/utils/resolve-display-status.test.ts` covering 100% of branches.
-- **Typecheck**: `npx tsc --noEmit` exits with 0.
-- **Linter**: `npx eslint --fix` on modified files with 0 errors.
-- **Regression**: Run entire test suite: `npx jest --testPathIgnorePatterns="dotify-api"`.
-
-## 7. Definition of Done (DoD)
-- [ ] All AC-1 through AC-5 proven by unit tests.
-- [ ] Deterministic verification passes 100%.
-- [ ] Devil's Advocate review conducted with 0 unresolved blocking findings.
-- [ ] Judge issues PASS verdict.

package/examples/dot/attendance-confirmation/judge-verdict.md

@@ -1,43 +0,0 @@
-# Judge Evaluation Report: Attendance Confirmation Fix
-
-## 1. Executive Verdict
-- **Verdict**: `PASS`
-- **Iteration**: `Iteration 2 of 3`
-- **Confidence**: `HIGH`
-
----
-
-## 2. Deterministic Verification Audit
-
-| Check | Command Executed | Raw Result | Status |
-|---|---|---|:---:|
-| **Unit Tests** | `npx jest src/server/attendance-confirmations/utils/resolve-display-status.test.ts` | `Tests: 12 passed, 12 total. Snapshots: 0. Time: 1.42s` | ✅ PASS |
-| **Full Suite** | `npx jest --testPathIgnorePatterns="dotify-api"` | `Test Suites: 48 passed, 48 total. Tests: 382 passed.` | ✅ PASS |
-| **TypeScript** | `npx tsc --noEmit` | `Exit code 0. Zero errors.` | ✅ PASS |
-| **Linter** | `npx eslint --fix src/server/attendance-confirmations/**` | `0 errors, 0 warnings found.` | ✅ PASS |
-
----
-
-## 3. Goal Contract Compliance Audit
-
-| Criterion | Verified By Test / Artifact | Result |
-|---|---|:---:|
-| **AC-1**: Normal hours weekday calculation | `resolve-display-status.test.ts > normal hours` | ✅ PASS |
-| **AC-2**: Weekend & duration > 8 handling | `resolve-display-status.test.ts > weekend overtime` | ✅ PASS |
-| **AC-3**: Non-normal hours employee rules | `resolve-display-status.test.ts > shift worker` | ✅ PASS |
-| **AC-4**: Null & undefined timeEntities safety | `resolve-display-status.test.ts > null safety` | ✅ PASS |
-| **AC-5**: API Contract Preservation | `tRPC router typecheck` | ✅ PASS |
-
----
-
-## 4. Finding Triage Audit
-
-- **COR-001 (High - Null Safety)**: Maker applied null coalescing in Iteration 2. Verified via fresh test execution. **Status: RESOLVED & VERIFIED**.
-- **MAINT-001 (Low - Factory Suggestion)**: Overridden by Judge as invalid speculative nitpick. **Status: DISMISSED / INVALID**.
-
----
-
-## 5. Formal Conclusion & Hand-off
-
-The Definition of Done has been 100% satisfied with reproducible evidence.
-**Authorized next action**: Proceed to [DOT Delivery Adapter](file:///Users/egagofur/Development/work/ai-engineering-loop/adapters/dot/README.md) for GitLab MR generation, multi-branch cherry-picking, Coreview triage, and Mattermost notification.

package/examples/dot/attendance-confirmation/review-findings.md

@@ -1,57 +0,0 @@
-# Adversarial Review Findings & Triage: Attendance Confirmation Fix
-
-## 1. Review Summary
-
-- **Reviewer**: Devil's Advocate Agent
-- **Target Branch**: `main...fix/attendance-confirmation-status`
-- **Total Findings**: 2
-- **Blocking (SEV-1/2)**: 1
-- **Non-Blocking / Invalid**: 1
-
----
-
-## 2. Findings Ledger
-
-### Finding COR-001: Missing null safety when iterating `timeEntities`
-- **Severity**: `HIGH` (SEV-2)
-- **Category**: `Correctness`
-- **Location**: `src/server/attendance-confirmations/utils/resolve-display-status.ts:34-41`
-- **Evidence**:
-  ```typescript
-  const hasPending = confirmation.timeEntities.some(
-    (entity) => entity.status === "NEED_APPROVAL"
-  );
-  ```
-- **Problem**:
-  If `confirmation.timeEntities` is `null` or `undefined` (which occurs for historical attendance records prior to migration v2.4), calling `.some()` throws a runtime `TypeError: Cannot read properties of undefined (reading 'some')`.
-- **Impact**:
-  Crashing pagination API for employees with legacy historical attendance records.
-- **Recommendation**:
-  ```diff
-  - const hasPending = confirmation.timeEntities.some(
-  + const hasPending = (confirmation.timeEntities ?? []).some(
-      (entity) => entity.status === "NEED_APPROVAL"
-    );
-  ```
-- **Confidence**: `HIGH`
-- **Status**: `TRIAGED_VALID`
-- **Resolution**:
-  Maker Agent applied optional chaining and null coalescing `(confirmation.timeEntities ?? [])` and added unit test case `should return APPROVED when timeEntities is null or undefined` in `resolve-display-status.test.ts`.
-
----
-
-### Finding MAINT-001: Suggestion to convert helper into an abstract factory class
-- **Severity**: `LOW` (SEV-4)
-- **Category**: `Maintainability`
-- **Location**: `src/server/attendance-confirmations/utils/resolve-display-status.ts:1-50`
-- **Evidence**:
-  Utility is authored as a pure exported function `export function resolveAttendanceConfirmationDisplayStatus(...)`.
-- **Problem**:
-  Reviewer claimed that an object-oriented Strategy/Factory pattern would allow swapping attendance status calculators in the future.
-- **Impact**:
-  None. Pure functions are more testable, tree-shakeable, and align with current repository conventions.
-- **Recommendation**: Refactor to `class AttendanceStatusCalculatorFactory`.
-- **Confidence**: `LOW`
-- **Status**: `TRIAGED_INVALID`
-- **Triage Reason**:
-  Dismissed as speculative overengineering. Repository architecture uses functional utilities with tRPC. Adding a class factory violates Technical Constraint: *"Produce minimal, surgical changes without speculative abstractions."*