ai-engineering-loop 1.0.13 → 1.0.15

package/adapters/dot/skills/task-impact-inquiry/SKILL.md

@@ -0,0 +1,155 @@
+---
+name: task-impact-inquiry
+description: Map business blast radius before code. Use for impact, side effects, sibling data, approval, queues, or when a new developer must learn the current flow. Triggers: cek impactnya, blast radius, analisa pengaruh, brainstorming impact. Not a substitute for ai-engineering-loop.
+---
+
+# Task Impact Inquiry
+
+Map the **current business flow** and the **blast radius** of a change before any production edit.
+
+This skill fills AI Engineering Loop Stage 1 grill. It is not a parallel engineering OS.
+
+If Stage 1 grill already produced this matrix and the user confirmed it, stop. Do not interview again. On commit-bound work, continue in `ai-engineering-loop` (freeze the Goal Contract, then Maker). Do not start `dot-dev-workflow` Phases 1-6.
+
+## Hard gate
+
+Do not create a branch or edit production code until:
+
+1. The current lifecycle is drawn from evidence (not guessed).
+2. The impact matrix is on screen.
+3. The user has answered the probing questions (or waived them).
+
+Green unit tests later are not proof that siblings, approvals, or downstream jobs survived. A 100% passing suite can still reset approved history or fire the wrong downstream job.
+
+## When to use
+
+- "cek impactnya", "blast radius", "analisa pengaruh", "brainstorming impact"
+- Bug, edge case, or business-logic change
+- Shared service, status transition, calculation, validation, authorization, schema
+- The user is new to the domain and does not know the flow
+
+Impact-only (no implementation): run this skill and stop after the report.
+
+Commit-bound work: run this inside AEL Stage 1, then freeze. Do not run it a second time after grill.
+
+## Host notes
+
+Claude Code / Kiro: no mermaid, no LaTeX, no extra tool keys. ASCII diagrams only.
+
+Grok: do not spawn children for this skill. Stay in the parent.
+
+Look up facts (files, enums, jobs). Grill only **decisions**.
+
+## Steps
+
+### 1. Look up (do not ask)
+
+Read in this order. Skip a source if it is missing. Do not invent statuses.
+
+1. `.ai-engineering-loop/glossary.md`
+2. Existing FSD if present (`docs/fsd/`, `specs-book/fsd/`, especially `impact-matrix.md`). Read only. Do not generate an FSD.
+3. Status enums, services, validators, listeners, BullMQ / cron / queue processors
+4. Matching FE pages, routes, and permission guards when both FE and BE are in the workspace
+
+Cite the path for each claim. If FE or BE is missing, say so.
+
+### 2. New-dev briefing + lifecycle picture
+
+Explain the current flow in plain language for someone new to the app: who acts, what status changes, when a period locks.
+
+Then draw the lifecycle in ASCII. Do not ask the user what the code already shows.
+
+```text
+Author submit    -> DRAFT
+Author send      -> NEED_APPROVAL
+Reviewer approve -> APPROVED
+period lock      -> CONFIRMED --> billing / aggregate job
+```
+
+If the flow cannot be determined from the repo, say what is missing.
+
+### 3. Four-pillar scan
+
+**State and conditions.** Does the rule apply the same in normal vs special cases (rush vs standard, holiday, locked vs open period)? What happens in DRAFT, SUBMITTED, NEED_APPROVAL, APPROVED, REJECTED, CONFIRMED, UNCONFIRMED?
+
+**Sibling / historical isolation.** If entity A in parent P changes, do B and C in the same parent, period, or cart change? Can already-approved history reset?
+
+**Actor and approval.** Who creates, who may edit, who must re-approve? When is an existing approval void, and when must it be kept?
+
+**Downstream.** BullMQ, cron, listeners, billing, dashboard totals.
+
+### 4. Where it hits (hit map + blast picture)
+
+List the surfaces a naive edit would touch. Empty rows mean you have not finished looking.
+
+```text
+Surface          Path / job                         Naive risk
+FE page          <route or page>                    <what the user would see>
+BE service       <service / status write>           <what the row would become>
+Sibling rows     <same parent / period / cart>      isolate | also-update
+Approval         <who, void vs keep>                <approval lost or kept>
+Queue / billing  <job name>                         rerun | skip
+```
+
+Then the blast-radius picture (ASCII only):
+
+```text
+edit(A in period P)
+  |- sibling B in P     : isolate | also-update
+  |- approval on A      : void | keep
+  |- billing / queue    : rerun | skip
+```
+
+### 5. Impact matrix (failure table)
+
+| Scenario | Current logic (cite path) | Side effect if we ship naive | Proposed treatment |
+|---|---|---|---|
+| Happy path | | | |
+| Empty / omitted field | | | |
+| Boundary (min/max, locked vs open) | | | |
+| Sibling in the same parent | | | |
+| Error / denied / unauthorized | | | |
+
+A matrix with only the sunny path is not done.
+
+### 6. Probing questions
+
+Ask 2-3 decisions. Number them. Give a recommended answer. Wait.
+
+```text
+Q1 - <title>: <choices>
+Recommended: <your answer>
+```
+
+Typical decisions: void vs keep approval; isolate vs also-update siblings; rerun vs skip the downstream job.
+
+### 7. Contract rows
+
+Each accepted matrix row becomes a numbered AC in the Goal Contract **file** (failure table). Name the seam or artifact.
+
+If this session is AEL: freeze after those ACs are in the file. Chat `setuju` is not freeze.
+
+If this session is impact-only: print the report and stop. Do not implement.
+
+## Output
+
+```text
+Task impact inquiry
+Briefing: <plain-language current flow>
+Lifecycle: <ASCII>
+Hit map: <surfaces + paths>
+Blast radius: <ASCII>
+Matrix: <table>
+Questions: Q1..Qn with Recommended
+Proposed AC: AC-1..N (happy, empty/omit, boundary, sibling, error)
+Next: freeze Goal Contract | stop (impact-only)
+```
+
+## Forbidden
+
+- Implementing, branching, or "small fix while we discuss"
+- Second interview after AEL grill already captured the matrix
+- Mermaid or LaTeX
+- Claiming isolation because unit tests passed
+- Inventing business rules the repo and the user did not supply
+- Generating an FSD or starting `dot-dev-workflow` as a second loop

package/agents/judge.md

@@ -49,7 +49,8 @@ flowchart LR
 
 ### Step 2: Goal Contract Compliance Audit
 - Cross-reference every Acceptance Criterion (AC-1 through AC-N) from the [Goal Contract](file:///Users/egagofur/Development/work/ai-engineering-loop/core/goal-contract.md).
-- Verify that automated tests exist that explicitly exercise and prove each criterion.
+- Verify that automated tests exist that explicitly exercise and prove each criterion, including non-happy-path rows in the failure table.
+- A happy-path-only suite while the contract lists empty, boundary, sibling, or error rows is `ITERATE`.
 - Verify that no out-of-scope files were touched and technical constraints were respected.
 
 ### Step 3: Finding Triage & Evidence Verification

package/agents/maker.md

@@ -28,7 +28,7 @@ flowchart LR
 3. **Test-Driven Engineering** ([TDD Policy](file:///Users/egagofur/Development/work/ai-engineering-loop/policies/tdd-policy.md)):
    - Red before green at the Goal Contract's named seams only.
    - Tests observe public behavior, use glossary terms, and never assert implementation details.
-   - Cover the AC slice in play: happy path, negative edge, null/empty, boundary. Vertical slices, not all-tests-then-all-code.
+   - Cover the AC slice in play: happy path, empty/omit, boundary, sibling/isolation, error/denied. One red test per AC row. Vertical slices, not all-tests-then-all-code.
 4. **Addressing Reviewer Findings**:
    - In subsequent iterations, ingest findings from the [Devil's Advocate](file:///Users/egagofur/Development/work/ai-engineering-loop/agents/devil-advocate.md) and directives from the [Judge](file:///Users/egagofur/Development/work/ai-engineering-loop/agents/judge.md).
    - Fix validated issues surgically.

package/agents/shared/devil-advocate.body.md

@@ -22,7 +22,7 @@ Do not ask for Maker rationale.
 
 Report Spec and Standards as separate findings. Do not rerank one axis with the other. A change can pass Spec and fail Standards, or the reverse. Do not spawn children to split axes.
 
-**Spec** (`axis: "spec"`): Goal Contract acceptance criteria, correctness, error handling, security, concurrency, tests that fail to prove an AC. BLOCKER or HIGH only for a real AC breach or runtime defect.
+**Spec** (`axis: "spec"`): Goal Contract acceptance criteria, correctness, error handling, security, concurrency, tests that fail to prove an AC, happy-path-only suite vs written failure table. BLOCKER or HIGH only for a real AC breach or runtime defect.
 
 **Standards** (`axis: "standards"`): `.ai-engineering-loop/conventions.md` plus the smell baseline below. Judgement calls: severity MEDIUM or LOW. Set `hardConvention: true` only when conventions.md states a hard rule that this hunk violates. A smell that hides an AC defect is Spec, not Standards.
 

package/agents/shared/judge.body.md

@@ -10,7 +10,7 @@ Use only paths in the spawn prompt: Goal Contract, verification evidence, Findin
 
 AC source is the Goal Contract **file** only. Chat `setuju` and the parent transcript are not AC. Do not PASS because the parent agreed in chat. `CONTEXT_ISOLATION_ONLY` does not relax this.
 
-ITERATE if verification is missing, vague, non-zero, proves a different artifact than the AC names, or is only a source grep.
+ITERATE if verification is missing, vague, non-zero, proves a different artifact than the AC names, is only a source grep, or is happy-path-only while the Goal Contract lists empty, boundary, sibling, or error rows.
 
 ## Axes
 

package/bin/ai-engineering-loop.js

@@ -21,7 +21,7 @@ const {
   formatHostSyncReport
 } = require('../lib/sync-hosts.js');
 
-const VERSION = '1.0.13';
+const VERSION = '1.0.15';
 const CWD = process.cwd();
 const CONTEXT_DIR = path.join(CWD, '.ai-engineering-loop');
 
@@ -275,7 +275,7 @@ function generateContextFiles(rootDir, discovery, trigger = 'init', impact = 'IN
 
   // 0. metadata.json (Baseline)
   const metadataJson = {
-    contextVersion: '1.0.13',
+    contextVersion: '1.0.15',
     generatedAt: new Date().toISOString(),
     repositoryRevision: currentRevision,
     projectProfile: discovery.profile,

package/core/goal-contract.md

@@ -29,9 +29,15 @@ Every Goal Contract MUST adhere to the following schema in Markdown or structure
 [Explain what changes for the real-world actor (e.g. Employee, Admin, Customer, System). Describe the before/after lifecycle state transition.]
 
 ## 3. Acceptance Criteria (AC)
-- [ ] AC-1: [Exact, testable statement with expected outcome]
-- [ ] AC-2: [Exact, testable statement with expected outcome]
-- [ ] AC-3: [Edge case or boundary behavior explicitly specified]
+Each AC is one row that can **fail**. Happy path alone is not a contract (`policies/tdd-policy.md`).
+
+| AC | Input / actor | Expected at seam | Must fail if missing |
+|---|---|---|---|
+| AC-1 | Happy path | [observable] | [what would still look green] |
+| AC-2 | Empty / omitted field | [observable] | [what would still look green] |
+| AC-3 | Boundary | [observable] | [what would still look green] |
+| AC-4 | Sibling / isolation (if domain has siblings) | [observable] | [what would still look green] |
+| AC-5 | Error / denied / locked | [observable] | [what would still look green] |
 
 ## 4. Technical Constraints
 - [Architecture]: [Preserve existing patterns, layer boundaries, dependency conventions]
@@ -105,3 +111,4 @@ Every single item listed under `Acceptance Criteria` must map to at least one co
 - **The Self-Serving Goal**: Modifying acceptance criteria post-hoc when tests fail rather than fixing the underlying implementation.
 - **The Chat Contract**: Treating "setuju" in the parent transcript as AC. The file is the contract.
 - **The Wrong Artifact**: Tests pass on a `/tmp` build while the sample the user opens omits the feature.
+- **The Happy-Path Contract**: Only the sunny case is an AC. Coverage % is not a substitute for a failure table.

package/core/grill-policy.md

@@ -45,22 +45,26 @@ Before Maker starts:
 
 If a decision was agreed in chat and is missing from the file, the contract is not frozen. Do not start Maker.
 
-## DOT adapter (`adapter_type: dot`)
+## Business blast radius
 
-On DOT repositories, grill is **one** session that includes the four-pillar blast radius from Antigravity skill `task-impact-inquiry` (`~/.gemini/config/skills/task-impact-inquiry/SKILL.md`). Do not run that skill as a second interview after grill.
+Green unit tests are not proof that sibling rows, approvals, or downstream jobs survived.
 
-The four pillars must appear in the grill (and then in the Goal Contract) whenever the change can touch:
+When the change can touch state, siblings, actors/approvals, or downstream work, grill **must** include blast radius — even if AC look obvious or the user said "just do it". Typo, lint, and version-bump skips still apply.
 
-1. State and condition permutations (status, overtime vs normal hours, locked vs open periods)
-2. Sibling / historical isolation (other entities in the same parent, period, or cart)
-3. Actor and approval authority (who edits, when an existing approval is void vs kept)
-4. Downstream jobs and queues (BullMQ, cron, payroll/aggregates)
+On `adapter_type: dot`, this is mandatory. On other adapters, skip only when the change cannot touch those four (copy, CSS, comment).
 
-**Do not skip grill** for those four cases, even if AC look obvious or the user said "just do it". Typo, lint, and version-bump skips still apply.
+Canonical skill: `adapters/dot/skills/task-impact-inquiry/SKILL.md`. Host copies via `sync-hosts`: `~/.claude/skills/task-impact-inquiry/`, `~/.grok/skills/task-impact-inquiry/`, `~/.gemini/config/skills/task-impact-inquiry/`. Load that skill if present. If it is missing, still run this section. Do not claim the skill ran.
 
-If the skill file is missing on this host, still ask the four pillars from this section. Do not claim the Gemini skill ran.
+If Stage 1 grill already produced the matrix and the user confirmed it, do not run a second interview.
 
-Present the impact matrix and 2–3 probing questions in the same grill round as other Stage 1 decisions. Recommended answers required. After the frontier is empty, freeze the Goal Contract once.
+In the same grill round:
+
+1. Look up the current flow. Draw an ASCII lifecycle (actor → status → lock). Do not ask look-up facts.
+2. Scan four pillars: state/conditions; sibling/historical isolation; actor and approval (void vs keep); downstream jobs and queues.
+3. ASCII blast-radius picture. No mermaid.
+4. Impact matrix (happy, empty/omit, boundary, sibling, error). Sunny-path-only is not done.
+5. 2–3 probing questions with recommended answers. Wait.
+6. Each accepted row becomes a numbered AC in the Goal Contract **file** (failure table).
 
 ## Design tree
 
@@ -80,12 +84,14 @@ The grill is done when the frontier is empty: every branch visited, nothing sile
 ## What the grill must settle
 
 - Objective and business outcome
-- Acceptance criteria that can fail a test
+- Acceptance criteria that can fail a test, as a **failure table** (not happy path only)
 - Out of scope
 - Test **seams** (public interfaces to observe; prefer existing seams; fewer is better)
 - Glossary terms to use (read and update `.ai-engineering-loop/glossary.md`)
 - Hard decisions that belong in an ADR under `.ai-engineering-loop/adrs/`
 
+A Goal Contract with only the sunny path is not frozen. Include at least: happy path, empty/omitted input, one boundary, one isolation/sibling (when the domain has siblings), one error/denied path. DOT four-pillar rows count toward this table.
+
 ## Invariants
 
 - No production code edits during grill.

package/core/judge-policy.md

@@ -64,6 +64,7 @@ The Judge renders decisions based strictly on **Validity + Severity**, then **re
   2. Active iteration count is below MAX_ITERATIONS (default 3).
   3. Maker or verification cites chat agreement for behavior that is not an AC in the Goal Contract file.
   4. Evidence is for the wrong artifact, is source-grep only, or does not map to written AC ids.
+  5. The suite is happy-path-only while the Goal Contract lists empty, boundary, sibling, or error AC rows.
 - **Maker Directive**: The Maker must adopt the concrete alternative diff or provide an equivalent verified architectural resolution, authoring regression unit tests.
 
 ---

package/core/verification-loop.md

@@ -22,7 +22,7 @@ A verification `PASS` is **strictly invalid** without concrete execution evidenc
 5. **`stdout` & `stderr`**: Raw machine logs captured from execution.
 6. **`timeoutStatus`**: Must be `"COMPLETED"` (not timed out or backgrounded without completion).
 7. **`testCounts`**: Explicit counts of passed, failed, and skipped tests.
-8. **`assertionEvidence`**: Specific assertion proof matching the active Goal Contract's Acceptance Criteria, observed at a named test seam.
+8. **`assertionEvidence`**: Specific assertion proof matching the active Goal Contract's Acceptance Criteria, observed at a named test seam. Must include a non-happy-path AC when the contract has a failure table. Coverage percent is not assertionEvidence.
 
 ```json
 {
@@ -61,3 +61,5 @@ The Verification Gate immediately halts and returns to the Maker if:
 - Exit code is non-zero.
 - The command was sent to the background and not verified to completion.
 - Test logs contain zero passing assertions for new acceptance criteria.
+- assertionEvidence maps only to a happy path while the Goal Contract lists empty, boundary, sibling, or error AC rows.
+- The only new "test" is a source grep or a coverage percentage.

package/examples/backend-api/payment-idempotency/README.md

@@ -22,12 +22,12 @@ Task: Implement atomic idempotency key validation and SELECT FOR UPDATE row lock
 
 ## 3. Walkthrough Artifacts
 
-1. **[Goal Contract (`goal-contract.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/backend-api/payment-idempotency/goal-contract.md)**:
+1. **[Goal Contract (`goal-contract.md`)](./goal-contract.md)**:
    - AC-1: Idempotency-Key header mandatory on POST `/api/v1/payments/charge`.
    - AC-2: Atomic reservation using PostgreSQL `INSERT ... ON CONFLICT DO NOTHING`.
    - AC-3: Concurrent requests for same user wallet serialized with `SELECT ... FOR UPDATE`.
-2. **[Adversarial Review Findings (`review-findings.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/backend-api/payment-idempotency/review-findings.md)**:
+2. **[Adversarial Review Findings (`review-findings.md`)](./review-findings.md)**:
    - Devil's Advocate activates `backend-api` rules (concurrency, database atomicity).
    - Flags missing rollback on external gateway timeout (`ERR-001`).
-3. **[Judge Verdict (`judge-verdict.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/backend-api/payment-idempotency/judge-verdict.md)**:
+3. **[Judge Verdict (`judge-verdict.md`)](./judge-verdict.md)**:
    - Evaluates parallel test execution (`go test -race ./...`), verifies concurrency safety, and issues `PASS` verdict.

package/examples/dot/status-display/README.md

@@ -0,0 +1,23 @@
+# Reference Example: Request Display Status Fix
+
+## 1. Context & Scenario
+
+This walkthrough shows how a status-display bug moves through the **AI Engineering Loop** and the **DOT Delivery Adapter**. Names, URLs, and schema below are **fictional**. Do not copy real client tickets, GitLab links, or field names into this package.
+
+### The Problem
+
+On an employee portal, request cards on the list and pagination endpoints showed `"PENDING"` after every line item was already approved or rejected. Non-standard-window records were also scored with the standard-day rule.
+
+---
+
+## 2. Walkthrough Stages & Artifacts
+
+1. **[Stage 1: Goal Contract (`goal-contract.md`)](./goal-contract.md)**:
+   - Objective, acceptance criteria (standard window, holiday, non-standard window, null values), and verification plan.
+2. **[Stage 2: Adversarial Review & Triage (`review-findings.md`)](./review-findings.md)**:
+   - Devil's Advocate flags a null-safety bug (`COR-001`) and an invalid nitpick (`MAINT-001`).
+   - Maker triage and surgical fix.
+3. **[Stage 3: Judge Evaluation & Verdict (`judge-verdict.md`)](./judge-verdict.md)**:
+   - Audit of tests, typecheck, finding resolutions, and `PASS`.
+4. **[Stage 4: DOT Delivery Pipeline (`delivery-report.md`)](./delivery-report.md)**:
+   - Fictional issue, base MR, cherry-picks to `staging` and `develop`, Coreview triage, Mattermost notice.

package/examples/dot/status-display/delivery-report.md

@@ -0,0 +1,41 @@
+# DOT Delivery Report: Request Display Status Fix
+
+Fictional sample. Replace host, group, repo, issue, and MR ids from `glab` output. Never paste real client URLs into this package.
+
+## 1. Summary of Delivery Actions
+
+1. **GitLab Issue Created**: [Issue #42 - [BE] [Requests] Fix display status](https://gitlab.example.com/example-org/work-portal/-/issues/42).
+2. **Primary MR Created**: [MR !10 targeting `main`](https://gitlab.example.com/example-org/work-portal/-/merge_requests/10).
+3. **Multi-Branch Cherry-Pick**:
+   - [MR !11 targeting `staging`](https://gitlab.example.com/example-org/work-portal/-/merge_requests/11).
+   - [MR !12 targeting `develop`](https://gitlab.example.com/example-org/work-portal/-/merge_requests/12).
+4. **Coreview Bot Triage**:
+   - Comments fetched on MR !12. Zero blocking comments.
+5. **Mattermost Notification**:
+   - Resolved repository `example-org/work-portal` to channel `"team-work-portal"`.
+   - Dispatched via MCP `mattermost_send_message` with `from: "AI Agent"`.
+
+---
+
+## 2. GitLab Links
+
+| Artifact | Branch | Link |
+|---|---|---|
+| **GitLab Issue** | — | [Issue #42](https://gitlab.example.com/example-org/work-portal/-/issues/42) |
+| **Merge Request DEV** | `develop` | [MR !12](https://gitlab.example.com/example-org/work-portal/-/merge_requests/12) |
+| **Merge Request STAGING** | `staging` | [MR !11](https://gitlab.example.com/example-org/work-portal/-/merge_requests/11) |
+| **Merge Request MAIN** | `main` | [MR !10](https://gitlab.example.com/example-org/work-portal/-/merge_requests/10) |
+
+---
+
+## 3. Dispatched Mattermost Notification
+
+```text
+[MR DEV] https://gitlab.example.com/example-org/work-portal/-/merge_requests/12
+Changes log
+- Include standard-window and rush-note fields when loading request list pages.
+- Resolve display status from all line items, including holiday and null collections.
+- Add unit tests for standard, holiday, non-standard-window, and null line-item cases.
+
+cc: @owner
+```

package/examples/dot/status-display/goal-contract.md

@@ -0,0 +1,46 @@
+# Goal Contract: Request Display Status Fix
+
+## 1. Objective
+
+Fix incorrect display status on list and pagination endpoints when a request has mixed line items, holiday logs, non-standard windows, or null collections.
+
+## 2. Business Outcome & User Lifecycle Impact
+
+- **Employees**: See APPROVED, REJECTED, or NEED_APPROVAL matching the real record.
+- **Reviewers**: Stop getting false pending notices for already-settled holiday logs.
+- **Finance**: Totals used by the downstream aggregate job stay consistent.
+
+## 3. Acceptance Criteria (AC)
+
+- [ ] **AC-1**: If `hasStandardWindow = true` and `duration` is within the standard day limit on a weekday without a rush note, display status is `APPROVED` or `NEED_APPROVAL` from clock-in/out presence only.
+- [ ] **AC-2**: If a rush note exists, or duration exceeds the standard limit, or `isHoliday = true`, evaluate pending status across all associated `lineItems`.
+- [ ] **AC-3**: Non-standard-window records (`user.type.hasStandardWindow = false`) must not use the weekday duration threshold.
+- [ ] **AC-4**: Null or missing `lineItems` default to `APPROVED` without throwing `TypeError`.
+- [ ] **AC-5**: The existing API response contract is unchanged.
+
+## 4. Technical Constraints
+
+- Keep the existing list/pagination query shape.
+- Centralize logic in a pure function: `resolveRequestDisplayStatus`.
+- No new runtime dependencies.
+- `tsc --noEmit` exits 0.
+
+## 5. Out of Scope
+
+- Frontend layout changes.
+- Database migrations.
+- Changing the downstream aggregate/export job.
+
+## 6. Verification Requirements
+
+- **Unit Tests**: Jest suite at `src/server/requests/utils/resolve-display-status.test.ts`.
+- **Typecheck**: `npx tsc --noEmit` exits 0.
+- **Linter**: `npx eslint --fix` on modified files, 0 errors.
+- **Regression**: commands in `.ai-engineering-loop/verification.md` (example: `npx jest && npx tsc --noEmit`).
+
+## 7. Definition of Done (DoD)
+
+- [ ] AC-1 through AC-5 proven by unit tests.
+- [ ] Deterministic verification passes.
+- [ ] Devil's Advocate review with 0 unresolved blocking findings.
+- [ ] Judge issues PASS.

package/examples/dot/status-display/judge-verdict.md

@@ -0,0 +1,44 @@
+# Judge Evaluation Report: Request Display Status Fix
+
+## 1. Executive Verdict
+
+- **Verdict**: `PASS`
+- **Iteration**: `Iteration 2 of 3`
+- **Confidence**: `HIGH`
+
+---
+
+## 2. Deterministic Verification Audit
+
+| Check | Command Executed | Raw Result | Status |
+|---|---|---|:---:|
+| **Unit Tests** | `npx jest src/server/requests/utils/resolve-display-status.test.ts` | `Tests: 12 passed, 12 total.` | PASS |
+| **Full Suite** | `npx jest && npx tsc --noEmit` | `Test Suites: 12 passed. tsc exit 0.` | PASS |
+| **TypeScript** | `npx tsc --noEmit` | `Exit code 0.` | PASS |
+| **Linter** | `npx eslint --fix src/server/requests/**` | `0 errors.` | PASS |
+
+---
+
+## 3. Goal Contract Compliance Audit
+
+| Criterion | Verified By Test / Artifact | Result |
+|---|---|:---:|
+| **AC-1**: Standard-window weekday | `resolve-display-status.test.ts > standard window` | PASS |
+| **AC-2**: Holiday and over-limit handling | `resolve-display-status.test.ts > holiday rush` | PASS |
+| **AC-3**: Non-standard-window records | `resolve-display-status.test.ts > non-standard window` | PASS |
+| **AC-4**: Null `lineItems` | `resolve-display-status.test.ts > null safety` | PASS |
+| **AC-5**: API contract | router typecheck | PASS |
+
+---
+
+## 4. Finding Triage Audit
+
+- **COR-001 (High - Null Safety)**: Maker applied null coalescing in Iteration 2. **Status: RESOLVED & VERIFIED**.
+- **MAINT-001 (Low - Factory Suggestion)**: Invalid speculative nitpick. **Status: DISMISSED / INVALID**.
+
+---
+
+## 5. Formal Conclusion & Hand-off
+
+Definition of Done is met with reproducible evidence.
+**Authorized next action**: DOT Delivery Adapter (`adapters/dot/README.md`) for GitLab MR, multi-branch cherry-pick, Coreview triage, and Mattermost.

package/examples/dot/status-display/review-findings.md

@@ -0,0 +1,63 @@
+# Adversarial Review Findings & Triage: Request Display Status Fix
+
+## 1. Review Summary
+
+- **Reviewer**: Devil's Advocate Agent
+- **Target Branch**: `main...fix/request-display-status`
+- **Total Findings**: 2
+- **Blocking (SEV-1/2)**: 1
+- **Non-Blocking / Invalid**: 1
+
+---
+
+## 2. Findings Ledger
+
+### Finding COR-001: Missing null safety when iterating `lineItems`
+
+- **Severity**: `HIGH` (SEV-2)
+- **Category**: `Correctness`
+- **Location**: `src/server/requests/utils/resolve-display-status.ts:34-41`
+- **Evidence**:
+
+```typescript
+const hasPending = confirmation.lineItems.some(
+  (item) => item.status === "NEED_APPROVAL"
+);
+```
+
+- **Problem**:
+  If `confirmation.lineItems` is `null` or `undefined` (legacy rows), `.some()` throws `TypeError`.
+- **Impact**:
+  Pagination API crashes for historical records.
+- **Recommendation**:
+
+```diff
+- const hasPending = confirmation.lineItems.some(
++ const hasPending = (confirmation.lineItems ?? []).some(
+    (item) => item.status === "NEED_APPROVAL"
+  );
+```
+
+- **Confidence**: `HIGH`
+- **Status**: `TRIAGED_VALID`
+- **Resolution**:
+  Maker applied `(confirmation.lineItems ?? [])` and added `should return APPROVED when lineItems is null or undefined`.
+
+---
+
+### Finding MAINT-001: Suggestion to convert helper into an abstract factory class
+
+- **Severity**: `LOW` (SEV-4)
+- **Category**: `Maintainability`
+- **Location**: `src/server/requests/utils/resolve-display-status.ts:1-50`
+- **Evidence**:
+  Utility is `export function resolveRequestDisplayStatus(...)`.
+- **Problem**:
+  Reviewer wanted a Strategy/Factory for future calculator swaps.
+- **Impact**:
+  None. Pure functions match this repo.
+- **Recommendation**: Refactor to `class StatusCalculatorFactory`.
+- **Confidence**: `LOW`
+- **Status**: `TRIAGED_INVALID`
+- **Triage Reason**:
+  Speculative overengineering. Constraint: surgical change, no extra abstractions.

package/examples/initialization/README.md

@@ -13,7 +13,7 @@ This walkthrough demonstrates how the **AI Engineering Loop** automatically init
 
 ## 2. Walkthrough Artifacts
 
-1. **[Discovery Execution Trace (`discovery-trace.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/initialization/discovery-trace.md)**:
+1. **[Discovery Execution Trace (`discovery-trace.md`)](./discovery-trace.md)**:
    - Full 5-pass log of directory inspection, manifest parsing, script discovery, architecture tracing, and second-pass quality check.
-2. **[Generated Context Artifacts (`generated-context.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/initialization/generated-context.md)**:
+2. **[Generated Context Artifacts (`generated-context.md`)](./generated-context.md)**:
    - The exact evidence-based `.ai-engineering-loop/` files generated automatically by the agent without user intervention.

package/examples/initialization/discovery-trace.md

@@ -18,7 +18,7 @@
   - `packages/` (contains `ui/`, `database/`, `shared/`)
   - `pnpm-workspace.yaml` (detected `pnpm` monorepo)
   - `turbo.json` (detected Turborepo pipeline)
-- **Profile Binding**: Bound [`profiles/monorepo.md`](file:///Users/egagofur/Development/work/ai-engineering-loop/profiles/monorepo.md).
+- **Profile Binding**: Bound [`profiles/monorepo.md`](../../profiles/monorepo.md).
 
 ### Pass 2: Manifests & Verification Commands Discovery
 - Parsed `package.json` (root):

package/examples/mobile-app/offline-sync-queue/README.md

@@ -22,12 +22,12 @@ Task: Implement persistent offline SQLite mutation queue with exponential backof
 
 ## 3. Walkthrough Artifacts
 
-1. **[Goal Contract (`goal-contract.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/mobile-app/offline-sync-queue/goal-contract.md)**:
+1. **[Goal Contract (`goal-contract.md`)](./goal-contract.md)**:
    - AC-1: All form submissions persist immediately to local SQLite `mutation_queue` table before network dispatch.
    - AC-2: Background sync engine triggers on network restoration with exponential backoff.
    - AC-3: OS suspension / app kill must not drop un-synced items.
-2. **[Adversarial Review Findings (`review-findings.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/mobile-app/offline-sync-queue/review-findings.md)**:
+2. **[Adversarial Review Findings (`review-findings.md`)](./review-findings.md)**:
    - Devil's Advocate activates `mobile-app` rules (offline persistence, lifecycle, battery).
    - Flags missing disk write error handling when device storage is full (`PERF-001`).
-3. **[Judge Verdict (`judge-verdict.md`)](file:///Users/egagofur/Development/work/ai-engineering-loop/examples/mobile-app/offline-sync-queue/judge-verdict.md)**:
+3. **[Judge Verdict (`judge-verdict.md`)](./judge-verdict.md)**:
    - Audits Flutter unit & mock network tests, verifies 100% pass, and issues `PASS` verdict.

package/lib/sync-hosts.js

@@ -33,6 +33,7 @@ function hostFileMap(home) {
       root: claude,
       files: [
         { src: '.claude/skills/ai-engineering-loop/SKILL.md', dest: path.join(claude, 'skills/ai-engineering-loop/SKILL.md'), mode: 'upsert' },
+        { src: 'adapters/dot/skills/task-impact-inquiry/SKILL.md', dest: path.join(claude, 'skills/task-impact-inquiry/SKILL.md'), mode: 'upsert' },
         { src: '.claude/agents/devil-advocate.md', dest: path.join(claude, 'agents/devil-advocate.md'), mode: 'upsert' },
         { src: '.claude/agents/judge.md', dest: path.join(claude, 'agents/judge.md'), mode: 'upsert' },
         { src: '.claude/commands/ai-engineering-loop.md', dest: path.join(claude, 'commands/ai-engineering-loop.md'), mode: 'upsert' }
@@ -43,6 +44,7 @@ function hostFileMap(home) {
       root: grok,
       files: [
         { src: '.grok/skills/ai-engineering-loop/SKILL.md', dest: path.join(grok, 'skills/ai-engineering-loop/SKILL.md'), mode: 'upsert', grokSkillOverlay: true },
+        { src: 'adapters/dot/skills/task-impact-inquiry/SKILL.md', dest: path.join(grok, 'skills/task-impact-inquiry/SKILL.md'), mode: 'upsert', grokSkillOverlay: true },
         { src: '.grok/agents/devil-advocate.md', dest: path.join(grok, 'agents/devil-advocate.md'), mode: 'upsert' },
         { src: '.grok/agents/judge.md', dest: path.join(grok, 'agents/judge.md'), mode: 'upsert' },
         { src: '.grok/commands/ai-engineering-loop.md', dest: path.join(grok, 'commands/ai-engineering-loop.md'), mode: 'upsert' }
@@ -52,7 +54,8 @@ function hostFileMap(home) {
       id: 'gemini',
       root: gemini,
       files: [
-        { src: '.gemini/skills/ai-engineering-loop/SKILL.md', dest: path.join(gemini, 'config/skills/ai-engineering-loop/SKILL.md'), mode: 'upsert' }
+        { src: '.gemini/skills/ai-engineering-loop/SKILL.md', dest: path.join(gemini, 'config/skills/ai-engineering-loop/SKILL.md'), mode: 'upsert' },
+        { src: 'adapters/dot/skills/task-impact-inquiry/SKILL.md', dest: path.join(gemini, 'config/skills/task-impact-inquiry/SKILL.md'), mode: 'upsert' }
       ]
     },
     {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ai-engineering-loop",
-  "version": "1.0.13",
+  "version": "1.0.15",
   "description": "A reusable, framework-agnostic AI Engineering Operating System for autonomous coding agents.",
   "main": "bin/ai-engineering-loop.js",
   "bin": {