agentvibes 5.6.0 → 5.6.2

package/src/services/config-service.js

@@ -1,264 +1,264 @@
-/**
- * AgentVibes Config Service
- * Story 6.5: Command Routing & Entry Points (isInstalled, isBmadDetected stubs)
- * Story 7.1: Provider & Voice Settings Group (full read/write implementation)
- *
- * Provides config hierarchy: global (~/.agentvibes/config.json)
- * + project-level overrides (<projectRoot>/.agentvibes/config.json).
- * All path operations use path.resolve() to prevent traversal.
- * Config writes are atomic (write .tmp → rename) with chmod 600.
- */
-
-import fs from 'node:fs';
-import os from 'node:os';
-import path from 'node:path';
-
-export class ConfigService {
-  /**
-   * @param {object} [opts]
-   * @param {string} [opts.projectRoot] - Project root for hook/config detection. Defaults to process.cwd().
-   * @param {string} [opts.homeDir]     - User home dir for global config. Defaults to os.homedir().
-   */
-  constructor(opts = {}) {
-    // path.resolve() on all roots prevents path-traversal at the source
-    this._projectRoot = path.resolve(opts.projectRoot ?? process.cwd());
-    this._homeDir = path.resolve(opts.homeDir ?? os.homedir());
-  }
-
-  /** Returns the resolved project root path. */
-  getProjectRoot() {
-    return this._projectRoot;
-  }
-
-  // ---------------------------------------------------------------------------
-  // Detection (story 6.5)
-
-  /**
-   * Returns true if AgentVibes hooks are installed in this project.
-   * Detection: .claude/hooks/play-tts.sh exists in projectRoot.
-   */
-  isInstalled() {
-    const hooksFile = path.resolve(this._projectRoot, '.claude', 'hooks', 'play-tts.sh');
-    return fs.existsSync(hooksFile);
-  }
-
-  /**
-   * Returns true if BMAD framework is detected.
-   * Checks: _bmad/ or .bmad/ in projectRoot, OR global voice map.
-   */
-  isBmadDetected() {
-    const checks = [
-      path.resolve(this._projectRoot, '_bmad'),
-      path.resolve(this._projectRoot, '.bmad'),
-      path.resolve(this._homeDir, '.agentvibes', 'bmad-voice-map.json'),
-    ];
-    return checks.some(p => fs.existsSync(p));
-  }
-
-  // ---------------------------------------------------------------------------
-  // Read (story 7.1)
-
-  /**
-   * Returns global config (~/.agentvibes/config.json).
-   * Returns {} if file does not exist.
-   */
-  getGlobalConfig() {
-    const filePath = path.resolve(this._homeDir, '.agentvibes', 'config.json');
-    return this._readConfigFile(filePath) ?? {};
-  }
-
-  /**
-   * Returns project config (<projectRoot>/.agentvibes/config.json) or null if not present.
-   */
-  getProjectConfig() {
-    const dir = path.resolve(this._projectRoot, '.agentvibes');
-    if (!fs.existsSync(dir)) return null;
-    const filePath = path.resolve(dir, 'config.json');
-    return this._readConfigFile(filePath);
-  }
-
-  /**
-   * Returns merged config: global + project overrides.
-   * Project config keys win on conflict (deep merge for nested objects).
-   */
-  getConfig() {
-    const global = this.getGlobalConfig();
-    const project = this.getProjectConfig();
-    return this._deepMerge(global, project);
-  }
-
-  /**
-   * Returns config schema version from merged config.
-   */
-  getVersion() {
-    return this.getConfig().version ?? '1.0';
-  }
-
-  // ---------------------------------------------------------------------------
-  // Path helpers
-
-  /** Returns the resolved global config file path. */
-  getGlobalConfigPath() {
-    return path.resolve(this._homeDir, '.agentvibes', 'config.json');
-  }
-
-  /** Returns the resolved local project config file path (regardless of whether it exists). */
-  getLocalConfigPath() {
-    return path.resolve(this._projectRoot, '.agentvibes', 'config.json');
-  }
-
-  /** Returns true if a local project config file exists. */
-  hasLocalConfig() {
-    return fs.existsSync(this.getLocalConfigPath());
-  }
-
-  // ---------------------------------------------------------------------------
-  // Bulk save
-
-  /**
-   * Overwrites the ENTIRE global config with the given object.
-   * Atomic write (tmp → rename). Creates dir if needed. chmod 600.
-   * @param {object} data
-   */
-  saveAllToGlobal(data) {
-    this._writeConfigAtomic(this.getGlobalConfigPath(), data);
-    this._syncToTextFiles(path.resolve(this._homeDir, '.claude'), data);
-  }
-
-  /**
-   * Overwrites the ENTIRE local project config with the given object.
-   * Atomic write (tmp → rename). Creates dir if needed. chmod 600.
-   * @param {object} data
-   */
-  saveAllToLocal(data) {
-    this._writeConfigAtomic(this.getLocalConfigPath(), data);
-    this._syncToTextFiles(path.resolve(this._projectRoot, '.claude'), data);
-  }
-
-  // ---------------------------------------------------------------------------
-  // Write (story 7.1)
-
-  /**
-   * Writes a key to project config if <projectRoot>/.agentvibes/ exists,
-   * otherwise writes to global config. Atomic write (tmp → rename). chmod 600.
-   * @param {string} key
-   * @param {*} value
-   */
-  set(key, value) {
-    const projDir = path.resolve(this._projectRoot, '.agentvibes');
-    if (fs.existsSync(projDir)) {
-      const filePath = path.resolve(projDir, 'config.json');
-      const current = this._readConfigFile(filePath) ?? {};
-      current[key] = value;
-      this._writeConfigAtomic(filePath, current);
-    } else {
-      this.setGlobal(key, value);
-    }
-  }
-
-  /**
-   * Always writes a key to global config (~/.agentvibes/config.json).
-   * Atomic write (tmp → rename). chmod 600. Creates dir if needed.
-   * @param {string} key
-   * @param {*} value
-   */
-  setGlobal(key, value) {
-    const filePath = path.resolve(this._homeDir, '.agentvibes', 'config.json');
-    const current = this._readConfigFile(filePath) ?? {};
-    current[key] = value;
-    this._writeConfigAtomic(filePath, current);
-  }
-
-  // ---------------------------------------------------------------------------
-  // Private helpers
-
-  /**
-   * Sync config.json values to .claude/ text files that TTS scripts read.
-   * Only writes files that the config has values for. Silently ignores errors.
-   * @param {string} claudeDir - Path to .claude/ directory
-   * @param {object} data - Config data object
-   */
-  _syncToTextFiles(claudeDir, data) {
-    if (!claudeDir || !data) return;
-    try {
-      if (!fs.existsSync(claudeDir)) return;
-      if (data.voice) {
-        fs.writeFileSync(path.join(claudeDir, 'tts-voice.txt'), String(data.voice));
-      }
-      if (data.provider) {
-        fs.writeFileSync(path.join(claudeDir, 'tts-provider.txt'), String(data.provider));
-      }
-      if (data.verbosity) {
-        fs.writeFileSync(path.join(claudeDir, 'tts-verbosity.txt'), String(data.verbosity));
-      }
-    } catch { /* best-effort sync */ }
-  }
-
-  /**
-   * Read and parse a JSON config file.
-   * Returns null if the file does not exist or is not a regular file.
-   * @param {string} filePath
-   * @returns {object|null}
-   */
-  _readConfigFile(filePath) {
-    if (!fs.existsSync(filePath)) return null;
-    try {
-      const raw = fs.readFileSync(filePath, 'utf8');
-      return JSON.parse(raw);
-    } catch {
-      // Corrupt or unreadable — treat as missing
-      return null;
-    }
-  }
-
-  /**
-   * Deep-merge two plain objects. Values from `override` win on conflict.
-   * Arrays are replaced (not merged). null override → returns copy of base.
-   * @param {object} base
-   * @param {object|null} override
-   * @returns {object}
-   */
-  _deepMerge(base, override) {
-    if (!override || typeof override !== 'object') return { ...base };
-    const result = { ...base };
-    for (const [k, v] of Object.entries(override)) {
-      if (
-        v !== null &&
-        typeof v === 'object' &&
-        !Array.isArray(v) &&
-        typeof result[k] === 'object' &&
-        result[k] !== null &&
-        !Array.isArray(result[k])
-      ) {
-        result[k] = this._deepMerge(result[k], v);
-      } else {
-        result[k] = v;
-      }
-    }
-    return result;
-  }
-
-  /**
-   * Atomically write data as JSON to filePath.
-   * Writes to {filePath}.tmp then renames — safe against partial reads.
-   * Creates parent directory if needed. Sets file permissions to 0o600.
-   * @param {string} filePath
-   * @param {object} data
-   */
-  _writeConfigAtomic(filePath, data) {
-    const dir = path.dirname(filePath);
-    fs.mkdirSync(dir, { recursive: true });
-
-    const tmpPath = `${filePath}.tmp`;
-    const json = JSON.stringify(data, null, 2);
-
-    // Write to tmp, then atomic rename
-    fs.writeFileSync(tmpPath, json, { encoding: 'utf8', mode: 0o600 });
-    fs.renameSync(tmpPath, filePath);
-
-    // Ensure correct permissions on final file
-    fs.chmodSync(filePath, 0o600);
-  }
-}
-
-export default ConfigService;
+/**
+ * AgentVibes Config Service
+ * Story 6.5: Command Routing & Entry Points (isInstalled, isBmadDetected stubs)
+ * Story 7.1: Provider & Voice Settings Group (full read/write implementation)
+ *
+ * Provides config hierarchy: global (~/.agentvibes/config.json)
+ * + project-level overrides (<projectRoot>/.agentvibes/config.json).
+ * All path operations use path.resolve() to prevent traversal.
+ * Config writes are atomic (write .tmp → rename) with chmod 600.
+ */
+
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+
+export class ConfigService {
+  /**
+   * @param {object} [opts]
+   * @param {string} [opts.projectRoot] - Project root for hook/config detection. Defaults to process.cwd().
+   * @param {string} [opts.homeDir]     - User home dir for global config. Defaults to os.homedir().
+   */
+  constructor(opts = {}) {
+    // path.resolve() on all roots prevents path-traversal at the source
+    this._projectRoot = path.resolve(opts.projectRoot ?? process.cwd());
+    this._homeDir = path.resolve(opts.homeDir ?? os.homedir());
+  }
+
+  /** Returns the resolved project root path. */
+  getProjectRoot() {
+    return this._projectRoot;
+  }
+
+  // ---------------------------------------------------------------------------
+  // Detection (story 6.5)
+
+  /**
+   * Returns true if AgentVibes hooks are installed in this project.
+   * Detection: .claude/hooks/play-tts.sh exists in projectRoot.
+   */
+  isInstalled() {
+    const hooksFile = path.resolve(this._projectRoot, '.claude', 'hooks', 'play-tts.sh');
+    return fs.existsSync(hooksFile);
+  }
+
+  /**
+   * Returns true if BMAD framework is detected.
+   * Checks: _bmad/ or .bmad/ in projectRoot, OR global voice map.
+   */
+  isBmadDetected() {
+    const checks = [
+      path.resolve(this._projectRoot, '_bmad'),
+      path.resolve(this._projectRoot, '.bmad'),
+      path.resolve(this._homeDir, '.agentvibes', 'bmad-voice-map.json'),
+    ];
+    return checks.some(p => fs.existsSync(p));
+  }
+
+  // ---------------------------------------------------------------------------
+  // Read (story 7.1)
+
+  /**
+   * Returns global config (~/.agentvibes/config.json).
+   * Returns {} if file does not exist.
+   */
+  getGlobalConfig() {
+    const filePath = path.resolve(this._homeDir, '.agentvibes', 'config.json');
+    return this._readConfigFile(filePath) ?? {};
+  }
+
+  /**
+   * Returns project config (<projectRoot>/.agentvibes/config.json) or null if not present.
+   */
+  getProjectConfig() {
+    const dir = path.resolve(this._projectRoot, '.agentvibes');
+    if (!fs.existsSync(dir)) return null;
+    const filePath = path.resolve(dir, 'config.json');
+    return this._readConfigFile(filePath);
+  }
+
+  /**
+   * Returns merged config: global + project overrides.
+   * Project config keys win on conflict (deep merge for nested objects).
+   */
+  getConfig() {
+    const global = this.getGlobalConfig();
+    const project = this.getProjectConfig();
+    return this._deepMerge(global, project);
+  }
+
+  /**
+   * Returns config schema version from merged config.
+   */
+  getVersion() {
+    return this.getConfig().version ?? '1.0';
+  }
+
+  // ---------------------------------------------------------------------------
+  // Path helpers
+
+  /** Returns the resolved global config file path. */
+  getGlobalConfigPath() {
+    return path.resolve(this._homeDir, '.agentvibes', 'config.json');
+  }
+
+  /** Returns the resolved local project config file path (regardless of whether it exists). */
+  getLocalConfigPath() {
+    return path.resolve(this._projectRoot, '.agentvibes', 'config.json');
+  }
+
+  /** Returns true if a local project config file exists. */
+  hasLocalConfig() {
+    return fs.existsSync(this.getLocalConfigPath());
+  }
+
+  // ---------------------------------------------------------------------------
+  // Bulk save
+
+  /**
+   * Overwrites the ENTIRE global config with the given object.
+   * Atomic write (tmp → rename). Creates dir if needed. chmod 600.
+   * @param {object} data
+   */
+  saveAllToGlobal(data) {
+    this._writeConfigAtomic(this.getGlobalConfigPath(), data);
+    this._syncToTextFiles(path.resolve(this._homeDir, '.claude'), data);
+  }
+
+  /**
+   * Overwrites the ENTIRE local project config with the given object.
+   * Atomic write (tmp → rename). Creates dir if needed. chmod 600.
+   * @param {object} data
+   */
+  saveAllToLocal(data) {
+    this._writeConfigAtomic(this.getLocalConfigPath(), data);
+    this._syncToTextFiles(path.resolve(this._projectRoot, '.claude'), data);
+  }
+
+  // ---------------------------------------------------------------------------
+  // Write (story 7.1)
+
+  /**
+   * Writes a key to project config if <projectRoot>/.agentvibes/ exists,
+   * otherwise writes to global config. Atomic write (tmp → rename). chmod 600.
+   * @param {string} key
+   * @param {*} value
+   */
+  set(key, value) {
+    const projDir = path.resolve(this._projectRoot, '.agentvibes');
+    if (fs.existsSync(projDir)) {
+      const filePath = path.resolve(projDir, 'config.json');
+      const current = this._readConfigFile(filePath) ?? {};
+      current[key] = value;
+      this._writeConfigAtomic(filePath, current);
+    } else {
+      this.setGlobal(key, value);
+    }
+  }
+
+  /**
+   * Always writes a key to global config (~/.agentvibes/config.json).
+   * Atomic write (tmp → rename). chmod 600. Creates dir if needed.
+   * @param {string} key
+   * @param {*} value
+   */
+  setGlobal(key, value) {
+    const filePath = path.resolve(this._homeDir, '.agentvibes', 'config.json');
+    const current = this._readConfigFile(filePath) ?? {};
+    current[key] = value;
+    this._writeConfigAtomic(filePath, current);
+  }
+
+  // ---------------------------------------------------------------------------
+  // Private helpers
+
+  /**
+   * Sync config.json values to .claude/ text files that TTS scripts read.
+   * Only writes files that the config has values for. Silently ignores errors.
+   * @param {string} claudeDir - Path to .claude/ directory
+   * @param {object} data - Config data object
+   */
+  _syncToTextFiles(claudeDir, data) {
+    if (!claudeDir || !data) return;
+    try {
+      if (!fs.existsSync(claudeDir)) return;
+      if (data.voice) {
+        fs.writeFileSync(path.join(claudeDir, 'tts-voice.txt'), String(data.voice));
+      }
+      if (data.provider) {
+        fs.writeFileSync(path.join(claudeDir, 'tts-provider.txt'), String(data.provider));
+      }
+      if (data.verbosity) {
+        fs.writeFileSync(path.join(claudeDir, 'tts-verbosity.txt'), String(data.verbosity));
+      }
+    } catch { /* best-effort sync */ }
+  }
+
+  /**
+   * Read and parse a JSON config file.
+   * Returns null if the file does not exist or is not a regular file.
+   * @param {string} filePath
+   * @returns {object|null}
+   */
+  _readConfigFile(filePath) {
+    if (!fs.existsSync(filePath)) return null;
+    try {
+      const raw = fs.readFileSync(filePath, 'utf8');
+      return JSON.parse(raw);
+    } catch {
+      // Corrupt or unreadable — treat as missing
+      return null;
+    }
+  }
+
+  /**
+   * Deep-merge two plain objects. Values from `override` win on conflict.
+   * Arrays are replaced (not merged). null override → returns copy of base.
+   * @param {object} base
+   * @param {object|null} override
+   * @returns {object}
+   */
+  _deepMerge(base, override) {
+    if (!override || typeof override !== 'object') return { ...base };
+    const result = { ...base };
+    for (const [k, v] of Object.entries(override)) {
+      if (
+        v !== null &&
+        typeof v === 'object' &&
+        !Array.isArray(v) &&
+        typeof result[k] === 'object' &&
+        result[k] !== null &&
+        !Array.isArray(result[k])
+      ) {
+        result[k] = this._deepMerge(result[k], v);
+      } else {
+        result[k] = v;
+      }
+    }
+    return result;
+  }
+
+  /**
+   * Atomically write data as JSON to filePath.
+   * Writes to {filePath}.tmp then renames — safe against partial reads.
+   * Creates parent directory if needed. Sets file permissions to 0o600.
+   * @param {string} filePath
+   * @param {object} data
+   */
+  _writeConfigAtomic(filePath, data) {
+    const dir = path.dirname(filePath);
+    fs.mkdirSync(dir, { recursive: true });
+
+    const tmpPath = `${filePath}.tmp`;
+    const json = JSON.stringify(data, null, 2);
+
+    // Write to tmp, then atomic rename
+    fs.writeFileSync(tmpPath, json, { encoding: 'utf8', mode: 0o600 });
+    fs.renameSync(tmpPath, filePath);
+
+    // Ensure correct permissions on final file
+    fs.chmodSync(filePath, 0o600);
+  }
+}
+
+export default ConfigService;

package/src/services/language-service.js

@@ -1,47 +1,47 @@
-/**
- * LanguageService — single source of truth for the selected UI language.
- *
- * Persists the selection to ~/.claude/config/language.txt so it survives
- * process restarts.  Notifies registered listeners on every change so the
- * TUI can re-render dynamic labels immediately.
- */
-
-import fs from 'node:fs';
-import path from 'node:path';
-import os from 'node:os';
-import { t, SUPPORTED_LANGUAGES } from '../i18n/strings.js';
-
-const LANG_FILE = path.join(os.homedir(), '.claude', 'config', 'language.txt');
-const VALID_LANGS = new Set(SUPPORTED_LANGUAGES.map(l => l.value));
-
-export class LanguageService {
-  constructor() {
-    this._lang = this._load();
-    this._listeners = [];
-  }
-
-  _load() {
-    try {
-      const val = fs.readFileSync(LANG_FILE, 'utf8').trim();
-      return VALID_LANGS.has(val) ? val : 'en';
-    } catch {
-      return 'en';
-    }
-  }
-
-  getLang() { return this._lang; }
-
-  setLang(lang) {
-    if (!VALID_LANGS.has(lang)) return;
-    this._lang = lang;
-    try {
-      fs.mkdirSync(path.dirname(LANG_FILE), { recursive: true });
-      fs.writeFileSync(LANG_FILE, lang, { mode: 0o600 });
-    } catch { /* non-fatal */ }
-    this._listeners.forEach(fn => fn(lang));
-  }
-
-  onChange(fn) { this._listeners.push(fn); }
-
-  t(key) { return t(this._lang, key); }
-}
+/**
+ * LanguageService — single source of truth for the selected UI language.
+ *
+ * Persists the selection to ~/.claude/config/language.txt so it survives
+ * process restarts.  Notifies registered listeners on every change so the
+ * TUI can re-render dynamic labels immediately.
+ */
+
+import fs from 'node:fs';
+import path from 'node:path';
+import os from 'node:os';
+import { t, SUPPORTED_LANGUAGES } from '../i18n/strings.js';
+
+const LANG_FILE = path.join(os.homedir(), '.claude', 'config', 'language.txt');
+const VALID_LANGS = new Set(SUPPORTED_LANGUAGES.map(l => l.value));
+
+export class LanguageService {
+  constructor() {
+    this._lang = this._load();
+    this._listeners = [];
+  }
+
+  _load() {
+    try {
+      const val = fs.readFileSync(LANG_FILE, 'utf8').trim();
+      return VALID_LANGS.has(val) ? val : 'en';
+    } catch {
+      return 'en';
+    }
+  }
+
+  getLang() { return this._lang; }
+
+  setLang(lang) {
+    if (!VALID_LANGS.has(lang)) return;
+    this._lang = lang;
+    try {
+      fs.mkdirSync(path.dirname(LANG_FILE), { recursive: true });
+      fs.writeFileSync(LANG_FILE, lang, { mode: 0o600 });
+    } catch { /* non-fatal */ }
+    this._listeners.forEach(fn => fn(lang));
+  }
+
+  onChange(fn) { this._listeners.push(fn); }
+
+  t(key) { return t(this._lang, key); }
+}

package/src/services/llm-provider-service.js

@@ -632,11 +632,18 @@ export function loadLlmConfigSync(llmKey, targetDir) {
  */
 export function saveLlmConfigSync(llmKey, config, targetDir) {
   const cfgKey = `llm:${llmKey}`;
-  // Sanitize pipe chars in user-editable fields to prevent config format corruption
-  const sanitize = (v) => (v || '').replace(/\|/g, '');
-  const cfgLine = `${cfgKey}|${sanitize(config.effects)}|${sanitize(config.bgTrack)}|${config.bgVolume}|${sanitize(config.voice)}|${sanitize(config.pretext)}|${sanitize(config.ttsEngine)}`;
+  // Sanitize user-editable fields: strip pipe chars (config delimiter) and newlines
+  // (newlines could inject extra rows into the pipe-delimited config file)
+  const sanitize = (v) => (v || '').replace(/[\|\n\r]/g, '');
+  const cfgLine = `${cfgKey}|${sanitize(config.effects)}|${sanitize(config.bgTrack)}|${sanitize(config.bgVolume)}|${sanitize(config.voice)}|${sanitize(config.pretext)}|${sanitize(config.ttsEngine)}`;
   const resolvedTargetDir = targetDir || process.env.INIT_CWD || process.cwd();
-  const cfgPath = config.sourcePath || resolveCfgPath(resolvedTargetDir);
+  // When targetDir is explicitly passed, write there directly (do not fall back to global).
+  // resolveCfgPath falls back to ~/.claude when the local file doesn't yet exist,
+  // which would silently redirect writes away from the intended directory.
+  const cfgPath = config.sourcePath ||
+    (targetDir
+      ? path.join(resolvedTargetDir, '.claude', 'config', 'audio-effects.cfg')
+      : resolveCfgPath(resolvedTargetDir));
 
   try {
     let content = '';