agentvibes 5.10.1 → 5.11.0

package/src/console/tabs/voices-tab.js

@@ -45,7 +45,7 @@ const COLORS = {
   dimFg:      '#455a64',
 };
 
-const FOOTER_TEXT = '[↑↓/jk] Navigate  [Space] Preview  [Enter] Select/Install  [*] Favorite  [/] Search';
+const FOOTER_TEXT = '[↑↓/jk] Navigate  [Space] Preview  [Enter] Select/Install  [f] Favorite ★  [/] Search';
 /**
  * Resolve the Piper voice storage directory using the same precedence as the
  * shell-side get_voice_storage_dir() in piper-voice-manager.sh:
@@ -229,6 +229,64 @@ export function genderIconTag(gender) {
   return '—';
 }
 
+// Fixed column widths shared by every provider's voice picker so the rows line up
+// identically regardless of engine. `status` is in terminal cells (emoji count 2).
+export const VOICE_ROW_COLS = Object.freeze({ status: 3, name: 14, lang: 6 });
+
+const _TAG_RE = /\{[^}]*\}/g;
+
+/**
+ * Visible terminal-cell width of a blessed-tagged string. Color tags ({...}) are
+ * zero-width; astral-plane emoji (👍/👎, cp ≥ U+1F000) render two cells; the
+ * VS16 emoji-presentation selector (U+FE0F) adds none. BMP symbols (★ ♀ ♂ ♪ ✓ ☁)
+ * stay one cell. Used to pad the status column so emoji-bearing rows (Piper's
+ * thumbs) align with single-glyph rows (Kokoro/ElevenLabs).
+ * @param {string} str
+ * @returns {number}
+ */
+export function cellWidth(str) {
+  const plain = String(str).replace(_TAG_RE, '');
+  let w = 0;
+  for (const ch of plain) {
+    const cp = ch.codePointAt(0);
+    if (cp === 0xFE0F) continue;       // variation selector — zero width
+    w += cp >= 0x1F000 ? 2 : 1;        // astral emoji = 2 cells, everything else = 1
+  }
+  return w;
+}
+
+/**
+ * Canonical voice-row renderer used by ALL voice pickers (Piper, Kokoro,
+ * ElevenLabs) so their columns and per-column styling are identical:
+ *   [status]  [Name]  [gender ♀/♂ colored]  [language grey]  [detail grey]
+ *
+ * @param {object} o
+ * @param {string} [o.status='  ']  provider indicator slot (e.g. fav/cache marks); may contain tags
+ * @param {string} [o.name='']      voice display name
+ * @param {string} [o.gender='']    'Female' | 'Male' | '' (drives the colored icon)
+ * @param {string} [o.lang='']      language tag (e.g. 'en-US', 'ja')
+ * @param {string} [o.detail='']    trailing description / id / provider (rendered grey)
+ * @returns {string} blessed tag-formatted row (host list must set tags:true)
+ */
+export function formatVoiceRow({ status = '  ', name = '', gender = '', lang = '', detail = '' } = {}) {
+  const { status: STATUS_W, name: NAME_W, lang: LANG_W } = VOICE_ROW_COLS;
+  // Pad the status to a fixed cell width so every provider's name column starts
+  // at the same offset, even when the status holds a 2-cell emoji (Piper thumbs).
+  const st = status + ' '.repeat(Math.max(0, STATUS_W - cellWidth(status)));
+  const nm = name.length > NAME_W ? name.slice(0, NAME_W - 1) + '…' : name.padEnd(NAME_W);
+  const lg = String(lang || '').padEnd(LANG_W);
+  const det = detail ? `{#9e9e9e-fg}${detail}{/#9e9e9e-fg}` : '';
+  return ` ${st} ${nm} ${genderIconTag(gender)} {#9e9e9e-fg}${lg}{/#9e9e9e-fg} ${det}`;
+}
+
+/** Standardized column header matching formatVoiceRow's layout. */
+export function voiceRowHeader() {
+  const { status: STATUS_W, name: NAME_W, lang: LANG_W } = VOICE_ROW_COLS;
+  // Lead = the row's leading space + status column + the space after it.
+  const lead = ' '.repeat(1 + STATUS_W + 1);
+  return `${lead}{cyan-fg}${'Name'.padEnd(NAME_W)}{/cyan-fg} {cyan-fg}⚥{/cyan-fg} {cyan-fg}${'Lang'.padEnd(LANG_W)}{/cyan-fg} {cyan-fg}Detail{/cyan-fg}`;
+}
+
 // ---------------------------------------------------------------------------
 // Pure helpers — exported for testability
 
@@ -776,7 +834,7 @@ export function createVoicesTab(screen, services) {
 
   // -------------------------------------------------------------------------
   // Hint text shown in previewLine when the list has focus and nothing is playing
-  const HINT_TEXT = '{white-fg}[Space] preview  [Enter] select  [+] thumbs up  [-] thumbs down{/white-fg}';
+  const HINT_TEXT = '{white-fg}[Space] preview  [Enter] select  [f] favorite ★  [/] search{/white-fg}';
   let _listFocused = false;
 
   // Inline selection hint appended to the currently highlighted voice row.
@@ -1185,49 +1243,10 @@ export function createVoicesTab(screen, services) {
     return btn;
   }
 
-  const switchBtn = _createBtn(_tl('voicesSwitchBtn'), () => {
-    const voices = _getFilteredVoices();
-    const selected = voices[voiceList.selected];
-    if (selected) {
-      _activateVoice(selected);
-      refreshDisplay();
-    }
-  });
-  switchBtn.bottom = 4;
-  switchBtn.left = 4;
-
-  const favoriteBtn = _createBtn(_tl('voicesFavoriteBtn'), () => {
-    const voices = _getFilteredVoices();
-    const selected = voices[voiceList.selected];
-    if (selected) {
-      toggleFavorite(configService, selected);
-      refreshDisplay();
-    }
-  });
-  favoriteBtn.bottom = 4;
-  favoriteBtn.left = 22;
-
-  const installBtn = _createBtn(_tl('voicesDownloadBtn'), () => {
-    const voices = _getFilteredVoices();
-    const selected = voices[voiceList.selected];
-    if (!selected) return;
-    if (_isInstalled(selected)) {
-      const notice = blessed.text({
-        parent: box,
-        top: 'center',
-        left: 'center',
-        content: 'Voice already installed. Scroll down to find uninstalled voices (greyed out).',
-        tags: true,
-        style: { fg: COLORS.noticeFg, bg: COLORS.contentBg },
-      });
-      screen.render();
-      setTimeout(() => { notice.destroy(); screen.render(); }, 3000);
-    } else {
-      _openDownloadModal(selected);
-    }
-  });
-  installBtn.bottom = 4;
-  installBtn.left = 38;
+  // The voice list is button-free: Enter selects (or downloads an uninstalled
+  // Piper voice then selects), Space previews, and 'f'/'*' toggles the favorite
+  // star. The old Switch/Favorite/Download button row was redundant with these
+  // keys and has been removed.
 
   // -------------------------------------------------------------------------
   // "Voice Changed" notice — auto-dismisses after 2 s
@@ -1725,11 +1744,13 @@ export function createVoicesTab(screen, services) {
 
     const active = providerService.getActiveVoiceId();
     const favorites = getFavorites(configService);
-    const thumbsDown = getThumbsDown(configService);
+    // Thumbs-down was removed — only the favorite star remains. Pass an empty
+    // set so any pre-existing downvotes in config no longer render.
+    const thumbsDown = [];
     const filtered = _getFilteredVoices();
     const items = _buildListItems(filtered, active, favorites, thumbsDown);
 
-    voiceList.setItems(items.length > 0 ? items : [' (no voices found — install piper first)']);
+    voiceList.setItems(items.length > 0 ? items : [' No voices installed — run: npx agentvibes voices download']);
     const maxIdx = Math.max(0, (items.length > 0 ? items.length : 1) - 1);
     voiceList.select(Math.min(savedIdx, maxIdx));
     voiceList.childBase = Math.min(savedScroll, Math.max(0, (items.length > 0 ? items.length : 1) - (voiceList.height - 2)));
@@ -1816,21 +1837,13 @@ export function createVoicesTab(screen, services) {
   });
 
   // '*' or '+' in voiceList toggles thumbs-up
-  voiceList.key(['*', '+'], () => {
+  // 'f' / '*' / '+' toggle the favorite star. There is a single favorite
+  // mechanism now (the star) — thumbs-up/thumbs-down was removed.
+  voiceList.key(['f', '*', '+'], () => {
     const voices = _getFilteredVoices();
     const selected = voices[voiceList.selected];
     if (selected) {
-      toggleThumbsUp(configService, selected);
-      refreshDisplay();
-    }
-  });
-
-  // '-' in voiceList toggles thumbs-down
-  voiceList.key(['-'], () => {
-    const voices = _getFilteredVoices();
-    const selected = voices[voiceList.selected];
-    if (selected) {
-      toggleThumbsDown(configService, selected);
+      toggleFavorite(configService, selected);
       refreshDisplay();
     }
   });
@@ -1961,32 +1974,6 @@ export function createVoicesTab(screen, services) {
     }
   });
 
-  // -------------------------------------------------------------------------
-  // Button-row keyboard navigation
-  // ↓ at the last list item → descend into the button row (Switch Voice gets focus first)
-  // Note: Tab is NOT used — navigation.js registers screen.key(['tab']) to cycle tabs,
-  // so element.key(['tab']) + screen.key(['tab']) both fire simultaneously.
-  voiceList.key(['down'], () => {
-    const voices = _getFilteredVoices();
-    if (voiceList.selected >= voices.length - 1) {
-      switchBtn.focus();
-      screen.render();
-    }
-  });
-
-  // ←/→ navigate between the three buttons
-  switchBtn.key(['right'],    () => { favoriteBtn.focus();  screen.render(); });
-  favoriteBtn.key(['right'],  () => { installBtn.focus();   screen.render(); });
-  installBtn.key(['right'],   () => { switchBtn.focus();    screen.render(); });
-  switchBtn.key(['left'],     () => { installBtn.focus();   screen.render(); });
-  favoriteBtn.key(['left'],   () => { switchBtn.focus();    screen.render(); });
-  installBtn.key(['left'],    () => { favoriteBtn.focus();  screen.render(); });
-
-  // ↑ or Escape from any button → back to voice list
-  switchBtn.key(['up', 'escape'],   () => { voiceList.focus(); screen.render(); });
-  favoriteBtn.key(['up', 'escape'], () => { voiceList.focus(); screen.render(); });
-  installBtn.key(['up', 'escape'],  () => { voiceList.focus(); screen.render(); });
-
   // -------------------------------------------------------------------------
   // Language refresh
 
@@ -1995,9 +1982,6 @@ export function createVoicesTab(screen, services) {
     searchLabelText.setContent(_tl('searchLabel'));
     colHeaderText.setContent(`{#00897b-fg}${_tl('voicesColName').padEnd(COL_NAME_W)}{/#00897b-fg}{magenta-fg}♀{/magenta-fg}/{bright-cyan-fg}♂{/bright-cyan-fg} {#00897b-fg}${_tl('voicesColProvider')}{/#00897b-fg}`);
     voiceInfoHdr.setContent(`{#00897b-fg}${_tl('voicesInfoHeader')}${'─'.repeat(54)}{/#00897b-fg}`);
-    switchBtn.setContent(_tl('voicesSwitchBtn'));
-    favoriteBtn.setContent(_tl('voicesFavoriteBtn'));
-    installBtn.setContent(_tl('voicesDownloadBtn'));
     screen.render();
   }
 

package/src/console/widgets/destroy-list.js

@@ -1,25 +1,25 @@
-/**
- * AgentVibes TUI — Shared Widget: Modal Destroy Helper
- *
- * Force-invalidates blessed's olines buffer after destroying a modal widget.
- * Without this, blessed skips repainting cells where lines==olines and the
- * terminal retains stale modal content as ghost artifacts.
- */
-
-/**
- * Destroy a blessed list/box widget and force full screen repaint.
- *
- * @param {object} widget  - blessed widget to destroy
- * @param {object} screen  - blessed screen instance
- * @param {Function} [onClose] - optional callback after destruction
- */
-export function destroyList(widget, screen, onClose) {
-  widget.destroy();
-  try {
-    for (let r = 0; r < screen.height; r++)
-      for (let c = 0; c < screen.width; c++)
-        if (screen.olines[r]?.[c]) screen.olines[r][c][0] = -1;
-  } catch {}
-  onClose?.();
-  screen.render();
-}
+/**
+ * AgentVibes TUI — Shared Widget: Modal Destroy Helper
+ *
+ * Force-invalidates blessed's olines buffer after destroying a modal widget.
+ * Without this, blessed skips repainting cells where lines==olines and the
+ * terminal retains stale modal content as ghost artifacts.
+ */
+
+/**
+ * Destroy a blessed list/box widget and force full screen repaint.
+ *
+ * @param {object} widget  - blessed widget to destroy
+ * @param {object} screen  - blessed screen instance
+ * @param {Function} [onClose] - optional callback after destruction
+ */
+export function destroyList(widget, screen, onClose) {
+  widget.destroy();
+  try {
+    for (let r = 0; r < screen.height; r++)
+      for (let c = 0; c < screen.width; c++)
+        if (screen.olines[r]?.[c]) screen.olines[r][c][0] = -1;
+  } catch {}
+  onClose?.();
+  screen.render();
+}

package/src/console/widgets/format-utils.js

@@ -96,6 +96,18 @@ export function formatVoiceName(voice) {
  * @returns {string}
  */
 export function formatReverbState(preset) {
-  const LABELS = { off: 'Off', light: 'Light (Small room)', medium: 'Medium (Conference room)', heavy: 'Heavy (Large hall)', cathedral: 'Cathedral (Epic space)' };
-  return LABELS[preset] ?? LABELS.light;
+  const LABELS = {
+    off:          'Off',
+    light:        'Light Reverb',
+    medium:       'Medium Reverb',
+    heavy:        'Heavy Reverb',
+    cathedral:    'Cathedral',
+    'chorus-light': 'Light Chorus',
+    'chorus-deep':  'Deep Chorus',
+    'echo-short':   'Echo (short)',
+    'echo-long':    'Cave Echo',
+    warm:           'Warm',
+    radio:          'Radio',
+  };
+  return LABELS[preset] ?? 'Light Reverb';
 }

package/src/console/widgets/help-bar.js

@@ -0,0 +1,55 @@
+/**
+ * AgentVibes TUI — Shared Widget: Picker Chrome Helpers
+ *
+ * Pure, blessed-free string builders shared by every selector modal so the
+ * control hints and titles look identical across the whole app. Keeping these
+ * free of any blessed import makes them trivially unit-testable (no
+ * AGENTVIBES_TEST_MODE gate needed).
+ *
+ *   renderHelpBar([{ key, label }, ...]) -> a tag-formatted hint row
+ *   selectorTitle('Voice')               -> a standardized box label
+ *
+ * Color grammar (Paul's spec): square brackets grey, key word magenta,
+ * the '=' grey, the action label white.
+ */
+
+const C_BRACKET = '#9e9e9e'; // grey  — the [ ] around the key
+const C_KEY = 'magenta';     //        — the key word (Space, Enter, Esc…)
+const C_EQ = '#9e9e9e';      // grey  — the '=' sign
+const C_LABEL = 'white';     //        — the action label (preview, select…)
+
+/**
+ * Build one standardized help-bar row from a list of {key, label} hints.
+ * Only pass hints whose keys actually do something in this picker — the bar
+ * must never advertise a control that does not fire.
+ *
+ * @param {Array<{key: string, label: string}>} items
+ * @param {object} [opts]
+ * @param {string} [opts.sep='  ']  separator between hints
+ * @returns {string} blessed tag-formatted string (host must set tags:true)
+ */
+export function renderHelpBar(items, opts = {}) {
+  const sep = opts.sep ?? '  ';
+  if (!Array.isArray(items)) return '';
+  return items
+    .filter((it) => it && it.key && it.label)
+    .map(({ key, label }) =>
+      `{${C_BRACKET}-fg}[{/${C_BRACKET}-fg}`
+      + `{${C_KEY}-fg}${key}{/${C_KEY}-fg}`
+      + `{${C_BRACKET}-fg}]{/${C_BRACKET}-fg} `
+      + `{${C_EQ}-fg}={/${C_EQ}-fg} `
+      + `{${C_LABEL}-fg}${label}{/${C_LABEL}-fg}`)
+    .join(sep);
+}
+
+/**
+ * Standardized box label for a selector modal:
+ *   ' {bold}{cyan-fg}<name> Selector{/cyan-fg}{/bold} '
+ * Pass the noun only — e.g. selectorTitle('Voice') -> ' Voice Selector '.
+ *
+ * @param {string} name
+ * @returns {string}
+ */
+export function selectorTitle(name) {
+  return ` {bold}{cyan-fg}${name} Selector{/cyan-fg}{/bold} `;
+}

package/src/console/widgets/notice.js

@@ -1,55 +1,55 @@
-/**
- * AgentVibes TUI — Shared Widget: Notice Toast
- *
- * Displays a short auto-dismissing notice modal centred on screen.
- * Usable from any tab; no settings-specific state required.
- */
-
-import { destroyList } from './destroy-list.js';
-
-const IS_TEST = process.env.AGENTVIBES_TEST_MODE === 'true';
-let blessed;
-if (!IS_TEST) {
-  const { default: b } = await import('blessed');
-  blessed = b;
-}
-
-/**
- * Show a temporary notice that auto-dismisses after 2.5 seconds.
- *
- * @param {object} screen  - blessed screen instance
- * @param {string} message - text to display
- * @param {object} [opts]
- * @param {string} [opts.bg='#0a0e1a']       - background colour
- * @param {string} [opts.fg='#e3f2fd']       - foreground colour
- * @param {string} [opts.borderFg='bright-cyan'] - border colour
- * @param {number} [opts.durationMs=2500]    - auto-dismiss delay in ms
- */
-export function showNotice(screen, message, opts = {}) {
-  const bg         = opts.bg         ?? '#0a0e1a';
-  const fg         = opts.fg         ?? '#e3f2fd';
-  const borderFg   = opts.borderFg   ?? 'bright-cyan';
-  const durationMs = opts.durationMs ?? 2500;
-
-  const width = Math.max(28, message.length + 6);
-  const modal = blessed.box({
-    parent: screen,
-    top: 'center',
-    left: 'center',
-    width,
-    height: 3,
-    border: { type: 'line' },
-    tags: true,
-    content: `{center}${message}{/center}`,
-    style: {
-      fg,
-      bg,
-      border: { fg: borderFg },
-    },
-  });
-  screen.render();
-
-  setTimeout(() => {
-    destroyList(modal, screen);
-  }, durationMs);
-}
+/**
+ * AgentVibes TUI — Shared Widget: Notice Toast
+ *
+ * Displays a short auto-dismissing notice modal centred on screen.
+ * Usable from any tab; no settings-specific state required.
+ */
+
+import { destroyList } from './destroy-list.js';
+
+const IS_TEST = process.env.AGENTVIBES_TEST_MODE === 'true';
+let blessed;
+if (!IS_TEST) {
+  const { default: b } = await import('blessed');
+  blessed = b;
+}
+
+/**
+ * Show a temporary notice that auto-dismisses after 2.5 seconds.
+ *
+ * @param {object} screen  - blessed screen instance
+ * @param {string} message - text to display
+ * @param {object} [opts]
+ * @param {string} [opts.bg='#0a0e1a']       - background colour
+ * @param {string} [opts.fg='#e3f2fd']       - foreground colour
+ * @param {string} [opts.borderFg='bright-cyan'] - border colour
+ * @param {number} [opts.durationMs=2500]    - auto-dismiss delay in ms
+ */
+export function showNotice(screen, message, opts = {}) {
+  const bg         = opts.bg         ?? '#0a0e1a';
+  const fg         = opts.fg         ?? '#e3f2fd';
+  const borderFg   = opts.borderFg   ?? 'bright-cyan';
+  const durationMs = opts.durationMs ?? 2500;
+
+  const width = Math.max(28, message.length + 6);
+  const modal = blessed.box({
+    parent: screen,
+    top: 'center',
+    left: 'center',
+    width,
+    height: 3,
+    border: { type: 'line' },
+    tags: true,
+    content: `{center}${message}{/center}`,
+    style: {
+      fg,
+      bg,
+      border: { fg: borderFg },
+    },
+  });
+  screen.render();
+
+  setTimeout(() => {
+    destroyList(modal, screen);
+  }, durationMs);
+}