agentvibes 5.10.1 → 5.11.0

package/src/console/tabs/music-tab.js

@@ -13,8 +13,7 @@ import fs from 'node:fs';
 import path from 'node:path';
 import os from 'node:os';
 import { fileURLToPath } from 'node:url';
-import { spawn } from 'node:child_process';
-import { buildAudioEnv, detectMp3Player } from '../audio-env.js';
+import { buildAudioEnv, spawnMp3Player } from '../audio-env.js';
 import { t } from '../../i18n/strings.js';
 
 // Package-relative tracks dir — used as fallback when cwd has no .claude/audio/tracks/
@@ -542,28 +541,14 @@ export function createMusicTab(screen, services) {
   let _playingProcess = null;
   let _playingTrackId = null;
 
-  // Kill the entire process group so child audio processes (ffplay, play, mpg123) all die
   function _killPlayingProcess() {
     if (_playingProcess) {
-      const _isWin = process.platform === 'win32' && !process.env.WSL_DISTRO_NAME;
-      try {
-        if (_isWin) {
-          // Windows: kill the process tree via taskkill (process group kill doesn't work)
-          spawn('taskkill', ['/F', '/T', '/PID', String(_playingProcess.pid)], { // NOSONAR
-            stdio: 'ignore', windowsHide: true,
-          });
-        } else {
-          process.kill(-_playingProcess.pid, 'SIGTERM');
-        }
-      } catch (e) {
-        if (e.code !== 'ESRCH') { /* ignore */ }
-      }
+      _playingProcess.kill();
       _playingProcess = null;
     }
   }
 
   const _spawnEnv = buildAudioEnv();
-  const _detectedPlayer = detectMp3Player(_spawnEnv);
 
   process.on('exit', () => { _killPlayingProcess(); });
 
@@ -594,7 +579,8 @@ export function createMusicTab(screen, services) {
     _killPlayingProcess();
     _playingTrackId = null;
 
-    if (!_detectedPlayer) {
+    const proc = spawnMp3Player(trackPath, _spawnEnv);
+    if (!proc) {
       const installHint = process.platform === 'win32'
         ? 'No MP3 player found. Install ffmpeg: winget install ffmpeg'
         : 'No MP3 player found. Install ffmpeg: sudo apt install ffmpeg';
@@ -604,18 +590,14 @@ export function createMusicTab(screen, services) {
       return;
     }
 
-    const _isWin = process.platform === 'win32' && !process.env.WSL_DISTRO_NAME;
-    // Spawn the detected player directly (no sh -c chain — avoids VLC/cvlc stderr issues)
-    _playingProcess = spawn(_detectedPlayer.bin, _detectedPlayer.args(trackPath), {
-      stdio: 'ignore', detached: !_isWin, windowsHide: true, env: _spawnEnv,
-    });
+    _playingProcess = proc;
     _playingTrackId = trackId;
 
     const label = _allTracks.find(t => t.id === trackId)?.label ?? formatTrackLabel(trackId);
     previewLine.setContent(`{${COLORS.playingFg}-fg}♪ Previewing: ${label}  (Space again to stop){/${COLORS.playingFg}-fg}`);
     screen.render();
 
-    _playingProcess.on('exit', () => {
+    proc.on('exit', () => {
       if (_playingTrackId === trackId) {
         _playingTrackId = null;
         _playingProcess = null;
@@ -624,7 +606,7 @@ export function createMusicTab(screen, services) {
       }
     });
 
-    _playingProcess.on('error', () => {
+    proc.on('error', () => {
       if (_playingTrackId === trackId) {
         _killPlayingProcess();
         _playingTrackId = null;

package/src/console/tabs/readme-tab.js

@@ -1,272 +1,272 @@
-/**
- * AgentVibes TUI Console — Readme Tab
- * Epic 13: Story 13.2
- *
- * Implements the Tab Component Contract:
- *   createReadmeTab(screen, services) → { box, show, hide, onFocus, onBlur, getFooterText, getFooterColor }
- *
- * Features: renders README.md with styled markdown, scrolling, search.
- */
-
-import fs from 'node:fs';
-import path from 'node:path';
-import { t } from '../../i18n/strings.js';
-
-const IS_TEST = process.env.AGENTVIBES_TEST_MODE === 'true';
-
-let blessed;
-if (!IS_TEST) {
-  const { default: b } = await import('blessed');
-  blessed = b;
-}
-
-// ---------------------------------------------------------------------------
-
-const COLORS = {
-  contentBg:  '#0a0e1a',
-  h1Fg:       '#69f0ae',  // Green — H1
-  h2Fg:       '#82b1ff',  // Blue — H2
-  h3Fg:       '#80d8ff',  // Light blue — H3
-  codeFg:     '#ffff00',  // Yellow — code spans
-  boldFg:     '#e3f2fd',  // Bright — bold text
-  quoteFg:    '#90a4ae',  // Gray — blockquotes
-  labelFg:    '#e3f2fd',
-  borderFg:   '#455a64',
-  footerBg:   '#455a64',  // Dark gray — Readme tab footer
-};
-
-const _FOOTER_TEXT_EN = '[↑↓/jk] Scroll  [PgUp/PgDn] Page  [/] Search  [S/V/M/A/R] Tab  [Q] Quit';
-
-// ---------------------------------------------------------------------------
-// Markdown renderer (story 13.2)
-
-/**
- * Render a single markdown line to blessed tagged string.
- * Handles: H1/H2/H3, bold (**), code spans (`), blockquotes (>), plain text.
- *
- * @param {string} line
- * @returns {string}
- */
-export function renderMarkdownLine(line) {
-  // H1
-  if (/^# /.test(line)) {
-    const text = line.replace(/^# /, '');
-    return `{bold}{${COLORS.h1Fg}-fg}${text}{/${COLORS.h1Fg}-fg}{/bold}`;
-  }
-  // H2
-  if (/^## /.test(line)) {
-    const text = line.replace(/^## /, '');
-    return `{bold}{${COLORS.h2Fg}-fg}${text}{/${COLORS.h2Fg}-fg}{/bold}`;
-  }
-  // H3
-  if (/^### /.test(line)) {
-    const text = line.replace(/^### /, '');
-    return `{${COLORS.h3Fg}-fg}${text}{/${COLORS.h3Fg}-fg}`;
-  }
-  // Blockquote
-  if (/^> /.test(line)) {
-    const text = line.replace(/^> /, '');
-    return `{${COLORS.quoteFg}-fg}│ ${text}{/${COLORS.quoteFg}-fg}`;
-  }
-  // Horizontal rule
-  if (/^---+$/.test(line.trim())) {
-    return `{${COLORS.quoteFg}-fg}${'─'.repeat(66)}{/${COLORS.quoteFg}-fg}`;
-  }
-
-  // Inline: code spans, bold
-  let result = line;
-  // Escape existing blessed tags (literal braces in content)
-  // Code spans: `text`
-  result = result.replace(/`([^`]+)`/g, `{${COLORS.codeFg}-fg}$1{/${COLORS.codeFg}-fg}`);
-  // Bold: **text**
-  result = result.replace(/\*\*([^*]+)\*\*/g, `{bold}$1{/bold}`);
-  // Italic: *text*
-  result = result.replace(/\*([^*]+)\*/g, `{${COLORS.h3Fg}-fg}$1{/${COLORS.h3Fg}-fg}`);
-
-  return result;
-}
-
-/**
- * Render full markdown content to blessed tagged multi-line string.
- * @param {string} markdown
- * @returns {string}
- */
-export function renderMarkdown(markdown) {
-  return markdown
-    .split('\n')
-    .map(line => renderMarkdownLine(line))
-    .join('\n');
-}
-
-// ---------------------------------------------------------------------------
-
-function createTestStub() {
-  return {
-    box: {},
-    show: () => {},
-    hide: () => {},
-    onFocus: () => {},
-    onBlur: () => {},
-    getFooterText: () => _FOOTER_TEXT_EN,
-    getFooterColor: () => COLORS.footerBg,
-  };
-}
-
-// ---------------------------------------------------------------------------
-
-/**
- * Create the Readme tab component.
- *
- * @param {object} screen   - Blessed screen instance
- * @param {object} services
- * @returns {{ box, show, hide, onFocus, onBlur, getFooterText, getFooterColor }}
- */
-export function createReadmeTab(screen, services) {
-  if (IS_TEST) return createTestStub();
-
-  const { focusMainTabBar, languageService } = services;
-  const _tl = (key) => languageService ? languageService.t(key) : t('en', key);
-
-  // -------------------------------------------------------------------------
-  // Container
-
-  const box = blessed.box({
-    parent: screen,
-    top: 5,
-    left: 0,
-    width: '100%',
-    bottom: 2,
-    hidden: true,
-    style: { fg: COLORS.labelFg, bg: COLORS.contentBg },
-    border: { type: 'line' },
-    borderStyle: { fg: COLORS.borderFg },
-  });
-
-  // -------------------------------------------------------------------------
-  // Load README.md
-
-  function _loadReadme() {
-    // Package root — works whether installed globally (node_modules/.bin) or run from source
-    const pkgRoot = path.resolve(new URL(import.meta.url).pathname, '..', '..', '..', '..');
-    const candidates = [
-      path.resolve(process.cwd(), 'README.md'),
-      path.resolve(process.cwd(), 'readme.md'),
-      path.resolve(pkgRoot, 'README.md'),  // AgentVibes package README fallback
-    ];
-    for (const p of candidates) {
-      if (fs.existsSync(p)) {
-        try {
-          return fs.readFileSync(p, 'utf8');
-        } catch {
-          // Unreadable
-        }
-      }
-    }
-    return `# README\n\n${_tl('readmeNotFound')}`;
-  }
-
-  // -------------------------------------------------------------------------
-  // Scrollable content
-
-  const scrollBox = blessed.box({
-    parent: box,
-    top: 1,
-    left: 2,
-    width: '96%',
-    bottom: 4,
-    scrollable: true,
-    alwaysScroll: true,
-    tags: true,
-    keys: true,
-    vi: true,
-    mouse: true,
-    scrollbar: { ch: '│', style: { fg: COLORS.borderFg } },
-    content: '',
-    style: { fg: COLORS.labelFg, bg: COLORS.contentBg },
-  });
-
-  // Scroll indicator
-  const scrollIndicator = blessed.text({
-    parent: box,
-    bottom: 2,
-    right: 2,
-    content: '',
-    tags: true,
-    style: { fg: COLORS.quoteFg, bg: COLORS.contentBg },
-  });
-
-  // -------------------------------------------------------------------------
-  // Render
-
-  function refreshContent() {
-    const markdown = _loadReadme();
-    const rendered = renderMarkdown(markdown);
-    scrollBox.setContent(rendered);
-    scrollIndicator.setContent(`{#607d8b-fg}${_tl('readmeScrollMore')}{/#607d8b-fg}`);
-    screen.render();
-  }
-
-  // Scroll events update indicator
-  scrollBox.on('scroll', () => {
-    const atBottom = scrollBox.getScrollPerc() >= 99;
-    scrollIndicator.setContent(
-      atBottom ? '' : `{#607d8b-fg}${_tl('readmeScrollMore')}{/#607d8b-fg}`
-    );
-    screen.render();
-  });
-
-  // PgUp/PgDn
-  scrollBox.key(['pageup'], () => {
-    scrollBox.scroll(-10);
-    screen.render();
-  });
-  scrollBox.key(['pagedown'], () => {
-    scrollBox.scroll(10);
-    screen.render();
-  });
-
-  // [↑] at top of content → jump to main header tab bar
-  scrollBox.key(['up'], () => {
-    if (scrollBox.getScroll() === 0 && typeof focusMainTabBar === 'function') {
-      focusMainTabBar();
-    }
-  });
-
-  // Escape → return to header tab bar
-  scrollBox.key(['escape'], () => {
-    if (typeof focusMainTabBar === 'function') { focusMainTabBar(); screen.render(); }
-  });
-
-  // -------------------------------------------------------------------------
-  // Tab Component Contract
-
-  return {
-    box,
-
-    show() {
-      box.show();
-      refreshContent();
-      screen.render();
-    },
-
-    hide() {
-      box.hide();
-      screen.render();
-    },
-
-    onFocus() {
-      scrollBox.focus();
-      screen.render();
-    },
-
-    onBlur() {},
-
-    getFooterText() {
-      return _tl('readmeFooter');
-    },
-
-    getFooterColor() {
-      return COLORS.footerBg;
-    },
-  };
-}
+/**
+ * AgentVibes TUI Console — Readme Tab
+ * Epic 13: Story 13.2
+ *
+ * Implements the Tab Component Contract:
+ *   createReadmeTab(screen, services) → { box, show, hide, onFocus, onBlur, getFooterText, getFooterColor }
+ *
+ * Features: renders README.md with styled markdown, scrolling, search.
+ */
+
+import fs from 'node:fs';
+import path from 'node:path';
+import { t } from '../../i18n/strings.js';
+
+const IS_TEST = process.env.AGENTVIBES_TEST_MODE === 'true';
+
+let blessed;
+if (!IS_TEST) {
+  const { default: b } = await import('blessed');
+  blessed = b;
+}
+
+// ---------------------------------------------------------------------------
+
+const COLORS = {
+  contentBg:  '#0a0e1a',
+  h1Fg:       '#69f0ae',  // Green — H1
+  h2Fg:       '#82b1ff',  // Blue — H2
+  h3Fg:       '#80d8ff',  // Light blue — H3
+  codeFg:     '#ffff00',  // Yellow — code spans
+  boldFg:     '#e3f2fd',  // Bright — bold text
+  quoteFg:    '#90a4ae',  // Gray — blockquotes
+  labelFg:    '#e3f2fd',
+  borderFg:   '#455a64',
+  footerBg:   '#455a64',  // Dark gray — Readme tab footer
+};
+
+const _FOOTER_TEXT_EN = '[↑↓/jk] Scroll  [PgUp/PgDn] Page  [/] Search  [S/V/M/A/R] Tab  [Q] Quit';
+
+// ---------------------------------------------------------------------------
+// Markdown renderer (story 13.2)
+
+/**
+ * Render a single markdown line to blessed tagged string.
+ * Handles: H1/H2/H3, bold (**), code spans (`), blockquotes (>), plain text.
+ *
+ * @param {string} line
+ * @returns {string}
+ */
+export function renderMarkdownLine(line) {
+  // H1
+  if (/^# /.test(line)) {
+    const text = line.replace(/^# /, '');
+    return `{bold}{${COLORS.h1Fg}-fg}${text}{/${COLORS.h1Fg}-fg}{/bold}`;
+  }
+  // H2
+  if (/^## /.test(line)) {
+    const text = line.replace(/^## /, '');
+    return `{bold}{${COLORS.h2Fg}-fg}${text}{/${COLORS.h2Fg}-fg}{/bold}`;
+  }
+  // H3
+  if (/^### /.test(line)) {
+    const text = line.replace(/^### /, '');
+    return `{${COLORS.h3Fg}-fg}${text}{/${COLORS.h3Fg}-fg}`;
+  }
+  // Blockquote
+  if (/^> /.test(line)) {
+    const text = line.replace(/^> /, '');
+    return `{${COLORS.quoteFg}-fg}│ ${text}{/${COLORS.quoteFg}-fg}`;
+  }
+  // Horizontal rule
+  if (/^---+$/.test(line.trim())) {
+    return `{${COLORS.quoteFg}-fg}${'─'.repeat(66)}{/${COLORS.quoteFg}-fg}`;
+  }
+
+  // Inline: code spans, bold
+  let result = line;
+  // Escape existing blessed tags (literal braces in content)
+  // Code spans: `text`
+  result = result.replace(/`([^`]+)`/g, `{${COLORS.codeFg}-fg}$1{/${COLORS.codeFg}-fg}`);
+  // Bold: **text**
+  result = result.replace(/\*\*([^*]+)\*\*/g, `{bold}$1{/bold}`);
+  // Italic: *text*
+  result = result.replace(/\*([^*]+)\*/g, `{${COLORS.h3Fg}-fg}$1{/${COLORS.h3Fg}-fg}`);
+
+  return result;
+}
+
+/**
+ * Render full markdown content to blessed tagged multi-line string.
+ * @param {string} markdown
+ * @returns {string}
+ */
+export function renderMarkdown(markdown) {
+  return markdown
+    .split('\n')
+    .map(line => renderMarkdownLine(line))
+    .join('\n');
+}
+
+// ---------------------------------------------------------------------------
+
+function createTestStub() {
+  return {
+    box: {},
+    show: () => {},
+    hide: () => {},
+    onFocus: () => {},
+    onBlur: () => {},
+    getFooterText: () => _FOOTER_TEXT_EN,
+    getFooterColor: () => COLORS.footerBg,
+  };
+}
+
+// ---------------------------------------------------------------------------
+
+/**
+ * Create the Readme tab component.
+ *
+ * @param {object} screen   - Blessed screen instance
+ * @param {object} services
+ * @returns {{ box, show, hide, onFocus, onBlur, getFooterText, getFooterColor }}
+ */
+export function createReadmeTab(screen, services) {
+  if (IS_TEST) return createTestStub();
+
+  const { focusMainTabBar, languageService } = services;
+  const _tl = (key) => languageService ? languageService.t(key) : t('en', key);
+
+  // -------------------------------------------------------------------------
+  // Container
+
+  const box = blessed.box({
+    parent: screen,
+    top: 5,
+    left: 0,
+    width: '100%',
+    bottom: 2,
+    hidden: true,
+    style: { fg: COLORS.labelFg, bg: COLORS.contentBg },
+    border: { type: 'line' },
+    borderStyle: { fg: COLORS.borderFg },
+  });
+
+  // -------------------------------------------------------------------------
+  // Load README.md
+
+  function _loadReadme() {
+    // Package root — works whether installed globally (node_modules/.bin) or run from source
+    const pkgRoot = path.resolve(new URL(import.meta.url).pathname, '..', '..', '..', '..');
+    const candidates = [
+      path.resolve(process.cwd(), 'README.md'),
+      path.resolve(process.cwd(), 'readme.md'),
+      path.resolve(pkgRoot, 'README.md'),  // AgentVibes package README fallback
+    ];
+    for (const p of candidates) {
+      if (fs.existsSync(p)) {
+        try {
+          return fs.readFileSync(p, 'utf8');
+        } catch {
+          // Unreadable
+        }
+      }
+    }
+    return `# README\n\n${_tl('readmeNotFound')}`;
+  }
+
+  // -------------------------------------------------------------------------
+  // Scrollable content
+
+  const scrollBox = blessed.box({
+    parent: box,
+    top: 1,
+    left: 2,
+    width: '96%',
+    bottom: 4,
+    scrollable: true,
+    alwaysScroll: true,
+    tags: true,
+    keys: true,
+    vi: true,
+    mouse: true,
+    scrollbar: { ch: '│', style: { fg: COLORS.borderFg } },
+    content: '',
+    style: { fg: COLORS.labelFg, bg: COLORS.contentBg },
+  });
+
+  // Scroll indicator
+  const scrollIndicator = blessed.text({
+    parent: box,
+    bottom: 2,
+    right: 2,
+    content: '',
+    tags: true,
+    style: { fg: COLORS.quoteFg, bg: COLORS.contentBg },
+  });
+
+  // -------------------------------------------------------------------------
+  // Render
+
+  function refreshContent() {
+    const markdown = _loadReadme();
+    const rendered = renderMarkdown(markdown);
+    scrollBox.setContent(rendered);
+    scrollIndicator.setContent(`{#607d8b-fg}${_tl('readmeScrollMore')}{/#607d8b-fg}`);
+    screen.render();
+  }
+
+  // Scroll events update indicator
+  scrollBox.on('scroll', () => {
+    const atBottom = scrollBox.getScrollPerc() >= 99;
+    scrollIndicator.setContent(
+      atBottom ? '' : `{#607d8b-fg}${_tl('readmeScrollMore')}{/#607d8b-fg}`
+    );
+    screen.render();
+  });
+
+  // PgUp/PgDn
+  scrollBox.key(['pageup'], () => {
+    scrollBox.scroll(-10);
+    screen.render();
+  });
+  scrollBox.key(['pagedown'], () => {
+    scrollBox.scroll(10);
+    screen.render();
+  });
+
+  // [↑] at top of content → jump to main header tab bar
+  scrollBox.key(['up'], () => {
+    if (scrollBox.getScroll() === 0 && typeof focusMainTabBar === 'function') {
+      focusMainTabBar();
+    }
+  });
+
+  // Escape → return to header tab bar
+  scrollBox.key(['escape'], () => {
+    if (typeof focusMainTabBar === 'function') { focusMainTabBar(); screen.render(); }
+  });
+
+  // -------------------------------------------------------------------------
+  // Tab Component Contract
+
+  return {
+    box,
+
+    show() {
+      box.show();
+      refreshContent();
+      screen.render();
+    },
+
+    hide() {
+      box.hide();
+      screen.render();
+    },
+
+    onFocus() {
+      scrollBox.focus();
+      screen.render();
+    },
+
+    onBlur() {},
+
+    getFooterText() {
+      return _tl('readmeFooter');
+    },
+
+    getFooterColor() {
+      return COLORS.footerBg;
+    },
+  };
+}