agentvibes 2.17.3 → 2.17.4

package/src/utils/dependency-checker.js

@@ -110,127 +110,137 @@ function checkAudioPlayers() {
 /**
  * Get platform-specific install commands for missing dependencies
  */
-export function getInstallCommands(missing, platform) {
-  const commands = [];
-
-  if (platform === 'darwin') {
-    // macOS
-    const brewPackages = [];
+/**
+ * Build homebrew package list for macOS
+ * @param {Object} missing - Missing dependencies
+ * @returns {string[]} Homebrew packages to install
+ */
+function buildBrewPackages(missing) {
+  const packages = [];
+  const packageMap = {
+    bash: 'bash',
+    sox: 'sox',
+    ffmpeg: 'ffmpeg',
+    pipx: 'pipx',
+    flock: 'util-linux',
+    curl: 'curl',
+    bc: 'bc'
+  };
 
-    if (missing.bash) {
-      brewPackages.push('bash');
-    }
-    if (missing.sox) {
-      brewPackages.push('sox');
-    }
-    if (missing.ffmpeg) {
-      brewPackages.push('ffmpeg');
-    }
-    if (missing.pipx) {
-      brewPackages.push('pipx');
-    }
-    if (missing.flock) {
-      // flock is usually part of util-linux, but might need separate install on macOS
-      brewPackages.push('util-linux');
-    }
-    if (missing.curl) {
-      brewPackages.push('curl');
-    }
-    if (missing.bc) {
-      brewPackages.push('bc');
+  for (const [key, pkg] of Object.entries(packageMap)) {
+    if (missing[key]) {
+      packages.push(pkg);
     }
+  }
 
-    if (brewPackages.length > 0) {
-      commands.push({
-        label: 'macOS (Homebrew)',
-        command: `brew install ${brewPackages.join(' ')}`
-      });
-    }
+  return packages;
+}
 
-    if (missing.python) {
-      commands.push({
-        label: 'Python 3.10+',
-        command: 'brew install python@3.11'
-      });
-    }
-  } else if (platform === 'linux' || platform === 'wsl') {
-    // Linux/WSL
-    const aptPackages = [];
-    const dnfPackages = [];
-    const pacmanPackages = [];
-
-    if (missing.sox) {
-      aptPackages.push('sox');
-      dnfPackages.push('sox');
-      pacmanPackages.push('sox');
-    }
-    if (missing.ffmpeg) {
-      aptPackages.push('ffmpeg');
-      dnfPackages.push('ffmpeg');
-      pacmanPackages.push('ffmpeg');
-    }
-    if (missing.python) {
-      aptPackages.push('python3-pip');
-      dnfPackages.push('python3-pip');
-      pacmanPackages.push('python-pip');
-    }
-    if (missing.pipx) {
-      aptPackages.push('pipx');
-      dnfPackages.push('pipx');
-      pacmanPackages.push('python-pipx');
-    }
-    if (missing.audioPlayer) {
-      aptPackages.push('pulseaudio-utils'); // provides paplay
-      dnfPackages.push('pulseaudio-utils');
-      pacmanPackages.push('libpulse'); // provides paplay
-    }
-    if (missing.flock) {
-      // flock is part of util-linux package on most Linux distros
-      aptPackages.push('util-linux');
-      dnfPackages.push('util-linux');
-      pacmanPackages.push('util-linux');
-    }
-    if (missing.curl) {
-      aptPackages.push('curl');
-      dnfPackages.push('curl');
-      pacmanPackages.push('curl');
-    }
-    if (missing.bc) {
-      aptPackages.push('bc');
-      dnfPackages.push('bc');
-      pacmanPackages.push('bc');
-    }
+/**
+ * Build Linux package lists for different package managers
+ * @param {Object} missing - Missing dependencies
+ * @returns {Object} Package lists for apt, dnf, and pacman
+ */
+function buildLinuxPackages(missing) {
+  const apt = [];
+  const dnf = [];
+  const pacman = [];
+
+  const packageMap = {
+    sox: { apt: 'sox', dnf: 'sox', pacman: 'sox' },
+    ffmpeg: { apt: 'ffmpeg', dnf: 'ffmpeg', pacman: 'ffmpeg' },
+    python: { apt: 'python3-pip', dnf: 'python3-pip', pacman: 'python-pip' },
+    pipx: { apt: 'pipx', dnf: 'pipx', pacman: 'python-pipx' },
+    audioPlayer: { apt: 'pulseaudio-utils', dnf: 'pulseaudio-utils', pacman: 'libpulse' },
+    flock: { apt: 'util-linux', dnf: 'util-linux', pacman: 'util-linux' },
+    curl: { apt: 'curl', dnf: 'curl', pacman: 'curl' },
+    bc: { apt: 'bc', dnf: 'bc', pacman: 'bc' }
+  };
 
-    if (aptPackages.length > 0) {
-      commands.push({
-        label: 'Ubuntu/Debian',
-        command: `sudo apt-get update && sudo apt-get install -y ${aptPackages.join(' ')}`
-      });
+  for (const [key, packages] of Object.entries(packageMap)) {
+    if (missing[key]) {
+      apt.push(packages.apt);
+      dnf.push(packages.dnf);
+      pacman.push(packages.pacman);
     }
+  }
 
-    if (dnfPackages.length > 0) {
-      commands.push({
-        label: 'Fedora/RHEL',
-        command: `sudo dnf install -y ${dnfPackages.join(' ')}`
-      });
-    }
+  return { apt, dnf, pacman };
+}
 
-    if (pacmanPackages.length > 0) {
-      commands.push({
-        label: 'Arch Linux',
-        command: `sudo pacman -S ${pacmanPackages.join(' ')}`
-      });
-    }
-  } else if (platform === 'win32') {
-    // Windows
+/**
+ * Generate macOS installation commands
+ * @param {Object} missing - Missing dependencies
+ * @returns {Array} Installation command objects
+ */
+function getMacOSCommands(missing) {
+  const commands = [];
+  const brewPackages = buildBrewPackages(missing);
+
+  if (brewPackages.length > 0) {
+    commands.push({
+      label: 'macOS (Homebrew)',
+      command: `brew install ${brewPackages.join(' ')}`
+    });
+  }
+
+  if (missing.python) {
+    commands.push({
+      label: 'Python 3.10+',
+      command: 'brew install python@3.11'
+    });
+  }
+
+  return commands;
+}
+
+/**
+ * Generate Linux installation commands
+ * @param {Object} missing - Missing dependencies
+ * @returns {Array} Installation command objects
+ */
+function getLinuxCommands(missing) {
+  const commands = [];
+  const packages = buildLinuxPackages(missing);
+
+  if (packages.apt.length > 0) {
     commands.push({
+      label: 'Ubuntu/Debian',
+      command: `sudo apt-get update && sudo apt-get install -y ${packages.apt.join(' ')}`
+    });
+  }
+
+  if (packages.dnf.length > 0) {
+    commands.push({
+      label: 'Fedora/RHEL',
+      command: `sudo dnf install -y ${packages.dnf.join(' ')}`
+    });
+  }
+
+  if (packages.pacman.length > 0) {
+    commands.push({
+      label: 'Arch Linux',
+      command: `sudo pacman -S ${packages.pacman.join(' ')}`
+    });
+  }
+
+  return commands;
+}
+
+export function getInstallCommands(missing, platform) {
+  if (platform === 'darwin') {
+    return getMacOSCommands(missing);
+  } else if (platform === 'linux' || platform === 'wsl') {
+    return getLinuxCommands(missing);
+  } else if (platform === 'win32') {
+    return [{
       label: 'Windows (WSL Required)',
       command: 'wsl --install -d Ubuntu',
       note: 'Then install dependencies inside WSL using Ubuntu commands above'
-    });
+    }];
   }
 
-  return commands;
+  return [];
 }
 
 /**
@@ -324,6 +334,79 @@ export function checkDependencies(options = {}) {
   return results;
 }
 
+/**
+ * Build list of missing core dependencies
+ * @param {Object} missing - Missing dependencies object
+ * @param {Object} results - Full check results
+ * @returns {string[]} List of missing core dependencies
+ */
+function buildCoreMissingList(missing, results) {
+  const list = [];
+  const coreMap = {
+    node: { label: 'Node.js ≥16.0', key: 'node' },
+    python: { label: 'Python ≥3.10', key: 'python' },
+    bash: { label: 'Bash ≥5.0', key: 'bash' }
+  };
+
+  for (const [dep, { label, key }] of Object.entries(coreMap)) {
+    if (missing[dep]) {
+      const version = results.core[key]?.version;
+      list.push(`• ${label} ${version ? `(found: ${version})` : ''}`);
+    }
+  }
+
+  return list;
+}
+
+/**
+ * Build list of missing optional dependencies
+ * @param {Object} missing - Missing dependencies object
+ * @returns {string[]} List of missing optional dependencies
+ */
+function buildOptionalMissingList(missing) {
+  const optionalMap = {
+    curl: '• curl (downloading Piper TTS and voices)',
+    sox: '• sox (audio effects)',
+    ffmpeg: '• ffmpeg (background music, RDP optimization)',
+    bc: '• bc (audio processing calculations)',
+    pipx: '• pipx (Piper TTS installation)',
+    flock: '• flock (TTS queue file locking)',
+    audioPlayer: '• paplay/aplay (audio playback)'
+  };
+
+  const list = [];
+  for (const [dep, description] of Object.entries(optionalMap)) {
+    if (missing[dep]) {
+      list.push(description);
+    }
+  }
+
+  return list;
+}
+
+/**
+ * Format install commands section
+ * @param {Array} commands - Install commands
+ * @returns {string} Formatted commands section
+ */
+function formatInstallCommands(commands) {
+  if (commands.length === 0) {
+    return '';
+  }
+
+  let section = chalk.cyan.bold('Installation Commands:\n\n');
+  commands.forEach(({ label, command, note }) => {
+    section += chalk.cyan(`${label}:\n`);
+    section += chalk.white(`  ${command}\n`);
+    if (note) {
+      section += chalk.gray(`  ${note}\n`);
+    }
+    section += '\n';
+  });
+
+  return section;
+}
+
 /**
  * Display missing dependencies in a formatted box
  */
@@ -339,26 +422,14 @@ export function displayMissingDependencies(results) {
   let content = chalk.bold.yellow('⚠️  Missing Dependencies Detected\n\n');
 
   // Core requirements
-  const coreMissing = [];
-  if (missing.node) coreMissing.push(`• Node.js ≥16.0 ${results.core.node.version ? `(found: ${results.core.node.version})` : ''}`);
-  if (missing.python) coreMissing.push(`• Python ≥3.10 ${results.core.python.version ? `(found: ${results.core.python.version})` : ''}`);
-  if (missing.bash) coreMissing.push(`• Bash ≥5.0 ${results.core.bash.version ? `(found: ${results.core.bash.version})` : ''}`);
-
+  const coreMissing = buildCoreMissingList(missing, results);
   if (coreMissing.length > 0) {
     content += chalk.red('Required:\n');
     content += coreMissing.map(item => chalk.red(item)).join('\n') + '\n\n';
   }
 
   // Optional tools
-  const optionalMissing = [];
-  if (missing.curl) optionalMissing.push('• curl (downloading Piper TTS and voices)');
-  if (missing.sox) optionalMissing.push('• sox (audio effects)');
-  if (missing.ffmpeg) optionalMissing.push('• ffmpeg (background music, RDP optimization)');
-  if (missing.bc) optionalMissing.push('• bc (audio processing calculations)');
-  if (missing.pipx) optionalMissing.push('• pipx (Piper TTS installation)');
-  if (missing.flock) optionalMissing.push('• flock (TTS queue file locking)');
-  if (missing.audioPlayer) optionalMissing.push('• paplay/aplay (audio playback)');
-
+  const optionalMissing = buildOptionalMissingList(missing);
   if (optionalMissing.length > 0) {
     content += chalk.yellow('Optional (recommended):\n');
     content += optionalMissing.map(item => chalk.yellow(item)).join('\n') + '\n\n';
@@ -366,17 +437,7 @@ export function displayMissingDependencies(results) {
 
   // Install commands
   const commands = getInstallCommands(missing, platform);
-  if (commands.length > 0) {
-    content += chalk.cyan.bold('Installation Commands:\n\n');
-    commands.forEach(({ label, command, note }) => {
-      content += chalk.cyan(`${label}:\n`);
-      content += chalk.white(`  ${command}\n`);
-      if (note) {
-        content += chalk.gray(`  ${note}\n`);
-      }
-      content += '\n';
-    });
-  }
+  content += formatInstallCommands(commands);
 
   // Impact notice
   if (optionalMissing.length > 0 && coreMissing.length === 0) {