agentic-qe 3.4.1 → 3.4.2

package/.claude/skills/cicd-pipeline-qe-orchestrator/scripts/validate.sh

@@ -0,0 +1,310 @@
+#!/bin/bash
+# =============================================================================
+# AQE Skill Validator: cicd-pipeline-qe-orchestrator v1.0.0
+# Validates CI/CD quality orchestration output per ADR-056
+# =============================================================================
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+PROJECT_ROOT="$(cd "$SKILL_DIR/../../.." && pwd)"
+
+VALIDATOR_LIB=""
+for lib_path in \
+  "$PROJECT_ROOT/.claude/skills/.validation/templates/validator-lib.sh" \
+  "$SKILL_DIR/scripts/validator-lib.sh" \
+  "$SCRIPT_DIR/validator-lib.sh"; do
+  if [[ -f "$lib_path" ]]; then
+    VALIDATOR_LIB="$lib_path"
+    break
+  fi
+done
+
+if [[ -n "$VALIDATOR_LIB" ]]; then
+  # shellcheck source=/dev/null
+  source "$VALIDATOR_LIB"
+else
+  echo "ERROR: Validator library not found"
+  exit 1
+fi
+
+SKILL_NAME="cicd-pipeline-qe-orchestrator"
+SKILL_VERSION="1.0.0"
+
+REQUIRED_TOOLS=("jq")
+OPTIONAL_TOOLS=("npm" "docker" "python3")
+
+SCHEMA_PATH="$SKILL_DIR/schemas/output.json"
+
+REQUIRED_FIELDS=("skillName" "status" "output" "output.summary" "output.orchestrationPlan")
+REQUIRED_NON_EMPTY_FIELDS=("output.summary")
+
+MUST_CONTAIN_TERMS=("CI/CD" "pipeline" "test" "quality")
+MUST_NOT_CONTAIN_TERMS=("TODO" "placeholder" "FIXME")
+
+ENUM_VALIDATIONS=(
+  ".status:success,partial,failed,skipped"
+)
+
+OUTPUT_FILE=""
+SELF_TEST=false
+VERBOSE=false
+JSON_ONLY=false
+LIST_TOOLS=false
+
+while [[ $# -gt 0 ]]; do
+  case "$1" in
+    --self-test) SELF_TEST=true; shift ;;
+    --verbose|-v) VERBOSE=true; export AQE_DEBUG=1; shift ;;
+    --json) JSON_ONLY=true; shift ;;
+    --list-tools) LIST_TOOLS=true; shift ;;
+    -h|--help)
+      cat << 'HELP_EOF'
+AQE cicd-pipeline-qe-orchestrator Skill Validator v1.0.0
+
+Usage: ./validate.sh <output-file> [options]
+       ./validate.sh --self-test [--verbose]
+
+Options:
+  --self-test       Run validator self-test mode
+  --verbose, -v     Enable verbose/debug output
+  --json            Output results as JSON only
+  --list-tools      Show available validation tools
+  --help, -h        Show this help message
+
+HELP_EOF
+      exit 0
+      ;;
+    -*) error "Unknown option: $1"; exit 1 ;;
+    *) OUTPUT_FILE="$1"; shift ;;
+  esac
+done
+
+if [[ "$LIST_TOOLS" == "true" ]]; then
+  echo "Available tools for $SKILL_NAME:"
+  for tool in "${REQUIRED_TOOLS[@]}" "${OPTIONAL_TOOLS[@]}"; do
+    if command_exists "$tool"; then
+      echo "  [OK] $tool"
+    else
+      echo "  [MISSING] $tool"
+    fi
+  done
+  exit 0
+fi
+
+if [[ "$SELF_TEST" == "true" ]]; then
+  echo "Running $SKILL_NAME validator self-test..."
+  self_test_passed=true
+
+  for tool in "${REQUIRED_TOOLS[@]}"; do
+    if ! command_exists "$tool"; then
+      error "Required tool missing: $tool"
+      self_test_passed=false
+    fi
+  done
+
+  if [[ -f "$SCHEMA_PATH" ]]; then
+    success "Schema file exists"
+  else
+    error "Schema file not found: $SCHEMA_PATH"
+    self_test_passed=false
+  fi
+
+  if [[ "$self_test_passed" == "true" ]]; then
+    success "Self-test PASSED"
+    exit 0
+  else
+    error "Self-test FAILED"
+    exit 1
+  fi
+fi
+
+validate_orchestration_plan() {
+  local output_file="$1"
+  local plan_data
+  plan_data=$(json_get "$output_file" ".output.orchestrationPlan" 2>/dev/null)
+
+  if [[ -z "$plan_data" ]] || [[ "$plan_data" == "null" ]]; then
+    warn "Missing orchestration plan in output"
+    return 1
+  fi
+
+  return 0
+}
+
+validate_skill_specific() {
+  local output_file="$1"
+  local has_errors=false
+
+  debug "Running CI/CD orchestration specific validations..."
+
+  if ! validate_orchestration_plan "$output_file"; then
+    has_errors=true
+  else
+    success "Orchestration plan validation passed"
+  fi
+
+  if [[ "$has_errors" == "true" ]]; then
+    return 1
+  fi
+
+  return 0
+}
+
+validate_tools() {
+  local missing=()
+  for tool in "${REQUIRED_TOOLS[@]}"; do
+    if ! command_exists "$tool"; then
+      missing+=("$tool")
+    fi
+  done
+
+  if [[ ${#missing[@]} -gt 0 ]]; then
+    error "Missing required tools: ${missing[*]}"
+    return 1
+  fi
+
+  return 0
+}
+
+validate_schema() {
+  local output_file="$1"
+
+  if [[ ! -f "$SCHEMA_PATH" ]]; then
+    warn "Schema file not found: $SCHEMA_PATH"
+    return 2
+  fi
+
+  local result
+  result=$(validate_json_schema "$SCHEMA_PATH" "$output_file" 2>&1)
+  local status=$?
+
+  case $status in
+    0) success "Schema validation passed"; return 0 ;;
+    1) error "Schema validation failed"; return 1 ;;
+    2) warn "Schema validation skipped"; return 2 ;;
+  esac
+}
+
+validate_required_fields() {
+  local output_file="$1"
+  local missing=()
+
+  for field in "${REQUIRED_FIELDS[@]}"; do
+    local value
+    value=$(json_get "$output_file" ".$field" 2>/dev/null)
+    if [[ -z "$value" ]] || [[ "$value" == "null" ]]; then
+      missing+=("$field")
+    fi
+  done
+
+  if [[ ${#missing[@]} -gt 0 ]]; then
+    error "Missing required fields: ${missing[*]}"
+    return 1
+  fi
+
+  success "All required fields present"
+  return 0
+}
+
+validate_enum_fields() {
+  local output_file="$1"
+
+  for validation in "${ENUM_VALIDATIONS[@]}"; do
+    local field_path="${validation%%:*}"
+    local allowed_values="${validation#*:}"
+    local actual_value
+    actual_value=$(json_get "$output_file" "$field_path" 2>/dev/null)
+
+    if [[ -n "$actual_value" ]] && [[ "$actual_value" != "null" ]]; then
+      local found=false
+      IFS=',' read -ra allowed_array <<< "$allowed_values"
+      for allowed in "${allowed_array[@]}"; do
+        if [[ "$actual_value" == "$allowed" ]]; then
+          found=true
+          break
+        fi
+      done
+
+      if [[ "$found" == "false" ]]; then
+        error "Invalid value for $field_path: '$actual_value'"
+        return 1
+      fi
+    fi
+  done
+
+  success "All enum fields valid"
+  return 0
+}
+
+validate_content_terms() {
+  local output_file="$1"
+  local content
+  content=$(cat "$output_file")
+
+  local missing_terms=()
+  for term in "${MUST_CONTAIN_TERMS[@]}"; do
+    if ! grep -qi "$term" <<< "$content"; then
+      missing_terms+=("$term")
+    fi
+  done
+
+  if [[ ${#missing_terms[@]} -gt 0 ]]; then
+    error "Output missing required terms: ${missing_terms[*]}"
+    return 1
+  fi
+
+  success "All required terms found"
+  return 0
+}
+
+main() {
+  if [[ -z "$OUTPUT_FILE" ]]; then
+    error "No output file specified"
+    exit 1
+  fi
+
+  if [[ ! -f "$OUTPUT_FILE" ]]; then
+    error "Output file not found: $OUTPUT_FILE"
+    exit 1
+  fi
+
+  if [[ "$JSON_ONLY" != "true" ]]; then
+    echo "Validating $SKILL_NAME output..."
+  fi
+
+  local overall_status="passed"
+
+  if ! validate_tools; then
+    if [[ "$JSON_ONLY" == "true" ]]; then
+      output_validation_report "$SKILL_NAME" "skipped" "skipped" "failed"
+    fi
+    exit $EXIT_SKIP
+  fi
+
+  if ! validate_json "$OUTPUT_FILE"; then
+    if [[ "$JSON_ONLY" == "true" ]]; then
+      output_validation_report "$SKILL_NAME" "failed" "failed" "passed"
+    fi
+    exit $EXIT_FAIL
+  fi
+
+  validate_schema "$OUTPUT_FILE" || true
+  validate_required_fields "$OUTPUT_FILE" || overall_status="failed"
+  validate_enum_fields "$OUTPUT_FILE" || overall_status="failed"
+  validate_content_terms "$OUTPUT_FILE" || overall_status="failed"
+  validate_skill_specific "$OUTPUT_FILE" || overall_status="failed"
+
+  if [[ "$JSON_ONLY" == "true" ]]; then
+    output_validation_report "$SKILL_NAME" "passed" "$overall_status" "passed"
+  fi
+
+  if [[ "$overall_status" == "passed" ]]; then
+    exit $EXIT_PASS
+  else
+    exit $EXIT_FAIL
+  fi
+}
+
+main

package/.claude/skills/code-review-quality/SKILL.md

@@ -11,6 +11,11 @@ last_optimized: 2025-12-02
 dependencies: []
 quick_reference_card: true
 tags: [code-review, feedback, quality, testability, maintainability, pr-review]
+trust_tier: 2
+validation:
+  schema_path: schemas/output.json
+  validator_path: scripts/validate.sh
+
 ---
 
 # Code Review Quality

package/.claude/skills/code-review-quality/schemas/output.json

@@ -0,0 +1,264 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://agentic-qe.dev/schemas/skills/code-review-quality/output.json",
+  "title": "Code Review Quality Skill Output Schema",
+  "description": "Schema for code-review-quality skill output. Context-driven code review with quality assessments.",
+  "type": "object",
+  "required": ["skillName", "version", "timestamp", "status", "trustTier", "output"],
+  "properties": {
+    "skillName": {
+      "type": "string",
+      "const": "code-review-quality"
+    },
+    "version": {
+      "type": "string",
+      "pattern": "^\\d+\\.\\d+\\.\\d+(-[a-zA-Z0-9]+)?$"
+    },
+    "timestamp": {
+      "type": "string",
+      "format": "date-time"
+    },
+    "status": {
+      "type": "string",
+      "enum": ["success", "partial", "failed", "skipped"]
+    },
+    "trustTier": {
+      "type": "integer",
+      "const": 3
+    },
+    "output": {
+      "type": "object",
+      "required": ["summary", "reviewFindings", "codeQuality"],
+      "properties": {
+        "summary": {
+          "type": "string",
+          "minLength": 50,
+          "maxLength": 3000
+        },
+        "reviewFindings": {
+          "type": "array",
+          "items": {
+            "$ref": "#/$defs/reviewFinding"
+          },
+          "maxItems": 200
+        },
+        "codeQuality": {
+          "$ref": "#/$defs/codeQuality"
+        },
+        "severity": {
+          "$ref": "#/$defs/severityBreakdown"
+        },
+        "recommendations": {
+          "type": "array",
+          "items": {
+            "$ref": "#/$defs/recommendation"
+          },
+          "maxItems": 100
+        },
+        "context": {
+          "$ref": "#/$defs/reviewContext"
+        },
+        "qualityGates": {
+          "type": "array",
+          "items": {
+            "$ref": "#/$defs/qualityGate"
+          }
+        },
+        "complianceChecks": {
+          "type": "array",
+          "items": {
+            "$ref": "#/$defs/complianceCheck"
+          }
+        },
+        "verdict": {
+          "type": "string",
+          "enum": ["approved", "approved-with-suggestions", "request-changes", "blocked"]
+        },
+        "metrics": {
+          "$ref": "#/$defs/metrics"
+        }
+      }
+    },
+    "metadata": {
+      "$ref": "#/$defs/metadata"
+    },
+    "validation": {
+      "$ref": "#/$defs/validationResult"
+    },
+    "learning": {
+      "$ref": "#/$defs/learningData"
+    }
+  },
+  "$defs": {
+    "reviewFinding": {
+      "type": "object",
+      "required": ["id", "title", "severity", "category"],
+      "properties": {
+        "id": {
+          "type": "string",
+          "pattern": "^CRQ-\\d{3,6}$"
+        },
+        "title": {
+          "type": "string",
+          "minLength": 10,
+          "maxLength": 200
+        },
+        "description": {
+          "type": "string",
+          "maxLength": 2000
+        },
+        "severity": {
+          "type": "string",
+          "enum": ["critical", "high", "medium", "low", "suggestion"]
+        },
+        "category": {
+          "type": "string",
+          "enum": ["correctness", "design", "performance", "security", "maintainability", "readability", "testing", "documentation", "style", "best-practice"]
+        },
+        "location": {
+          "type": "object",
+          "properties": {
+            "file": { "type": "string" },
+            "line": { "type": "integer", "minimum": 1 },
+            "endLine": { "type": "integer", "minimum": 1 },
+            "function": { "type": "string" }
+          }
+        },
+        "codeSnippet": {
+          "type": "string",
+          "maxLength": 5000
+        },
+        "suggestedFix": {
+          "type": "string",
+          "maxLength": 5000
+        },
+        "rationale": {
+          "type": "string",
+          "maxLength": 1000
+        },
+        "effort": {
+          "type": "string",
+          "enum": ["trivial", "low", "medium", "high", "major"]
+        },
+        "blocking": {
+          "type": "boolean"
+        }
+      }
+    },
+    "codeQuality": {
+      "type": "object",
+      "required": ["overallScore", "grade"],
+      "properties": {
+        "overallScore": { "type": "number", "minimum": 0, "maximum": 100 },
+        "grade": { "type": "string", "pattern": "^[A-F][+-]?$" },
+        "dimensions": {
+          "type": "object",
+          "properties": {
+            "correctness": { "type": "number", "minimum": 0, "maximum": 100 },
+            "readability": { "type": "number", "minimum": 0, "maximum": 100 },
+            "maintainability": { "type": "number", "minimum": 0, "maximum": 100 },
+            "performance": { "type": "number", "minimum": 0, "maximum": 100 },
+            "security": { "type": "number", "minimum": 0, "maximum": 100 },
+            "testability": { "type": "number", "minimum": 0, "maximum": 100 },
+            "documentation": { "type": "number", "minimum": 0, "maximum": 100 }
+          }
+        },
+        "trend": {
+          "type": "string",
+          "enum": ["improving", "stable", "declining"]
+        }
+      }
+    },
+    "severityBreakdown": {
+      "type": "object",
+      "properties": {
+        "critical": { "type": "integer", "minimum": 0 },
+        "high": { "type": "integer", "minimum": 0 },
+        "medium": { "type": "integer", "minimum": 0 },
+        "low": { "type": "integer", "minimum": 0 },
+        "suggestion": { "type": "integer", "minimum": 0 }
+      }
+    },
+    "recommendation": {
+      "type": "object",
+      "required": ["id", "title", "priority"],
+      "properties": {
+        "id": { "type": "string", "pattern": "^REC-\\d{3,6}$" },
+        "title": { "type": "string", "maxLength": 200 },
+        "description": { "type": "string", "maxLength": 2000 },
+        "priority": { "type": "string", "enum": ["critical", "high", "medium", "low"] },
+        "category": { "type": "string" },
+        "relatedFindings": { "type": "array", "items": { "type": "string" } },
+        "codeExample": { "type": "string", "maxLength": 5000 }
+      }
+    },
+    "reviewContext": {
+      "type": "object",
+      "properties": {
+        "projectType": { "type": "string" },
+        "language": { "type": "string" },
+        "framework": { "type": "string" },
+        "reviewScope": { "type": "string" },
+        "prTitle": { "type": "string" },
+        "prDescription": { "type": "string" },
+        "changeType": { "type": "string", "enum": ["feature", "bugfix", "refactor", "hotfix", "docs"] }
+      }
+    },
+    "qualityGate": {
+      "type": "object",
+      "required": ["name", "passed"],
+      "properties": {
+        "name": { "type": "string" },
+        "passed": { "type": "boolean" },
+        "threshold": { "type": "number" },
+        "actual": { "type": "number" },
+        "message": { "type": "string" }
+      }
+    },
+    "complianceCheck": {
+      "type": "object",
+      "required": ["rule", "passed"],
+      "properties": {
+        "rule": { "type": "string" },
+        "ruleSet": { "type": "string" },
+        "passed": { "type": "boolean" },
+        "violations": { "type": "array", "items": { "type": "string" } }
+      }
+    },
+    "metrics": {
+      "type": "object",
+      "properties": {
+        "filesReviewed": { "type": "integer", "minimum": 0 },
+        "linesReviewed": { "type": "integer", "minimum": 0 },
+        "totalFindings": { "type": "integer", "minimum": 0 },
+        "blockingIssues": { "type": "integer", "minimum": 0 },
+        "qualityGatesPassed": { "type": "integer", "minimum": 0 },
+        "qualityGatesFailed": { "type": "integer", "minimum": 0 }
+      }
+    },
+    "metadata": {
+      "type": "object",
+      "properties": {
+        "executionTimeMs": { "type": "integer", "minimum": 0 },
+        "toolsUsed": { "type": "array", "items": { "type": "string" } },
+        "agentId": { "type": "string", "pattern": "^qe-[a-z][a-z0-9-]*$" },
+        "reviewType": { "type": "string", "enum": ["full", "incremental", "focused"] }
+      }
+    },
+    "validationResult": {
+      "type": "object",
+      "properties": {
+        "schemaValid": { "type": "boolean" },
+        "contentValid": { "type": "boolean" },
+        "confidence": { "type": "number", "minimum": 0, "maximum": 1 }
+      }
+    },
+    "learningData": {
+      "type": "object",
+      "properties": {
+        "patternsDetected": { "type": "array", "items": { "type": "string" } },
+        "reward": { "type": "number", "minimum": 0, "maximum": 1 }
+      }
+    }
+  }
+}

package/.claude/skills/code-review-quality/scripts/validate.sh

@@ -0,0 +1,113 @@
+#!/bin/bash
+# =============================================================================
+# AQE Skill Validator: code-review-quality v1.0.0
+# =============================================================================
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+PROJECT_ROOT="$(cd "$SKILL_DIR/../../.." && pwd)"
+
+for lib_path in "$PROJECT_ROOT/.claude/skills/.validation/templates/validator-lib.sh" "$SKILL_DIR/scripts/validator-lib.sh"; do
+  [[ -f "$lib_path" ]] && source "$lib_path" && break
+done
+
+SKILL_NAME="code-review-quality"
+SKILL_VERSION="1.0.0"
+REQUIRED_TOOLS=("jq")
+SCHEMA_PATH="$SKILL_DIR/schemas/output.json"
+REQUIRED_FIELDS=("skillName" "status" "output" "output.summary" "output.reviewFindings" "output.codeQuality")
+MUST_CONTAIN_TERMS=("review" "quality")
+MUST_NOT_CONTAIN_TERMS=("TODO" "FIXME")
+ENUM_VALIDATIONS=(".status:success,partial,failed,skipped")
+
+validate_skill_specific() {
+  local output_file="$1"
+  local has_errors=false
+
+  # Validate review findings
+  local finding_count
+  finding_count=$(jq '.output.reviewFindings | length' "$output_file" 2>/dev/null || echo "0")
+
+  if [[ "$finding_count" -gt 0 ]]; then
+    local invalid_findings
+    invalid_findings=$(jq '[.output.reviewFindings[]? | select(.id == null or .title == null or .severity == null or .category == null)] | length' "$output_file" 2>/dev/null || echo "0")
+
+    if [[ "$invalid_findings" -gt 0 ]]; then
+      warn "$invalid_findings finding(s) missing required fields"
+    fi
+
+    # Validate finding ID pattern
+    local invalid_ids
+    invalid_ids=$(jq '[.output.reviewFindings[]?.id // empty | select(test("^CRQ-[0-9]{3,6}$") | not)] | length' "$output_file" 2>/dev/null || echo "0")
+
+    if [[ "$invalid_ids" -gt 0 ]]; then
+      warn "$invalid_ids finding(s) have invalid ID format (should be CRQ-NNN)"
+    fi
+
+    # Validate severity enum
+    local valid_severities="critical high medium low suggestion"
+    local severities
+    severities=$(jq -r '.output.reviewFindings[]?.severity // empty' "$output_file" 2>/dev/null || true)
+
+    for sev in $severities; do
+      if ! echo "$valid_severities" | grep -qw "$sev"; then
+        error "Invalid severity: $sev"
+        has_errors=true
+      fi
+    done
+  fi
+
+  # Validate code quality
+  local has_quality
+  has_quality=$(jq '.output.codeQuality | has("overallScore") and has("grade")' "$output_file" 2>/dev/null)
+
+  if [[ "$has_quality" != "true" ]]; then
+    error "Code quality missing required fields (overallScore, grade)"
+    has_errors=true
+  fi
+
+  # Validate quality gates if present
+  local gate_count
+  gate_count=$(jq '.output.qualityGates | length' "$output_file" 2>/dev/null || echo "0")
+
+  if [[ "$gate_count" -gt 0 ]]; then
+    local invalid_gates
+    invalid_gates=$(jq '[.output.qualityGates[]? | select(.name == null or .passed == null)] | length' "$output_file" 2>/dev/null || echo "0")
+
+    if [[ "$invalid_gates" -gt 0 ]]; then
+      warn "$invalid_gates quality gate(s) missing required fields"
+    fi
+  fi
+
+  # Validate verdict
+  local verdict
+  verdict=$(jq -r '.output.verdict // ""' "$output_file" 2>/dev/null)
+
+  if [[ -n "$verdict" && "$verdict" != "null" ]]; then
+    local valid_verdicts="approved approved-with-suggestions request-changes blocked"
+    if ! echo "$valid_verdicts" | grep -qw "$verdict"; then
+      error "Invalid verdict: $verdict"
+      has_errors=true
+    fi
+  fi
+
+  if [[ "$has_errors" == "true" ]]; then return 1; fi
+  success "Code review quality validation passed"
+  return 0
+}
+
+OUTPUT_FILE="${1:-}"
+[[ -z "$OUTPUT_FILE" ]] && { echo "Usage: $0 <output-file>"; exit 1; }
+[[ ! -f "$OUTPUT_FILE" ]] && { echo "ERROR: File not found: $OUTPUT_FILE"; exit 1; }
+
+echo "Validating $SKILL_NAME output..."
+jq empty "$OUTPUT_FILE" 2>/dev/null || { echo "ERROR: Invalid JSON"; exit 1; }
+
+if validate_skill_specific "$OUTPUT_FILE"; then
+  echo "PASSED: $SKILL_NAME validation"
+  exit 0
+else
+  echo "FAILED: $SKILL_NAME validation"
+  exit 1
+fi