agentic-qe 3.4.1 → 3.4.2

package/.claude/skills/brutal-honesty-review/schemas/output.json

@@ -0,0 +1,291 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://agentic-qe.dev/schemas/skills/brutal-honesty-review/output.json",
+  "title": "Brutal Honesty Review Skill Output Schema",
+  "description": "Schema for brutal-honesty-review skill output. Validates unvarnished technical criticism with actionable recommendations.",
+  "type": "object",
+  "required": ["skillName", "version", "timestamp", "status", "trustTier", "output"],
+  "properties": {
+    "skillName": {
+      "type": "string",
+      "const": "brutal-honesty-review"
+    },
+    "version": {
+      "type": "string",
+      "pattern": "^\\d+\\.\\d+\\.\\d+(-[a-zA-Z0-9]+)?$"
+    },
+    "timestamp": {
+      "type": "string",
+      "format": "date-time"
+    },
+    "status": {
+      "type": "string",
+      "enum": ["success", "partial", "failed", "skipped"]
+    },
+    "trustTier": {
+      "type": "integer",
+      "const": 3
+    },
+    "output": {
+      "type": "object",
+      "required": ["summary", "reviewFindings", "codeQuality"],
+      "properties": {
+        "summary": {
+          "type": "string",
+          "minLength": 50,
+          "maxLength": 3000,
+          "description": "Brutally honest executive summary"
+        },
+        "reviewFindings": {
+          "type": "array",
+          "items": {
+            "$ref": "#/$defs/reviewFinding"
+          },
+          "minItems": 1,
+          "maxItems": 200,
+          "description": "Detailed findings with no sugar-coating"
+        },
+        "codeQuality": {
+          "$ref": "#/$defs/codeQuality"
+        },
+        "severity": {
+          "$ref": "#/$defs/severityBreakdown"
+        },
+        "recommendations": {
+          "type": "array",
+          "items": {
+            "$ref": "#/$defs/recommendation"
+          },
+          "maxItems": 100,
+          "description": "Actionable improvement recommendations"
+        },
+        "technicalDebt": {
+          "$ref": "#/$defs/technicalDebt"
+        },
+        "readabilityScore": {
+          "type": "number",
+          "minimum": 0,
+          "maximum": 100
+        },
+        "maintainabilityScore": {
+          "type": "number",
+          "minimum": 0,
+          "maximum": 100
+        },
+        "verdict": {
+          "type": "string",
+          "enum": ["ship-it", "needs-work", "major-issues", "do-not-merge", "rewrite-needed"],
+          "description": "Final honest verdict"
+        },
+        "metrics": {
+          "$ref": "#/$defs/metrics"
+        }
+      }
+    },
+    "metadata": {
+      "$ref": "#/$defs/metadata"
+    },
+    "validation": {
+      "$ref": "#/$defs/validationResult"
+    },
+    "learning": {
+      "$ref": "#/$defs/learningData"
+    }
+  },
+  "$defs": {
+    "reviewFinding": {
+      "type": "object",
+      "required": ["id", "title", "severity", "category", "honestAssessment"],
+      "properties": {
+        "id": {
+          "type": "string",
+          "pattern": "^REV-\\d{3,6}$"
+        },
+        "title": {
+          "type": "string",
+          "minLength": 10,
+          "maxLength": 200
+        },
+        "description": {
+          "type": "string",
+          "maxLength": 2000
+        },
+        "severity": {
+          "type": "string",
+          "enum": ["critical", "high", "medium", "low", "nitpick"]
+        },
+        "category": {
+          "type": "string",
+          "enum": ["architecture", "design", "implementation", "performance", "security", "maintainability", "readability", "testing", "documentation", "naming"]
+        },
+        "honestAssessment": {
+          "type": "string",
+          "minLength": 20,
+          "maxLength": 2000,
+          "description": "Brutally honest assessment with no softening"
+        },
+        "location": {
+          "type": "object",
+          "properties": {
+            "file": { "type": "string" },
+            "line": { "type": "integer", "minimum": 1 },
+            "endLine": { "type": "integer", "minimum": 1 },
+            "function": { "type": "string" }
+          }
+        },
+        "codeSnippet": {
+          "type": "string",
+          "maxLength": 5000
+        },
+        "suggestedFix": {
+          "type": "string",
+          "maxLength": 5000
+        },
+        "effort": {
+          "type": "string",
+          "enum": ["trivial", "low", "medium", "high", "major"]
+        },
+        "blocking": {
+          "type": "boolean",
+          "description": "Whether this blocks merging"
+        }
+      }
+    },
+    "codeQuality": {
+      "type": "object",
+      "required": ["overallScore", "grade"],
+      "properties": {
+        "overallScore": {
+          "type": "number",
+          "minimum": 0,
+          "maximum": 100
+        },
+        "grade": {
+          "type": "string",
+          "pattern": "^[A-F][+-]?$"
+        },
+        "dimensions": {
+          "type": "object",
+          "properties": {
+            "correctness": { "type": "number", "minimum": 0, "maximum": 100 },
+            "readability": { "type": "number", "minimum": 0, "maximum": 100 },
+            "maintainability": { "type": "number", "minimum": 0, "maximum": 100 },
+            "performance": { "type": "number", "minimum": 0, "maximum": 100 },
+            "security": { "type": "number", "minimum": 0, "maximum": 100 },
+            "testability": { "type": "number", "minimum": 0, "maximum": 100 }
+          }
+        },
+        "strengths": {
+          "type": "array",
+          "items": { "type": "string" }
+        },
+        "weaknesses": {
+          "type": "array",
+          "items": { "type": "string" }
+        }
+      }
+    },
+    "severityBreakdown": {
+      "type": "object",
+      "properties": {
+        "critical": { "type": "integer", "minimum": 0 },
+        "high": { "type": "integer", "minimum": 0 },
+        "medium": { "type": "integer", "minimum": 0 },
+        "low": { "type": "integer", "minimum": 0 },
+        "nitpick": { "type": "integer", "minimum": 0 },
+        "blocking": { "type": "integer", "minimum": 0 }
+      }
+    },
+    "recommendation": {
+      "type": "object",
+      "required": ["id", "title", "priority", "impact"],
+      "properties": {
+        "id": {
+          "type": "string",
+          "pattern": "^REC-\\d{3,6}$"
+        },
+        "title": {
+          "type": "string",
+          "maxLength": 200
+        },
+        "description": {
+          "type": "string",
+          "maxLength": 2000
+        },
+        "priority": {
+          "type": "string",
+          "enum": ["critical", "high", "medium", "low"]
+        },
+        "impact": {
+          "type": "string",
+          "enum": ["transformative", "significant", "moderate", "minor"]
+        },
+        "relatedFindings": {
+          "type": "array",
+          "items": { "type": "string" }
+        },
+        "effort": {
+          "type": "string",
+          "enum": ["trivial", "low", "medium", "high", "major"]
+        },
+        "codeExample": {
+          "type": "string",
+          "maxLength": 5000
+        }
+      }
+    },
+    "technicalDebt": {
+      "type": "object",
+      "properties": {
+        "totalDebtHours": { "type": "number", "minimum": 0 },
+        "debtRatio": { "type": "number", "minimum": 0, "maximum": 100 },
+        "categories": {
+          "type": "array",
+          "items": {
+            "type": "object",
+            "properties": {
+              "category": { "type": "string" },
+              "hours": { "type": "number" },
+              "priority": { "type": "string" }
+            }
+          }
+        }
+      }
+    },
+    "metrics": {
+      "type": "object",
+      "properties": {
+        "filesReviewed": { "type": "integer", "minimum": 0 },
+        "linesReviewed": { "type": "integer", "minimum": 0 },
+        "totalFindings": { "type": "integer", "minimum": 0 },
+        "blockingIssues": { "type": "integer", "minimum": 0 },
+        "suggestedFixes": { "type": "integer", "minimum": 0 }
+      }
+    },
+    "metadata": {
+      "type": "object",
+      "properties": {
+        "executionTimeMs": { "type": "integer", "minimum": 0 },
+        "toolsUsed": { "type": "array", "items": { "type": "string" } },
+        "agentId": { "type": "string", "pattern": "^qe-[a-z][a-z0-9-]*$" },
+        "reviewScope": { "type": "string" },
+        "reviewType": { "type": "string", "enum": ["full", "incremental", "focused"] }
+      }
+    },
+    "validationResult": {
+      "type": "object",
+      "properties": {
+        "schemaValid": { "type": "boolean" },
+        "contentValid": { "type": "boolean" },
+        "confidence": { "type": "number", "minimum": 0, "maximum": 1 }
+      }
+    },
+    "learningData": {
+      "type": "object",
+      "properties": {
+        "patternsDetected": { "type": "array", "items": { "type": "string" } },
+        "reward": { "type": "number", "minimum": 0, "maximum": 1 }
+      }
+    }
+  }
+}

package/.claude/skills/brutal-honesty-review/scripts/validate.sh

@@ -0,0 +1,130 @@
+#!/bin/bash
+# =============================================================================
+# AQE Skill Validator: brutal-honesty-review v1.0.0
+# =============================================================================
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+PROJECT_ROOT="$(cd "$SKILL_DIR/../../.." && pwd)"
+
+for lib_path in "$PROJECT_ROOT/.claude/skills/.validation/templates/validator-lib.sh" "$SKILL_DIR/scripts/validator-lib.sh"; do
+  [[ -f "$lib_path" ]] && source "$lib_path" && break
+done
+
+SKILL_NAME="brutal-honesty-review"
+SKILL_VERSION="1.0.0"
+REQUIRED_TOOLS=("jq")
+SCHEMA_PATH="$SKILL_DIR/schemas/output.json"
+REQUIRED_FIELDS=("skillName" "status" "output" "output.summary" "output.reviewFindings" "output.codeQuality")
+MUST_CONTAIN_TERMS=("review" "code")
+MUST_NOT_CONTAIN_TERMS=("TODO" "FIXME")
+ENUM_VALIDATIONS=(".status:success,partial,failed,skipped")
+
+validate_skill_specific() {
+  local output_file="$1"
+  local has_errors=false
+
+  # Validate review findings
+  local finding_count
+  finding_count=$(jq '.output.reviewFindings | length' "$output_file" 2>/dev/null || echo "0")
+
+  if [[ "$finding_count" -eq 0 ]]; then
+    warn "No review findings - brutal honesty review should have at least one finding"
+  else
+    local invalid_findings
+    invalid_findings=$(jq '[.output.reviewFindings[]? | select(.id == null or .title == null or .severity == null or .category == null or .honestAssessment == null)] | length' "$output_file" 2>/dev/null || echo "0")
+
+    if [[ "$invalid_findings" -gt 0 ]]; then
+      warn "$invalid_findings finding(s) missing required fields (id, title, severity, category, honestAssessment)"
+    fi
+
+    # Validate finding ID pattern
+    local invalid_ids
+    invalid_ids=$(jq '[.output.reviewFindings[]?.id // empty | select(test("^REV-[0-9]{3,6}$") | not)] | length' "$output_file" 2>/dev/null || echo "0")
+
+    if [[ "$invalid_ids" -gt 0 ]]; then
+      warn "$invalid_ids finding(s) have invalid ID format (should be REV-NNN)"
+    fi
+
+    # Validate severity enum
+    local valid_severities="critical high medium low nitpick"
+    local severities
+    severities=$(jq -r '.output.reviewFindings[]?.severity // empty' "$output_file" 2>/dev/null || true)
+
+    for sev in $severities; do
+      if ! echo "$valid_severities" | grep -qw "$sev"; then
+        error "Invalid severity: $sev"
+        has_errors=true
+      fi
+    done
+
+    # Ensure honest assessment is substantial (min 20 chars)
+    local short_assessments
+    short_assessments=$(jq '[.output.reviewFindings[]?.honestAssessment // "" | select(length < 20)] | length' "$output_file" 2>/dev/null || echo "0")
+
+    if [[ "$short_assessments" -gt 0 ]]; then
+      warn "$short_assessments finding(s) have assessment shorter than 20 characters"
+    fi
+  fi
+
+  # Validate code quality
+  local has_quality
+  has_quality=$(jq '.output.codeQuality | has("overallScore") and has("grade")' "$output_file" 2>/dev/null)
+
+  if [[ "$has_quality" != "true" ]]; then
+    error "Code quality missing required fields (overallScore, grade)"
+    has_errors=true
+  else
+    # Validate score range
+    local score
+    score=$(jq '.output.codeQuality.overallScore' "$output_file" 2>/dev/null)
+
+    if [[ -n "$score" && "$score" != "null" ]]; then
+      if (( $(echo "$score < 0 || $score > 100" | bc -l 2>/dev/null || echo "0") )); then
+        error "Overall score $score out of range (0-100)"
+        has_errors=true
+      fi
+    fi
+
+    # Validate grade pattern
+    local grade
+    grade=$(jq -r '.output.codeQuality.grade // ""' "$output_file" 2>/dev/null)
+
+    if [[ -n "$grade" && ! "$grade" =~ ^[A-F][+-]?$ ]]; then
+      error "Invalid grade format: $grade (should be A-F with optional +/-)"
+      has_errors=true
+    fi
+  fi
+
+  # Validate verdict if present
+  local verdict
+  verdict=$(jq -r '.output.verdict // ""' "$output_file" 2>/dev/null)
+
+  if [[ -n "$verdict" && "$verdict" != "null" ]]; then
+    local valid_verdicts="ship-it needs-work major-issues do-not-merge rewrite-needed"
+    if ! echo "$valid_verdicts" | grep -qw "$verdict"; then
+      error "Invalid verdict: $verdict"
+      has_errors=true
+    fi
+  fi
+
+  if [[ "$has_errors" == "true" ]]; then return 1; fi
+  success "Brutal honesty review validation passed"
+  return 0
+}
+
+OUTPUT_FILE="${1:-}"
+[[ -z "$OUTPUT_FILE" ]] && { echo "Usage: $0 <output-file>"; exit 1; }
+[[ ! -f "$OUTPUT_FILE" ]] && { echo "ERROR: File not found: $OUTPUT_FILE"; exit 1; }
+
+echo "Validating $SKILL_NAME output..."
+jq empty "$OUTPUT_FILE" 2>/dev/null || { echo "ERROR: Invalid JSON"; exit 1; }
+
+if validate_skill_specific "$OUTPUT_FILE"; then
+  echo "PASSED: $SKILL_NAME validation"
+  exit 0
+else
+  echo "FAILED: $SKILL_NAME validation"
+  exit 1
+fi

package/.claude/skills/bug-reporting-excellence/SKILL.md

@@ -11,6 +11,11 @@ last_optimized: 2025-12-03
 dependencies: []
 quick_reference_card: true
 tags: [bugs, reporting, communication, triage, quality]
+trust_tier: 2
+validation:
+  schema_path: schemas/output.json
+  validator_path: scripts/validate.sh
+
 ---
 
 # Bug Reporting Excellence