agentic-loop 3.4.7 → 3.5.2

package/ralph/setup.sh

@@ -2,6 +2,80 @@
 # shellcheck shell=bash
 # setup.sh - Set up agentic-loop in a project
 
+# Append missing sections from template to existing PROMPT.md
+# Usage: append_prompt_sections <template_file> <target_file>
+append_prompt_sections() {
+  local template="$1"
+  local target="$2"
+  local added=false
+
+  # Key sections to check and append if missing
+  local sections=(
+    "### 3. Verify It Actually Works"
+    "**Playwright MCP**"
+    "**Chrome DevTools MCP**"
+    "## Verification Checklist"
+    "## Code Quality Standards"
+    "## Architecture Rules"
+    "## Scalability Rules"
+  )
+
+  for section in "${sections[@]}"; do
+    if ! grep -qF "$section" "$target" 2>/dev/null; then
+      # Section missing - extract and append it
+      case "$section" in
+        "### 3. Verify It Actually Works"|"**Playwright MCP**"|"**Chrome DevTools MCP**")
+          # Extract the browser verification block
+          if ! grep -qF "Playwright MCP" "$target" 2>/dev/null; then
+            echo "" >> "$target"
+            echo "### 3. Verify It Actually Works" >> "$target"
+            echo "" >> "$target"
+            echo "**You have browser tools - USE THEM to verify your work:**" >> "$target"
+            echo "" >> "$target"
+            echo "**Playwright MCP** (testing & automation):" >> "$target"
+            echo "- Navigate to URLs and verify page content" >> "$target"
+            echo "- Take screenshots to verify UI renders correctly" >> "$target"
+            echo "- Click elements and fill forms to test interactions" >> "$target"
+            echo "- Get accessibility snapshots for a11y testing" >> "$target"
+            echo "" >> "$target"
+            echo "**Chrome DevTools MCP** (debugging & inspection):" >> "$target"
+            echo "- Inspect DOM elements and check console for errors" >> "$target"
+            echo "- Debug network requests and responses" >> "$target"
+            echo "- Check element styles and computed properties" >> "$target"
+            echo "" >> "$target"
+            echo "**Do NOT say you're done until:**" >> "$target"
+            echo "- All unit tests pass" >> "$target"
+            echo "- You've opened the browser and visually verified the feature works" >> "$target"
+            echo "- Console has no errors" >> "$target"
+            echo "- Error states are handled gracefully" >> "$target"
+            added=true
+            break  # Don't re-add for the other MCP checks
+          fi
+          ;;
+        "## Verification Checklist")
+          echo "" >> "$target"
+          echo "## Verification Checklist" >> "$target"
+          echo "" >> "$target"
+          echo "Before considering any story complete:" >> "$target"
+          echo "" >> "$target"
+          echo "- [ ] All acceptance criteria are met" >> "$target"
+          echo "- [ ] All error handling from story is implemented" >> "$target"
+          echo "- [ ] TypeScript/code compiles without errors" >> "$target"
+          echo "- [ ] Unit tests written and passing" >> "$target"
+          echo "- [ ] **Browser verified** - used MCP tools to visually confirm it works" >> "$target"
+          echo "- [ ] No console errors" >> "$target"
+          echo "- [ ] Linting passes" >> "$target"
+          added=true
+          ;;
+      esac
+    fi
+  done
+
+  if [[ "$added" == "true" ]]; then
+    echo "  Updated PROMPT.md with new sections"
+  fi
+}
+
 ralph_setup() {
   echo ""
   echo "    _                    _   _        _                       "
@@ -83,7 +157,7 @@ setup_ralph_dir() {
     echo "  Created .ralph/config.json"
   fi
 
-  # Copy signs template
+  # Copy or merge signs template
   if [[ ! -f ".ralph/signs.json" ]]; then
     if [[ -f "$pkg_root/templates/signs.json" ]]; then
       cp "$pkg_root/templates/signs.json" ".ralph/signs.json"
@@ -91,12 +165,41 @@ setup_ralph_dir() {
       echo '{"signs": []}' > ".ralph/signs.json"
     fi
     echo "  Created .ralph/signs.json"
+  else
+    # Merge new default signs into existing file
+    if [[ -f "$pkg_root/templates/signs.json" ]] && command -v jq &>/dev/null; then
+      local existing_ids new_signs_added=0
+      existing_ids=$(jq -r '.signs[].id // empty' ".ralph/signs.json" 2>/dev/null | tr '\n' '|')
+
+      # Add signs from template that don't exist locally
+      while IFS= read -r sign; do
+        local sign_id
+        sign_id=$(echo "$sign" | jq -r '.id // empty')
+        if [[ -n "$sign_id" && ! "$existing_ids" =~ "$sign_id" ]]; then
+          # Add this sign to local file
+          local tmp_file
+          tmp_file=$(mktemp)
+          jq --argjson new_sign "$sign" '.signs += [$new_sign]' ".ralph/signs.json" > "$tmp_file"
+          mv "$tmp_file" ".ralph/signs.json"
+          ((new_signs_added++))
+        fi
+      done < <(jq -c '.signs[]' "$pkg_root/templates/signs.json" 2>/dev/null)
+
+      if [[ $new_signs_added -gt 0 ]]; then
+        echo "  Merged $new_signs_added new sign(s) into .ralph/signs.json"
+      fi
+    fi
   fi
 
-  # Create PROMPT.md if missing
-  if [[ ! -f "PROMPT.md" ]] && [[ -f "$pkg_root/templates/PROMPT.md" ]]; then
-    cp "$pkg_root/templates/PROMPT.md" "PROMPT.md"
-    echo "  Created PROMPT.md"
+  # Create or update PROMPT.md
+  if [[ -f "$pkg_root/templates/PROMPT.md" ]]; then
+    if [[ ! -f "PROMPT.md" ]]; then
+      cp "$pkg_root/templates/PROMPT.md" "PROMPT.md"
+      echo "  Created PROMPT.md"
+    else
+      # Append missing sections to existing PROMPT.md
+      append_prompt_sections "$pkg_root/templates/PROMPT.md" "PROMPT.md"
+    fi
   fi
 
   # Auto-detect project settings
@@ -468,18 +571,12 @@ EOF
 # Set up GitHub Actions CI/CD
 setup_github_ci() {
   local pkg_root="$1"
-  local template_dir="$pkg_root/templates/github/workflows"
 
   # Skip if not a git repo
   if [[ ! -d ".git" ]]; then
     return 0
   fi
 
-  # Skip if templates don't exist
-  if [[ ! -d "$template_dir" ]]; then
-    return 0
-  fi
-
   # Skip if already set up
   if [[ -f ".github/workflows/pr.yml" ]] && [[ -f ".github/workflows/nightly.yml" ]]; then
     return 0
@@ -493,7 +590,7 @@ setup_github_ci() {
   read -r -p "  Set up GitHub Actions? [Y/n] " response
 
   if [[ "$response" =~ ^[Nn]$ ]]; then
-    echo "  Skipped GitHub Actions (run 'ralph ci install' later)"
+    echo "  Skipped GitHub Actions (run 'npx agentic-loop ci install' later)"
     return 0
   fi
 
@@ -502,15 +599,200 @@ setup_github_ci() {
   # Create workflows directory
   mkdir -p .github/workflows
 
-  # Install PR workflow
+  # Read config values for dynamic generation
+  local backend_dir frontend_dir test_cmd
+  backend_dir=$(get_config '.directories.backend' "")
+  frontend_dir=$(get_config '.directories.frontend' "")
+  test_cmd=$(get_config '.checks.testCommand' "")
+
+  # Generate PR workflow
   if [[ ! -f ".github/workflows/pr.yml" ]]; then
-    cp "$template_dir/pr.yml" .github/workflows/pr.yml
+    _generate_pr_workflow "$backend_dir" "$frontend_dir"
     echo "  Created .github/workflows/pr.yml (fast PR checks)"
   fi
 
-  # Install nightly workflow
+  # Generate nightly workflow
   if [[ ! -f ".github/workflows/nightly.yml" ]]; then
-    cp "$template_dir/nightly.yml" .github/workflows/nightly.yml
+    _generate_nightly_workflow "$backend_dir" "$frontend_dir" "$test_cmd"
     echo "  Created .github/workflows/nightly.yml (nightly full tests)"
   fi
 }
+
+# Generate PR workflow based on project structure
+_generate_pr_workflow() {
+  local backend_dir="$1"
+  local frontend_dir="$2"
+
+  cat > .github/workflows/pr.yml << 'HEADER'
+# Fast PR checks - lint only, no tests
+name: PR Check
+
+on:
+  pull_request:
+    branches: [main, master]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+HEADER
+
+  # Detect and add Python steps
+  if [[ -f "pyproject.toml" ]] || [[ -f "requirements.txt" ]] || [[ -n "$backend_dir" && -f "$backend_dir/pyproject.toml" ]]; then
+    local py_dir="${backend_dir:-.}"
+    cat >> .github/workflows/pr.yml << EOF
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
+      - name: Install Python dependencies
+        run: |
+          pip install ruff uv
+          cd $py_dir && uv pip install -e . --system 2>/dev/null || pip install -e . 2>/dev/null || true
+
+      - name: Ruff lint
+        run: cd $py_dir && ruff check .
+EOF
+  fi
+
+  # Detect and add Node.js steps
+  if [[ -f "package.json" ]] || [[ -n "$frontend_dir" && -f "$frontend_dir/package.json" ]]; then
+    local node_dir="${frontend_dir:-.}"
+    cat >> .github/workflows/pr.yml << EOF
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Install Node dependencies
+        run: cd $node_dir && npm ci
+
+      - name: Lint
+        run: cd $node_dir && npm run lint 2>/dev/null || true
+
+      - name: TypeScript check
+        run: cd $node_dir && npx tsc --noEmit 2>/dev/null || true
+
+      - name: Build
+        run: cd $node_dir && npm run build 2>/dev/null || true
+EOF
+  fi
+}
+
+# Generate nightly workflow based on project structure
+_generate_nightly_workflow() {
+  local backend_dir="$1"
+  local frontend_dir="$2"
+  local test_cmd="$3"
+
+  cat > .github/workflows/nightly.yml << 'HEADER'
+# Nightly comprehensive test suite
+name: Nightly Tests
+
+on:
+  schedule:
+    - cron: '0 3 * * *'  # 3am UTC daily
+  workflow_dispatch:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+HEADER
+
+  # Add services if backend exists (likely needs DB)
+  if [[ -n "$backend_dir" ]] || [[ -f "pyproject.toml" ]]; then
+    cat >> .github/workflows/nightly.yml << 'EOF'
+
+    services:
+      postgres:
+        image: postgres:15
+        env:
+          POSTGRES_USER: test
+          POSTGRES_PASSWORD: test
+          POSTGRES_DB: test
+        ports:
+          - 5432:5432
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+
+    env:
+      DATABASE_URL: postgresql://test:test@localhost:5432/test
+EOF
+  fi
+
+  cat >> .github/workflows/nightly.yml << 'EOF'
+
+    steps:
+      - uses: actions/checkout@v4
+EOF
+
+  # Add Python setup and tests
+  if [[ -f "pyproject.toml" ]] || [[ -n "$backend_dir" && -f "$backend_dir/pyproject.toml" ]]; then
+    local py_dir="${backend_dir:-.}"
+    local py_test_cmd="${test_cmd:-pytest -v --tb=short}"
+
+    cat >> .github/workflows/nightly.yml << EOF
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
+      - name: Install Python dependencies
+        run: |
+          pip install uv
+          cd $py_dir && uv pip install -e ".[dev]" --system 2>/dev/null || pip install -e . 2>/dev/null || true
+
+      - name: Run migrations
+        run: cd $py_dir && alembic upgrade head 2>/dev/null || true
+        continue-on-error: true
+
+      - name: Python tests
+        run: cd $py_dir && $py_test_cmd
+        continue-on-error: true
+EOF
+  fi
+
+  # Add Node.js setup and tests
+  if [[ -f "package.json" ]] || [[ -n "$frontend_dir" && -f "$frontend_dir/package.json" ]]; then
+    local node_dir="${frontend_dir:-.}"
+    cat >> .github/workflows/nightly.yml << EOF
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Install Node dependencies
+        run: cd $node_dir && npm ci
+
+      - name: Node tests
+        run: cd $node_dir && npm test 2>/dev/null || true
+        continue-on-error: true
+EOF
+  fi
+
+  # Add PRD tests
+  cat >> .github/workflows/nightly.yml << 'EOF'
+
+      - name: Run PRD tests
+        if: hashFiles('.ralph/prd.json') != ''
+        run: npx agentic-loop test prd 2>/dev/null || true
+        continue-on-error: true
+
+  notify:
+    needs: test
+    runs-on: ubuntu-latest
+    if: failure()
+    steps:
+      - name: Notify on failure
+        run: echo "Nightly tests failed!"
+EOF
+}

package/ralph/verify/tests.sh

@@ -223,6 +223,57 @@ run_unit_tests() {
   fi
 }
 
+# Expand config placeholders in a string
+# Usage: expand_config_vars "curl {config.urls.backend}/api"
+# Expands: {config.urls.backend}, {config.urls.frontend}, {config.directories.*}
+_expand_config_vars() {
+  local input="$1"
+  local config="$RALPH_DIR/config.json"
+
+  # No config file, return as-is
+  [[ ! -f "$config" ]] && echo "$input" && return
+
+  local result="$input"
+
+  # Expand {config.urls.backend}
+  if [[ "$result" == *"{config.urls.backend}"* ]]; then
+    local backend_url
+    backend_url=$(jq -r '.urls.backend // .api.baseUrl // empty' "$config" 2>/dev/null)
+    if [[ -n "$backend_url" ]]; then
+      result="${result//\{config.urls.backend\}/$backend_url}"
+    fi
+  fi
+
+  # Expand {config.urls.frontend}
+  if [[ "$result" == *"{config.urls.frontend}"* ]]; then
+    local frontend_url
+    frontend_url=$(jq -r '.urls.frontend // .testUrlBase // empty' "$config" 2>/dev/null)
+    if [[ -n "$frontend_url" ]]; then
+      result="${result//\{config.urls.frontend\}/$frontend_url}"
+    fi
+  fi
+
+  # Expand {config.directories.backend}
+  if [[ "$result" == *"{config.directories.backend}"* ]]; then
+    local backend_dir
+    backend_dir=$(jq -r '.directories.backend // empty' "$config" 2>/dev/null)
+    if [[ -n "$backend_dir" ]]; then
+      result="${result//\{config.directories.backend\}/$backend_dir}"
+    fi
+  fi
+
+  # Expand {config.directories.frontend}
+  if [[ "$result" == *"{config.directories.frontend}"* ]]; then
+    local frontend_dir
+    frontend_dir=$(jq -r '.directories.frontend // empty' "$config" 2>/dev/null)
+    if [[ -n "$frontend_dir" ]]; then
+      result="${result//\{config.directories.frontend\}/$frontend_dir}"
+    fi
+  fi
+
+  echo "$result"
+}
+
 # Verify PRD acceptance criteria / test steps
 verify_prd_criteria() {
   local story="$1"
@@ -247,9 +298,13 @@ verify_prd_criteria() {
   while IFS= read -r step; do
     [[ -z "$step" ]] && continue
 
-    echo -n "    $step... "
+    # Expand config placeholders (e.g., {config.urls.backend})
+    local expanded_step
+    expanded_step=$(_expand_config_vars "$step")
+
+    echo -n "    $expanded_step... "
 
-    if safe_exec "$step" "$log_file"; then
+    if safe_exec "$expanded_step" "$log_file"; then
       print_success "passed"
     else
       print_error "failed"
@@ -260,7 +315,7 @@ verify_prd_criteria() {
       # Save failure details for retry context
       {
         echo "PRD test step $step_index failed for $story:"
-        echo "  Command: $step"
+        echo "  Command: $expanded_step"
         echo "  Error output:"
         tail -30 "$log_file" | sed 's/^/    /'
         echo ""