agentic-loop 3.4.7 → 3.5.2

package/ralph/ci.sh

@@ -38,68 +38,227 @@ install_github_workflows() {
   # Create workflows directory
   mkdir -p .github/workflows
 
-  # Copy workflow templates
-  local template_dir="$RALPH_TEMPLATES/github/workflows"
-
-  if [[ ! -d "$template_dir" ]]; then
-    print_error "Workflow templates not found at $template_dir"
-    return 1
-  fi
+  # Read config values
+  local backend_dir frontend_dir test_cmd
+  backend_dir=$(get_config '.directories.backend' "")
+  frontend_dir=$(get_config '.directories.frontend' "")
+  test_cmd=$(get_config '.checks.testCommand' "")
 
-  # Install PR workflow
+  # Generate PR workflow
   if [[ -f ".github/workflows/pr.yml" ]]; then
     echo "  PR workflow already exists, skipping..."
   else
-    cp "$template_dir/pr.yml" .github/workflows/pr.yml
+    generate_pr_workflow "$backend_dir" "$frontend_dir"
     print_success "Created .github/workflows/pr.yml (fast lint checks)"
   fi
 
-  # Install nightly workflow
+  # Generate nightly workflow
   if [[ -f ".github/workflows/nightly.yml" ]]; then
     echo "  Nightly workflow already exists, skipping..."
   else
-    cp "$template_dir/nightly.yml" .github/workflows/nightly.yml
+    generate_nightly_workflow "$backend_dir" "$frontend_dir" "$test_cmd"
     print_success "Created .github/workflows/nightly.yml (full test suite)"
   fi
 
   echo ""
   echo "Workflows installed:"
   echo ""
-  echo "  📋 PR Check (.github/workflows/pr.yml)"
+  echo "  PR Check (.github/workflows/pr.yml)"
   echo "     Runs on: Pull requests to main/master"
   echo "     Checks: Lint, TypeScript, Build"
-  echo "     Speed: Fast (~1-2 min)"
   echo ""
-  echo "  🌙 Nightly Tests (.github/workflows/nightly.yml)"
+  echo "  Nightly Tests (.github/workflows/nightly.yml)"
   echo "     Runs on: Daily at 3am UTC + manual trigger"
-  echo "     Checks: Full test suite + PRD testSteps + Coverage"
-  echo "     Speed: Comprehensive (~5-10 min)"
+  echo "     Checks: Full test suite + PRD testSteps"
   echo ""
-
-  # Check if we need to customize for monorepo
-  local backend_dir frontend_dir
-  backend_dir=$(get_config '.directories.backend' "")
-  frontend_dir=$(get_config '.directories.frontend' "")
-
-  if [[ -n "$backend_dir" ]] || [[ -n "$frontend_dir" ]]; then
-    print_warning "Monorepo detected. You may need to customize workflow paths."
-    echo ""
-    echo "  Edit .github/workflows/*.yml to add:"
-    [[ -n "$backend_dir" ]] && echo "    - working-directory: $backend_dir"
-    [[ -n "$frontend_dir" ]] && echo "    - working-directory: $frontend_dir"
-    echo ""
-  fi
-
-  # Remind about secrets
   echo "Next steps:"
   echo "  1. Review and customize the workflows if needed"
-  echo "  2. Commit and push: git add .github && git commit -m 'ci: Add GitHub Actions workflows'"
-  echo "  3. Set up any required secrets in GitHub repo settings"
+  echo "  2. Commit: git add .github && git commit -m 'ci: Add workflows'"
+  echo "  3. Add any required secrets in GitHub repo settings"
   echo ""
 
   return 0
 }
 
+# Generate PR workflow based on project structure
+generate_pr_workflow() {
+  local backend_dir="$1"
+  local frontend_dir="$2"
+
+  cat > .github/workflows/pr.yml << 'HEADER'
+# Fast PR checks - lint only, no tests
+name: PR Check
+
+on:
+  pull_request:
+    branches: [main, master]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+HEADER
+
+  # Detect and add Python steps
+  if [[ -f "pyproject.toml" ]] || [[ -f "requirements.txt" ]] || [[ -n "$backend_dir" && -f "$backend_dir/pyproject.toml" ]]; then
+    local py_dir="${backend_dir:-.}"
+    cat >> .github/workflows/pr.yml << EOF
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
+      - name: Install Python dependencies
+        run: |
+          pip install ruff uv
+          cd $py_dir && uv pip install -e . --system 2>/dev/null || pip install -e . 2>/dev/null || true
+
+      - name: Ruff lint
+        run: cd $py_dir && ruff check .
+EOF
+  fi
+
+  # Detect and add Node.js steps
+  if [[ -f "package.json" ]] || [[ -n "$frontend_dir" && -f "$frontend_dir/package.json" ]]; then
+    local node_dir="${frontend_dir:-.}"
+    cat >> .github/workflows/pr.yml << EOF
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Install Node dependencies
+        run: cd $node_dir && npm ci
+
+      - name: Lint
+        run: cd $node_dir && npm run lint 2>/dev/null || true
+
+      - name: TypeScript check
+        run: cd $node_dir && npx tsc --noEmit 2>/dev/null || true
+
+      - name: Build
+        run: cd $node_dir && npm run build 2>/dev/null || true
+EOF
+  fi
+}
+
+# Generate nightly workflow based on project structure
+generate_nightly_workflow() {
+  local backend_dir="$1"
+  local frontend_dir="$2"
+  local test_cmd="$3"
+
+  cat > .github/workflows/nightly.yml << 'HEADER'
+# Nightly comprehensive test suite
+name: Nightly Tests
+
+on:
+  schedule:
+    - cron: '0 3 * * *'  # 3am UTC daily
+  workflow_dispatch:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+HEADER
+
+  # Add services if backend exists (likely needs DB)
+  if [[ -n "$backend_dir" ]] || [[ -f "pyproject.toml" ]]; then
+    cat >> .github/workflows/nightly.yml << 'EOF'
+
+    services:
+      postgres:
+        image: postgres:15
+        env:
+          POSTGRES_USER: test
+          POSTGRES_PASSWORD: test
+          POSTGRES_DB: test
+        ports:
+          - 5432:5432
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+
+    env:
+      DATABASE_URL: postgresql://test:test@localhost:5432/test
+EOF
+  fi
+
+  cat >> .github/workflows/nightly.yml << 'EOF'
+
+    steps:
+      - uses: actions/checkout@v4
+EOF
+
+  # Add Python setup and tests
+  if [[ -f "pyproject.toml" ]] || [[ -n "$backend_dir" && -f "$backend_dir/pyproject.toml" ]]; then
+    local py_dir="${backend_dir:-.}"
+    local py_test_cmd="${test_cmd:-pytest -v --tb=short}"
+
+    cat >> .github/workflows/nightly.yml << EOF
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
+      - name: Install Python dependencies
+        run: |
+          pip install uv
+          cd $py_dir && uv pip install -e ".[dev]" --system 2>/dev/null || pip install -e . 2>/dev/null || true
+
+      - name: Run migrations
+        run: cd $py_dir && alembic upgrade head 2>/dev/null || true
+        continue-on-error: true
+
+      - name: Python tests
+        run: cd $py_dir && $py_test_cmd
+        continue-on-error: true
+EOF
+  fi
+
+  # Add Node.js setup and tests
+  if [[ -f "package.json" ]] || [[ -n "$frontend_dir" && -f "$frontend_dir/package.json" ]]; then
+    local node_dir="${frontend_dir:-.}"
+    cat >> .github/workflows/nightly.yml << EOF
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Install Node dependencies
+        run: cd $node_dir && npm ci
+
+      - name: Node tests
+        run: cd $node_dir && npm test 2>/dev/null || true
+        continue-on-error: true
+EOF
+  fi
+
+  # Add PRD tests
+  cat >> .github/workflows/nightly.yml << 'EOF'
+
+      - name: Run PRD tests
+        if: hashFiles('.ralph/prd.json') != ''
+        run: npx agentic-loop test prd 2>/dev/null || true
+        continue-on-error: true
+
+  notify:
+    needs: test
+    runs-on: ubuntu-latest
+    if: failure()
+    steps:
+      - name: Notify on failure
+        run: echo "Nightly tests failed!"
+EOF
+}
+
 check_ci_status() {
   echo ""
   print_info "=== CI/CD Status ==="

package/ralph/hooks/protect-prd.sh

@@ -1,10 +1,9 @@
 #!/usr/bin/env bash
-# protect-prd.sh - Protect prd.json from accidental edits
+# protect-prd.sh - Protect prd.json from marking stories as passed
 # Hook: PreToolUse matcher: "Edit|Write"
 #
-# Allows: /prd, /idea commands (they create .prd-edit-allowed marker)
-# Allows: Ralph loop fixing test steps (detected by last_failure.txt)
-# Blocks: Accidental edits during normal coding
+# Allows: Most edits to prd.json (adding fields, fixing test steps, etc.)
+# Blocks: Edits that mark stories as "passes": true (Ralph handles this)
 
 set -euo pipefail
 
@@ -13,25 +12,18 @@ FILE_PATH=$(echo "$INPUT" | jq -r '.tool_input.file_path // .tool_input.path //
 
 # Check if editing prd.json
 if [[ "$FILE_PATH" == *"prd.json"* ]]; then
-  # Allow if /prd or /idea set the bypass marker
-  if [[ -f ".ralph/.prd-edit-allowed" ]]; then
-    rm -f ".ralph/.prd-edit-allowed"  # One-time use
-    echo '{"continue": true}'
-    exit 0
-  fi
+  # Get the new content being written
+  NEW_STRING=$(echo "$INPUT" | jq -r '.tool_input.new_string // .tool_input.content // ""')
 
-  # Allow if Ralph is in a retry loop with a RECENT failure (within 10 min)
-  # This lets Ralph fix broken test steps, but not stale failures from old sessions
-  if [[ -f ".ralph/last_failure.txt" ]]; then
-    file_age=$(( $(date +%s) - $(stat -f %m ".ralph/last_failure.txt" 2>/dev/null || echo 0) ))
-    if [[ $file_age -lt 600 ]]; then  # 10 minutes
-      echo '{"continue": true}'
-      exit 0
-    fi
+  # Block if trying to set passes to true (Ralph handles story completion)
+  if echo "$NEW_STRING" | grep -qE '"passes"\s*:\s*true'; then
+    echo "BLOCKED: Cannot mark stories as passed. Ralph handles this after verification." >&2
+    exit 2  # Exit code 2 = blocking error
   fi
 
-  echo "BLOCKED: prd.json is managed by Ralph. Use /prd or /idea to add stories." >&2
-  exit 2  # Exit code 2 = blocking error
+  # Allow all other prd.json edits (adding mcp, originalContext, fixing testSteps, etc.)
+  echo '{"continue": true}'
+  exit 0
 fi
 
 # Allow all other edits

package/ralph/loop.sh

@@ -504,135 +504,11 @@ startup_checklist() {
   fi
 }
 
-# Helper: Inject story details into prompt
-_inject_story_context() {
-  local story_json="$1"
-
-  echo ""
-  echo "---"
-  echo ""
-  echo "## Current Story"
-  echo ""
-  echo '```json'
-  echo "$story_json"
-  echo '```'
-}
-
-# Helper: Inject file guidance into prompt
-_inject_file_guidance() {
-  local story_json="$1"
-
-  local has_files
-  has_files=$(echo "$story_json" | jq -r '.files // empty' 2>/dev/null)
-  [[ -z "$has_files" ]] && return
-
-  echo ""
-  echo "### File Guidance for This Story"
-  echo ""
-  echo "**Create these files:**"
-  echo "$story_json" | jq -r '.files.create[]? // empty' | sed 's/^/- /'
-  echo ""
-  echo "**Modify these files:**"
-  echo "$story_json" | jq -r '.files.modify[]? // empty' | sed 's/^/- /'
-  echo ""
-  echo "**Reuse/import from:**"
-  echo "$story_json" | jq -r '.files.reuse[]? // empty' | sed 's/^/- /'
-}
-
-# Helper: Inject scalability guidance for story
-_inject_story_scale() {
-  local story_json="$1"
-
-  local has_scale
-  has_scale=$(echo "$story_json" | jq -r '.scale // empty' 2>/dev/null)
-  [[ -z "$has_scale" ]] && return
-
-  echo ""
-  echo "### Scalability Requirements for This Story"
-  echo ""
-  echo "$story_json" | jq -r '.scale | to_entries[] | "- **\(.key):** \(.value)"' 2>/dev/null
-}
-
-# Helper: Inject styleguide reference for frontend stories
-_inject_styleguide() {
-  local story_json="$1"
-
-  local story_type
-  story_type=$(echo "$story_json" | jq -r '.type // "frontend"' 2>/dev/null)
-  local styleguide_path
-  styleguide_path=$(get_config '.styleguide' "")
-
-  if [[ "$story_type" == "frontend" && -n "$styleguide_path" && -f "$styleguide_path" ]]; then
-    echo ""
-    echo "### Styleguide"
-    echo ""
-    echo "**FIRST:** Read the project styleguide at \`$styleguide_path\` before implementing."
-    echo "Use existing components, colors, and patterns from the styleguide."
-  fi
-}
-
-# Helper: Inject feature-level context
-_inject_feature_context() {
-  echo ""
-  echo "## Feature Context"
-  echo ""
-  echo '```json'
-  jq '{feature: .feature, metadata: .metadata}' "$RALPH_DIR/prd.json"
-  echo '```'
-}
-
-# Helper: Inject scalability requirements
-_inject_scalability() {
-  local has_scalability
-  has_scalability=$(jq -r '.scalability // empty' "$RALPH_DIR/prd.json" 2>/dev/null)
-  [[ -z "$has_scalability" ]] && return
-
-  echo ""
-  echo "## Scalability Requirements"
-  echo ""
-  echo "**IMPORTANT:** Follow these scalability rules."
-  echo ""
-  echo '```json'
-  jq '.scalability' "$RALPH_DIR/prd.json"
-  echo '```'
-  echo ""
-  echo "### Key Rules:"
-  echo "- Always paginate list endpoints (never return unbounded arrays)"
-  echo "- Avoid N+1 queries - eager load relationships"
-  echo "- Add database indexes for frequently queried fields"
-  echo "- Implement caching strategy as specified"
-  echo "- Add rate limiting to public endpoints"
-}
-
-# Helper: Inject architecture guidelines
-_inject_architecture() {
-  local has_architecture
-  has_architecture=$(jq -r '.architecture // empty' "$RALPH_DIR/prd.json" 2>/dev/null)
-  [[ -z "$has_architecture" ]] && return
-
-  echo ""
-  echo "## Architecture Guidelines"
-  echo ""
-  echo "**IMPORTANT:** Follow these architecture rules strictly."
-  echo ""
-  echo '```json'
-  jq '.architecture' "$RALPH_DIR/prd.json"
-  echo '```'
-  echo ""
-  echo "### Key Rules:"
-  echo "- Put files in the specified directories"
-  echo "- Reuse existing components listed in 'patterns.reuse'"
-  echo "- Do NOT create anything in 'doNotCreate'"
-  echo "- Keep files under $(jq -r '.architecture.principles.maxFileLines // 300' "$RALPH_DIR/prd.json") lines"
-  echo "- Scripts go in scripts/, docs go in docs/"
-}
-
 # Helper: Build delta prompt for continuing session
-# Minimal context - just new story + any failure info
+# Minimal context - just story ID + any failure info
 _build_delta_prompt() {
   local story="$1"
-  local story_json="$2"
-  local failure_context="${3:-}"
+  local failure_context="${2:-}"
 
   echo ""
   echo "---"
@@ -642,8 +518,10 @@ _build_delta_prompt() {
   if [[ -n "$failure_context" ]]; then
     echo "## Retry: Fix the errors below"
     echo ""
+    echo "Read \`.ralph/last_failure.txt\` for full error details."
+    echo ""
     echo '```'
-    echo "$failure_context"
+    echo "$failure_context" | head -50
     echo '```'
     echo ""
   else
@@ -651,100 +529,79 @@ _build_delta_prompt() {
     local completed_count
     completed_count=$(jq '[.stories[] | select(.passes==true)] | length' "$RALPH_DIR/prd.json" 2>/dev/null || echo "0")
     if [[ "$completed_count" -gt 0 ]]; then
-      echo "## Previous stories complete. Moving to next story."
+      echo "## Previous story complete. Moving to next."
       echo ""
-      # Suggest compact if we've done several stories
-      if [[ "$completed_count" -ge 3 ]]; then
-        echo "*Consider running /compact if context feels heavy.*"
-        echo ""
-      fi
     fi
   fi
 
-  echo "## Current Story"
-  echo ""
-  echo '```json'
-  echo "$story_json"
-  echo '```'
-
-  # Include file guidance for the new story
-  _inject_file_guidance "$story_json"
-  _inject_story_scale "$story_json"
-  _inject_styleguide "$story_json"
-}
-
-# Helper: Inject failure context from previous iteration
-_inject_failure_context() {
-  local failure_context="$1"
-  [[ -z "$failure_context" ]] && return
-
+  echo "## Current Story: $story"
   echo ""
-  echo "## Previous Iteration Failed"
-  echo ""
-  echo "Fix the errors below. If a PRD test step is broken, you can fix it in .ralph/prd.json."
-  echo ""
-  echo '```'
-  echo "$failure_context"
-  echo '```'
+  echo "Read full story details from \`.ralph/prd.json\`"
 }
 
-# Helper: Inject signs (learned patterns)
+# Helper: Inject signs (learned patterns) - ALWAYS inject these
 _inject_signs() {
-  echo ""
-  echo "## Signs (Learned Patterns)"
-  echo ""
-  echo "Apply these lessons from previous sessions:"
-  echo ""
-  if [[ -f "$RALPH_DIR/signs.json" ]]; then
-    jq -r '.signs[] | "- [\(.category)] \(.pattern)"' "$RALPH_DIR/signs.json" 2>/dev/null || echo "(none yet)"
-  else
-    echo "(none yet)"
-  fi
-}
+  [[ ! -f "$RALPH_DIR/signs.json" ]] && return
 
-# Helper: Inject developer DNA
-_inject_developer_dna() {
-  [[ ! -f "$HOME/.claude/DNA.md" ]] && return
+  local sign_count
+  sign_count=$(jq '.signs | length' "$RALPH_DIR/signs.json" 2>/dev/null || echo "0")
+  [[ "$sign_count" == "0" ]] && return
 
   echo ""
-  echo "## Developer DNA"
+  echo "## Signs (Learned Patterns) - FOLLOW THESE"
   echo ""
-  echo "The developer has these working preferences:"
-  echo ""
-  cat "$HOME/.claude/DNA.md"
+  jq -r '.signs[] | "- [\(.category)] \(.pattern)"' "$RALPH_DIR/signs.json" 2>/dev/null
 }
 
-# Build the prompt with story context injected
+# Build the prompt - LEAN version
+# Claude reads context from prd.json, we just provide the story ID and signs
 # Usage: build_prompt <story_id> [failure_context] [is_continuation]
 build_prompt() {
   local story="$1"
   local failure_context="${2:-}"
   local is_continuation="${3:-false}"
 
-  # Get story JSON once
-  local story_json
-  story_json=$(jq --arg id "$story" '.stories[] | select(.id==$id)' "$RALPH_DIR/prd.json")
-
   if [[ "$is_continuation" == "true" ]]; then
-    # Delta prompt for continuing session - just new story context
-    _build_delta_prompt "$story" "$story_json" "$failure_context"
+    # Delta prompt for continuing session
+    _build_delta_prompt "$story" "$failure_context"
     return
   fi
 
-  # Full prompt for fresh session
+  # Full prompt for fresh session - LEAN
   cat "$PROMPT_FILE"
 
-  # Inject all sections
-  _inject_story_context "$story_json"
-  _inject_file_guidance "$story_json"
-  _inject_story_scale "$story_json"
-  _inject_styleguide "$story_json"
-  _inject_feature_context
-  _inject_scalability
-  _inject_architecture
-  _inject_failure_context "$failure_context"
+  echo ""
+  echo "---"
+  echo ""
+  echo "## Current Story: $story"
+  echo ""
+  echo "Read full story details from \`.ralph/prd.json\` - it contains everything you need:"
+  echo "- \`story.files\` - which files to create/modify"
+  echo "- \`story.acceptanceCriteria\` - what must be true"
+  echo "- \`story.testSteps\` - verification commands"
+  echo "- \`story.contextFiles\` - idea files, styleguides to read"
+  echo "- \`story.mcp\` - browser tools for verification"
+  echo "- \`story.skills\` - relevant skills to reference"
+  echo ""
+  echo "Also read:"
+  echo "- \`prd.techStack\` - technologies in use"
+  echo "- \`prd.globalConstraints\` - rules for all stories"
+  echo "- \`.ralph/config.json\` - URLs and directories"
+
+  # Failure context if retrying
+  if [[ -n "$failure_context" ]]; then
+    echo ""
+    echo "## Previous Iteration Failed"
+    echo ""
+    echo "Read \`.ralph/last_failure.txt\` for details. Key error:"
+    echo ""
+    echo '```'
+    echo "$failure_context" | head -30
+    echo '```'
+  fi
+
+  # Signs are critical - always inject to prevent repeated mistakes
   _inject_signs
-  _inject_developer_dna
 }
 
 # Print story completion summary

package/ralph/prd.sh

@@ -96,6 +96,7 @@ ralph_prd() {
   printf '%s\n' '    "branch": "feature/feature-name",' >> "$prompt_file"
   printf '%s\n' '    "status": "pending"' >> "$prompt_file"
   printf '%s\n' '  },' >> "$prompt_file"
+  printf '%s\n' '  "originalContext": "PASTE THE FULL ORIGINAL NOTES/DESCRIPTION HERE - this preserves intent for Claude during implementation",' >> "$prompt_file"
   printf '%s\n' '  "metadata": {' >> "$prompt_file"
   printf '%s\n' '    "security": ["list of security requirements"],' >> "$prompt_file"
   printf '%s\n' '    "scaling": ["list of scaling concerns"],' >> "$prompt_file"
@@ -185,6 +186,10 @@ ralph_prd() {
   printf '%s\n' '- If complexity is "high" AND > 5 stories, MUST split' >> "$prompt_file"
   printf '%s\n' "- Each story should be completable in one Claude session (~10 min)" >> "$prompt_file"
   printf '\n%s\n' "If splitting is needed, generate ONLY phase 1 and note deferred items." >> "$prompt_file"
+  printf '\n%s\n' "## Original Context - IMPORTANT" >> "$prompt_file"
+  printf '\n%s\n' "Copy the FULL original feature notes into the 'originalContext' field verbatim." >> "$prompt_file"
+  printf '%s\n' "This preserves the user's original intent for Claude during implementation." >> "$prompt_file"
+  printf '%s\n' "Do NOT summarize - include the complete text." >> "$prompt_file"
   printf '\n%s\n' "## Output" >> "$prompt_file"
   printf '\n%s\n' "After questions are answered, output the prd.json content between these exact markers:" >> "$prompt_file"
   printf '%s\n' "--- BEGIN PRD.JSON ---" >> "$prompt_file"