adserver-dashboard 1.0.0

package/PCM/tests/source-validation.test.js

@@ -0,0 +1,324 @@
+import { describe, it, before, after } from 'node:test';
+import assert from 'node:assert';
+
+const BASE_URL = 'http://localhost:5000/api/v1/rest';
+
+async function request(method, path, body = null) {
+  const options = {
+    method,
+    headers: { 'Content-Type': 'application/json' }
+  };
+  if (body) {
+    options.body = JSON.stringify(body);
+  }
+  const response = await fetch(`${BASE_URL}${path}`, options);
+  const data = await response.json();
+  return { status: response.status, data };
+}
+
+describe('Source-Based Permissions Tests', () => {
+  describe('Import API - Source Validation', () => {
+    it('should reject "influence" source on DIRECT_PUBLISHER_SPLIT import', async () => {
+      const { status, data } = await request('POST', '/deals/import', {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `test-influence-reject-${Date.now()}`,
+            name: 'Test Campaign',
+            source: 'influence',
+            brand: 'Test Brand',
+            clientType: 'AGENCY',
+            currency: 'USD',
+            status: 'GENERATED',
+            marketSelection: { country: 'US', currency: 'USD' },
+            budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+          },
+          inventories: [{
+            inventoryId: 'test-inv-1',
+            publisher: { id: 'pub-1', name: 'Test Publisher' },
+            resolution: '1920x1080',
+            duration: 15
+          }]
+        }
+      });
+      assert.strictEqual(status, 400, `Expected 400, got ${status}: ${JSON.stringify(data)}`);
+      assert.ok(data.message?.includes('influence') || data.code === 'INVALID_SOURCE_FOR_IMPORT', 
+        `Expected error about influence source: ${JSON.stringify(data)}`);
+    });
+
+    it('should reject "influence" source on PROGRAMMATIC_STANDARD import', async () => {
+      const { status, data } = await request('POST', '/deals/import', {
+        payloadType: 'PROGRAMMATIC_STANDARD',
+        externalPayload: {
+          campaign: {
+            externalId: `test-prog-influence-${Date.now()}`,
+            name: 'Test Programmatic Campaign',
+            source: 'influence',
+            currency: 'USD',
+            status: 'GENERATED'
+          },
+          lineItems: []
+        }
+      });
+      assert.strictEqual(status, 400, `Expected 400, got ${status}: ${JSON.stringify(data)}`);
+    });
+
+    it('should reject "influence" source via options override', async () => {
+      const { status, data } = await request('POST', '/deals/import', {
+        payloadType: 'DIRECT_STANDARD',
+        externalPayload: {
+          campaign: {
+            externalId: `test-opts-influence-${Date.now()}`,
+            name: 'Test Campaign',
+            source: 'broadsign',
+            brand: 'Test Brand',
+            clientType: 'AGENCY',
+            currency: 'USD',
+            marketSelection: { country: 'US', currency: 'USD' },
+            budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+          },
+          lineItems: []
+        },
+        options: {
+          source: 'influence'
+        }
+      });
+      assert.strictEqual(status, 400, `Expected 400, got ${status}: ${JSON.stringify(data)}`);
+    });
+
+    it('should accept valid external source on import', async () => {
+      const externalId = `test-valid-source-${Date.now()}`;
+      const { status, data } = await request('POST', '/deals/import', {
+        payloadType: 'DIRECT_STANDARD',
+        externalPayload: {
+          campaign: {
+            externalId,
+            name: 'Test External Campaign',
+            source: 'broadsign',
+            brand: 'Test Brand',
+            clientType: 'AGENCY',
+            currency: 'USD',
+            status: 'GENERATED',
+            marketSelection: { country: 'US', currency: 'USD' },
+            budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+          },
+          lineItems: []
+        }
+      });
+      assert.strictEqual(status, 201, `Expected 201, got ${status}: ${JSON.stringify(data)}`);
+      
+      if (data.result?.dealId) {
+        await request('DELETE', `/deals/${data.result.dealId}`);
+      }
+    });
+  });
+
+  describe('Source Normalization', () => {
+    let internalDealId;
+    let externalDealId;
+    let undefinedSourceDealId;
+
+    after(async () => {
+      if (internalDealId) await request('DELETE', `/deals/${internalDealId}`);
+      if (externalDealId) await request('DELETE', `/deals/${externalDealId}`);
+      if (undefinedSourceDealId) await request('DELETE', `/deals/${undefinedSourceDealId}`);
+    });
+
+    it('should recognize "influence" as INTERNAL source', async () => {
+      const { status, data } = await request('POST', '/deals', {
+        externalId: `internal-source-${Date.now()}`,
+        name: 'Internal Source Deal',
+        mode: 'DIRECT',
+        source: 'influence',
+        brand: 'Test Brand',
+        clientType: 'AGENCY',
+        currency: 'USD',
+        status: 'GENERATED',
+        marketSelection: { country: 'US', currency: 'USD' },
+        budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+        campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+      });
+      assert.strictEqual(status, 201);
+      internalDealId = data.result.dealId;
+
+      const transitionsRes = await request('GET', `/deals/${internalDealId}/status/transitions`);
+      assert.strictEqual(transitionsRes.data.result.source, 'INTERNAL');
+      assert.strictEqual(transitionsRes.data.result.editableFields.structure, true);
+    });
+
+    it('should recognize "broadsign" as EXTERNAL source', async () => {
+      const { status, data } = await request('POST', '/deals', {
+        externalId: `external-source-${Date.now()}`,
+        name: 'External Source Deal',
+        mode: 'DIRECT',
+        source: 'broadsign',
+        brand: 'Test Brand',
+        clientType: 'AGENCY',
+        currency: 'USD',
+        status: 'GENERATED',
+        marketSelection: { country: 'US', currency: 'USD' },
+        budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+        campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+      });
+      assert.strictEqual(status, 201);
+      externalDealId = data.result.dealId;
+
+      const transitionsRes = await request('GET', `/deals/${externalDealId}/status/transitions`);
+      assert.strictEqual(transitionsRes.data.result.source, 'EXTERNAL');
+      assert.strictEqual(transitionsRes.data.result.editableFields.structure, false);
+    });
+
+    it('should default undefined source to INTERNAL for POST /deals (AdOps UI)', async () => {
+      const { status, data } = await request('POST', '/deals', {
+        externalId: `undefined-source-${Date.now()}`,
+        name: 'Undefined Source Deal',
+        mode: 'DIRECT',
+        brand: 'Test Brand',
+        clientType: 'AGENCY',
+        currency: 'USD',
+        status: 'GENERATED',
+        marketSelection: { country: 'US', currency: 'USD' },
+        budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+        campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+      });
+      assert.strictEqual(status, 201);
+      undefinedSourceDealId = data.result.dealId;
+
+      const transitionsRes = await request('GET', `/deals/${undefinedSourceDealId}/status/transitions`);
+      assert.strictEqual(transitionsRes.data.result.source, 'INTERNAL', 
+        'POST /deals should default to influence (INTERNAL) for AdOps UI');
+    });
+  });
+
+  describe('External Source Edit Restrictions', () => {
+    let externalDealId;
+
+    before(async () => {
+      const { status, data } = await request('POST', '/deals', {
+        externalId: `edit-restriction-${Date.now()}`,
+        name: 'Edit Restriction Test',
+        mode: 'DIRECT',
+        source: 'vistar',
+        brand: 'Test Brand',
+        clientType: 'AGENCY',
+        currency: 'USD',
+        status: 'GENERATED',
+        marketSelection: { country: 'US', currency: 'USD' },
+        budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+        campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+      });
+      assert.strictEqual(status, 201, `Failed: ${JSON.stringify(data)}`);
+      externalDealId = data.result.dealId;
+    });
+
+    after(async () => {
+      if (externalDealId) await request('DELETE', `/deals/${externalDealId}`);
+    });
+
+    it('should restrict structure edits for external source in all statuses', async () => {
+      const statuses = ['GENERATED'];
+      
+      for (const expectedStatus of statuses) {
+        const transitionsRes = await request('GET', `/deals/${externalDealId}/status/transitions`);
+        assert.strictEqual(transitionsRes.data.result.editableFields.structure, false,
+          `Structure should be non-editable in ${expectedStatus} for external source`);
+        assert.strictEqual(transitionsRes.data.result.editableFields.inventory, false);
+        assert.strictEqual(transitionsRes.data.result.editableFields.dates, false);
+        assert.strictEqual(transitionsRes.data.result.editableFields.creatives, false);
+      }
+    });
+
+    it('should allow pacing edits in APPROVED for external source', async () => {
+      await request('POST', `/deals/${externalDealId}/status`, { status: 'APPROVED' });
+      
+      const transitionsRes = await request('GET', `/deals/${externalDealId}/status/transitions`);
+      assert.strictEqual(transitionsRes.data.result.editableFields.pacing, true);
+      assert.strictEqual(transitionsRes.data.result.editableFields.budget, true);
+    });
+
+    it('should restrict budget edits in LIVE for external source', async () => {
+      await request('POST', `/deals/${externalDealId}/status`, { status: 'LIVE', owner: 'MQ_WORKER' });
+      
+      const transitionsRes = await request('GET', `/deals/${externalDealId}/status/transitions`);
+      assert.strictEqual(transitionsRes.data.result.editableFields.pacing, true);
+      assert.strictEqual(transitionsRes.data.result.editableFields.budget, false);
+    });
+  });
+
+  describe('Case Sensitivity', () => {
+    it('should treat "INFLUENCE" (uppercase) as internal', async () => {
+      const { status, data } = await request('POST', '/deals', {
+        externalId: `upper-influence-${Date.now()}`,
+        name: 'Uppercase Influence',
+        mode: 'DIRECT',
+        source: 'INFLUENCE',
+        brand: 'Test Brand',
+        clientType: 'AGENCY',
+        currency: 'USD',
+        status: 'GENERATED',
+        marketSelection: { country: 'US', currency: 'USD' },
+        budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+        campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+      });
+      assert.strictEqual(status, 201);
+      
+      const transitionsRes = await request('GET', `/deals/${data.result.dealId}/status/transitions`);
+      assert.strictEqual(transitionsRes.data.result.source, 'INTERNAL');
+      
+      await request('DELETE', `/deals/${data.result.dealId}`);
+    });
+
+    it('should treat " influence " (with spaces) as internal', async () => {
+      const { status, data } = await request('POST', '/deals', {
+        externalId: `spaced-influence-${Date.now()}`,
+        name: 'Spaced Influence',
+        mode: 'DIRECT',
+        source: ' influence ',
+        brand: 'Test Brand',
+        clientType: 'AGENCY',
+        currency: 'USD',
+        status: 'GENERATED',
+        marketSelection: { country: 'US', currency: 'USD' },
+        budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+        campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+      });
+      assert.strictEqual(status, 201);
+      
+      const transitionsRes = await request('GET', `/deals/${data.result.dealId}/status/transitions`);
+      assert.strictEqual(transitionsRes.data.result.source, 'INTERNAL');
+      
+      await request('DELETE', `/deals/${data.result.dealId}`);
+    });
+  });
+
+  describe('Multiple External Sources', () => {
+    const externalSources = ['broadsign', 'vistar', 'hivestack', 'place-exchange', 'custom-dsp'];
+    
+    for (const source of externalSources) {
+      it(`should recognize "${source}" as EXTERNAL`, async () => {
+        const { status, data } = await request('POST', '/deals', {
+          externalId: `${source}-test-${Date.now()}`,
+          name: `${source} Source Deal`,
+          mode: 'DIRECT',
+          source,
+          brand: 'Test Brand',
+          clientType: 'AGENCY',
+          currency: 'USD',
+          status: 'GENERATED',
+          marketSelection: { country: 'US', currency: 'USD' },
+          budgetSetup: { currency: 'USD', budgetAmount: 10000 },
+          campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+        });
+        assert.strictEqual(status, 201);
+        
+        const transitionsRes = await request('GET', `/deals/${data.result.dealId}/status/transitions`);
+        assert.strictEqual(transitionsRes.data.result.source, 'EXTERNAL');
+        
+        await request('DELETE', `/deals/${data.result.dealId}`);
+      });
+    }
+  });
+});