adserver-dashboard 1.0.0

package/PCM/tests/campaign-import-e2e.test.js

@@ -0,0 +1,520 @@
+import { describe, it, before, after } from 'node:test';
+import assert from 'node:assert';
+
+const BASE_URL = 'http://localhost:5000/api/v1/rest';
+
+async function request(method, path, body = null) {
+  const options = {
+    method,
+    headers: { 'Content-Type': 'application/json' }
+  };
+  if (body) options.body = JSON.stringify(body);
+  const res = await fetch(`${BASE_URL}${path}`, options);
+  const data = await res.json();
+  return { status: res.status, data };
+}
+
+describe('Campaign Import E2E Edge Cases', () => {
+  const createdDealIds = [];
+
+  after(async () => {
+    for (const dealId of createdDealIds) {
+      try {
+        await request('DELETE', `/deals/${dealId}`);
+      } catch (e) {}
+    }
+  });
+
+  describe('DIRECT_PUBLISHER_SPLIT Edge Cases', () => {
+    
+    it('should handle single publisher with multiple inventories grouped by publisher and duration', async () => {
+      const payload = {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-single-pub-${Date.now()}`,
+            name: 'Single Publisher Campaign',
+            brand: 'Test Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['test@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 100000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 500000 },
+            targeting: { venueTypes: ['retail.mall', 'retail.supermarket'] },
+            pacing: { type: 'even', dailyCap: 10000 }
+          },
+          inventories: [
+            { id: 'inv-1', name: 'Screen 1', resolution: '1920x1080', publisher: { id: 'pub-only', name: 'Only Publisher' } },
+            { id: 'inv-2', name: 'Screen 2', resolution: '1920x1080', publisher: { id: 'pub-only', name: 'Only Publisher' } },
+            { id: 'inv-3', name: 'Screen 3', resolution: '3840x2160', publisher: { id: 'pub-only', name: 'Only Publisher' } }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import', payload);
+      assert.strictEqual(status, 201);
+      assert.strictEqual(data.result.summary.lineItemsProcessed, 1);
+      assert.strictEqual(data.result.summary.inventoriesProcessed, 3);
+      createdDealIds.push(data.result.deal.id);
+
+      const liRes = await request('GET', `/deals/${data.result.deal.id}/line-items`);
+      assert.strictEqual(liRes.data.result.data.length, 1);
+      const allResolutions = liRes.data.result.data.flatMap(li => li.resolutions || []);
+      assert.ok(allResolutions.includes('1920x1080'));
+      assert.ok(allResolutions.includes('3840x2160'));
+    });
+
+    it('should handle many publishers (10+)', async () => {
+      const inventories = [];
+      for (let i = 1; i <= 15; i++) {
+        inventories.push({
+          id: `inv-many-${i}`,
+          name: `Screen ${i}`,
+          resolution: '1920x1080',
+          publisher: { id: `pub-${i}`, name: `Publisher ${i}` }
+        });
+      }
+
+      const payload = {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-many-pub-${Date.now()}`,
+            name: 'Many Publishers Campaign',
+            brand: 'Test Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['test@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 150000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 1500000 }
+          },
+          inventories
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import', payload);
+      assert.strictEqual(status, 201);
+      assert.strictEqual(data.result.summary.lineItemsProcessed, 15);
+      createdDealIds.push(data.result.deal.id);
+    });
+
+    it('should reject empty inventories array for PUBLISHER_SPLIT (validation requires inventories)', async () => {
+      const payload = {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-empty-inv-${Date.now()}`,
+            name: 'Empty Inventories Campaign',
+            brand: 'Test Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['test@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 50000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 100000 }
+          },
+          inventories: []
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import/convert', payload);
+      assert.strictEqual(status, 400);
+      assert.ok(data.message || data.errors);
+    });
+
+    it('should inherit complex targeting with dot-notation venueTypes', async () => {
+      const payload = {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-targeting-${Date.now()}`,
+            name: 'Complex Targeting Campaign',
+            brand: 'Target Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['test@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 80000 },
+            campaignGoal: { type: 'REACH', targetValue: 250000 },
+            targeting: {
+              venueTypes: ['retail.mall.indoor', 'transit.mrt.station', 'entertainment.cinema.lobby'],
+              demographics: { ageRange: '25-44', gender: 'all' },
+              geofencing: { radius: 5, unit: 'km', coordinates: [{ lat: 3.1390, lng: 101.6869 }] }
+            },
+            deliveryTargeting: {
+              weather: { conditions: ['sunny', 'cloudy'] },
+              timeOfDay: { start: '08:00', end: '22:00' }
+            },
+            pacing: { type: 'front-loaded', dailyCap: 15000 }
+          },
+          inventories: [
+            { id: 'inv-t1', name: 'Mall Screen', resolution: '1920x1080', publisher: { id: 'pub-mall', name: 'Mall Media' } },
+            { id: 'inv-t2', name: 'MRT Screen', resolution: '1920x1080', publisher: { id: 'pub-transit', name: 'Transit Ads' } }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import', payload);
+      assert.strictEqual(status, 201);
+      createdDealIds.push(data.result.deal.id);
+
+      const liRes = await request('GET', `/deals/${data.result.deal.id}/line-items`);
+      const lineItems = liRes.data.result.data;
+      
+      for (const li of lineItems) {
+        assert.ok(li.targeting.venueTypes.includes('retail.mall.indoor'));
+        assert.ok(li.targeting.venueTypes.includes('transit.mrt.station'));
+        assert.deepStrictEqual(li.pacing.type, 'front-loaded');
+        assert.deepStrictEqual(li.pacing.dailyCap, 15000);
+      }
+    });
+
+    it('should handle inventories with missing resolution in same line item', async () => {
+      const payload = {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-no-res-${Date.now()}`,
+            name: 'No Resolution Campaign',
+            brand: 'Test Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['test@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 30000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 50000 }
+          },
+          inventories: [
+            { id: 'inv-nr1', name: 'Screen No Res', publisher: { id: 'pub-nr', name: 'No Res Publisher' } },
+            { id: 'inv-nr2', name: 'Screen With Res', resolution: '1920x1080', publisher: { id: 'pub-nr', name: 'No Res Publisher' } }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import', payload);
+      assert.strictEqual(status, 201);
+      assert.strictEqual(data.result.summary.lineItemsProcessed, 1);
+      createdDealIds.push(data.result.deal.id);
+    });
+
+    it('should proportionally split budget across publishers', async () => {
+      const payload = {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-budget-split-${Date.now()}`,
+            name: 'Budget Split Campaign',
+            brand: 'Budget Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['test@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 100000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 1000000 }
+          },
+          inventories: [
+            { id: 'inv-b1', name: 'Screen 1', resolution: '1920x1080', publisher: { id: 'pub-big', name: 'Big Publisher' } },
+            { id: 'inv-b2', name: 'Screen 2', resolution: '1920x1080', publisher: { id: 'pub-big', name: 'Big Publisher' } },
+            { id: 'inv-b3', name: 'Screen 3', resolution: '1920x1080', publisher: { id: 'pub-big', name: 'Big Publisher' } },
+            { id: 'inv-s1', name: 'Screen 4', resolution: '1920x1080', publisher: { id: 'pub-small', name: 'Small Publisher' } }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const convertRes = await request('POST', '/deals/import/convert', payload);
+      assert.strictEqual(convertRes.status, 200);
+      
+      const lineItems = convertRes.data.result.converted.lineItems;
+      const bigPub = lineItems.find(li => li.publisherId === 'pub-big');
+      const smallPub = lineItems.find(li => li.publisherId === 'pub-small');
+      
+      assert.strictEqual(bigPub.direct.budgetSetup.budgetAmount, 75000);
+      assert.strictEqual(smallPub.direct.budgetSetup.budgetAmount, 25000);
+      assert.strictEqual(bigPub.direct.campaignGoal.targetValue, 750000);
+      assert.strictEqual(smallPub.direct.campaignGoal.targetValue, 250000);
+    });
+  });
+
+  describe('DIRECT_STANDARD Edge Cases', () => {
+    
+    it('should handle line items with planning data', async () => {
+      const payload = {
+        payloadType: 'DIRECT_STANDARD',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-planning-${Date.now()}`,
+            name: 'Planning Data Campaign',
+            brand: 'Plan Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['test@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 60000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 300000 }
+          },
+          lineItems: [
+            {
+              externalId: 'li-plan-1',
+              name: 'Line Item With Planning',
+              creativeType: 'DISPLAY',
+              resolutions: ['1920x1080'],
+              planning: {
+                capacity: { campaignDays: 30, availableSlots: 10000 },
+                allocation: { slots: 5000, shareOfVoice: 0.5 },
+                estimates: { impressions: 150000, reach: 50000 },
+                pricing: { cpm: 5.0, estimatedCost: 750 }
+              },
+              inventories: [
+                { id: 'inv-plan-1', name: 'Planning Screen', resolution: '1920x1080', publisher: { id: 'pub-plan', name: 'Plan Pub' } }
+              ]
+            }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import', payload);
+      assert.strictEqual(status, 201);
+      createdDealIds.push(data.result.deal.id);
+    });
+
+    it('should handle line items without inventories', async () => {
+      const payload = {
+        payloadType: 'DIRECT_STANDARD',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-no-inv-li-${Date.now()}`,
+            name: 'No Inventory LI Campaign',
+            brand: 'Test Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['test@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 40000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 200000 }
+          },
+          lineItems: [
+            {
+              externalId: 'li-no-inv',
+              name: 'Line Item No Inventories',
+              creativeType: 'VIDEO',
+              resolutions: ['1920x1080']
+            }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import', payload);
+      assert.strictEqual(status, 201);
+      assert.strictEqual(data.result.summary.lineItemsProcessed, 1);
+      assert.strictEqual(data.result.summary.inventoriesProcessed, 0);
+      createdDealIds.push(data.result.deal.id);
+    });
+  });
+
+  describe('PROGRAMMATIC_STANDARD Edge Cases', () => {
+    
+    it('should handle GUARANTEED deal type via convert', async () => {
+      const payload = {
+        payloadType: 'PROGRAMMATIC_STANDARD',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-guaranteed-${Date.now()}`,
+            name: 'Guaranteed Campaign',
+            dealType: 'GUARANTEED',
+            buyers: [{ id: 'buyer-1', name: 'DSP Buyer', seats: ['seat-1'] }],
+            auctionType: 'fixed price',
+            costType: 'CPM',
+            bidFloor: 10.5
+          },
+          lineItems: [
+            {
+              externalId: 'li-guar-1',
+              name: 'Guaranteed Line Item',
+              resolutions: ['1920x1080'],
+              targeting: { venueTypes: ['retail.mall'] },
+              inventories: [
+                { id: 'inv-guar-1', name: 'Guaranteed Screen', resolution: '1920x1080', publisher: { id: 'pub-guar', name: 'Guar Pub' } }
+              ]
+            }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import/convert', payload);
+      assert.strictEqual(status, 200);
+      assert.strictEqual(data.result.converted.deal.dealType, 'GUARANTEED');
+      assert.strictEqual(data.result.converted.deal.mode, 'PROGRAMMATIC');
+    });
+
+    it('should handle PRIVATE_AUCTION with second price via convert', async () => {
+      const payload = {
+        payloadType: 'PROGRAMMATIC_STANDARD',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-auction-${Date.now()}`,
+            name: 'Private Auction Campaign',
+            dealType: 'PRIVATE_AUCTION',
+            buyers: [{ id: 'buyer-2', name: 'Another DSP' }],
+            auctionType: 'second price',
+            costType: 'CPM',
+            bidFloor: 8.0
+          },
+          lineItems: [
+            {
+              externalId: 'li-auction-1',
+              name: 'Auction Line Item',
+              resolutions: ['1920x1080'],
+              inventories: []
+            }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import/convert', payload);
+      assert.strictEqual(status, 200);
+      assert.strictEqual(data.result.converted.deal.dealType, 'PRIVATE_AUCTION');
+      assert.strictEqual(data.result.converted.deal.programmatic.auctionType, 'second price');
+    });
+  });
+
+  describe('Validation Edge Cases', () => {
+    
+    it('should reject invalid payload type', async () => {
+      const payload = {
+        payloadType: 'INVALID_TYPE',
+        externalPayload: { campaign: { name: 'Test' } }
+      };
+
+      const { status, data } = await request('POST', '/deals/import', payload);
+      assert.strictEqual(status, 400);
+      assert.ok(data.message.includes('payloadType'));
+    });
+
+    it('should reject missing campaign in externalPayload', async () => {
+      const payload = {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: { inventories: [] }
+      };
+
+      const { status, data } = await request('POST', '/deals/import', payload);
+      assert.strictEqual(status, 400);
+    });
+
+    it('should create separate deals for independent imports', async () => {
+      const ts = Date.now();
+      const makePayload = (suffix) => ({
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-ind-${ts}-${suffix}`,
+            name: `Independent Import ${suffix}`,
+            brand: 'Test Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['test@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 20000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 50000 }
+          },
+          inventories: [
+            { id: `inv-ind-${ts}-${suffix}`, name: `Screen ${suffix}`, resolution: '1920x1080', publisher: { id: `pub-ind-${suffix}`, name: `Publisher ${suffix}` } }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      });
+
+      const first = await request('POST', '/deals/import', makePayload('first'));
+      assert.strictEqual(first.status, 201, `First import failed: ${JSON.stringify(first.data)}`);
+      createdDealIds.push(first.data.result.deal.id);
+
+      const second = await request('POST', '/deals/import', makePayload('second'));
+      assert.strictEqual(second.status, 201, `Second import failed: ${JSON.stringify(second.data)}`);
+      createdDealIds.push(second.data.result.deal.id);
+      
+      assert.notStrictEqual(first.data.result.deal.id, second.data.result.deal.id, 'Both imports should create separate deals');
+    });
+  });
+
+  describe('Convert Endpoint Edge Cases', () => {
+    
+    it('should convert without persisting', async () => {
+      const uniqueName = `Convert Only Campaign ${Date.now()}`;
+      const payload = {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-convert-only-${Date.now()}`,
+            name: uniqueName,
+            brand: 'Convert Brand',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['convert@test.com'],
+            marketSelection: { country: 'SG', currency: 'SGD' },
+            budgetSetup: { currency: 'SGD', budgetAmount: 50000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 250000 }
+          },
+          inventories: [
+            { id: 'inv-c1', name: 'Convert Screen', resolution: '1920x1080', publisher: { id: 'pub-c', name: 'Convert Pub' } }
+          ]
+        },
+        options: { source: 'e2e-convert-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import/convert', payload);
+      assert.strictEqual(status, 200);
+      assert.ok(data.result.converted.deal);
+      assert.ok(data.result.converted.lineItems);
+      assert.strictEqual(data.result.converted.type, 'DIRECT_PUBLISHER_SPLIT');
+      
+      const listRes = await request('GET', `/deals?search=${encodeURIComponent(uniqueName)}`);
+      const found = listRes.data.result.data.find(d => d.name === uniqueName);
+      assert.strictEqual(found, undefined);
+    });
+
+    it('should return validation errors for invalid payload structure', async () => {
+      const payload = {
+        payloadType: 'PROGRAMMATIC_STANDARD',
+        externalPayload: {
+          lineItems: []
+        }
+      };
+
+      const { status, data } = await request('POST', '/deals/import/convert', payload);
+      assert.strictEqual(status, 400);
+      assert.ok(data.errors || data.message);
+    });
+  });
+
+  describe('Special Characters and Unicode', () => {
+    
+    it('should handle unicode in campaign and publisher names', async () => {
+      const payload = {
+        payloadType: 'DIRECT_PUBLISHER_SPLIT',
+        externalPayload: {
+          campaign: {
+            externalId: `e2e-unicode-${Date.now()}`,
+            name: '春节促销活动 Spring Festival 🎉',
+            brand: 'Ünïcödé Bränd™',
+            clientType: 'DIRECT_ADVERTISER',
+            approvalEmails: ['unicode@test.com'],
+            marketSelection: { country: 'MY', currency: 'MYR' },
+            budgetSetup: { currency: 'MYR', budgetAmount: 25000 },
+            campaignGoal: { type: 'IMPRESSIONS', targetValue: 100000 }
+          },
+          inventories: [
+            { id: 'inv-u1', name: '购物中心屏幕', resolution: '1920x1080', publisher: { id: 'pub-cn', name: '媒体公司' } },
+            { id: 'inv-u2', name: 'Écran français', resolution: '1920x1080', publisher: { id: 'pub-fr', name: 'Médias Français' } }
+          ]
+        },
+        options: { source: 'e2e-test' }
+      };
+
+      const { status, data } = await request('POST', '/deals/import', payload);
+      assert.strictEqual(status, 201);
+      assert.ok(data.result.deal.name.includes('春节'));
+      createdDealIds.push(data.result.deal.id);
+    });
+  });
+});