abapgit-agent 1.7.2 → 1.8.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abapgit-agent",
-  "version": "1.7.2",
+  "version": "1.8.1",
   "description": "ABAP Git Agent - Pull and activate ABAP code via abapGit from any git repository",
   "main": "src/index.js",
   "files": [
@@ -19,11 +19,21 @@
     "start": "node src/server.js",
     "dev": "nodemon src/server.js",
     "test": "jest",
-    "test:all": "node scripts/test-all.js",
+    "test:all": "node tests/run-all.js",
+    "test:unit": "jest",
     "test:jest": "jest",
-    "test:aunit": "node scripts/test-all.js --aunit",
-    "test:cmd": "node scripts/test-all.js --cmd",
-    "test:cmd:demo": "node scripts/test-all.js --cmd --demo",
+    "test:integration": "node tests/run-all.js --cmd",
+    "test:aunit": "node tests/run-all.js --aunit",
+    "test:cmd": "node tests/run-all.js --cmd",
+    "test:cmd:demo": "node tests/run-all.js --cmd --demo",
+    "test:cmd:syntax": "node tests/run-all.js --cmd --command=syntax",
+    "test:cmd:pull": "node tests/run-all.js --cmd --command=pull",
+    "test:cmd:inspect": "node tests/run-all.js --cmd --command=inspect",
+    "test:cmd:unit": "node tests/run-all.js --cmd --command=unit",
+    "test:cmd:view": "node tests/run-all.js --cmd --command=view",
+    "test:cmd:preview": "node tests/run-all.js --cmd --command=preview",
+    "test:cmd:tree": "node tests/run-all.js --cmd --command=tree",
+    "test:lifecycle": "node tests/run-all.js --lifecycle",
     "pull": "node bin/abapgit-agent",
     "release": "node scripts/release.js",
     "unrelease": "node scripts/unrelease.js"
@@ -43,5 +53,11 @@
   },
   "engines": {
     "node": ">=16.0.0"
+  },
+  "jest": {
+    "testMatch": [
+      "**/tests/unit/**/*.test.js"
+    ],
+    "testEnvironment": "node"
   }
 }

package/src/agent.js

@@ -1,13 +1,16 @@
 /**
  * ABAP Git Agent - Main agent class
+ * Uses AbapHttp for all ABAP communication
  */
 
-const { getClient } = require('./abap-client');
+const { AbapHttp } = require('./utils/abap-http');
+const { getAbapConfig } = require('./config');
 const logger = require('./logger');
 
 class ABAPGitAgent {
   constructor() {
-    this.abap = getClient();
+    this.config = getAbapConfig();
+    this.http = new AbapHttp(this.config);
   }
 
   /**
@@ -17,13 +20,31 @@ class ABAPGitAgent {
    * @param {string} username - Git username (optional)
    * @param {string} password - Git password/token (optional)
    * @param {Array} files - Specific files to pull (optional)
+   * @param {string} transportRequest - Transport request number (optional)
    * @returns {object} Pull result with success, job_id, message, error_detail
    */
-  async pull(repoUrl, branch = 'main', username = null, password = null, files = null) {
-    logger.info('Starting pull operation', { repoUrl, branch, username: !!username, files });
+  async pull(repoUrl, branch = 'main', username = null, password = null, files = null, transportRequest = null) {
+    logger.info('Starting pull operation', { repoUrl, branch, username: !!username, files, transportRequest });
 
     try {
-      const result = await this.abap.pull(repoUrl, branch, username, password, files);
+      const csrfToken = await this.http.fetchCsrfToken();
+
+      const data = {
+        url: repoUrl,
+        branch: branch,
+        username: username || this.config.gitUsername,
+        password: password || this.config.gitPassword
+      };
+
+      if (files && files.length > 0) {
+        data.files = files;
+      }
+
+      if (transportRequest) {
+        data.transport_request = transportRequest;
+      }
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/pull', data, { csrfToken });
 
       // Return the result directly from ABAP (handle uppercase keys from /UI2/CL_JSON)
       return {
@@ -49,7 +70,7 @@ class ABAPGitAgent {
    */
   async healthCheck() {
     try {
-      const result = await this.abap.healthCheck();
+      const result = await this.http.get('/sap/bc/z_abapgit_agent/health');
       return {
         status: 'healthy',
         abap: 'connected',
@@ -65,7 +86,7 @@ class ABAPGitAgent {
   }
 
   /**
-   * Check syntax of an ABAP object
+   * Check syntax of an ABAP object (legacy - not used by CLI)
    * @param {string} objectType - ABAP object type (e.g., 'CLAS', 'PROG', 'INTF')
    * @param {string} objectName - ABAP object name
    * @returns {object} Syntax check result with errors (if any)
@@ -74,7 +95,13 @@ class ABAPGitAgent {
     logger.info('Starting syntax check', { objectType, objectName });
 
     try {
-      const result = await this.abap.syntaxCheck(objectType, objectName);
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {
+        object_type: objectType,
+        object_name: objectName
+      };
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/syntax-check', data, { csrfToken });
       return {
         success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
         object_type: result.OBJECT_TYPE || result.object_type,
@@ -88,6 +115,51 @@ class ABAPGitAgent {
     }
   }
 
+  /**
+   * Check syntax of ABAP source code directly (without pull/activation)
+   * Supported types: CLAS, INTF, PROG
+   * @param {Array} objects - Array of {type, name, source, locals_def?, locals_imp?}
+   * @param {string} uccheck - Unicode check mode ('X' for Standard, '5' for Cloud)
+   * @returns {object} Syntax check results with success, results array
+   */
+  async syntaxCheckSource(objects, uccheck = 'X') {
+    logger.info('Starting source syntax check', { objectCount: objects.length, uccheck });
+
+    try {
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {
+        objects: objects,
+        uccheck: uccheck
+      };
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/syntax', data, { csrfToken });
+      const success = result.SUCCESS === 'X' || result.SUCCESS === true ||
+                      result.success === 'X' || result.success === true;
+      const results = result.RESULTS || result.results || [];
+      const message = result.MESSAGE || result.message || '';
+
+      // Normalize results
+      const normalizedResults = results.map(r => ({
+        object_type: r.OBJECT_TYPE || r.object_type,
+        object_name: r.OBJECT_NAME || r.object_name,
+        success: r.SUCCESS === 'X' || r.SUCCESS === true || r.success === 'X' || r.success === true,
+        error_count: r.ERROR_COUNT || r.error_count || 0,
+        errors: r.ERRORS || r.errors || [],
+        warnings: r.WARNINGS || r.warnings || [],
+        message: r.MESSAGE || r.message || ''
+      }));
+
+      return {
+        success,
+        message,
+        results: normalizedResults
+      };
+    } catch (error) {
+      logger.error('Source syntax check failed', { error: error.message });
+      throw new Error(`Source syntax check failed: ${error.message}`);
+    }
+  }
+
   /**
    * Run unit tests for package or objects
    * @param {string} packageName - Package name to run tests for (optional)
@@ -98,7 +170,18 @@ class ABAPGitAgent {
     logger.info('Starting unit tests', { package: packageName, objects });
 
     try {
-      const result = await this.abap.unitTest(packageName, objects);
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {};
+
+      if (packageName) {
+        data.package = packageName;
+      }
+
+      if (objects && objects.length > 0) {
+        data.objects = objects;
+      }
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/unit', data, { csrfToken });
       return {
         success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
         test_count: result.TEST_COUNT || result.test_count || 0,
@@ -127,7 +210,26 @@ class ABAPGitAgent {
     logger.info('Creating repository', { repoUrl, packageName, branch });
 
     try {
-      const result = await this.abap.create(repoUrl, packageName, branch, displayName, name, folderLogic);
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {
+        url: repoUrl,
+        package: packageName,
+        branch: branch
+      };
+
+      if (displayName) {
+        data.display_name = displayName;
+      }
+
+      if (name) {
+        data.name = name;
+      }
+
+      if (folderLogic) {
+        data.folder_logic = folderLogic;
+      }
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/create', data, { csrfToken });
       return {
         success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
         repo_key: result.REPO_KEY || result.repo_key,
@@ -151,7 +253,16 @@ class ABAPGitAgent {
     logger.info('Starting import operation', { repoUrl, message });
 
     try {
-      const result = await this.abap.import(repoUrl, message);
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {
+        url: repoUrl
+      };
+
+      if (message) {
+        data.message = message;
+      }
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/import', data, { csrfToken });
       return {
         success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
         files_staged: result.FILES_STAGED || result.files_staged || 0,
@@ -176,7 +287,14 @@ class ABAPGitAgent {
     logger.info('Getting package tree', { package: packageName, depth, includeObjects });
 
     try {
-      const result = await this.abap.tree(packageName, depth, includeObjects);
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {
+        package: packageName,
+        depth: Math.min(Math.max(1, depth), 10),
+        include_objects: includeObjects
+      };
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/tree', data, { csrfToken });
       return {
         success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
         command: result.COMMAND || result.command || 'TREE',
@@ -206,7 +324,27 @@ class ABAPGitAgent {
     logger.info('Previewing data', { objects, type, limit, offset, where, columns });
 
     try {
-      const result = await this.abap.preview(objects, type, limit, offset, where, columns);
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {
+        objects: objects,
+        limit: Math.min(Math.max(1, limit), 500),
+        offset: Math.max(0, offset)
+      };
+
+      if (type) {
+        data.type = type;
+      }
+
+      if (where) {
+        // Convert ISO date format (YYYY-MM-DD) to ABAP DATS format (YYYYMMDD)
+        data.where = this.convertDatesInWhereClause(where);
+      }
+
+      if (columns) {
+        data.columns = columns;
+      }
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/preview', data, { csrfToken });
       return {
         success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
         command: result.COMMAND || result.command || 'PREVIEW',
@@ -222,6 +360,22 @@ class ABAPGitAgent {
     }
   }
 
+  /**
+   * Convert ISO date formats to ABAP DATS format in WHERE clause
+   * @param {string} whereClause - SQL WHERE clause
+   * @returns {string} - WHERE clause with dates converted to YYYYMMDD format
+   */
+  convertDatesInWhereClause(whereClause) {
+    if (!whereClause) return whereClause;
+
+    const isoDatePattern = /'\\d{4}-\\d{2}-\\d{2}'/g;
+    return whereClause.replace(isoDatePattern, (match) => {
+      const dateContent = match.slice(1, -1);
+      const [year, month, day] = dateContent.split('-');
+      return `'${year}${month}${day}'`;
+    });
+  }
+
   /**
    * List objects in an ABAP package
    * @param {string} packageName - ABAP package name
@@ -235,7 +389,22 @@ class ABAPGitAgent {
     logger.info('Listing objects', { package: packageName, type, name, limit, offset });
 
     try {
-      const result = await this.abap.list(packageName, type, name, limit, offset);
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {
+        package: packageName,
+        limit: Math.min(Math.max(1, limit), 1000),
+        offset: Math.max(0, offset)
+      };
+
+      if (type) {
+        data.type = type;
+      }
+
+      if (name) {
+        data.name = name;
+      }
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/list', data, { csrfToken });
 
       // Normalize objects array to use lowercase keys
       const rawObjects = result.OBJECTS || result.objects || [];
@@ -277,7 +446,16 @@ class ABAPGitAgent {
     logger.info('Viewing objects', { objects, type });
 
     try {
-      const result = await this.abap.view(objects, type);
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {
+        objects: objects
+      };
+
+      if (type) {
+        data.type = type;
+      }
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/view', data, { csrfToken });
       return {
         success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
         command: result.COMMAND || result.command || 'VIEW',
@@ -302,7 +480,18 @@ class ABAPGitAgent {
     logger.info('Finding where-used', { objects, type, limit, offset });
 
     try {
-      const result = await this.abap.where(objects, type, limit, offset);
+      const csrfToken = await this.http.fetchCsrfToken();
+      const data = {
+        objects: objects,
+        limit: Math.min(Math.max(1, limit), 500),
+        offset: Math.max(0, offset)
+      };
+
+      if (type) {
+        data.type = type;
+      }
+
+      const result = await this.http.post('/sap/bc/z_abapgit_agent/where-used', data, { csrfToken });
       return {
         success: result.SUCCESS === 'X' || result.success === 'X' || result.success === true,
         command: result.COMMAND || result.command || 'WHERE',

package/src/commands/create.js

@@ -0,0 +1,102 @@
+/**
+ * Create command - Create abapGit online repository in ABAP system
+ */
+
+module.exports = {
+  name: 'create',
+  description: 'Create abapGit online repository in ABAP system',
+  requiresAbapConfig: true,
+  requiresVersionCheck: true,
+
+  async execute(args, context) {
+    const { loadConfig, gitUtils, AbapHttp } = context;
+
+    // Show help if requested
+    const helpIndex = args.findIndex(a => a === '--help' || a === '-h');
+    if (helpIndex !== -1) {
+      console.log(`
+Usage:
+  abapgit-agent create
+
+Description:
+  Create abapGit online repository in ABAP system.
+  Auto-detects URL from git remote and package from .abapGitAgent.
+
+Prerequisites:
+  - Run "abapgit-agent init" first
+  - Edit .abapGitAgent with credentials (host, user, password)
+
+Examples:
+  abapgit-agent create                    # Create repo in ABAP
+`);
+      return;
+    }
+
+    // Get parameters from config
+    const config = loadConfig();
+    const repoUrl = gitUtils.getRemoteUrl();
+
+    if (!repoUrl) {
+      console.error('Error: No git remote configured. Please configure a remote origin.');
+      process.exit(1);
+    }
+
+    if (!config.package) {
+      console.error('Error: Package not configured. Run "abapgit-agent init" first or set package in .abapGitAgent.');
+      process.exit(1);
+    }
+
+    const branch = gitUtils.getBranch();
+
+    // Extract repo name from git URL
+    const repoName = repoUrl.split('/').pop().replace('.git', '');
+
+    console.log(`\n🚀 Creating online repository`);
+    console.log(`   URL: ${repoUrl}`);
+    console.log(`   Package: ${config.package}`);
+    console.log(`   Folder: ${config.folder || '/src/'}`);
+    console.log(`   Name: ${repoName}`);
+    console.log(`   Branch: ${branch}`);
+
+    const http = new AbapHttp(config);
+    const csrfToken = await http.fetchCsrfToken();
+
+    const data = {
+      url: repoUrl,
+      package: config.package,
+      name: repoName,
+      branch: branch,
+      folder: config.folder || '/src/'
+    };
+
+    if (config.gitUsername) {
+      data.username = config.gitUsername;
+    }
+
+    if (config.gitPassword) {
+      data.password = config.gitPassword;
+    }
+
+    const result = await http.post('/sap/bc/z_abapgit_agent/create', data, { csrfToken });
+
+    console.log('\n');
+
+    // Handle uppercase keys from ABAP
+    const success = result.SUCCESS || result.success;
+    const repoKey = result.REPO_KEY || result.repo_key;
+    const createdRepoName = result.REPO_NAME || result.repo_name;
+    const message = result.MESSAGE || result.message;
+    const error = result.ERROR || result.error;
+
+    if (success === 'X' || success === true) {
+      console.log(`✅ Repository created successfully!`);
+      console.log(`   URL: ${repoUrl}`);
+      console.log(`   Package: ${config.package}`);
+      console.log(`   Name: ${createdRepoName || repoName}`);
+    } else {
+      console.log(`❌ Failed to create repository`);
+      console.log(`   Error: ${error || message || 'Unknown error'}`);
+      process.exit(1);
+    }
+  }
+};

package/src/commands/delete.js

@@ -0,0 +1,72 @@
+/**
+ * Delete command - Delete abapGit online repository from ABAP system
+ */
+
+module.exports = {
+  name: 'delete',
+  description: 'Delete abapGit online repository from ABAP system',
+  requiresAbapConfig: true,
+  requiresVersionCheck: true,
+
+  async execute(args, context) {
+    const { loadConfig, gitUtils, AbapHttp } = context;
+
+    // Show help if requested
+    const helpIndex = args.findIndex(a => a === '--help' || a === '-h');
+    if (helpIndex !== -1) {
+      console.log(`
+Usage:
+  abapgit-agent delete
+
+Description:
+  Delete abapGit online repository from ABAP system.
+  Auto-detects URL from git remote of current directory.
+
+Prerequisites:
+  - Run "abapgit-agent create" first
+
+Examples:
+  abapgit-agent delete   # Delete repo for current git remote
+`);
+      return;
+    }
+
+    // Get URL from current git remote
+    const config = loadConfig();
+    const repoUrl = gitUtils.getRemoteUrl();
+
+    if (!repoUrl) {
+      console.error('Error: No git remote configured. Please configure a remote origin.');
+      process.exit(1);
+    }
+
+    console.log(`\n🗑️  Deleting online repository`);
+    console.log(`   URL: ${repoUrl}`);
+
+    const http = new AbapHttp(config);
+    const csrfToken = await http.fetchCsrfToken();
+
+    const data = {
+      url: repoUrl
+    };
+
+    const result = await http.post('/sap/bc/z_abapgit_agent/delete', data, { csrfToken });
+
+    console.log('\n');
+
+    // Handle uppercase keys from ABAP
+    const success = result.SUCCESS || result.success;
+    const repoKey = result.REPO_KEY || result.repo_key;
+    const message = result.MESSAGE || result.message;
+    const error = result.ERROR || result.error;
+
+    if (success === 'X' || success === true) {
+      console.log(`✅ Repository deleted successfully!`);
+      console.log(`   Key: ${repoKey}`);
+    } else {
+      console.log(`❌ Failed to delete repository`);
+      console.log(`   Error: ${error || message || 'Unknown error'}`);
+      process.exit(1);
+    }
+  }
+};

package/src/commands/health.js

@@ -0,0 +1,24 @@
+/**
+ * Health command - Check ABAP REST API health
+ */
+
+module.exports = {
+  name: 'health',
+  description: 'Check if ABAP REST API is healthy',
+  requiresAbapConfig: true,
+  requiresVersionCheck: false,
+
+  async execute(args, context) {
+    const { config, AbapHttp } = context;
+
+    try {
+      const http = new AbapHttp(config);
+      const result = await http.get('/sap/bc/z_abapgit_agent/health');
+      console.log(JSON.stringify(result, null, 2));
+      return result;
+    } catch (error) {
+      console.error(`Health check failed: ${error.message}`);
+      process.exit(1);
+    }
+  }
+};

package/src/commands/help.js

@@ -0,0 +1,111 @@
+/**
+ * Help command - Display usage information
+ */
+
+module.exports = {
+  name: 'help',
+  description: 'Display usage information and available commands',
+  requiresAbapConfig: false,
+  requiresVersionCheck: false,
+
+  async execute(args, context) {
+    console.log(`
+ABAP Git Agent
+
+Usage:
+  abapgit-agent <command> [options]
+
+Commands:
+  init --folder <folder> --package <package>
+    Initialize local configuration for an existing git repository.
+  init --update
+    Update existing files (CLAUDE.md, copilot-instructions.md, guidelines) to latest version.
+
+  create
+    Create abapGit online repository in ABAP system.
+    Auto-detects URL from git remote and package from .abapGitAgent.
+
+  import [--message <message>]
+    Import existing objects from package to git repository.
+    Uses the git remote URL to find the abapGit online repository.
+
+  pull [--url <git-url>] [--branch <branch>] [--files <file1,file2,...>] [--transport <request>]
+    Pull and activate repository in ABAP system.
+    Auto-detects git remote and branch from current directory.
+    Use --files to pull only specific files.
+    Use --transport to specify a transport request.
+
+  inspect --files <file1>,<file2>,...
+    Inspect ABAP source file(s) for issues. Currently runs syntax check.
+
+  syntax --files <file1>,<file2>,... [--cloud] [--json]
+    Check syntax of ABAP source files WITHOUT pull/activation.
+    Reads source from local files and checks directly in ABAP system.
+    Use --cloud for ABAP Cloud (BTP) stricter syntax checking.
+
+  unit --files <file1>,<file2>,...
+    Run AUnit tests for ABAP test class files (.testclasses.abap)
+
+  tree --package <package> [--depth <n>] [--include-types] [--json]
+    Display package hierarchy tree from ABAP system
+
+  list --package <package> [--type <types>] [--name <pattern>] [--limit <n>] [--offset <n>] [--json]
+    List ABAP objects in a package with filtering and pagination
+
+  view --objects <obj1>,<obj2>,... [--type <type>] [--json]
+    View ABAP object definitions from the ABAP system
+
+  where --objects <obj1>,<obj2>,... [--type <type>] [--limit <n>] [--json]
+    Find where-used list for ABAP objects (classes, interfaces, programs)
+
+  ref <pattern> [--json]
+    Search ABAP reference repositories for patterns. Requires referenceFolder in .abapGitAgent.
+
+  ref --topic <topic> [--json]
+    View specific topic from cheat sheets (exceptions, sql, unit-tests, etc.)
+
+  ref --list-topics
+    List available topics for reference search
+
+  ref --list-repos
+    List all reference repositories in the reference folder
+
+  ref --clone <repo> [--name <folder>]
+    Clone a GitHub repository to the reference folder
+    - Use full URL: https://github.com/user/repo.git
+    - Or short name: user/repo or user/repo (assumes github.com)
+
+  health
+    Check if ABAP REST API is healthy
+
+  status
+    Check if ABAP integration is configured for this repo
+
+Examples:
+  abapgit-agent init --folder /src --package ZMY_PACKAGE      # Initialize
+  abapgit-agent init --update                                # Update files to latest
+  abapgit-agent create                                       # Create repo
+  abapgit-agent delete                                       # Delete repo
+  abapgit-agent import                                       # Import objects to git
+  abapgit-agent import --message "Initial import"            # Import with message
+  abapgit-agent pull                                         # Auto-detect from git
+  abapgit-agent pull --branch develop                        # Specific branch
+  abapgit-agent pull --files src/zcl_my_class.clas.abap          # Specific file
+  abapgit-agent pull --transport DEVK900001                  # With transport
+  abapgit-agent inspect --files src/zcl_my_class.clas.abap       # Syntax check
+  abapgit-agent syntax --files src/zcl_my_class.clas.abap        # Check without pull
+  abapgit-agent syntax --files src/zmy_prog.prog.abap --cloud    # ABAP Cloud check
+  abapgit-agent unit --files src/zcl_my_test.clas.testclasses.abap  # Run unit tests
+  abapgit-agent tree --package $MY_PACKAGE                   # Display package tree
+  abapgit-agent list --package $MY_PACKAGE --type CLAS,INTF  # List classes & interfaces
+  abapgit-agent view --objects ZCL_MY_CLASS                  # View class definition
+  abapgit-agent where --objects ZCL_MY_CLASS                 # Find where class is used
+  abapgit-agent ref "CORRESPONDING"                          # Search for pattern
+  abapgit-agent ref --topic exceptions                       # View exceptions topic
+  abapgit-agent health                                       # Health check
+  abapgit-agent status                                       # Configuration status
+
+For more info: https://github.tools.sap/I045696/abapgit-agent
+`);
+  }
+};