abapgit-agent 1.7.2 → 1.8.1

package/abap/guidelines/08_abapgit.md

@@ -1,3 +1,11 @@
+---
+layout: default
+title: abapGit XML Metadata
+nav_order: 9
+parent: ABAP Coding Guidelines
+grand_parent: ABAP Development
+---
+
 # abapGit Object XML Metadata
 
 Each ABAP object requires an XML metadata file for abapGit to understand how to serialize/deserialize it. This guide provides templates for common object types.
@@ -57,6 +65,7 @@ abapGit needs XML files to:
     <EXPOSURE>2</EXPOSURE>
     <STATE>1</STATE>
     <UNICODE>X</UNICODE>
+    <FIXPT>X</FIXPT>
    </VSEOCLASS>
   </asx:values>
  </asx:abap>
@@ -69,6 +78,9 @@ abapGit needs XML files to:
 - `EXPOSURE`: Exposure (2 = Public, 3 = Protected, 4 = Private)
 - `STATE`: State (1 = Active)
 - `UNICODE`: Unicode encoding (X = Yes)
+- `FIXPT`: Fixed-point arithmetic (X = Yes) - **Always include for correct decimal arithmetic**
+
+**Note**: `<FIXPT>X</FIXPT>` is default for modern ABAP. Without it, decimals treated as integers.
 
 **Local Classes**: If the class has local classes (e.g., test doubles), add:
 - `<WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>` - for test classes
@@ -163,7 +175,41 @@ abapGit needs XML files to:
 
 ---
 
-### CDS View (DDLS)
+### CDS View Entity (DDLS) - RECOMMENDED
+
+**Use by default when user says "create CDS view"**
+
+**Filename**: `src/zc_my_entity.ddls.xml`
+
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_DDLS" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <DDLS>
+    <DDLNAME>ZC_MY_ENTITY</DDLNAME>
+    <DDLANGUAGE>E</DDLANGUAGE>
+    <DDTEXT>My CDS View Entity</DDTEXT>
+    <SOURCE_TYPE>W</SOURCE_TYPE>
+   </DDLS>
+  </asx:values>
+ </asx:abap>
+</abapGit>
+```
+
+**Key Points for CDS View Entities**:
+1. **ABAP file extension**: Use `.ddls.asddls` (NOT `.ddls.abap`)
+2. **XML file**: Use `.ddls.xml`
+3. **DDLNAME**: Must match the CDS view entity name in the source
+4. **SOURCE_TYPE**: `W` = View Entity (modern, recommended)
+5. **Serializer**: Use `LCL_OBJECT_DDLS`
+6. **Source file**: Use `define view entity` (no `@AbapCatalog.sqlViewName`)
+
+---
+
+### CDS View (DDLS) - Legacy Only
+
+**Only use when explicitly requested (e.g., "create legacy CDS view")**
 
 **Filename**: `src/zc_my_view.ddls.xml`
 
@@ -183,12 +229,15 @@ abapGit needs XML files to:
 </abapGit>
 ```
 
-**Key Points for CDS Views**:
+**Key Points for CDS Views (Legacy)**:
 1. **ABAP file extension**: Use `.ddls.asddls` (NOT `.ddls.abap`)
 2. **XML file**: Use `.ddls.xml`
 3. **DDLNAME**: Must match the CDS view name in the source
-4. **SOURCE_TYPE**: V = View, C = Consumption
+4. **SOURCE_TYPE**: `V` = View (legacy)
 5. **Serializer**: Use `LCL_OBJECT_DDLS`
+6. **Source file**: Must include `@AbapCatalog.sqlViewName` annotation
+
+**For detailed comparison and usage guidance, see `guidelines/04_cds.md`**
 
 ---
 

package/abap/guidelines/09_unit_testable_code.md

@@ -1,3 +1,11 @@
+---
+layout: default
+title: Unit Testable Code
+nav_order: 10
+parent: ABAP Coding Guidelines
+grand_parent: ABAP Development
+---
+
 # ABAP Unit Testable Code Guidelines
 
 This document provides guidelines for creating ABAP OO classes/interfaces that can be easily unit tested with test doubles. These guidelines help AI coding tools understand how to design classes that are testable without requiring real dependencies.

package/abap/guidelines/10_common_errors.md

@@ -0,0 +1,95 @@
+---
+layout: default
+title: Common ABAP Errors
+nav_order: 11
+parent: ABAP Coding Guidelines
+grand_parent: ABAP Development
+---
+
+# Common ABAP Errors - Quick Fixes
+
+**Searchable keywords**: error, syntax error, field mismatch, fixed point, comma, host variable, @ prefix, type incompatible
+
+## Fixed Point Arithmetic Error
+
+```
+This ABAP SQL statement uses additions that can only be used when
+the fixed point arithmetic flag is activated
+```
+
+**Fix**: Add `<FIXPT>X</FIXPT>` to class XML.
+
+```xml
+<VSEOCLASS>
+  ...
+  <FIXPT>X</FIXPT>
+</VSEOCLASS>
+```
+
+---
+
+## Field Name Mismatch
+
+```
+The field 'CARRIERID' does not have a corresponding field in the work area
+```
+
+**Fix**: Match structure field names with CDS view.
+
+Check actual names: `abapgit-agent preview --objects <VIEW> --limit 1`
+
+**Better fix**: Use CDS as type: `TYPE STANDARD TABLE OF zc_view WITH DEFAULT KEY`
+
+---
+
+## Missing Commas in SELECT
+
+```
+The elements in the 'SELECT LIST' list must be separated using commas
+```
+
+**Fix**: `SELECT carrid, connid, fldate` (add commas between fields)
+
+---
+
+## Missing @ Escape
+
+```
+Either 'LT_RESULT' has to be escaped using '@' or qualified by a table name
+```
+
+**Fix**: `INTO TABLE @lt_result WHERE field = @lv_param` (add @ prefix)
+
+---
+
+## Type Incompatible
+
+```
+The data type of the component 'OCCUPANCYPERCENT' is not compatible
+```
+
+**Fix for calculated CDS fields**: Use `TYPE decfloat34`
+
+**Fix for other fields**: Use correct data element.
+
+Find: `abapgit-agent view --objects <TABLE> --type TABL`
+
+---
+
+## Using Raw Types
+
+```abap
+❌ carrierid TYPE c LENGTH 3,
+✅ carrierid TYPE s_carr_id,
+```
+
+**Rule**: Always use data elements, never raw types (c, n, p without reference).
+
+Find data elements: `abapgit-agent view --objects <TABLE> --type TABL`
+
+---
+
+## See Also
+- **ABAP SQL** (01_sql.md) - for SQL syntax rules
+- **CDS Views** (04_cds.md) - for CDS selection patterns
+- **abapGit** (08_abapgit.md) - for XML metadata templates