@zq-silk/yui 0.15.11 → 0.16.0

package/dist/release/runtimeRelease.js

@@ -18,6 +18,7 @@ import { createHash, randomBytes, randomUUID } from "node:crypto";
 import { existsSync, lstatSync, mkdirSync, readdirSync, readFileSync, readlinkSync, rmSync, writeFileSync } from "node:fs";
 import { dirname, join, resolve } from "node:path";
 import { readLinuxProcessStartIdentity } from "../controller/domainIdentity.js";
+import { processGenerationIsLive } from "../core/fileLockOwner.js";
 import { writeTextFileAtomically } from "../storage/durableFile.js";
 export const RELEASES_DIRECTORY = "runtime/releases";
 export const ACTIVE_RELEASE_POINTER_PATH = "runtime/active-release.json";
@@ -334,10 +335,7 @@ export function acquireHandoverLock(home) {
                 continue;
             throw error;
         }
-        if (typeof existing.pid === "number"
-            && Number.isSafeInteger(existing.pid)
-            && existing.pid > 0
-            && isHandoverLockLive(existing)) {
+        if (isHandoverLockLive(existing)) {
             throw new Error(`Another Controller handover is already running (owner PID ${existing.pid}, `
                 + `createdAt ${String(existing.createdAt)}): ${lockPath}`);
         }
@@ -350,22 +348,18 @@ export function acquireHandoverLock(home) {
  * A handover lock is live only when its owner process is still the same
  * generation that wrote it. A PID that exists but with a different start
  * identity was reused by an unrelated process, so the lock is stale.
- * Locks written before the start-identity field existed fall back to the
- * PID-exists check for backward compatibility.
+ * An incomplete identity is not proof of a stale owner. Diagnose it without
+ * removing the lock or authorizing an apparent parent by PID alone.
  */
 function isHandoverLockLive(existing) {
     if (typeof existing.pid !== "number"
         || !Number.isSafeInteger(existing.pid)
-        || existing.pid <= 0) {
-        return false;
+        || existing.pid <= 0
+        || typeof existing.processStartIdentity !== "string"
+        || !/^[0-9]{1,32}$/u.test(existing.processStartIdentity)) {
+        throw new Error("Unsupported handover lock identity; preserve the lock and inspect its owner before cleanup.");
     }
-    const currentIdentity = readLinuxProcessStartIdentity(existing.pid);
-    if (currentIdentity === undefined)
-        return false;
-    if (typeof existing.processStartIdentity === "string") {
-        return currentIdentity === existing.processStartIdentity;
-    }
-    return true;
+    return processGenerationIsLive(existing.pid, existing.processStartIdentity);
 }
 export function newHandoverId() {
     return `handover-${randomUUID()}`;