@zq-silk/yui 0.15.11 → 0.16.0

package/dist/controller/clientRuntime.js

@@ -2,18 +2,18 @@ import { spawn } from "node:child_process";
 import { fileURLToPath } from "node:url";
 import { findLiveControllerProcessForHome, inspectLiveControllerProcess } from "../core/controllerProcessIdentity.js";
 import { readHomeFilesystemId } from "../core/homeFilesystemIdentity.js";
+import { AGENT_OPERATIONAL_ENVIRONMENT_NAMES, nativeAgentEnvironmentNames, operationalAgentEnvironment, selectEnvironment, YUI_MANAGED_RUNTIME_ENVIRONMENT_NAMES } from "../agent/launchEnvironment.js";
 import { callController, ControllerClientError, readControllerDiscovery, stopOrphanedFileTaskController } from "../core/controllerClient.js";
 import { FILE_TASK_CONTROLLER_PROTOCOL_VERSION } from "../core/protocol.js";
-import { AGENT_OPERATIONAL_ENVIRONMENT_NAMES, nativeAgentEnvironmentNames, operationalAgentEnvironment, selectEnvironment, YUI_MANAGED_RUNTIME_ENVIRONMENT_NAMES } from "../agent/launchEnvironment.js";
-import { openCurrentTaskStore } from "../storage/currentTaskStore.js";
+import { isForeignHandoverLockHeld } from "../release/runtimeRelease.js";
+import { WorkspaceCleanupBlockedError } from "../repository/taskWorkspacePreparer.js";
 import { hasRuntimeLifecycleWork } from "../runtime/lifecycleReservation.js";
 import { assertControllerStatusIdentity } from "../runtime/runtimeCoherence.js";
-import { EPHEMERAL_DOMAIN_ENVIRONMENT_NAMES } from "./domainIdentity.js";
+import { CONTROLLER_SHUTDOWN_TIMEOUT_MS, LIFECYCLE_REQUEST_TIMEOUT_MS } from "../runtime/runtimeDeadlines.js";
+import { openCurrentTaskStore } from "../storage/currentTaskStore.js";
 import { yuiVersionIdentity } from "../version.js";
+import { EPHEMERAL_DOMAIN_ENVIRONMENT_NAMES } from "./domainIdentity.js";
 import { SessionOwnerReconciliation } from "./sessionOwnerReconciliation.js";
-import { WorkspaceCleanupBlockedError } from "../repository/taskWorkspacePreparer.js";
-import { CONTROLLER_SHUTDOWN_TIMEOUT_MS, LIFECYCLE_REQUEST_TIMEOUT_MS } from "../runtime/runtimeDeadlines.js";
-import { isForeignHandoverLockHeld } from "../release/runtimeRelease.js";
 const STARTUP_TIMEOUT_MS = 5_000;
 const POLL_INTERVAL_MS = 50;
 const ENVIRONMENT_REFRESH_TIMEOUT_MS = 500;
@@ -166,7 +166,7 @@ function assertCompatibleControllerStatus(status, expectedVersion) {
         });
     }
 }
-function spawnDetachedFileTaskController(home, environment) {
+function spawnDetachedFileTaskController(_home, environment) {
     const child = spawn(process.execPath, [fileURLToPath(new URL("./controllerMain.js", import.meta.url))], {
         env: environment,
         detached: true,
@@ -439,9 +439,6 @@ export class FileTaskWorkflowRuntime {
         this.workspacePreparer = workspacePreparer;
         this.clientOptions = clientOptions;
     }
-    notifyStateChanged(taskId) {
-        void this.notifyMailboxChanged({ kind: "task", taskId });
-    }
     notifyMailboxChanged(target) {
         const pending = callFileTaskController(this.home, "scheduler.signal", { key: controllerMailboxKey(target) }, this.clientOptions).then(() => { });
         void pending.catch(this.clientOptions.onError ?? (() => { }));
@@ -577,6 +574,17 @@ export class FileTaskWorkflowRuntime {
             + blockers.map((entry) => (`${entry.owner.roleName}/${entry.nativeSessionId ?? "unknown-session"}`
                 + ` (pid ${entry.physical?.alive === true ? entry.physical.pid : "?"})`)).join("; "));
     }
+    /** Archive cleanup is stronger than a read-only proof that no process is live. */
+    async releaseTaskTerminals(taskId) {
+        await this.assertTaskPhysicalResourcesReleased(taskId);
+        // A Home's server is shared with other Tasks and the Operator. Remove only
+        // this Task's session group; exited panes still own scrollback memory.
+        await this.tmux.stopTaskAsync(taskId);
+        const remaining = this.tmux.inspectTaskRolePanes(taskId);
+        if (remaining.length > 0) {
+            throw new WorkspaceCleanupBlockedError("physical-resource-live", `task:${taskId}`, true, `Task terminals remain after cleanup: ${remaining.map(pane => pane.roleName).join(", ")}.`);
+        }
+    }
     async stopGlobalRoleSession(roleName) {
         if (this.store.getGlobalRole(roleName) === null) {
             throw new Error(`Global Role not found: ${roleName}.`);
@@ -678,11 +686,11 @@ function runtimeOwnerLabel(owner) {
 }
 const MANAGED_RUNTIME_ENVIRONMENT = new Set(YUI_MANAGED_RUNTIME_ENVIRONMENT_NAMES);
 function foregroundGlobalRoleEnvironment(store, roleName, source) {
-    const role = store.getGlobalRole?.(roleName);
-    if (role === null || role === undefined)
+    const role = store.getGlobalRole(roleName);
+    if (role === null)
         return undefined;
-    const agent = store.getConfiguredAgent?.(role.activeAgentId);
-    if (agent === null || agent === undefined)
+    const agent = store.getConfiguredAgent(role.activeAgentId);
+    if (agent === null)
         return undefined;
     const declaredSources = new Set(agent.environment.map((binding) => binding.sourceName));
     for (const name of MANAGED_RUNTIME_ENVIRONMENT)

package/dist/controller/controller.js

@@ -16,7 +16,6 @@ import { nearestDeadlineBatch } from "../coordination/deadlineScheduler.js";
 import { mailboxHasWork, nextPendingBatch } from "../coordination/workMailbox.js";
 import { hasRuntimeCleanupObligation } from "../runtime/lifecycleReservation.js";
 import { formatTaskRecordReference } from "../task/taskRecordReference.js";
-import { activationRequestIsControllerAdoptable } from "../task/taskActivation.js";
 import { parseDurableJobAcknowledgeParams, parseDurableJobCancelParams, parseDurableJobRefParams, parseDurableJobStartParams } from "./jobControl.js";
 const DEFAULT_RECONCILIATION_INTERVAL_MS = reconciliationIntervalMilliseconds();
 const DEFAULT_SIGNAL_WINDOW_MS = 100;
@@ -217,8 +216,7 @@ async function processSelectedRoleRuntimeCleanups(store, delivery, lifecycleHost
                 if (!await lifecycleHost.stopOwner(owner)) {
                     throw new Error(`Role runtime cleanup could not confirm the host stopped: ${runtimeOwnerLabel(owner)}.`);
                 }
-                if (store.completeRuntimeCleanup === undefined
-                    || !store.completeRuntimeCleanup(target, now)) {
+                if (!store.completeRuntimeCleanup(target, now)) {
                     throw new Error(`Role runtime cleanup mailbox changed: ${runtimeOwnerLabel(owner)}.`);
                 }
                 forgetPreparedRuntimeOwner(delivery, owner);
@@ -252,7 +250,7 @@ function selectedTaskIdsForBoundedPass(store, selection) {
     return new Set(selectedActiveSchedulerTasks(store, selection).map((task) => task.id));
 }
 function selectedReadyWorkMailboxes(store) {
-    return store.listReadyWorkMailboxes?.() ?? store.listWorkMailboxes();
+    return store.listReadyWorkMailboxes();
 }
 function selectedRuntimeLifecycleTargets(store, scope, blockedTaskIds = new Set()) {
     if (scope.kind === "full") {
@@ -456,9 +454,9 @@ export function compileReconcileSelection(scope) {
     };
 }
 /**
- * Adopts activation requests whose deferral has been released.
+ * Continues admitted activation requests once their execution boundaries allow it.
  *
- * The deferral is only ever released by the planning Turn ending, so this phase
+ * A planning deferral is released only by its Turn ending. This phase therefore
  * re-reads the request instead of trusting the signal that woke it: a request
  * cancelled, or a Task retired or stopped, while the Turn was still running is
  * left alone rather than replayed as historical intent. Adoption itself belongs
@@ -475,10 +473,7 @@ async function adoptReleasedTaskActivations(store, workspace, selection, onError
     if (workspace === undefined)
         return;
     const candidates = selection.full
-        ? (store.listPendingActivationRequestTaskIds?.()
-            ?? store.listTasks().flatMap((task) => (task.status === "draft" && task.activationRequest?.disposition === "pending"
-                ? [task.id]
-                : [])))
+        ? store.listPendingActivationRequestTaskIds()
         : selection.taskIds;
     for (const taskId of candidates) {
         if (selection.blockedTaskIds?.has(taskId))
@@ -489,20 +484,14 @@ async function adoptReleasedTaskActivations(store, workspace, selection, onError
         const request = task.activationRequest;
         if (request?.disposition !== "pending")
             continue;
-        // Continue only requests with a provable source: a released deferral, or an
-        // immediate request carrying a recognised origin (explicit action, or a
-        // develop submission accepted while unplanned). This admits legal
-        // Operator/user immediate requests the old actor filter dropped, while
-        // still refusing origin-less historical requests, which stay behind the
-        // explicit `yui task activate` boundary.
-        if (!activationRequestIsControllerAdoptable(request))
-            continue;
+        // The request was authorized at admission. Recheck its current execution
+        // and Session boundaries without a second provenance-based workflow gate.
         // Later Draft discussion is a Session notification, not another AgentRun.
         // Its durable activation intent is sufficient once the exact native input
         // is settled. Never create a synthetic Run merely to release that intent.
         if (store.getActiveRun(taskId, "leader") !== null)
             continue;
-        const provider = store.getTaskRoleSessionSet?.(taskId, "leader")?.providerBinding;
+        const provider = store.getTaskRoleSessionSet(taskId, "leader")?.providerBinding;
         if (provider?.run != null
             && ["submitting", "accepted", "delivery-unknown"].includes(provider.run.status))
             continue;
@@ -663,7 +652,6 @@ function mergeControllerSchedulerResults(results) {
 export class FileTaskController {
     store;
     delivery;
-    #startedAt;
     #intervalMs;
     #now;
     #onError;
@@ -702,6 +690,7 @@ export class FileTaskController {
     #leaderWakeFence;
     #jobSupervisor;
     #globalInputDelivery;
+    #providerRetry;
     #continuationReconciler;
     #current;
     #operatorCurrent;
@@ -711,6 +700,7 @@ export class FileTaskController {
     #operatorStartupRetryArmed = false;
     #lastOperatorSignalIdentity;
     #stopped = false;
+    #workspaceWaitAbort = new AbortController();
     #lastRuntimeDrain;
     #runtimeDrainPasses = 0;
     #runtimeListedEvents = 0;
@@ -722,9 +712,12 @@ export class FileTaskController {
         this.delivery = delivery;
         this.#intervalMs = positiveInteger(options.intervalMs, DEFAULT_RECONCILIATION_INTERVAL_MS, "Controller reconciliation interval");
         this.#now = options.now ?? (() => new Date());
-        this.#startedAt = this.#now();
         this.#onError = options.onError ?? (() => { });
-        this.#workspacePreparer = options.workspacePreparer;
+        const workspacePreparer = options.workspacePreparer;
+        this.#workspacePreparer = workspacePreparer === undefined ? undefined : {
+            prepareTaskWorkspace: (taskId) => workspacePreparer.prepareTaskWorkspace(taskId, this.#workspaceWaitAbort.signal),
+            activateTaskWorkspace: (taskId, environment) => workspacePreparer.activateTaskWorkspace(taskId, environment, this.#workspaceWaitAbort.signal)
+        };
         this.#deliveryRetryMs = positiveInteger(options.deliveryRetryMs, DEFAULT_DELIVERY_RETRY_MS, "Controller delivery retry delay");
         this.#deliveryRetryLimit = positiveInteger(options.deliveryRetryLimit, DEFAULT_DELIVERY_RETRY_LIMIT, "Controller delivery retry limit");
         this.#deliveryTimeoutMs = positiveInteger(options.deliveryTimeoutMs, DEFAULT_DELIVERY_TIMEOUT_MS, "Controller delivery timeout");
@@ -749,6 +742,7 @@ export class FileTaskController {
         this.#jobSupervisor = options.jobSupervisor;
         this.#continuationReconciler = options.continuationReconciler;
         this.#globalInputDelivery = options.globalInputDelivery;
+        this.#providerRetry = options.providerRetry;
         this.#signalScheduler = new MailboxScheduler(async (keys) => { await this.#requestPass({ kind: "dirty", keys }); }, {
             windowMs: options.signalWindowMs ?? DEFAULT_SIGNAL_WINDOW_MS,
             onError: this.#onError,
@@ -846,6 +840,7 @@ export class FileTaskController {
     }
     stop() {
         this.#stopped = true;
+        this.#workspaceWaitAbort.abort(new Error("Controller stopped while waiting for Project maintenance."));
         this.#signalScheduler.stop();
         this.#operatorSignalScheduler.stop();
         if (this.#deadlineTimer !== undefined) {
@@ -988,6 +983,7 @@ export class FileTaskController {
                         }
                     }
                     const firstRuntimeDrain = await this.#drainRuntimeEvents();
+                    await this.#providerRetry?.reconcile();
                     await this.#globalInputDelivery?.();
                     for (const taskId of runtimeTaskFailureIds(firstRuntimeDrain)) {
                         runtimeFailedTaskIds.add(taskId);
@@ -1331,7 +1327,7 @@ export class FileTaskController {
                     at: Date.parse(request.policy.timeoutAt)
                 }]
             : []);
-        const nearest = nearestDeadlineBatch(deadlines);
+        const nearest = nearestDeadlineBatch([...deadlines, ...(this.#providerRetry?.deadlines() ?? [])]);
         if (nearest === null)
             return;
         const now = this.#now().getTime();
@@ -1640,7 +1636,7 @@ export async function startFileTaskController(home, store, delivery, dispatcher,
                 }
                 if (method === "job.get") {
                     const ref = parseDurableJobRefParams(params);
-                    const job = control.getJob(ref.taskId, ref.jobId);
+                    const job = control.getJob(ref.taskId, ref.jobId, ref.caller);
                     if (job === null) {
                         throw controllerApplicationError("NOT_FOUND", `DurableJob not found: ${ref.taskId}/${ref.jobId}.`);
                     }