@zhushanwen/pi-subagent-workflow 8.5.0 → 8.7.0

package/src/execution/__tests__/session-runner-schema-env.test.ts

@@ -1,311 +0,0 @@
-// src/__tests__/session-runner-schema-env.test.ts
-//
-// Wave 2 (issue #3): schemaEnv bridge 测试。
-//
-// 覆盖 test-matrix 用例:
-//   - T3.9  (boundary): schemaEnv 透传——传入时 childEnv 含 PI_WORKFLOW_SCHEMA
-//   - T3.11 (state):    schemaEnv 不传 → childEnv 无 PI_WORKFLOW_SCHEMA（BC-6 tool 层不变）
-//   - T3.16 (NFR-compatibility): schemaEnv 不传时 BC-6 childEnv 等价——不传时与合并前
-//     行为一致，不注入 PI_WORKFLOW_SCHEMA → structured-output tool 不注册
-//
-// 测试策略：
-//   - applySchemaEnvToChildEnv 纯函数单测（不依赖 runSpawn/spawn mock）
-//   - runSpawn 集成测试：通过 mock spawn 拦截 childEnv，验证 schemaEnv 实际注入
-//
-// D-A6: schemaEnv 经 RunOptions 透传到 runSpawn childEnv。
-// BC-6: tool 层 execute 不传 schemaEnv → childEnv 不设 PI_WORKFLOW_SCHEMA → 行为不变。
-
-import type { PassThrough } from "node:stream";
-
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-
-// ── mock modules (与 run-spawn-integration.test.ts 同模式) ──
-
-vi.mock("node:child_process", async () => {
-  const { EventEmitter } = await import("node:events");
-  const { PassThrough } = await import("node:stream");
-
-  class FakeChild extends EventEmitter {
-    pid = 12345;
-    stdout = new PassThrough();
-    stdin = new PassThrough(); // runSpawn 注册 stdin EPIPE handler（session-runner），FakeChild 必须提供
-    stderr = new PassThrough();
-    killed = false;
-    killSignal: string | undefined;
-    kill(sig?: string): boolean {
-      this.killed = true;
-      this.killSignal = sig;
-      return true;
-    }
-  }
-
-  return {
-    spawn: vi.fn(() => new FakeChild()),
-    // buildEnvBlock 用 execFile 异步取 git branch：默认 err-first 兜底（catch → branch=""）
-    execFile: vi.fn(
-      (
-        _cmd: string,
-        _args: readonly string[],
-        _opts: unknown,
-        cb: (err: Error | null, stdout?: string, stderr?: string) => void,
-      ) => cb(new Error("execFile not configured in this test")),
-    ),
-  };
-});
-
-vi.mock("node:fs", async () => {
-  const actual = await import("node:fs");
-  return {
-    default: {
-      ...actual,
-      mkdirSync: vi.fn(),
-      existsSync: vi.fn(() => false),
-      appendFileSync: vi.fn(),
-      writeFileSync: vi.fn(),
-      readdirSync: vi.fn(() => []),
-    },
-    mkdirSync: vi.fn(),
-    existsSync: vi.fn(() => false),
-    appendFileSync: vi.fn(),
-    writeFileSync: vi.fn(),
-    readdirSync: vi.fn(() => []),
-    promises: actual.promises,
-  };
-});
-
-vi.mock("../alive-store.ts", () => ({
-  writeAliveMarker: vi.fn(),
-}));
-
-vi.mock("../temp-prompt.ts", () => ({
-  writePromptToTempFile: vi.fn(async (agent: string) => {
-    const safeName = agent.replace(/[^\w.-]+/g, "_");
-    return { dir: `/tmp/fake-${safeName}`, filePath: `/tmp/fake-${safeName}/prompt-${safeName}.md` };
-  }),
-  cleanupTempPrompt: vi.fn(async () => {}),
-}));
-
-import { spawn } from "node:child_process";
-import * as fs from "node:fs";
-
-import { waitForSpawn } from "./helpers/spawn-mock.ts";
-import { createRecord } from "../execution-record.ts";
-import {
-  applySchemaEnvToChildEnv,
-  type RunOptions,
-  runSpawn,
-  type SessionRunnerContext,
-} from "../session-runner.ts";
-
-const mockSpawn = vi.mocked(spawn);
-const mockExistsSync = vi.mocked(fs.existsSync);
-
-interface FakeChild {
-  pid: number;
-  stdout: PassThrough;
-  stderr: PassThrough;
-  killed: boolean;
-  killSignal: string | undefined;
-  kill(sig?: string): boolean;
-  emit(event: string, ...args: unknown[]): boolean;
-}
-
-function getLastSpawnedChild(): FakeChild {
-  const result = mockSpawn.mock.results.at(-1);
-  if (!result) throw new Error("spawn was not called yet");
-  return result.value as FakeChild;
-}
-
-function getLastSpawnEnv(): Record<string, string | undefined> {
-  return mockSpawn.mock.calls.at(-1)?.[2]?.env as Record<string, string | undefined> ?? {};
-}
-
-// ── 公共 fixture ──
-
-function makeRecord() {
-  return createRecord("test-1", {
-    agent: "general-purpose",
-    model: "test/model",
-    mode: "sync",
-    task: "test task",
-    startedAt: Date.now(),
-    rootSessionId: "s1",
-    parentRecordId: undefined,
-    depth: 0,
-  });
-}
-
-function makeRunOpts(overrides: Partial<RunOptions> = {}): RunOptions {
-  return {
-    resolved: { model: { provider: "test", id: "model" }, thinkingLevel: undefined },
-    agentConfig: undefined,
-    appendSystemPrompt: undefined,
-    skillPath: undefined,
-    schema: undefined,
-    maxTurns: undefined,
-    graceTurns: undefined,
-    signal: undefined,
-    onEvent: undefined,
-    ...overrides,
-  };
-}
-
-function makeCtx(overrides: Partial<SessionRunnerContext> = {}): SessionRunnerContext {
-  return {
-    cwd: "/fake/cwd",
-    agentDir: "/fake/agent",
-    skillDirs: [],
-    mainCwd: "/fake/cwd",
-    sessionRootId: "root-session-test",
-    rootCwd: "/fake/cwd",
-    ...overrides,
-  };
-}
-
-// ── applySchemaEnvToChildEnv 纯函数单测 ──
-
-describe("applySchemaEnvToChildEnv (T3.9/T3.11/T3.16)", () => {
-  // T3.11: schemaEnv 不传 → childEnv 无 PI_WORKFLOW_SCHEMA
-  it("T3.11: schemaEnv 不传时 childEnv 不含 PI_WORKFLOW_SCHEMA（BC-6）", () => {
-    const childEnv: Record<string, string | undefined> = { PATH: "/usr/bin" };
-    applySchemaEnvToChildEnv(childEnv, undefined);
-    expect(childEnv).not.toHaveProperty("PI_WORKFLOW_SCHEMA");
-    expect(childEnv.PATH).toBe("/usr/bin"); // 其他 key 不受影响
-  });
-
-  // T3.16: schemaEnv 不传时 BC-6 childEnv 等价——合并前后行为一致
-  it("T3.16: schemaEnv 不传时 childEnv 等价于合并前（BC-6，不注入 PI_WORKFLOW_SCHEMA）", () => {
-    const childEnv: Record<string, string | undefined> = {};
-    applySchemaEnvToChildEnv(childEnv, undefined);
-    // 不传 schemaEnv 时，childEnv 应与调用前完全一致（不含 PI_WORKFLOW_SCHEMA）
-    expect(Object.keys(childEnv)).toHaveLength(0);
-    expect(childEnv.PI_WORKFLOW_SCHEMA).toBeUndefined();
-  });
-
-  // T3.16 补充: schemaEnv 为空串也不注入（空串不是有效 schema）
-  it("T3.16 补充: schemaEnv 为空串时不注入（false-ish 语义）", () => {
-    const childEnv: Record<string, string | undefined> = {};
-    applySchemaEnvToChildEnv(childEnv, "");
-    expect(childEnv).not.toHaveProperty("PI_WORKFLOW_SCHEMA");
-  });
-
-  // T3.9: schemaEnv 传入 → childEnv 含 PI_WORKFLOW_SCHEMA
-  it("T3.9: schemaEnv 传入时 childEnv 含 PI_WORKFLOW_SCHEMA", () => {
-    const childEnv: Record<string, string | undefined> = {};
-    const schemaJson = '{"type":"object","properties":{"x":{"type":"number"}}}';
-    applySchemaEnvToChildEnv(childEnv, schemaJson);
-    expect(childEnv.PI_WORKFLOW_SCHEMA).toBe(schemaJson);
-  });
-
-  // T3.9 补充: schemaEnv 值为复杂 JSON 字符串时正确透传
-  it("T3.9 补充: schemaEnv 值为复杂 JSON 字符串时完整透传", () => {
-    const childEnv: Record<string, string | undefined> = {};
-    const schemaJson = JSON.stringify({
-      type: "object",
-      properties: {
-        name: { type: "string" },
-        age: { type: "number", minimum: 0 },
-      },
-      required: ["name"],
-    });
-    applySchemaEnvToChildEnv(childEnv, schemaJson);
-    expect(childEnv.PI_WORKFLOW_SCHEMA).toBe(schemaJson);
-    // 验证可以 parse 回原始结构
-    expect(() => JSON.parse(childEnv.PI_WORKFLOW_SCHEMA!)).not.toThrow();
-  });
-
-  // T3.9 补充: schemaEnv 与已有 key 不冲突
-  it("T3.9 补充: schemaEnv 注入不覆盖 childEnv 已有 key", () => {
-    const childEnv: Record<string, string | undefined> = {
-      PATH: "/usr/bin",
-      HOME: "/home/user",
-    };
-    applySchemaEnvToChildEnv(childEnv, '{"x":1}');
-    expect(childEnv.PATH).toBe("/usr/bin");
-    expect(childEnv.HOME).toBe("/home/user");
-    expect(childEnv.PI_WORKFLOW_SCHEMA).toBe('{"x":1}');
-  });
-});
-
-// ── runSpawn 集成测试：schemaEnv 经 RunOptions → childEnv ──
-
-describe("runSpawn schemaEnv childEnv 注入 (T3.9/T3.11)", () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-    mockExistsSync.mockReturnValue(false);
-  });
-
-  afterEach(() => {
-    vi.restoreAllMocks();
-  });
-
-  // T3.11: schemaEnv 不传 → childEnv 的 PI_WORKFLOW_SCHEMA 保持 process.env 原值
-  // BC-6: applySchemaEnvToChildEnv 不注入新值，但 process.env 可能已有此 key（子进程继承父环境）。
-  // 验证点: 不传 schemaEnv 时我们的代码不修改 PI_WORKFLOW_SCHEMA。
-  it("T3.11 (integration): RunOptions 无 schemaEnv → childEnv 继承 process.env 原值（BC-6）", async () => {
-    const record = makeRecord();
-    const opts = makeRunOpts({ schemaEnv: undefined });
-    const ctx = makeCtx();
-
-    const resultPromise = runSpawn(record, "test task", opts, ctx);
-    await waitForSpawn(mockSpawn);
-    const childEnv = getLastSpawnEnv();
-    // BC-6: schemaEnv 未传入 → PI_WORKFLOW_SCHEMA 应为 process.env 原值（我们的代码不注入）
-    expect(childEnv.PI_WORKFLOW_SCHEMA).toBe(process.env.PI_WORKFLOW_SCHEMA);
-
-    const child = getLastSpawnedChild();
-    child.emit("close", 0);
-    await resultPromise;
-  });
-
-  // T3.9: schemaEnv 传入 → childEnv 含 PI_WORKFLOW_SCHEMA
-  it("T3.9 (integration): RunOptions 有 schemaEnv → childEnv 含 PI_WORKFLOW_SCHEMA", async () => {
-    const record = makeRecord();
-    const schemaJson = '{"type":"object","properties":{"result":{"type":"string"}}}';
-    const opts = makeRunOpts({ schemaEnv: schemaJson });
-    const ctx = makeCtx();
-
-    const resultPromise = runSpawn(record, "test task", opts, ctx);
-    await waitForSpawn(mockSpawn);
-    const childEnv = getLastSpawnEnv();
-    expect(childEnv.PI_WORKFLOW_SCHEMA).toBe(schemaJson);
-
-    // 关闭子进程
-    const child = getLastSpawnedChild();
-    child.emit("close", 0);
-    await resultPromise;
-  });
-
-  // T3.9 + fork: schemaEnv 与 fork env 共存时不冲突
-  it("T3.9 + fork: schemaEnv 与 fork depth env 共存不冲突", async () => {
-    const record = createRecord("test-fork-1", {
-      agent: "general-purpose",
-      model: "test/model",
-      mode: "sync",
-      task: "test task",
-      startedAt: Date.now(),
-      rootSessionId: "s1",
-      parentRecordId: undefined,
-      depth: 1,
-    });
-    const schemaJson = '{"type":"object"}';
-    const opts = makeRunOpts({
-      schemaEnv: schemaJson,
-      fork: true,
-      parentForkDepth: 0,
-    });
-    const ctx = makeCtx();
-
-    const resultPromise = runSpawn(record, "test task", opts, ctx);
-    await waitForSpawn(mockSpawn);
-    const childEnv = getLastSpawnEnv();
-    // fork depth env 应存在
-    expect(childEnv.PI_SUBAGENT_FORK_DEPTH).toBe("1");
-    // schemaEnv 也应存在
-    expect(childEnv.PI_WORKFLOW_SCHEMA).toBe(schemaJson);
-
-    const child = getLastSpawnedChild();
-    child.emit("close", 0);
-    await resultPromise;
-  });
-});

package/src/execution/__tests__/session-start-reaper.test.ts

@@ -1,233 +0,0 @@
-// src/__tests__/session-start-reaper.test.ts
-//
-// 验证 session_start 的两个新行为：
-//   1. WTM.scan reaper 被调用（best-effort）
-//   2. mainSessionFile 被缓存
-//   3. scan 抛错不阻断启动
-
-import { beforeEach,describe, expect, it, vi } from "vitest";
-
-// ── mock modules（在 import 前声明）──
-
-vi.mock("@earendil-works/pi-coding-agent", () => ({
-  getAgentDir: () => "/home/user/.pi/agent",
-}));
-vi.mock("@earendil-works/pi-coding-agent", () => ({
-  getAgentDir: () => "/home/user/.pi/agent",
-}));
-vi.mock("@earendil-works/pi-ai", () => ({
-  StringEnum: (values: string[]) => ({ type: "string", enum: values }),
-}));
-vi.mock("@earendil-works/pi-ai", () => ({
-  StringEnum: (values: string[]) => ({ type: "string", enum: values }),
-}));
-vi.mock("typebox", () => ({
-  Type: {
-    Object: (props: Record<string, unknown>) => ({ type: "object", properties: props }),
-    Optional: (schema: unknown) => ({ ...schema as object, optional: true }),
-    String: () => ({ type: "string" }),
-    Boolean: () => ({ type: "boolean" }),
-    Number: () => ({ type: "number" }),
-    Array: (items: unknown) => ({ type: "array", items }),
-    Record: (key: unknown, value: unknown) => ({ type: "object", additionalProperties: value, key }),
-    Unknown: () => ({ type: "unknown" }),
-    Union: (members: unknown[]) => ({ type: "union", members }),
-    Literal: (value: unknown) => ({ type: "literal", value }),
-  },
-}));
-
-// hoisted mock 实例
-const { mockScan, mockCleanup } = vi.hoisted(() => ({
-  mockScan: vi.fn(),
-  mockCleanup: vi.fn(),
-}));
-
-vi.mock("../worktree-manager.ts", () => ({
-  WorktreeManager: class {
-    constructor(_agentDir: string) { /* mock */ }
-    scan = mockScan;
-    cleanup = mockCleanup;
-    create = vi.fn();
-    collectPatch = vi.fn();
-    registerPid = vi.fn();
-  },
-}));
-
-vi.mock("../session-file-gc.ts", () => ({
-  maybeCleanupExpiredSessionFiles: vi.fn(),
-}));
-
-// mock subagent-service：避免真正构造 SubagentService（它依赖 ModelConfigService 等）
-const { mockInitModel, mockInitSession, mockSetUiRequestHandler, mockSetModelConfigService, mockSetSubagentService, capturedConstructorArg } =
-  vi.hoisted(() => ({
-    mockInitModel: vi.fn(),
-    mockInitSession: vi.fn(),
-    // W3: index.ts session_start 注入 UI handler 时调用
-    mockSetUiRequestHandler: vi.fn(),
-    mockSetModelConfigService: vi.fn(),
-    mockSetSubagentService: vi.fn(),
-    capturedConstructorArg: { current: undefined as unknown },
-  }));
-
-vi.mock("../model-config-service.ts", () => ({
-  ModelConfigService: class {
-    initModel = mockInitModel;
-  },
-  getModelConfigService: () => null,
-  setModelConfigService: mockSetModelConfigService,
-}));
-
-vi.mock("../subagent-service.ts", () => ({
-  SubagentService: class {
-    initSession = mockInitSession;
-    // W3: index.ts session_start 注入 UI handler 时调用
-    setUiRequestHandler = mockSetUiRequestHandler;
-    startGcTimer = vi.fn();
-    recoverManifestTmpFiles = vi.fn(async () => ({ deleted: 0, recovered: 0 }));
-    constructor(init: unknown) {
-      capturedConstructorArg.current = init;
-    }
-  },
-  getSubagentService: () => null,
-  setSubagentService: mockSetSubagentService,
-}));
-
-// mock commands/tools（避免触发真实注册）
-vi.mock("../commands/subagents.ts", () => ({
-  registerSubagentsCommand: vi.fn(),
-}));
-vi.mock("../tools/subagent-tool.ts", () => ({
-  registerSubagentTool: vi.fn(),
-}));
-vi.mock("../tui/bg-notify-render.ts", () => ({
-  renderBgNotifyMessage: vi.fn(),
-}));
-
-// ── import 被测工厂 ──
-import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-
-import subagentsExtension from "../../index.ts";
-
-// ── helpers ──
-
-/** 创建最小 mock ExtensionAPI，捕获 session_start handler。 */
-function createMockPi(overrides: Record<string, unknown> = {}): {
-  pi: ExtensionAPI;
-  getSessionStartHandler: () => ((event: unknown, ctx: unknown) => void) | undefined;
-} {
-  let sessionStartHandler: ((event: unknown, ctx: unknown) => void) | undefined;
-  const noop = (): void => { /* mock */ };
-  const pi = new Proxy<ExtensionAPI>(overrides as ExtensionAPI, {
-    get(target, prop: string | symbol): unknown {
-      if (prop === "on") {
-        return (event: string, handler: (...args: unknown[]) => unknown) => {
-          if (event === "session_start") {
-            sessionStartHandler = handler as (event: unknown, ctx: unknown) => void;
-          }
-        };
-      }
-      if (prop in target) return target[prop as keyof ExtensionAPI];
-      return noop;
-    },
-  });
-  return {
-    pi,
-    getSessionStartHandler: () => sessionStartHandler,
-  };
-}
-
-/** 最小 ExtensionContext mock。 */
-function createMockCtx(overrides: Record<string, unknown> = {}): Record<string, unknown> {
-  return {
-    cwd: "/home/user/project",
-    // [Wave1 #21] mode 必填（与 SDK ExtensionContext 契约一致）；默认 tui。
-    mode: "tui",
-    modelRegistry: { getAvailable: () => [], find: () => undefined, hasConfiguredAuth: () => false },
-    model: undefined,
-    sessionManager: {
-      getSessionId: () => "session-123",
-      getSessionFile: () => "/home/user/.pi/agent/sessions/session-123.jsonl",
-      getSessionDir: () => "/home/user/.pi/agent/sessions",
-      getCwd: () => "/home/user/project",
-      getEntries: () => [],
-      getBranch: () => [],
-      getLeafId: () => null,
-      getLeafEntry: () => undefined,
-      getEntry: () => undefined,
-      getHeader: () => null,
-      getTree: () => [],
-      getSessionName: () => undefined,
-    },
-    ...overrides,
-  };
-}
-
-// ── tests ──
-
-describe("session_start worktree reaper", () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-  });
-
-  it("session_start 触发 WTM.scan 调用", async () => {
-    const { pi, getSessionStartHandler } = createMockPi();
-    subagentsExtension(pi);
-
-    const handler = getSessionStartHandler();
-    expect(handler).toBeDefined();
-
-    await handler!(
-      { type: "session_start", reason: "startup" },
-      createMockCtx(),
-    );
-
-    expect(mockScan).toHaveBeenCalledTimes(1);
-    // scan 无参（全局注册表，不依赖 cwd）
-    expect(mockScan).toHaveBeenCalledWith();
-  });
-
-  it("scan 抛错不阻断 session_start", async () => {
-    mockScan.mockImplementation(() => {
-      throw new Error("git not found");
-    });
-
-    const { pi, getSessionStartHandler } = createMockPi();
-    subagentsExtension(pi);
-
-    const handler = getSessionStartHandler();
-    expect(handler).toBeDefined();
-
-    // 不应抛错
-    await expect(
-      handler!(
-        { type: "session_start", reason: "startup" },
-        createMockCtx(),
-      )
-    ).resolves.toBeUndefined();
-
-    // service 仍然被注册（启动未被阻断）
-    expect(mockSetSubagentService).toHaveBeenCalled();
-  });
-
-  it("mainSessionFile 被缓存并传给 SubagentService", async () => {
-    const { pi, getSessionStartHandler } = createMockPi();
-    subagentsExtension(pi);
-
-    const handler = getSessionStartHandler();
-    await handler!(
-      { type: "session_start", reason: "startup" },
-      createMockCtx(),
-    );
-
-    // SubagentService 构造参数含 getMainSessionFile getter
-    const init = capturedConstructorArg.current as {
-      getMainSessionFile?: () => string | undefined;
-    } | undefined;
-    expect(init).toBeDefined();
-    expect(init?.getMainSessionFile).toBeDefined();
-    // 返回 session_start 时缓存的 sessionFile
-    expect(init?.getMainSessionFile?.()).toBe(
-      "/home/user/.pi/agent/sessions/session-123.jsonl",
-    );
-  });
-});