@zhushanwen/pi-subagent-workflow 8.5.0 → 8.7.0

package/src/orchestration/__tests__/launcher-nested-workflow.test.ts

@@ -1,277 +0,0 @@
-/**
- * executeNestedWorkflow — workflow() 嵌套调用实现测试。
- *
- * 覆盖 6 个场景：循环检测、registry 未找到、lint 失败、成功执行、budget 同步、
- * 子 workflow 失败。
- *
- * 通过 vi.mock("../lifecycle.ts") 控制 runWorkflow：返回固定 runId + 把预构造的
- * child run 注入 deps.runs，使 pollRunToResult 首轮即命中 done 返回（无需真实 worker）。
- */
-import { beforeEach, describe, expect, it, vi } from "vitest";
-
-import { Budget } from "../models/budget.ts";
-import type { RunSpec } from "../models/run-spec.ts";
-import type { LauncherDeps } from "../launcher.ts";
-import type { LintResult } from "../script-lint.ts";
-import type { WorkflowRun } from "../models/workflow-run.ts";
-import type { WorkflowScript } from "../models/workflow-script.ts";
-
-// ── module mock：lifecycle.runWorkflow 由各 test 配置 ──────────────────
-
-vi.mock("../lifecycle.ts", () => ({
-  runWorkflow: vi.fn(),
-  abortRun: vi.fn(async () => {}),
-  scheduleTimeBudget: vi.fn(() => undefined),
-}));
-
-// import 在 vi.mock 之后（hoisting 保证拿到 mock 版本）。runWorkflow 从被 mock 的
-// lifecycle 模块导入，与 launcher.ts 内部引用的是同一 mock 实例。
-import { runWorkflow } from "../lifecycle.ts";
-import { ArgsValidationError } from "../args-validator.ts";
-import { executeNestedWorkflow } from "../launcher.ts";
-
-const MOCK_RUN_ID = "wf-test-child";
-
-// ── helpers ──────────────────────────────────────────────────
-
-/** 构造 mock WorkflowScript（validate / toExecutable 可控）。 */
-function makeScript(opts: { valid?: boolean; lintErrorMsg?: string } = {}): WorkflowScript {
-  const valid = opts.valid ?? true;
-  return {
-    name: "child-wf",
-    path: "/fake/child-wf.js",
-    meta: { name: "child-wf", description: "child workflow", phases: [] },
-    toExecutable: () => "const meta = {}; execute() {}",
-    validate: (): LintResult => ({
-      valid,
-      findings: valid
-        ? []
-        : [
-            {
-              severity: "error",
-              line: 3,
-              message: opts.lintErrorMsg ?? "lint boom",
-              suggestion: "fix it",
-            },
-          ],
-    }),
-  } as unknown as WorkflowScript;
-}
-
-/**
- * 构造 mock parent WorkflowRun。
- *
- * parentBudget 用真实 Budget 实例（remaining() + 可写 usedTokens/usedCost）。
- * controller 提供 AbortSignal（默认未 abort）。
- */
-function makeParentRun(opts: {
-  scriptName?: string;
-  parentWorkflowChain?: readonly string[];
-  budget?: Budget;
-  aborted?: boolean;
-} = {}): WorkflowRun {
-  const controller = new AbortController();
-  if (opts.aborted) controller.abort();
-  const spec = {
-    scriptName: opts.scriptName ?? "parent-wf",
-    parentWorkflowChain: opts.parentWorkflowChain,
-  };
-  return {
-    spec,
-    state: { budget: opts.budget ?? new Budget({ maxTokens: 10000 }) },
-    runtime: { controller },
-  } as unknown as WorkflowRun;
-}
-
-/**
- * 构造 mock child WorkflowRun（done 终态，pollRunToResult 首轮命中）。
- *
- * childBudget 用普通对象（仅需 usedTokens/usedCost 供 budget 同步读取）。
- */
-function makeDoneChildRun(opts: {
-  reason?: "completed" | "failed" | "aborted";
-  scriptResult?: unknown;
-  error?: string;
-  usedTokens?: number;
-  usedCost?: number;
-}): WorkflowRun {
-  const reason = opts.reason ?? "completed";
-  return {
-    runId: MOCK_RUN_ID,
-    spec: { scriptName: "child-wf" },
-    state: {
-      status: "done",
-      reason,
-      scriptResult: opts.scriptResult,
-      error: opts.error,
-      budget: { usedTokens: opts.usedTokens ?? 0, usedCost: opts.usedCost ?? 0 },
-    },
-  } as unknown as WorkflowRun;
-}
-
-/** 构造 LauncherDeps mock：registry + runs（Map）+ 占位 port。 */
-function makeDeps(opts: {
-  script?: WorkflowScript;
-  childRun?: WorkflowRun;
-  registry?: { getPath: ReturnType<typeof vi.fn> };
-} = {}): LauncherDeps {
-  const runs = new Map<string, WorkflowRun>();
-  if (opts.childRun) runs.set(MOCK_RUN_ID, opts.childRun);
-  const registry = opts.registry ?? {
-    getPath: vi.fn(async () => opts.script),
-  };
-  return {
-    registry,
-    runs,
-    store: { save: vi.fn(async () => {}), loadAll: vi.fn(async () => []) },
-    workerHost: { start: vi.fn(() => ({ postMessage: vi.fn() })) },
-    runner: { run: vi.fn(async () => ({})) },
-    log: vi.fn(),
-    eventBus: { emit: vi.fn() },
-  } as unknown as LauncherDeps;
-}
-
-/** 配置 runWorkflow mock：把 childRun 注入 deps.runs 并返回 MOCK_RUN_ID。 */
-function setupRunWorkflow(childRun: WorkflowRun): void {
-  vi.mocked(runWorkflow).mockImplementation(async (_spec, deps) => {
-    deps.runs.set(MOCK_RUN_ID, childRun);
-    return MOCK_RUN_ID;
-  });
-}
-
-beforeEach(() => {
-  vi.clearAllMocks();
-});
-
-// ── tests ────────────────────────────────────────────────────
-
-describe("executeNestedWorkflow", () => {
-  it("returns error result when workflow not found", async () => {
-    const parent = makeParentRun();
-    const signal = parent.runtime!.controller.signal;
-    const addSpy = vi.spyOn(signal, "addEventListener");
-    const removeSpy = vi.spyOn(signal, "removeEventListener");
-    const deps = makeDeps({ script: undefined });
-
-    const result = await executeNestedWorkflow("missing", {}, parent, deps);
-
-    expect(result.error).toBe("Workflow 'missing' not found");
-    expect(result.content).toBe("");
-    expect(runWorkflow).not.toHaveBeenCalled();
-    // E8：早返回也走 finally——Step 2 注册的 listener 被移除（原实现泄漏）
-    expect(addSpy).toHaveBeenCalledTimes(1);
-    expect(removeSpy).toHaveBeenCalledTimes(1);
-  });
-
-  it("returns error result on lint failure", async () => {
-    const parent = makeParentRun();
-    const deps = makeDeps({ script: makeScript({ valid: false, lintErrorMsg: "no entry point" }) });
-
-    const result = await executeNestedWorkflow("child-wf", {}, parent, deps);
-
-    expect(result.error).toContain("has lint errors");
-    expect(result.error).toContain("no entry point");
-    expect(result.content).toBe("");
-    expect(runWorkflow).not.toHaveBeenCalled();
-  });
-
-  it("TC11: chokepoint 校验失败 → {error} + parentSignal listener 不泄漏（E8）", async () => {
-    // 模块级 mock lifecycle：runWorkflow reject ArgsValidationError（真实实例——
-    // launcher.ts 未被 mock，instanceof 检查命中同一 class）。
-    vi.mocked(runWorkflow).mockRejectedValueOnce(
-      new ArgsValidationError(
-        "child-wf",
-        "Invalid args for workflow 'child-wf': 1 error(s)\n- /target: is required\nRead the workflow script file (location from <available_workflows>) for the parameter schema and usage.",
-      ),
-    );
-    const parent = makeParentRun();
-    const signal = parent.runtime!.controller.signal;
-    const addSpy = vi.spyOn(signal, "addEventListener");
-    const removeSpy = vi.spyOn(signal, "removeEventListener");
-    const deps = makeDeps({ script: makeScript() });
-
-    const result = await executeNestedWorkflow("child-wf", {}, parent, deps);
-
-    expect(result.content).toBe("");
-    expect(result.error).toContain("Invalid args for workflow 'child-wf'");
-    // Step 2 注册 1 次 + finally 移除 1 次 → 平衡即无泄漏（E8 修复点）
-    expect(addSpy).toHaveBeenCalledTimes(1);
-    expect(removeSpy).toHaveBeenCalledTimes(1);
-  });
-
-  it("detects circular call chain", async () => {
-    // parent chain ["a"], parent scriptName "b", target name "a" → a→b→a 循环
-    const parent = makeParentRun({
-      scriptName: "b",
-      parentWorkflowChain: ["a"],
-    });
-    const deps = makeDeps({ script: makeScript() });
-
-    const result = await executeNestedWorkflow("a", {}, parent, deps);
-
-    expect(result.error).toContain("Circular workflow call detected");
-    expect(result.error).toContain("a → b → a");
-    expect(result.content).toBe("");
-    expect(runWorkflow).not.toHaveBeenCalled();
-  });
-
-  it("executes child workflow and returns result on success", async () => {
-    const parent = makeParentRun();
-    const childRun = makeDoneChildRun({
-      reason: "completed",
-      scriptResult: { summary: "done" },
-    });
-    const deps = makeDeps({ script: makeScript(), childRun });
-    setupRunWorkflow(childRun);
-
-    const result = await executeNestedWorkflow("child-wf", { k: 1 }, parent, deps);
-
-    // content = JSON.stringify(scriptResult)；parsedOutput 原样回传对象
-    expect(result.error).toBeUndefined();
-    expect(result.content).toBe(JSON.stringify({ summary: "done" }));
-    expect(result.parsedOutput).toEqual({ summary: "done" });
-    expect(runWorkflow).toHaveBeenCalledTimes(1);
-  });
-
-  it("shares parent budget reference with child run (no sync-back)", async () => {
-    const parentBudget = new Budget({ maxTokens: 10000 });
-    parentBudget.usedTokens = 100;
-    const parent = makeParentRun({ budget: parentBudget });
-    const childRun = makeDoneChildRun({
-      reason: "completed",
-      scriptResult: "ok",
-    });
-    const deps = makeDeps({ script: makeScript(), childRun });
-
-    // 捕获传给 runWorkflow 的 spec——验证 budgetRef 共享父 Budget 引用
-    let capturedSpec: RunSpec | undefined;
-    vi.mocked(runWorkflow).mockImplementation(async (spec, d) => {
-      capturedSpec = spec;
-      d.runs.set(MOCK_RUN_ID, childRun);
-      return MOCK_RUN_ID;
-    });
-
-    await executeNestedWorkflow("child-wf", {}, parent, deps);
-
-    // 子 run 直接复用父 Budget 引用（budgetRef），而非独立 Budget + sync-back
-    expect(capturedSpec?.budgetRef).toBe(parentBudget);
-    expect(capturedSpec?.budgetTokens).toBeUndefined();
-    // 无 sync-back：parent budget 不被 launcher 直接修改（mock 未真实 consume）
-    expect(parent.state.budget.usedTokens).toBe(100);
-  });
-
-  it("returns error result when child workflow fails", async () => {
-    const parent = makeParentRun();
-    const childRun = makeDoneChildRun({
-      reason: "failed",
-      error: "agent exploded",
-    });
-    const deps = makeDeps({ script: makeScript(), childRun });
-    setupRunWorkflow(childRun);
-
-    const result = await executeNestedWorkflow("child-wf", {}, parent, deps);
-
-    expect(result.content).toBe("");
-    expect(result.error).toBe("agent exploded");
-  });
-});

package/src/orchestration/__tests__/lifecycle-runid-injection.test.ts

@@ -1,96 +0,0 @@
-/**
- * rfl 仪表 T2（tier-1 §7.1）：引擎注入稳定 _runId。
- *
- *   A3 runWorkflow 在 validateRunArgs 后向 spec.args 注入 _runId（值 = 返回的
- *      runId）——runAndWait 与 executeNestedWorkflow 两个 args 入口共用的单一
- *      choke point（lifecycle.ts runWorkflow）。
- *   A4 rebuildRuntime 复用 run.spec.args 同一对象，_runId 跨 worker rebuild 不
- *      漂移（修复「rebuild 回退 run-<Date.now()> 导致 run 碎裂」）。
- */
-import { describe, expect, it, vi } from "vitest";
-
-import { rebuildRuntime } from "../error-recovery.ts";
-import { runWorkflow } from "../lifecycle.ts";
-import type { RunSpec } from "../models/run-spec.ts";
-import type { LifecycleDeps } from "../models/ports.ts";
-
-function makeSpec(args: Record<string, unknown> = {}): RunSpec {
-  return {
-    scriptSource: "module.exports = { execute: async () => 'ok' };",
-    args,
-    scriptName: "test-wf",
-    scriptPath: "/fake/test.js",
-  };
-}
-
-/** LifecycleDeps mock：workerHost.start 可观察（记录每次调用收到的 args 引用）。 */
-function makeRecordingDeps(): LifecycleDeps & {
-  startCalls: Array<{ spec: RunSpec; args: Record<string, unknown> }>;
-} {
-  const startCalls: Array<{ spec: RunSpec; args: Record<string, unknown> }> = [];
-  const deps = {
-    store: { save: vi.fn(async () => {}), loadAll: vi.fn(async () => []) },
-    workerHost: {
-      start: vi.fn((spec: RunSpec, args: Record<string, unknown>) => {
-        startCalls.push({ spec, args });
-        return { postMessage: vi.fn(), terminate: vi.fn(async () => {}) };
-      }),
-    },
-    runner: { run: vi.fn(async () => ({})) },
-    runs: new Map(),
-    eventBus: { emit: vi.fn() },
-    onRunDone: vi.fn(),
-    log: vi.fn(),
-  } as unknown as LifecycleDeps;
-  return Object.assign(deps, { startCalls });
-}
-
-describe("A3 runWorkflow 注入 _runId（tier-1 §7.1）", () => {
-  it("A3 runWorkflow 后 spec.args._runId === 返回的 runId（字符串），且 workerHost.start 收到同一值", async () => {
-    const deps = makeRecordingDeps();
-    const spec = makeSpec({ targetType: "file", target: "/tmp/x" });
-    const runId = await runWorkflow(spec, deps);
-    expect(runId).toBeTruthy();
-    expect(spec.args._runId).toBe(runId);
-    expect(typeof spec.args._runId).toBe("string");
-    expect(deps.startCalls.length).toBe(1);
-    expect(deps.startCalls[0].args._runId).toBe(runId);
-  });
-
-  it("A3 引擎注入覆盖用户预传的 _runId（非公开参数，引擎值权威）", async () => {
-    const deps = makeRecordingDeps();
-    const spec = makeSpec({ _runId: "user-supplied" });
-    const runId = await runWorkflow(spec, deps);
-    expect(runId).not.toBe("user-supplied");
-    expect(spec.args._runId).toBe(runId);
-  });
-});
-
-describe("A4 rebuild 后 _runId 稳定（tier-1 §7.1）", () => {
-  it("A4 rebuildRuntime 第二次 workerHost.start 收到的 args._runId 非 undefined 且与首启一致（同一 args 对象）", async () => {
-    const deps = makeRecordingDeps();
-    const spec = makeSpec({ targetType: "file" });
-    const runId = await runWorkflow(spec, deps);
-    expect(deps.startCalls.length).toBe(1);
-
-    const run = deps.runs.get(runId);
-    expect(run).toBeTruthy();
-    expect(run.state.status).toBe("running");
-
-    // 触发 rebuild（对齐 error-recovery handleWorkerError 的恢复路径）
-    rebuildRuntime(run, deps, {
-      onMessage: vi.fn(),
-      onError: vi.fn(),
-      onExit: vi.fn(),
-    });
-
-    expect(deps.startCalls.length).toBe(2);
-    const first = deps.startCalls[0].args;
-    const second = deps.startCalls[1].args;
-    expect(second._runId).not.toBeUndefined();
-    expect(second._runId).toBe(first._runId);
-    expect(second._runId).toBe(runId);
-    // 同一对象引用（复用而非拷贝）——这是跨 rebuild 稳定的结构保证
-    expect(second).toBe(first);
-  });
-});