@zhushanwen/pi-subagent-workflow 5.0.2 → 7.0.0

package/src/orchestration/__tests__/review-fix-loop-e2e.test.ts

@@ -19,7 +19,7 @@
  * 已知限制：parallel 的 review 调用顺序不保证——剧本不依赖具体 agent 顺序
  * （E2E-2 只断言调用总数，R1 中先到者 dirty 后到者 clean 均可）。
  */
-import { existsSync, mkdtempSync, readdirSync, readFileSync, rmSync } from "node:fs";
+import { existsSync, mkdtempSync, readdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { dirname, join } from "node:path";
 import { fileURLToPath } from "node:url";
@@ -27,6 +27,8 @@ import { fileURLToPath } from "node:url";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
 import { JsonlRunStore } from "../jsonl-run-store.ts";
+import { parseResourceMeta } from "../../shared/meta-parser.ts";
+import { normalizeRef } from "../../shared/agent-ref.ts";
 import { type LauncherDeps, runAndWait } from "../launcher.ts";
 import type { LifecycleDeps } from "../models/ports.ts";
 import type { AgentRunner } from "../models/ports.ts";
@@ -41,6 +43,16 @@ import { WorkerHostImpl } from "../worker-host.ts";
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const WORKFLOWS_DIR = join(__dirname, "..", "..", "..", "workflows");
+const wf = (name: string): string => join(WORKFLOWS_DIR, name + ".js");
+
+// agentMd 创建真实临时 fixture .md（e2e 自包含，不依赖包内 agents/ 清单）。
+// R3 启动期 stat 校验要求路径真实存在；fixtureDir 在 beforeEach 创建。
+let fixtureDir: string;
+const agentMd = (name: string): string => {
+  const p = join(fixtureDir, name + ".md");
+  writeFileSync(p, `---\nname: ${name}\ndescription: "${name} fixture"\n---\nbody`, "utf-8");
+  return p;
+};
 
 let sessionDir: string;
 let createdStores: JsonlRunStore[] = [];
@@ -197,24 +209,11 @@ function makeScenarioRunner(scenario: Scenario) {
 // ── registry（与 workflows-e2e.test.ts 同模式：读文件构造 WorkflowScript） ──
 
 function extractMeta(source: string, fallbackName: string): WorkflowMeta {
-  const metaPattern = /(?:export\s+)?const\s+meta\s*=\s*(\{[^]*?\});?\s*$/m;
-  const match = metaPattern.exec(source);
-  if (match) {
-    try {
-      const fn = new Function(`return (${match[1]});`);
-      const obj = fn();
-      if (obj && typeof obj === "object" && typeof obj.name === "string") {
-        return {
-          name: obj.name,
-          description: typeof obj.description === "string" ? obj.description : "",
-          phases: Array.isArray(obj.phases) ? obj.phases : [],
-        };
-      }
-    } catch {
-      // 提取失败 → fallback name（非测试关注点）
-    }
-  }
-  return { name: fallbackName, description: "", phases: [] };
+  // m2 exec-review MINOR-1：旧 const meta regex + new Function 随 m2 迁移已失效，
+  // 改调 IF1 parseResourceMeta（与 workflows-e2e.test 一致）。
+  const meta = parseResourceMeta(source, "workflow");
+  if (meta && meta.kind === "workflow") return meta;
+  return { kind: "workflow", name: fallbackName, description: "", phases: [] };
 }
 
 function loadWorkflowsFromDir(dir: string): Map<string, WorkflowScript> {
@@ -244,6 +243,29 @@ function loadWorkflowsFromDir(dir: string): Map<string, WorkflowScript> {
 function makeRegistry(scripts: Map<string, WorkflowScript>): WorkflowScriptRegistry {
   return {
     get: async (name: string) => scripts.get(name),
+    // S2：按路径加载（任意路径 .js）——路径未预扫则直接读文件
+    getPath: async (ref: string) => {
+      const normalized = normalizeRef(ref, ".js");
+      if (normalized === null) return undefined;
+      for (const script of scripts.values()) {
+        if (script.path === normalized) return script;
+      }
+      try {
+        const sourceCode = readFileSync(normalized, "utf-8");
+        const stem = basename(normalized, ".js");
+        const meta = extractMeta(sourceCode, stem);
+        return new WorkflowScript({
+          name: meta.name,
+          source: "saved",
+          path: normalized,
+          sourceCode,
+          meta,
+          available: true,
+        });
+      } catch {
+        return undefined;
+      }
+    },
     loadAll: async () => Array.from(scripts.values()),
     invalidate: () => {},
   };
@@ -265,16 +287,19 @@ function makeDeps(runner: AgentRunner): LauncherDeps {
 
 beforeEach(() => {
   sessionDir = mkdtempSync(join(tmpdir(), "rfl-e2e-"));
+  fixtureDir = mkdtempSync(join(tmpdir(), "rfl-e2e-agents-"));
   createdStores = [];
 });
 
 afterEach(() => {
   try {
     rmSync(sessionDir, { recursive: true, force: true });
+    rmSync(fixtureDir, { recursive: true, force: true });
   } catch {
     // 临时目录清理失败不影响测试结论
   }
   sessionDir = "";
+  fixtureDir = "";
   createdStores = [];
   vi.restoreAllMocks();
 });
@@ -291,7 +316,7 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       fix: () => ({}),
     });
     const deps = makeDeps(runner);
-    const result = await runAndWait("chain", { task: "x" }, deps, undefined, RUN_TIMEOUT_MS);
+    const result = await runAndWait(wf("chain"), { task: "x" }, deps, undefined, RUN_TIMEOUT_MS);
     expect(result.reason).toBe("completed");
   });
   it(
@@ -326,8 +351,8 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       const deps = makeDeps(runner);
 
       const result = await runAndWait(
-        "review-fix-loop",
-        { targetType: "file", target: "README.md", agents: "reviewer", _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "file", target: "README.md", agents: agentMd("reviewer"), _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
@@ -400,8 +425,8 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       const deps = makeDeps(runner);
 
       const result = await runAndWait(
-        "review-fix-loop",
-        { targetType: "file", target: "README.md", agents: "reviewer,doc-reviewer", fixAgent: "reviewer", _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "file", target: "README.md", agents: agentMd("reviewer") + "," + agentMd("doc-reviewer"), fixAgent: agentMd("reviewer"), _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
@@ -418,13 +443,12 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       expect(reviewCalls.length).toBe(3);
       expect(kinds.filter((k) => k === "fix").length).toBe(1);
       expect(kinds.filter((k) => k === "aggregate").length).toBe(1);
-      // m5：fixAgent 派发验证——fix 调用带 agent: "reviewer"（review 调用只记录不断言：
-      // 内置名走 def.name，自定义 .md agent 为 undefined）
+      // S4：fixAgent 派发验证——fix 调用带 agentRef 路径（<available_subagents> location 语义）
       const fixIdx = kinds.indexOf("fix");
-      expect(agents[fixIdx]).toBe("reviewer");
+      expect(agents[fixIdx]).toBe(agentMd("reviewer"));
       // M3 直接证据：doc-reviewer（schema-only，report_file=""）报告经 report_content
-      // 落盘到 <runDir>/batch-1/round-1/doc-reviewer.md（def.report 文件名 = 内置名剥离
-      // review- 前缀，resolveAgentDefs 默认分支）。修复前 normalizeReviewResult 丢弃
+      // 落盘到 <runDir>/batch-1/round-1/doc-reviewer.md（def.report 文件名 = 路径 basename，
+      // resolveAgentDefs 路径解析）。修复前 normalizeReviewResult 丢弃
       // report_content → 落盘内容为空文件，本断言失败。
       const docReportPath = join(outcome.runDir, "batch-1", "round-1", "doc-reviewer.md");
       expect(existsSync(docReportPath)).toBe(true);
@@ -454,8 +478,8 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       const deps = makeDeps(runner);
 
       const result = await runAndWait(
-        "review-fix-loop",
-        { targetType: "file", target: "README.md", agents: "reviewer", _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "file", target: "README.md", agents: agentMd("reviewer"), _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
@@ -524,8 +548,8 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       const deps = makeDeps(runner);
 
       const result = await runAndWait(
-        "review-fix-loop",
-        { targetType: "file", target: "README.md", agents: "reviewer", maxRounds: 2, _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "file", target: "README.md", agents: agentMd("reviewer"), maxRounds: 2, _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
@@ -587,8 +611,8 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       const deps = makeDeps(runner);
 
       const result = await runAndWait(
-        "review-fix-loop",
-        { targetType: "file", target: "README.md", agents: "reviewer,doc-reviewer", recheckAfterFix: true, _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "file", target: "README.md", agents: agentMd("reviewer") + "," + agentMd("doc-reviewer"), recheckAfterFix: true, _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
@@ -656,8 +680,8 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       const deps = makeDeps(runner);
 
       const result = await runAndWait(
-        "review-fix-loop",
-        { targetType: "file", target: "README.md", agents: "doc-reviewer", _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "file", target: "README.md", agents: agentMd("doc-reviewer"), _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
@@ -732,8 +756,8 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       const deps = makeDeps(runner);
 
       const result = await runAndWait(
-        "review-fix-loop",
-        { targetType: "file", target: "README.md", agents: "reviewer", maxRounds: 4, _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "file", target: "README.md", agents: agentMd("reviewer"), maxRounds: 4, _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
@@ -765,8 +789,8 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
       const deps = makeDeps(runner);
 
       const result = await runAndWait(
-        "review-fix-loop",
-        { targetType: "file", target: "README.md", agents: "reviewer", batchl: "fallow-scan", _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "file", target: "README.md", agents: agentMd("reviewer"), batchl: "fallow-scan", _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
@@ -790,28 +814,69 @@ describe("review-fix-loop E2E（真实 worker + 场景化 mock runner）", () =>
         fix: () => ({ fixed_count: 0, fixes: [], deferred: [] }),
       }));
 
-      // targetType 非法枚举
+      // targetType 非法枚举（m3 TC14：chokepoint 先拦 → invalid_args + ajv 文案 + info 指引）
       const r1 = await runAndWait(
-        "review-fix-loop",
-        { targetType: "nope", target: "README.md", agents: "reviewer", _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "nope", target: "README.md", agents: agentMd("reviewer"), _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
       );
-      expect(r1.reason).toBe("failed");
-      expect(r1.error).toContain("targetType 必填且必须是枚举之一");
+      expect(r1.reason).toBe("invalid_args");
+      expect(r1.error).toContain("Invalid args for workflow 'review-fix-loop'");
+      expect(r1.error).toContain("targetType");
+      expect(r1.error).toContain("Read the workflow script file");
 
-      // target 空串（trim 后为空 → fail）
+      // target 空串（m3 required 空串复查先拦 → invalid_args；脚本 !target 成不可达死代码）
       const r2 = await runAndWait(
-        "review-fix-loop",
-        { targetType: "file", target: "   ", agents: "reviewer", _runId: RUN_ID() },
+        wf("review-fix-loop"),
+        { targetType: "file", target: "   ", agents: agentMd("reviewer"), _runId: RUN_ID() },
         deps,
         undefined,
         RUN_TIMEOUT_MS,
       );
-      expect(r2.reason).toBe("failed");
-      expect(r2.error).toContain("target 必填");
+      expect(r2.reason).toBe("invalid_args");
+      // schema 驱动（minLength:1 + pattern '\\S'）：chokepoint 不发明约束
+      expect(r2.error).toContain("target");
+      expect(r2.error).toContain("Read the workflow script file");
     },
     RUN_TIMEOUT_MS,
   );
 });
+
+describe("startup fail-fast (ADR-0003 D6)", () => {
+  const emptyScenario = {
+    review: [() => ({ issues: [], must_fix: [], stuck: false })],
+    aggregate: () => ({ issues: [], must_fix: [], stuck: false }),
+    fix: () => ({ fixed_count: 0, fixes: [], deferred: [] }),
+  };
+
+  it("TC1: batchN 不存在路径 → 启动期 fail-fast，未调 agent", async () => {
+    const runner = makeScenarioRunner(emptyScenario);
+    const deps = makeDeps(runner);
+    const result = await runAndWait(
+      wf("review-fix-loop"),
+      { targetType: "file", target: "README.md", agents: "/nonexistent/missing.md", _runId: RUN_ID() },
+      deps, undefined, RUN_TIMEOUT_MS,
+    );
+    expect(result.reason).not.toBe("completed");
+    expect(String(result.error ?? "")).toContain("Agent file not found");
+    expect(String(result.error ?? "")).toContain("/nonexistent/missing.md");
+    // fail-fast 在 round 前：agent mock 未被调用
+    expect(runner.stats().kinds.length).toBe(0);
+  }, RUN_TIMEOUT_MS);
+
+  it("TC2: fixAgent 不存在路径 → 启动期 fail-fast", async () => {
+    const runner = makeScenarioRunner(emptyScenario);
+    const deps = makeDeps(runner);
+    const result = await runAndWait(
+      wf("review-fix-loop"),
+      { targetType: "file", target: "README.md", agents: agentMd("reviewer"), fixAgent: "/nonexistent/fix.md", _runId: RUN_ID() },
+      deps, undefined, RUN_TIMEOUT_MS,
+    );
+    expect(result.reason).not.toBe("completed");
+    expect(String(result.error ?? "")).toContain("Agent file not found");
+    expect(String(result.error ?? "")).toContain("/nonexistent/fix.md");
+    expect(runner.stats().kinds.length).toBe(0);
+  }, RUN_TIMEOUT_MS);
+});

package/src/orchestration/__tests__/script-lint.test.ts

@@ -12,7 +12,13 @@
  */
 import { describe, it, expect } from "vitest";
 
-import { lintScript, type LintFinding } from "../script-lint.ts";
+import { readFileSync } from "node:fs";
+import { join } from "node:path";
+
+import { lintAgentMeta, lintScript } from "../script-lint.ts";
+import { parseResourceMeta } from "../../shared/meta-parser.ts";
+
+const WORKFLOWS_DIR = join(__dirname, "../../../workflows");
 
 /** 取所有 error 级 finding。 */
 function errors(findings: LintFinding[]): LintFinding[] {
@@ -663,3 +669,163 @@ describe("声明 phases 与 phase() 调用一致性 — warning", () => {
     expect(warnings(result.findings)).toHaveLength(0);
   });
 });
+
+// ── m4 W1-W5：meta 质量（SSOT lint） ─────────────────────────
+
+describe("m4 W1-W5: meta 质量 lint", () => {
+  const wf = (meta: string, body = 'await agent({ prompt: "x" });') =>
+    `/* @pi-meta\n${meta}\n*/\n${body}`;
+
+  it("TC5 W1: 已声明参数名 :/= 形态 → error；非参数 prose 不误报", () => {
+    // 参数名集合 = properties keys + patternProperties word 前缀
+    const bad = lintScript(
+      wf(
+        'name: w\ndescription: "targetType: git-diff 用法"\nphases: [a]\nparameters:\n  type: object\n  properties:\n    targetType: { type: string }\n  required: [targetType]',
+      ),
+    );
+    expect(errors(bad.findings).some((f) => f.message.includes("targetType"))).toBe(true);
+
+    // note:/a=b 非参数 → 不误报（评审探针实测形态匹配误报面）
+    const good = lintScript(
+      wf(
+        'name: w\ndescription: "note: fix agent 与 batchN 互斥，见 a=b 说明"\nphases: [a]\nparameters:\n  type: object\n  properties:\n    targetType: { type: string }\n  required: [targetType]',
+      ),
+    );
+    expect(errors(good.findings).length).toBe(0);
+  });
+
+  it("TC5b W1: patternProperties word 前缀参数名（batch）也检查", () => {
+    const bad = lintScript(
+      wf(
+        'name: w\ndescription: "batch=high 模式"\nphases: [a]\nparameters:\n  type: object\n  patternProperties:\n    "^batch\\\\d+$": { type: string }',
+      ),
+    );
+    expect(errors(bad.findings).some((f) => f.message.includes("batch"))).toBe(true);
+  });
+
+  it("TC6 W2: >200 字符 → error；200 边界通过", () => {
+    const over = lintScript(
+      wf('name: w\ndescription: "' + "x".repeat(201) + '"\nphases: [a]'),
+    );
+    expect(errors(over.findings).some((f) => f.message.includes("200"))).toBe(true);
+    const at = lintScript(
+      wf('name: w\ndescription: "' + "x".repeat(200) + '"\nphases: [a]'),
+    );
+    expect(errors(at.findings).length).toBe(0);
+  });
+
+  it("TC7 W3: 括号内句号/缩写剥离后不报；括号外多句报", () => {
+    // 括号内 e.g. + 句号 → 剥离后单句无 finding
+    const paren = lintScript(
+      wf('name: w\ndescription: "多批串行循环（批内并行 review，e.g. 每批 3 视角）"\nphases: [a]'),
+    );
+    expect(errors(paren.findings).length).toBe(0);
+    // 括号外两个句号 → error
+    const multi = lintScript(
+      wf('name: w\ndescription: "第一句。第二句"\nphases: [a]'),
+    );
+    expect(errors(multi.findings).some((f) => f.message.includes("单句"))).toBe(true);
+  });
+
+  it("TC8 W4: lintAgentMeta positive 四形态", () => {
+    const meta = (examples: unknown) =>
+      ({ kind: "agent", name: "a", description: "d", examples }) as never;
+    // 正反各一 → 无 finding
+    expect(
+      lintAgentMeta(
+        meta([{ match: "review 代码", action: "reviewer", positive: true }, { match: "天气", action: "x", positive: false }]),
+      ).length,
+    ).toBe(0);
+    // 全正向 → error
+    expect(
+      lintAgentMeta(
+        meta([{ match: "a", action: "x", positive: true }, { match: "b", action: "y", positive: true }]),
+      ).length,
+    ).toBe(1);
+    // [] → error
+    expect(lintAgentMeta(meta([])).length).toBe(1);
+    // 缺失 → 无 finding（WQ1：未迁移 agent 不报错）
+    expect(lintAgentMeta(meta(undefined)).length).toBe(0);
+  });
+
+  it("TC8a: W4 EXAMPLES_MAX 边界——3/4 条合法，5 条 → finding", () => {
+    const meta = (examples: unknown) =>
+      ({ kind: "agent", name: "a", description: "d", examples }) as never;
+    const mk = (n: number) =>
+      Array.from({ length: n }, (_, i) => ({
+        match: `m${i}`,
+        action: "x",
+        positive: i % 2 === 0,
+      }));
+    expect(lintAgentMeta(meta(mk(3))).length).toBe(0); // 3 条合法
+    expect(lintAgentMeta(meta(mk(4))).length).toBe(0); // 4 条合法（上限）
+    expect(lintAgentMeta(meta(mk(5))).length).toBe(1); // 5 条超上限
+  });
+
+  it("TC8b: W4 EXAMPLES_MAX——examples 超上限（5 条）→ finding", () => {
+    const meta = (examples: unknown) =>
+      ({ kind: "agent", name: "a", description: "d", examples }) as never;
+    const five = [
+      { match: "a", action: "x", positive: true },
+      { match: "b", action: "x", positive: false },
+      { match: "c", action: "x", positive: true },
+      { match: "d", action: "x", positive: false },
+      { match: "e", action: "x", positive: true },
+    ];
+    const findings = lintAgentMeta(meta(five));
+    expect(findings.length).toBe(1);
+    expect(findings[0]!.message).toContain("上限");
+  });
+
+  it("TC9: 5 内置真实 workflow 过 W1-W5（lintScript valid 无 meta 质量 error）", () => {
+    const files = ["chain", "parallel", "scatter-gather", "map-reduce", "review-fix-loop"];
+    for (const f of files) {
+      const src = readFileSync(join(WORKFLOWS_DIR, `${f}.js`), "utf-8");
+      // F11：先断言 meta 真实解析成功——防 parse 失败时 W1-W3 整体跳过真空通过
+      const meta = parseResourceMeta(src, "workflow");
+      expect(meta, `${f} meta 解析`).not.toBeNull();
+      const result = lintScript(src);
+      const qualityErrors = errors(result.findings).filter((x) => x.message.includes("meta."));
+      expect(qualityErrors, `${f} meta 质量`).toEqual([]);
+    }
+  });
+
+  it("F2 回归: 参数名含未配对 [ 不崩溃（RegExp 注入）", () => {
+    const src = wf(
+      'name: w\ndescription: "x[ 参数说明"\nphases: [a]\nparameters:\n  type: object\n  properties:\n    "x[": { type: string }\n  required: ["x["]',
+    );
+    expect(() => lintScript(src)).not.toThrow();
+  });
+
+  it("F6 回归: 子串词缀不误报（task 不命中 subtask:）", () => {
+    const src = wf(
+      'name: w\ndescription: "subtask: 需要分解"\nphases: [a]\nparameters:\n  type: object\n  properties:\n    task: { type: string }\n  required: [task]',
+    );
+    const metaErrors = errors(lintScript(src).findings).filter((x) => x.message.includes("meta."));
+    expect(metaErrors).toEqual([]);
+  });
+
+  it("F6b 回归: 元字符参数名不误报（a.b 不命中 aXb:）", () => {
+    const src = wf(
+      'name: w\ndescription: "aXb: 任意字符"\nphases: [a]\nparameters:\n  type: object\n  properties:\n    "a.b": { type: string }\n  required: ["a.b"]',
+    );
+    const metaErrors = errors(lintScript(src).findings).filter((x) => x.message.includes("meta."));
+    expect(metaErrors).toEqual([]);
+  });
+
+  it("F7 回归: description 空串时 when/notFor 仍受检查", () => {
+    const src = wf(
+      'name: w\ndescription: ""\nwhen: "第一句。第二句"\nphases: [a]',
+    );
+    const metaErrors = errors(lintScript(src).findings).filter((x) => x.message.includes("meta."));
+    expect(metaErrors.length).toBeGreaterThan(0); // when 非单句被拦
+  });
+
+  it("F8 回归: 括号外 e.g. 缩写不误报", () => {
+    const src = wf(
+      'name: w\ndescription: "Run when user wants review, e.g. iterative fix loop"\nphases: [a]',
+    );
+    const metaErrors = errors(lintScript(src).findings).filter((x) => x.message.includes("meta."));
+    expect(metaErrors).toEqual([]);
+  });
+});

package/src/orchestration/__tests__/worker-host.test.ts

@@ -0,0 +1,120 @@
+/**
+ * WorkerHostImpl — workerData 映射测试。
+ *
+ * Option B（run-level model/thinkingLevel）的映射点在 WorkerHostImpl.start：
+ * RunSpec.model/thinkingLevel → workerData.model/thinkingLevel → worker 内
+ * $MODEL/$THINKING_LEVEL globals（worker-script-builder 注入）→ agent() fallback。
+ *
+ * 本测试 mock node:worker_threads.Worker，捕获构造 options.workerData，
+ * 直接断言映射（lifecycle.test.ts 的 workerHost.start 是 mock，看不到 workerData）。
+ */
+import { describe, expect, it, vi } from "vitest";
+
+const { workerMock } = vi.hoisted(() => ({
+  workerMock: vi.fn(),
+}));
+
+vi.mock("node:worker_threads", () => ({
+  Worker: workerMock,
+}));
+
+import { WorkerHostImpl } from "../worker-host.ts";
+import type { RunSpec } from "../models/run-spec.ts";
+import type { WorkerHandlers } from "../models/ports.ts";
+
+interface WorkerOptions {
+  eval?: boolean;
+  workerData?: Record<string, unknown>;
+}
+
+/** mock Worker 实例（WorkerHandle 依赖 on/postMessage/terminate）。 */
+function fakeWorkerInstance() {
+  return { on: vi.fn(), postMessage: vi.fn(), terminate: vi.fn() };
+}
+
+function makeSpec(overrides: Partial<RunSpec> = {}): RunSpec {
+  return {
+    scriptSource: "execute() {}",
+    args: { autoCommit: true },
+    scriptName: "test-wf",
+    scriptPath: "/fake/test.js",
+    description: "test desc",
+    ...overrides,
+  };
+}
+
+function makeHandlers(): WorkerHandlers {
+  return {
+    onMessage: vi.fn(),
+    onError: vi.fn(),
+    onExit: vi.fn(),
+  };
+}
+
+describe("WorkerHostImpl.start — workerData 映射", () => {
+  it("Option B: RunSpec.model/thinkingLevel 映射进 workerData（其余字段不破坏）", () => {
+    const spec = makeSpec({
+      model: "anthropic/claude-3.5-sonnet",
+      thinkingLevel: "high",
+      budgetTokens: 5000,
+    });
+    let captured: WorkerOptions | undefined;
+    workerMock.mockImplementation(function (
+      this: unknown,
+      _code: string,
+      options: WorkerOptions,
+    ) {
+      captured = options;
+      return fakeWorkerInstance();
+    });
+
+    new WorkerHostImpl().start(spec, spec.args, makeHandlers());
+
+    expect(workerMock).toHaveBeenCalledTimes(1);
+    expect(captured).toBeDefined();
+    const wd = captured!.workerData;
+    expect(wd).toBeDefined();
+    // Option B 核心：run-level override 经 workerData 进入 worker globals
+    expect(wd!.model).toBe("anthropic/claude-3.5-sonnet");
+    expect(wd!.thinkingLevel).toBe("high");
+    // workerData 契约其余字段（防未来重构破坏 worker 启动链路）
+    expect(wd!.scriptPath).toBe("/fake/test.js");
+    expect(wd!.args).toEqual({ autoCommit: true });
+    expect(wd!.meta).toEqual({ name: "test-wf", description: "test desc" });
+    expect(wd!.budget).toEqual({ maxTokens: 5000, usedTokens: 0, usedCost: 0 });
+    expect(captured!.eval).toBe(true);
+  });
+
+  it("model/thinkingLevel 未设：workerData 字段为 undefined（继承主 agent 语义，不污染）", () => {
+    let captured: WorkerOptions | undefined;
+    workerMock.mockImplementation(function (
+      this: unknown,
+      _code: string,
+      options: WorkerOptions,
+    ) {
+      captured = options;
+      return fakeWorkerInstance();
+    });
+
+    new WorkerHostImpl().start(makeSpec(), {}, makeHandlers());
+
+    expect(captured!.workerData!.model).toBeUndefined();
+    expect(captured!.workerData!.thinkingLevel).toBeUndefined();
+  });
+
+  it("handlers 绑定：message/error/exit 三类事件注册到 worker", () => {
+    const instance = fakeWorkerInstance();
+    workerMock.mockImplementation(function (this: unknown) {
+      return instance;
+    });
+
+    const handle = new WorkerHostImpl().start(makeSpec(), {}, makeHandlers());
+
+    expect(instance.on).toHaveBeenCalledTimes(3);
+    expect(instance.on).toHaveBeenCalledWith("message", expect.any(Function));
+    expect(instance.on).toHaveBeenCalledWith("error", expect.any(Function));
+    expect(instance.on).toHaveBeenCalledWith("exit", expect.any(Function));
+    // handle 持底层 worker（RunRuntime 直接访问 ref/href）
+    expect(handle.raw).toBe(instance);
+  });
+});