@zhushanwen/pi-subagent-workflow 5.0.2 → 7.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (77) hide show
  1. package/agents/{reviewer.md → code-reviewer.md} +20 -3
  2. package/agents/context-builder.md +5 -0
  3. package/agents/doc-reviewer.md +9 -2
  4. package/agents/explorer.md +5 -0
  5. package/agents/general-purpose.md +5 -0
  6. package/agents/oracle.md +20 -4
  7. package/agents/orchestrator.md +6 -1
  8. package/agents/planner.md +5 -0
  9. package/agents/researcher.md +5 -0
  10. package/agents/worker.md +5 -0
  11. package/package.json +6 -4
  12. package/src/execution/__tests__/agent-registry.test.ts +189 -119
  13. package/src/execution/__tests__/crash-recovery.test.ts +0 -1
  14. package/src/execution/__tests__/execute-options-mapper.test.ts +4 -4
  15. package/src/execution/__tests__/index-session-start.test.ts +0 -1
  16. package/src/execution/__tests__/model-resolver.test.ts +20 -0
  17. package/src/execution/__tests__/session-start-reaper.test.ts +0 -2
  18. package/src/execution/__tests__/subprocess-agent-runner.test.ts +1 -1
  19. package/src/execution/agent-registry.ts +92 -169
  20. package/src/execution/execute-options-mapper.ts +2 -2
  21. package/src/execution/model-config-service.ts +13 -34
  22. package/src/execution/model-resolver.ts +5 -3
  23. package/src/execution/subagent-service.ts +9 -6
  24. package/src/execution/subprocess-agent-runner.ts +3 -2
  25. package/src/index.ts +4 -25
  26. package/src/injectors/__tests__/subagent-list-injector.test.ts +266 -14
  27. package/src/injectors/__tests__/workflow-list-injector.test.ts +236 -32
  28. package/src/injectors/subagent-list-injector.ts +99 -48
  29. package/src/injectors/workflow-list-injector.ts +65 -50
  30. package/src/interface/__tests__/detectors.test.ts +100 -43
  31. package/src/interface/__tests__/subagent-tool-prompt.test.ts +8 -12
  32. package/src/interface/__tests__/tool-workflow-script-generate.test.ts +163 -0
  33. package/src/interface/__tests__/workflow-tool-prompt.test.ts +55 -9
  34. package/src/interface/subagent-tool.ts +7 -4
  35. package/src/interface/tool-workflow-script.ts +27 -10
  36. package/src/interface/tool-workflow.ts +174 -81
  37. package/src/orchestration/__tests__/args-validator.test.ts +143 -0
  38. package/src/orchestration/__tests__/config-loader.test.ts +124 -40
  39. package/src/orchestration/__tests__/launcher-nested-workflow.test.ts +33 -2
  40. package/src/orchestration/__tests__/lifecycle.test.ts +59 -2
  41. package/src/orchestration/__tests__/review-fix-loop-e2e.test.ts +116 -51
  42. package/src/orchestration/__tests__/script-lint.test.ts +167 -1
  43. package/src/orchestration/__tests__/worker-host.test.ts +120 -0
  44. package/src/orchestration/__tests__/worker-script-builder-runtime.test.ts +69 -0
  45. package/src/orchestration/__tests__/worker-script-builder.test.ts +51 -1
  46. package/src/orchestration/__tests__/workflow-nesting-e2e.test.ts +2 -2
  47. package/src/orchestration/__tests__/workflows-e2e.test.ts +177 -24
  48. package/src/orchestration/agent-opts-resolver.ts +51 -101
  49. package/src/orchestration/args-validator.ts +127 -0
  50. package/src/orchestration/config-loader.ts +63 -94
  51. package/src/orchestration/error-recovery.ts +6 -9
  52. package/src/orchestration/launcher.ts +77 -41
  53. package/src/orchestration/lifecycle.ts +7 -0
  54. package/src/orchestration/models/ports.ts +0 -14
  55. package/src/orchestration/models/run-spec.ts +24 -1
  56. package/src/orchestration/models/types.ts +15 -8
  57. package/src/orchestration/models/workflow-script-registry.ts +3 -0
  58. package/src/orchestration/models/workflow-script.ts +10 -14
  59. package/src/orchestration/script-lint.ts +159 -0
  60. package/src/orchestration/worker-host.ts +5 -0
  61. package/src/orchestration/worker-script-builder.ts +15 -4
  62. package/src/orchestration/workflow-script-registry-impl.ts +34 -29
  63. package/src/shared/__tests__/meta-parser.test.ts +304 -0
  64. package/src/shared/__tests__/resource-discovery.test.ts +167 -7
  65. package/src/shared/__tests__/resource-meta.test.ts +51 -0
  66. package/src/shared/agent-ref.ts +36 -0
  67. package/src/shared/meta-parser.ts +257 -0
  68. package/src/shared/resource-discovery.ts +88 -2
  69. package/src/shared/resource-meta.ts +60 -0
  70. package/workflows/README.md +2 -2
  71. package/workflows/_shared/agent-refs.cjs +40 -0
  72. package/workflows/chain.js +30 -6
  73. package/workflows/map-reduce.js +33 -5
  74. package/workflows/parallel.js +34 -7
  75. package/workflows/review-fix-loop-utils.cjs +23 -103
  76. package/workflows/review-fix-loop.js +121 -58
  77. package/workflows/scatter-gather.js +30 -6
@@ -0,0 +1,127 @@
1
+ // src/orchestration/args-validator.ts
2
+ //
3
+ // m3:参数校验单一 chokepoint(IF3 validateRunArgs + IF4 ArgsValidationError)。
4
+ // lifecycle.runWorkflow 首行调用——§5.3 fail-fast:参数错误在 worker 启动前返回,
5
+ // 带「read 脚本重看」指引。
6
+ //
7
+ // 设计决策(m3 design-review 探针实证):
8
+ // - ajv 选项钉死 { coerceTypes:true, strictSchema:false, allErrors:true, useDefaults:false }:
9
+ // coerceTypes 原地规范化弱 LLM 的字符串参数('false'→false、'10'→10,m2 MAJOR-1 闭环);
10
+ // strictSchema:false 容忍用户 workflow 的自定义关键字/format(默认 strict:true 会误判畸形);
11
+ // useDefaults:false 不注入 schema default(脚本 fallback 语义不变)。
12
+ // - 无缓存:ajv.compile 实测 0.006ms/次([P-compile]),v5 §6.5 的 Map 缓存被探针证据推翻。
13
+ // - null-scan + required 空串复查:coerceTypes 下 {target:null} 会被 coerce 成 "" 放行
14
+ // required(required 只查属性存在性)——null 视为缺失、必填字符串空串视为失败,
15
+ // 与 review-fix-loop 脚本的 !target 语义对齐,保住「启动前 fail-fast」承诺。
16
+
17
+ import Ajv from "ajv";
18
+
19
+ import type { RunSpec } from "./models/run-spec.ts";
20
+
21
+ /** 参数校验失败(§5.3)。三调用方各自 catch 并映射到返回类型。 */
22
+ export class ArgsValidationError extends Error {
23
+ readonly workflowName: string;
24
+ /** ajv 校验错误数组(畸形 schema 时为 undefined)。 */
25
+ readonly errors?: readonly unknown[];
26
+
27
+ constructor(workflowName: string, message: string, errors?: readonly unknown[]) {
28
+ super(message);
29
+ this.name = "ArgsValidationError";
30
+ this.workflowName = workflowName;
31
+ this.errors = errors;
32
+ }
33
+ }
34
+
35
+ const ajv = new Ajv({
36
+ coerceTypes: true,
37
+ strictSchema: false,
38
+ allErrors: true,
39
+ useDefaults: false,
40
+ });
41
+
42
+ /** §5.3 错误文案:workflow 名 + errors 摘要 + info 指引。 */
43
+ function formatMessage(name: string, errors: readonly unknown[]): string {
44
+ const lines = errors.map((e) => {
45
+ let path = "/";
46
+ let msg = "invalid";
47
+ if (e !== null && typeof e === "object") {
48
+ const err = e as Record<string, unknown>;
49
+ if (typeof err.instancePath === "string" && err.instancePath) path = err.instancePath;
50
+ if (typeof err.message === "string") msg = err.message;
51
+ }
52
+ return `- ${path}: ${msg}`;
53
+ });
54
+ return (
55
+ `Invalid args for workflow '${name}': ${errors.length} error(s)\n` +
56
+ `${lines.join("\n")}\n` +
57
+ `Read the workflow script file (location from <available_workflows>) for the parameter schema and usage.`
58
+ );
59
+ }
60
+
61
+ /**
62
+ * 校验 spec.parameters(JSON Schema draft-07)对 spec.args 的约束。
63
+ *
64
+ * - spec.parameters === undefined → 跳过(安全退化:漏拷 parameters 退化是「不校验」非「校验错」)
65
+ * - coerceTypes 原地规范化 spec.args(worker 启动 + pause/resume 重建共用同一对象,
66
+ * run.spec === spec,保证恢复路径参数一致)
67
+ * - 失败 throw ArgsValidationError(非原始 ajv 错误)
68
+ *
69
+ * @throws ArgsValidationError 参数不合法或 schema 无效
70
+ */
71
+ export function validateRunArgs(spec: RunSpec): void {
72
+ const { parameters, args, scriptName } = spec;
73
+ if (parameters === undefined) return;
74
+
75
+ if (parameters === null || typeof parameters !== "object" || Array.isArray(parameters)) {
76
+ throw new ArgsValidationError(
77
+ scriptName,
78
+ `Workflow '${scriptName}' has an invalid parameter schema (expected object). Read the workflow script file (location from <available_workflows>) to inspect it.`,
79
+ );
80
+ }
81
+
82
+ // null-scan:null 值视为缺失(coerceTypes 会把 null→"" 放行 required,绕过 fail-fast)。
83
+ // 只删 schema 未声明 nullable 的键——type 含 "null"(如 ["string","null"])的合法 null
84
+ // 输入保留(m3 exec-review M1 探针实证:全键删除会拒掉 nullable required 的合法值)。
85
+ const schema = parameters as Record<string, unknown>;
86
+ const properties =
87
+ schema.properties !== null && typeof schema.properties === "object"
88
+ ? (schema.properties as Record<string, unknown>)
89
+ : {};
90
+ for (const key of Object.keys(args)) {
91
+ if (args[key] !== null) continue;
92
+ const prop = properties[key];
93
+ let isNullable = false;
94
+ if (prop !== null && typeof prop === "object") {
95
+ const propType = (prop as Record<string, unknown>).type;
96
+ isNullable = Array.isArray(propType)
97
+ ? (propType as unknown[]).includes("null")
98
+ : propType === "null";
99
+ }
100
+ if (!isNullable) delete args[key];
101
+ }
102
+
103
+ let validate: ReturnType<Ajv["compile"]>;
104
+ try {
105
+ validate = ajv.compile(parameters);
106
+ } catch (err) {
107
+ // 真畸形 schema(如 type:'not-a-type')→ 结构化 ArgsValidationError,不泄漏原始 throw
108
+ const detail = err instanceof Error ? err.message : String(err);
109
+ throw new ArgsValidationError(
110
+ scriptName,
111
+ `Workflow '${scriptName}' has an invalid parameter schema: ${detail}. Read the workflow script file (location from <available_workflows>) to inspect it.`,
112
+ );
113
+ }
114
+
115
+ if (!validate(args)) {
116
+ throw new ArgsValidationError(
117
+ scriptName,
118
+ formatMessage(scriptName, validate.errors ?? []),
119
+ validate.errors ?? undefined,
120
+ );
121
+ }
122
+ // 注:非空约束由 schema 声明(minLength/pattern),chokepoint 不发明约束——
123
+ // m3 exec-review M2:硬编码 trim 空串复查与 schema 显式语义(enum 含 ''/minLength:0)
124
+ // 矛盾。review-fix-loop 的 target 用 { minLength: 1, pattern: '\\S' } 表达。
125
+ // 校验失败时 spec.args 可能已被 null-scan/coerce 部分 mutate(文档化行为:失败后
126
+ // 调用方不应复用该 args 对象)。
127
+ }
@@ -2,19 +2,30 @@
2
2
  * Workflow Config Loader — 统一资源发现版(ADR-031)
3
3
  *
4
4
  * 扫描逻辑委托给 shared/resource-discovery(与 agent 发现共享同一套扫描源)。
5
- * 本文件只保留 workflow 专属的 meta 提取(regex)+ 60s TTL 缓存。
5
+ * 本文件只保留 workflow 专属的 meta 提取(经 shared/meta-parser.ts IF1 统一 parser)+ 60s TTL 缓存。
6
+ *
7
+ * m2 收敛:删 extractMetaViaRegex + safeEvalObject(new Function),改调 parseResourceMeta
8
+ * (真实 YAML 解析 @pi-meta 块注释,发现期不执行作者代码,v5 原则 6 no-eval)。
9
+ * toCachedMeta 整对象透传(...meta),不再 {name,description,phases} 解构——消灭第 1 处重映射。
6
10
  *
7
11
  * Failed imports are marked available=false — the loader never throws.
8
12
  */
9
13
 
10
- import { readFile } from "node:fs/promises";
14
+
11
15
  import { resolve } from "node:path";
12
16
 
13
- // WorkflowMeta / WorkflowSource 的规范来源是 engine/models/workflow-script.ts
14
- import type { WorkflowMeta, WorkflowSource } from "./models/workflow-script.ts";
17
+ // WorkflowMeta 规范来源是 shared/resource-meta.ts(m1 DM1);WorkflowSource 来自 workflow-script
18
+ import type { WorkflowSource } from "./models/workflow-script.ts";
19
+ import type { WorkflowMeta } from "../shared/resource-meta.ts";
20
+ import { getCachedFile, getCachedFileContent, clearFileCache } from "../shared/resource-discovery.ts";
21
+ import { parseResourceMeta } from "../shared/meta-parser.ts";
22
+ import { normalizeRef, WORKFLOW_REF_EXT } from "../shared/agent-ref.ts";
15
23
  export type { WorkflowMeta, WorkflowSource };
16
24
 
17
25
  import { getAgentDir } from "@earendil-works/pi-coding-agent";
26
+ import { getLogger } from "@zhushanwen/pi-extension-logger";
27
+
28
+ const logger = getLogger("config-loader");
18
29
 
19
30
  import {
20
31
  discoverResources,
@@ -36,20 +47,15 @@ export interface CachedWorkflowMeta extends WorkflowMeta {
36
47
 
37
48
  // ── Internal types ────────────────────────────────────────────
38
49
 
39
- interface WorkerResult {
40
- success: boolean;
41
- meta?: WorkflowMeta;
42
- error?: string;
43
- }
44
-
45
50
  interface CacheEntry {
46
51
  meta: CachedWorkflowMeta;
47
- cachedAt: number;
52
+ /** 文件 mtime(m5:mtime 键控判失效——删 60s TTL,mtime 未变即命中)。 */
53
+ mtimeMs: number;
48
54
  }
49
55
 
50
56
  // ── Constants ─────────────────────────────────────────────────
51
57
 
52
- const CACHE_TTL_MS = 60_000;
58
+ // m5:删 60s TTL——mtime 键控判失效(TTL 只服务 getWorkflow 且造成 60s 陈旧窗口)。
53
59
 
54
60
  // ── Cache ─────────────────────────────────────────────────────
55
61
 
@@ -66,7 +72,9 @@ function getCacheBucket(workspaceRoot: string): Map<string, CacheEntry> {
66
72
  }
67
73
 
68
74
  function isCacheValid(entry: CacheEntry): boolean {
69
- return Date.now() - entry.cachedAt < CACHE_TTL_MS;
75
+ // m5:mtime 判变——文件 mtime 未变即命中(删 TTL 后文件变更立即反映)
76
+ const file = getCachedFile(entry.meta.path);
77
+ return file !== null && file.mtimeMs === entry.mtimeMs;
70
78
  }
71
79
 
72
80
  // ── Helpers ───────────────────────────────────────────────────
@@ -78,71 +86,6 @@ function stem(filePath: string): string {
78
86
  return dot > 0 ? base.slice(0, dot) : base;
79
87
  }
80
88
 
81
- // ── Regex-based meta extraction ─────────────────────────────
82
-
83
- /**
84
- * Extract the `meta` object from a workflow script using regex.
85
- *
86
- * This avoids executing user code (no Worker/import/require), so it works
87
- * regardless of whether the script uses CJS, ESM, top-level await, or
88
- * references runtime globals like `agent` or `$ARGS`.
89
- *
90
- * Supports both `const meta = { ... }` and `export const meta = { ... }`.
91
- */
92
- async function extractMetaViaRegex(scriptPath: string): Promise<WorkerResult> {
93
- try {
94
- const content = await readFile(scriptPath, "utf-8");
95
-
96
- const metaPattern = /(?:export\s+)?const\s+meta\s*=\s*(\{[^]*?\});?\s*$/m;
97
- const match = metaPattern.exec(content);
98
- if (!match) {
99
- return { success: false, error: "No 'const meta = { ... }' declaration found" };
100
- }
101
-
102
- const metaObj = safeEvalObject(match[1]);
103
- if (!metaObj || typeof metaObj !== "object") {
104
- return { success: false, error: "Failed to parse meta object" };
105
- }
106
-
107
- if (typeof metaObj.name !== "string") {
108
- return { success: false, error: "meta.name must be a string" };
109
- }
110
-
111
- return {
112
- success: true,
113
- meta: {
114
- name: metaObj.name,
115
- description: typeof metaObj.description === "string" ? metaObj.description : "",
116
- phases: Array.isArray(metaObj.phases)
117
- ? metaObj.phases.filter(
118
- (p: unknown) => typeof p === "string" || (typeof p === "object" && p !== null && "title" in p),
119
- ) as (string | { title: string; detail?: string })[]
120
- : [],
121
- },
122
- };
123
- } catch (err) {
124
- return { success: false, error: err instanceof Error ? err.message : String(err) };
125
- }
126
- }
127
-
128
- /**
129
- * Safely evaluate a simple object literal string.
130
- * Uses `new Function` to avoid eval while still supporting basic JS
131
- * literal syntax (strings, numbers, arrays, nested objects).
132
- */
133
- function safeEvalObject(literal: string): Record<string, unknown> | undefined {
134
- try {
135
- const fn = new Function(`return (${literal});`);
136
- const result = fn();
137
- if (typeof result === "object" && result !== null && !Array.isArray(result)) {
138
- return result as Record<string, unknown>;
139
- }
140
- return undefined;
141
- } catch {
142
- return undefined;
143
- }
144
- }
145
-
146
89
  // ── ResourceSource → WorkflowSource 映射 ─────────────────────
147
90
 
148
91
  /** 统一模块的 ResourceSource 映射为 workflow 的 saved/tmp 语义 */
@@ -150,29 +93,40 @@ function toWorkflowSource(source: ResourceSource): WorkflowSource {
150
93
  return source === "project-pi-tmp" ? "tmp" : "saved";
151
94
  }
152
95
 
153
- // ── 单文件 → CachedWorkflowMeta ───────────────────────────────
96
+ // ── 单文件 → CachedWorkflowMeta(IF1 parseResourceMeta + 整对象透传)──
154
97
 
155
- /** 提取单个文件的 meta,失败时标 available=false(与原行为一致) */
98
+ /**
99
+ * 提取单个文件的 meta(经 IF1 parseResourceMeta),失败时标 available=false(fail-safe 不抛)。
100
+ *
101
+ * m2:整对象透传(...meta),不再 {name,description,phases} 解构——消灭第 1 处重映射,
102
+ * parameters/usage/when/notFor 一路流到 script.meta。仅认 @pi-meta 新格式(D1 无 adapter)。
103
+ */
156
104
  async function toCachedMeta(
157
105
  filePath: string,
158
106
  source: ResourceSource,
159
107
  ): Promise<CachedWorkflowMeta> {
160
108
  const fallbackName = stem(filePath);
161
- const result = await extractMetaViaRegex(filePath);
162
109
  const wfSource = toWorkflowSource(source);
163
-
164
- if (result.success && result.meta) {
165
- return {
166
- name: result.meta.name,
167
- description: result.meta.description,
168
- phases: result.meta.phases,
169
- path: filePath,
170
- available: true,
171
- source: wfSource,
172
- };
110
+ try {
111
+ const content = getCachedFileContent(filePath); // m5:统一 mtime 缓存层
112
+ if (content === null) throw new Error("file not readable");
113
+ const meta = parseResourceMeta(content, "workflow");
114
+ if (meta && meta.kind === "workflow") {
115
+ return { ...meta, path: filePath, available: true, source: wfSource };
116
+ }
117
+ // m2 exec-review MINOR-4:文件可读但 meta=null → 旧 const meta 格式或格式错误,
118
+ // 静默 available=false(D1 无 adapter)。warn 帮助用户定位需迁移到 @pi-meta 的存量 workflow。
119
+ logger.warn(
120
+ `[config-loader] ${filePath}: 未解析到 @pi-meta 元数据(旧 const meta 格式需迁移)→ available=false`,
121
+ );
122
+ } catch (err) {
123
+ // 读失败 → available=false(fail-safe 不抛,与原行为一致)
124
+ logger.debug(`[config-loader] skip unreadable workflow file ${filePath}`, {
125
+ reason: err instanceof Error ? err.message : String(err),
126
+ });
173
127
  }
174
-
175
128
  return {
129
+ kind: "workflow",
176
130
  name: fallbackName,
177
131
  description: "",
178
132
  phases: [],
@@ -268,9 +222,9 @@ export async function discoverWorkflows(
268
222
 
269
223
  // Update cache (scoped to current workspace root)
270
224
  const bucket = getCacheBucket(workspaceRoot);
271
- const now = Date.now();
272
225
  for (const wf of merged) {
273
- bucket.set(wf.name, { meta: wf, cachedAt: now });
226
+ const file = getCachedFile(wf.path);
227
+ bucket.set(wf.name, { meta: wf, mtimeMs: file?.mtimeMs ?? 0 });
274
228
  }
275
229
 
276
230
  return merged;
@@ -304,10 +258,25 @@ export async function getWorkflow(name: string): Promise<CachedWorkflowMeta | un
304
258
  return workflows.find((wf) => wf.name === name);
305
259
  }
306
260
 
261
+ /**
262
+ * 按绝对路径加载单个 workflow(workflowRef 统一解析入口——S2 路径统一)。
263
+ *
264
+ * - ~/ 前缀展开;相对路径/非 .js 引用返回 undefined(引用唯一形态 = 绝对路径)
265
+ * - 任意路径(不限扫描源):内置包内脚本、用户任意位置脚本均可执行
266
+ * - meta 提取失败/文件不可读 → available=false(fail-safe,不抛)
267
+ */
268
+ export async function getWorkflowByPath(ref: string): Promise<CachedWorkflowMeta | undefined> {
269
+ const filePath = normalizeRef(ref, WORKFLOW_REF_EXT);
270
+ if (filePath === null) return undefined;
271
+ return toCachedMeta(filePath, "user-pi");
272
+ }
273
+
307
274
  /**
308
275
  * Invalidate the internal meta cache.
309
276
  * The next call to loadWorkflows or getWorkflow will re-scan directories.
310
277
  */
311
278
  export function invalidateCache(): void {
279
+ // m5:清统一 mtime 缓存层 + bucket(测试隔离 + mtime 漏判场景手动刷新兜底)
280
+ clearFileCache();
312
281
  cache.clear();
313
282
  }
@@ -279,15 +279,12 @@ function dispatchAgentCall(
279
279
  : undefined,
280
280
  };
281
281
 
282
- // BL-1:解析 agent/skill/schema → systemPromptFiles / skillPath / schemaEnv
283
- // D-12 重构误删 resolveAgentOpts,导致 inline override 静默失效。此处从
284
- // LifecycleDeps agentRegistry/sessionDir/activeTempFiles(per-session,由
285
- // Interface session_start 注入),调 resolveAgentOpts 解析 inline override。
286
- // 解析失败(agent/skill 未找到、临时文件写入错)走 error 路径,不发 slot、不 spawn。
287
- const hasResolverDeps = deps.agentRegistry && deps.sessionDir && deps.activeTempFiles;
288
- const resolved = hasResolverDeps
289
- ? resolveAgentOpts(opts, deps.agentRegistry!, deps.sessionDir!, deps.activeTempFiles!)
290
- : { opts };
282
+ // BL-1:解析 skill/schema → skillPath / schemaEnv / appendSystemPrompt
283
+ // M2 修正后 resolveAgentOpts 单参数,只处理 schema SO 指令(内容直传)+ skill。
284
+ // agent ref 处理(systemPrompt/model/thinkingLevel)交 resolveIdentity(经
285
+ // getAgentConfig + resolveModel 完整覆盖),消除双重注入与 model 层级混乱。
286
+ // 解析失败(skill 未找到)走 error 路径,不发 slot、不 spawn。
287
+ const resolved = resolveAgentOpts(opts);
291
288
  if (resolved.error) {
292
289
  const call = new AgentCall(msg.callId, opts, node);
293
290
  call.markRunning();
@@ -25,6 +25,7 @@
25
25
  * 参考:domain-models.md §D-8(WorkflowRunResult 签名)、clarification.md C.7。
26
26
  */
27
27
 
28
+ import { ArgsValidationError } from "./args-validator.ts";
28
29
  import { abortRun, runWorkflow } from "./lifecycle.ts";
29
30
  import type { LifecycleDeps } from "./models/ports.ts";
30
31
  import type { RunSpec } from "./models/run-spec.ts";
@@ -177,8 +178,8 @@ export async function runAndWait(
177
178
  signal?: AbortSignal,
178
179
  timeoutMs: number = DEFAULT_RUNANDWAIT_TIMEOUT_MS,
179
180
  ): Promise<WorkflowRunResult> {
180
- // 1. registry 查找脚本
181
- const script = await deps.registry.get(name);
181
+ // 1. registry 查找脚本(workflowRef = 绝对路径,S2 路径统一)
182
+ const script = await deps.registry.getPath(name);
182
183
  if (!script) {
183
184
  return {
184
185
  status: "done",
@@ -210,12 +211,31 @@ export async function runAndWait(
210
211
  scriptName: script.name,
211
212
  scriptPath: script.path,
212
213
  description: script.meta.description,
214
+ parameters: script.meta.parameters,
213
215
  };
214
216
 
215
217
  // 4. 启动 workflow + 5. 轮询至 done(含 6. timeout → abortRun,C.7)
216
218
  // pending-notification 的 register/unregister 由 runWorkflow(启动注册)+
217
219
  // transition("done") 路径(完成注销)统一处理,runAndWait 不再重复 emit。
218
- const runId = await runWorkflow(spec, deps, signal);
220
+ // m3:chokepoint 校验失败(ArgsValidationError)→ 返回 invalid_args 结果(run 从未
221
+ // 创建,runId 恒 ''),非 ArgsValidationError 保持传播。
222
+ let runId: string;
223
+ try {
224
+ runId = await runWorkflow(spec, deps, signal);
225
+ } catch (err) {
226
+ if (err instanceof ArgsValidationError) {
227
+ // 注:WorkflowRunResult.reason 是 pi.__workflowRun 的跨扩展公开类型——新增
228
+ // 'invalid_args' 成员是对外部消费方的契约变更(m3 exec-review m5);该 reason
229
+ // 永不进 run.state.reason(run 从未创建),仅存在于本合成返回值。
230
+ return {
231
+ status: "done",
232
+ reason: "invalid_args",
233
+ runId: "",
234
+ error: err.message,
235
+ };
236
+ }
237
+ throw err;
238
+ }
219
239
  return pollRunToResult(runId, deps, signal, timeoutMs, "Aborted by signal");
220
240
  }
221
241
 
@@ -293,47 +313,56 @@ export async function executeNestedWorkflow(
293
313
  }
294
314
  }
295
315
 
296
- // Step 3: registry 查找 + lint(失败返回 error result,不抛错)
297
- const script = await deps.registry.get(name);
298
- if (!script) {
299
- return { content: "", error: `Workflow '${name}' not found` };
300
- }
301
- const lintResult = script.validate();
302
- if (!lintResult.valid) {
303
- const errors = lintResult.findings
304
- .filter((f) => f.severity === "error")
305
- .map((f) => `L${f.line}: ${f.message}`)
306
- .join("; ");
307
- return {
308
- content: "",
309
- error: `Workflow script '${name}' has lint errors: ${errors}`,
310
- };
311
- }
316
+ // Step 3+:registry 查找 + lint + RunSpec + runWorkflow + poll 全程 try(m3 E8——
317
+ // try 起点提到 Step 2 的 listener 注册之后,覆盖 Step 3-6。runWorkflow throw
318
+ // (含 chokepoint ArgsValidationError)与 not found/lint 早返回均走 finally 移除
319
+ // parentSignal listener——修复原 try runWorkflow 的泄漏路径)。
320
+ try {
321
+ // Step 3: registry 查找 + lint(失败返回 error result,不抛错)
322
+ const script = await deps.registry.getPath(name);
323
+ if (!script) {
324
+ return { content: "", error: `Workflow '${name}' not found` };
325
+ }
326
+ const lintResult = script.validate();
327
+ if (!lintResult.valid) {
328
+ const errors = lintResult.findings
329
+ .filter((f) => f.severity === "error")
330
+ .map((f) => `L${f.line}: ${f.message}`)
331
+ .join("; ");
332
+ return {
333
+ content: "",
334
+ error: `Workflow script '${name}' has lint errors: ${errors}`,
335
+ };
336
+ }
312
337
 
313
- // Step 4: 构建 RunSpec(共享父 Budget + 循环链)+ 启动子 workflow
314
- // budget 共享(F-7 方案 B):子 run 直接复用父 Budget 引用(budgetRef),consume 实时
315
- // 累加到父 Budget,消除并行嵌套下的超支窗口,无需 Step 6 的 sync-back。
316
- const spec: RunSpec = {
317
- scriptSource: script.toExecutable(),
318
- args,
319
- budgetRef: parentRun.state.budget,
320
- scriptName: script.name,
321
- scriptPath: script.path,
322
- description: script.meta.description,
323
- parentWorkflowChain: chain,
324
- };
325
- const runId = await runWorkflow(spec, deps, childController.signal);
338
+ // Step 4: 构建 RunSpec(共享父 Budget + 循环链)+ 启动子 workflow
339
+ // budget 共享(F-7 方案 B):子 run 直接复用父 Budget 引用(budgetRef),consume 实时
340
+ // 累加到父 Budget,消除并行嵌套下的超支窗口,无需 Step 6 的 sync-back。
341
+ const spec: RunSpec = {
342
+ scriptSource: script.toExecutable(),
343
+ args,
344
+ budgetRef: parentRun.state.budget,
345
+ // Run-level override 传播(与父 run 对齐):子 run 继承父 run 的 model/thinkingLevel,
346
+ // 否则嵌套 workflow 丢失父 run 的模型指定,回落主 agent 模型。
347
+ model: parentRun.spec.model,
348
+ thinkingLevel: parentRun.spec.thinkingLevel,
349
+ scriptName: script.name,
350
+ scriptPath: script.path,
351
+ description: script.meta.description,
352
+ parameters: script.meta.parameters,
353
+ parentWorkflowChain: chain,
354
+ };
355
+ const runId = await runWorkflow(spec, deps, childController.signal);
326
356
 
327
- // Step 5: 轮询至 done(复用 runAndWait 的轮询逻辑)
328
- // [H-1] 嵌套 workflow timeout 从父 run 继承:父 spec.budgetTimeMs 存在时取
329
- // min(父 budget, DEFAULT),让子 run 不超出父 run 的剩余时间预算;否则用 DEFAULT。
330
- // budgetRef(共享 Budget)已在 Step 4 透传给子 run 处理 token/cost 预算,
331
- // 此处的 budgetTimeMs 只服务 pollRunToResult 的轮询 deadline(wall-clock 兜底)。
332
- const nestedTimeoutMs = parentRun.spec.budgetTimeMs
333
- ? Math.min(parentRun.spec.budgetTimeMs, DEFAULT_RUNANDWAIT_TIMEOUT_MS)
334
- : DEFAULT_RUNANDWAIT_TIMEOUT_MS;
357
+ // Step 5: 轮询至 done(复用 runAndWait 的轮询逻辑)
358
+ // [H-1] 嵌套 workflow timeout 从父 run 继承:父 spec.budgetTimeMs 存在时取
359
+ // min(父 budget, DEFAULT),让子 run 不超出父 run 的剩余时间预算;否则用 DEFAULT。
360
+ // budgetRef(共享 Budget)已在 Step 4 透传给子 run 处理 token/cost 预算,
361
+ // 此处的 budgetTimeMs 只服务 pollRunToResult 的轮询 deadline(wall-clock 兜底)。
362
+ const nestedTimeoutMs = parentRun.spec.budgetTimeMs
363
+ ? Math.min(parentRun.spec.budgetTimeMs, DEFAULT_RUNANDWAIT_TIMEOUT_MS)
364
+ : DEFAULT_RUNANDWAIT_TIMEOUT_MS;
335
365
 
336
- try {
337
366
  const result = await pollRunToResult(
338
367
  runId,
339
368
  deps,
@@ -360,6 +389,13 @@ export async function executeNestedWorkflow(
360
389
  content: "",
361
390
  error: result.error ?? `Workflow '${name}' ended: ${result.reason}`,
362
391
  };
392
+ } catch (err) {
393
+ // m3:chokepoint 校验失败 → {error}(§5.3 指引文案),非 ArgsValidationError 保持传播
394
+ // (dispatchWorkflowCall 的 .catch 兜底转 postResult,worker 不崩)。
395
+ if (err instanceof ArgsValidationError) {
396
+ return { content: "", error: err.message };
397
+ }
398
+ throw err;
363
399
  } finally {
364
400
  // [L-2] 子 run done 后移除 parentSignal listener,避免累积({ once: true } 在
365
401
  // 正常完成路径下不会自动触发,listener 残留;多次嵌套调用会泄漏到 parentSignal)。
@@ -32,6 +32,7 @@
32
32
 
33
33
  import { getLogger } from "@zhushanwen/pi-extension-logger";
34
34
 
35
+ import { validateRunArgs } from "./args-validator.ts";
35
36
  import { ConcurrencyGate, DEFAULT_CONCURRENCY } from "./concurrency-gate.ts";
36
37
  import {
37
38
  handleWorkerError,
@@ -147,6 +148,12 @@ export async function runWorkflow(
147
148
  deps: LifecycleDeps,
148
149
  signal?: AbortSignal,
149
150
  ): Promise<string> {
151
+ // m3 E9:参数校验单一 chokepoint,钉在所有副作用前(generateRunId/log/signal
152
+ // listener/runs.set/workerHost.start/store.save/pending:register)。校验失败时
153
+ // zero side effects。coerceTypes 原地规范化 spec.args——worker 启动与 pause/resume
154
+ // 重建共用同一对象(run.spec === spec),恢复路径参数一致。
155
+ validateRunArgs(spec);
156
+
150
157
  const runId = generateRunId();
151
158
  deps.log?.("debug", "workflow:lifecycle", "runWorkflow start", { runId, scriptName: spec.scriptName });
152
159
 
@@ -10,7 +10,6 @@
10
10
  *
11
11
  * 层归属:Engine。零 infra 依赖(AC-1)。
12
12
  */
13
- import type { AgentRegistry } from "../../execution/agent-registry.ts";
14
13
  import type { StreamSink, SubagentStream } from "../../execution/stream-sink.ts";
15
14
  import type { AgentEvent } from "../../shared/agent-event.ts";
16
15
  import type { WorkerHandle } from "../worker-handle.ts";
@@ -126,19 +125,6 @@ export interface LifecycleDeps {
126
125
  */
127
126
  log?: (level: "debug" | "info" | "warn" | "error", component: string, message: string, data?: unknown) => void;
128
127
  /**
129
- * BL-1:agent/skill/schema 解析依赖(per-session,可选)。
130
- *
131
- * Interface 层 factory 在 session_start 注入:agentRegistry(扫描 .agents/agents 等
132
- * 7 路径)、sessionDir(临时文件根)、activeTempFiles(session_shutdown 回收集合)。
133
- * error-recovery.dispatchAgentCall 用这 3 项调 resolveAgentOpts,把
134
- * `agent({agent,skill,schema})` 的 inline override 解析成 systemPromptFiles /
135
- * skillPath / schemaEnv,否则 pi 子进程只收到原始 prompt(D-12 重构误删导致回归)。
136
- * 全部可选——测试 makeDeps 工厂无需改。
137
- */
138
- agentRegistry?: AgentRegistry;
139
- sessionDir?: string;
140
- activeTempFiles?: Set<string>;
141
- /**
142
128
  * D-12 regression fix (round-2 #2):rebuildRuntime 重新调度 run 级墙钟预算计时器。
143
129
  *
144
130
  * worker/script 错误重试走 replaceRuntime,旧 RunRuntime 的 release 会 clearTimeout
@@ -24,8 +24,31 @@ import type { Budget } from "./budget.ts";
24
24
  export interface RunSpec {
25
25
  /** 已 strip export 的可执行源(WorkflowScript.toExecutable 产物)。 */
26
26
  readonly scriptSource: string;
27
- /** 调用方传入的参数(worker 内通过 $ARGS 访问)。 */
27
+ /**
28
+ * 参数契约(JSON Schema draft-07,来自 script.meta.parameters 整对象透传,m3 DM2)。
29
+ *
30
+ * undefined = 不校验(安全退化——漏拷 parameters 退化是「不校验」非「校验错」)。
31
+ * 由调用方(actionRun/runAndWait/executeNestedWorkflow)从 script.meta.parameters 拷贝。
32
+ * lifecycle.runWorkflow 首行经 validateRunArgs 校验 spec.args(coerceTypes 原地规范化
33
+ * args 对象内容,字段引用不变;worker 启动与 pause/resume 重建共用同一对象)。
34
+ */
35
+ readonly parameters?: Record<string, unknown>;
36
+ /** 调用方传入的参数(worker 内通过 $ARGS 访问)。 */
28
37
  readonly args: Record<string, unknown>;
38
+ /**
39
+ * Run 级 model override(Option B:经 workerData → worker global $MODEL → agent() fallback)。
40
+ *
41
+ * undefined = 继承主 agent 模型(零配置默认)。设置时该 run 内所有 agent() 调用默认继承
42
+ * (除非 per-call 显式指定 model)。注意:不 merge 进 args(对称单路径注入),
43
+ * 而是经 worker-script-builder 注入为 $MODEL worker global。
44
+ */
45
+ readonly model?: string;
46
+ /**
47
+ * Run 级 thinkingLevel override(Option B:经 workerData → worker global $THINKING_LEVEL)。
48
+ *
49
+ * undefined = 继承主 agent thinkingLevel。取值范围由 THINKING_ORDER SSOT 派生(含 max)。
50
+ */
51
+ readonly thinkingLevel?: string;
29
52
  /** Token 预算上限(未设或 0 = 不限制,见 Budget 守卫)。 */
30
53
  readonly budgetTokens?: number;
31
54
  /** 时间预算上限(ms,wall-clock,由 lifecycle.scheduleTimeBudget 调度)。 */