@zeniai/client-epic-state 5.2.7-betaRD1 → 5.2.8

package/lib/esm/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -3,9 +3,7 @@ import orderBy from 'lodash/orderBy';
 import { reduceAnyFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { LAST_SCHEDULE_DAY_OF_MONTH, toMonthYearPeriodId, } from '../../../commonStateTypes/timePeriod';
 import { getAccountIdsForTypes } from '../../../entity/account/accountSelector';
-import { generateJEOneTimeAccrualKey } from '../../../entity/jeSchedules/jeScheduleHelper';
-import { getJEAccruedScheduleByJEScheduleKey, getJEOneTimeAccrualByKey, getJEScheduledTransactionByJEScheduleTransactionKey, } from '../../../entity/jeSchedules/jeSchedulesSelector';
-import { ALL_SCHEDULES_TYPES, } from '../../../entity/jeSchedules/jeSchedulesTypes';
+import { getJEScheduledTransactionByJEScheduleTransactionKey, } from '../../../entity/jeSchedules/jeSchedulesSelector';
 import { getCurrentTenant } from '../../../entity/tenant/tenantSelector';
 import { getAccountIdsForLabel, getAccountList, getNestedAccountListHierarchy, getUncategorizedAccounts, } from '../../accountList/accountListSelector';
 import { getClassList, getNestedClassListHierarchy, } from '../../classList/classListSelector';
@@ -13,126 +11,8 @@ import { getAccountsTypesForScheduleDetails } from '../../scheduleView/scheduleD
 import { filterNestedAccountHierarchyById } from '../../scheduleView/scheduleDetailView/scheduleDetailSelector';
 import { getAccountLabelForScheduleType, getAccountsTypesForScheduleList, } from '../../scheduleView/scheduleListView/scheduleListHelper';
 import { getAllSteps } from './getAllStepsHelper';
-import { ALL_JE_PAGE_TABS, getJESchedulePeriodTabKey, } from '../types/jeSchedulesViewState';
 import { getJEAccountSettingsView } from './jeAccountSettingsViewSelector';
-import { getNewScheduleView } from './jeNewScheduleViewSelector';
-// Matches the AI-automation user addresses webc's schedule list row already
-// checks (JEScheduleReadOnlyListRow/JEScheduleDraftListRow "Method" column,
-// strings.ts aiBotEmail/botEmail) to determine whether a schedule was
-// created by the AI accountant vs. a human.
-const AI_BOT_EMAIL = 'ai@zeni.ai';
-const BOT_EMAIL = 'bot@zeni.ai';
-// A one-time accrual has no jeScheduleType of its own — it is not a JE schedule. It is still an
-// accrued expense, so it counts and filters under that type on the page's type tabs.
-const ONE_TIME_ACCRUAL_SCHEDULE_TYPE = 'accrued_expenses';
-// Which of the two list buckets an accrual belongs in. `draft` still needs a human to post it;
-// everything else is already on the books or in a transient claim.
-const ONE_TIME_ACCRUAL_REVIEW_STATUSES = [
-    'draft',
-];
-/**
- * `posting_blocked` is written by the posting Cron when a JE fails to post. It is an internal
- * failure state with no human action attached, so it is dropped here rather than hidden at render
- * time — filtering in the view would leave the group counts and KPI totals counting rows nobody
- * can see. The expense-automation endpoint applies no status filter on the close-period path, so
- * these rows do arrive.
- */
-export function isRenderableOneTimeAccrual(accrual) {
-    return accrual.accrualStatus !== 'posting_blocked';
-}
-export function getJEScheduleRowType(schedule) {
-    return isOneTimeAccrualRow(schedule)
-        ? ONE_TIME_ACCRUAL_SCHEDULE_TYPE
-        : schedule.jeScheduleType;
-}
-export function isPendingReviewRow(schedule) {
-    return isOneTimeAccrualRow(schedule)
-        ? ONE_TIME_ACCRUAL_REVIEW_STATUSES.includes(schedule.accrualStatus)
-        : schedule.status.code === 'draft';
-}
-// Belongs on the Existing Schedules tab. For an accrual the endpoint has already filtered to
-// posted, so this only has to agree with that rather than re-derive it.
-export function isExistingTabRow(schedule) {
-    return isOneTimeAccrualRow(schedule)
-        ? schedule.accrualStatus === 'posted'
-        : schedule.status.code === 'ongoing';
-}
-// Exported (rather than kept as a closure inside the selector) so it can be
-// unit-tested directly — confidenceScore is a separate, more narrowly
-// populated field that can be null on a schedule the bot user created,
-// which previously caused these schedules to display as "AI Accountant" in
-// the list but count under "Manual" in the KPI summary.
-export const isAiAccountantSchedule = (schedule) => {
-    // A one-time accrual records who made it as `origin`, which is authoritative — no email
-    // sniffing needed, and the JE bot is often absent from the user entity entirely.
-    if (isOneTimeAccrualRow(schedule)) {
-        return schedule.origin === 'agent';
-    }
-    return (schedule.createdByUser?.email === AI_BOT_EMAIL ||
-        schedule.createdByUser?.email === BOT_EMAIL);
-};
-// Accrued schedules are structurally distinct — no baseTransaction, carrying recurringAmount and
-// memo in its place — so anything reading baseTransaction has to branch on this first.
-//
-// Discriminates on jeAccruedScheduleKey, which only JEAccruedSchedule carries. jeScheduleType
-// cannot be used: it is a data field present on BOTH row shapes, so an accrued-typed row that
-// arrived through the prepaid/fixed DTO (failed_je_postings, legacy fetches) would be
-// misclassified and then crash on recurringAmount / jeAccruedScheduleKey.
-export function isAccruedScheduleRow(schedule) {
-    return 'jeAccruedScheduleKey' in schedule;
-}
-// Same structural approach as isAccruedScheduleRow, and for the same reason: jeOneTimeAccrualKey
-// exists only on this shape. Note the two guards are NOT interchangeable — a one-time accrual is
-// not an accrued *schedule*, and routing it into the accrued branch would read recurringAmount,
-// render postedCount/lifecycleTotal as a lifecycle and startDate–endDate as a period, none of
-// which it has.
-export function isOneTimeAccrualRow(schedule) {
-    return 'jeOneTimeAccrualKey' in schedule;
-}
-function getScheduleAmount(schedule) {
-    if (isOneTimeAccrualRow(schedule)) {
-        return schedule.estimatedAmount.amount;
-    }
-    if (isAccruedScheduleRow(schedule)) {
-        return schedule.recurringAmount.amount;
-    }
-    return schedule.baseTransaction.amount.amount;
-}
-// A one-time accrual shares almost no sortable field with a schedule, so it gets its own accessor
-// rather than a guard on each of the dozen cases below. Keys with no meaning for a single-month
-// accrual -- amortizationPeriod, remainingMonths, runningBalance, jePostingDate, scheduleCategory --
-// deliberately fall through to undefined, which sorts them together at one end.
-function getOneTimeAccrualSortValue(accrual, sortKey) {
-    switch (sortKey) {
-        case 'vendor':
-            return accrual.vendorName.toLowerCase();
-        case 'category':
-            return accrual.jeDebitAccountName?.toLowerCase();
-        case 'class':
-            return accrual.jeDebitAccountingClassName?.toLowerCase();
-        case 'depCategory':
-            return accrual.jeCreditAccountName?.toLowerCase();
-        case 'type':
-            return ONE_TIME_ACCRUAL_SCHEDULE_TYPE;
-        case 'totalAmount':
-            return accrual.estimatedAmount.amount;
-        case 'transactionDate':
-            return accrual.postingDate?.valueOf();
-        case 'memo':
-            return accrual.memo.toLowerCase();
-        case 'startMonth':
-            return accrual.serviceMonth;
-        default:
-            return undefined;
-    }
-}
 function getJEScheduleSortAccessor(sortKey) {
-    const scheduleAccessor = getScheduleRowSortAccessor(sortKey);
-    return (schedule) => isOneTimeAccrualRow(schedule)
-        ? getOneTimeAccrualSortValue(schedule, sortKey)
-        : scheduleAccessor(schedule);
-}
-function getScheduleRowSortAccessor(sortKey) {
     switch (sortKey) {
         case 'vendor':
             return (s) => s.vendor.name?.toLowerCase();
@@ -143,9 +23,7 @@ function getScheduleRowSortAccessor(sortKey) {
         case 'depCategory':
             return (s) => s.jeCredit.account?.accountName?.toLowerCase();
         case 'scheduleCategory':
-            return (s) => isAccruedScheduleRow(s)
-                ? undefined
-                : s.baseTransaction.account?.accountName?.toLowerCase();
+            return (s) => s.baseTransaction.account?.accountName?.toLowerCase();
         case 'startMonth':
             return (s) => s.startDate?.valueOf();
         case 'type':
@@ -173,13 +51,11 @@ function getScheduleRowSortAccessor(sortKey) {
                 return s.balanceAsOfToday?.amount ?? null;
             };
         case 'totalAmount':
-            return (s) => getScheduleAmount(s);
+            return (s) => s.baseTransaction.amount.amount;
         case 'transactionDate':
-            return (s) => s.createTime?.valueOf();
+            return (s) => s.baseTransaction.date.valueOf();
         case 'memo':
-            return (s) => isAccruedScheduleRow(s)
-                ? s.memo.toLowerCase()
-                : s.baseTransaction.memo?.toLowerCase();
+            return (s) => s.baseTransaction.memo?.toLowerCase();
         default:
             return (s) => s.startDate?.valueOf();
     }
@@ -191,15 +67,9 @@ function sortJEScheduledTransactions(transactions, sortKey, sortOrder) {
 export function getExpenseAutomationJESchedulesView(state) {
     const jeScheduledTransaction = [];
     const failedJeScheduledTransaction = [];
-    const accruedSchedules = [];
-    const oneTimeAccruals = [];
     const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
-    const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, oneTimeAccrualActionStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
+    const { jeScheduleTransactionKeysByPeriod, failedJeScheduleTransactionKeysByPeriod, jeScheduleLocalDataById, postStatusById, ignoreStatusById, uiState, error, fetchState, refreshStatus, } = expenseAutomationJESchedulesViewState;
     const accountSettingsView = getJEAccountSettingsView(state);
-    const newScheduleView = newSchedule.selectedDetailScheduleType === 'fixed_assets' ||
-        newSchedule.selectedDetailScheduleType === 'prepaid_expenses'
-        ? getNewScheduleView(state, newSchedule.selectedDetailScheduleType)
-        : undefined;
     const currentTenant = getCurrentTenant(state);
     const { selectedPeriodByTenantId } = expenseAutomationViewState;
     const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
@@ -227,48 +97,27 @@ export function getExpenseAutomationJESchedulesView(state) {
     const filteredDepAccountListNestedAccountHierarchy = filterNestedAccountHierarchyById(depAccountListNestedAccountHierarchy, filteredDepAccounts.map((account) => account.accountId));
     const classListNestedAccountHierarchy = getNestedClassListHierarchy(classListState);
     const monthYearPeriodId = selectedPeriod != null ? toMonthYearPeriodId(selectedPeriod) : null;
-    const selectedPeriodTabKey = monthYearPeriodId != null
-        ? getJESchedulePeriodTabKey(uiState.selectedPageTab, monthYearPeriodId)
+    const jeScheduleTransactionKeysForSelectedPeriod = monthYearPeriodId != null
+        ? jeScheduleTransactionKeysByPeriod[monthYearPeriodId]
         : null;
-    const jeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
-        ? jeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
-        : undefined;
-    const failedJeScheduleTransactionKeysForSelectedTab = selectedPeriodTabKey != null
-        ? failedJeScheduleTransactionKeysByPeriodAndTab[selectedPeriodTabKey]
-        : undefined;
-    // Distinguishes "this tab has never been fetched for this period" from "fetched and genuinely
-    // empty". Without it the page cannot tell a first visit from a real empty state, and renders an
-    // empty table where it should render a skeleton.
-    const hasLoadedForSelectedTab = jeScheduleTransactionKeysForSelectedTab != null;
-    const jeScheduleTransactionKeys = jeScheduleTransactionKeysForSelectedTab ?? [];
-    const failedJeScheduleTransactionKeys = failedJeScheduleTransactionKeysForSelectedTab ?? [];
-    const jeScheduleAccruedKeys = (selectedPeriodTabKey != null
-        ? jeScheduleAccruedKeysByPeriodAndTab[selectedPeriodTabKey]
-        : undefined) ?? [];
-    const jeScheduleOneTimeAccrualKeys = (selectedPeriodTabKey != null
-        ? jeScheduleOneTimeAccrualKeysByPeriodAndTab[selectedPeriodTabKey]
-        : undefined) ?? [];
-    jeScheduleOneTimeAccrualKeys.forEach((jeOneTimeAccrualKey) => {
-        const accrual = getJEOneTimeAccrualByKey(jeOneTimeAccrualKey, state.jeSchedulesState);
-        if (accrual != null && isRenderableOneTimeAccrual(accrual)) {
-            oneTimeAccruals.push(accrual);
-        }
-    });
+    const failedJeScheduleTransactionKeysForSelectedPeriod = monthYearPeriodId != null
+        ? failedJeScheduleTransactionKeysByPeriod[monthYearPeriodId]
+        : null;
+    const jeScheduleTransactionKeys = jeScheduleTransactionKeysForSelectedPeriod ?? [];
+    const failedJeScheduleTransactionKeys = failedJeScheduleTransactionKeysForSelectedPeriod ?? [];
     jeScheduleTransactionKeys.forEach((jeScheduleKey) => {
         const jeScheduleDetails = getJEScheduledTransactionByJEScheduleTransactionKey(jeScheduleKey, state);
         jeScheduledTransaction.push(jeScheduleDetails);
     });
-    jeScheduleAccruedKeys.forEach((jeAccruedScheduleKey) => {
-        const accruedScheduleDetails = getJEAccruedScheduleByJEScheduleKey(jeAccruedScheduleKey, state);
-        if (accruedScheduleDetails != null) {
-            accruedSchedules.push(accruedScheduleDetails);
-        }
-    });
     failedJeScheduleTransactionKeys.forEach((jeScheduleKey) => {
         const jeScheduleDetails = getJEScheduledTransactionByJEScheduleTransactionKey(jeScheduleKey, state);
         failedJeScheduledTransaction.push(jeScheduleDetails);
     });
-    const { sortKey, sortOrder, selectedJETypeFilter } = uiState;
+    const { sortKey, sortOrder } = uiState;
+    const draftSchedules = sortJEScheduledTransactions(jeScheduledTransaction.filter((schedule) => schedule.status.code === 'draft'), sortKey, sortOrder);
+    const ongoingSchedules = sortJEScheduledTransactions(jeScheduledTransaction.filter((schedule) => schedule.status.code === 'ongoing'), sortKey, sortOrder);
+    const completedSchedules = sortJEScheduledTransactions(jeScheduledTransaction.filter((schedule) => schedule.status.code === 'completed' ||
+        schedule.status.code === 'marked_as_completed'), sortKey, sortOrder);
     const unsortedResolveSchedules = [];
     failedJeScheduledTransaction.forEach((schedule) => {
         schedule.scheduledJournalEntry.forEach((journalEntry) => {
@@ -280,87 +129,10 @@ export function getExpenseAutomationJESchedulesView(state) {
     });
     const resolveSchedules = sortJEScheduledTransactions(unsortedResolveSchedules, sortKey, sortOrder);
     const validResolveForPending = unsortedResolveSchedules.filter((r) => jeScheduleLocalDataById[r.scheduledJournalEntry.scheduledJournalEntryID] != null);
-    const matchesTypeFilter = (schedule) => selectedJETypeFilter == null ||
-        getJEScheduleRowType(schedule) === selectedJETypeFilter;
-    const isCreatedStatus = (schedule) => {
-        // An accrual is "created" once it is not review work: posted, reversing, reversed, or in a
-        // transient posting claim.
-        if (isOneTimeAccrualRow(schedule)) {
-            return !isPendingReviewRow(schedule);
-        }
-        return (schedule.status.code === 'ongoing' ||
-            schedule.status.code === 'completed' ||
-            schedule.status.code === 'marked_as_completed');
-    };
-    const allScheduleRows = [
-        ...jeScheduledTransaction,
-        ...accruedSchedules,
-        ...oneTimeAccruals,
-    ];
     const pendingReviewSchedules = sortJEScheduledTransactions([
-        ...allScheduleRows.filter((schedule) => isPendingReviewRow(schedule) && matchesTypeFilter(schedule)),
+        ...jeScheduledTransaction.filter((schedule) => schedule.status.code === 'draft'),
         ...validResolveForPending,
     ], sortKey, sortOrder);
-    const createdSchedules = sortJEScheduledTransactions(allScheduleRows.filter((schedule) => isCreatedStatus(schedule) && matchesTypeFilter(schedule)), sortKey, sortOrder);
-    // KPI summary — derived from unfiltered schedules so counts are always accurate
-    const allSchedules = allScheduleRows;
-    const sumAmount = (schedules) => schedules.reduce((total, schedule) => total + (getScheduleAmount(schedule) ?? 0), 0);
-    const pendingReviewTotal = sumAmount(pendingReviewSchedules);
-    const createdTotal = sumAmount(createdSchedules);
-    const aiAccountantSchedules = allSchedules.filter(isAiAccountantSchedule);
-    const manualSchedules = allSchedules.filter((schedule) => !isAiAccountantSchedule(schedule));
-    const pendingUnfiltered = allSchedules.filter((schedule) => isPendingReviewRow(schedule));
-    const kpiSummary = {
-        aiAccountant: {
-            count: aiAccountantSchedules.length,
-            amount: sumAmount(aiAccountantSchedules),
-        },
-        manual: {
-            count: manualSchedules.length,
-            amount: sumAmount(manualSchedules),
-        },
-        needsReview: {
-            count: pendingUnfiltered.length,
-            amount: sumAmount(pendingUnfiltered),
-        },
-        total: {
-            count: allSchedules.length,
-            amount: sumAmount(allSchedules),
-        },
-    };
-    // Each tab's badge counts from that tab's own bucket. A tab that has not been fetched yet
-    // reports undefined rather than 0, so the UI can hide the badge instead of asserting "none".
-    const scheduleCountsByTab = {};
-    ALL_JE_PAGE_TABS.forEach((pageTab) => {
-        const periodTabKey = monthYearPeriodId != null
-            ? getJESchedulePeriodTabKey(pageTab, monthYearPeriodId)
-            : null;
-        const transactionKeys = periodTabKey != null
-            ? jeScheduleTransactionKeysByPeriodAndTab[periodTabKey]
-            : undefined;
-        if (transactionKeys == null) {
-            return;
-        }
-        const accruedKeys = (periodTabKey != null
-            ? jeScheduleAccruedKeysByPeriodAndTab[periodTabKey]
-            : undefined) ?? [];
-        const oneTimeAccrualKeys = (periodTabKey != null
-            ? jeScheduleOneTimeAccrualKeysByPeriodAndTab[periodTabKey]
-            : undefined) ?? [];
-        const rowsForTab = [
-            ...transactionKeys.map((transactionKey) => getJEScheduledTransactionByJEScheduleTransactionKey(transactionKey, state)),
-            ...accruedKeys
-                .map((accruedKey) => getJEAccruedScheduleByJEScheduleKey(accruedKey, state))
-                .filter((accruedRow) => accruedRow != null),
-            ...oneTimeAccrualKeys
-                .map((accrualKey) => getJEOneTimeAccrualByKey(accrualKey, state.jeSchedulesState))
-                .filter((accrualRow) => accrualRow != null && isRenderableOneTimeAccrual(accrualRow)),
-        ];
-        scheduleCountsByTab[pageTab] =
-            pageTab === 'existing_schedules'
-                ? rowsForTab.filter((row) => isExistingTabRow(row)).length
-                : rowsForTab.filter((row) => isPendingReviewRow(row) || isCreatedStatus(row)).length;
-    });
     const allSteps = monthYearPeriodId != null
         ? getAllSteps(monthEndCloseChecksState, monthYearPeriodId, currentTenant.tenantId)
         : [];
@@ -373,20 +145,6 @@ export function getExpenseAutomationJESchedulesView(state) {
         { fetchState, error },
         monthEndFetchState,
     ]);
-    const countByType = (schedules) => {
-        const counts = ALL_SCHEDULES_TYPES.reduce((acc, type) => ({ ...acc, [type]: 0 }), {});
-        schedules.forEach((schedule) => {
-            const scheduleType = getJEScheduleRowType(schedule);
-            if (scheduleType != null) {
-                counts[scheduleType] += 1;
-            }
-        });
-        return counts;
-    };
-    const jeScheduleTypeCounts = {
-        active: countByType(allSchedules.filter((schedule) => isPendingReviewRow(schedule) || isCreatedStatus(schedule))),
-        ongoing: countByType(allSchedules.filter((schedule) => isExistingTabRow(schedule))),
-    };
     return {
         uncategorizedAccounts,
         allDepreciationAccountList: filteredDepAccounts,
@@ -395,21 +153,14 @@ export function getExpenseAutomationJESchedulesView(state) {
         allAccountList: filteredAccounts,
         accountListNestedAccountHierarchy,
         allClassList: allClasses,
-        createdSchedules,
-        createdTotal,
-        hasLoadedForSelectedTab,
-        jeScheduleTypeCounts,
-        scheduleCountsByTab,
-        kpiSummary,
+        completedSchedules,
+        draftSchedules,
+        ongoingSchedules,
         pendingReviewSchedules,
-        pendingReviewTotal,
         resolveSchedules: resolveSchedules,
         accountSettingsView,
-        newScheduleView,
         postStatusById: postStatusById,
         ignoreStatusById: ignoreStatusById,
-        revertStatusById: revertStatusById,
-        oneTimeAccrualActionStatusById: oneTimeAccrualActionStatusById,
         fetchState: reducedFetchStatus.fetchState,
         jeScheduleLocalDataById: jeScheduleLocalDataById,
         uiState: uiState,
@@ -418,26 +169,3 @@ export function getExpenseAutomationJESchedulesView(state) {
         completionStatus,
     };
 }
-/**
- * One accrual plus the status of its promote / ignore request, for the detail screen.
- *
- * `accrual` is undefined on a cold load — a refresh or a shared link, where the list has never run
- * — so the screen dispatches `fetchOneTimeAccrual` and waits on `detailFetchState`. The two states
- * are separate on purpose: `actionFetchState` drives the row spinner and the post-revert navigation,
- * and a page load must not look like an action that just finished.
- */
-export function getExpenseAutomationJEOneTimeAccrualDetailView(state, accrualId) {
-    return {
-        accrual: getJEOneTimeAccrualByKey(generateJEOneTimeAccrualKey(accrualId), state.jeSchedulesState),
-        actionFetchState: state.expenseAutomationJESchedulesViewState
-            .oneTimeAccrualActionStatusById[accrualId] ?? {
-            fetchState: 'Not-Started',
-            error: undefined,
-        },
-        detailFetchState: state.expenseAutomationJESchedulesViewState
-            .oneTimeAccrualFetchStatusById[accrualId] ?? {
-            fetchState: 'Not-Started',
-            error: undefined,
-        },
-    };
-}

package/lib/esm/view/expenseAutomationView/types/jeSchedulesViewState.js

@@ -16,8 +16,9 @@ const JE_SCHEDULE_SORT_KEYS = [
     'memo',
 ];
 export const toJEScheduleSortKey = (v) => stringToUnion(v, JE_SCHEDULE_SORT_KEYS);
-const JE_PAGE_TABS = ['schedules', 'existing_schedules'];
-export const toJEPageTab = (v) => stringToUnion(v, JE_PAGE_TABS);
-export const ALL_JE_PAGE_TABS = JE_PAGE_TABS;
-export const getJESchedulePeriodTabKey = (selectedPageTab, monthYearPeriodId) => `${selectedPageTab}_${monthYearPeriodId}`;
-export const MIN_NEW_SCHEDULE_SEARCH_LENGTH = 2;
+const JE_SCHEDULE_MAIN_TABS = [
+    'pending_review',
+    'ongoing',
+    'completed',
+];
+export const toJEScheduleMainTab = (v) => stringToUnion(v, JE_SCHEDULE_MAIN_TABS);

package/lib/esm/view/invoicing/editInvoicingCatalogItemDetailView/editInvoicingCatalogItemDetailViewSelector.js

@@ -1,7 +1,7 @@
 import { createSelector } from '@reduxjs/toolkit';
 import { getInvoicingPlanById, getInvoicingPlansByIds, } from '../../../entity/invoicing/plan/planSelector';
 import { getInvoicingConfigView, invoicingFieldHelpForGroup, } from '../invoicingConfigView/invoicingConfigViewSelector';
-import { INVOICING_INCOME_ACCOUNT_TYPES, getInvoicingQboView, invoicingAccountHierarchyForTypes, isInvoicingQboConnected, } from '../invoicingQboView/invoicingQboViewSelector';
+import { INVOICING_INCOME_ACCOUNT_TYPES, getInvoicingQboView, invoicingAccountHierarchyForTypes, isInvoicingAccountingPickerDataLoading, isInvoicingQboConnected, } from '../invoicingQboView/invoicingQboViewSelector';
 import { INVOICING_CATALOG_APPLICABILITY_VALUES, INVOICING_CATALOG_PRICING_MODEL_VALUES, INVOICING_CATALOG_PRORATION_VALUES, INVOICING_CATALOG_TIER_TYPE_VALUES, entityToInvoicingCatalogItemFormLocalData, } from './invoicingCatalogItemFormConfig';
 export const getEditInvoicingCatalogItemDetailViewState = (state) => ({
     fetchState: state.editInvoicingCatalogItemDetailViewState.fetchState,
@@ -53,6 +53,7 @@ export const getInvoicingCatalogItemFormView = (state, id) => {
     const { billingPeriodUnitOptions, catalogItemTypeOptions, catalogTierTypeOptionsByPricingModel, catalogTrialEndActionOptions, catalogTrialUnitOptions, } = getInvoicingConfigView(state);
     return {
         fieldHelp: invoicingFieldHelpForGroup(state, 'catalog'),
+        isQboPickerDataLoading: isInvoicingAccountingPickerDataLoading(state),
         qboClassHierarchy: isQboConnected
             ? getInvoicingQboView(state).nestedClassHierarchy
             : [],

package/lib/esm/view/invoicing/invoicingConfigView/invoicingConfigViewSelector.js

@@ -1,3 +1,4 @@
+import { isInvoicingQboConnected } from '../invoicingQboView/invoicingQboViewSelector';
 import { deriveInvoicingOnboardingStatus, } from './invoicingConfigViewPayload';
 export const getInvoicingConfigView = (state) => {
     const { acceptTermsFetchState, enableFetchState, ...configState } = state.invoicingConfigViewState;
@@ -14,6 +15,7 @@ export const getInvoicingOnboardingGateView = (state) => {
         acceptTermsState: acceptTermsFetchState,
         enableState: enableFetchState,
         fetchState,
+        isQboConnected: isInvoicingQboConnected(state),
         status: deriveInvoicingOnboardingStatus(state.invoicingConfigViewState.isInvoicingTosAccepted, state.invoicingConfigViewState.isInvoicingEnabled),
     };
 };

package/lib/esm/view/invoicing/invoicingQboView/epics/fetchInvoicingAccountingPickersEpic.js

@@ -9,12 +9,17 @@ import { INVOICING_ACCOUNT_LIST_KEY } from '../invoicingQboViewSelector';
 export const fetchInvoicingAccountingPickersEpic = (actions$, state$) => actions$.pipe(filter(fetchInvoicingAccountingPickers.match), withLatestFrom(state$), mergeMap(([, state]) => {
     const actions = [];
     const accountList = state.accountListState.byReportId[INVOICING_ACCOUNT_LIST_KEY];
-    if (accountList.hasValidState() === false &&
+    // `hasValidState` only reports that a fetch finished, not that it
+    // returned anything usable. The shared bucket can be Completed and empty
+    // because a screen that needs fewer accounts filled it first, which would
+    // leave the invoicing pickers empty with no request in flight to fix it.
+    const isAccountListUsable = accountList.hasValidState() && accountList.accountIds.length > 0;
+    if (isAccountListUsable === false &&
         accountList.fetchState !== 'In-Progress') {
-        // AP/AR accounts cannot back an invoicing mapping, so they are excluded
-        // here — which is why this uses invoicing's own bucket rather than the
-        // general `accountList` other screens fill without those exclusions.
-        actions.push(fetchAccountList(INVOICING_ACCOUNT_LIST_KEY, true, true, true));
+        // Same arguments the vendor and categorization screens pass, so this
+        // shares their cached list rather than replacing it with a narrower one.
+        // Invoicing narrows to income accounts when it builds its options.
+        actions.push(fetchAccountList(INVOICING_ACCOUNT_LIST_KEY, true));
     }
     const classList = state.classListState;
     if (classList.hasValidState() === false &&

package/lib/esm/view/invoicing/invoicingQboView/invoicingQboViewSelector.js

@@ -1,10 +1,34 @@
 import { getAccountList, getNestedAccountListHierarchy, } from '../../accountList/accountListSelector';
 import { getClassList, getNestedClassListHierarchy, } from '../../classList/classListSelector';
-// Its own bucket: invoicing needs the AP/AR exclusions that the vendor and
-// transaction screens sharing `accountList` do not pass.
-export const INVOICING_ACCOUNT_LIST_KEY = 'invoicingAccountList';
+// The shared bucket, fetched with the same arguments as the other consumers so
+// whichever screen loads first satisfies the rest. Invoicing narrows to income
+// accounts when it builds its options, so it does not need its own copy.
+export const INVOICING_ACCOUNT_LIST_KEY = 'accountList';
 /** Whether QBO is connected, without building the option lists to find out. */
 export const isInvoicingQboConnected = (state) => state.invoicingQboViewState.connection?.connected === true;
+/**
+ * Whether the accounting pickers are still waiting on their data. Only true when
+ * QBO is connected: a tenant without it has no pickers to populate, so the form
+ * must not sit behind a skeleton waiting for lists it will never show.
+ */
+export const isInvoicingAccountingPickerDataLoading = (state) => {
+    const isPending = (fetchState) => fetchState === 'Not-Started' || fetchState === 'In-Progress';
+    // The connection settles first and decides whether the lists are fetched at
+    // all, so it counts as loading too. Reporting "not loading" while it is in
+    // flight renders the form, then takes it away again the moment the tenant
+    // turns out to be connected.
+    if (isPending(getInvoicingQboConnectionFetchState(state).fetchState)) {
+        return true;
+    }
+    if (!isInvoicingQboConnected(state)) {
+        return false;
+    }
+    const accountList = state.accountListState.byReportId[INVOICING_ACCOUNT_LIST_KEY];
+    return (isPending(accountList.fetchState) ||
+        isPending(state.classListState.fetchState));
+};
+/** The QBO connection fetch on its own, without building the bundled view. */
+export const getInvoicingQboConnectionFetchState = (state) => state.invoicingQboViewState.connectionFetchState;
 /**
  * Account types that can back invoicing revenue. Named here so screens ask for
  * "income accounts" rather than repeating the accounting service's vocabulary.

package/lib/esm/view/invoicing/settingsView/settingsViewSelector.js

@@ -63,9 +63,10 @@ export function deriveInvoicingEnablePrerequisites(settings, isQboConnected, qbo
  * two integration prerequisites kept separate so the hub can name the step still
  * outstanding instead of showing a dead button.
  *
- * `canEnableInvoicing` folds in the onboarding step, so the screen does not need
- * to re-check it: the footer is only offered mid-onboarding and only once both
- * integrations are ready.
+ * `isInvoicingEnabled` decides whether the footer renders; `canEnableInvoicing`
+ * whether its button is live, and it still requires the onboarding step so the
+ * terms cannot be skipped. A tenant partway through therefore sees the footer,
+ * disabled and naming what is left, rather than nothing at all.
  *
  * Deliberately not folded into `getInvoicingConfigView`: that selector gates
  * every invoicing route and stays a pure read of the config slice. The settings
@@ -75,7 +76,10 @@ export const getInvoicingSettingsHubView = (state) => {
     const { dunningScheduleActionOptions, enableState, error: configError, fetchState: configFetchState, qboAccountMappingKindOptions, qboCustomerMatchingOptions, qboSyncStatusOptions, status, } = getInvoicingConfigView(state);
     const { canEnable, isQboConfigured, isStripeConnected } = deriveInvoicingEnablePrerequisites(state.invoicingSettingsViewState.settings, state.invoicingQboViewState.connection?.connected === true, qboAccountMappingKindOptions);
     return {
+        // Keeps the onboarding step in the gate: a tenant that has not accepted the
+        // terms cannot enable invoicing, whatever the integrations say.
         canEnableInvoicing: status === 'settings' && canEnable,
+        isInvoicingEnabled: state.invoicingConfigViewState.isInvoicingEnabled === true,
         configError,
         configFetchState,
         dunningScheduleActionOptions,

package/lib/esm/view/scheduleView/scheduleListView/epics/fetchAccruedScheduleListEpic.js

@@ -30,7 +30,7 @@ export const fetchAccruedScheduleListEpic = (actions$, state$, zeniAPI) => actio
         je_schedule_type: scheduleType,
         sort_by: 'transaction_date',
         sort_order: 'desc',
-        filter: action.payload.statusFilter,
+        filter: 'all',
     };
     return zeniAPI
         .getJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/schedules?query=${encodeURIComponent(JSON.stringify(queryParam))}`)

package/lib/esm/view/scheduleView/scheduleListView/epics/fetchDownloadSchedulesEpic.js

@@ -7,14 +7,9 @@ import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePay
 import { fetchDownloadSchedules, getState, updateDownloadScheduleFailure, updateDownloadScheduleSuccess, } from '../scheduleListReducer';
 import { getScheduleListKey } from '../scheduleListTypes';
 export const fetchDownloadSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchDownloadSchedules.match), mergeMap((action) => {
-    const { scheduleType, downloadCategories, statusFilter } = action.payload;
+    const { scheduleType, downloadCategories } = action.payload;
     const scheduleListState = state$.value.scheduleListState;
     // if parameters are provided, use those. else go to localdata
-    // Accrued is deliberately not served here. Its rows come back in a different shape, this
-    // epic writes them through updateJESchedules (the prepaid / fixed mapper), and
-    // doUpdateScheduleList never flips downloadState for accrued -- so a request would store the
-    // wrong data and then never report completion. Accrued downloads go through
-    // fetchAccruedScheduleList, which owns that shape end to end.
     let scheduleState;
     if (scheduleType !== 'accrued_expenses') {
         scheduleState = getState(scheduleListState, scheduleType);
@@ -39,7 +34,7 @@ export const fetchDownloadSchedulesEpic = (actions$, state$, zeniAPI) => actions
         base_txn_account_ids: downloadCategories,
         sort_by: 'transaction_date',
         sort_order: 'desc',
-        filter: statusFilter,
+        filter: 'all',
     };
     return zeniAPI
         .getJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/schedules/download?query=${encodeURIComponent(JSON.stringify(queryParam))}`)

package/lib/esm/view/scheduleView/scheduleListView/scheduleListReducer.js

@@ -84,8 +84,8 @@ const scheduleListView = createSlice({
     reducers: {
         fetchDownloadSchedules: {
             reducer(draft, action) {
-                // Accrued is not downloaded through this action -- see fetchDownloadSchedulesEpic for why.
                 if (action.payload.scheduleType !== 'accrued_expenses') {
+                    //if condition added for type narrowing
                     const state = getState(draft, action.payload.scheduleType);
                     const selectedTimeframe = action.payload.timeframeAndCategory.selectedTimeframe;
                     const selectedCategoryId = action.payload.timeframeAndCategory.selectedCategoryId;
@@ -109,14 +109,13 @@ const scheduleListView = createSlice({
                     updateState(draft, action.payload.scheduleType, state);
                 }
             },
-            prepare(scheduleType, timeframeAndCategory, downloadCategories, statusFilter = 'all', cacheOverride = false) {
+            prepare(scheduleType, timeframeAndCategory, downloadCategories, cacheOverride = false) {
                 return {
                     payload: {
                         timeframeAndCategory,
                         scheduleType,
                         cacheOverride,
                         downloadCategories,
-                        statusFilter,
                     },
                 };
             },
@@ -152,13 +151,12 @@ const scheduleListView = createSlice({
                     updateState(draft, action.payload.scheduleType, state);
                 }
             },
-            prepare(scheduleType, timeframeAndCategory, cacheOverride = false, statusFilter = 'all') {
+            prepare(scheduleType, timeframeAndCategory, cacheOverride = false) {
                 return {
                     payload: {
                         timeframeAndCategory,
                         scheduleType,
                         cacheOverride,
-                        statusFilter,
                     },
                 };
             },