@zeniai/client-epic-state 5.2.7-betaRD1 → 5.2.8

package/lib/view/invoicing/invoicingQboView/epics/fetchInvoicingAccountingPickersEpic.js

@@ -12,12 +12,17 @@ const invoicingQboViewSelector_1 = require("../invoicingQboViewSelector");
 const fetchInvoicingAccountingPickersEpic = (actions$, state$) => actions$.pipe((0, operators_1.filter)(invoicingQboViewReducer_1.fetchInvoicingAccountingPickers.match), (0, operators_1.withLatestFrom)(state$), (0, operators_1.mergeMap)(([, state]) => {
     const actions = [];
     const accountList = state.accountListState.byReportId[invoicingQboViewSelector_1.INVOICING_ACCOUNT_LIST_KEY];
-    if (accountList.hasValidState() === false &&
+    // `hasValidState` only reports that a fetch finished, not that it
+    // returned anything usable. The shared bucket can be Completed and empty
+    // because a screen that needs fewer accounts filled it first, which would
+    // leave the invoicing pickers empty with no request in flight to fix it.
+    const isAccountListUsable = accountList.hasValidState() && accountList.accountIds.length > 0;
+    if (isAccountListUsable === false &&
         accountList.fetchState !== 'In-Progress') {
-        // AP/AR accounts cannot back an invoicing mapping, so they are excluded
-        // here — which is why this uses invoicing's own bucket rather than the
-        // general `accountList` other screens fill without those exclusions.
-        actions.push((0, accountListReducer_1.fetchAccountList)(invoicingQboViewSelector_1.INVOICING_ACCOUNT_LIST_KEY, true, true, true));
+        // Same arguments the vendor and categorization screens pass, so this
+        // shares their cached list rather than replacing it with a narrower one.
+        // Invoicing narrows to income accounts when it builds its options.
+        actions.push((0, accountListReducer_1.fetchAccountList)(invoicingQboViewSelector_1.INVOICING_ACCOUNT_LIST_KEY, true));
     }
     const classList = state.classListState;
     if (classList.hasValidState() === false &&

package/lib/view/invoicing/invoicingQboView/invoicingQboViewSelector.d.ts

@@ -4,9 +4,17 @@ import { FetchStateAndError } from '../../../commonStateTypes/common';
 import { AccountType } from '../../../entity/account/accountState';
 import { RootState } from '../../../rootStateTypes';
 import { InvoicingQboConnection, InvoicingQboSyncHealth } from './invoicingQboViewPayload';
-export declare const INVOICING_ACCOUNT_LIST_KEY: "invoicingAccountList";
+export declare const INVOICING_ACCOUNT_LIST_KEY: "accountList";
 /** Whether QBO is connected, without building the option lists to find out. */
 export declare const isInvoicingQboConnected: (state: RootState) => boolean;
+/**
+ * Whether the accounting pickers are still waiting on their data. Only true when
+ * QBO is connected: a tenant without it has no pickers to populate, so the form
+ * must not sit behind a skeleton waiting for lists it will never show.
+ */
+export declare const isInvoicingAccountingPickerDataLoading: (state: RootState) => boolean;
+/** The QBO connection fetch on its own, without building the bundled view. */
+export declare const getInvoicingQboConnectionFetchState: (state: RootState) => FetchStateAndError;
 /**
  * Account types that can back invoicing revenue. Named here so screens ask for
  * "income accounts" rather than repeating the accounting service's vocabulary.

package/lib/view/invoicing/invoicingQboView/invoicingQboViewSelector.js

@@ -1,14 +1,40 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getInvoicingQboView = exports.invoicingAccountHierarchyForTypes = exports.invoicingAccountsForQboAccountTypes = exports.INVOICING_INCOME_ACCOUNT_TYPES = exports.isInvoicingQboConnected = exports.INVOICING_ACCOUNT_LIST_KEY = void 0;
+exports.getInvoicingQboView = exports.invoicingAccountHierarchyForTypes = exports.invoicingAccountsForQboAccountTypes = exports.INVOICING_INCOME_ACCOUNT_TYPES = exports.getInvoicingQboConnectionFetchState = exports.isInvoicingAccountingPickerDataLoading = exports.isInvoicingQboConnected = exports.INVOICING_ACCOUNT_LIST_KEY = void 0;
 const accountListSelector_1 = require("../../accountList/accountListSelector");
 const classListSelector_1 = require("../../classList/classListSelector");
-// Its own bucket: invoicing needs the AP/AR exclusions that the vendor and
-// transaction screens sharing `accountList` do not pass.
-exports.INVOICING_ACCOUNT_LIST_KEY = 'invoicingAccountList';
+// The shared bucket, fetched with the same arguments as the other consumers so
+// whichever screen loads first satisfies the rest. Invoicing narrows to income
+// accounts when it builds its options, so it does not need its own copy.
+exports.INVOICING_ACCOUNT_LIST_KEY = 'accountList';
 /** Whether QBO is connected, without building the option lists to find out. */
 const isInvoicingQboConnected = (state) => state.invoicingQboViewState.connection?.connected === true;
 exports.isInvoicingQboConnected = isInvoicingQboConnected;
+/**
+ * Whether the accounting pickers are still waiting on their data. Only true when
+ * QBO is connected: a tenant without it has no pickers to populate, so the form
+ * must not sit behind a skeleton waiting for lists it will never show.
+ */
+const isInvoicingAccountingPickerDataLoading = (state) => {
+    const isPending = (fetchState) => fetchState === 'Not-Started' || fetchState === 'In-Progress';
+    // The connection settles first and decides whether the lists are fetched at
+    // all, so it counts as loading too. Reporting "not loading" while it is in
+    // flight renders the form, then takes it away again the moment the tenant
+    // turns out to be connected.
+    if (isPending((0, exports.getInvoicingQboConnectionFetchState)(state).fetchState)) {
+        return true;
+    }
+    if (!(0, exports.isInvoicingQboConnected)(state)) {
+        return false;
+    }
+    const accountList = state.accountListState.byReportId[exports.INVOICING_ACCOUNT_LIST_KEY];
+    return (isPending(accountList.fetchState) ||
+        isPending(state.classListState.fetchState));
+};
+exports.isInvoicingAccountingPickerDataLoading = isInvoicingAccountingPickerDataLoading;
+/** The QBO connection fetch on its own, without building the bundled view. */
+const getInvoicingQboConnectionFetchState = (state) => state.invoicingQboViewState.connectionFetchState;
+exports.getInvoicingQboConnectionFetchState = getInvoicingQboConnectionFetchState;
 /**
  * Account types that can back invoicing revenue. Named here so screens ask for
  * "income accounts" rather than repeating the accounting service's vocabulary.

package/lib/view/invoicing/settingsView/settingsViewSelector.d.ts

@@ -1,7 +1,7 @@
 import { FetchState, FetchStateAndError } from '../../../commonStateTypes/common';
 import { InvoicingDunningActionOption, InvoicingNamedOption, InvoicingQboAccountMappingKindOption, InvoicingSettingsPayload } from '../../../entity/invoicing/invoicingCommonPayload';
-import { RootState } from '../../../rootStateTypes';
 import { ZeniAPIStatus } from '../../../responsePayload';
+import { RootState } from '../../../rootStateTypes';
 import { InvoicingBrandingFormLocalData } from './invoicingBrandingFormConfig';
 /**
  * Shared primitive: the raw invoicing settings. Consumed internally by other
@@ -53,6 +53,12 @@ export interface InvoicingSettingsHubView {
     configFetchState: FetchState;
     dunningScheduleActionOptions: InvoicingDunningActionOption[];
     isEnablingInvoicing: boolean;
+    /**
+     * Whether the tenant has already enabled invoicing. The enable footer is for
+     * tenants that have not, so this — not `canEnableInvoicing` — decides whether
+     * it renders at all.
+     */
+    isInvoicingEnabled: boolean;
     isQboConfigured: boolean;
     isStripeConnected: boolean;
     qboAccountMappingKindOptions: InvoicingQboAccountMappingKindOption[];
@@ -67,9 +73,10 @@ export interface InvoicingSettingsHubView {
  * two integration prerequisites kept separate so the hub can name the step still
  * outstanding instead of showing a dead button.
  *
- * `canEnableInvoicing` folds in the onboarding step, so the screen does not need
- * to re-check it: the footer is only offered mid-onboarding and only once both
- * integrations are ready.
+ * `isInvoicingEnabled` decides whether the footer renders; `canEnableInvoicing`
+ * whether its button is live, and it still requires the onboarding step so the
+ * terms cannot be skipped. A tenant partway through therefore sees the footer,
+ * disabled and naming what is left, rather than nothing at all.
  *
  * Deliberately not folded into `getInvoicingConfigView`: that selector gates
  * every invoicing route and stays a pure read of the config slice. The settings

package/lib/view/invoicing/settingsView/settingsViewSelector.js

@@ -70,9 +70,10 @@ function deriveInvoicingEnablePrerequisites(settings, isQboConnected, qboAccount
  * two integration prerequisites kept separate so the hub can name the step still
  * outstanding instead of showing a dead button.
  *
- * `canEnableInvoicing` folds in the onboarding step, so the screen does not need
- * to re-check it: the footer is only offered mid-onboarding and only once both
- * integrations are ready.
+ * `isInvoicingEnabled` decides whether the footer renders; `canEnableInvoicing`
+ * whether its button is live, and it still requires the onboarding step so the
+ * terms cannot be skipped. A tenant partway through therefore sees the footer,
+ * disabled and naming what is left, rather than nothing at all.
  *
  * Deliberately not folded into `getInvoicingConfigView`: that selector gates
  * every invoicing route and stays a pure read of the config slice. The settings
@@ -82,7 +83,10 @@ const getInvoicingSettingsHubView = (state) => {
     const { dunningScheduleActionOptions, enableState, error: configError, fetchState: configFetchState, qboAccountMappingKindOptions, qboCustomerMatchingOptions, qboSyncStatusOptions, status, } = (0, invoicingConfigViewSelector_1.getInvoicingConfigView)(state);
     const { canEnable, isQboConfigured, isStripeConnected } = deriveInvoicingEnablePrerequisites(state.invoicingSettingsViewState.settings, state.invoicingQboViewState.connection?.connected === true, qboAccountMappingKindOptions);
     return {
+        // Keeps the onboarding step in the gate: a tenant that has not accepted the
+        // terms cannot enable invoicing, whatever the integrations say.
         canEnableInvoicing: status === 'settings' && canEnable,
+        isInvoicingEnabled: state.invoicingConfigViewState.isInvoicingEnabled === true,
         configError,
         configFetchState,
         dunningScheduleActionOptions,

package/lib/view/scheduleView/scheduleListView/epics/fetchAccruedScheduleListEpic.js

@@ -33,7 +33,7 @@ const fetchAccruedScheduleListEpic = (actions$, state$, zeniAPI) => actions$.pip
         je_schedule_type: scheduleType,
         sort_by: 'transaction_date',
         sort_order: 'desc',
-        filter: action.payload.statusFilter,
+        filter: 'all',
     };
     return zeniAPI
         .getJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/schedules?query=${encodeURIComponent(JSON.stringify(queryParam))}`)

package/lib/view/scheduleView/scheduleListView/epics/fetchDownloadSchedulesEpic.js

@@ -10,14 +10,9 @@ const responsePayload_1 = require("../../../../responsePayload");
 const scheduleListReducer_1 = require("../scheduleListReducer");
 const scheduleListTypes_1 = require("../scheduleListTypes");
 const fetchDownloadSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(scheduleListReducer_1.fetchDownloadSchedules.match), (0, operators_1.mergeMap)((action) => {
-    const { scheduleType, downloadCategories, statusFilter } = action.payload;
+    const { scheduleType, downloadCategories } = action.payload;
     const scheduleListState = state$.value.scheduleListState;
     // if parameters are provided, use those. else go to localdata
-    // Accrued is deliberately not served here. Its rows come back in a different shape, this
-    // epic writes them through updateJESchedules (the prepaid / fixed mapper), and
-    // doUpdateScheduleList never flips downloadState for accrued -- so a request would store the
-    // wrong data and then never report completion. Accrued downloads go through
-    // fetchAccruedScheduleList, which owns that shape end to end.
     let scheduleState;
     if (scheduleType !== 'accrued_expenses') {
         scheduleState = (0, scheduleListReducer_1.getState)(scheduleListState, scheduleType);
@@ -42,7 +37,7 @@ const fetchDownloadSchedulesEpic = (actions$, state$, zeniAPI) => actions$.pipe(
         base_txn_account_ids: downloadCategories,
         sort_by: 'transaction_date',
         sort_order: 'desc',
-        filter: statusFilter,
+        filter: 'all',
     };
     return zeniAPI
         .getJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/schedules/download?query=${encodeURIComponent(JSON.stringify(queryParam))}`)

package/lib/view/scheduleView/scheduleListView/scheduleListReducer.d.ts

@@ -16,7 +16,7 @@ export declare const initialState: ScheduleListViewState;
 export declare const fetchDownloadSchedules: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[scheduleType: "prepaid_expenses" | "fixed_assets" | "accrued_expenses" | "deferred_revenue", timeframeAndCategory: {
     selectedCategoryId: ID;
     selectedTimeframe: TimeframeTick;
-}, downloadCategories: string[], statusFilter?: "completed" | "new" | "ongoing" | "all" | undefined, cacheOverride?: any], {
+}, downloadCategories: string[], cacheOverride?: any], {
     timeframeAndCategory: {
         selectedCategoryId: ID;
         selectedTimeframe: TimeframeTick;
@@ -24,18 +24,16 @@ export declare const fetchDownloadSchedules: import("@reduxjs/toolkit").ActionCr
     scheduleType: "prepaid_expenses" | "fixed_assets" | "accrued_expenses" | "deferred_revenue";
     cacheOverride: any;
     downloadCategories: string[];
-    statusFilter: "completed" | "new" | "ongoing" | "all";
 }, "scheduleListView/fetchDownloadSchedules", never, never>, fetchAccruedScheduleList: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[scheduleType: "prepaid_expenses" | "fixed_assets" | "accrued_expenses" | "deferred_revenue", timeframeAndCategory?: {
     selectedCategoryId: ID;
     selectedTimeframe: TimeframeTick;
-} | undefined, cacheOverride?: any, statusFilter?: "completed" | "new" | "ongoing" | "all" | undefined], {
+} | undefined, cacheOverride?: any], {
     timeframeAndCategory: {
         selectedCategoryId: ID;
         selectedTimeframe: TimeframeTick;
     } | undefined;
     scheduleType: "prepaid_expenses" | "fixed_assets" | "accrued_expenses" | "deferred_revenue";
     cacheOverride: any;
-    statusFilter: "completed" | "new" | "ongoing" | "all";
 }, "scheduleListView/fetchAccruedScheduleList", never, never>, fetchScheduleList: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[scheduleType: "prepaid_expenses" | "fixed_assets" | "accrued_expenses" | "deferred_revenue", timeframeAndCategory?: {
     selectedCategoryId: ID;
     selectedTimeframe: TimeframeTick;

package/lib/view/scheduleView/scheduleListView/scheduleListReducer.js

@@ -90,8 +90,8 @@ const scheduleListView = (0, toolkit_1.createSlice)({
     reducers: {
         fetchDownloadSchedules: {
             reducer(draft, action) {
-                // Accrued is not downloaded through this action -- see fetchDownloadSchedulesEpic for why.
                 if (action.payload.scheduleType !== 'accrued_expenses') {
+                    //if condition added for type narrowing
                     const state = getState(draft, action.payload.scheduleType);
                     const selectedTimeframe = action.payload.timeframeAndCategory.selectedTimeframe;
                     const selectedCategoryId = action.payload.timeframeAndCategory.selectedCategoryId;
@@ -115,14 +115,13 @@ const scheduleListView = (0, toolkit_1.createSlice)({
                     updateState(draft, action.payload.scheduleType, state);
                 }
             },
-            prepare(scheduleType, timeframeAndCategory, downloadCategories, statusFilter = 'all', cacheOverride = false) {
+            prepare(scheduleType, timeframeAndCategory, downloadCategories, cacheOverride = false) {
                 return {
                     payload: {
                         timeframeAndCategory,
                         scheduleType,
                         cacheOverride,
                         downloadCategories,
-                        statusFilter,
                     },
                 };
             },
@@ -158,13 +157,12 @@ const scheduleListView = (0, toolkit_1.createSlice)({
                     updateState(draft, action.payload.scheduleType, state);
                 }
             },
-            prepare(scheduleType, timeframeAndCategory, cacheOverride = false, statusFilter = 'all') {
+            prepare(scheduleType, timeframeAndCategory, cacheOverride = false) {
                 return {
                     payload: {
                         timeframeAndCategory,
                         scheduleType,
                         cacheOverride,
-                        statusFilter,
                     },
                 };
             },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.7-betaRD1",
+  "version": "5.2.8",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",

package/lib/commonStateTypes/selectorTypes/pickAndMergeForecastSection.js

@@ -1 +0,0 @@
-"use strict";

package/lib/entity/invoicing/coupon/couponConstants.d.ts

@@ -1,11 +0,0 @@
-import { InvoicingFormOption } from '../invoicingCommonPayload';
-import { InvoicingCouponApplyOn, InvoicingCouponDurationType, InvoicingCouponPeriodUnit, InvoicingDiscountType } from './couponPayload';
-/**
- * Coupon form select options. Single source of truth (CES-owned) for the value
- * sets that back the coupon's string-union domain fields; surfaced to the form
- * via `getInvoicingCouponFormView` so web-components need not hardcode them.
- */
-export declare const INVOICING_DISCOUNT_TYPE_OPTIONS: readonly InvoicingFormOption<InvoicingDiscountType>[];
-export declare const INVOICING_COUPON_DURATION_TYPE_OPTIONS: readonly InvoicingFormOption<InvoicingCouponDurationType>[];
-export declare const INVOICING_COUPON_PERIOD_UNIT_OPTIONS: readonly InvoicingFormOption<InvoicingCouponPeriodUnit>[];
-export declare const INVOICING_COUPON_APPLY_ON_OPTIONS: readonly InvoicingFormOption<InvoicingCouponApplyOn>[];

package/lib/entity/invoicing/coupon/couponConstants.js

@@ -1,29 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.INVOICING_COUPON_APPLY_ON_OPTIONS = exports.INVOICING_COUPON_PERIOD_UNIT_OPTIONS = exports.INVOICING_COUPON_DURATION_TYPE_OPTIONS = exports.INVOICING_DISCOUNT_TYPE_OPTIONS = void 0;
-/**
- * Coupon form select options. Single source of truth (CES-owned) for the value
- * sets that back the coupon's string-union domain fields; surfaced to the form
- * via `getInvoicingCouponFormView` so web-components need not hardcode them.
- */
-exports.INVOICING_DISCOUNT_TYPE_OPTIONS = [
-    { label: 'Percentage', value: 'percentage' },
-    { label: 'Fixed amount', value: 'fixed_amount' },
-    { label: 'Offer quantity', value: 'offer_quantity' },
-];
-exports.INVOICING_COUPON_DURATION_TYPE_OPTIONS = [
-    { label: 'One time', value: 'one_time' },
-    { label: 'Forever', value: 'forever' },
-    { label: 'Limited period', value: 'limited_period' },
-];
-exports.INVOICING_COUPON_PERIOD_UNIT_OPTIONS = [
-    { label: 'Day', value: 'day' },
-    { label: 'Week', value: 'week' },
-    { label: 'Month', value: 'month' },
-    { label: 'Year', value: 'year' },
-];
-exports.INVOICING_COUPON_APPLY_ON_OPTIONS = [
-    { label: 'Invoice amount', value: 'invoice_amount' },
-    { label: 'Each specified item', value: 'each_specified_item' },
-    { label: 'Specified items total', value: 'specified_items_total' },
-];

package/lib/esm/commonStateTypes/selectorTypes/pickAndMergeForecastSection.js

@@ -1 +0,0 @@
-"use strict";

package/lib/esm/entity/invoicing/coupon/couponConstants.js

@@ -1,26 +0,0 @@
-/**
- * Coupon form select options. Single source of truth (CES-owned) for the value
- * sets that back the coupon's string-union domain fields; surfaced to the form
- * via `getInvoicingCouponFormView` so web-components need not hardcode them.
- */
-export const INVOICING_DISCOUNT_TYPE_OPTIONS = [
-    { label: 'Percentage', value: 'percentage' },
-    { label: 'Fixed amount', value: 'fixed_amount' },
-    { label: 'Offer quantity', value: 'offer_quantity' },
-];
-export const INVOICING_COUPON_DURATION_TYPE_OPTIONS = [
-    { label: 'One time', value: 'one_time' },
-    { label: 'Forever', value: 'forever' },
-    { label: 'Limited period', value: 'limited_period' },
-];
-export const INVOICING_COUPON_PERIOD_UNIT_OPTIONS = [
-    { label: 'Day', value: 'day' },
-    { label: 'Week', value: 'week' },
-    { label: 'Month', value: 'month' },
-    { label: 'Year', value: 'year' },
-];
-export const INVOICING_COUPON_APPLY_ON_OPTIONS = [
-    { label: 'Invoice amount', value: 'invoice_amount' },
-    { label: 'Each specified item', value: 'each_specified_item' },
-    { label: 'Specified items total', value: 'specified_items_total' },
-];

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/fetchOneTimeAccrualEpic.js

@@ -1,45 +0,0 @@
-import { from } from 'rxjs';
-import { catchError, filter, mergeMap, takeUntil } from 'rxjs/operators';
-import { updateJEOneTimeAccruals } from '../../../../entity/jeSchedules/jeSchedulesReducer';
-import { createZeniAPIStatus, isSuccessResponse, } from '../../../../responsePayload';
-import { clearAll } from '../../../../rootActions';
-import { fetchOneTimeAccrual, fetchOneTimeAccrualFailure, fetchOneTimeAccrualSuccess, } from '../../reducers/jeSchedulesViewReducer';
-/**
- * Read one accrual by id so its detail page can render from a URL alone.
- *
- * Every other row on this page arrives with the JE Schedules list, and the accrual detail page used
- * to render only from what that list had already put in the store -- so opening its URL directly, on
- * a refresh or a shared link, had nothing to render and showed not-found. This is the read that
- * makes the URL self-sufficient.
- *
- * The response is the same `{accrual}` envelope promote / ignore / revert return, and it goes through
- * the same `updateJEOneTimeAccruals`, so a page loaded cold holds exactly the entity a page reached
- * through the list holds.
- */
-export const fetchOneTimeAccrualEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(fetchOneTimeAccrual.match), mergeMap((action) => {
-    const { accrualId } = action.payload;
-    return zeniAPI
-        .getJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/accruals/${accrualId}`)
-        .pipe(mergeMap((response) => {
-        if (isSuccessResponse(response) && response.data != null) {
-            return from([
-                updateJEOneTimeAccruals([response.data.accrual]),
-                fetchOneTimeAccrualSuccess({ accrualId }),
-            ]);
-        }
-        // A deleted or ignored accrual answers 404 here, the same as an id that never existed.
-        // Both end as an error state the page turns into not-found, rather than a spinner that
-        // never resolves.
-        return from([
-            fetchOneTimeAccrualFailure({ accrualId, status: response.status }),
-        ]);
-    }), catchError((error) => from([
-        fetchOneTimeAccrualFailure({
-            accrualId,
-            status: createZeniAPIStatus('Unexpected Error', `Fetch one-time accrual REST API call errored out ${JSON.stringify(error)}`),
-        }),
-    ])), 
-    // A tenant switch clears the store while this request is in flight. Without this the old
-    // tenant's accrual is written back into the freshly cleared store.
-    takeUntil(actions$.pipe(filter(clearAll.match))));
-}));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/newSchedule/createOneTimeAccrualEpic.js

@@ -1,81 +0,0 @@
-import { from } from 'rxjs';
-import { catchError, filter, mergeMap } from 'rxjs/operators';
-import { convertToPeriod, toAbsoluteDay, } from '../../../../../commonStateTypes/timePeriod';
-import { updateJEOneTimeAccruals } from '../../../../../entity/jeSchedules/jeSchedulesReducer';
-import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
-import { getCurrentTenant } from '../../../../../entity/tenant/tenantSelector';
-import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
-import { prepareCreateOneTimeAccrualPayload, } from '../../../payload/jeSchedulesPayload';
-import { createOneTimeAccrual, createOneTimeAccrualFailure, createOneTimeAccrualSuccess, fetchJeSchedules, } from '../../../reducers/jeSchedulesViewReducer';
-export const createOneTimeAccrualEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(createOneTimeAccrual.match), mergeMap((action) => {
-    const state = state$.value;
-    const { localData } = action.payload;
-    const payload = { ...prepareCreateOneTimeAccrualPayload(state, localData) };
-    // convertToPeriod destructures, so an unset period would throw here and take the epic
-    // subscription down for the whole session — a missed refresh is the cheaper failure.
-    const selectedMonthYear = state.expenseAutomationViewState.selectedPeriodByTenantId[getCurrentTenant(state).tenantId];
-    const selectedPeriod = selectedMonthYear != null
-        ? convertToPeriod(selectedMonthYear)
-        : undefined;
-    const periodStart = selectedPeriod != null
-        ? toAbsoluteDay(selectedPeriod.start)
-        : undefined;
-    const periodEnd = selectedPeriod != null ? toAbsoluteDay(selectedPeriod.end) : undefined;
-    return zeniAPI
-        .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/accruals`, payload)
-        .pipe(mergeMap((response) => {
-        if (isSuccessResponse(response) && response.data != null) {
-            const successActions = [
-                updateJEOneTimeAccruals([response.data.accrual]),
-                createOneTimeAccrualSuccess(),
-                openSnackbar({
-                    messageSection: 'create_schedule',
-                    messageText: 'success',
-                    type: 'success',
-                    variables: [
-                        {
-                            variableName: '_vendor_name_',
-                            variableValue: localData.vendorName,
-                        },
-                    ],
-                }),
-            ];
-            // The tab buckets (jeScheduleOneTimeAccrualKeysByPeriodAndTab) are rebuilt wholesale
-            // per fetch, and the backend decides whether a freshly posted accrual belongs to
-            // Review or Existing — so refetch rather than guess which bucket to insert into.
-            if (periodStart != null && periodEnd != null) {
-                successActions.push(fetchJeSchedules({ start: periodStart, end: periodEnd }, true));
-            }
-            return from(successActions);
-        }
-        return from([
-            createOneTimeAccrualFailure({ status: response.status }),
-            openSnackbar({
-                messageSection: 'create_schedule',
-                messageText: 'failed',
-                type: 'error',
-                variables: [
-                    {
-                        variableName: '_api-error_',
-                        variableValue: response.status.message,
-                    },
-                ],
-            }),
-        ]);
-    }), catchError((error) => from([
-        openSnackbar({
-            messageSection: 'create_schedule',
-            messageText: 'failed',
-            type: 'error',
-            variables: [
-                {
-                    variableName: '_api-error_',
-                    variableValue: JSON.stringify(error),
-                },
-            ],
-        }),
-        createOneTimeAccrualFailure({
-            status: createZeniAPIStatus('Unexpected Error', `Create One Time Accrual REST API call errored out ${JSON.stringify(error)}`),
-        }),
-    ])));
-}));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/newSchedule/initializeNewScheduleEpic.js

@@ -1,25 +0,0 @@
-import { from } from 'rxjs';
-import { filter, mergeMap } from 'rxjs/operators';
-import { fetchAccountList } from '../../../../accountList/accountListReducer';
-import { fetchClassList } from '../../../../classList/classListReducer';
-import { getAccountsTypesForScheduleEpics } from '../../../../scheduleView/scheduleListView/scheduleListHelper';
-import { clearSearchTransactionsForNewSchedule, initializeNewSchedule, resetNewScheduleLocalData, } from '../../../reducers/jeSchedulesViewReducer';
-export const initializeNewScheduleEpic = (actions$, state$) => actions$.pipe(filter(initializeNewSchedule.match), mergeMap((action) => {
-    const newScheduleActions = [];
-    const accountType = getAccountsTypesForScheduleEpics();
-    const { accountListState, classListState } = state$.value;
-    if (accountListState.byReportId[accountType.accountListKey]?.fetchState ===
-        'Not-Started') {
-        newScheduleActions.push(fetchAccountList(accountType.accountListKey, true, false, false, false, accountType.allowedAccountList));
-    }
-    if (classListState.fetchState === 'Not-Started') {
-        newScheduleActions.push(fetchClassList());
-    }
-    // The account and class fetches above are idempotent (both guard on 'Not-Started'), so they
-    // can run on every open. Clearing what the user entered cannot, so it is opt-in.
-    if (action.payload.shouldResetEnteredData) {
-        newScheduleActions.push(resetNewScheduleLocalData({ scheduleType: action.payload.scheduleType }));
-        newScheduleActions.push(clearSearchTransactionsForNewSchedule());
-    }
-    return from(newScheduleActions);
-}));

package/lib/esm/view/expenseAutomationView/epics/jeSchedule/newSchedule/saveNewScheduleEpic.js

@@ -1,110 +0,0 @@
-import { from } from 'rxjs';
-import { catchError, filter, mergeMap } from 'rxjs/operators';
-import { updateJESchedules, updateJESchedulesDetails, } from '../../../../../entity/jeSchedules/jeSchedulesReducer';
-import { getJEScheduleTransactionKey } from '../../../../../entity/jeSchedules/jeSchedulesTypes';
-import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
-import { getScheduleTransactionById } from '../../../../../entity/transaction/transactionSelector';
-import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
-import { prepareNewSchedulePayload, } from '../../../helpers/newScheduleLocalDataHelper';
-import { resetNewScheduleLocalData, saveNewSchedule, saveNewScheduleFailure, saveNewScheduleSuccess, } from '../../../reducers/jeSchedulesViewReducer';
-const FAILURE_REASON_MESSAGES = {
-    missing_third_party_id: 'This transaction is missing a QuickBooks reference and cannot be scheduled.',
-    missing_vendor: 'Select a vendor before saving this schedule.',
-};
-export const saveNewScheduleEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveNewSchedule.match), mergeMap((action) => {
-    const { scheduleType } = action.payload;
-    const state = state$.value;
-    const localData = state.expenseAutomationJESchedulesViewState.newSchedule
-        .newScheduleState[scheduleType];
-    const { selectedBaseTransactionId } = localData;
-    const transaction = selectedBaseTransactionId != null
-        ? getScheduleTransactionById(state.transactionState, getJEScheduleTransactionKey(selectedBaseTransactionId))
-        : undefined;
-    if (transaction == null) {
-        return from([
-            saveNewScheduleFailure({
-                status: createZeniAPIStatus('Unexpected Error', 'No base transaction selected for this schedule.'),
-            }),
-            openSnackbar({
-                messageSection: 'create_schedule',
-                messageText: 'failed',
-                type: 'error',
-                variables: [
-                    {
-                        variableName: '_api-error_',
-                        variableValue: 'No base transaction selected.',
-                    },
-                ],
-            }),
-        ]);
-    }
-    const result = prepareNewSchedulePayload(transaction, localData, scheduleType);
-    if (!result.ok) {
-        const message = FAILURE_REASON_MESSAGES[result.reason];
-        return from([
-            saveNewScheduleFailure({
-                status: createZeniAPIStatus('Unexpected Error', message),
-            }),
-            openSnackbar({
-                messageSection: 'create_schedule',
-                messageText: 'failed',
-                type: 'error',
-                variables: [{ variableName: '_api-error_', variableValue: message }],
-            }),
-        ]);
-    }
-    const vendorName = localData.selectedVendor?.name ?? transaction.vendorName ?? '';
-    const queryParam = {
-        je_schedule_type: scheduleType,
-    };
-    const payload = { ...result.payload };
-    return zeniAPI
-        .postAndGetJSON(`${zeniAPI.apiEndPoints.accountMicroServiceBaseUrl}/1.0/schedules?query=${encodeURIComponent(JSON.stringify(queryParam))}`, payload)
-        .pipe(mergeMap((response) => {
-        if (isSuccessResponse(response) && response.data != null) {
-            return from([
-                updateJESchedules(response.data.je_schedules),
-                updateJESchedulesDetails(response.data.je_schedules, response.data.scheduled_journal_entries),
-                resetNewScheduleLocalData({ scheduleType }),
-                saveNewScheduleSuccess(),
-                openSnackbar({
-                    messageSection: 'create_schedule',
-                    messageText: 'success',
-                    type: 'success',
-                    variables: [
-                        { variableName: '_vendor_name_', variableValue: vendorName },
-                    ],
-                }),
-            ]);
-        }
-        return from([
-            saveNewScheduleFailure({ status: response.status }),
-            openSnackbar({
-                messageSection: 'create_schedule',
-                messageText: 'failed',
-                type: 'error',
-                variables: [
-                    {
-                        variableName: '_api-error_',
-                        variableValue: response.status.message,
-                    },
-                ],
-            }),
-        ]);
-    }), catchError((error) => from([
-        openSnackbar({
-            messageSection: 'create_schedule',
-            messageText: 'failed',
-            type: 'error',
-            variables: [
-                {
-                    variableName: '_api-error_',
-                    variableValue: JSON.stringify(error),
-                },
-            ],
-        }),
-        saveNewScheduleFailure({
-            status: createZeniAPIStatus('Unexpected Error', `Save New Schedule REST API call errored out ${JSON.stringify(error)}`),
-        }),
-    ])));
-}));