@zeniai/client-epic-state 5.2.32 → 5.2.34-beta0ND

package/lib/view/expenseAutomationView/selectors/missingReceiptsSelector.js

@@ -5,7 +5,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getExpenseAutomationMissingReceiptsView = getExpenseAutomationMissingReceiptsView;
 const orderBy_1 = __importDefault(require("lodash/orderBy"));
-const reduceFetchState_1 = require("../../../commonStateTypes/reduceFetchState");
 const timePeriod_1 = require("../../../commonStateTypes/timePeriod");
 const tenantSelector_1 = require("../../../entity/tenant/tenantSelector");
 const transactionSelector_1 = require("../../../entity/transaction/transactionSelector");
@@ -14,7 +13,7 @@ const missingReceiptsViewReducer_1 = require("../reducers/missingReceiptsViewRed
 const missingReceiptsViewState_1 = require("../types/missingReceiptsViewState");
 const getAllStepsHelper_1 = require("./getAllStepsHelper");
 function getExpenseAutomationMissingReceiptsView(state) {
-    const { expenseAutomationMissingReceiptsViewState, expenseAutomationViewState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
+    const { expenseAutomationMissingReceiptsViewState, expenseAutomationViewState, transactionState, monthEndCloseChecksState, } = state;
     const currentTenant = (0, tenantSelector_1.getCurrentTenant)(state);
     const { selectedPeriodByTenantId } = expenseAutomationViewState;
     const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
@@ -182,16 +181,16 @@ function getExpenseAutomationMissingReceiptsView(state) {
             vendorLogo: result.vendorLogo ?? transaction?.logo?.href,
         };
     });
-    const monthEndFetchState = monthYearPeriodId != null
-        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
-        : { fetchState: 'Not-Started', error: undefined };
-    const reducedFetchStatus = (0, reduceFetchState_1.reduceAnyFetchState)([
-        { fetchState, error },
-        monthEndFetchState,
-    ]);
+    // `fetchState` is a flat slice field that survives a period switch, so it still reads
+    // 'Completed' before the newly selected period's ids land. Reporting 'Not-Started' until they
+    // do keeps the skeleton up instead of flashing the "all done" empty state over the previous
+    // period's rows.
+    const fetchStatus = fetchState === 'Completed' && transactionIdsForSelectedPeriod == null
+        ? { fetchState: 'Not-Started', error: undefined }
+        : { fetchState, error };
     return {
-        fetchState: reducedFetchStatus.fetchState,
-        error: reducedFetchStatus.error,
+        fetchState: fetchStatus.fetchState,
+        error: fetchStatus.error,
         uploadReceiptStatusById,
         uiState,
         refreshStatus,

package/lib/view/invoicing/editInvoicingCustomerDetailView/editInvoicingCustomerDetailViewPayload.d.ts

@@ -1,7 +1,7 @@
 import { InvoicingCustomerPayload } from '../../../entity/invoicing/invoicingCustomer/invoicingCustomerPayload';
 import { ZeniAPIResponse } from '../../../responsePayload';
 import { AddressUpdatableInfo } from '../../addressView/addressViewState';
-import { InvoicingCustomerFormLocalData } from './editInvoicingCustomerDetailViewState';
+import { InvoicingCustomerFormLocalData, InvoicingPaymentLinkEmailPreviewData } from './editInvoicingCustomerDetailViewState';
 export type SaveInvoicingCustomerResponse = ZeniAPIResponse<InvoicingCustomerPayload>;
 /**
  * Build the create/update customer request body from the form draft. The
@@ -25,15 +25,5 @@ export type InvoicingPaymentLinkEmailPreviewResponse = ZeniAPIResponse<Invoicing
  * The email rendered once with sentinel tokens standing in for the subject and
  * body, so the composer can splice a draft into it without another request.
  */
-export interface InvoicingPaymentLinkEmailPreviewData {
-    /** Default body prefill, plain text. */
-    body: string;
-    bodyToken: string;
-    renderedHtmlTemplate: string;
-    /** Default subject prefill. */
-    subject: string;
-    subjectToken: string;
-    to: string;
-}
 export declare const toInvoicingPaymentLinkEmailPreview: (payload: InvoicingPaymentLinkEmailPreviewPayload) => InvoicingPaymentLinkEmailPreviewData;
 export type AddPromotionalCreditsResponse = ZeniAPIResponse<InvoicingCustomerPayload>;

package/lib/view/invoicing/editInvoicingCustomerDetailView/editInvoicingCustomerDetailViewPayload.js

@@ -34,6 +34,10 @@ const localDataToSaveInvoicingCustomerPayload = (localData, billingAddress) => {
     };
 };
 exports.localDataToSaveInvoicingCustomerPayload = localDataToSaveInvoicingCustomerPayload;
+/**
+ * The email rendered once with sentinel tokens standing in for the subject and
+ * body, so the composer can splice a draft into it without another request.
+ */
 const toInvoicingPaymentLinkEmailPreview = (payload) => ({
     body: payload.body,
     bodyToken: payload.body_token,

package/lib/view/invoicing/editInvoicingCustomerDetailView/editInvoicingCustomerDetailViewReducer.d.ts

@@ -1,7 +1,6 @@
 import { ID } from '../../../commonStateTypes/common';
 import { ZeniAPIStatus } from '../../../responsePayload';
-import { InvoicingPaymentLinkEmailPreviewData } from './editInvoicingCustomerDetailViewPayload';
-import { EditInvoicingCustomerDetailViewState, InvoicingCustomerFormLocalData } from './editInvoicingCustomerDetailViewState';
+import { EditInvoicingCustomerDetailViewState, InvoicingCustomerFormLocalData, InvoicingPaymentLinkEmailPreviewData } from './editInvoicingCustomerDetailViewState';
 /** Add promotional credits to a customer. */
 export interface SubmitAddPromotionalCreditsPayload {
     amount: number;

package/lib/view/invoicing/editInvoicingCustomerDetailView/editInvoicingCustomerDetailViewSelector.d.ts

@@ -5,8 +5,7 @@ import { InvoicingFieldHelpByCode, InvoicingNamedOption } from '../../../entity/
 import { InvoicingCustomer, InvoicingCustomerPaymentMethod } from '../../../entity/invoicing/invoicingCustomer/invoicingCustomerState';
 import { RootState } from '../../../rootStateTypes';
 import { InvoicingSetupIntent } from '../customerPaymentMethod/customerPaymentMethodState';
-import { InvoicingPaymentLinkEmailPreviewData } from './editInvoicingCustomerDetailViewPayload';
-import { InvoicingCustomerFormLocalData } from './editInvoicingCustomerDetailViewState';
+import { InvoicingCustomerFormLocalData, InvoicingPaymentLinkEmailPreviewData } from './editInvoicingCustomerDetailViewState';
 /**
  * Read-only view for the customer detail page: the customer entity + its fetch
  * state, plus everything the page renders in view mode — recent invoices, the

package/lib/view/invoicing/editInvoicingCustomerDetailView/editInvoicingCustomerDetailViewState.d.ts

@@ -1,5 +1,19 @@
 import { FetchStateAndError, FetchedState, ID } from '../../../commonStateTypes/common';
-import { InvoicingPaymentLinkEmailPreviewData } from './editInvoicingCustomerDetailViewPayload';
+/**
+ * The payment-link email the composer opens with: the backend's prefill plus
+ * the tokens the frontend splices the user's edits into. State, not wire shape
+ * — `toInvoicingPaymentLinkEmailPreview` in the payload file maps onto it.
+ */
+export interface InvoicingPaymentLinkEmailPreviewData {
+    /** Default body prefill, plain text. */
+    body: string;
+    bodyToken: string;
+    renderedHtmlTemplate: string;
+    /** Default subject prefill. */
+    subject: string;
+    subjectToken: string;
+    to: string;
+}
 /**
  * Draft form state for the create/edit customer form. Held in CES so the form
  * flows its data from here (mirrors the bill-pay / reimbursement pattern). The

package/lib/view/invoicing/invoicingCustomerListView/invoicingCustomerListViewReducer.d.ts

@@ -26,7 +26,7 @@ export declare const fetchInvoicingCustomerList: import("@reduxjs/toolkit").Acti
     ids: ID[];
     keepExistingListItems: boolean;
     nextCursor: string | null;
-}, "invoicingCustomerListView/updateInvoicingCustomerList">, updateInvoicingCustomerListFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingCustomerListView/updateInvoicingCustomerListFailure">, fetchInvoicingCustomerCounts: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingCustomerListView/fetchInvoicingCustomerCounts">, updateInvoicingCustomerCounts: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingListCounts, "invoicingCustomerListView/updateInvoicingCustomerCounts">, updateInvoicingCustomerCountsFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingCustomerListView/updateInvoicingCustomerCountsFailure">, updateInvoicingCustomerFilters: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingCustomerFilters, "invoicingCustomerListView/updateInvoicingCustomerFilters">, setInvoicingCustomerActiveTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"active" | "all" | "at_risk" | "trial", "invoicingCustomerListView/setInvoicingCustomerActiveTab">, addInvoicingCustomerToList: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
+}, "invoicingCustomerListView/updateInvoicingCustomerList">, updateInvoicingCustomerListFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingCustomerListView/updateInvoicingCustomerListFailure">, fetchInvoicingCustomerCounts: import("@reduxjs/toolkit").ActionCreatorWithoutPayload<"invoicingCustomerListView/fetchInvoicingCustomerCounts">, updateInvoicingCustomerCounts: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingListCounts, "invoicingCustomerListView/updateInvoicingCustomerCounts">, updateInvoicingCustomerCountsFailure: import("@reduxjs/toolkit").ActionCreatorWithPayload<ZeniAPIStatus<Record<string, unknown>>, "invoicingCustomerListView/updateInvoicingCustomerCountsFailure">, updateInvoicingCustomerFilters: import("@reduxjs/toolkit").ActionCreatorWithPayload<InvoicingCustomerFilters, "invoicingCustomerListView/updateInvoicingCustomerFilters">, setInvoicingCustomerActiveTab: import("@reduxjs/toolkit").ActionCreatorWithPayload<"active" | "all" | "trial" | "at_risk", "invoicingCustomerListView/setInvoicingCustomerActiveTab">, addInvoicingCustomerToList: import("@reduxjs/toolkit").ActionCreatorWithPayload<{
     id: ID;
     status?: string;
 }, "invoicingCustomerListView/addInvoicingCustomerToList">;

package/lib/view/invoicing/invoicingCustomerListView/invoicingCustomerListViewState.d.ts

@@ -20,7 +20,7 @@ export interface InvoicingCustomerColumnConfig {
 }
 export declare const INVOICING_CUSTOMER_COLUMNS: InvoicingCustomerColumnConfig[];
 export declare const ALL_INVOICING_CUSTOMER_TAB_IDS: readonly ["all", "active", "trial", "at_risk"];
-export declare const toInvoicingCustomerTabId: (v: string) => "active" | "all" | "at_risk" | "trial";
+export declare const toInvoicingCustomerTabId: (v: string) => "active" | "all" | "trial" | "at_risk";
 export type InvoicingCustomerTabId = ReturnType<typeof toInvoicingCustomerTabId>;
 export interface InvoicingCustomerListViewState extends FetchedState {
     /** Selected status tab (CES-owned so it persists across page revisits). */

package/lib/view/notificationPreferencesView/epics/saveNotificationPreferencesEpic.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.saveNotificationPreferencesEpic = void 0;
 const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
+const notificationRegistryState_1 = require("../../../entity/notificationRegistry/notificationRegistryState");
 const snackbarReducer_1 = require("../../../entity/snackbar/snackbarReducer");
 const responsePayload_1 = require("../../../responsePayload");
 const notificationPreferencesEndpoint_1 = require("../notificationPreferencesEndpoint");
@@ -16,9 +17,19 @@ const saveNotificationPreferencesEpic = (actions$, state$, zeniAPI) => actions$.
 // ignored, so stale success/failure actions cannot clobber the newer
 // batch's state. Server-side ordering is arrival-order LWW.
 (0, operators_1.switchMap)(([, state]) => {
-    const overrides = (0, notificationPreferencesViewSelector_1.getNotificationLocalOverrides)(state);
-    const preferencesPatch = (0, notificationPreferencesViewPayload_1.mapPreferencesToPayload)(overrides);
-    if (Object.keys(preferencesPatch).length === 0) {
+    // A clean domain is omitted entirely: an empty patch is still a write against it.
+    const overridesByDomain = {};
+    const body = {};
+    notificationRegistryState_1.NOTIFICATION_DOMAINS.forEach((domain) => {
+        const overrides = (0, notificationPreferencesViewSelector_1.getNotificationLocalOverridesForDomain)(state, domain);
+        const preferencesPatch = (0, notificationPreferencesViewPayload_1.mapPreferencesToPayload)(overrides);
+        if (Object.keys(preferencesPatch).length === 0) {
+            return;
+        }
+        overridesByDomain[domain] = overrides;
+        body[`${domain}_preferences`] = preferencesPatch;
+    });
+    if (Object.keys(body).length === 0) {
         // No diff → do not dispatch a synthetic success (that would wipe
         // stored preferences via the reducer). Simply no-op.
         return rxjs_1.EMPTY;
@@ -31,7 +42,6 @@ const saveNotificationPreferencesEpic = (actions$, state$, zeniAPI) => actions$.
     // in-flight save's response (Success/Failure never dispatched, so
     // the counter never drained and future saves got their merge dropped).
     const cancelEpochAtDispatch = state.notificationPreferencesViewState.cancelEpoch;
-    const body = { task_checklist_preferences: preferencesPatch };
     // Suppress the error snackbar when the response lands AFTER the user
     // pressed Cancel — the Failure reducer already swallows the state
     // update, so the toast would be a stale error for a save the user
@@ -60,8 +70,11 @@ const saveNotificationPreferencesEpic = (actions$, state$, zeniAPI) => actions$.
         if ((0, responsePayload_1.isSuccessResponse)(response)) {
             return (0, rxjs_1.of)((0, notificationPreferencesViewReducer_1.saveNotificationPreferencesSuccess)({
                 cancelEpochAtDispatch,
-                savedOverrides: overrides,
-                serverEcho: response.data?.task_checklist_preferences,
+                savedOverridesByDomain: overridesByDomain,
+                serverEchoByDomain: {
+                    task_checklist: response.data?.task_checklist_preferences,
+                    commenting: response.data?.commenting_preferences,
+                },
             }));
         }
         const actions = [

package/lib/view/notificationPreferencesView/notificationPreferencesViewReducer.d.ts

@@ -1,30 +1,33 @@
-import { NotificationChannel, NotificationFrequency } from '../../entity/notificationRegistry/notificationRegistryState';
+import { NotificationChannel, NotificationDomain, NotificationFrequency } from '../../entity/notificationRegistry/notificationRegistryState';
 import { ZeniAPIStatus } from '../../responsePayload';
 import { NotificationPreferencesPayload } from './notificationPreferencesViewPayload';
-import { NotificationPreferences, NotificationPreferencesViewState } from './notificationPreferencesViewState';
+import { NotificationPreferencesByDomain, NotificationPreferencesViewState } from './notificationPreferencesViewState';
 export declare const initialState: NotificationPreferencesViewState;
 export interface SetFrequencyPayload {
     frequency: NotificationFrequency;
     groupId: string;
+    domain?: NotificationDomain;
 }
 export interface TogglePreferencePayload {
     channel: NotificationChannel;
     enabled: boolean;
     eventId: string;
+    domain?: NotificationDomain;
 }
 export interface SetGroupChannelMasterPayload {
     channel: NotificationChannel;
     enabled: boolean;
     groupId: string;
+    domain?: NotificationDomain;
 }
 export interface FetchNotificationPreferencesSuccessPayload {
-    preferences: NotificationPreferencesPayload | undefined;
+    preferencesByDomain: Partial<Record<NotificationDomain, NotificationPreferencesPayload | undefined>>;
     saveEpochAtDispatch: number;
 }
 export interface SaveNotificationPreferencesSuccessPayload {
     cancelEpochAtDispatch: number;
-    savedOverrides: NotificationPreferences;
-    serverEcho: NotificationPreferencesPayload | undefined;
+    savedOverridesByDomain: NotificationPreferencesByDomain;
+    serverEchoByDomain: Partial<Record<NotificationDomain, NotificationPreferencesPayload | undefined>>;
 }
 export interface SaveNotificationPreferencesFailurePayload {
     cancelEpochAtDispatch: number;

package/lib/view/notificationPreferencesView/notificationPreferencesViewReducer.js

@@ -3,16 +3,27 @@ var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.toggleEventChannel = exports.setGroupFrequency = exports.setGroupChannelMaster = exports.saveNotificationPreferencesSuccess = exports.saveNotificationPreferencesFailure = exports.saveNotificationPreferences = exports.fetchNotificationPreferencesSuccess = exports.clearNotificationPreferencesLocalOverrides = exports.clearAllNotificationPreferencesView = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
+const notificationRegistryState_1 = require("../../entity/notificationRegistry/notificationRegistryState");
 const rootActions_1 = require("../../rootActions");
 const notificationPreferencesViewPayload_1 = require("./notificationPreferencesViewPayload");
 const notificationPreferencesViewState_1 = require("./notificationPreferencesViewState");
 exports.initialState = {
     cancelEpoch: 0,
-    localOverrides: (0, notificationPreferencesViewState_1.emptyNotificationPreferences)(),
-    preferences: (0, notificationPreferencesViewState_1.emptyNotificationPreferences)(),
+    localOverridesByDomain: {},
+    preferencesByDomain: {},
     saveEpoch: 0,
     savePreferencesState: { fetchState: 'Not-Started' },
 };
+// Lazy: a gate-off tenant never receives that domain's key at all.
+const overridesFor = (byDomain, domain) => {
+    const existing = byDomain[domain];
+    if (existing != null) {
+        return existing;
+    }
+    const created = (0, notificationPreferencesViewState_1.emptyNotificationPreferences)();
+    byDomain[domain] = created;
+    return created;
+};
 const mergePreferences = (base, patch) => {
     const eventEnabledByChannel = {
         ...base.eventEnabledByChannel,
@@ -150,7 +161,8 @@ const notificationPreferencesView = (0, toolkit_1.createSlice)({
             // Success/Failure never dispatches, subsequent legitimate saves
             // still work because their captured epoch matches the current one.
             draft.cancelEpoch += 1;
-            draft.localOverrides = (0, notificationPreferencesViewState_1.emptyNotificationPreferences)();
+            // One shared Save/Cancel footer, so Cancel discards every domain.
+            draft.localOverridesByDomain = {};
             // Also drop `savePreferencesState` back to Not-Started so any
             // "Saving…" affordance bound to `getNotificationPreferencesSaveState`
             // clears on Cancel. Without this, a Cancel-during-save whose stale
@@ -167,9 +179,6 @@ const notificationPreferencesView = (0, toolkit_1.createSlice)({
             // them; the save-success path is the only clearer.
             // A `null`/`undefined` payload isn't a snapshot at all (e.g. the
             // envelope key was omitted); no-op instead of wiping preferences.
-            if (action.payload.preferences == null) {
-                return;
-            }
             // Stale-GET guard (Cursor Bugbot 3632510237): if the fetch epic
             // captured a `saveEpoch` lower than the current one, a save has
             // succeeded since this GET dispatched — the response is carrying
@@ -179,7 +188,13 @@ const notificationPreferencesView = (0, toolkit_1.createSlice)({
             if (action.payload.saveEpochAtDispatch < draft.saveEpoch) {
                 return;
             }
-            draft.preferences = (0, notificationPreferencesViewPayload_1.mapPayloadToPreferences)(action.payload.preferences);
+            Object.entries(action.payload.preferencesByDomain).forEach(([domain, payload]) => {
+                if (payload == null) {
+                    return;
+                }
+                draft.preferencesByDomain[domain] =
+                    (0, notificationPreferencesViewPayload_1.mapPayloadToPreferences)(payload);
+            });
         },
         saveNotificationPreferences(draft) {
             draft.savePreferencesState = { fetchState: 'In-Progress' };
@@ -238,33 +253,44 @@ const notificationPreferencesView = (0, toolkit_1.createSlice)({
             // skip the `preferences` replace. Cursor Bugbot 3632510237.
             draft.saveEpoch += 1;
             draft.savePreferencesState = { fetchState: 'Completed' };
-            const patch = action.payload.serverEcho == null
-                ? action.payload.savedOverrides
-                : (0, notificationPreferencesViewPayload_1.mapPayloadToPreferences)(action.payload.serverEcho);
-            draft.preferences = mergePreferences(draft.preferences, patch);
-            draft.localOverrides = subtractSavedOverrides(draft.localOverrides, action.payload.savedOverrides);
+            Object.entries(action.payload.savedOverridesByDomain).forEach(([rawDomain, savedOverrides]) => {
+                if (savedOverrides == null) {
+                    return;
+                }
+                const domain = rawDomain;
+                const serverEcho = action.payload.serverEchoByDomain[domain];
+                const patch = serverEcho == null
+                    ? savedOverrides
+                    : (0, notificationPreferencesViewPayload_1.mapPayloadToPreferences)(serverEcho);
+                draft.preferencesByDomain[domain] = mergePreferences(draft.preferencesByDomain[domain] ?? (0, notificationPreferencesViewState_1.emptyNotificationPreferences)(), patch);
+                draft.localOverridesByDomain[domain] = subtractSavedOverrides(draft.localOverridesByDomain[domain] ??
+                    (0, notificationPreferencesViewState_1.emptyNotificationPreferences)(), savedOverrides);
+            });
         },
         setGroupChannelMaster(draft, action) {
             // Mirror of `toggleEventChannel` but scoped to the group-channel master
             // held under `groupChannelEnabledByGroupId[groupId][channel]`.
             const { channel, enabled, groupId } = action.payload;
+            const overrides = overridesFor(draft.localOverridesByDomain, action.payload.domain ?? notificationRegistryState_1.DEFAULT_NOTIFICATION_DOMAIN);
             const groupMap = {
-                ...(draft.localOverrides.groupChannelEnabledByGroupId[groupId] ?? {}),
+                ...(overrides.groupChannelEnabledByGroupId[groupId] ?? {}),
             };
             groupMap[channel] = enabled;
-            draft.localOverrides.groupChannelEnabledByGroupId[groupId] = groupMap;
+            overrides.groupChannelEnabledByGroupId[groupId] = groupMap;
         },
         setGroupFrequency(draft, action) {
-            draft.localOverrides.groupFrequencyByGroupId[action.payload.groupId] =
+            const overrides = overridesFor(draft.localOverridesByDomain, action.payload.domain ?? notificationRegistryState_1.DEFAULT_NOTIFICATION_DOMAIN);
+            overrides.groupFrequencyByGroupId[action.payload.groupId] =
                 action.payload.frequency;
         },
         toggleEventChannel(draft, action) {
             const { channel, enabled, eventId } = action.payload;
+            const overrides = overridesFor(draft.localOverridesByDomain, action.payload.domain ?? notificationRegistryState_1.DEFAULT_NOTIFICATION_DOMAIN);
             const eventMap = {
-                ...(draft.localOverrides.eventEnabledByChannel[eventId] ?? {}),
+                ...(overrides.eventEnabledByChannel[eventId] ?? {}),
             };
             eventMap[channel] = enabled;
-            draft.localOverrides.eventEnabledByChannel[eventId] = eventMap;
+            overrides.eventEnabledByChannel[eventId] = eventMap;
         },
     },
     extraReducers: (builder) => {

package/lib/view/notificationPreferencesView/notificationPreferencesViewSelector.d.ts

@@ -1,7 +1,11 @@
 import { FetchStateAndError } from '../../commonStateTypes/common';
+import { NotificationDomain } from '../../entity/notificationRegistry/notificationRegistryState';
 import { RootState } from '../../rootStateTypes';
 import { NotificationPreferences } from './notificationPreferencesViewState';
 export declare const getNotificationPreferencesSaveState: (state: RootState) => FetchStateAndError;
+export declare const getEffectiveNotificationPreferencesForDomain: (state: RootState, domain: NotificationDomain) => NotificationPreferences;
 export declare const getEffectiveNotificationPreferences: (state: RootState) => NotificationPreferences;
+export declare const getNotificationLocalOverridesForDomain: (state: RootState, domain: NotificationDomain) => NotificationPreferences;
 export declare const getNotificationLocalOverrides: (state: RootState) => NotificationPreferences;
+export declare const hasUnsavedNotificationPreferencesForDomain: (state: RootState, domain: NotificationDomain) => boolean;
 export declare const hasUnsavedNotificationPreferences: (state: RootState) => boolean;

package/lib/view/notificationPreferencesView/notificationPreferencesViewSelector.js

@@ -1,7 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.hasUnsavedNotificationPreferences = exports.getNotificationLocalOverrides = exports.getEffectiveNotificationPreferences = exports.getNotificationPreferencesSaveState = void 0;
+exports.hasUnsavedNotificationPreferences = exports.hasUnsavedNotificationPreferencesForDomain = exports.getNotificationLocalOverrides = exports.getNotificationLocalOverridesForDomain = exports.getEffectiveNotificationPreferences = exports.getEffectiveNotificationPreferencesForDomain = exports.getNotificationPreferencesSaveState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
+const notificationRegistryState_1 = require("../../entity/notificationRegistry/notificationRegistryState");
+const notificationPreferencesViewState_1 = require("./notificationPreferencesViewState");
 const getView = (state) => state.notificationPreferencesViewState;
 const getNotificationPreferencesSaveState = (state) => getView(state).savePreferencesState;
 exports.getNotificationPreferencesSaveState = getNotificationPreferencesSaveState;
@@ -9,7 +11,12 @@ exports.getNotificationPreferencesSaveState = getNotificationPreferencesSaveStat
 // stable reference while neither input changes — a plain function would
 // allocate a fresh object on every call and re-render every `useSelector`
 // consumer on any unrelated dispatch.
-exports.getEffectiveNotificationPreferences = (0, toolkit_1.createSelector)((state) => getView(state).preferences, (state) => getView(state).localOverrides, (preferences, localOverrides) => {
+const EMPTY_PREFERENCES = (0, notificationPreferencesViewState_1.emptyNotificationPreferences)();
+// One per domain: a shared createSelector has a cache of one and would thrash across two.
+const effectivePreferencesSelectorByDomain = new Map();
+const createEffectivePreferencesSelector = (domain) => (0, toolkit_1.createSelector)((state) => getView(state).preferencesByDomain[domain], (state) => getView(state).localOverridesByDomain[domain], (storedPreferences, storedOverrides) => {
+    const preferences = storedPreferences ?? EMPTY_PREFERENCES;
+    const localOverrides = storedOverrides ?? EMPTY_PREFERENCES;
     const mergedEventEnabledByChannel = { ...preferences.eventEnabledByChannel };
     Object.entries(localOverrides.eventEnabledByChannel).forEach(([eventId, channels]) => {
         mergedEventEnabledByChannel[eventId] = {
@@ -33,8 +40,26 @@ exports.getEffectiveNotificationPreferences = (0, toolkit_1.createSelector)((sta
         },
     };
 });
-const getNotificationLocalOverrides = (state) => getView(state).localOverrides;
+const getEffectiveNotificationPreferencesForDomain = (state, domain) => {
+    let selector = effectivePreferencesSelectorByDomain.get(domain);
+    if (selector == null) {
+        selector = createEffectivePreferencesSelector(domain);
+        effectivePreferencesSelectorByDomain.set(domain, selector);
+    }
+    return selector(state);
+};
+exports.getEffectiveNotificationPreferencesForDomain = getEffectiveNotificationPreferencesForDomain;
+const getEffectiveNotificationPreferences = (state) => (0, exports.getEffectiveNotificationPreferencesForDomain)(state, notificationRegistryState_1.DEFAULT_NOTIFICATION_DOMAIN);
+exports.getEffectiveNotificationPreferences = getEffectiveNotificationPreferences;
+const getNotificationLocalOverridesForDomain = (state, domain) => getView(state).localOverridesByDomain[domain] ?? EMPTY_PREFERENCES;
+exports.getNotificationLocalOverridesForDomain = getNotificationLocalOverridesForDomain;
+const getNotificationLocalOverrides = (state) => (0, exports.getNotificationLocalOverridesForDomain)(state, notificationRegistryState_1.DEFAULT_NOTIFICATION_DOMAIN);
 exports.getNotificationLocalOverrides = getNotificationLocalOverrides;
-exports.hasUnsavedNotificationPreferences = (0, toolkit_1.createSelector)((state) => getView(state).localOverrides, (localOverrides) => Object.keys(localOverrides.eventEnabledByChannel).length > 0 ||
+const isDirty = (localOverrides) => Object.keys(localOverrides.eventEnabledByChannel).length > 0 ||
     Object.keys(localOverrides.groupChannelEnabledByGroupId).length > 0 ||
-    Object.keys(localOverrides.groupFrequencyByGroupId).length > 0);
+    Object.keys(localOverrides.groupFrequencyByGroupId).length > 0;
+const hasUnsavedNotificationPreferencesForDomain = (state, domain) => isDirty((0, exports.getNotificationLocalOverridesForDomain)(state, domain));
+exports.hasUnsavedNotificationPreferencesForDomain = hasUnsavedNotificationPreferencesForDomain;
+// Drives the shared page-level Save/Cancel footer.
+const hasUnsavedNotificationPreferences = (state) => Object.values(getView(state).localOverridesByDomain).some((localOverrides) => localOverrides != null && isDirty(localOverrides));
+exports.hasUnsavedNotificationPreferences = hasUnsavedNotificationPreferences;

package/lib/view/notificationPreferencesView/notificationPreferencesViewState.d.ts

@@ -1,5 +1,5 @@
 import { FetchStateAndError } from '../../commonStateTypes/common';
-import { NotificationChannel, NotificationFrequency } from '../../entity/notificationRegistry/notificationRegistryState';
+import { NotificationChannel, NotificationDomain, NotificationFrequency } from '../../entity/notificationRegistry/notificationRegistryState';
 export interface NotificationPreferences {
     eventEnabledByChannel: Record<string, Partial<Record<NotificationChannel, boolean>>>;
     groupChannelEnabledByGroupId: Record<string, Partial<Record<NotificationChannel, boolean>>>;
@@ -7,9 +7,10 @@ export interface NotificationPreferences {
 }
 export interface NotificationPreferencesViewState {
     cancelEpoch: number;
-    localOverrides: NotificationPreferences;
-    preferences: NotificationPreferences;
+    localOverridesByDomain: NotificationPreferencesByDomain;
+    preferencesByDomain: NotificationPreferencesByDomain;
     saveEpoch: number;
     savePreferencesState: FetchStateAndError;
 }
+export type NotificationPreferencesByDomain = Partial<Record<NotificationDomain, NotificationPreferences>>;
 export declare const emptyNotificationPreferences: () => NotificationPreferences;

package/lib/view/profitAndLossProjectView/profitAndLossProjectViewPayload.d.ts

@@ -17,6 +17,18 @@ interface ProjectCOABalanceGroupedPayloadByProjectIdV2 {
 export interface SectionByProjectCOABalanceGroupedPayloadV2 extends COABalanceGroupedPayloadV2 {
     projects: ProjectCOABalanceGroupedPayloadByProjectIdV2;
 }
+interface CalculatedProjectCOABalanceGroupedPayloadByProjectIdV2 {
+    [project_Id: string]: COABalanceGroupedPayloadV2;
+}
+/**
+ * A section whose per-project entries carry a time series and nothing else: the
+ * backend fills the account-wise map only for the account sections, so the
+ * calculated sections (net income, the operating total, change in cash) are
+ * grouped by project with no accounts underneath.
+ */
+export interface CalculatedSectionByProjectCOABalanceGroupedPayloadV2 extends COABalanceGroupedPayloadV2 {
+    projects: CalculatedProjectCOABalanceGroupedPayloadByProjectIdV2;
+}
 export interface ProfitAndLossProjectViewPayload extends ReportByProjectMetadataPayloadV2 {
     cogs: SectionByProjectCOABalanceGroupedPayloadV2;
     earnings_before_interest_and_tax: COABalanceGroupedPayloadV2;

package/lib/view/settingsView/epic/fetchNotificationSettingsEpic.js

@@ -41,11 +41,21 @@ const fetchNotificationSettingsEpic = (actions$, state$, zeniAPI) => actions$.pi
             // 67d6918e.
             updateActions.push((0, notificationRegistryReducer_1.updateNotificationRegistry)({
                 registry: response.data.task_checklist_registry ?? undefined,
+                // An absent `<domain>_registry` means that domain's gate is off.
+                registriesByDomain: {
+                    task_checklist: response.data.task_checklist_registry ?? undefined,
+                    commenting: response.data.commenting_registry ?? undefined,
+                },
                 registryEpochAtDispatch,
             }));
-            if (response.data.task_checklist_preferences != null) {
+            // One action so the domains cannot land on different store epochs.
+            const preferencesByDomain = {
+                task_checklist: response.data.task_checklist_preferences ?? undefined,
+                commenting: response.data.commenting_preferences ?? undefined,
+            };
+            if (Object.values(preferencesByDomain).some((preferences) => preferences != null)) {
                 updateActions.push((0, notificationPreferencesViewReducer_1.fetchNotificationPreferencesSuccess)({
-                    preferences: response.data.task_checklist_preferences,
+                    preferencesByDomain,
                     saveEpochAtDispatch,
                 }));
             }

package/lib/view/settingsView/settingsViewPayload.d.ts

@@ -37,6 +37,8 @@ export interface NotificationSettingsPayload {
     pending_bill_approval_notification: RemindersPayload | null;
     pending_reimbursement_approval_notification: RemindersPayload | null;
     uncategorized_transaction_notification: RemindersPayload | null;
+    commenting_preferences?: NotificationPreferencesPayload;
+    commenting_registry?: NotificationRegistryPayload;
     month_end_email_recipient_email_ids?: string[];
     task_checklist_preferences?: NotificationPreferencesPayload;
     task_checklist_registry?: NotificationRegistryPayload;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.2.32",
+  "version": "5.2.34-beta0ND",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",