@zeniai/client-epic-state 5.2.32 → 5.2.34-beta0ND

package/lib/esm/view/aiCfoView/epics/setRoutineEnabledEpic.js

@@ -0,0 +1,28 @@
+import { of } from 'rxjs';
+import { catchError, filter, mergeMap } from 'rxjs/operators';
+import { createZeniAPIStatus, isSuccessResponse } from '../../../responsePayload';
+import { fetchRoutines, saveRoutineFailure, saveRoutineSuccess, setRoutineEnabled, } from '../aiCfoViewReducer';
+/**
+ * PUT /1.0/routines/{scheduleId} with nothing but `enabled`.
+ *
+ * Separate from `saveRoutineEpic` because pausing is not editing. A routine
+ * whose cadence this client version does not recognise has `recurrence: null`
+ * and cannot produce a `RoutineDraft` — and that is precisely the routine
+ * someone most needs to be able to stop. Sending only `enabled` also means a
+ * pause can never rewrite a schedule as a side effect.
+ */
+export const setRoutineEnabledEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(setRoutineEnabled.match), 
+// mergeMap: pausing one routine must not cancel pausing another, and these
+// target different rows so they cannot collide the way two saves of one
+// form would.
+mergeMap((action) => {
+    const { enabled, scheduleId } = action.payload;
+    return zeniAPI
+        .putAndGetJSON(`${zeniAPI.apiEndPoints.aiCfoMicroServiceBaseUrl}/1.0/routines/${encodeURIComponent(scheduleId)}`, { enabled })
+        .pipe(mergeMap((response) => isSuccessResponse(response)
+        ? of(saveRoutineSuccess(), fetchRoutines())
+        : // Refetch on failure too: the switch was flipped optimistically,
+            // and leaving it showing "paused" for a routine that is still
+            // running would be the one lie this list must not tell.
+            of(saveRoutineFailure(response.status), fetchRoutines())), catchError((error) => of(saveRoutineFailure(createZeniAPIStatus('Unexpected Error', 'Set routine enabled REST API call failed', error instanceof Error ? { message: error.message } : undefined)), fetchRoutines())));
+}));

package/lib/esm/view/aiCfoView/epics/toRoutine.js

@@ -0,0 +1,64 @@
+const RECURRENCES = ['daily', 'weekly', 'monthly'];
+const STATUSES = ['succeeded', 'failed', 'timeout'];
+/**
+ * A routine is usable if it has an identity. That is the whole bar.
+ *
+ * `schedule_id` and `name` are what every consumer dereferences, so those are
+ * what this establishes.
+ *
+ * Deliberately NOT also requiring `macro_id`. A routine whose skill was deleted
+ * can come back without one — and it is still an active schedule emailing the
+ * user's financials. Dropping it here would make it invisible in the UI while
+ * it kept running, with no way for anyone to turn it off. Showing a broken row
+ * that can be paused or deleted is strictly better than hiding a live one.
+ */
+export const isRoutinePayload = (value) => {
+    const candidate = value;
+    return (typeof candidate?.schedule_id === 'string' &&
+        candidate.schedule_id !== '' &&
+        typeof candidate.name === 'string');
+};
+/**
+ * Narrow a server string to a known recurrence, or null.
+ *
+ * Null, NOT a fallback to 'daily'. A read-side default becomes a write-side
+ * value the moment the user opens that routine and saves it — so guessing here
+ * would quietly convert a cadence this client does not understand into a daily
+ * one, and the owner would find out from the volume of email. Null says "this
+ * client does not know", and the UI shows the row so it can still be paused or
+ * deleted while refusing to edit its schedule.
+ */
+const toRecurrence = (value) => RECURRENCES.includes(value)
+    ? value
+    : null;
+const toStatus = (value) => STATUSES.includes(value) ? value : null;
+/** Map one routine off the wire. Every default here is a deliberate reading. */
+export const toRoutine = (payload) => ({
+    unreadRuns: payload.unread_runs ?? 0,
+    consecutiveFailures: payload.consecutive_failures ?? 0,
+    dayOfMonth: payload.day_of_month ?? null,
+    // Absent reads as enabled: a routine the server returned without the flag is
+    // one it intends to run, and defaulting to false would show every row paused.
+    enabled: payload.enabled !== false,
+    hour: payload.hour ?? 0,
+    isAdHoc: payload.is_ad_hoc === true,
+    lastRunAt: payload.last_run_at ?? null,
+    lastStatus: toStatus(payload.last_status),
+    // '' is the sanctioned "unset ID" (CLAUDE.md), not a papered-over absence:
+    // the row still renders, and the UI reads this to show it as broken rather
+    // than offering to open a skill that is not there.
+    macroId: payload.macro_id ?? '',
+    minute: payload.minute ?? 0,
+    name: payload.name,
+    nextRunAt: payload.next_run_at ?? null,
+    pinnedVersion: payload.pinned_version ?? null,
+    recurrence: toRecurrence(payload.recurrence),
+    scheduleId: payload.schedule_id,
+    sessionId: payload.session_id ?? null,
+    // Null, not a guessed 'UTC'. Same trap as `recurrence`: a read-side default
+    // is written straight back on the next save, silently moving the routine's
+    // delivery by however many hours the real zone differed by. The server always
+    // sends this, so null means something is wrong and the UI should say so.
+    tzName: payload.tz_name ?? null,
+    weekday: payload.weekday ?? null,
+});

package/lib/esm/view/aiCfoView/epics/toRoutineRun.js

@@ -0,0 +1,42 @@
+const STATUSES = [
+    'claimed',
+    'running',
+    'succeeded',
+    'failed',
+    'timeout',
+];
+/**
+ * A run is usable if it has an identity — the same bar `isRoutinePayload` sets.
+ *
+ * Nothing else is required. A run that is still in flight has no `finished_at`,
+ * a claimed one has no `started_at`, and a failed one may have neither an error
+ * nor an answer to link to. Requiring any of those would drop exactly the rows
+ * the history exists to show.
+ */
+export const isRoutineRunPayload = (value) => {
+    const candidate = value;
+    return typeof candidate?.run_id === 'string' && candidate.run_id !== '';
+};
+/**
+ * Narrow a server status to one this client knows, or null.
+ *
+ * Null rather than a fallback, for the same reason `toRecurrence` returns null:
+ * a guess here would badge an unknown state as something specific, and on a run
+ * history the difference between "failed" and "we don't know" is the whole
+ * message. The UI shows an unknown status as neither succeeded nor failed.
+ */
+const toStatus = (value) => STATUSES.find((status) => status === value) ?? null;
+/** Empty strings become null: the server sends '' for an absent deep link. */
+const toId = (value) => value != null && value !== '' ? value : null;
+export const toRoutineRun = (payload) => ({
+    runId: payload.run_id,
+    attempt: payload.attempt ?? 1,
+    isManual: payload.is_manual === true,
+    error: toId(payload.error),
+    finishedAt: toId(payload.finished_at),
+    questionAnswerId: toId(payload.question_answer_id),
+    sessionId: toId(payload.session_id),
+    scheduledFor: toId(payload.scheduled_for),
+    startedAt: toId(payload.started_at),
+    status: toStatus(payload.status),
+});

package/lib/esm/view/expenseAutomationView/selectors/fluxAnalysisViewSelector.js

@@ -1,4 +1,3 @@
-import { reduceAnyFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
 import { getAccountBase } from '../../../entity/account/accountSelector';
 import { getClassById } from '../../../entity/class/classSelector';
@@ -7,7 +6,7 @@ import { getUserByUserId } from '../../../entity/user/userSelector';
 import { getVendorByVendorId } from '../../../entity/vendor/vendorSelector';
 import { getAllSteps } from './getAllStepsHelper';
 export function getExpenseAutomationFluxAnalysisView(state) {
-    const { expenseAutomationFluxAnalysisViewState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
+    const { expenseAutomationFluxAnalysisViewState, monthEndCloseChecksState } = state;
     const { fetchState, error, lastRefreshSuccessTime, refreshStatus, uiState, reviewOperatingExpenseIdsByPeriod, selectedSectionIdsByPeriod, groupsBySelectedPeriod, fluxAnalysisEntities, bulkReviewStatus, currency, totalBalancesAndVariance, } = expenseAutomationFluxAnalysisViewState;
     const fetchStateAndError = {
         fetchState,
@@ -92,17 +91,20 @@ export function getExpenseAutomationFluxAnalysisView(state) {
         },
     };
     const completionStatus = fluxCompletionStatus != null ? fluxCompletionStatus : 'incomplete';
-    const monthEndFetchState = monthYearPeriodId != null
-        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
-        : { fetchState: 'Not-Started', error: undefined };
-    const reducedFetchStatus = reduceAnyFetchState([
-        fetchStateAndError,
-        monthEndFetchState,
-    ]);
+    const groupsForSelectedPeriod = monthYearPeriodId != null
+        ? groupsBySelectedPeriod[monthYearPeriodId]
+        : undefined;
+    // `fetchState` is a flat slice field that survives a period switch. The per-period group is
+    // created by the fetch's own request reducer, so its absence means "not requested yet for this
+    // period" -- report 'Not-Started' then, so the table keeps its skeleton instead of rendering
+    // the previous period's rows during the transition.
+    const fetchStatus = fetchState === 'Completed' && groupsForSelectedPeriod == null
+        ? { fetchState: 'Not-Started', error: undefined }
+        : fetchStateAndError;
     return {
         sections,
         totalBalancesAndVariance,
-        fetchStatus: reducedFetchStatus,
+        fetchStatus,
         bulkReviewStatus,
         reviewOperatingExpensesIds,
         selectedSectionIds,

package/lib/esm/view/expenseAutomationView/selectors/jeSchedulesViewSelector.js

@@ -1,6 +1,5 @@
 import omit from 'lodash/omit';
 import orderBy from 'lodash/orderBy';
-import { reduceAnyFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { LAST_SCHEDULE_DAY_OF_MONTH, toMonthYearPeriodId, } from '../../../commonStateTypes/timePeriod';
 import { getAccountIdsForTypes } from '../../../entity/account/accountSelector';
 import { generateJEOneTimeAccrualKey } from '../../../entity/jeSchedules/jeScheduleHelper';
@@ -210,7 +209,7 @@ export function getExpenseAutomationJESchedulesView(state) {
     const failedJeScheduledTransaction = [];
     const accruedSchedules = [];
     const oneTimeAccruals = [];
-    const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
+    const { accountState, accountListState, classState, classListState, expenseAutomationJESchedulesViewState, expenseAutomationViewState, monthEndCloseChecksState, } = state;
     const { jeScheduleTransactionKeysByPeriodAndTab, jeScheduleAccruedKeysByPeriodAndTab, jeScheduleOneTimeAccrualKeysByPeriodAndTab, failedJeScheduleTransactionKeysByPeriodAndTab, jeScheduleLocalDataById, postStatusById, ignoreStatusById, revertStatusById, oneTimeAccrualActionStatusById, uiState, error, fetchState, refreshStatus, newSchedule, } = expenseAutomationJESchedulesViewState;
     const accountSettingsView = getJEAccountSettingsView(state);
     const newScheduleView = newSchedule.selectedDetailScheduleType === 'fixed_assets' ||
@@ -401,13 +400,6 @@ export function getExpenseAutomationJESchedulesView(state) {
         : [];
     const jeCompletionStatus = allSteps.find((step) => step.step === 'je_schedules')?.completionStatus;
     const completionStatus = jeCompletionStatus != null ? jeCompletionStatus : 'incomplete';
-    const monthEndFetchState = monthYearPeriodId != null
-        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
-        : { fetchState: 'Not-Started', error: undefined };
-    const reducedFetchStatus = reduceAnyFetchState([
-        { fetchState, error },
-        monthEndFetchState,
-    ]);
     const countByType = (schedules) => {
         const counts = ALL_SCHEDULES_TYPES.reduce((acc, type) => ({ ...acc, [type]: 0 }), {});
         schedules.forEach((schedule) => {
@@ -445,10 +437,10 @@ export function getExpenseAutomationJESchedulesView(state) {
         ignoreStatusById: ignoreStatusById,
         revertStatusById: revertStatusById,
         oneTimeAccrualActionStatusById: oneTimeAccrualActionStatusById,
-        fetchState: reducedFetchStatus.fetchState,
+        fetchState,
         jeScheduleLocalDataById: jeScheduleLocalDataById,
         uiState: uiState,
-        error: reducedFetchStatus.error,
+        error,
         refreshStatus,
         completionStatus,
     };

package/lib/esm/view/expenseAutomationView/selectors/missingReceiptsSelector.js

@@ -1,5 +1,4 @@
 import orderBy from 'lodash/orderBy';
-import { reduceAnyFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { toMonthYearPeriodId } from '../../../commonStateTypes/timePeriod';
 import { getCurrentTenant } from '../../../entity/tenant/tenantSelector';
 import { getSupportedTransactionById, getSupportedTransactionsByIds, } from '../../../entity/transaction/transactionSelector';
@@ -8,7 +7,7 @@ import { getCompletedTransactionsCacheKey } from '../reducers/missingReceiptsVie
 import { isUnmatchedTabFileStatus, } from '../types/missingReceiptsViewState';
 import { getAllSteps } from './getAllStepsHelper';
 export function getExpenseAutomationMissingReceiptsView(state) {
-    const { expenseAutomationMissingReceiptsViewState, expenseAutomationViewState, transactionState, monthEndCloseChecksState, monthEndCloseChecksViewState, } = state;
+    const { expenseAutomationMissingReceiptsViewState, expenseAutomationViewState, transactionState, monthEndCloseChecksState, } = state;
     const currentTenant = getCurrentTenant(state);
     const { selectedPeriodByTenantId } = expenseAutomationViewState;
     const selectedPeriod = selectedPeriodByTenantId[currentTenant.tenantId];
@@ -176,16 +175,16 @@ export function getExpenseAutomationMissingReceiptsView(state) {
             vendorLogo: result.vendorLogo ?? transaction?.logo?.href,
         };
     });
-    const monthEndFetchState = monthYearPeriodId != null
-        ? (monthEndCloseChecksViewState.monthEndCloseChecksViewByTenantId[currentTenant.tenantId]?.[monthYearPeriodId] ?? { fetchState: 'Not-Started', error: undefined })
-        : { fetchState: 'Not-Started', error: undefined };
-    const reducedFetchStatus = reduceAnyFetchState([
-        { fetchState, error },
-        monthEndFetchState,
-    ]);
+    // `fetchState` is a flat slice field that survives a period switch, so it still reads
+    // 'Completed' before the newly selected period's ids land. Reporting 'Not-Started' until they
+    // do keeps the skeleton up instead of flashing the "all done" empty state over the previous
+    // period's rows.
+    const fetchStatus = fetchState === 'Completed' && transactionIdsForSelectedPeriod == null
+        ? { fetchState: 'Not-Started', error: undefined }
+        : { fetchState, error };
     return {
-        fetchState: reducedFetchStatus.fetchState,
-        error: reducedFetchStatus.error,
+        fetchState: fetchStatus.fetchState,
+        error: fetchStatus.error,
         uploadReceiptStatusById,
         uiState,
         refreshStatus,

package/lib/esm/view/invoicing/editInvoicingCustomerDetailView/editInvoicingCustomerDetailViewPayload.js

@@ -30,6 +30,10 @@ export const localDataToSaveInvoicingCustomerPayload = (localData, billingAddres
             : {}),
     };
 };
+/**
+ * The email rendered once with sentinel tokens standing in for the subject and
+ * body, so the composer can splice a draft into it without another request.
+ */
 export const toInvoicingPaymentLinkEmailPreview = (payload) => ({
     body: payload.body,
     bodyToken: payload.body_token,

package/lib/esm/view/notificationPreferencesView/epics/saveNotificationPreferencesEpic.js

@@ -1,11 +1,12 @@
 import { EMPTY, of } from 'rxjs';
 import { catchError, filter, finalize, mergeMap, switchMap, takeUntil, withLatestFrom, } from 'rxjs/operators';
+import { NOTIFICATION_DOMAINS } from '../../../entity/notificationRegistry/notificationRegistryState';
 import { openSnackbar } from '../../../entity/snackbar/snackbarReducer';
 import { createZeniAPIStatus, isSuccessResponse, } from '../../../responsePayload';
 import { notificationPreferencesUrl } from '../notificationPreferencesEndpoint';
 import { mapPreferencesToPayload, } from '../notificationPreferencesViewPayload';
 import { clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, saveNotificationPreferencesFailure, saveNotificationPreferencesSuccess, } from '../notificationPreferencesViewReducer';
-import { getNotificationLocalOverrides } from '../notificationPreferencesViewSelector';
+import { getNotificationLocalOverridesForDomain } from '../notificationPreferencesViewSelector';
 export const saveNotificationPreferencesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter((action) => saveNotificationPreferences.match(action)), withLatestFrom(state$), 
 // `switchMap` unsubscribes from any in-flight PUT observable when a newer
 // Save fires. The prior HTTP request has already left the
@@ -13,9 +14,19 @@ export const saveNotificationPreferencesEpic = (actions$, state$, zeniAPI) => ac
 // ignored, so stale success/failure actions cannot clobber the newer
 // batch's state. Server-side ordering is arrival-order LWW.
 switchMap(([, state]) => {
-    const overrides = getNotificationLocalOverrides(state);
-    const preferencesPatch = mapPreferencesToPayload(overrides);
-    if (Object.keys(preferencesPatch).length === 0) {
+    // A clean domain is omitted entirely: an empty patch is still a write against it.
+    const overridesByDomain = {};
+    const body = {};
+    NOTIFICATION_DOMAINS.forEach((domain) => {
+        const overrides = getNotificationLocalOverridesForDomain(state, domain);
+        const preferencesPatch = mapPreferencesToPayload(overrides);
+        if (Object.keys(preferencesPatch).length === 0) {
+            return;
+        }
+        overridesByDomain[domain] = overrides;
+        body[`${domain}_preferences`] = preferencesPatch;
+    });
+    if (Object.keys(body).length === 0) {
         // No diff → do not dispatch a synthetic success (that would wipe
         // stored preferences via the reducer). Simply no-op.
         return EMPTY;
@@ -28,7 +39,6 @@ switchMap(([, state]) => {
     // in-flight save's response (Success/Failure never dispatched, so
     // the counter never drained and future saves got their merge dropped).
     const cancelEpochAtDispatch = state.notificationPreferencesViewState.cancelEpoch;
-    const body = { task_checklist_preferences: preferencesPatch };
     // Suppress the error snackbar when the response lands AFTER the user
     // pressed Cancel — the Failure reducer already swallows the state
     // update, so the toast would be a stale error for a save the user
@@ -57,8 +67,11 @@ switchMap(([, state]) => {
         if (isSuccessResponse(response)) {
             return of(saveNotificationPreferencesSuccess({
                 cancelEpochAtDispatch,
-                savedOverrides: overrides,
-                serverEcho: response.data?.task_checklist_preferences,
+                savedOverridesByDomain: overridesByDomain,
+                serverEchoByDomain: {
+                    task_checklist: response.data?.task_checklist_preferences,
+                    commenting: response.data?.commenting_preferences,
+                },
             }));
         }
         const actions = [

package/lib/esm/view/notificationPreferencesView/notificationPreferencesViewReducer.js

@@ -1,14 +1,25 @@
 import { createSlice } from '@reduxjs/toolkit';
+import { DEFAULT_NOTIFICATION_DOMAIN, } from '../../entity/notificationRegistry/notificationRegistryState';
 import { clearAll } from '../../rootActions';
 import { mapPayloadToPreferences, } from './notificationPreferencesViewPayload';
 import { emptyNotificationPreferences, } from './notificationPreferencesViewState';
 export const initialState = {
     cancelEpoch: 0,
-    localOverrides: emptyNotificationPreferences(),
-    preferences: emptyNotificationPreferences(),
+    localOverridesByDomain: {},
+    preferencesByDomain: {},
     saveEpoch: 0,
     savePreferencesState: { fetchState: 'Not-Started' },
 };
+// Lazy: a gate-off tenant never receives that domain's key at all.
+const overridesFor = (byDomain, domain) => {
+    const existing = byDomain[domain];
+    if (existing != null) {
+        return existing;
+    }
+    const created = emptyNotificationPreferences();
+    byDomain[domain] = created;
+    return created;
+};
 const mergePreferences = (base, patch) => {
     const eventEnabledByChannel = {
         ...base.eventEnabledByChannel,
@@ -146,7 +157,8 @@ const notificationPreferencesView = createSlice({
             // Success/Failure never dispatches, subsequent legitimate saves
             // still work because their captured epoch matches the current one.
             draft.cancelEpoch += 1;
-            draft.localOverrides = emptyNotificationPreferences();
+            // One shared Save/Cancel footer, so Cancel discards every domain.
+            draft.localOverridesByDomain = {};
             // Also drop `savePreferencesState` back to Not-Started so any
             // "Saving…" affordance bound to `getNotificationPreferencesSaveState`
             // clears on Cancel. Without this, a Cancel-during-save whose stale
@@ -163,9 +175,6 @@ const notificationPreferencesView = createSlice({
             // them; the save-success path is the only clearer.
             // A `null`/`undefined` payload isn't a snapshot at all (e.g. the
             // envelope key was omitted); no-op instead of wiping preferences.
-            if (action.payload.preferences == null) {
-                return;
-            }
             // Stale-GET guard (Cursor Bugbot 3632510237): if the fetch epic
             // captured a `saveEpoch` lower than the current one, a save has
             // succeeded since this GET dispatched — the response is carrying
@@ -175,7 +184,13 @@ const notificationPreferencesView = createSlice({
             if (action.payload.saveEpochAtDispatch < draft.saveEpoch) {
                 return;
             }
-            draft.preferences = mapPayloadToPreferences(action.payload.preferences);
+            Object.entries(action.payload.preferencesByDomain).forEach(([domain, payload]) => {
+                if (payload == null) {
+                    return;
+                }
+                draft.preferencesByDomain[domain] =
+                    mapPayloadToPreferences(payload);
+            });
         },
         saveNotificationPreferences(draft) {
             draft.savePreferencesState = { fetchState: 'In-Progress' };
@@ -234,33 +249,44 @@ const notificationPreferencesView = createSlice({
             // skip the `preferences` replace. Cursor Bugbot 3632510237.
             draft.saveEpoch += 1;
             draft.savePreferencesState = { fetchState: 'Completed' };
-            const patch = action.payload.serverEcho == null
-                ? action.payload.savedOverrides
-                : mapPayloadToPreferences(action.payload.serverEcho);
-            draft.preferences = mergePreferences(draft.preferences, patch);
-            draft.localOverrides = subtractSavedOverrides(draft.localOverrides, action.payload.savedOverrides);
+            Object.entries(action.payload.savedOverridesByDomain).forEach(([rawDomain, savedOverrides]) => {
+                if (savedOverrides == null) {
+                    return;
+                }
+                const domain = rawDomain;
+                const serverEcho = action.payload.serverEchoByDomain[domain];
+                const patch = serverEcho == null
+                    ? savedOverrides
+                    : mapPayloadToPreferences(serverEcho);
+                draft.preferencesByDomain[domain] = mergePreferences(draft.preferencesByDomain[domain] ?? emptyNotificationPreferences(), patch);
+                draft.localOverridesByDomain[domain] = subtractSavedOverrides(draft.localOverridesByDomain[domain] ??
+                    emptyNotificationPreferences(), savedOverrides);
+            });
         },
         setGroupChannelMaster(draft, action) {
             // Mirror of `toggleEventChannel` but scoped to the group-channel master
             // held under `groupChannelEnabledByGroupId[groupId][channel]`.
             const { channel, enabled, groupId } = action.payload;
+            const overrides = overridesFor(draft.localOverridesByDomain, action.payload.domain ?? DEFAULT_NOTIFICATION_DOMAIN);
             const groupMap = {
-                ...(draft.localOverrides.groupChannelEnabledByGroupId[groupId] ?? {}),
+                ...(overrides.groupChannelEnabledByGroupId[groupId] ?? {}),
             };
             groupMap[channel] = enabled;
-            draft.localOverrides.groupChannelEnabledByGroupId[groupId] = groupMap;
+            overrides.groupChannelEnabledByGroupId[groupId] = groupMap;
         },
         setGroupFrequency(draft, action) {
-            draft.localOverrides.groupFrequencyByGroupId[action.payload.groupId] =
+            const overrides = overridesFor(draft.localOverridesByDomain, action.payload.domain ?? DEFAULT_NOTIFICATION_DOMAIN);
+            overrides.groupFrequencyByGroupId[action.payload.groupId] =
                 action.payload.frequency;
         },
         toggleEventChannel(draft, action) {
             const { channel, enabled, eventId } = action.payload;
+            const overrides = overridesFor(draft.localOverridesByDomain, action.payload.domain ?? DEFAULT_NOTIFICATION_DOMAIN);
             const eventMap = {
-                ...(draft.localOverrides.eventEnabledByChannel[eventId] ?? {}),
+                ...(overrides.eventEnabledByChannel[eventId] ?? {}),
             };
             eventMap[channel] = enabled;
-            draft.localOverrides.eventEnabledByChannel[eventId] = eventMap;
+            overrides.eventEnabledByChannel[eventId] = eventMap;
         },
     },
     extraReducers: (builder) => {

package/lib/esm/view/notificationPreferencesView/notificationPreferencesViewSelector.js

@@ -1,11 +1,18 @@
 import { createSelector } from '@reduxjs/toolkit';
+import { DEFAULT_NOTIFICATION_DOMAIN, } from '../../entity/notificationRegistry/notificationRegistryState';
+import { emptyNotificationPreferences, } from './notificationPreferencesViewState';
 const getView = (state) => state.notificationPreferencesViewState;
 export const getNotificationPreferencesSaveState = (state) => getView(state).savePreferencesState;
 // Memoised on `preferences` + `localOverrides` so the merged shape keeps a
 // stable reference while neither input changes — a plain function would
 // allocate a fresh object on every call and re-render every `useSelector`
 // consumer on any unrelated dispatch.
-export const getEffectiveNotificationPreferences = createSelector((state) => getView(state).preferences, (state) => getView(state).localOverrides, (preferences, localOverrides) => {
+const EMPTY_PREFERENCES = emptyNotificationPreferences();
+// One per domain: a shared createSelector has a cache of one and would thrash across two.
+const effectivePreferencesSelectorByDomain = new Map();
+const createEffectivePreferencesSelector = (domain) => createSelector((state) => getView(state).preferencesByDomain[domain], (state) => getView(state).localOverridesByDomain[domain], (storedPreferences, storedOverrides) => {
+    const preferences = storedPreferences ?? EMPTY_PREFERENCES;
+    const localOverrides = storedOverrides ?? EMPTY_PREFERENCES;
     const mergedEventEnabledByChannel = { ...preferences.eventEnabledByChannel };
     Object.entries(localOverrides.eventEnabledByChannel).forEach(([eventId, channels]) => {
         mergedEventEnabledByChannel[eventId] = {
@@ -29,7 +36,20 @@ export const getEffectiveNotificationPreferences = createSelector((state) => get
         },
     };
 });
-export const getNotificationLocalOverrides = (state) => getView(state).localOverrides;
-export const hasUnsavedNotificationPreferences = createSelector((state) => getView(state).localOverrides, (localOverrides) => Object.keys(localOverrides.eventEnabledByChannel).length > 0 ||
+export const getEffectiveNotificationPreferencesForDomain = (state, domain) => {
+    let selector = effectivePreferencesSelectorByDomain.get(domain);
+    if (selector == null) {
+        selector = createEffectivePreferencesSelector(domain);
+        effectivePreferencesSelectorByDomain.set(domain, selector);
+    }
+    return selector(state);
+};
+export const getEffectiveNotificationPreferences = (state) => getEffectiveNotificationPreferencesForDomain(state, DEFAULT_NOTIFICATION_DOMAIN);
+export const getNotificationLocalOverridesForDomain = (state, domain) => getView(state).localOverridesByDomain[domain] ?? EMPTY_PREFERENCES;
+export const getNotificationLocalOverrides = (state) => getNotificationLocalOverridesForDomain(state, DEFAULT_NOTIFICATION_DOMAIN);
+const isDirty = (localOverrides) => Object.keys(localOverrides.eventEnabledByChannel).length > 0 ||
     Object.keys(localOverrides.groupChannelEnabledByGroupId).length > 0 ||
-    Object.keys(localOverrides.groupFrequencyByGroupId).length > 0);
+    Object.keys(localOverrides.groupFrequencyByGroupId).length > 0;
+export const hasUnsavedNotificationPreferencesForDomain = (state, domain) => isDirty(getNotificationLocalOverridesForDomain(state, domain));
+// Drives the shared page-level Save/Cancel footer.
+export const hasUnsavedNotificationPreferences = (state) => Object.values(getView(state).localOverridesByDomain).some((localOverrides) => localOverrides != null && isDirty(localOverrides));

package/lib/esm/view/settingsView/epic/fetchNotificationSettingsEpic.js

@@ -38,11 +38,21 @@ export const fetchNotificationSettingsEpic = (actions$, state$, zeniAPI) => acti
             // 67d6918e.
             updateActions.push(updateNotificationRegistry({
                 registry: response.data.task_checklist_registry ?? undefined,
+                // An absent `<domain>_registry` means that domain's gate is off.
+                registriesByDomain: {
+                    task_checklist: response.data.task_checklist_registry ?? undefined,
+                    commenting: response.data.commenting_registry ?? undefined,
+                },
                 registryEpochAtDispatch,
             }));
-            if (response.data.task_checklist_preferences != null) {
+            // One action so the domains cannot land on different store epochs.
+            const preferencesByDomain = {
+                task_checklist: response.data.task_checklist_preferences ?? undefined,
+                commenting: response.data.commenting_preferences ?? undefined,
+            };
+            if (Object.values(preferencesByDomain).some((preferences) => preferences != null)) {
                 updateActions.push(fetchNotificationPreferencesSuccess({
-                    preferences: response.data.task_checklist_preferences,
+                    preferencesByDomain,
                     saveEpochAtDispatch,
                 }));
             }

package/lib/index.d.ts

@@ -116,8 +116,8 @@ import { updateCommentsNotifications, updateCommentsNotificationsStatuses } from
 import { NotificationWithAuthors } from './entity/notification/types/notificationSelectorTypes';
 import { Notification, NotificationActivity, NotificationEventData, NotificationMetaData, NotificationUpdates, NotificationValueFormat } from './entity/notification/types/notificationStateTypes';
 import { ExternalNotificationData, NotificationActivityType, NotificationGroup, NotificationIdentifierType, NotificationMode, NotificationStatus, NotificationUpdateValue, toNotificationModeStrict } from './entity/notification/types/notificationTypes';
-import { getNotificationRegistry } from './entity/notificationRegistry/notificationRegistrySelector';
-import { NotificationChannel, NotificationFrequency, NotificationRegistry, RegistryNotificationEvent, RegistryNotificationGroup, toNotificationChannel, toNotificationFrequency } from './entity/notificationRegistry/notificationRegistryState';
+import { getNotificationRegistry, getNotificationRegistryForDomain } from './entity/notificationRegistry/notificationRegistrySelector';
+import { DEFAULT_NOTIFICATION_DOMAIN, NOTIFICATION_DOMAINS, NotificationChannel, NotificationDomain, NotificationFrequency, NotificationRegistry, RegistryNotificationEvent, RegistryNotificationGroup, toNotificationChannel, toNotificationDomain, toNotificationFrequency } from './entity/notificationRegistry/notificationRegistryState';
 import { getPlaidPaymentAccounts } from './entity/paymentAccount/paymentAccountSelector';
 import { Logo, PaymentAccount, VERIFIED_PAYMENT_ACCOUNT_PROVIDER_VERIFICATION_STATUS } from './entity/paymentAccount/paymentAccountState';
 import { PaymentInstrument } from './entity/paymentInstrument/paymentInstrument';
@@ -379,7 +379,7 @@ import { getNetBurnOrIncomeStoryCardReport } from './view/netBurnOrIncomeStoryCa
 import { AccountingMethod, NetBurnOrIncomeStoryCardReport } from './view/netBurnOrIncomeStoryCard/netBurnOrIncomeStoryCardSelectorTypes';
 import { AverageMonthsCount, NetBurnOrIncomeRunway, NetBurnOrIncomeStoryCardState, TimeSpanIdForAverage } from './view/netBurnOrIncomeStoryCard/netBurnOrIncomeStoryCardState';
 import { clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, setGroupChannelMaster, setGroupFrequency, toggleEventChannel } from './view/notificationPreferencesView/notificationPreferencesViewReducer';
-import { getEffectiveNotificationPreferences, getNotificationLocalOverrides, getNotificationPreferencesSaveState, hasUnsavedNotificationPreferences } from './view/notificationPreferencesView/notificationPreferencesViewSelector';
+import { getEffectiveNotificationPreferences, getEffectiveNotificationPreferencesForDomain, getNotificationLocalOverrides, getNotificationLocalOverridesForDomain, getNotificationPreferencesSaveState, hasUnsavedNotificationPreferences, hasUnsavedNotificationPreferencesForDomain } from './view/notificationPreferencesView/notificationPreferencesViewSelector';
 import { NotificationPreferences } from './view/notificationPreferencesView/notificationPreferencesViewState';
 import { fetchNotificationUnreadCount, fetchNotificationUnreadCountSuccess, fetchNotificationView, updateNotificationViewAllNotificationsStatus, updateNotificationViewCurrentTabAndSubTab, updateNotificationViewNotificationStatus, updateNotificationViewSubTab, updateNotificationViewTabState, updateNotificationViewUIState } from './view/notificationView/notificationViewReducer';
 import { NotificationView, getExternalNotificationsForSelectedSubTab, getNotificationView, getNotificationsForSelectedSubTab } from './view/notificationView/notificationViewSelector';
@@ -966,7 +966,7 @@ export { ExternalNotificationData, NotificationGroup, NotificationActivityType,
 export { NotificationView, NotificationViewUIState, NotificationTabState, NotificationTabType, NotificationSubTabType, toNotificationSubTabTypeStrict, toNotificationTabTypeStrict, fetchNotificationView, fetchNotificationUnreadCount, fetchNotificationUnreadCountSuccess, updateNotificationViewAllNotificationsStatus, updateNotificationViewNotificationStatus, updateNotificationViewTabState, updateNotificationViewCurrentTabAndSubTab, updateNotificationViewSubTab, updateNotificationViewUIState, getNotificationView, getExternalNotificationsForSelectedSubTab, getNotificationsForSelectedSubTab, };
 export { fetchRegisteredInterests, notifyMeForFeature, getFeatureNotificationView, getRegisteredInterests, getRegisteredInterestsByFeature, isFeatureInterestRegistered, FeatureInterest, FeatureNotificationViewState, };
 export { pushToastNotification, ToastNotification, ToastNotificationPayload, getLastNotificationTime, getNotifications, };
-export { getEffectiveNotificationPreferences, getNotificationLocalOverrides, getNotificationPreferencesSaveState, getNotificationRegistry, hasUnsavedNotificationPreferences, NotificationChannel, NotificationFrequency, NotificationPreferences, NotificationRegistry, RegistryNotificationEvent, RegistryNotificationGroup, clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, setGroupChannelMaster, setGroupFrequency, toggleEventChannel, toNotificationChannel, toNotificationFrequency, };
+export { getEffectiveNotificationPreferences, getEffectiveNotificationPreferencesForDomain, getNotificationLocalOverrides, getNotificationLocalOverridesForDomain, getNotificationPreferencesSaveState, getNotificationRegistry, getNotificationRegistryForDomain, hasUnsavedNotificationPreferences, hasUnsavedNotificationPreferencesForDomain, NOTIFICATION_DOMAINS, NotificationChannel, DEFAULT_NOTIFICATION_DOMAIN, NotificationDomain, NotificationFrequency, NotificationPreferences, NotificationRegistry, RegistryNotificationEvent, RegistryNotificationGroup, clearAllNotificationPreferencesView, clearNotificationPreferencesLocalOverrides, saveNotificationPreferences, setGroupChannelMaster, setGroupFrequency, toggleEventChannel, toNotificationChannel, toNotificationDomain, toNotificationFrequency, };
 export { getReferralListView, getInviteFormView, ReferralListSelectorView, ReferralViewState, InviteCompanyLocalData, ReferralInvitation, ReferralListViewSortKey, ReferralViewUIState, toReferralListViewSortKeyType, ReferralStatus, ReferralAmountStatus, StatusTypes, AmountStatusTypes, DEFAULT_REFERRER_AMOUNT, fetchReferrals, sendReferralInvite, clearReferrals, saveReferralFormDataInLocalStore, updateReferralListSortUiState, resendReferralInvite, fetchRewardsPlan, RewardsPlanCardReport, getRewardsPlanCard, updateReferViewed, RewardsPlanData, };
 export { ALL_WEEK_DAYS, DayOfWeek, RecurringDatePickerOptions, RecurringFrequencyType, SEMI_WEEKLY_REQUIRED_DAYS_COUNT, getMinAllowedEndDate, getRecurringEndDateFromCount, toDayOfWeek, toRecurringFrequency, };
 export { fetchCockpitContext, fetchCompanyTaskManagerView, fetchTaskManagerMetrics, CompanyTaskManagerSelectorView, CompanyTaskManagerViewUIState, TaskManagerMetrics, getCompanyTaskManagerView, TaskWithCompanyDetail, createTaskFromTaskGroupTemplate, TaskGroupTemplate, };
@@ -983,12 +983,12 @@ export { AiAccountantCustomerViewState, AiAccountantSortKey, AiAccountantUIState
 export { AiAccountantFilterCategoryField } from './view/companyView/types/cockpitTypes';
 export { cancelAiAccountantOnboarding, fetchAiAccountantCustomers, fetchAiAccountantJobs, setSelectedTenantIdsForJobTrigger, triggerAiAccountantJob, updateAiAccountantUIState, } from './view/aiAccountantView/aiAccountantViewReducer';
 export { AiAccountantCockpitView, getAiAccountantCockpitView, } from './view/aiAccountantView/aiAccountantViewSelector';
-export { fetchChatSessionsForUser, createSession, submitQuestion, updateAiCfoViewScrollPosition, updateCurrentInput, updateCotCollapsedState, setSession, clearCurrentSessionId, clearDeleteChatSessionStatus, clearLastContextMessage, createSessionAndSubmit, stopSubmit, stopSubmitQuestion, fetchChatHistory, acceptMasterTOS, deleteChatSession, submitFeedback, updateResponseState, fetchSuggestedQuestions, fetchSuggestedQuestionsSuccess, fetchSuggestedQuestionsFailure, fetchSkills, fetchSkillsSuccess, fetchSkillsFailure, fetchSkillDetail, clearSkillDetail, clearSkillMutation, deleteSkill, fetchSkillVersionBody, fetchSkillVersions, saveSkill, setSkillVisibility, openSkillsBrowser, closeSkillsBrowser, applyAiCfoSidePanelHostPageTransition, clearAiCfoSidePanelHostPageContext, } from './view/aiCfoView/aiCfoViewReducer';
-export { AiCfoViewState, AiCfoViewUIState, Skill, SkillDetail, SkillDetailState, SkillDraft, SkillMutationState, SkillVersion, SkillVersionBodyState, SkillVersionsState, SkillVisibility, SkillsState, SuggestedQuestionsForPageContext, } from './view/aiCfoView/aiCfoViewState';
+export { acceptMasterTOS, applyAiCfoSidePanelHostPageTransition, clearAiCfoSidePanelHostPageContext, clearCurrentSessionId, clearDeleteChatSessionStatus, clearLastContextMessage, clearSkillDetail, clearSkillMutation, closeRoutineRuns, closeRoutinesBrowser, closeSkillsBrowser, createSession, createSessionAndSubmit, deleteChatSession, deleteRoutine, deleteSkill, fetchChatHistory, fetchChatSessionsForUser, fetchRoutineRuns, fetchRoutines, fetchSkillDetail, fetchSkills, fetchSkillsFailure, fetchSkillsSuccess, fetchSkillVersionBody, fetchSkillVersions, fetchSuggestedQuestions, fetchSuggestedQuestionsFailure, fetchSuggestedQuestionsSuccess, openRoutinesBrowser, openSkillsBrowser, runRoutine, saveRoutine, saveSkill, setRoutineEnabled, setSession, setSkillVisibility, stopSubmit, stopSubmitQuestion, submitFeedback, submitQuestion, updateAiCfoViewScrollPosition, updateCotCollapsedState, updateCurrentInput, updateResponseState, } from './view/aiCfoView/aiCfoViewReducer';
+export { AiCfoViewState, AiCfoViewUIState, Routine, RoutineDraft, RoutineMutationState, RoutineRecurrence, RoutineRun, RoutineRunsState, RoutineRunStatus, RoutinesState, RoutineStatus, Skill, SkillDetail, SkillDetailState, SkillDraft, SkillMutationState, SkillsState, SkillVersion, SkillVersionBodyState, SkillVersionsState, SkillVisibility, SuggestedQuestionsForPageContext, } from './view/aiCfoView/aiCfoViewState';
 export { FetchSuggestedQuestionsResponse, SuggestedQuestionsDataPayload, FetchSkillsResponse, SkillSummaryPayload, SkillListDataPayload, } from './view/aiCfoView/aiCfoViewPayload';
 export type { FeedbackType, SubmitFeedbackPayload, } from './view/aiCfoView/aiCfoViewPayload';
 export type { AiCfoSuggestedQuestionsPageContext } from './common/aiCfo/aiCfoSuggestedQuestionsPageContext';
-export { AiCfoViewSelector, getAiCfoView, getSuggestedQuestionsForPageContext, getSkills, getSkillDetail, getSkillMutation, getSkillVersionBody, getSkillVersions, getSkillsEnabled, } from './view/aiCfoView/aiCfoViewSelector';
+export { AiCfoViewSelector, canCreateRoutine, getAiCfoView, getRoutineMutation, getRoutineRuns, getRoutines, getRoutinesEnabled, getSkillDetail, getSkillMutation, getSkills, getSkillsEnabled, getSkillVersionBody, getSkillVersions, getSuggestedQuestionsForPageContext, } from './view/aiCfoView/aiCfoViewSelector';
 export { MessagePayload, ChatSessionPayload, AiCfoAnswerPayload, } from './entity/aiCfo/aiCfoPayload';
 export { setNewSession, setSessions, updateAiCfoAnswerCardPolicyWizardPlan, upsertAnswerPayload, upsertOrAddQuestionAnswerPayload, addQuestionPayload, clearSession, toAiCfoExports, toAiCfoVisualization, appendSyntheticAiCfoAnswer, updateSyntheticAiCfoAnswer, removeSyntheticAiCfoAnswer, } from './entity/aiCfo/aiCfoReducer';
 export { AiCfoSelectorView, getAllQuestionAnswersForChatSession, getQuestionAnswerByIdForChatSession, getAllQuestionsForChatSession, getAiCfoSelectorView, getSyntheticAiCfoAnswersForChatSession, getSyntheticAiCfoAnswerByQuestionAnswerId, ChatSessionWithOrderedQuestionAnswers, } from './entity/aiCfo/aiCfoSelector';
@@ -1171,7 +1171,7 @@ export type { InvoicingCustomerColumnConfig, InvoicingCustomerFilters, Invoicing
 export { getInvoicingCustomerListView } from './view/invoicing/invoicingCustomerListView/invoicingCustomerListViewSelector';
 export type { InvoicingCustomerListView } from './view/invoicing/invoicingCustomerListView/invoicingCustomerListViewSelector';
 export { fetchInvoicingCustomerDetail, fetchInvoicingCustomerDetailPage, fetchInvoicingPaymentLinkEmailPreviewPage, } from './view/invoicing/editInvoicingCustomerDetailView/editInvoicingCustomerDetailViewReducer';
-export type { InvoicingPaymentLinkEmailPreviewData } from './view/invoicing/editInvoicingCustomerDetailView/editInvoicingCustomerDetailViewPayload';
+export type { InvoicingPaymentLinkEmailPreviewData } from './view/invoicing/editInvoicingCustomerDetailView/editInvoicingCustomerDetailViewState';
 export { createInvoicingSetupIntent, fetchInvoicingPlaidLinkToken, resetInvoicingCustomerPaymentMethod, saveInvoicingPaymentMethod, sendInvoicingPaymentLink, } from './view/invoicing/customerPaymentMethod/customerPaymentMethodReducer';
 export type { InvoicingSetupIntent } from './view/invoicing/customerPaymentMethod/customerPaymentMethodState';
 export { getInvoicingPaymentLinkSendState, getInvoicingPaymentMethodSaveState, getInvoicingPlaidLinkToken, getInvoicingSentPaymentLinkEmail, getInvoicingSentPaymentLinkMagicUrl, getInvoicingSetupIntent, getInvoicingSetupIntentFetchState, } from './view/invoicing/customerPaymentMethod/customerPaymentMethodSelector';