@zeniai/client-epic-state 5.1.42-betaDI4 → 5.1.42

package/lib/view/taskManager/taskListView/taskListViewHelpers.d.ts

@@ -1,16 +1,5 @@
-import { Tag } from '../../../entity/tag/tagState';
 import { Task } from '../../../entity/task/taskState';
-import { User } from '../../../entity/user/userState';
 import { ZeniDate } from '../../../zeniDayJS';
 import { TaskGroupKey } from './taskList';
-export type SubtaskSortKey = 'name' | 'status' | 'assignee' | 'tag';
-export type SubtaskSortOrder = 'asc' | 'desc';
 export declare const getDueDateValueFromDueDateGroupId: (groupId: string) => ZeniDate;
 export declare const getTaskUpdates: (groupByKey: TaskGroupKey, groupId: string) => Partial<Task>;
-/**
- * Sort a subtask list by one of the sortable columns. Pure — no state
- * dependency. `statusOrder` is derived from `allTaskStatus` so any new
- * status added upstream slots in by its enum position instead of
- * falling into a catch-all bucket.
- */
-export declare const sortSubtasks: (subtasks: Task[], sortKey: SubtaskSortKey | null, sortOrder: SubtaskSortOrder, userList: User[], tagList: Tag[]) => Task[];

package/lib/view/taskManager/taskListView/taskListViewHelpers.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.sortSubtasks = exports.getTaskUpdates = exports.getDueDateValueFromDueDateGroupId = void 0;
+exports.getTaskUpdates = exports.getDueDateValueFromDueDateGroupId = void 0;
 const zeniDayJS_1 = require("../../../zeniDayJS");
 const taskDetailSelector_1 = require("../taskDetailView/taskDetailSelector");
 const taskList_1 = require("./taskList");
@@ -53,62 +53,3 @@ const getTaskUpdates = (groupByKey, groupId) => {
     };
 };
 exports.getTaskUpdates = getTaskUpdates;
-/**
- * Sort a subtask list by one of the sortable columns. Pure — no state
- * dependency. `statusOrder` is derived from `allTaskStatus` so any new
- * status added upstream slots in by its enum position instead of
- * falling into a catch-all bucket.
- */
-const sortSubtasks = (subtasks, sortKey, sortOrder, userList, tagList) => {
-    if (sortKey == null) {
-        return subtasks;
-    }
-    const statusOrder = taskDetailSelector_1.allTaskStatus.reduce((acc, status, index) => {
-        acc[status.code] = index;
-        return acc;
-    }, {});
-    const unknownStatusRank = taskDetailSelector_1.allTaskStatus.length;
-    const cmpStr = (a, b) => a.localeCompare(b, undefined, { sensitivity: 'base' });
-    const keyFn = (task) => {
-        if (sortKey === 'name') {
-            return task.name ?? '';
-        }
-        if (sortKey === 'status') {
-            return statusOrder[task.status.code] ?? unknownStatusRank;
-        }
-        if (sortKey === 'assignee') {
-            const firstId = task.assignees?.[0];
-            if (firstId == null) {
-                return '';
-            }
-            const user = userList.find((candidate) => candidate.userId === firstId);
-            return user
-                ? `${user.firstName ?? ''} ${user.lastName ?? ''}`.trim()
-                : '';
-        }
-        if (sortKey === 'tag') {
-            const firstTagId = task.tagIds?.[0];
-            if (firstTagId == null) {
-                return '';
-            }
-            const tag = tagList.find((candidate) => candidate.tagId === firstTagId);
-            return tag?.name ?? '';
-        }
-        return '';
-    };
-    const copy = [...subtasks];
-    copy.sort((a, b) => {
-        const av = keyFn(a);
-        const bv = keyFn(b);
-        let cmp;
-        if (typeof av === 'number' && typeof bv === 'number') {
-            cmp = av - bv;
-        }
-        else {
-            cmp = cmpStr(String(av), String(bv));
-        }
-        return sortOrder === 'asc' ? cmp : -cmp;
-    });
-    return copy;
-};
-exports.sortSubtasks = sortSubtasks;

package/lib/view/transactionDetail/epics/saveTransactionHelper.js

@@ -48,7 +48,15 @@ const toTransactionUpdatesFromTransactionDetailLocalData = (transactionDetailLoc
     let lastUpdatedCategory;
     let lastUpdatedClass;
     // single recommendation to just pick the last recommendation in the list of lines
+    const existingLineIds = new Set(transaction.lines?.map((l) => l.id) ?? []);
+    const deletedLineIds = new Set((transactionDetailLocalData.deletedLineIds ?? []).filter((id) => existingLineIds.has(id)));
+    // Collect new lines — in lineItemById but not yet in transaction.lines.
+    const addedLines = Object.values(transactionDetailLocalData.lineItemById).filter((item) => !existingLineIds.has(item.id));
     transaction.lines?.forEach((line) => {
+        // Skip lines the user deleted in edit mode.
+        if (deletedLineIds.has(line.id)) {
+            return;
+        }
         const lineItem = transactionDetailLocalData.lineItemById[line.id];
         if (line.type === 'transaction_with_account_and_class_line' ||
             line.type === 'transaction_with_product_or_service_line' ||
@@ -59,6 +67,7 @@ const toTransactionUpdatesFromTransactionDetailLocalData = (transactionDetailLoc
             const entityDetails = getEntityDetails(selectedEntity, lineItem, transactionDetailLocalData.vendorUpdates, transactionDetailLocalData.customerUpdates);
             updatesByLineId[line.id] = {
                 lineDescription: lineItem.lineDescription,
+                amount: lineItem.amount,
                 class: lineItem.class,
                 account: lineItem.account,
                 // Project is at the transaction level for invoice/credit_memo; omit from lines.
@@ -80,6 +89,17 @@ const toTransactionUpdatesFromTransactionDetailLocalData = (transactionDetailLoc
                         currentSelectedEntityLine.type === 'vendor'
                         ? lineItem.vendor
                         : undefined,
+                    // Carry the JE debit/credit side so a split edit that flips an
+                    // existing line's posting side persists through the line patch.
+                    ...(line.type === 'journal_entry_transaction_line'
+                        ? {
+                            postingType: lineItem.postingType,
+                            postingTypeName: lineItem.postingType != null
+                                ? lineItem.postingType.charAt(0).toUpperCase() +
+                                    lineItem.postingType.slice(1)
+                                : lineItem.postingTypeName,
+                        }
+                        : {}),
                 };
             }
             let hasCategoryChanged = false;
@@ -166,6 +186,8 @@ const toTransactionUpdatesFromTransactionDetailLocalData = (transactionDetailLoc
         and all the line items are NOT uncategorized*/
         markAsMiscatUpdates: isTransactionMisCategorized,
         anyBulkUpdates: isBulkUpdate,
+        addedLines: addedLines.length > 0 ? addedLines : undefined,
+        deletedLineIds: deletedLineIds.size > 0 ? [...deletedLineIds] : undefined,
     };
 };
 exports.toTransactionUpdatesFromTransactionDetailLocalData = toTransactionUpdatesFromTransactionDetailLocalData;

package/lib/view/transactionDetail/epics/updateTransactionDetailEpic.d.ts

@@ -1,9 +1,11 @@
 import { ActionsObservable, StateObservable } from 'redux-observable';
+import { ID } from '../../../commonStateTypes/common';
 import { COTTransactionTracking } from '../../../commonStateTypes/recommendationBase';
 import { CustomerBase } from '../../../entity/customer/customerState';
 import { Entity } from '../../../entity/genericEntity/entity';
 import { openSnackbar } from '../../../entity/snackbar/snackbarReducer';
 import { TransactionPayload } from '../../../entity/transaction/payloadTypes/transactionPayload';
+import { Line } from '../../../entity/transaction/stateTypes/transactionLine';
 import { updateTransaction, updateTransactions } from '../../../entity/transaction/transactionReducer';
 import { SupportedTransaction } from '../../../entity/transaction/transactionState';
 import { updateVendors } from '../../../entity/vendor/vendorReducer';
@@ -13,6 +15,8 @@ import { ZeniAPI } from '../../../zeniAPI';
 import { syncTransactionCategorizationFromDetailSave } from '../../expenseAutomationView/reducers/transactionsViewReducer';
 import { initializeTransactionDetailLocalData, markTransactionAsNotMiscategorized, updateStatusConsolidatedSaveTransactionDetail, updateTransactionDetail, updateTransactionDetailSaveStatus, updateTransactionStateIfUpdateActionNotAllowed } from '../transactionDetailReducer';
 import { TransactionUpdates } from '../transactionDetailState';
+import { TransactionDetailLineItemData } from '../transactionDetailTypes';
 export type ActionType = ReturnType<typeof updateTransactionDetail> | ReturnType<typeof updateTransaction> | ReturnType<typeof updateTransactions> | ReturnType<typeof updateTransactionStateIfUpdateActionNotAllowed> | ReturnType<typeof openSnackbar> | ReturnType<typeof updateTransactionDetailSaveStatus> | ReturnType<typeof updateStatusConsolidatedSaveTransactionDetail> | ReturnType<typeof initializeTransactionDetailLocalData> | ReturnType<typeof updateVendors> | ReturnType<typeof markTransactionAsNotMiscategorized> | ReturnType<typeof syncTransactionCategorizationFromDetailSave>;
 export declare const updateTransactionDetailEpic: (actions$: ActionsObservable<ActionType>, state$: StateObservable<RootState>, zeniAPI: ZeniAPI) => import("rxjs").Observable<ActionType>;
-export declare const toTransactionUpdatePayload: (updates: TransactionUpdates, detail: SupportedTransaction, cotTransactionTracking: COTTransactionTracking, isAccountingProjectsEnabled: boolean, vendorUpdates?: VendorBase, customerUpdates?: CustomerBase, tranSelectedEntity?: Entity) => Partial<TransactionPayload>;
+export declare const toTransactionUpdatePayload: (updates: TransactionUpdates, detail: SupportedTransaction, cotTransactionTracking: COTTransactionTracking, isAccountingProjectsEnabled: boolean, vendorUpdates?: VendorBase, customerUpdates?: CustomerBase, tranSelectedEntity?: Entity, deletedLineIds?: ID[], addedLines?: TransactionDetailLineItemData[]) => Partial<TransactionPayload>;
+export declare const toNewTransactionLine: (item: TransactionDetailLineItemData) => Line;

package/lib/view/transactionDetail/epics/updateTransactionDetailEpic.js

@@ -3,7 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.toTransactionUpdatePayload = exports.updateTransactionDetailEpic = void 0;
+exports.toNewTransactionLine = exports.toTransactionUpdatePayload = exports.updateTransactionDetailEpic = void 0;
 const get_1 = __importDefault(require("lodash/get"));
 const rxjs_1 = require("rxjs");
 const operators_1 = require("rxjs/operators");
@@ -64,7 +64,9 @@ const updateTransactionDetailEpic = (actions$, state$, zeniAPI) => actions$.pipe
             if (response.data.vendors != null) {
                 actions.push((0, vendorReducer_1.updateVendors)(response.data.vendors, 'merge'));
             }
-            actions.push((0, transactionReducer_1.updateTransaction)(transactionDetailKeyForResponse, response.data.transaction));
+            // 'replace' so deleted lines are removed from Redux; 'merge' would
+            // keep any line absent from the server response (deletion bug).
+            actions.push((0, transactionReducer_1.updateTransaction)(transactionDetailKeyForResponse, response.data.transaction, 'replace'));
             actions.push((0, transactionDetailReducer_1.initializeTransactionDetailLocalData)({
                 transactionId: transactionIdResp,
                 vendorId: response.data.vendors?.[0]?.vendor_id,
@@ -166,7 +168,7 @@ function preparePayload(transactionState, vendorState, transactionDetailState, t
         };
     }
     if (detail != null) {
-        const transUpdates = (0, exports.toTransactionUpdatePayload)(saveUpdates.updates, detail, cotTransactionTracking, isAccountingProjectsEnabled, vendorUpdates, customerUpdates, currentSelectedEntity);
+        const transUpdates = (0, exports.toTransactionUpdatePayload)(saveUpdates.updates, detail, cotTransactionTracking, isAccountingProjectsEnabled, vendorUpdates, customerUpdates, currentSelectedEntity, saveUpdates.deletedLineIds, saveUpdates.addedLines);
         const entityUpdates = toEntityUpdatePayload(saveUpdates.entityRelatedUpdates);
         return {
             entity_related_updates: entityUpdates,
@@ -176,7 +178,7 @@ function preparePayload(transactionState, vendorState, transactionDetailState, t
     }
     return undefined;
 }
-const toTransactionUpdatePayload = (updates, detail, cotTransactionTracking, isAccountingProjectsEnabled, vendorUpdates, customerUpdates, tranSelectedEntity) => {
+const toTransactionUpdatePayload = (updates, detail, cotTransactionTracking, isAccountingProjectsEnabled, vendorUpdates, customerUpdates, tranSelectedEntity, deletedLineIds, addedLines) => {
     const transaction = Object.assign({}, detail);
     transaction.memo = updates.memo ?? '';
     // Unlike `memo` (always reset to '' when absent), `documentId` falls back to
@@ -185,6 +187,11 @@ const toTransactionUpdatePayload = (updates, detail, cotTransactionTracking, isA
     // either the unchanged current value or undefined, and we must not send an
     // empty `document_id` that the server would treat as clearing the number.
     transaction.documentId = updates.documentId ?? transaction.documentId;
+    // Remove lines deleted by the user in edit mode before patching or serializing.
+    if (deletedLineIds != null && deletedLineIds.length > 0) {
+        const deletedSet = new Set(deletedLineIds);
+        transaction.lines = transaction.lines?.filter((line) => !deletedSet.has(line.id));
+    }
     const recommendationUpdates = {};
     for (const key in updates.updatesByLineId) {
         const lineUpdates = updates.updatesByLineId[key];
@@ -192,6 +199,9 @@ const toTransactionUpdatePayload = (updates, detail, cotTransactionTracking, isA
             if (line.id === key) {
                 const lineTobeUpdated = Object.assign({}, line);
                 lineTobeUpdated.lineDescription = lineUpdates.lineDescription ?? '';
+                if (lineUpdates.amount != null) {
+                    lineTobeUpdated.amount = lineUpdates.amount;
+                }
                 if (lineUpdates.class != null) {
                     lineTobeUpdated.class = lineUpdates.class;
                 }
@@ -213,6 +223,16 @@ const toTransactionUpdatePayload = (updates, detail, cotTransactionTracking, isA
                 else {
                     lineTobeUpdated.vendor = undefined;
                 }
+                // Persist a debit↔credit flip on an existing JE line. `lineTobeUpdated`
+                // is typed as the account-and-class shape, but for a JE the runtime
+                // object is a JournalEntryTransactionLine, so cast to set the side.
+                if (lineUpdates.postingType != null) {
+                    const journalEntryLine = lineTobeUpdated;
+                    journalEntryLine.postingType = lineUpdates.postingType;
+                    if (lineUpdates.postingTypeName != null) {
+                        journalEntryLine.postingTypeName = lineUpdates.postingTypeName;
+                    }
+                }
                 if (lineUpdates.recommendation != null) {
                     recommendationUpdates[line.id] = lineUpdates.recommendation;
                 }
@@ -232,6 +252,12 @@ const toTransactionUpdatePayload = (updates, detail, cotTransactionTracking, isA
         });
         transaction.lines = newLineMap;
     }
+    // Append lines added by the user in edit mode. Sending id='' tells the
+    // backend to create a new QBO line rather than updating an existing one.
+    if (addedLines != null && addedLines.length > 0) {
+        const newLines = addedLines.map(exports.toNewTransactionLine);
+        transaction.lines = [...(transaction.lines ?? []), ...newLines];
+    }
     transaction.recommendations = recommendationUpdates;
     // Convert transaction to payload first
     let basePayload;
@@ -307,6 +333,53 @@ const checkIfVendorOrCustomerMissingForAnyLineItem = (transactionPayload) => {
     }
     return isAnyVendorOrCustomerMissing;
 };
+// Converts a locally-created line item (from edit mode) into the wire shape
+// expected by the categorize endpoint. Sending id='' signals the backend to
+// create a new QBO line rather than update an existing one.
+//
+// Type-dispatched so each transaction family contributes its own new-line
+// shape: journal entries carry debit/credit `postingType`, expenses carry
+// `billable`. Phase 3 types extend this by adding a branch rather than forking
+// the function.
+const EMPTY_ACCOUNT = {
+    accountDescription: '',
+    accountId: '',
+    accountName: '',
+    labels: [],
+};
+const toNewTransactionLine = (item) => {
+    if (item.type === 'journal_entry_transaction_line') {
+        const journalEntryLine = {
+            ...item,
+            id: '',
+            type: 'journal_entry_transaction_line',
+            platformLineDetailType: item.platformLineDetailType ?? 'journal_entry_line_detail',
+            account: item.account ?? EMPTY_ACCOUNT,
+            billable: item.billable ?? 'not_billable',
+            isCategoryMiscategorized: false,
+            isClassMiscategorized: false,
+            lineTransactionType: item.lineTransactionType ?? 'journal_entry',
+            postingType: item.postingType ?? 'debit',
+            postingTypeName: item.postingTypeName != null && item.postingTypeName !== ''
+                ? item.postingTypeName
+                : (item.postingType ?? 'debit').charAt(0).toUpperCase() +
+                    (item.postingType ?? 'debit').slice(1),
+        };
+        return journalEntryLine;
+    }
+    const accountAndClassLine = {
+        ...item,
+        id: '',
+        type: 'transaction_with_account_and_class_line',
+        platformLineDetailType: item.platformLineDetailType ?? 'account_based_expense_line_detail',
+        account: item.account ?? EMPTY_ACCOUNT,
+        billable: item.billable ?? 'not_billable',
+        isCategoryMiscategorized: false,
+        isClassMiscategorized: false,
+    };
+    return accountAndClassLine;
+};
+exports.toNewTransactionLine = toNewTransactionLine;
 const toEntityUpdatePayload = (entityUpdates) => {
     const entityUpdatesPayload = [];
     let entityKey;

package/lib/view/transactionDetail/journalEntryLinesViewModel.d.ts

@@ -64,6 +64,33 @@ export declare const journalEntryTotalsByPostingSide: (lines: ReadonlyArray<Pick
     creditTotal?: Amount;
     debitTotal?: Amount;
 };
+type PostingBearer = Pick<JournalEntryTransactionLine, 'amount' | 'postingType'>;
+export interface JournalEntrySplitReconciliation {
+    creditTotal: number;
+    debitTotal: number;
+    /** Total debits == total credits == original transaction total. */
+    isBalanced: boolean;
+}
+/**
+ * Sums debit and credit sides (big.js-exact) and reports whether the split is
+ * balanced: total debits equal total credits AND equal the original
+ * transaction total. The original total of a valid JE equals its total debits,
+ * so it is passed in by the caller (`transaction.amount.amount`).
+ */
+export declare const journalEntrySplitReconciliation: (lines: ReadonlyArray<PostingBearer>, originalTotal: number) => JournalEntrySplitReconciliation;
+export type JournalEntrySplitErrorKey = 'lineNeedsDebitOrCredit' | 'totalsMustEqual';
+export interface JournalEntrySplitValidation {
+    ok: boolean;
+    errorKey?: JournalEntrySplitErrorKey;
+}
+/**
+ * Save-time validation for a JE split (Figma `4165:33028` / `4165:45379`):
+ *   1. every line needs a non-zero debit or credit, and
+ *   2. total debits == total credits == original total.
+ * Returns the first failing rule's `errorKey` (maps to a strings entry). Does
+ * NOT require category/class to be chosen — balance is the only gate.
+ */
+export declare const validateJournalEntrySplit: (lines: ReadonlyArray<PostingBearer>, originalTotal: number) => JournalEntrySplitValidation;
 /**
  * Drops `linked_transaction_line` entries — equivalent to legacy
  * `filterOutLinkedTransactionLine` in `transactionDetail.helpers.ts`.

package/lib/view/transactionDetail/journalEntryLinesViewModel.js

@@ -3,7 +3,8 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.sortJournalEntryLines = exports.filterJournalEntryLinesExcludingLinked = exports.journalEntryTotalsByPostingSide = exports.sumJournalEntryAmounts = exports.journalEntryDefaultSortConfig = exports.toJournalEntrySortKey = exports.JOURNAL_ENTRY_SORT_KEYS = void 0;
+exports.sortJournalEntryLines = exports.filterJournalEntryLinesExcludingLinked = exports.validateJournalEntrySplit = exports.journalEntrySplitReconciliation = exports.journalEntryTotalsByPostingSide = exports.sumJournalEntryAmounts = exports.journalEntryDefaultSortConfig = exports.toJournalEntrySortKey = exports.JOURNAL_ENTRY_SORT_KEYS = void 0;
+const big_js_1 = __importDefault(require("big.js"));
 const orderBy_1 = __importDefault(require("lodash/orderBy"));
 const stringToUnion_1 = require("../../commonStateTypes/stringToUnion");
 const transactionLine_1 = require("../../entity/transaction/stateTypes/transactionLine");
@@ -110,6 +111,65 @@ const journalEntryTotalsByPostingSide = (lines) => {
 };
 exports.journalEntryTotalsByPostingSide = journalEntryTotalsByPostingSide;
 // ---------------------------------------------------------------------------
+// Split reconciliation & validation (Phase 2 — JE split)
+// ---------------------------------------------------------------------------
+// Half-cent tolerance for the balance equality checks, matching the expense
+// reconciliation row's epsilon. Sums use big.js so repeated decimal addition
+// doesn't drift before the comparison.
+const JOURNAL_ENTRY_BALANCE_EPSILON = 0.005;
+/**
+ * Sums debit and credit sides (big.js-exact) and reports whether the split is
+ * balanced: total debits equal total credits AND equal the original
+ * transaction total. The original total of a valid JE equals its total debits,
+ * so it is passed in by the caller (`transaction.amount.amount`).
+ */
+const journalEntrySplitReconciliation = (lines, originalTotal) => {
+    let debit = new big_js_1.default(0);
+    let credit = new big_js_1.default(0);
+    for (const line of lines) {
+        const amount = new big_js_1.default(line.amount?.amount ?? 0);
+        if (line.postingType === 'debit') {
+            debit = debit.plus(amount);
+        }
+        else if (line.postingType === 'credit') {
+            credit = credit.plus(amount);
+        }
+    }
+    const balancedToEachOther = debit
+        .minus(credit)
+        .abs()
+        .lt(JOURNAL_ENTRY_BALANCE_EPSILON);
+    const balancedToOriginal = debit
+        .minus(originalTotal)
+        .abs()
+        .lt(JOURNAL_ENTRY_BALANCE_EPSILON);
+    return {
+        debitTotal: debit.toNumber(),
+        creditTotal: credit.toNumber(),
+        isBalanced: balancedToEachOther && balancedToOriginal,
+    };
+};
+exports.journalEntrySplitReconciliation = journalEntrySplitReconciliation;
+/**
+ * Save-time validation for a JE split (Figma `4165:33028` / `4165:45379`):
+ *   1. every line needs a non-zero debit or credit, and
+ *   2. total debits == total credits == original total.
+ * Returns the first failing rule's `errorKey` (maps to a strings entry). Does
+ * NOT require category/class to be chosen — balance is the only gate.
+ */
+const validateJournalEntrySplit = (lines, originalTotal) => {
+    const everyLineHasSide = lines.every((line) => (line.postingType === 'debit' || line.postingType === 'credit') &&
+        Math.abs(line.amount?.amount ?? 0) > JOURNAL_ENTRY_BALANCE_EPSILON);
+    if (!everyLineHasSide) {
+        return { ok: false, errorKey: 'lineNeedsDebitOrCredit' };
+    }
+    if (!(0, exports.journalEntrySplitReconciliation)(lines, originalTotal).isBalanced) {
+        return { ok: false, errorKey: 'totalsMustEqual' };
+    }
+    return { ok: true };
+};
+exports.validateJournalEntrySplit = validateJournalEntrySplit;
+// ---------------------------------------------------------------------------
 // Filter
 // ---------------------------------------------------------------------------
 /**

package/lib/view/transactionDetail/transactionDetailLocalDataHelper.js

@@ -834,14 +834,16 @@ const getChangedLineItemCountFromLocalData = (transaction, transactionLocalData)
                 line.type === 'transaction_with_product_or_service_line' ||
                 line.type === 'journal_entry_transaction_line') {
                 const accountLineLocal = transactionLocalData.lineItemById[lineId];
-                const accountLine = line;
-                hasCategoryChanged =
-                    accountLineLocal.account?.qboId !== accountLine.account.qboId &&
-                        accountLineLocal.account?.accountId !== accountLine.account.accountId;
-                hasClassChanged =
-                    (accountLineLocal.class?.qboId != null ||
-                        accountLine.class?.qboId != null) &&
-                        accountLineLocal.class?.qboId !== accountLine.class?.qboId;
+                if (accountLineLocal != null) {
+                    const accountLine = line;
+                    hasCategoryChanged =
+                        accountLineLocal.account?.qboId !== accountLine.account.qboId &&
+                            accountLineLocal.account?.accountId !== accountLine.account.accountId;
+                    hasClassChanged =
+                        (accountLineLocal.class?.qboId != null ||
+                            accountLine.class?.qboId != null) &&
+                            accountLineLocal.class?.qboId !== accountLine.class?.qboId;
+                }
             }
             hasDescriptionChanged =
                 transactionLocalData.lineItemById[lineId] != null

package/lib/view/transactionDetail/transactionDetailReducer.d.ts

@@ -8,7 +8,7 @@ import { SupportedTransaction, SupportedTransactionPayload } from '../../entity/
 import { ZeniAPIStatus } from '../../responsePayload';
 import { UncategorizedAccounts } from '../accountList/accountListSelector';
 import { TransactionDetailState, TransactionSaveUpdates } from './transactionDetailState';
-import { TransactionDetailLocalData, TransactionVendorUpdates } from './transactionDetailTypes';
+import { TransactionDetailLineItemData, TransactionDetailLocalData, TransactionVendorUpdates } from './transactionDetailTypes';
 export declare const initialState: TransactionDetailState;
 export declare const downloadAccountingProviderAttachment: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[attachmentId: string], {
     attachmentId: string;
@@ -166,6 +166,15 @@ export declare const downloadAccountingProviderAttachment: import("@reduxjs/tool
     transactionId: TransactionID;
     transaction: SupportedTransaction;
     isEnabled: boolean;
-}, "transactionDetail/setIsVendorUpdateAllChecked", never, never>;
+}, "transactionDetail/setIsVendorUpdateAllChecked", never, never>, addSplitLine: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[transactionId: TransactionID, newLine: TransactionDetailLineItemData], {
+    transactionId: TransactionID;
+    newLine: TransactionDetailLineItemData;
+}, "transactionDetail/addSplitLine", never, never>, deleteSplitLine: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[transactionId: TransactionID, lineId: string], {
+    transactionId: TransactionID;
+    lineId: string;
+}, "transactionDetail/deleteSplitLine", never, never>, toggleSplitEditMode: import("@reduxjs/toolkit").ActionCreatorWithPreparedPayload<[transactionId: TransactionID, editMode: boolean], {
+    transactionId: TransactionID;
+    editMode: boolean;
+}, "transactionDetail/toggleSplitEditMode", never, never>;
 declare const _default: import("redux").Reducer<TransactionDetailState>;
 export default _default;

package/lib/view/transactionDetail/transactionDetailReducer.js

@@ -4,7 +4,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.setIsVendorUpdateAllChecked = exports.updateVendorBulkRecommendationsFetchStatus = exports.updateLatestSelectedEntity = exports.resetAllLineItemsToVendor = exports.updateVendorToAllLineItems = exports.updateLocalDataWithTransactionsUpdateWithVendorCheckbox = exports.resetSelectedCustomer = exports.resetVendor = exports.updateSelectedCustomer = exports.updateSelectedVendor = exports.removeEntityRecommendationForLineIdForTransactionDetail = exports.markCategoryClassRecommendationsFailureForTransactionDetail = exports.markCategoryClassRecommendationsCompletedForTransactionDetail = exports.markCategoryClassRecommendationsInProgressForTransactionDetail = exports.setEntityRecommendationForLineIdsForTransactionDetail = exports.setAllLineItemsLocalDataIsUpdateAllChecked = exports.setAllLineItemsToCategoryClassInLocalData = exports.resetLineItemsCategoryClassInLocalData = exports.clearTransactionDetailLocalData = exports.saveTransactionDetailLocalData = exports.initializeTransactionDetailLocalData = exports.saveTransactionDetail = exports.updateTransactionStateIfUpdateActionNotAllowed = exports.updateStatusConsolidatedSaveTransactionDetail = exports.updateStatusForTransactionNotMiscategorizedUpdate = exports.deleteTransactionAttachmentSuccess = exports.deleteTransactionAttachmentFailure = exports.deleteTransactionAttachment = exports.markTransactionAsNotMiscategorized = exports.clearTransactionDetailSaveStatus = exports.updateTransactionDetailSaveStatus = exports.updateTransactionDetail = exports.uploadMissingAttachmentSuccess = exports.clearTransactionDetail = exports.removeTransactionDetail = exports.updateTransactionDetailFetchState = exports.fetchTransactionDetail = exports.downloadAccountingProviderAttachmentFailure = exports.downloadAccountingProviderAttachmentSuccess = exports.downloadAccountingProviderAttachment = exports.initialState = void 0;
+exports.toggleSplitEditMode = exports.deleteSplitLine = exports.addSplitLine = exports.setIsVendorUpdateAllChecked = exports.updateVendorBulkRecommendationsFetchStatus = exports.updateLatestSelectedEntity = exports.resetAllLineItemsToVendor = exports.updateVendorToAllLineItems = exports.updateLocalDataWithTransactionsUpdateWithVendorCheckbox = exports.resetSelectedCustomer = exports.resetVendor = exports.updateSelectedCustomer = exports.updateSelectedVendor = exports.removeEntityRecommendationForLineIdForTransactionDetail = exports.markCategoryClassRecommendationsFailureForTransactionDetail = exports.markCategoryClassRecommendationsCompletedForTransactionDetail = exports.markCategoryClassRecommendationsInProgressForTransactionDetail = exports.setEntityRecommendationForLineIdsForTransactionDetail = exports.setAllLineItemsLocalDataIsUpdateAllChecked = exports.setAllLineItemsToCategoryClassInLocalData = exports.resetLineItemsCategoryClassInLocalData = exports.clearTransactionDetailLocalData = exports.saveTransactionDetailLocalData = exports.initializeTransactionDetailLocalData = exports.saveTransactionDetail = exports.updateTransactionStateIfUpdateActionNotAllowed = exports.updateStatusConsolidatedSaveTransactionDetail = exports.updateStatusForTransactionNotMiscategorizedUpdate = exports.deleteTransactionAttachmentSuccess = exports.deleteTransactionAttachmentFailure = exports.deleteTransactionAttachment = exports.markTransactionAsNotMiscategorized = exports.clearTransactionDetailSaveStatus = exports.updateTransactionDetailSaveStatus = exports.updateTransactionDetail = exports.uploadMissingAttachmentSuccess = exports.clearTransactionDetail = exports.removeTransactionDetail = exports.updateTransactionDetailFetchState = exports.fetchTransactionDetail = exports.downloadAccountingProviderAttachmentFailure = exports.downloadAccountingProviderAttachmentSuccess = exports.downloadAccountingProviderAttachment = exports.initialState = void 0;
 const toolkit_1 = require("@reduxjs/toolkit");
 const get_1 = __importDefault(require("lodash/get"));
 const entity_1 = require("../../entity/genericEntity/entity");
@@ -670,6 +670,71 @@ const transactionDetail = (0, toolkit_1.createSlice)({
                 };
             },
         },
+        // Split transaction — Phase 1 (expense)
+        addSplitLine: {
+            reducer(draft, action) {
+                const key = (0, transactionDetailState_1.getTransactionDetailKey)(action.payload.transactionId);
+                const detail = (0, get_1.default)(draft.transactionDetailById, key, undefined);
+                if (detail != null) {
+                    draft.transactionDetailById[key] = {
+                        ...detail,
+                        transactionDetailLocalData: {
+                            ...detail.transactionDetailLocalData,
+                            lineItemById: {
+                                ...detail.transactionDetailLocalData.lineItemById,
+                                [action.payload.newLine.id]: action.payload.newLine,
+                            },
+                        },
+                    };
+                }
+            },
+            prepare(transactionId, newLine) {
+                return { payload: { transactionId, newLine } };
+            },
+        },
+        deleteSplitLine: {
+            reducer(draft, action) {
+                const key = (0, transactionDetailState_1.getTransactionDetailKey)(action.payload.transactionId);
+                const detail = (0, get_1.default)(draft.transactionDetailById, key, undefined);
+                if (detail == null) {
+                    return;
+                }
+                const { lineItemById, deletedLineIds = [] } = detail.transactionDetailLocalData;
+                const updated = { ...lineItemById };
+                delete updated[action.payload.lineId];
+                draft.transactionDetailById[key] = {
+                    ...detail,
+                    transactionDetailLocalData: {
+                        ...detail.transactionDetailLocalData,
+                        lineItemById: updated,
+                        deletedLineIds: [...deletedLineIds, action.payload.lineId],
+                    },
+                };
+            },
+            prepare(transactionId, lineId) {
+                return { payload: { transactionId, lineId } };
+            },
+        },
+        toggleSplitEditMode: {
+            reducer(draft, action) {
+                const key = (0, transactionDetailState_1.getTransactionDetailKey)(action.payload.transactionId);
+                const detail = (0, get_1.default)(draft.transactionDetailById, key, undefined);
+                if (detail != null) {
+                    draft.transactionDetailById[key] = {
+                        ...detail,
+                        transactionDetailLocalData: {
+                            ...detail.transactionDetailLocalData,
+                            editMode: action.payload.editMode,
+                            // Clear delete tracking when exiting edit mode without saving.
+                            ...(!action.payload.editMode && { deletedLineIds: [] }),
+                        },
+                    };
+                }
+            },
+            prepare(transactionId, editMode) {
+                return { payload: { transactionId, editMode } };
+            },
+        },
         clearRecommendedVendorsList(draft) {
             Object.assign(draft, exports.initialState);
         },
@@ -778,7 +843,7 @@ const transactionDetail = (0, toolkit_1.createSlice)({
         },
     },
 });
-_a = transactionDetail.actions, exports.downloadAccountingProviderAttachment = _a.downloadAccountingProviderAttachment, exports.downloadAccountingProviderAttachmentSuccess = _a.downloadAccountingProviderAttachmentSuccess, exports.downloadAccountingProviderAttachmentFailure = _a.downloadAccountingProviderAttachmentFailure, exports.fetchTransactionDetail = _a.fetchTransactionDetail, exports.updateTransactionDetailFetchState = _a.updateTransactionDetailFetchState, exports.removeTransactionDetail = _a.removeTransactionDetail, exports.clearTransactionDetail = _a.clearTransactionDetail, exports.uploadMissingAttachmentSuccess = _a.uploadMissingAttachmentSuccess, exports.updateTransactionDetail = _a.updateTransactionDetail, exports.updateTransactionDetailSaveStatus = _a.updateTransactionDetailSaveStatus, exports.clearTransactionDetailSaveStatus = _a.clearTransactionDetailSaveStatus, exports.markTransactionAsNotMiscategorized = _a.markTransactionAsNotMiscategorized, exports.deleteTransactionAttachment = _a.deleteTransactionAttachment, exports.deleteTransactionAttachmentFailure = _a.deleteTransactionAttachmentFailure, exports.deleteTransactionAttachmentSuccess = _a.deleteTransactionAttachmentSuccess, exports.updateStatusForTransactionNotMiscategorizedUpdate = _a.updateStatusForTransactionNotMiscategorizedUpdate, exports.updateStatusConsolidatedSaveTransactionDetail = _a.updateStatusConsolidatedSaveTransactionDetail, exports.updateTransactionStateIfUpdateActionNotAllowed = _a.updateTransactionStateIfUpdateActionNotAllowed, exports.saveTransactionDetail = _a.saveTransactionDetail, exports.initializeTransactionDetailLocalData = _a.initializeTransactionDetailLocalData, exports.saveTransactionDetailLocalData = _a.saveTransactionDetailLocalData, exports.clearTransactionDetailLocalData = _a.clearTransactionDetailLocalData, exports.resetLineItemsCategoryClassInLocalData = _a.resetLineItemsCategoryClassInLocalData, exports.setAllLineItemsToCategoryClassInLocalData = _a.setAllLineItemsToCategoryClassInLocalData, exports.setAllLineItemsLocalDataIsUpdateAllChecked = _a.setAllLineItemsLocalDataIsUpdateAllChecked, exports.setEntityRecommendationForLineIdsForTransactionDetail = _a.setEntityRecommendationForLineIdsForTransactionDetail, exports.markCategoryClassRecommendationsInProgressForTransactionDetail = _a.markCategoryClassRecommendationsInProgressForTransactionDetail, exports.markCategoryClassRecommendationsCompletedForTransactionDetail = _a.markCategoryClassRecommendationsCompletedForTransactionDetail, exports.markCategoryClassRecommendationsFailureForTransactionDetail = _a.markCategoryClassRecommendationsFailureForTransactionDetail, exports.removeEntityRecommendationForLineIdForTransactionDetail = _a.removeEntityRecommendationForLineIdForTransactionDetail, exports.updateSelectedVendor = _a.updateSelectedVendor, exports.updateSelectedCustomer = _a.updateSelectedCustomer, exports.resetVendor = _a.resetVendor, exports.resetSelectedCustomer = _a.resetSelectedCustomer, exports.updateLocalDataWithTransactionsUpdateWithVendorCheckbox = _a.updateLocalDataWithTransactionsUpdateWithVendorCheckbox, exports.updateVendorToAllLineItems = _a.updateVendorToAllLineItems, exports.resetAllLineItemsToVendor = _a.resetAllLineItemsToVendor, exports.updateLatestSelectedEntity = _a.updateLatestSelectedEntity, exports.updateVendorBulkRecommendationsFetchStatus = _a.updateVendorBulkRecommendationsFetchStatus, exports.setIsVendorUpdateAllChecked = _a.setIsVendorUpdateAllChecked;
+_a = transactionDetail.actions, exports.downloadAccountingProviderAttachment = _a.downloadAccountingProviderAttachment, exports.downloadAccountingProviderAttachmentSuccess = _a.downloadAccountingProviderAttachmentSuccess, exports.downloadAccountingProviderAttachmentFailure = _a.downloadAccountingProviderAttachmentFailure, exports.fetchTransactionDetail = _a.fetchTransactionDetail, exports.updateTransactionDetailFetchState = _a.updateTransactionDetailFetchState, exports.removeTransactionDetail = _a.removeTransactionDetail, exports.clearTransactionDetail = _a.clearTransactionDetail, exports.uploadMissingAttachmentSuccess = _a.uploadMissingAttachmentSuccess, exports.updateTransactionDetail = _a.updateTransactionDetail, exports.updateTransactionDetailSaveStatus = _a.updateTransactionDetailSaveStatus, exports.clearTransactionDetailSaveStatus = _a.clearTransactionDetailSaveStatus, exports.markTransactionAsNotMiscategorized = _a.markTransactionAsNotMiscategorized, exports.deleteTransactionAttachment = _a.deleteTransactionAttachment, exports.deleteTransactionAttachmentFailure = _a.deleteTransactionAttachmentFailure, exports.deleteTransactionAttachmentSuccess = _a.deleteTransactionAttachmentSuccess, exports.updateStatusForTransactionNotMiscategorizedUpdate = _a.updateStatusForTransactionNotMiscategorizedUpdate, exports.updateStatusConsolidatedSaveTransactionDetail = _a.updateStatusConsolidatedSaveTransactionDetail, exports.updateTransactionStateIfUpdateActionNotAllowed = _a.updateTransactionStateIfUpdateActionNotAllowed, exports.saveTransactionDetail = _a.saveTransactionDetail, exports.initializeTransactionDetailLocalData = _a.initializeTransactionDetailLocalData, exports.saveTransactionDetailLocalData = _a.saveTransactionDetailLocalData, exports.clearTransactionDetailLocalData = _a.clearTransactionDetailLocalData, exports.resetLineItemsCategoryClassInLocalData = _a.resetLineItemsCategoryClassInLocalData, exports.setAllLineItemsToCategoryClassInLocalData = _a.setAllLineItemsToCategoryClassInLocalData, exports.setAllLineItemsLocalDataIsUpdateAllChecked = _a.setAllLineItemsLocalDataIsUpdateAllChecked, exports.setEntityRecommendationForLineIdsForTransactionDetail = _a.setEntityRecommendationForLineIdsForTransactionDetail, exports.markCategoryClassRecommendationsInProgressForTransactionDetail = _a.markCategoryClassRecommendationsInProgressForTransactionDetail, exports.markCategoryClassRecommendationsCompletedForTransactionDetail = _a.markCategoryClassRecommendationsCompletedForTransactionDetail, exports.markCategoryClassRecommendationsFailureForTransactionDetail = _a.markCategoryClassRecommendationsFailureForTransactionDetail, exports.removeEntityRecommendationForLineIdForTransactionDetail = _a.removeEntityRecommendationForLineIdForTransactionDetail, exports.updateSelectedVendor = _a.updateSelectedVendor, exports.updateSelectedCustomer = _a.updateSelectedCustomer, exports.resetVendor = _a.resetVendor, exports.resetSelectedCustomer = _a.resetSelectedCustomer, exports.updateLocalDataWithTransactionsUpdateWithVendorCheckbox = _a.updateLocalDataWithTransactionsUpdateWithVendorCheckbox, exports.updateVendorToAllLineItems = _a.updateVendorToAllLineItems, exports.resetAllLineItemsToVendor = _a.resetAllLineItemsToVendor, exports.updateLatestSelectedEntity = _a.updateLatestSelectedEntity, exports.updateVendorBulkRecommendationsFetchStatus = _a.updateVendorBulkRecommendationsFetchStatus, exports.setIsVendorUpdateAllChecked = _a.setIsVendorUpdateAllChecked, exports.addSplitLine = _a.addSplitLine, exports.deleteSplitLine = _a.deleteSplitLine, exports.toggleSplitEditMode = _a.toggleSplitEditMode;
 exports.default = transactionDetail.reducer;
 function getUpdatedEntityLocalData(detail, updates, entity, resetRecommendations, type) {
     const key = type === 'customer' ? 'customerUpdates' : 'vendorUpdates';

package/lib/view/transactionDetail/transactionDetailState.d.ts

@@ -1,4 +1,5 @@
 import { FetchState, FetchStateAndError, FetchedState, ID } from '../../commonStateTypes/common';
+import { Amount } from '../../commonStateTypes/amount';
 import { Recommendation } from '../../commonStateTypes/recommendationBase';
 import { AccountBase } from '../../entity/account/accountState';
 import { ClassBase } from '../../entity/class/classState';
@@ -6,9 +7,10 @@ import { CustomerBase } from '../../entity/customer/customerState';
 import { EntityType } from '../../entity/genericEntity/entity';
 import { ProjectBase } from '../../entity/project/projectState';
 import { Transaction, TransactionID } from '../../entity/transaction/stateTypes/transaction';
+import { TransactionCategory } from '../../entity/transaction/stateTypes/transactionType';
 import { VendorBase } from '../../entity/vendor/vendorState';
 import { EntityRecommendationKey } from '../recommendation/recommendationState';
-import { TransactionDetailLocalData } from './transactionDetailTypes';
+import { TransactionDetailLineItemData, TransactionDetailLocalData } from './transactionDetailTypes';
 export declare const getTransactionDetailKey: (transactionId: TransactionID) => `${string}_bill` | `${string}_expense` | `${string}_check` | `${string}_refund` | `${string}_invoice` | `${string}_payment` | `${string}_credit_memo` | `${string}_sales_receipt` | `${string}_delayed_credit` | `${string}_delayed_charge` | `${string}_bill_payment` | `${string}_bill_payment_check` | `${string}_bill_payment_credit_card` | `${string}_vendor_credit` | `${string}_credit_card_credit` | `${string}_transfer` | `${string}_credit_card_payment` | `${string}_deposit` | `${string}_journal_entry`;
 export type TransactionDetailKey = ReturnType<typeof getTransactionDetailKey>;
 export declare const getZeniTransactionDetailKey: (transactionId: TransactionID) => `${string}_bill` | `${string}_expense` | `${string}_check` | `${string}_refund` | `${string}_invoice` | `${string}_payment` | `${string}_credit_memo` | `${string}_sales_receipt` | `${string}_delayed_credit` | `${string}_delayed_charge` | `${string}_bill_payment` | `${string}_bill_payment_check` | `${string}_bill_payment_credit_card` | `${string}_vendor_credit` | `${string}_credit_card_credit` | `${string}_transfer` | `${string}_credit_card_payment` | `${string}_deposit` | `${string}_journal_entry`;
@@ -50,9 +52,12 @@ export interface TransactionDetailState {
 }
 export interface TransactionLineUpdates {
     account?: AccountBase;
+    amount?: Amount;
     class?: ClassBase;
     customer?: CustomerBase;
     lineDescription?: string;
+    postingType?: TransactionCategory;
+    postingTypeName?: string;
     project?: ProjectBase;
     recommendation?: Recommendation[];
     vendor?: VendorBase;
@@ -78,5 +83,7 @@ export interface TransactionSaveUpdates {
     entityRelatedUpdates: Record<EntityRecommendationKey, EntityRelatedRecommendationUpdates>;
     markAsMiscatUpdates: boolean;
     updates: TransactionUpdates;
+    addedLines?: TransactionDetailLineItemData[];
+    deletedLineIds?: ID[];
 }
 export {};

package/lib/view/transactionDetail/transactionDetailTypes.d.ts

@@ -50,7 +50,9 @@ export interface TransactionDetailLocalData {
         qboId: ID;
     };
     customerUpdates?: TransactionVendorUpdates;
+    deletedLineIds?: ID[];
     documentId?: string;
+    editMode?: boolean;
     latestSelectedEntityOnLineItem?: Entity;
     latestUpdatedLineWithEntity?: ID;
     memo?: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zeniai/client-epic-state",
-  "version": "5.1.42-betaDI4",
+  "version": "5.1.42",
   "description": "Shared module between Web & Mobile containing required abstractions for state management, async network communication. ",
   "main": "lib/index.js",
   "module": "lib/esm/index.js",