@zeniai/client-epic-state 5.1.42-betaDI4 → 5.1.42

package/lib/esm/view/taskManager/taskDetailView/taskDetailSelector.js

@@ -1,8 +1,8 @@
 import isEqual from 'lodash/isEqual';
-import { reduceAnyFetchState } from '../../../commonStateTypes/reduceFetchState';
+import { reduceFetchState } from '../../../commonStateTypes/reduceFetchState';
 import { getClassesByIds } from '../../../entity/class/classSelector';
 import { getFilesByFileIds } from '../../../entity/file/fileSelector';
-import { getTaskById, getTasksByIds } from '../../../entity/task/taskSelector';
+import { getTaskById } from '../../../entity/task/taskSelector';
 import { getUserAndUserRole, } from '../../companyView/types/userAndRole';
 import { getFileDeleteStatusById, getFileUpdateNameStatusById, } from '../../fileView/fileViewSelector';
 import { getUserList, } from '../../userListView/userListViewSelector';
@@ -27,13 +27,8 @@ export const getTaskDetail = (state, taskId) => {
     let recurringSourceTaskId = undefined;
     let snoozedUntil = undefined;
     let taskGroupId = undefined;
-    let subtasks = [];
     if (taskId != null && sourceTaskDetail != null) {
         const taskEntity = getTaskById(taskState, taskId);
-        subtasks =
-            taskEntity != null
-                ? getTasksByIds(taskState, taskEntity.subTasksIds)
-                : [];
         const fileIdsInEntity = taskEntity?.fileIds ?? [];
         if (taskEntity != null) {
             createdByUser = getUserAndUserRole(userState, userRoleState, addressState, taskEntity.createdBy);
@@ -43,37 +38,26 @@ export const getTaskDetail = (state, taskId) => {
             snoozedUntil = taskEntity.snoozedUntil;
             taskGroupId = taskEntity.taskGroupIds[0];
         }
-        // Treat "no entry" as Completed so it doesn't block the combined
-        // fetch state. The Not-Started default would pin the detail page
-        // below Completed forever before the first fetchSubTasks dispatches.
-        const completedSubTaskStatus = {
-            fetchState: 'Completed',
-            error: undefined,
-        };
-        const subTaskStatus = taskDetailState.subTaskListFetchStatusByParentId[taskId] ??
-            completedSubTaskStatus;
         if (fileIdsInEntity.length > 0) {
-            fetchStatus = reduceAnyFetchState([
+            fetchStatus = reduceFetchState([
                 fileViewState.fetchFilesStatus,
                 sourceTaskDetail.fetchTaskStatus,
                 userList,
                 classListState,
-                subTaskStatus,
             ]);
         }
         else {
-            fetchStatus = reduceAnyFetchState([
+            fetchStatus = reduceFetchState([
                 sourceTaskDetail.fetchTaskStatus,
                 userList,
                 classListState,
-                subTaskStatus,
             ]);
         }
         showTaskDetailFormFooter = showFormFooter(sourceTaskDetail.taskDetailLocalData, taskEntity);
         taskHistory = taskDetailState.taskHistoryById[taskId]?.historicEvents ?? [];
     }
     else if (taskId == null) {
-        fetchStatus = reduceAnyFetchState([userList, classListState]);
+        fetchStatus = reduceFetchState([userList, classListState]);
     }
     const { classIds } = classListState;
     const allAccountingClasses = getClassesByIds(classState, {
@@ -106,7 +90,6 @@ export const getTaskDetail = (state, taskId) => {
         showTaskDetailFormFooter,
         snoozedUntil,
         taskGroupId,
-        subtasks,
     };
 };
 export const allTaskStatus = [
@@ -154,16 +137,13 @@ export const allTaskPriority = [
     },
 ];
 const showFormFooter = (taskDetailLocalData, taskDetailInStore) => {
-    if (taskDetailInStore == null) {
-        return false;
-    }
-    if (taskDetailLocalData.name !== taskDetailInStore.name ||
+    if (taskDetailLocalData.name !== taskDetailInStore?.name ||
         taskDetailLocalData.description !== taskDetailInStore.description ||
         taskDetailLocalData.priority !== taskDetailInStore.priority.code ||
         taskDetailLocalData.status !== taskDetailInStore.status.code ||
         !isEqual(taskDetailInStore.tagIds, taskDetailLocalData.tagIds) ||
-        !isEqual(taskDetailLocalData.assignee, taskDetailInStore.assignees ?? []) ||
-        !isEqual(taskDetailLocalData.groupAssignees, taskDetailInStore.groupAssignees ?? []) ||
+        !isEqual(taskDetailLocalData.assignee, taskDetailInStore?.assignees ?? []) ||
+        !isEqual(taskDetailLocalData.groupAssignees, taskDetailInStore?.groupAssignees ?? []) ||
         !isEqual(taskDetailLocalData.fileIds, taskDetailInStore.fileIds ?? []) ||
         !isEqual(taskDetailLocalData.dueDate, taskDetailInStore.dueDate) ||
         !isEqual(taskDetailLocalData.type, taskDetailInStore.type) ||
@@ -171,10 +151,7 @@ const showFormFooter = (taskDetailLocalData, taskDetailInStore) => {
         !isEqual(taskDetailLocalData.recurringFrequency, taskDetailInStore.recurringFrequency) ||
         !isEqual(taskDetailLocalData.recurringDaysOfWeek, taskDetailInStore.recurringDaysOfWeek) ||
         !isEqual(taskDetailLocalData.recurringStartDate, taskDetailInStore.recurringStartDate) ||
-        !isEqual(taskDetailLocalData.timeSpent, taskDetailInStore.timeSpent) ||
-        !isEqual(taskDetailLocalData.taskGroupId, taskDetailInStore.taskGroupIds.length > 0
-            ? taskDetailInStore.taskGroupIds[0]
-            : undefined)) {
+        !isEqual(taskDetailLocalData.timeSpent, taskDetailInStore.timeSpent)) {
         return true;
     }
     return false;

package/lib/esm/view/taskManager/taskListView/epics/fetchTaskListEpic.js

@@ -9,17 +9,15 @@ export const fetchTaskListEpic = (actions$, _state$, zeniAPI) => actions$.pipe(f
         .getJSON(`${zeniAPI.apiEndPoints.taskMicroServiceBaseUrl}/1.0/task-manager/tasks?query=${encodeURIComponent(`{"task_type": "all"}`)}`)
         .pipe(mergeMap((response) => {
         if (isSuccessResponse(response) && response.data != null) {
-            const { tasks, deleted, archived, snoozed, completed } = response.data;
+            const { tasks, deleted, archived, snoozed } = response.data;
             const allTasks = [
                 ...tasks,
-                ...(completed ?? []),
                 ...(deleted ?? []),
                 ...(archived ?? []),
                 ...(snoozed ?? []),
             ];
             return of(updateTasks(allTasks), updateTaskList({
                 data: tasks,
-                completed: completed ?? [],
                 deleted: deleted ?? [],
                 archived: archived ?? [],
                 snoozed: snoozed ?? [],

package/lib/esm/view/taskManager/taskListView/taskList.js

@@ -1,7 +1,6 @@
 import { stringToUnion, stringToUnionStrict, } from '../../../commonStateTypes/stringToUnion';
 export const ALL_TASK_LIST_TABS = [
     'live',
-    'completed',
     'archived',
     'deleted',
     'snoozed',

package/lib/esm/view/taskManager/taskListView/taskListReducer.js

@@ -1,5 +1,4 @@
 import { createSlice } from '@reduxjs/toolkit';
-import { updateTasks } from '../../../entity/task/taskReducer';
 import { toPriorityCodeType, toTaskStatusCodeType, } from '../../../entity/task/taskState';
 import { date, dateNow } from '../../../zeniDayJS';
 import { toDueDateGroupKeyType, } from './taskList';
@@ -43,7 +42,6 @@ export const initialState = {
     currentTab: 'live',
     byTab: {
         live: { ...initialTabData },
-        completed: { ...initialTabData },
         archived: { ...initialTabData },
         deleted: { ...initialTabData },
         snoozed: { ...initialTabData },
@@ -65,12 +63,14 @@ export const initialState = {
     },
     filters: {
         categoryCombinationOperator: 'AND',
-        // Default to no filters. The Completed tab now owns the "hide resolved
-        // tasks from the live list" responsibility via the byTab split in
-        // updateTaskList / updateTaskFromListView / the updateTasks
-        // extraReducer. Keeping the historical `status != resolved` filter
-        // here would empty out the Completed tab.
-        categories: [],
+        categories: [
+            {
+                field: 'status',
+                matchingOperator: 'not_equal',
+                values: ['resolved'],
+                valuesCombinationOperator: 'ANY',
+            },
+        ],
     },
     hasValidState() {
         return this.fetchState == 'Completed';
@@ -102,16 +102,13 @@ const taskList = createSlice({
             draft.error = undefined;
         },
         updateTaskList(draft, action) {
-            const { data, archived, completed, deleted, snoozed } = action.payload;
+            const { data, archived, deleted, snoozed } = action.payload;
             draft.fetchState = 'Completed';
             draft.error = undefined;
             // Group live tasks
             const liveGrouped = getGroupedTaskIds(data);
             draft.byTab.live = toTabData(liveGrouped);
             // Group other tabs if provided
-            if (completed != null) {
-                draft.byTab.completed = toTabData(getGroupedTaskIds(completed));
-            }
             if (archived != null) {
                 draft.byTab.archived = toTabData(getGroupedTaskIds(archived));
             }
@@ -357,26 +354,9 @@ const taskList = createSlice({
                 draft.taskIdsByAssignees[assigneeKey] = draft.taskIdsByAssignees[assigneeKey].filter((taskId) => taskId !== currentTaskState.id);
                 draft.taskIdsByTags[tagsKey] = draft.taskIdsByTags[tagsKey].filter((taskId) => taskId !== currentTaskState.id);
                 draft.taskIdsByDueDate[dueDateKey] = draft.taskIdsByDueDate[dueDateKey].filter((taskId) => taskId !== currentTaskState.id);
-                // Remove from EVERY previous group bucket the task lived in, not
-                // just the destination bucket. Otherwise a detail-page save that
-                // moves a task from group A to group B leaves the row listed
-                // under both A and B until refetch.
-                const previousGroupIds = currentTaskState.taskGroupIds ?? [];
-                const allGroupIdsToClean = new Set([
-                    ...previousGroupIds,
-                    taskGroupId,
-                ]);
-                allGroupIdsToClean.forEach((gid) => {
-                    if (draft.taskIdsByGroupsIds[gid] != null) {
-                        draft.taskIdsByGroupsIds[gid] = draft.taskIdsByGroupsIds[gid].filter((id) => id !== currentTaskState.id);
-                    }
-                });
+                draft.taskIdsByGroupsIds[taskGroupId] = draft.taskIdsByGroupsIds[taskGroupId].filter((taskId) => taskId !== currentTaskState.id);
             }
             doUpdateTaskList(draft, task, taskGroupId);
-            // Mirror top-level grouping into the active tab's byTab snapshot,
-            // otherwise the next updateTaskListTab call copies stale byTab data
-            // back over this optimistic update.
-            syncTopLevelToActiveTab(draft);
         },
         updateTaskListOnCreateTaskFromTemplateSuccess(draft, action) {
             const { tasks } = action.payload;
@@ -400,7 +380,6 @@ const taskList = createSlice({
             const taskId = task.id;
             draft.updateTasksFetchState.fetchState = 'In-Progress';
             draft.updateTasksFetchState.error = undefined;
-            let didMigrateTab = false;
             if (updates.priority != null) {
                 const prevPriorityCode = toPriorityCodeType(task.priority.code);
                 draft.taskIdsByPriority[prevPriorityCode] = draft.taskIdsByPriority[prevPriorityCode].filter((id) => id != taskId);
@@ -412,25 +391,6 @@ const taskList = createSlice({
                 draft.taskIdsByStatus[prevStatusCode] = draft.taskIdsByStatus[prevStatusCode].filter((id) => id != taskId);
                 const newStatusCode = toTaskStatusCodeType(updates.status.code);
                 draft.taskIdsByStatus[newStatusCode].push(taskId);
-                // Optimistically re-bucket between the live and completed tabs
-                // when status transitions in/out of "resolved", so the task
-                // moves to the Completed tab without waiting for the next
-                // fetch. Mirrors backend split in task_handler.py: only
-                // `resolved` counts as completed; `done` stays Active.
-                //
-                // Subtasks travel with their parent — they appear nested under
-                // the parent row, not as standalone entries in byTab.taskIds.
-                // So we only rebucket parent tasks (tasks with no parentTaskId).
-                const isTopLevelTask = task.parentTaskId == null;
-                const wasCompleted = prevStatusCode === 'resolved';
-                const isCompleted = newStatusCode === 'resolved';
-                if (isTopLevelTask && wasCompleted !== isCompleted) {
-                    const from = isCompleted ? 'live' : 'completed';
-                    const to = isCompleted ? 'completed' : 'live';
-                    const updatedTask = { ...task, ...updates };
-                    migrateTaskBetweenTabs(draft, taskId, updatedTask, from, to);
-                    didMigrateTab = true;
-                }
             }
             if (updates.assignees != null) {
                 const prevGroupId = getAssigneesGroupKey(task.assignees);
@@ -470,18 +430,7 @@ const taskList = createSlice({
                     };
                 }
             }
-            if (didMigrateTab) {
-                // The migration moved the task out of the source byTab and into
-                // the destination byTab. The active tab's grouping arrays are
-                // now authoritative — mirror them back to the top-level so the
-                // UI sees the task gone from Live (or freshly arrived in
-                // Completed). Inverse of syncTopLevelToActiveTab, used only on
-                // this path.
-                copyTabDataToTopLevel(draft, draft.byTab[draft.currentTab]);
-            }
-            else {
-                syncTopLevelToActiveTab(draft);
-            }
+            syncTopLevelToActiveTab(draft);
         },
         updateTasksListOnUpdateTaskSuccess(draft) {
             draft.updateTasksFetchState.fetchState = 'Completed';
@@ -494,80 +443,12 @@ const taskList = createSlice({
         removeTaskFromList(draft, action) {
             removeTaskIds(draft, [action.payload]);
         },
-        /**
-         * Remove a task id from a single group bucket without touching tab
-         * membership or other groupings. Used when the user clears a task's
-         * group on the Detail page so the row stops appearing under the old
-         * group while saveTaskDetailEpic skips the standard list re-insert.
-         */
-        removeTaskFromGroupBucket(draft, action) {
-            const { taskId, taskGroupId } = action.payload;
-            if (draft.taskIdsByGroupsIds[taskGroupId] != null) {
-                draft.taskIdsByGroupsIds[taskGroupId] = draft.taskIdsByGroupsIds[taskGroupId].filter((id) => id !== taskId);
-            }
-            // Mirror to the active tab's grouping so the UI re-renders.
-            const activeTab = draft.byTab[draft.currentTab];
-            if (activeTab.taskIdsByGroupsIds[taskGroupId] != null) {
-                activeTab.taskIdsByGroupsIds[taskGroupId] =
-                    activeTab.taskIdsByGroupsIds[taskGroupId].filter((id) => id !== taskId);
-            }
-        },
         clearTaskList(draft) {
             Object.assign(draft, initialState);
         },
     },
-    extraReducers: (builder) => {
-        // When the entity store receives updated tasks (e.g. from task detail
-        // save, snooze/archive/unarchive, etc.), re-bucket parent tasks between
-        // the live and completed tabs based on the new status. Mirrors the
-        // backend split in task_handler.py: only `resolved` parents count as
-        // completed. Subtasks are nested under their parent row, so they
-        // never move between tabs on their own.
-        builder.addCase(updateTasks, (draft, action) => {
-            action.payload.forEach((taskPayload) => {
-                // Only re-bucket parents; subtasks (parent_task_id is a non-empty
-                // string) are nested under their parent row and don't move tabs.
-                if (taskPayload.parent_task_id != null &&
-                    taskPayload.parent_task_id !== '') {
-                    return;
-                }
-                const taskId = taskPayload.task_id;
-                // `TaskPayload.status` is required per the type — every producer
-                // in this repo sends it, and `mapTaskPayloadToTask` dereferences
-                // it unguarded. The optional chain + null guard are defensive
-                // only, in case a downstream consumer (web-app-ui / cockpit-ui)
-                // ever dispatches `updateTasks` with a partial payload; in that
-                // case we treat missing status as "no status change" and skip
-                // re-bucketing so we don't migrate a Completed task back into
-                // the Live tab.
-                const statusCode = taskPayload.status?.code;
-                if (statusCode == null) {
-                    return;
-                }
-                const isCompleted = statusCode === 'resolved';
-                const targetTab = isCompleted ? 'completed' : 'live';
-                const otherTab = isCompleted ? 'live' : 'completed';
-                // Skip if the task isn't currently in either of these buckets
-                // (archived/snoozed/deleted are managed by their own actions).
-                const inLive = draft.byTab.live.taskIds.includes(taskId);
-                const inCompleted = draft.byTab.completed.taskIds.includes(taskId);
-                if (!inLive && !inCompleted) {
-                    return;
-                }
-                if (draft.byTab[otherTab].taskIds.includes(taskId)) {
-                    migrateTaskPayloadBetweenTabs(draft, taskId, taskPayload, otherTab, targetTab);
-                }
-                else if (!draft.byTab[targetTab].taskIds.includes(taskId)) {
-                    draft.byTab[targetTab].taskIds.push(taskId);
-                }
-            });
-            // Re-sync the top-level taskIds / grouping arrays for whichever
-            // tab the user is currently looking at.
-            copyTabDataToTopLevel(draft, draft.byTab[draft.currentTab]);
-        });
-    },
 });
-export const { fetchTaskListPage, fetchTaskList, updateTaskList, updateTaskListTab, updateTaskListFetchStatus, updateTaskListSearchText, updateTaskListUIState, updateTaskFilters, updateTaskListOnNewGroupCreationSuccess, bulkUpdateTaskList, updateTasksListOnBulkUpdateTasksSuccess, updateTasksListOnBulkUpdateTasksFailure, initiateTaskListLocalData, updateTaskListLocalData, updateTaskListOnTaskGroupDeletion, dragNDropTasks, updateTaskListOnNewTaskCreationSuccess, updateTaskListOnTaskGroupNameUpdate, updateTaskFromListView, updateTasksListOnUpdateTaskSuccess, updateTasksListOnUpdateTaskFailure, updateTaskListOnCreateTaskFromTemplateSuccess, removeTaskFromList, removeTaskFromGroupBucket, clearTaskList, } = taskList.actions;
+export const { fetchTaskListPage, fetchTaskList, updateTaskList, updateTaskListTab, updateTaskListFetchStatus, updateTaskListSearchText, updateTaskListUIState, updateTaskFilters, updateTaskListOnNewGroupCreationSuccess, bulkUpdateTaskList, updateTasksListOnBulkUpdateTasksSuccess, updateTasksListOnBulkUpdateTasksFailure, initiateTaskListLocalData, updateTaskListLocalData, updateTaskListOnTaskGroupDeletion, dragNDropTasks, updateTaskListOnNewTaskCreationSuccess, updateTaskListOnTaskGroupNameUpdate, updateTaskFromListView, updateTasksListOnUpdateTaskSuccess, updateTasksListOnUpdateTaskFailure, updateTaskListOnCreateTaskFromTemplateSuccess, removeTaskFromList, clearTaskList, } = taskList.actions;
 export default taskList.reducer;
 /**
  *  helpers
@@ -674,115 +555,6 @@ const copyTabDataToTopLevel = (draft, tabData) => {
     draft.taskIdsByDueDate = tabData.taskIdsByDueDate;
     draft.taskIdsByTags = tabData.taskIdsByTags;
 };
-/**
- * Migrate a parent task between two `byTab` buckets (live ↔ completed)
- * when its status flips into / out of `resolved`. The destination tab
- * picks up the task in EVERY grouping dimension (status, priority,
- * group id, assignees, dueDate, tags) using the UPDATED task as the
- * source-of-truth for the new bucket keys. Otherwise the Completed tab
- * shows the task in the right tab-level list but the grouped views
- * (Group by Status, Group by Priority, etc.) miss it until the next
- * full fetch.
- */
-const migrateTaskBetweenTabs = (draft, taskId, updatedTask, from, to) => {
-    const fromTab = draft.byTab[from];
-    const toTab = draft.byTab[to];
-    // Source tab: drop the task from every grouping dimension.
-    removeIdsFromTabData(fromTab, [taskId]);
-    // Destination tab: add the task to taskIds (deduped) plus the
-    // appropriate bucket inside each grouping dimension based on the
-    // updated task.
-    if (!toTab.taskIds.includes(taskId)) {
-        toTab.taskIds.push(taskId);
-    }
-    const priorityKey = toPriorityCodeType(updatedTask.priority.code);
-    if (!toTab.taskIdsByPriority[priorityKey].includes(taskId)) {
-        toTab.taskIdsByPriority[priorityKey].push(taskId);
-    }
-    const statusKey = toTaskStatusCodeType(updatedTask.status.code);
-    if (!toTab.taskIdsByStatus[statusKey].includes(taskId)) {
-        toTab.taskIdsByStatus[statusKey].push(taskId);
-    }
-    const dueDateKey = updatedTask.dueDate != null
-        ? getDueDateGroupKey(updatedTask.dueDate.toString())
-        : 'upcoming';
-    if (!toTab.taskIdsByDueDate[dueDateKey].includes(taskId)) {
-        toTab.taskIdsByDueDate[dueDateKey].push(taskId);
-    }
-    const assigneeKey = getAssigneesGroupKey(updatedTask.assignees);
-    if (toTab.taskIdsByAssignees[assigneeKey] == null) {
-        toTab.taskIdsByAssignees[assigneeKey] = [taskId];
-    }
-    else if (!toTab.taskIdsByAssignees[assigneeKey].includes(taskId)) {
-        toTab.taskIdsByAssignees[assigneeKey].push(taskId);
-    }
-    const tagIds = [...updatedTask.tagIds].sort();
-    const tagsKey = tagIds.join(',');
-    if (toTab.taskIdsByTags[tagsKey] == null) {
-        toTab.taskIdsByTags[tagsKey] = [taskId];
-    }
-    else if (!toTab.taskIdsByTags[tagsKey].includes(taskId)) {
-        toTab.taskIdsByTags[tagsKey].push(taskId);
-    }
-    (updatedTask.taskGroupIds ?? []).forEach((groupId) => {
-        if (toTab.taskIdsByGroupsIds[groupId] == null) {
-            toTab.taskIdsByGroupsIds[groupId] = [taskId];
-        }
-        else if (!toTab.taskIdsByGroupsIds[groupId].includes(taskId)) {
-            toTab.taskIdsByGroupsIds[groupId].push(taskId);
-        }
-    });
-};
-/**
- * `updateTasks` extraReducer variant — same migration semantics but
- * keyed off the raw `TaskPayload` instead of the rich `Task` entity.
- */
-const migrateTaskPayloadBetweenTabs = (draft, taskId, payload, from, to) => {
-    const fromTab = draft.byTab[from];
-    const toTab = draft.byTab[to];
-    removeIdsFromTabData(fromTab, [taskId]);
-    if (!toTab.taskIds.includes(taskId)) {
-        toTab.taskIds.push(taskId);
-    }
-    if (payload.priority?.code != null) {
-        const priorityKey = toPriorityCodeType(payload.priority.code);
-        if (!toTab.taskIdsByPriority[priorityKey].includes(taskId)) {
-            toTab.taskIdsByPriority[priorityKey].push(taskId);
-        }
-    }
-    if (payload.status?.code != null) {
-        const statusKey = toTaskStatusCodeType(payload.status.code);
-        if (!toTab.taskIdsByStatus[statusKey].includes(taskId)) {
-            toTab.taskIdsByStatus[statusKey].push(taskId);
-        }
-    }
-    const dueDateKey = getDueDateGroupKey(payload.due_date);
-    if (!toTab.taskIdsByDueDate[dueDateKey].includes(taskId)) {
-        toTab.taskIdsByDueDate[dueDateKey].push(taskId);
-    }
-    const assigneeKey = getAssigneesGroupKey(payload.assignees ?? []);
-    if (toTab.taskIdsByAssignees[assigneeKey] == null) {
-        toTab.taskIdsByAssignees[assigneeKey] = [taskId];
-    }
-    else if (!toTab.taskIdsByAssignees[assigneeKey].includes(taskId)) {
-        toTab.taskIdsByAssignees[assigneeKey].push(taskId);
-    }
-    const tagsKey = getTagsGroupKey(payload.tags ?? []);
-    if (toTab.taskIdsByTags[tagsKey] == null) {
-        toTab.taskIdsByTags[tagsKey] = [taskId];
-    }
-    else if (!toTab.taskIdsByTags[tagsKey].includes(taskId)) {
-        toTab.taskIdsByTags[tagsKey].push(taskId);
-    }
-    (payload.task_group_ids ?? []).forEach((groupId) => {
-        if (toTab.taskIdsByGroupsIds[groupId] == null) {
-            toTab.taskIdsByGroupsIds[groupId] = [taskId];
-        }
-        else if (!toTab.taskIdsByGroupsIds[groupId].includes(taskId)) {
-            toTab.taskIdsByGroupsIds[groupId].push(taskId);
-        }
-    });
-};
 const removeIdsFromTabData = (tabData, taskIds) => {
     const removedSet = new Set(taskIds);
     const isRemoved = (id) => removedSet.has(id);

package/lib/esm/view/taskManager/taskListView/taskListSelector.js

@@ -334,7 +334,6 @@ export const getAllTasks = createSelector((state) => state.taskListState, (state
     const taskGroupTemplates = getTaskGroupTemplateByIds(taskGroupTemplateState, taskGroupTemplateViewState.taskGroupTemplateIds);
     const tabCounts = {
         live: taskListState.byTab.live.taskIds.length,
-        completed: taskListState.byTab.completed.taskIds.length,
         archived: taskListState.byTab.archived.taskIds.length,
         deleted: taskListState.byTab.deleted.taskIds.length,
         snoozed: taskListState.byTab.snoozed.taskIds.length,

package/lib/esm/view/taskManager/taskListView/taskListViewHelpers.js

@@ -48,61 +48,3 @@ export const getTaskUpdates = (groupByKey, groupId) => {
         taskGroupIds: [groupId],
     };
 };
-/**
- * Sort a subtask list by one of the sortable columns. Pure — no state
- * dependency. `statusOrder` is derived from `allTaskStatus` so any new
- * status added upstream slots in by its enum position instead of
- * falling into a catch-all bucket.
- */
-export const sortSubtasks = (subtasks, sortKey, sortOrder, userList, tagList) => {
-    if (sortKey == null) {
-        return subtasks;
-    }
-    const statusOrder = allTaskStatus.reduce((acc, status, index) => {
-        acc[status.code] = index;
-        return acc;
-    }, {});
-    const unknownStatusRank = allTaskStatus.length;
-    const cmpStr = (a, b) => a.localeCompare(b, undefined, { sensitivity: 'base' });
-    const keyFn = (task) => {
-        if (sortKey === 'name') {
-            return task.name ?? '';
-        }
-        if (sortKey === 'status') {
-            return statusOrder[task.status.code] ?? unknownStatusRank;
-        }
-        if (sortKey === 'assignee') {
-            const firstId = task.assignees?.[0];
-            if (firstId == null) {
-                return '';
-            }
-            const user = userList.find((candidate) => candidate.userId === firstId);
-            return user
-                ? `${user.firstName ?? ''} ${user.lastName ?? ''}`.trim()
-                : '';
-        }
-        if (sortKey === 'tag') {
-            const firstTagId = task.tagIds?.[0];
-            if (firstTagId == null) {
-                return '';
-            }
-            const tag = tagList.find((candidate) => candidate.tagId === firstTagId);
-            return tag?.name ?? '';
-        }
-        return '';
-    };
-    const copy = [...subtasks];
-    copy.sort((a, b) => {
-        const av = keyFn(a);
-        const bv = keyFn(b);
-        let cmp;
-        if (typeof av === 'number' && typeof bv === 'number') {
-            cmp = av - bv;
-        }
-        else {
-            cmp = cmpStr(String(av), String(bv));
-        }
-        return sortOrder === 'asc' ? cmp : -cmp;
-    });
-    return copy;
-};

package/lib/esm/view/transactionDetail/epics/saveTransactionHelper.js

@@ -45,7 +45,15 @@ export const toTransactionUpdatesFromTransactionDetailLocalData = (transactionDe
     let lastUpdatedCategory;
     let lastUpdatedClass;
     // single recommendation to just pick the last recommendation in the list of lines
+    const existingLineIds = new Set(transaction.lines?.map((l) => l.id) ?? []);
+    const deletedLineIds = new Set((transactionDetailLocalData.deletedLineIds ?? []).filter((id) => existingLineIds.has(id)));
+    // Collect new lines — in lineItemById but not yet in transaction.lines.
+    const addedLines = Object.values(transactionDetailLocalData.lineItemById).filter((item) => !existingLineIds.has(item.id));
     transaction.lines?.forEach((line) => {
+        // Skip lines the user deleted in edit mode.
+        if (deletedLineIds.has(line.id)) {
+            return;
+        }
         const lineItem = transactionDetailLocalData.lineItemById[line.id];
         if (line.type === 'transaction_with_account_and_class_line' ||
             line.type === 'transaction_with_product_or_service_line' ||
@@ -56,6 +64,7 @@ export const toTransactionUpdatesFromTransactionDetailLocalData = (transactionDe
             const entityDetails = getEntityDetails(selectedEntity, lineItem, transactionDetailLocalData.vendorUpdates, transactionDetailLocalData.customerUpdates);
             updatesByLineId[line.id] = {
                 lineDescription: lineItem.lineDescription,
+                amount: lineItem.amount,
                 class: lineItem.class,
                 account: lineItem.account,
                 // Project is at the transaction level for invoice/credit_memo; omit from lines.
@@ -77,6 +86,17 @@ export const toTransactionUpdatesFromTransactionDetailLocalData = (transactionDe
                         currentSelectedEntityLine.type === 'vendor'
                         ? lineItem.vendor
                         : undefined,
+                    // Carry the JE debit/credit side so a split edit that flips an
+                    // existing line's posting side persists through the line patch.
+                    ...(line.type === 'journal_entry_transaction_line'
+                        ? {
+                            postingType: lineItem.postingType,
+                            postingTypeName: lineItem.postingType != null
+                                ? lineItem.postingType.charAt(0).toUpperCase() +
+                                    lineItem.postingType.slice(1)
+                                : lineItem.postingTypeName,
+                        }
+                        : {}),
                 };
             }
             let hasCategoryChanged = false;
@@ -163,6 +183,8 @@ export const toTransactionUpdatesFromTransactionDetailLocalData = (transactionDe
         and all the line items are NOT uncategorized*/
         markAsMiscatUpdates: isTransactionMisCategorized,
         anyBulkUpdates: isBulkUpdate,
+        addedLines: addedLines.length > 0 ? addedLines : undefined,
+        deletedLineIds: deletedLineIds.size > 0 ? [...deletedLineIds] : undefined,
     };
 };
 const doUpdateEntityUpdates = (entityUpdates, entityId, entityType, recommendation, isBulkUpdate = false, updatedEntityId, entityName) => {