@zeniai/client-epic-state 5.0.90-betaAR4 → 5.0.90-betaAS1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (77) hide show
  1. package/lib/entity/approvalRule/approvalRulePayload.d.ts +5 -34
  2. package/lib/entity/approvalRule/approvalRulePayload.js +10 -145
  3. package/lib/entity/approvalRule/approvalRuleSelector.d.ts +1 -25
  4. package/lib/entity/approvalRule/approvalRuleSelector.js +0 -40
  5. package/lib/entity/approvalRule/approvalRuleState.d.ts +7 -59
  6. package/lib/entity/snackbar/snackbarTypes.d.ts +1 -1
  7. package/lib/entity/snackbar/snackbarTypes.js +0 -2
  8. package/lib/epic.d.ts +1 -3
  9. package/lib/epic.js +1 -3
  10. package/lib/esm/entity/approvalRule/approvalRulePayload.js +10 -145
  11. package/lib/esm/entity/approvalRule/approvalRuleSelector.js +0 -35
  12. package/lib/esm/entity/snackbar/snackbarTypes.js +0 -2
  13. package/lib/esm/epic.js +1 -3
  14. package/lib/esm/index.js +7 -8
  15. package/lib/esm/view/spendManagement/billPay/billPayReview/billPayReviewSelector.js +0 -14
  16. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.js +12 -102
  17. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/deleteBillPayApprovalRuleEpic.js +2 -10
  18. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.js +4 -8
  19. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/initializeBillPaySetupApproverViewUpdateDataEpic.js +7 -11
  20. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/saveBillPaySetupApproverViewUpdatesEpic.js +4 -13
  21. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.js +16 -120
  22. package/lib/esm/view/spendManagement/billPay/editBillView/editBillViewSelector.js +4 -60
  23. package/lib/esm/view/spendManagement/billPay/internationalWireVerification/epics/initializeIntlVerificationFormEpic.js +13 -6
  24. package/lib/esm/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationPayload.js +46 -8
  25. package/lib/esm/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationReducer.js +2 -6
  26. package/lib/esm/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationSelector.js +23 -12
  27. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/deleteRemiApprovalRuleEpic.js +2 -10
  28. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.js +2 -8
  29. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/initializeRemiSetupApproverViewUpdateDataEpic.js +7 -11
  30. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/saveRemiSetupApproverViewUpdatesEpic.js +4 -13
  31. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js +11 -76
  32. package/lib/index.d.ts +9 -10
  33. package/lib/index.js +19 -27
  34. package/lib/view/companyTaskManagerView/companyTaskManagerViewReducer.d.ts +2 -2
  35. package/lib/view/companyView/types/cockpitTypes.d.ts +1 -1
  36. package/lib/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.d.ts +1 -1
  37. package/lib/view/people/peopleTypes.d.ts +1 -1
  38. package/lib/view/spendManagement/billPay/billPayReview/billPayReviewSelector.d.ts +0 -7
  39. package/lib/view/spendManagement/billPay/billPayReview/billPayReviewSelector.js +0 -14
  40. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.d.ts +3 -14
  41. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.js +13 -103
  42. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewState.d.ts +0 -16
  43. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/deleteBillPayApprovalRuleEpic.js +2 -10
  44. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.js +4 -8
  45. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/initializeBillPaySetupApproverViewUpdateDataEpic.js +6 -10
  46. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/saveBillPaySetupApproverViewUpdatesEpic.js +3 -12
  47. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.d.ts +1 -59
  48. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.js +17 -122
  49. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonState.d.ts +5 -31
  50. package/lib/view/spendManagement/billPay/editBillView/editBillViewSelector.d.ts +1 -8
  51. package/lib/view/spendManagement/billPay/editBillView/editBillViewSelector.js +4 -60
  52. package/lib/view/spendManagement/billPay/internationalWireVerification/epics/initializeIntlVerificationFormEpic.js +13 -6
  53. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationPayload.d.ts +22 -0
  54. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationPayload.js +49 -9
  55. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationReducer.js +1 -5
  56. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationSelector.js +23 -12
  57. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationState.d.ts +16 -0
  58. package/lib/view/spendManagement/chargeCards/chargeCardList/chargeCardList.d.ts +1 -1
  59. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/deleteRemiApprovalRuleEpic.js +2 -10
  60. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.js +2 -8
  61. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/initializeRemiSetupApproverViewUpdateDataEpic.js +6 -10
  62. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/saveRemiSetupApproverViewUpdatesEpic.js +3 -12
  63. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.d.ts +3 -14
  64. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js +12 -77
  65. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewState.d.ts +0 -12
  66. package/lib/view/taskManager/taskListView/taskList.d.ts +3 -3
  67. package/lib/view/transactionDetail/journalEntryLinesViewModel.d.ts +1 -1
  68. package/package.json +1 -1
  69. package/lib/entity/approvalRule/approvalRuleConflict.d.ts +0 -56
  70. package/lib/entity/approvalRule/approvalRuleConflict.js +0 -77
  71. package/lib/esm/entity/approvalRule/approvalRuleConflict.js +0 -74
  72. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/reorderBillPayApprovalRulesEpic.js +0 -54
  73. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/reorderRemiApprovalRulesEpic.js +0 -49
  74. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/reorderBillPayApprovalRulesEpic.d.ts +0 -23
  75. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/reorderBillPayApprovalRulesEpic.js +0 -58
  76. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/reorderRemiApprovalRulesEpic.d.ts +0 -14
  77. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/reorderRemiApprovalRulesEpic.js +0 -53
@@ -9,17 +9,9 @@ const userReducer_1 = require("../../../../../entity/user/userReducer");
9
9
  const responsePayload_1 = require("../../../../../responsePayload");
10
10
  const billPaySetupApproverViewReducer_1 = require("../billPaySetupApproverViewReducer");
11
11
  const deleteBillPayApprovalRuleEpic = (actions$, _state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(billPaySetupApproverViewReducer_1.deleteBillPayApprovalRule.match), (0, operators_1.switchMap)((action) => {
12
- const { approvalRuleId, useV3 } = action.payload;
13
- // Approval Rules 3.0 — flag-gated endpoint selection.
14
- // Explicit `=== true` keeps `strict-boolean-expressions` happy
15
- // when RTK's payload type widens to `any` in some configs.
16
- const endpoint = useV3 === true
17
- ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules-v2`
18
- : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`;
12
+ const { approvalRuleId } = action.payload;
19
13
  return zeniAPI
20
- .deleteAndGetJSON(endpoint, {
21
- approval_rule_id: approvalRuleId,
22
- })
14
+ .deleteAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`, { approval_rule_id: approvalRuleId })
23
15
  .pipe((0, operators_1.mergeMap)((response) => {
24
16
  if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
25
17
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -9,7 +9,7 @@ const userReducer_1 = require("../../../../../entity/user/userReducer");
9
9
  const responsePayload_1 = require("../../../../../responsePayload");
10
10
  const billPaySetupApproverViewReducer_1 = require("../billPaySetupApproverViewReducer");
11
11
  const fetchBillPaySetupApproverViewEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(billPaySetupApproverViewReducer_1.fetchBillPaySetupApproverView.match), (0, operators_1.switchMap)((action) => {
12
- const { cacheOverride, useV3 } = action.payload;
12
+ const { cacheOverride } = action.payload;
13
13
  const { billPaySetupApproverViewState, approvalRuleState } = state$.value;
14
14
  const approvalRules = (0, approvalRuleSelector_1.getApprovalRulesByIds)(approvalRuleState, billPaySetupApproverViewState.approvalRuleIds);
15
15
  if (cacheOverride === true ||
@@ -17,13 +17,9 @@ const fetchBillPaySetupApproverViewEpic = (actions$, state$, zeniAPI) => actions
17
17
  billPaySetupApproverViewState.approvalRuleIds.length ||
18
18
  (billPaySetupApproverViewState.hasValidState() === false &&
19
19
  billPaySetupApproverViewState.fetchState !== 'In-Progress')) {
20
- // Approval Rules 3.0 — flag-gated endpoint selection.
21
- // Explicit `=== true` keeps `strict-boolean-expressions` happy
22
- // when RTK's payload type widens to `any` in some configs.
23
- const endpoint = useV3 === true
24
- ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules-v2`
25
- : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`;
26
- return zeniAPI.getJSON(endpoint).pipe((0, operators_1.mergeMap)((response) => {
20
+ return zeniAPI
21
+ .getJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`)
22
+ .pipe((0, operators_1.mergeMap)((response) => {
27
23
  if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
28
24
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
29
25
  const actions = [
@@ -11,20 +11,16 @@ const initializeBillPaySetupApproverViewUpdateDataEpic = (actions$, state$) => a
11
11
  if (approvalRuleId != null) {
12
12
  const approvalRule = (0, approvalRuleSelector_1.getApprovalRuleById)(state$.value.approvalRuleState, approvalRuleId);
13
13
  if (approvalRule != null) {
14
+ const criteria = approvalRule.criteria[0];
15
+ const range = criteria?.range;
14
16
  const billPaySetupApproverViewUpdateData = {
15
17
  approvalRuleId,
16
18
  steps: approvalRule.steps,
17
19
  criteria: {
18
- amount: (0, approvalRuleSelector_1.getAmountCriteria)(approvalRule.criteria),
19
- vendor: (0, approvalRuleSelector_1.getVendorCriteria)(approvalRule.criteria),
20
- department: (0, approvalRuleSelector_1.getDepartmentCriteria)(approvalRule.criteria),
20
+ rangeType: criteria?.rangeType,
21
+ rangeEntity: criteria?.rangeEntity,
22
+ range,
21
23
  },
22
- // Approval Rules 3.0 — seed rule-level fields so the form can
23
- // round-trip them on edit. Each may be undefined on legacy rules.
24
- name: approvalRule.name,
25
- description: approvalRule.description,
26
- separationOfDuties: approvalRule.separationOfDuties,
27
- isFallback: approvalRule.isFallback,
28
24
  };
29
25
  fetchActions.push((0, billPaySetupApproverViewReducer_1.clearBillPaySetupApproverViewUpdateData)(), (0, billPaySetupApproverViewReducer_1.saveBillPaySetupApproverViewUpdateData)(billPaySetupApproverViewUpdateData));
30
26
  }
@@ -32,7 +28,7 @@ const initializeBillPaySetupApproverViewUpdateDataEpic = (actions$, state$) => a
32
28
  else {
33
29
  const billPaySetupApproverViewCreateData = {
34
30
  steps: [],
35
- criteria: {},
31
+ criteria: undefined,
36
32
  };
37
33
  fetchActions.push((0, billPaySetupApproverViewReducer_1.clearBillPaySetupApproverViewUpdateData)(), (0, billPaySetupApproverViewReducer_1.saveBillPaySetupApproverViewUpdateData)(billPaySetupApproverViewCreateData));
38
34
  }
@@ -9,23 +9,14 @@ const userReducer_1 = require("../../../../../entity/user/userReducer");
9
9
  const responsePayload_1 = require("../../../../../responsePayload");
10
10
  const billPaySetupApproverViewReducer_1 = require("../billPaySetupApproverViewReducer");
11
11
  const commonPayload_1 = require("../types/commonPayload");
12
- const saveBillPaySetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(billPaySetupApproverViewReducer_1.saveBillPaySetupApproverViewUpdates.match), (0, operators_1.switchMap)((action) => {
12
+ const saveBillPaySetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe((0, operators_1.filter)(billPaySetupApproverViewReducer_1.saveBillPaySetupApproverViewUpdates.match), (0, operators_1.switchMap)(() => {
13
13
  const { billPaySetupApproverViewState } = state$.value;
14
14
  const billPaySetupApproverViewUpdateData = billPaySetupApproverViewState.billPaySetupApproverViewUpdateData;
15
15
  if (billPaySetupApproverViewUpdateData != null &&
16
16
  billPaySetupApproverViewUpdateData.data != null) {
17
- // Approval Rules 3.0 — gate URL + write-side payload mapper on
18
- // the `approval_rule_v3_config` dynamic config. `useV3` arrives
19
- // on the action payload from the screen connector.
20
- const { useV3 } = action.payload;
21
- const payload = useV3
22
- ? (0, commonPayload_1.toApprovalChangableInfoPayload)(billPaySetupApproverViewUpdateData.data)
23
- : (0, commonPayload_1.toApprovalChangableInfoPayloadV1)(billPaySetupApproverViewUpdateData.data);
24
- const endpoint = useV3
25
- ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules-v2`
26
- : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`;
17
+ const payload = (0, commonPayload_1.toApprovalChangableInfoPayload)(billPaySetupApproverViewUpdateData.data);
27
18
  return zeniAPI
28
- .postAndGetJSON(endpoint, payload)
19
+ .postAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`, payload)
29
20
  .pipe((0, operators_1.mergeMap)((response) => {
30
21
  if ((0, responsePayload_1.isSuccessResponse)(response) && response.data != null) {
31
22
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -14,67 +14,9 @@ interface ApproverViewStepPayload extends Omit<StepPayload, 'actors'> {
14
14
  }
15
15
  interface ApprovalUpdatableInfoPayload {
16
16
  approval_rule_id: ID;
17
- criteria: CriteriaPayload;
17
+ criteria: CriteriaPayload[];
18
18
  is_applicable_on_pending_approval_entity: boolean;
19
19
  steps: ApproverViewStepPayload[];
20
- description?: string;
21
- is_fallback?: boolean;
22
- is_separation_of_duty_enabled?: boolean;
23
- /**
24
- * Approval Rules 3.0 — rule-level wire fields. The backend accepts these
25
- * as optional today; once 3.0 ships they become first-class. The SoD
26
- * field name matches the GET response shape (confirmed with backend),
27
- * so the same identifier flows both directions on the wire.
28
- */
29
- name?: string;
30
- }
31
- /**
32
- * V1 / pre-3.0 wire shape. Kept so the rollback flag (gated by
33
- * 'approval_rule_v3_config' dynamic config) can target the original
34
- * '/approval-rules' endpoint with the legacy snake_case array of
35
- * range entries. None of the 3.0 rule-level fields are sent.
36
- *
37
- * Reference: 'entityApprovalStatusPayload.json' fixture, which carries
38
- * a real V1 approval rule from the legacy backend:
39
- * criteria: [{type: 'range', range_entity: 'currency',
40
- * min, max, currency_code, currency_symbol}]
41
- * with 'min' / 'max' as scalar numbers and 'null' representing an
42
- * absent bound for one-sided rules. The read-side mapper in
43
- * 'approvalRulePayload.ts' (see 'LegacyAmountRangeCriterionPayload')
44
- * decodes the same shape — write-side has to match.
45
- */
46
- interface ApprovalUpdatableInfoPayloadV1CriterionEntry {
47
- currency_code: string;
48
- currency_symbol: string;
49
- /** Upper bound. 'null' for a 'greater_than' (open-upper) rule. */
50
- max: number | null;
51
- /** Lower bound. 'null' for a 'less_than' (open-lower) rule. */
52
- min: number | null;
53
- range_entity: 'currency';
54
- type: 'range';
55
- }
56
- interface ApprovalUpdatableInfoPayloadV1 {
57
- criteria: ApprovalUpdatableInfoPayloadV1CriterionEntry[];
58
- is_applicable_on_pending_approval_entity: boolean;
59
- steps: ApproverViewStepPayload[];
60
- approval_rule_id?: ID;
61
20
  }
62
21
  export declare const toApprovalChangableInfoPayload: (approverViewUpdateData: ApprovalRuleUpdateData | ApprovalRuleCreateData) => Partial<ApprovalUpdatableInfoPayload>;
63
- /**
64
- * V1 wire mapper — used when 'approval_rule_v3_config' resolves to OFF
65
- * for the current tenant. Emits the legacy snake_case array shape that
66
- * '/approval-rules' historically consumed (see the V1 fixture in
67
- * 'entity/entityApprovalStatus/__mocks__/json/entityApprovalStatusPayload.json'):
68
- * criteria: [{type: 'range', range_entity: 'currency', min, max,
69
- * currency_code, currency_symbol}]
70
- *
71
- * Open-ended semantics are preserved on the wire: an absent 'min' or
72
- * 'max' is sent as 'null' rather than synthesised to '0' or
73
- * 'MAX_SAFE_INTEGER', so a 'greater_than' / 'less_than' rule stays
74
- * one-sided after rollback rather than collapsing into a closed range.
75
- *
76
- * The V1 backend does not understand vendor / department criteria or
77
- * the rule-level 3.0 fields, so those are dropped on the wire.
78
- */
79
- export declare const toApprovalChangableInfoPayloadV1: (approverViewUpdateData: ApprovalRuleUpdateData | ApprovalRuleCreateData) => Partial<ApprovalUpdatableInfoPayloadV1>;
80
22
  export {};
@@ -1,51 +1,23 @@
1
1
  "use strict";
2
2
  Object.defineProperty(exports, "__esModule", { value: true });
3
- exports.toApprovalChangableInfoPayloadV1 = exports.toApprovalChangableInfoPayload = void 0;
3
+ exports.toApprovalChangableInfoPayload = void 0;
4
4
  const toApprovalChangableInfoPayload = (approverViewUpdateData) => {
5
- // Form-side criteria is a structured object with optional slots for
6
- // amount / vendor / department; flatten it into the wire format's
7
- // `conditions[]` array.
8
- let criteriaPayload;
5
+ let criteriaPayload = [];
9
6
  if (approverViewUpdateData.criteria != null) {
10
- const { amount, vendor, department } = approverViewUpdateData.criteria;
11
- const conditions = [];
12
- if (amount?.min != null) {
13
- conditions.push({
14
- field: 'amount',
15
- type: 'gte',
16
- value: amount.min.amount,
17
- });
18
- }
19
- if (amount?.max != null) {
20
- conditions.push({
21
- field: 'amount',
22
- type: 'lte',
23
- value: amount.max.amount,
24
- });
25
- }
26
- if (vendor != null && vendor.vendorIds.length > 0) {
27
- conditions.push({
28
- field: 'vendor_id',
29
- type: vendor.operator === 'is_not' ? 'not_in' : 'in',
30
- value: vendor.vendorIds,
31
- });
32
- }
33
- if (department != null && department.departmentIds.length > 0) {
34
- conditions.push({
35
- field: 'department_id',
36
- type: department.operator === 'is_not' ? 'not_in' : 'in',
37
- value: department.departmentIds,
38
- });
39
- }
40
- if (conditions.length > 0) {
41
- const currency = amount?.min ?? amount?.max ?? null;
42
- criteriaPayload = {
43
- conditions,
44
- criteria_operator: 'and',
45
- currency_code: currency?.currencyCode ?? 'USD',
46
- currency_symbol: currency?.currencySymbol ?? '$',
47
- };
48
- }
7
+ const criteria = approverViewUpdateData.criteria;
8
+ const { rangeType, rangeEntity, range } = criteria;
9
+ const { min, max } = range;
10
+ const { currencyCode, currencySymbol } = min;
11
+ criteriaPayload = [
12
+ {
13
+ type: rangeType,
14
+ range_entity: rangeEntity,
15
+ min: min.amount,
16
+ max: max?.amount ?? null,
17
+ currency_code: currencyCode,
18
+ currency_symbol: currencySymbol,
19
+ },
20
+ ];
49
21
  }
50
22
  const steps = approverViewUpdateData.steps.map((step) => {
51
23
  return {
@@ -66,90 +38,13 @@ const toApprovalChangableInfoPayload = (approverViewUpdateData) => {
66
38
  });
67
39
  const isUpdate = approverViewUpdateData.approvalRuleId != null;
68
40
  const payload = {
41
+ criteria: criteriaPayload,
69
42
  steps,
70
43
  is_applicable_on_pending_approval_entity: approverViewUpdateData.isApplicableOnPendingApprovalEntity ?? true,
71
44
  };
72
- if (criteriaPayload != null) {
73
- payload.criteria = criteriaPayload;
74
- }
75
- // Approval Rules 3.0 — surface rule-level fields when the form set them.
76
- // Send only what the user actually entered: an undefined value means
77
- // "no opinion" and stays off the wire.
78
- if (approverViewUpdateData.name != null) {
79
- payload.name = approverViewUpdateData.name;
80
- }
81
- if (approverViewUpdateData.description != null) {
82
- payload.description = approverViewUpdateData.description;
83
- }
84
- if (approverViewUpdateData.separationOfDuties != null) {
85
- payload.is_separation_of_duty_enabled =
86
- approverViewUpdateData.separationOfDuties;
87
- }
88
- if (approverViewUpdateData.isFallback != null) {
89
- payload.is_fallback = approverViewUpdateData.isFallback;
90
- }
91
45
  if (isUpdate) {
92
46
  payload.approval_rule_id = approverViewUpdateData.approvalRuleId;
93
47
  }
94
48
  return payload;
95
49
  };
96
50
  exports.toApprovalChangableInfoPayload = toApprovalChangableInfoPayload;
97
- /**
98
- * V1 wire mapper — used when 'approval_rule_v3_config' resolves to OFF
99
- * for the current tenant. Emits the legacy snake_case array shape that
100
- * '/approval-rules' historically consumed (see the V1 fixture in
101
- * 'entity/entityApprovalStatus/__mocks__/json/entityApprovalStatusPayload.json'):
102
- * criteria: [{type: 'range', range_entity: 'currency', min, max,
103
- * currency_code, currency_symbol}]
104
- *
105
- * Open-ended semantics are preserved on the wire: an absent 'min' or
106
- * 'max' is sent as 'null' rather than synthesised to '0' or
107
- * 'MAX_SAFE_INTEGER', so a 'greater_than' / 'less_than' rule stays
108
- * one-sided after rollback rather than collapsing into a closed range.
109
- *
110
- * The V1 backend does not understand vendor / department criteria or
111
- * the rule-level 3.0 fields, so those are dropped on the wire.
112
- */
113
- const toApprovalChangableInfoPayloadV1 = (approverViewUpdateData) => {
114
- const amount = approverViewUpdateData.criteria?.amount;
115
- const minAmount = amount?.min;
116
- const maxAmount = amount?.max;
117
- const currencyCode = minAmount?.currencyCode ?? maxAmount?.currencyCode ?? 'USD';
118
- const currencySymbol = minAmount?.currencySymbol ?? maxAmount?.currencySymbol ?? '$';
119
- const steps = approverViewUpdateData.steps.map((step) => {
120
- return {
121
- action: step.action,
122
- operator: step.operator,
123
- actors: step.actors
124
- .filter((actor) => actor.subType !== 'admin')
125
- .map((actor) => {
126
- return {
127
- type: actor.type,
128
- id: actor.userId ?? null,
129
- sub_type: actor.subType ?? null,
130
- id_type: actor.idType ?? null,
131
- is_implicit_actor: actor.isImplicitActor ?? false,
132
- };
133
- }),
134
- };
135
- });
136
- const isUpdate = approverViewUpdateData.approvalRuleId != null;
137
- const criteriaEntry = {
138
- type: 'range',
139
- range_entity: 'currency',
140
- min: minAmount?.amount ?? null,
141
- max: maxAmount?.amount ?? null,
142
- currency_code: currencyCode,
143
- currency_symbol: currencySymbol,
144
- };
145
- const payload = {
146
- steps,
147
- is_applicable_on_pending_approval_entity: approverViewUpdateData.isApplicableOnPendingApprovalEntity ?? true,
148
- criteria: [criteriaEntry],
149
- };
150
- if (isUpdate) {
151
- payload.approval_rule_id = approverViewUpdateData.approvalRuleId;
152
- }
153
- return payload;
154
- };
155
- exports.toApprovalChangableInfoPayloadV1 = toApprovalChangableInfoPayloadV1;
@@ -1,45 +1,19 @@
1
1
  import { FetchStateAndError, ID } from '../../../../../commonStateTypes/common';
2
- import { AmountCriteria, DepartmentCriteria, Step, VendorCriteria } from '../../../../../entity/approvalRule/approvalRuleState';
2
+ import { Criteria, Step } from '../../../../../entity/approvalRule/approvalRuleState';
3
3
  export type ApprovalUpdateActionType = 'approval_create' | 'approval_update';
4
4
  export interface ApproverViewUpdateData {
5
5
  type: ApprovalUpdateActionType;
6
6
  updateStatus: FetchStateAndError;
7
7
  data?: ApprovalRuleUpdateData | ApprovalRuleCreateData;
8
8
  }
9
- /**
10
- * Form-side criteria shape used by the rule create/edit form.
11
- *
12
- * Each condition kind gets its own optional slot, mirroring how the UI
13
- * edits them as distinct rows. At most one of each kind is present; this
14
- * matches the design constraint that each condition type can be added once.
15
- */
16
- export interface ApprovalRuleFormCriteria {
17
- amount?: AmountCriteria;
18
- department?: DepartmentCriteria;
19
- vendor?: VendorCriteria;
20
- }
21
- /**
22
- * Rule-level fields shared by both create and update flows.
23
- *
24
- * These come from the 3.0 design: the form now owns a name, an optional
25
- * description, an optional Separation-of-Duties toggle, and a flag that
26
- * marks the rule as the org-wide fallback rule. They live alongside
27
- * criteria/steps but are not part of either.
28
- */
29
- export interface ApprovalRuleFormBase {
30
- description?: string;
31
- isFallback?: boolean;
32
- name?: string;
33
- separationOfDuties?: boolean;
34
- }
35
- export interface ApprovalRuleUpdateData extends ApprovalRuleFormBase {
9
+ export interface ApprovalRuleUpdateData {
36
10
  approvalRuleId: ID;
37
- criteria: ApprovalRuleFormCriteria;
11
+ criteria: Criteria;
38
12
  steps: Step[];
39
13
  isApplicableOnPendingApprovalEntity?: boolean;
40
14
  }
41
- export interface ApprovalRuleCreateData extends ApprovalRuleFormBase {
42
- criteria: ApprovalRuleFormCriteria;
15
+ export interface ApprovalRuleCreateData {
16
+ criteria: Criteria;
43
17
  steps: Step[];
44
18
  isApplicableOnPendingApprovalEntity?: boolean;
45
19
  }
@@ -100,13 +100,6 @@ export interface EditBillDetailSelectorView extends SelectorView {
100
100
  withdrawFromList: FundingAccount[];
101
101
  billPayInfo?: BillPayInfo;
102
102
  bookCloseDate?: ZeniDate;
103
- /**
104
- * Bill-level accounting class id. Approval Rules 3.0 'department'
105
- * criteria match against this — selectors needing to evaluate a
106
- * department-narrowed rule against the current bill should read
107
- * this rather than digging through 'state.billTransactionState'.
108
- */
109
- classId?: ID;
110
103
  createTime?: ZeniDate;
111
104
  editBillInitialDetails?: EditBillInitialDetails;
112
105
  internationalWireOnboardingStatus?: AllowedValueWithCode;
@@ -164,4 +157,4 @@ export declare const getDefaultWithdrawFromAccount: (state: RootState, depositAc
164
157
  accountId: ID;
165
158
  accountType: AccountTypeSubConfigCodeKeyType;
166
159
  }) => FundingAccount | undefined;
167
- export declare const checkIfCreatorIsApprover: (billAmount: number, approvalRules: ApprovalRuleWithUser[], signedInUser?: LoggedInUser, billVendorId?: ID, billDepartmentId?: ID) => boolean;
160
+ export declare const checkIfCreatorIsApprover: (billAmount: number, approvalRules: ApprovalRuleWithUser[], signedInUser?: LoggedInUser) => boolean;
@@ -9,7 +9,6 @@ exports.getPaymentSection = getPaymentSection;
9
9
  exports.toPaymentToOption = toPaymentToOption;
10
10
  const get_1 = __importDefault(require("lodash/get"));
11
11
  const has_1 = __importDefault(require("lodash/has"));
12
- const approvalRuleSelector_1 = require("../../../../entity/approvalRule/approvalRuleSelector");
13
12
  const reduceFetchState_1 = require("../../../../commonStateTypes/reduceFetchState");
14
13
  const bankAccountSelector_1 = require("../../../../entity/bankAccount/bankAccountSelector");
15
14
  const contactSelector_1 = require("../../../../entity/billPay/contact/contactSelector");
@@ -366,14 +365,6 @@ const getEditBillDetail = (state, isVendorRecommendationFeatureEnabled, isZeniAc
366
365
  isDeleted,
367
366
  showAutofill,
368
367
  addBillAutoFields,
369
- // Bill-level accounting class. Approval Rules 3.0 'department'
370
- // criteria match against this. Lives on BillTransaction; not on
371
- // any sub-section. Empty-string is normalised to 'undefined'
372
- // so downstream readers treat "no class" uniformly regardless
373
- // of whether the wire used '' or omitted the field.
374
- classId: transaction?.classId != null && transaction.classId !== ''
375
- ? transaction.classId
376
- : undefined,
377
368
  billStage,
378
369
  deleteStatus,
379
370
  billActivities,
@@ -704,59 +695,12 @@ const getDefaultWithdrawFromAccount = (state, depositAccounts, companyId, lastSe
704
695
  return undefined;
705
696
  };
706
697
  exports.getDefaultWithdrawFromAccount = getDefaultWithdrawFromAccount;
707
- const checkIfCreatorIsApprover = (billAmount, approvalRules, signedInUser, billVendorId, billDepartmentId) => {
698
+ const checkIfCreatorIsApprover = (billAmount, approvalRules, signedInUser) => {
708
699
  let isCreatorAlsoApprover = false;
709
- // Approval Rules 3.0 — a rule applies to a bill only when all of
710
- // its present criteria are satisfied. Criteria not declared on
711
- // the rule are treated as "no narrowing on this axis".
712
- //
713
- // Strict-match semantics for vendor / department: if the rule
714
- // narrows by an axis but the bill has no value on that axis, the
715
- // rule does NOT apply (an absent bill-side value can't satisfy
716
- // either 'is' or 'is_not'). Amount is always present on a rule
717
- // (the form enforces this), but bounds may be one-sided.
718
700
  const approvalRule = approvalRules.find((rule) => {
719
- const vendorCriteria = (0, approvalRuleSelector_1.getVendorCriteria)(rule.criteria);
720
- if (vendorCriteria != null) {
721
- if (billVendorId == null) {
722
- return false;
723
- }
724
- const includesVendor = vendorCriteria.vendorIds.includes(billVendorId);
725
- if (vendorCriteria.operator === 'is' && !includesVendor) {
726
- return false;
727
- }
728
- if (vendorCriteria.operator === 'is_not' && includesVendor) {
729
- return false;
730
- }
731
- }
732
- const departmentCriteria = (0, approvalRuleSelector_1.getDepartmentCriteria)(rule.criteria);
733
- if (departmentCriteria != null) {
734
- if (billDepartmentId == null) {
735
- return false;
736
- }
737
- const includesDepartment = departmentCriteria.departmentIds.includes(billDepartmentId);
738
- if (departmentCriteria.operator === 'is' && !includesDepartment) {
739
- return false;
740
- }
741
- if (departmentCriteria.operator === 'is_not' && includesDepartment) {
742
- return false;
743
- }
744
- }
745
- const amountCriteria = (0, approvalRuleSelector_1.getAmountCriteria)(rule.criteria);
746
- if (amountCriteria == null) {
747
- // The form guarantees an amount criterion on every rule, so
748
- // this branch is defensive against backend drift. Keep
749
- // pre-3.0 behaviour: a rule that doesn't declare amount
750
- // doesn't participate here.
751
- return false;
752
- }
753
- // Bounds use the wire's inclusive 'gte' / 'lte' semantics, and
754
- // either side may be absent for a one-sided 'greater_than' /
755
- // 'less_than' rule.
756
- const { min, max } = amountCriteria;
757
- const matchesMin = min == null || billAmount >= min.amount;
758
- const matchesMax = max == null || billAmount <= max.amount;
759
- return matchesMin && matchesMax;
701
+ const { max, min } = rule.criteria[0].range;
702
+ return (billAmount > min.amount &&
703
+ (max?.amount != null ? billAmount <= max?.amount : true));
760
704
  });
761
705
  if (approvalRule != null) {
762
706
  const requireApprovalSteps = approvalRule.steps.filter((step) => step.action === 'require_approval');
@@ -16,17 +16,24 @@ const initializeIntlVerificationFormEpic = (actions$, state$) => actions$.pipe((
16
16
  ? onboardingDataFromCompanyInfo[formFieldKey]?.values
17
17
  : undefined;
18
18
  if (values != null) {
19
- localData[formFieldKey] =
20
- internationalWireFormPayload[formFieldKey].type === 'enum'
21
- ? internationalWireFormPayload[formFieldKey]
22
- .is_multiple_values_allowed === false
19
+ const fieldPayload = internationalWireFormPayload[formFieldKey];
20
+ if (fieldPayload.type === 'enum') {
21
+ localData[formFieldKey] =
22
+ fieldPayload.is_multiple_values_allowed === false
23
23
  ? typeof values[0] === 'object' && 'code' in values[0]
24
24
  ? values[0].code
25
25
  : ''
26
26
  : values.map((value) => typeof value === 'object' && 'code' in value
27
27
  ? value.code
28
- : '')
29
- : values[0];
28
+ : '');
29
+ }
30
+ else if (fieldPayload.type === 'file' &&
31
+ fieldPayload.is_multiple_values_allowed === true) {
32
+ localData[formFieldKey] = values.filter((value) => typeof value === 'string');
33
+ }
34
+ else {
35
+ localData[formFieldKey] = values[0] ?? '';
36
+ }
30
37
  }
31
38
  else {
32
39
  localData[formFieldKey] =
@@ -1,17 +1,39 @@
1
1
  import { AllowedValueWithCode } from '../../../../commonStateTypes/allowedValue';
2
2
  import { ZeniAPIResponse } from '../../../../responsePayload';
3
3
  import { VerificationFormField } from './internationalWireVerificationState';
4
+ export declare const InternationalWireVerificationFormOrder: readonly ["certificate_of_good_standing", "business_ownership", "company_proof_of_address", "company_officer_proof_of_address", "company_registration_date", "annual_turnover", "expected_transaction_volume", "employee_count", "intended_use_of_account", "transaction_countries", "stake_holder", "controlling_person"];
5
+ export interface FieldOptionPayload {
6
+ label: string;
7
+ }
8
+ export interface SubFieldPayload {
9
+ label: string;
10
+ type: string;
11
+ field_hint_text?: string;
12
+ field_values?: {
13
+ code: string;
14
+ description: string;
15
+ }[];
16
+ is_multiple_options_supported?: boolean;
17
+ options?: Record<string, FieldOptionPayload>;
18
+ }
4
19
  export interface FieldPayload {
5
20
  label: string;
6
21
  type: string;
22
+ default?: boolean;
7
23
  field_hint_text?: string;
8
24
  field_values?: {
9
25
  code: string;
10
26
  description: string;
11
27
  }[];
28
+ is_multiple_options_supported?: boolean;
12
29
  is_multiple_values_allowed?: boolean;
30
+ options?: Record<string, FieldOptionPayload>;
31
+ requirements?: string[];
32
+ subfields?: Record<string, SubFieldPayload>;
13
33
  }
14
34
  export declare const toDynamicFormField: (key: string, payload: FieldPayload) => VerificationFormField;
35
+ export declare const sortVerificationFormFields: (fields: VerificationFormField[]) => VerificationFormField[];
36
+ export declare const toVerificationFormFields: (internationalWireFormPayload: Record<string, FieldPayload>) => VerificationFormField[];
15
37
  export type IntlVerificationFormResponse = ZeniAPIResponse<IntlVerificationFormPayload>;
16
38
  export interface IntlVerificationFormPayload {
17
39
  create_time: string;
@@ -1,19 +1,59 @@
1
1
  "use strict";
2
2
  Object.defineProperty(exports, "__esModule", { value: true });
3
- exports.toDynamicFormField = void 0;
3
+ exports.toVerificationFormFields = exports.sortVerificationFormFields = exports.toDynamicFormField = exports.InternationalWireVerificationFormOrder = void 0;
4
+ exports.InternationalWireVerificationFormOrder = [
5
+ 'certificate_of_good_standing',
6
+ 'business_ownership',
7
+ 'company_proof_of_address',
8
+ 'company_officer_proof_of_address',
9
+ 'company_registration_date',
10
+ 'annual_turnover',
11
+ 'expected_transaction_volume',
12
+ 'employee_count',
13
+ 'intended_use_of_account',
14
+ 'transaction_countries',
15
+ 'stake_holder',
16
+ 'controlling_person',
17
+ ];
18
+ const toFieldValues = (fieldValues) => fieldValues?.map(({ code, description }) => ({ code, description })) ?? [];
19
+ const toSubField = (subfield) => ({
20
+ label: subfield.label,
21
+ placeholder: subfield.field_hint_text ?? '',
22
+ type: subfield.type,
23
+ fieldValues: toFieldValues(subfield.field_values),
24
+ isMultipleOptionsSupported: subfield.is_multiple_options_supported,
25
+ options: subfield.options,
26
+ });
4
27
  const toDynamicFormField = (key, payload) => ({
5
28
  name: key,
6
29
  label: payload.label,
7
30
  placeholder: payload.field_hint_text ?? '',
8
31
  isMultipleValuesAllowed: payload.is_multiple_values_allowed ?? false,
9
32
  type: payload.type,
10
- fieldValues: payload.field_values != null && payload.field_values.length > 0
11
- ? payload.field_values.map((fieldValue) => {
12
- return {
13
- code: fieldValue.code,
14
- description: fieldValue.description,
15
- };
16
- })
17
- : [],
33
+ fieldValues: toFieldValues(payload.field_values),
34
+ isMultipleOptionsSupported: payload.is_multiple_options_supported,
35
+ options: payload.options,
36
+ requirements: payload.requirements,
37
+ default: payload.default,
38
+ subfields: payload.subfields != null
39
+ ? Object.fromEntries(Object.entries(payload.subfields).map(([subfieldKey, subfield]) => [
40
+ subfieldKey,
41
+ toSubField(subfield),
42
+ ]))
43
+ : undefined,
18
44
  });
19
45
  exports.toDynamicFormField = toDynamicFormField;
46
+ const sortVerificationFormFields = (fields) => {
47
+ const orderIndex = new Map(exports.InternationalWireVerificationFormOrder.map((name, index) => [name, index]));
48
+ return fields.slice().sort((a, b) => {
49
+ const aIndex = orderIndex.get(a.name) ?? exports.InternationalWireVerificationFormOrder.length;
50
+ const bIndex = orderIndex.get(b.name) ?? exports.InternationalWireVerificationFormOrder.length;
51
+ if (aIndex !== bIndex) {
52
+ return aIndex - bIndex;
53
+ }
54
+ return a.name.localeCompare(b.name);
55
+ });
56
+ };
57
+ exports.sortVerificationFormFields = sortVerificationFormFields;
58
+ const toVerificationFormFields = (internationalWireFormPayload) => (0, exports.sortVerificationFormFields)(Object.keys(internationalWireFormPayload).map((key) => (0, exports.toDynamicFormField)(key, internationalWireFormPayload[key])));
59
+ exports.toVerificationFormFields = toVerificationFormFields;