@zeniai/client-epic-state 5.0.90-betaAR4 → 5.0.90-betaAS1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (77) hide show
  1. package/lib/entity/approvalRule/approvalRulePayload.d.ts +5 -34
  2. package/lib/entity/approvalRule/approvalRulePayload.js +10 -145
  3. package/lib/entity/approvalRule/approvalRuleSelector.d.ts +1 -25
  4. package/lib/entity/approvalRule/approvalRuleSelector.js +0 -40
  5. package/lib/entity/approvalRule/approvalRuleState.d.ts +7 -59
  6. package/lib/entity/snackbar/snackbarTypes.d.ts +1 -1
  7. package/lib/entity/snackbar/snackbarTypes.js +0 -2
  8. package/lib/epic.d.ts +1 -3
  9. package/lib/epic.js +1 -3
  10. package/lib/esm/entity/approvalRule/approvalRulePayload.js +10 -145
  11. package/lib/esm/entity/approvalRule/approvalRuleSelector.js +0 -35
  12. package/lib/esm/entity/snackbar/snackbarTypes.js +0 -2
  13. package/lib/esm/epic.js +1 -3
  14. package/lib/esm/index.js +7 -8
  15. package/lib/esm/view/spendManagement/billPay/billPayReview/billPayReviewSelector.js +0 -14
  16. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.js +12 -102
  17. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/deleteBillPayApprovalRuleEpic.js +2 -10
  18. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.js +4 -8
  19. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/initializeBillPaySetupApproverViewUpdateDataEpic.js +7 -11
  20. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/saveBillPaySetupApproverViewUpdatesEpic.js +4 -13
  21. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.js +16 -120
  22. package/lib/esm/view/spendManagement/billPay/editBillView/editBillViewSelector.js +4 -60
  23. package/lib/esm/view/spendManagement/billPay/internationalWireVerification/epics/initializeIntlVerificationFormEpic.js +13 -6
  24. package/lib/esm/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationPayload.js +46 -8
  25. package/lib/esm/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationReducer.js +2 -6
  26. package/lib/esm/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationSelector.js +23 -12
  27. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/deleteRemiApprovalRuleEpic.js +2 -10
  28. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.js +2 -8
  29. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/initializeRemiSetupApproverViewUpdateDataEpic.js +7 -11
  30. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/saveRemiSetupApproverViewUpdatesEpic.js +4 -13
  31. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js +11 -76
  32. package/lib/index.d.ts +9 -10
  33. package/lib/index.js +19 -27
  34. package/lib/view/companyTaskManagerView/companyTaskManagerViewReducer.d.ts +2 -2
  35. package/lib/view/companyView/types/cockpitTypes.d.ts +1 -1
  36. package/lib/view/expenseAutomationView/helpers/transactionCategorizationLocalDataHelper.d.ts +1 -1
  37. package/lib/view/people/peopleTypes.d.ts +1 -1
  38. package/lib/view/spendManagement/billPay/billPayReview/billPayReviewSelector.d.ts +0 -7
  39. package/lib/view/spendManagement/billPay/billPayReview/billPayReviewSelector.js +0 -14
  40. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.d.ts +3 -14
  41. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewReducer.js +13 -103
  42. package/lib/view/spendManagement/billPay/billPaySetupApproverView/billPaySetupApproverViewState.d.ts +0 -16
  43. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/deleteBillPayApprovalRuleEpic.js +2 -10
  44. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/fetchBillPaySetupApproverViewEpic.js +4 -8
  45. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/initializeBillPaySetupApproverViewUpdateDataEpic.js +6 -10
  46. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/saveBillPaySetupApproverViewUpdatesEpic.js +3 -12
  47. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.d.ts +1 -59
  48. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonPayload.js +17 -122
  49. package/lib/view/spendManagement/billPay/billPaySetupApproverView/types/commonState.d.ts +5 -31
  50. package/lib/view/spendManagement/billPay/editBillView/editBillViewSelector.d.ts +1 -8
  51. package/lib/view/spendManagement/billPay/editBillView/editBillViewSelector.js +4 -60
  52. package/lib/view/spendManagement/billPay/internationalWireVerification/epics/initializeIntlVerificationFormEpic.js +13 -6
  53. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationPayload.d.ts +22 -0
  54. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationPayload.js +49 -9
  55. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationReducer.js +1 -5
  56. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationSelector.js +23 -12
  57. package/lib/view/spendManagement/billPay/internationalWireVerification/internationalWireVerificationState.d.ts +16 -0
  58. package/lib/view/spendManagement/chargeCards/chargeCardList/chargeCardList.d.ts +1 -1
  59. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/deleteRemiApprovalRuleEpic.js +2 -10
  60. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/fetchRemiSetupApproverViewEpic.js +2 -8
  61. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/initializeRemiSetupApproverViewUpdateDataEpic.js +6 -10
  62. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/saveRemiSetupApproverViewUpdatesEpic.js +3 -12
  63. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.d.ts +3 -14
  64. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewReducer.js +12 -77
  65. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/remiSetupApproverViewState.d.ts +0 -12
  66. package/lib/view/taskManager/taskListView/taskList.d.ts +3 -3
  67. package/lib/view/transactionDetail/journalEntryLinesViewModel.d.ts +1 -1
  68. package/package.json +1 -1
  69. package/lib/entity/approvalRule/approvalRuleConflict.d.ts +0 -56
  70. package/lib/entity/approvalRule/approvalRuleConflict.js +0 -77
  71. package/lib/esm/entity/approvalRule/approvalRuleConflict.js +0 -74
  72. package/lib/esm/view/spendManagement/billPay/billPaySetupApproverView/epic/reorderBillPayApprovalRulesEpic.js +0 -54
  73. package/lib/esm/view/spendManagement/reimbursement/remiSetupApproverView/epic/reorderRemiApprovalRulesEpic.js +0 -49
  74. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/reorderBillPayApprovalRulesEpic.d.ts +0 -23
  75. package/lib/view/spendManagement/billPay/billPaySetupApproverView/epic/reorderBillPayApprovalRulesEpic.js +0 -58
  76. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/reorderRemiApprovalRulesEpic.d.ts +0 -14
  77. package/lib/view/spendManagement/reimbursement/remiSetupApproverView/epic/reorderRemiApprovalRulesEpic.js +0 -53
@@ -52,12 +52,6 @@ export const getReviewPageBillDetail = (state, billId) => {
52
52
  let recurringConfig;
53
53
  let billPayInfo;
54
54
  let isBillMarkedForRetry = false;
55
- // Bill-level accounting class id. Approval Rules 3.0 'department'
56
- // criteria match against this. Sourced from BillTransaction so
57
- // any selector that needs it (e.g. creator-as-approver lookup)
58
- // can read it off the view rather than reaching into
59
- // 'state.billTransactionState' itself.
60
- let classId;
61
55
  const zeniAssistRetryStatus = billId != null
62
56
  ? billDetailViewState.billDetailById[key].zeniAssist.retryStatus
63
57
  : undefined;
@@ -68,13 +62,6 @@ export const getReviewPageBillDetail = (state, billId) => {
68
62
  transaction?.billPayInfo.isCollectToAccountInfoFromVendorContact ?? false;
69
63
  isRecurring = transaction?.isRecurring ?? false;
70
64
  billPayInfo = transaction?.billPayInfo;
71
- // Normalise empty-string to undefined so downstream readers
72
- // treat "no class" uniformly regardless of whether the wire
73
- // used '' or omitted the field.
74
- classId =
75
- transaction?.classId != null && transaction.classId !== ''
76
- ? transaction.classId
77
- : undefined;
78
65
  if (isRecurring &&
79
66
  transaction?.recurringBillConfigId != null &&
80
67
  transaction.recurringBillInstance != null) {
@@ -191,6 +178,5 @@ export const getReviewPageBillDetail = (state, billId) => {
191
178
  zeniAssistRetryStatus,
192
179
  billPayInfo,
193
180
  outsideZeniPaymentInfo,
194
- classId,
195
181
  };
196
182
  };
@@ -13,7 +13,6 @@ export const initialState = {
13
13
  newApprovalRuleId: undefined,
14
14
  approvalRulesDeleteStatusById: {},
15
15
  billPaySetupApproverViewUpdateData: undefined,
16
- reorderStatus: { fetchState: 'Not-Started', error: undefined },
17
16
  hasValidState() {
18
17
  return this.fetchState === 'Completed';
19
18
  },
@@ -27,11 +26,8 @@ const billPaySetupApproverView = createSlice({
27
26
  draft.fetchState = 'In-Progress';
28
27
  draft.error = undefined;
29
28
  },
30
- // Approval Rules 3.0 `useV3` arrives from the screen connector
31
- // (`approval_rule_v3_config` dynamic config) and picks the v1 vs
32
- // v2 endpoint in the fetch epic.
33
- prepare(cacheOverride = false, includeUserRoles = true, useV3 = false) {
34
- return { payload: { cacheOverride, includeUserRoles, useV3 } };
29
+ prepare(cacheOverride = false, includeUserRoles = true) {
30
+ return { payload: { cacheOverride, includeUserRoles } };
35
31
  },
36
32
  },
37
33
  fetchBillPaySetupApproverViewSuccess: {
@@ -116,11 +112,8 @@ const billPaySetupApproverView = createSlice({
116
112
  error: undefined,
117
113
  };
118
114
  },
119
- // Approval Rules 3.0 — `useV3` flows from the screen connector
120
- // (`approval_rule_v3_config` dynamic config) so the delete epic
121
- // can pick the v1 vs v2 endpoint.
122
- prepare(approvalRuleId, useV3 = false) {
123
- return { payload: { approvalRuleId, useV3 } };
115
+ prepare(approvalRuleId) {
116
+ return { payload: { approvalRuleId } };
124
117
  },
125
118
  },
126
119
  deleteBillPayApprovalRuleSuccess: {
@@ -152,96 +145,13 @@ const billPaySetupApproverView = createSlice({
152
145
  };
153
146
  },
154
147
  },
155
- /**
156
- * Approval Rules 3.0 list-page drag-and-drop reorder.
157
- *
158
- * The trigger action carries the desired ordering as an ID list.
159
- * The reducer optimistically replaces 'approvalRuleIds' so the
160
- * list page renders the new order immediately; the epic then
161
- * fires the PUT and either confirms (success — pulls updated
162
- * priorities from the response) or recovers (failure — refetches
163
- * the view so we don't strand a stale local order).
164
- */
165
- reorderBillPayApprovalRules: {
166
- reducer(draft, action) {
167
- const { approvalRuleIds } = action.payload;
168
- const wasReorderInFlight = draft.reorderStatus.fetchState === 'In-Progress';
169
- draft.reorderStatus = { fetchState: 'In-Progress', error: undefined };
170
- // Stash the pre-reorder order so 'Failure' can restore it
171
- // synchronously. The epic's refetch on failure remains as a
172
- // safety net (covers cases where the server's truth has
173
- // drifted from the local snapshot), but the snappy UX path
174
- // is the in-memory rollback.
175
- //
176
- // Only capture a fresh snapshot when no reorder is already in
177
- // flight. If a second drag fires before the first PUT lands,
178
- // the existing snapshot already holds the last server-backed
179
- // order; overwriting it with the first reorder's optimistic
180
- // result would mean a Failure rolls back to an uncommitted
181
- // intermediate order instead of the last good list.
182
- if (!wasReorderInFlight) {
183
- draft.reorderRollbackIds = draft.approvalRuleIds;
184
- }
185
- // Optimistic: render new order immediately. On failure, the
186
- // reducer restores 'reorderRollbackIds' and the epic refetch
187
- // reconciles any drift.
188
- draft.approvalRuleIds = approvalRuleIds;
189
- },
190
- prepare(approvalRuleIds, useV3 = false) {
191
- return { payload: { approvalRuleIds, useV3 } };
192
- },
193
- },
194
- reorderBillPayApprovalRulesSuccess: {
195
- reducer(draft, action) {
196
- const { approvalRuleIds } = action.payload;
197
- draft.reorderStatus = { fetchState: 'Completed', error: undefined };
198
- // The API response is authoritative — overwrite with the
199
- // server's reported order in case it normalised anything.
200
- draft.approvalRuleIds = approvalRuleIds;
201
- // Reorder succeeded — discard the snapshot so the next
202
- // reorder starts from this committed order.
203
- draft.reorderRollbackIds = undefined;
204
- },
205
- prepare(approvalRuleIds) {
206
- return { payload: { approvalRuleIds } };
207
- },
208
- },
209
- reorderBillPayApprovalRulesFailure: {
210
- reducer(draft, action) {
211
- const { status } = action.payload;
212
- draft.reorderStatus = { fetchState: 'Error', error: status };
213
- // Restore the snapshot taken on the trigger reducer before
214
- // the optimistic mutation. The epic still fires a refetch
215
- // alongside the failure action for cross-tab drift recovery,
216
- // but locally the user sees their last good order instantly.
217
- if (draft.reorderRollbackIds != null) {
218
- draft.approvalRuleIds = draft.reorderRollbackIds;
219
- draft.reorderRollbackIds = undefined;
220
- }
221
- },
222
- prepare(status) {
223
- return { payload: { status } };
224
- },
225
- },
226
- saveBillPaySetupApproverViewUpdates: {
227
- // Approval Rules 3.0 — `useV3` is sourced from the
228
- // `approval_rule_v3_config` dynamic config in the screen
229
- // connector. The reducer doesn't read it (the field only
230
- // matters in the save epic), but it must be declared so the
231
- // action's payload type is correctly inferred for downstream
232
- // consumers.
233
- // eslint-disable-next-line @typescript-eslint/no-unused-vars
234
- reducer(draft, _action) {
235
- if (draft.billPaySetupApproverViewUpdateData != null) {
236
- draft.billPaySetupApproverViewUpdateData.updateStatus = {
237
- fetchState: 'In-Progress',
238
- error: undefined,
239
- };
240
- }
241
- },
242
- prepare(useV3) {
243
- return { payload: { useV3 } };
244
- },
148
+ saveBillPaySetupApproverViewUpdates(draft) {
149
+ if (draft.billPaySetupApproverViewUpdateData != null) {
150
+ draft.billPaySetupApproverViewUpdateData.updateStatus = {
151
+ fetchState: 'In-Progress',
152
+ error: undefined,
153
+ };
154
+ }
245
155
  },
246
156
  saveBillPaySetupApproverViewUpdatesSuccess: {
247
157
  reducer(draft, action) {
@@ -330,5 +240,5 @@ const billPaySetupApproverView = createSlice({
330
240
  },
331
241
  },
332
242
  });
333
- export const { fetchBillPaySetupApproverView, fetchBillPaySetupApproverViewSuccess, fetchBillPaySetupApproverViewFailure, fetchBillPayApproversDetails, fetchBillPayApproversList, fetchBillPayApproversListSuccess, fetchBillPayApproversListFailure, deleteBillPayApprovalRule, deleteBillPayApprovalRuleSuccess, deleteBillPayApprovalRuleFailure, reorderBillPayApprovalRules, reorderBillPayApprovalRulesSuccess, reorderBillPayApprovalRulesFailure, saveBillPaySetupApproverViewUpdates, saveBillPaySetupApproverViewUpdatesSuccess, saveBillPaySetupApproverViewUpdatesFailure, initializeBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdateData, clearBillPaySetupApproverViewUpdateData, setListeningToPusherEvent, clearBillPaySetupApproverView, } = billPaySetupApproverView.actions;
243
+ export const { fetchBillPaySetupApproverView, fetchBillPaySetupApproverViewSuccess, fetchBillPaySetupApproverViewFailure, fetchBillPayApproversDetails, fetchBillPayApproversList, fetchBillPayApproversListSuccess, fetchBillPayApproversListFailure, deleteBillPayApprovalRule, deleteBillPayApprovalRuleSuccess, deleteBillPayApprovalRuleFailure, saveBillPaySetupApproverViewUpdates, saveBillPaySetupApproverViewUpdatesSuccess, saveBillPaySetupApproverViewUpdatesFailure, initializeBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdateData, clearBillPaySetupApproverViewUpdateData, setListeningToPusherEvent, clearBillPaySetupApproverView, } = billPaySetupApproverView.actions;
334
244
  export default billPaySetupApproverView.reducer;
@@ -6,17 +6,9 @@ import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { deleteBillPayApprovalRule, deleteBillPayApprovalRuleFailure, deleteBillPayApprovalRuleSuccess, } from '../billPaySetupApproverViewReducer';
8
8
  export const deleteBillPayApprovalRuleEpic = (actions$, _state$, zeniAPI) => actions$.pipe(filter(deleteBillPayApprovalRule.match), switchMap((action) => {
9
- const { approvalRuleId, useV3 } = action.payload;
10
- // Approval Rules 3.0 — flag-gated endpoint selection.
11
- // Explicit `=== true` keeps `strict-boolean-expressions` happy
12
- // when RTK's payload type widens to `any` in some configs.
13
- const endpoint = useV3 === true
14
- ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules-v2`
15
- : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`;
9
+ const { approvalRuleId } = action.payload;
16
10
  return zeniAPI
17
- .deleteAndGetJSON(endpoint, {
18
- approval_rule_id: approvalRuleId,
19
- })
11
+ .deleteAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`, { approval_rule_id: approvalRuleId })
20
12
  .pipe(mergeMap((response) => {
21
13
  if (isSuccessResponse(response) && response.data != null) {
22
14
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -6,7 +6,7 @@ import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { fetchBillPaySetupApproverView, fetchBillPaySetupApproverViewFailure, fetchBillPaySetupApproverViewSuccess, } from '../billPaySetupApproverViewReducer';
8
8
  export const fetchBillPaySetupApproverViewEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(fetchBillPaySetupApproverView.match), switchMap((action) => {
9
- const { cacheOverride, useV3 } = action.payload;
9
+ const { cacheOverride } = action.payload;
10
10
  const { billPaySetupApproverViewState, approvalRuleState } = state$.value;
11
11
  const approvalRules = getApprovalRulesByIds(approvalRuleState, billPaySetupApproverViewState.approvalRuleIds);
12
12
  if (cacheOverride === true ||
@@ -14,13 +14,9 @@ export const fetchBillPaySetupApproverViewEpic = (actions$, state$, zeniAPI) =>
14
14
  billPaySetupApproverViewState.approvalRuleIds.length ||
15
15
  (billPaySetupApproverViewState.hasValidState() === false &&
16
16
  billPaySetupApproverViewState.fetchState !== 'In-Progress')) {
17
- // Approval Rules 3.0 — flag-gated endpoint selection.
18
- // Explicit `=== true` keeps `strict-boolean-expressions` happy
19
- // when RTK's payload type widens to `any` in some configs.
20
- const endpoint = useV3 === true
21
- ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules-v2`
22
- : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`;
23
- return zeniAPI.getJSON(endpoint).pipe(mergeMap((response) => {
17
+ return zeniAPI
18
+ .getJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`)
19
+ .pipe(mergeMap((response) => {
24
20
  if (isSuccessResponse(response) && response.data != null) {
25
21
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
26
22
  const actions = [
@@ -1,6 +1,6 @@
1
1
  import { from } from 'rxjs';
2
2
  import { filter, mergeMap } from 'rxjs/operators';
3
- import { getAmountCriteria, getApprovalRuleById, getDepartmentCriteria, getVendorCriteria, } from '../../../../../entity/approvalRule/approvalRuleSelector';
3
+ import { getApprovalRuleById } from '../../../../../entity/approvalRule/approvalRuleSelector';
4
4
  import { clearBillPaySetupApproverViewUpdateData, initializeBillPaySetupApproverViewUpdateData, saveBillPaySetupApproverViewUpdateData, } from '../billPaySetupApproverViewReducer';
5
5
  export const initializeBillPaySetupApproverViewUpdateDataEpic = (actions$, state$) => actions$.pipe(filter(initializeBillPaySetupApproverViewUpdateData.match), mergeMap((action) => {
6
6
  const { approvalRuleId } = action.payload;
@@ -8,20 +8,16 @@ export const initializeBillPaySetupApproverViewUpdateDataEpic = (actions$, state
8
8
  if (approvalRuleId != null) {
9
9
  const approvalRule = getApprovalRuleById(state$.value.approvalRuleState, approvalRuleId);
10
10
  if (approvalRule != null) {
11
+ const criteria = approvalRule.criteria[0];
12
+ const range = criteria?.range;
11
13
  const billPaySetupApproverViewUpdateData = {
12
14
  approvalRuleId,
13
15
  steps: approvalRule.steps,
14
16
  criteria: {
15
- amount: getAmountCriteria(approvalRule.criteria),
16
- vendor: getVendorCriteria(approvalRule.criteria),
17
- department: getDepartmentCriteria(approvalRule.criteria),
17
+ rangeType: criteria?.rangeType,
18
+ rangeEntity: criteria?.rangeEntity,
19
+ range,
18
20
  },
19
- // Approval Rules 3.0 — seed rule-level fields so the form can
20
- // round-trip them on edit. Each may be undefined on legacy rules.
21
- name: approvalRule.name,
22
- description: approvalRule.description,
23
- separationOfDuties: approvalRule.separationOfDuties,
24
- isFallback: approvalRule.isFallback,
25
21
  };
26
22
  fetchActions.push(clearBillPaySetupApproverViewUpdateData(), saveBillPaySetupApproverViewUpdateData(billPaySetupApproverViewUpdateData));
27
23
  }
@@ -29,7 +25,7 @@ export const initializeBillPaySetupApproverViewUpdateDataEpic = (actions$, state
29
25
  else {
30
26
  const billPaySetupApproverViewCreateData = {
31
27
  steps: [],
32
- criteria: {},
28
+ criteria: undefined,
33
29
  };
34
30
  fetchActions.push(clearBillPaySetupApproverViewUpdateData(), saveBillPaySetupApproverViewUpdateData(billPaySetupApproverViewCreateData));
35
31
  }
@@ -5,24 +5,15 @@ import { openSnackbar } from '../../../../../entity/snackbar/snackbarReducer';
5
5
  import { updateAllUsers } from '../../../../../entity/user/userReducer';
6
6
  import { createZeniAPIStatus, isSuccessResponse, } from '../../../../../responsePayload';
7
7
  import { saveBillPaySetupApproverViewUpdates, saveBillPaySetupApproverViewUpdatesFailure, saveBillPaySetupApproverViewUpdatesSuccess, } from '../billPaySetupApproverViewReducer';
8
- import { toApprovalChangableInfoPayload, toApprovalChangableInfoPayloadV1, } from '../types/commonPayload';
9
- export const saveBillPaySetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveBillPaySetupApproverViewUpdates.match), switchMap((action) => {
8
+ import { toApprovalChangableInfoPayload } from '../types/commonPayload';
9
+ export const saveBillPaySetupApproverViewUpdatesEpic = (actions$, state$, zeniAPI) => actions$.pipe(filter(saveBillPaySetupApproverViewUpdates.match), switchMap(() => {
10
10
  const { billPaySetupApproverViewState } = state$.value;
11
11
  const billPaySetupApproverViewUpdateData = billPaySetupApproverViewState.billPaySetupApproverViewUpdateData;
12
12
  if (billPaySetupApproverViewUpdateData != null &&
13
13
  billPaySetupApproverViewUpdateData.data != null) {
14
- // Approval Rules 3.0 — gate URL + write-side payload mapper on
15
- // the `approval_rule_v3_config` dynamic config. `useV3` arrives
16
- // on the action payload from the screen connector.
17
- const { useV3 } = action.payload;
18
- const payload = useV3
19
- ? toApprovalChangableInfoPayload(billPaySetupApproverViewUpdateData.data)
20
- : toApprovalChangableInfoPayloadV1(billPaySetupApproverViewUpdateData.data);
21
- const endpoint = useV3
22
- ? `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules-v2`
23
- : `${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`;
14
+ const payload = toApprovalChangableInfoPayload(billPaySetupApproverViewUpdateData.data);
24
15
  return zeniAPI
25
- .postAndGetJSON(endpoint, payload)
16
+ .postAndGetJSON(`${zeniAPI.apiEndPoints.approvalMicroServiceBaseUrl}/1.0/bill-pay/approval-rules`, payload)
26
17
  .pipe(mergeMap((response) => {
27
18
  if (isSuccessResponse(response) && response.data != null) {
28
19
  const approvalRuleIds = response.data.approval_rules.map((approvalRule) => approvalRule.approval_rule_id);
@@ -1,48 +1,20 @@
1
1
  export const toApprovalChangableInfoPayload = (approverViewUpdateData) => {
2
- // Form-side criteria is a structured object with optional slots for
3
- // amount / vendor / department; flatten it into the wire format's
4
- // `conditions[]` array.
5
- let criteriaPayload;
2
+ let criteriaPayload = [];
6
3
  if (approverViewUpdateData.criteria != null) {
7
- const { amount, vendor, department } = approverViewUpdateData.criteria;
8
- const conditions = [];
9
- if (amount?.min != null) {
10
- conditions.push({
11
- field: 'amount',
12
- type: 'gte',
13
- value: amount.min.amount,
14
- });
15
- }
16
- if (amount?.max != null) {
17
- conditions.push({
18
- field: 'amount',
19
- type: 'lte',
20
- value: amount.max.amount,
21
- });
22
- }
23
- if (vendor != null && vendor.vendorIds.length > 0) {
24
- conditions.push({
25
- field: 'vendor_id',
26
- type: vendor.operator === 'is_not' ? 'not_in' : 'in',
27
- value: vendor.vendorIds,
28
- });
29
- }
30
- if (department != null && department.departmentIds.length > 0) {
31
- conditions.push({
32
- field: 'department_id',
33
- type: department.operator === 'is_not' ? 'not_in' : 'in',
34
- value: department.departmentIds,
35
- });
36
- }
37
- if (conditions.length > 0) {
38
- const currency = amount?.min ?? amount?.max ?? null;
39
- criteriaPayload = {
40
- conditions,
41
- criteria_operator: 'and',
42
- currency_code: currency?.currencyCode ?? 'USD',
43
- currency_symbol: currency?.currencySymbol ?? '$',
44
- };
45
- }
4
+ const criteria = approverViewUpdateData.criteria;
5
+ const { rangeType, rangeEntity, range } = criteria;
6
+ const { min, max } = range;
7
+ const { currencyCode, currencySymbol } = min;
8
+ criteriaPayload = [
9
+ {
10
+ type: rangeType,
11
+ range_entity: rangeEntity,
12
+ min: min.amount,
13
+ max: max?.amount ?? null,
14
+ currency_code: currencyCode,
15
+ currency_symbol: currencySymbol,
16
+ },
17
+ ];
46
18
  }
47
19
  const steps = approverViewUpdateData.steps.map((step) => {
48
20
  return {
@@ -63,86 +35,10 @@ export const toApprovalChangableInfoPayload = (approverViewUpdateData) => {
63
35
  });
64
36
  const isUpdate = approverViewUpdateData.approvalRuleId != null;
65
37
  const payload = {
38
+ criteria: criteriaPayload,
66
39
  steps,
67
40
  is_applicable_on_pending_approval_entity: approverViewUpdateData.isApplicableOnPendingApprovalEntity ?? true,
68
41
  };
69
- if (criteriaPayload != null) {
70
- payload.criteria = criteriaPayload;
71
- }
72
- // Approval Rules 3.0 — surface rule-level fields when the form set them.
73
- // Send only what the user actually entered: an undefined value means
74
- // "no opinion" and stays off the wire.
75
- if (approverViewUpdateData.name != null) {
76
- payload.name = approverViewUpdateData.name;
77
- }
78
- if (approverViewUpdateData.description != null) {
79
- payload.description = approverViewUpdateData.description;
80
- }
81
- if (approverViewUpdateData.separationOfDuties != null) {
82
- payload.is_separation_of_duty_enabled =
83
- approverViewUpdateData.separationOfDuties;
84
- }
85
- if (approverViewUpdateData.isFallback != null) {
86
- payload.is_fallback = approverViewUpdateData.isFallback;
87
- }
88
- if (isUpdate) {
89
- payload.approval_rule_id = approverViewUpdateData.approvalRuleId;
90
- }
91
- return payload;
92
- };
93
- /**
94
- * V1 wire mapper — used when 'approval_rule_v3_config' resolves to OFF
95
- * for the current tenant. Emits the legacy snake_case array shape that
96
- * '/approval-rules' historically consumed (see the V1 fixture in
97
- * 'entity/entityApprovalStatus/__mocks__/json/entityApprovalStatusPayload.json'):
98
- * criteria: [{type: 'range', range_entity: 'currency', min, max,
99
- * currency_code, currency_symbol}]
100
- *
101
- * Open-ended semantics are preserved on the wire: an absent 'min' or
102
- * 'max' is sent as 'null' rather than synthesised to '0' or
103
- * 'MAX_SAFE_INTEGER', so a 'greater_than' / 'less_than' rule stays
104
- * one-sided after rollback rather than collapsing into a closed range.
105
- *
106
- * The V1 backend does not understand vendor / department criteria or
107
- * the rule-level 3.0 fields, so those are dropped on the wire.
108
- */
109
- export const toApprovalChangableInfoPayloadV1 = (approverViewUpdateData) => {
110
- const amount = approverViewUpdateData.criteria?.amount;
111
- const minAmount = amount?.min;
112
- const maxAmount = amount?.max;
113
- const currencyCode = minAmount?.currencyCode ?? maxAmount?.currencyCode ?? 'USD';
114
- const currencySymbol = minAmount?.currencySymbol ?? maxAmount?.currencySymbol ?? '$';
115
- const steps = approverViewUpdateData.steps.map((step) => {
116
- return {
117
- action: step.action,
118
- operator: step.operator,
119
- actors: step.actors
120
- .filter((actor) => actor.subType !== 'admin')
121
- .map((actor) => {
122
- return {
123
- type: actor.type,
124
- id: actor.userId ?? null,
125
- sub_type: actor.subType ?? null,
126
- id_type: actor.idType ?? null,
127
- is_implicit_actor: actor.isImplicitActor ?? false,
128
- };
129
- }),
130
- };
131
- });
132
- const isUpdate = approverViewUpdateData.approvalRuleId != null;
133
- const criteriaEntry = {
134
- type: 'range',
135
- range_entity: 'currency',
136
- min: minAmount?.amount ?? null,
137
- max: maxAmount?.amount ?? null,
138
- currency_code: currencyCode,
139
- currency_symbol: currencySymbol,
140
- };
141
- const payload = {
142
- steps,
143
- is_applicable_on_pending_approval_entity: approverViewUpdateData.isApplicableOnPendingApprovalEntity ?? true,
144
- criteria: [criteriaEntry],
145
- };
146
42
  if (isUpdate) {
147
43
  payload.approval_rule_id = approverViewUpdateData.approvalRuleId;
148
44
  }
@@ -1,6 +1,5 @@
1
1
  import recordGet from 'lodash/get';
2
2
  import has from 'lodash/has';
3
- import { getAmountCriteria, getDepartmentCriteria, getVendorCriteria, } from '../../../../entity/approvalRule/approvalRuleSelector';
4
3
  import { reduceFetchState } from '../../../../commonStateTypes/reduceFetchState';
5
4
  import { getBankAccountByBankAccountId, getBankAccountsByBankAccountIds, } from '../../../../entity/bankAccount/bankAccountSelector';
6
5
  import { getContactById, getContactsByIds, } from '../../../../entity/billPay/contact/contactSelector';
@@ -357,14 +356,6 @@ export const getEditBillDetail = (state, isVendorRecommendationFeatureEnabled, i
357
356
  isDeleted,
358
357
  showAutofill,
359
358
  addBillAutoFields,
360
- // Bill-level accounting class. Approval Rules 3.0 'department'
361
- // criteria match against this. Lives on BillTransaction; not on
362
- // any sub-section. Empty-string is normalised to 'undefined'
363
- // so downstream readers treat "no class" uniformly regardless
364
- // of whether the wire used '' or omitted the field.
365
- classId: transaction?.classId != null && transaction.classId !== ''
366
- ? transaction.classId
367
- : undefined,
368
359
  billStage,
369
360
  deleteStatus,
370
361
  billActivities,
@@ -687,59 +678,12 @@ export const getDefaultWithdrawFromAccount = (state, depositAccounts, companyId,
687
678
  }
688
679
  return undefined;
689
680
  };
690
- export const checkIfCreatorIsApprover = (billAmount, approvalRules, signedInUser, billVendorId, billDepartmentId) => {
681
+ export const checkIfCreatorIsApprover = (billAmount, approvalRules, signedInUser) => {
691
682
  let isCreatorAlsoApprover = false;
692
- // Approval Rules 3.0 — a rule applies to a bill only when all of
693
- // its present criteria are satisfied. Criteria not declared on
694
- // the rule are treated as "no narrowing on this axis".
695
- //
696
- // Strict-match semantics for vendor / department: if the rule
697
- // narrows by an axis but the bill has no value on that axis, the
698
- // rule does NOT apply (an absent bill-side value can't satisfy
699
- // either 'is' or 'is_not'). Amount is always present on a rule
700
- // (the form enforces this), but bounds may be one-sided.
701
683
  const approvalRule = approvalRules.find((rule) => {
702
- const vendorCriteria = getVendorCriteria(rule.criteria);
703
- if (vendorCriteria != null) {
704
- if (billVendorId == null) {
705
- return false;
706
- }
707
- const includesVendor = vendorCriteria.vendorIds.includes(billVendorId);
708
- if (vendorCriteria.operator === 'is' && !includesVendor) {
709
- return false;
710
- }
711
- if (vendorCriteria.operator === 'is_not' && includesVendor) {
712
- return false;
713
- }
714
- }
715
- const departmentCriteria = getDepartmentCriteria(rule.criteria);
716
- if (departmentCriteria != null) {
717
- if (billDepartmentId == null) {
718
- return false;
719
- }
720
- const includesDepartment = departmentCriteria.departmentIds.includes(billDepartmentId);
721
- if (departmentCriteria.operator === 'is' && !includesDepartment) {
722
- return false;
723
- }
724
- if (departmentCriteria.operator === 'is_not' && includesDepartment) {
725
- return false;
726
- }
727
- }
728
- const amountCriteria = getAmountCriteria(rule.criteria);
729
- if (amountCriteria == null) {
730
- // The form guarantees an amount criterion on every rule, so
731
- // this branch is defensive against backend drift. Keep
732
- // pre-3.0 behaviour: a rule that doesn't declare amount
733
- // doesn't participate here.
734
- return false;
735
- }
736
- // Bounds use the wire's inclusive 'gte' / 'lte' semantics, and
737
- // either side may be absent for a one-sided 'greater_than' /
738
- // 'less_than' rule.
739
- const { min, max } = amountCriteria;
740
- const matchesMin = min == null || billAmount >= min.amount;
741
- const matchesMax = max == null || billAmount <= max.amount;
742
- return matchesMin && matchesMax;
684
+ const { max, min } = rule.criteria[0].range;
685
+ return (billAmount > min.amount &&
686
+ (max?.amount != null ? billAmount <= max?.amount : true));
743
687
  });
744
688
  if (approvalRule != null) {
745
689
  const requireApprovalSteps = approvalRule.steps.filter((step) => step.action === 'require_approval');
@@ -13,17 +13,24 @@ export const initializeIntlVerificationFormEpic = (actions$, state$) => actions$
13
13
  ? onboardingDataFromCompanyInfo[formFieldKey]?.values
14
14
  : undefined;
15
15
  if (values != null) {
16
- localData[formFieldKey] =
17
- internationalWireFormPayload[formFieldKey].type === 'enum'
18
- ? internationalWireFormPayload[formFieldKey]
19
- .is_multiple_values_allowed === false
16
+ const fieldPayload = internationalWireFormPayload[formFieldKey];
17
+ if (fieldPayload.type === 'enum') {
18
+ localData[formFieldKey] =
19
+ fieldPayload.is_multiple_values_allowed === false
20
20
  ? typeof values[0] === 'object' && 'code' in values[0]
21
21
  ? values[0].code
22
22
  : ''
23
23
  : values.map((value) => typeof value === 'object' && 'code' in value
24
24
  ? value.code
25
- : '')
26
- : values[0];
25
+ : '');
26
+ }
27
+ else if (fieldPayload.type === 'file' &&
28
+ fieldPayload.is_multiple_values_allowed === true) {
29
+ localData[formFieldKey] = values.filter((value) => typeof value === 'string');
30
+ }
31
+ else {
32
+ localData[formFieldKey] = values[0] ?? '';
33
+ }
27
34
  }
28
35
  else {
29
36
  localData[formFieldKey] =
@@ -1,15 +1,53 @@
1
+ export const InternationalWireVerificationFormOrder = [
2
+ 'certificate_of_good_standing',
3
+ 'business_ownership',
4
+ 'company_proof_of_address',
5
+ 'company_officer_proof_of_address',
6
+ 'company_registration_date',
7
+ 'annual_turnover',
8
+ 'expected_transaction_volume',
9
+ 'employee_count',
10
+ 'intended_use_of_account',
11
+ 'transaction_countries',
12
+ 'stake_holder',
13
+ 'controlling_person',
14
+ ];
15
+ const toFieldValues = (fieldValues) => fieldValues?.map(({ code, description }) => ({ code, description })) ?? [];
16
+ const toSubField = (subfield) => ({
17
+ label: subfield.label,
18
+ placeholder: subfield.field_hint_text ?? '',
19
+ type: subfield.type,
20
+ fieldValues: toFieldValues(subfield.field_values),
21
+ isMultipleOptionsSupported: subfield.is_multiple_options_supported,
22
+ options: subfield.options,
23
+ });
1
24
  export const toDynamicFormField = (key, payload) => ({
2
25
  name: key,
3
26
  label: payload.label,
4
27
  placeholder: payload.field_hint_text ?? '',
5
28
  isMultipleValuesAllowed: payload.is_multiple_values_allowed ?? false,
6
29
  type: payload.type,
7
- fieldValues: payload.field_values != null && payload.field_values.length > 0
8
- ? payload.field_values.map((fieldValue) => {
9
- return {
10
- code: fieldValue.code,
11
- description: fieldValue.description,
12
- };
13
- })
14
- : [],
30
+ fieldValues: toFieldValues(payload.field_values),
31
+ isMultipleOptionsSupported: payload.is_multiple_options_supported,
32
+ options: payload.options,
33
+ requirements: payload.requirements,
34
+ default: payload.default,
35
+ subfields: payload.subfields != null
36
+ ? Object.fromEntries(Object.entries(payload.subfields).map(([subfieldKey, subfield]) => [
37
+ subfieldKey,
38
+ toSubField(subfield),
39
+ ]))
40
+ : undefined,
15
41
  });
42
+ export const sortVerificationFormFields = (fields) => {
43
+ const orderIndex = new Map(InternationalWireVerificationFormOrder.map((name, index) => [name, index]));
44
+ return fields.slice().sort((a, b) => {
45
+ const aIndex = orderIndex.get(a.name) ?? InternationalWireVerificationFormOrder.length;
46
+ const bIndex = orderIndex.get(b.name) ?? InternationalWireVerificationFormOrder.length;
47
+ if (aIndex !== bIndex) {
48
+ return aIndex - bIndex;
49
+ }
50
+ return a.name.localeCompare(b.name);
51
+ });
52
+ };
53
+ export const toVerificationFormFields = (internationalWireFormPayload) => sortVerificationFormFields(Object.keys(internationalWireFormPayload).map((key) => toDynamicFormField(key, internationalWireFormPayload[key])));