@yuneta/gobj-ui 7.25.14 → 7.25.16

package/src/shell_toast_once.test.js

@@ -5,17 +5,17 @@
  *      stacked under it: one close of the transport settles every
  *      request it cut, each view that asked shows its failure, and
  *      the operator got a column of identical "the connection
- *      dropped" (low of the independent review of the 2nd round).
+ *      dropped".
  *
- *      And a repeat is a caller of its own (third independent
- *      review): its handle and its time are its own, and the toast
- *      stays while any caller still holds it.
+ *      And a repeat is a caller of its own: its handle and its time
+ *      are its own, and the toast stays while any caller still holds
+ *      it.
  *
  *      And every ✕ this module draws is a control with a NAME: a
- *      `title` and an `aria-label`, both translatable (fourth
- *      independent review: TOAST_CLOSE had the label only). So is
- *      every other button of a dialog (fifth: the dialog's back arrow
- *      had no title, and the Yes/No of every confirmation had neither).
+ *      `title` and an `aria-label`, both translatable (TOAST_CLOSE had
+ *      the label only). So is every other button of a dialog (the
+ *      dialog's back arrow had no title, and the Yes/No of every
+ *      confirmation had neither).
  *
  *          Copyright (c) 2026, ArtGins.
  *          All Rights Reserved.
@@ -30,6 +30,9 @@ const {
     yui_shell_show_info,
     yui_shell_show_modal,
     yui_shell_confirm_danger,
+    yui_shell_confirm_ok,
+    yui_shell_confirm_yesno,
+    yui_shell_confirm_yesnocancel,
 } = await import("./shell_modals.js");
 
 let shell = null;
@@ -78,7 +81,7 @@ describe("one toast per message on screen", () => {
 });
 
 /*
- *  The third independent review: a repeat was handed the FIRST toast's
+ *  A repeat was handed the FIRST toast's
  *  handle and timer. A repeat asking `timeout: 0` was dismissed on the
  *  first one's timer, and closing one caller's handle closed the toast
  *  another caller was still showing.
@@ -168,7 +171,7 @@ describe("every close control is named", () => {
     });
 });
 
-describe("every other button of a dialog is named (fifth review)", () => {
+describe("every other button of a dialog is named", () => {
 
     function named($b)
     {
@@ -200,3 +203,63 @@ describe("every other button of a dialog is named (fifth review)", () => {
         ]);
     });
 });
+
+/*
+ *  A confirmation that names no label shows the DEFAULT ones, and those
+ *  are i18n keys like every other label: lower-case, translated by the
+ *  app's t(), and carried as the key of the text, the title and the
+ *  aria-label. They were "OK", "Yes", "No", "Delete" and "Cancel" --
+ *  keys no locale has, so the button read in English in every language.
+ */
+describe("the default labels of a confirmation are i18n keys", () => {
+
+    function keys_of($layer)
+    {
+        return [...$layer.querySelectorAll(".CONFIRM_BTN")].map(($b) => [
+            $b.getAttribute("data-i18n"),
+            $b.getAttribute("data-i18n-title"),
+            $b.getAttribute("data-i18n-aria-label"),
+        ]);
+    }
+
+    /*  What the reader hears: the aria-label, translated by t() when
+     *  the button is built.  */
+    function texts_of($layer)
+    {
+        return [...$layer.querySelectorAll(".CONFIRM_BTN")].map(($b) => $b.getAttribute("aria-label"));
+    }
+
+    const k = (key) => [key, key, key];
+
+    /*  A translator that tells a key it knows from one it does not.  */
+    const ES = {ok: "Aceptar", yes: "Sí", no: "No", delete: "Borrar", cancel: "Cancelar"};
+    const t = (key) => ES[key] || `?${key}?`;
+
+    test("ok", () => {
+        shell.priv.layers.modal = document.createElement("div");
+        yui_shell_confirm_ok(shell, "saved", {t: t});
+        expect(keys_of(shell.priv.layers.modal)).toEqual([k("ok")]);
+        expect(texts_of(shell.priv.layers.modal)).toEqual(["Aceptar"]);
+    });
+
+    test("yes / no", () => {
+        shell.priv.layers.modal = document.createElement("div");
+        yui_shell_confirm_yesno(shell, "go on?", {t: t});
+        expect(keys_of(shell.priv.layers.modal)).toEqual([k("yes"), k("no")]);
+        expect(texts_of(shell.priv.layers.modal)).toEqual(["Sí", "No"]);
+    });
+
+    test("yes / no / cancel", () => {
+        shell.priv.layers.modal = document.createElement("div");
+        yui_shell_confirm_yesnocancel(shell, "keep it?", {t: t});
+        expect(keys_of(shell.priv.layers.modal)).toEqual([k("yes"), k("no"), k("cancel")]);
+        expect(texts_of(shell.priv.layers.modal)).toEqual(["Sí", "No", "Cancelar"]);
+    });
+
+    test("delete / cancel", () => {
+        shell.priv.layers.modal = document.createElement("div");
+        yui_shell_confirm_danger(shell, "delete this column?", {t: t});
+        expect(keys_of(shell.priv.layers.modal)).toEqual([k("delete"), k("cancel")]);
+        expect(texts_of(shell.priv.layers.modal)).toEqual(["Borrar", "Cancelar"]);
+    });
+});

package/src/table_cell_text.js

@@ -7,7 +7,7 @@
  *          (only its own `plaintext` formatter escapes), so a record's text
  *          returned as a string is parsed as markup: `a<b and c>d` showed
  *          as `ad`, and a field holding `<img src=x onerror=...>` ran it in
- *          the operator's browser (M31 of the 2026-09-21 review). Record
+ *          the operator's browser. Record
  *          data goes in as a TEXT NODE, and a cell built around it as DOM,
  *          never as an HTML string with the data interpolated.
  *

package/src/table_cell_text.test.js

@@ -9,7 +9,7 @@ const doc = {
 describe("table_cell_text", () => {
 
     it("record text is a text node, markup included", () => {
-        /*  M31: Tabulator puts a string through innerHTML  */
+        /*  Tabulator puts a string through innerHTML  */
         const node = cell_text("limit a<b and c>d", doc);
         expect(node.nodeType).toBe(3);
         expect(node.textContent).toBe("limit a<b and c>d");

package/src/treedb_graph_writes.wiring.test.js

@@ -0,0 +1,208 @@
+/***********************************************************************
+ *          treedb_graph_writes.wiring.test.js
+ *
+ *      C_YUI_TREEDB_GRAPH and the writes of `__graphs__`, the topic
+ *      where the graph keeps its arrangement. The engine
+ *      (C_G6_NODES_TREE) takes such a write for granted before it
+ *      leaves: nothing answers it when it lands. So the host must say
+ *      when one did NOT land -- refused by the backend, refused on the
+ *      way out, or never sent for want of a session. Without that, the
+ *      engine believed the backend held the arrangement, and the next
+ *      Save had nothing to write.
+ *
+ *      Driven through the real host on a document double, with a fake
+ *      engine that records what it is told and a fake transport whose
+ *      state is the one the host reads.
+ *
+ *          Copyright (c) 2026, ArtGins.
+ *          All Rights Reserved.
+ ***********************************************************************/
+import {describe, test, expect, beforeAll, beforeEach} from "vitest";
+import {install_dom_double} from "../test/dom_double.js";
+
+install_dom_double();
+
+/*  The host watches its container's size; the document double has no
+ *  layout to watch.  */
+if(!globalThis.ResizeObserver) {
+    globalThis.ResizeObserver = class {
+        observe() {}
+        unobserve() {}
+        disconnect() {}
+    };
+}
+
+const {
+    SDATA, SDATA_END, data_type_t,
+    gclass_create,
+    gobj_start_up, gobj_create_yuno, gobj_create, gobj_create_service,
+    gobj_start, gobj_send_event, gobj_publish_event,
+    gobj_read_pointer_attr, gobj_subscribe_event,
+    gobj_change_state, gobj_current_state,
+    set_log_callback,
+} = await import("@yuneta/gobj-js");
+
+const logged = [];
+const commands = [];        /*  what the fake transport was asked  */
+const told = [];            /*  what the fake engine was told  */
+let refuse_on_the_way = false;
+
+function remote_command_parser(gobj, command, kw, src)
+{
+    if(refuse_on_the_way) {
+        return `cannot route '${command}'`;
+    }
+    commands.push({command, kw, src});
+    return null;
+}
+
+let yuno = null;
+
+beforeAll(async () => {
+    gobj_start_up(null, null, null, null, null, null, null);
+    set_log_callback((level, msg) => {
+        logged.push({level: String(level), msg: String(msg)});
+    });
+
+    gclass_create("C_TEST_HOST", [], [["ST_IDLE", []]], {}, 0, [SDATA_END()], {}, 0, 0, 0, 0);
+    gclass_create(
+        "C_TEST_REMOTE",
+        [],
+        [["ST_SESSION", []], ["ST_DISCONNECTED", []]],
+        {mt_command_parser: remote_command_parser},
+        0, [SDATA_END()], {}, 0, 0, 0, 0
+    );
+
+    /*  The engine, registered BEFORE the host so the host uses it. It
+     *  publishes what the real one publishes on a Save, and records every
+     *  event it is sent.  */
+    const record = (gobj, event, kw) => {
+        told.push({event, kw});
+        return 0;
+    };
+    const ENGINE_EVENTS = [
+        "EV_DESCS", "EV_CLEAR_DATA", "EV_LOAD_DATA", "EV_NODE_CREATED",
+        "EV_NODE_UPDATED", "EV_NODE_DELETED", "EV_GRAPHS_WRITE_REFUSED",
+        "EV_SHOW", "EV_HIDE", "EV_RESIZE", "EV_THEME", "EV_LANGUAGE_CHANGED",
+        "EV_SET_OPERATION_MODE", "EV_SET_LAYOUT"
+    ];
+    gclass_create(
+        "C_G6_NODES_TREE",
+        ENGINE_EVENTS.map((e) => [e, 0]).concat([["EV_UPDATE_NODE", 2]]),
+        [["ST_IDLE", ENGINE_EVENTS.map((e) => [e, record, null])]],
+        {
+            mt_create: (gobj) => {
+                const subscriber = gobj_read_pointer_attr(gobj, "subscriber");
+                if(subscriber) {
+                    gobj_subscribe_event(gobj, null, {}, subscriber);
+                }
+            }
+        },
+        0,
+        [
+            SDATA(data_type_t.DTP_POINTER, "subscriber", 0, null, ""),
+            SDATA(data_type_t.DTP_POINTER, "$container", 0, null, ""),
+            SDATA(data_type_t.DTP_POINTER, "gobj_remote_yuno", 0, null, ""),
+            SDATA(data_type_t.DTP_STRING, "treedb_name", 0, "", ""),
+            SDATA(data_type_t.DTP_JSON, "layout_names", 0, "[]", ""),
+            SDATA(data_type_t.DTP_STRING, "layout", 0, "", ""),
+            SDATA_END()
+        ],
+        {}, 0, 0, 0, 0
+    );
+
+    const {register_c_yui_treedb_graph} = await import("./c_yui_treedb_graph.js");
+    register_c_yui_treedb_graph();
+
+    yuno = gobj_create_yuno("graph_writes_yuno", "C_TEST_HOST", {});
+    gobj_start(yuno);
+});
+
+beforeEach(() => {
+    logged.length = 0;
+    commands.length = 0;
+    told.length = 0;
+    refuse_on_the_way = false;
+});
+
+function build(name)
+{
+    const remote = gobj_create_service(`${name}_remote`, "C_TEST_REMOTE", {}, yuno);
+    gobj_change_state(remote, "ST_SESSION");
+    const host = gobj_create_service(`${name}_graph`, "C_YUI_TREEDB_GRAPH", {
+        gobj_remote_yuno: remote,
+        treedb_name: "treedb_test"
+    }, yuno);
+    const engine = host.priv.gobj_nodes_tree;
+    expect(engine).toBeTruthy();
+    return {remote, host, engine};
+}
+
+/*  What the engine publishes on a Save of one topic's arrangement.  */
+function save_arrangement(engine, topic)
+{
+    gobj_publish_event(engine, "EV_UPDATE_NODE", {
+        treedb_name: "treedb_test",
+        topic_name: "__graphs__",
+        record: {id: topic, topic: topic, active: true, properties: {nodes: {}}},
+        options: {list_dict: true, autolink: false, create: true}
+    });
+}
+
+function answer(host, remote, request, result, comment)
+{
+    gobj_send_event(host, "EV_MT_COMMAND_ANSWER", {
+        result: result,
+        comment: comment || "",
+        data: null,
+        __md_iev__: {command_stack: [{command: request.command, kw: request.kw}]}
+    }, remote);
+}
+
+function refused()
+{
+    return told.filter((t) => t.event === "EV_GRAPHS_WRITE_REFUSED").map((t) => t.kw.topic);
+}
+
+describe("a __graphs__ write that does not land is said to the engine", () => {
+
+    test("refused by the backend", () => {
+        const {remote, host, engine} = build("g1");
+        save_arrangement(engine, "yunos");
+        expect(commands.length).toBe(1);
+        answer(host, remote, commands[0], -1, "not authorized");
+        expect(refused()).toEqual(["yunos"]);
+    });
+
+    test("landed: nothing is said", () => {
+        const {remote, host, engine} = build("g2");
+        save_arrangement(engine, "yunos");
+        answer(host, remote, commands[0], 0);
+        expect(refused()).toEqual([]);
+    });
+
+    test("with no session: not sent, and said", () => {
+        const {remote, host, engine} = build("g3");
+        gobj_change_state(remote, "ST_DISCONNECTED");
+        save_arrangement(engine, "realms");
+        expect(commands).toEqual([]);
+        expect(refused()).toEqual(["realms"]);
+        expect(logged.some((l) => /not sent/.test(l.msg))).toBe(true);
+    });
+
+    test("refused on the way out by the transport", () => {
+        const {remote, host, engine} = build("g4");
+        refuse_on_the_way = true;
+        save_arrangement(engine, "binaries");
+        expect(refused()).toEqual(["binaries"]);
+    });
+
+    test("a refused write of another topic says nothing to the engine", () => {
+        const {remote, host, engine} = build("g5");
+        gobj_send_event(host, "EV_UPDATE_NODE", {
+            topic_name: "yunos", record: {id: "1", x: 1}
+        }, engine);
+        answer(host, remote, commands[0], -1, "refused");
+        expect(refused()).toEqual([]);
+    });
+});

package/src/treedb_topics_transport.wiring.test.js

@@ -5,7 +5,7 @@
  *      through the real gclasses (C_YUI_SHELL, C_YUI_TREEDB_TOPICS) on a
  *      document double. The helper (form_writes_in_flight.js) was tested
  *      and right; what failed was that two hosts never called the action
- *      that uses it (M8 of the 2026-09-23 review), which no helper test
+ *      that uses it, which no helper test
  *      can see.
  *
  *          Copyright (c) 2026, ArtGins.
@@ -169,7 +169,7 @@ function errors()
     return logged.filter((l) => l.level === "error").map((l) => l.msg);
 }
 
-describe("a Save in flight when the backend drops (M8)", () => {
+describe("a Save in flight when the backend drops", () => {
 
     test("the shell's connection edge answers every form, with no host forwarding", () => {
         const {shell, topics, forms} = build("t1");

package/src/yui_install.js

@@ -194,6 +194,17 @@ function yui_install_start_watch()
  *      app can call yui_install_prompt() from a button of its
  *      own whenever it likes.
  ***************************************************************/
+/*  The question and its answers when the app names none. They are i18n
+ *  KEYS, lower-case, and the ones every consumer already defines; the
+ *  question was "Install this app?" until 7.25.16, a key no locale
+ *  carries. Written as `i18n:` entries so the validate-locales script of
+ *  a consumer finds them when it scans this module.  */
+const DEFAULT_ASK = Object.freeze({
+    message: Object.freeze({i18n: "install this app"}),
+    yes:     Object.freeze({i18n: "install"}),
+    no:      Object.freeze({i18n: "not now"})
+});
+
 function yui_install_ask_once(shell, opts)
 {
     opts = opts || {};
@@ -213,10 +224,10 @@ function yui_install_ask_once(shell, opts)
         S.asking = true;
         kw_set_local_storage_value(ASKED_KEY, true);
 
-        yui_shell_confirm_yesno(shell, opts.message || "Install this app?", {
+        yui_shell_confirm_yesno(shell, opts.message || DEFAULT_ASK.message.i18n, {
             t:         opts.t,
-            yes_label: opts.yes_label || "install",
-            no_label:  opts.no_label  || "not now"
+            yes_label: opts.yes_label || DEFAULT_ASK.yes.i18n,
+            no_label:  opts.no_label  || DEFAULT_ASK.no.i18n
         }).then(function(yes) {
             S.asking = false;
             if(yes) {

package/src/yui_install.test.js

@@ -140,3 +140,26 @@ test("subscribe(): a throwing listener does not break the others", async () => {
     off1();
     off2();
 });
+
+/*  The question asked when the app names none is an i18n KEY, the one
+ *  every consumer already defines ("install this app"). It was
+ *  "Install this app?", a key no locale carries, so an app that took
+ *  the default asked in English in every language.  */
+test("ask_once(): the default question and answers are i18n keys", async () => {
+    const asked = [];
+    vi.resetModules();
+    vi.doMock("./shell_modals.js", () => ({
+        yui_shell_confirm_yesno: (shell, message, opts) => {
+            asked.push({message, yes: opts.yes_label, no: opts.no_label});
+            return new Promise(() => {});
+        }
+    }));
+    try {
+        const {yui_install_ask_once} = await import("./yui_install.js");
+        window[STASH] = fake_event("accepted");
+        yui_install_ask_once({fake_shell: true}, {});
+        expect(asked).toEqual([{message: "install this app", yes: "install", no: "not now"}]);
+    } finally {
+        vi.doUnmock("./shell_modals.js");
+    }
+});

package/src/yui_row_search.test.js

@@ -115,7 +115,7 @@ describe("is_hook_size", () => {
  *  The children of a hook as the NODE EVENTS deliver them: `{id,
  *  topic_name}`, with no hook_name. Not taken for a reference, their
  *  topic_name -- the same word on every row -- was a wildcard for every
- *  row that had received an UPDATED (M30 of the 2026-09-21 review).
+ *  row that had received an UPDATED.
  */
 describe("a hook's children as the node events deliver them", () => {
     const row = {id: "w1", devices: [{id: "d7", topic_name: "devices"}]};

package/src/yui_table_select.test.js

@@ -59,7 +59,7 @@ describe("reading and dropping the selection", () => {
  *  A table as the delete of the treedb topic table meets it AFTER a
  *  confirmation: rows came and went while the dialog was open. A position
  *  names whatever row sits there now; an id names the row the question named
- *  (the regression of d60ec78, A6 of the 2026-09-21 review).
+ *  (the regression of d60ec78).
  */
 function fake_table(rows, index)
 {