@yuneta/gobj-ui 7.25.14 → 7.25.16

package/src/schema_editor_reload.wiring.test.js

@@ -1,37 +1,35 @@
 /***********************************************************************
  *          schema_editor_reload.wiring.test.js
  *
- *      C_YUI_SCHEMA_EDITOR while it RELOADS (the third independent
- *      review, 2026-09-23). A reload entered ST_LOADING and drew
- *      nothing: the screen it replaced stayed up and clickable, and
- *      ST_LOADING declares none of its actions, so a click on a card,
- *      on Back, on the drawing -- or the Save of a column form left
- *      open -- answered "Event NOT DEFINED in state ST_LOADING" and
+ *      C_YUI_SCHEMA_EDITOR while it RELOADS. A reload entered
+ *      ST_LOADING and drew nothing: the screen it replaced stayed up and
+ *      clickable, and ST_LOADING declares none of its actions, so a click
+ *      on a card, on Back, on the drawing -- or the Save of a column form
+ *      left open -- answered "Event NOT DEFINED in state ST_LOADING" and
  *      the click, or the edit, was lost.
  *
- *      And the lows of the same review: a position left over from a
- *      load that could not leave, a drop during a WRITE that dropped
- *      the host's position (a drop during a load applies it), the
- *      drawing of a treedb that is gone drawn over the old screen, and
- *      the reload of a late write that forgot this session's marks and
- *      never told the host a write had landed.
+ *      And what a reload left behind: a position left over from a load
+ *      that could not leave, a drop during a WRITE that dropped the
+ *      host's position (a drop during a load applies it), the drawing of
+ *      a treedb that is gone drawn over the old screen, the reload of a
+ *      late write that forgot this session's marks and never told the
+ *      host a write had landed, a dialog opened on the model it replaced
+ *      (its Save wrote the old record over the newer one), a load refused
+ *      IN session that blanked the model, a late write whose list_dict
+ *      fkey marked nothing, a write answered with no record that owed a
+ *      second reload and dropped the rest of its queue in silence, and a
+ *      toolbar gated on the state instead of on the treedb being there.
  *
- *      The fourth independent review (same day) found what a reload
- *      still left behind: a dialog opened on the model it replaced
- *      (its Save wrote the old record over the newer one), a load
- *      refused IN session that blanked the model, a late write whose
- *      list_dict fkey marked nothing, a write answered with no record
- *      that owed a second reload and dropped the rest of its queue in
- *      silence, and a toolbar gated on the state instead of on the
- *      treedb being there.
+ *      And where the owed reload lingered: a load that LANDED by another
+ *      road (the operator's Refresh, a late write) left it owed, so the
+ *      next edit was refused and read the store again; a move sent by the
+ *      host did not run it; a load that failed forgot the import plan of
+ *      a dialog it left up; and the export's two views switched in a DOM
+ *      handler, out of the machine.
  *
- *      The sixth independent review (same day) found where the owed
- *      reload still lingered: a load that LANDED by another road (the
- *      operator's Refresh, a late write) left it owed, so the next
- *      edit was refused and read the store again; a move sent by the
- *      host did not run it; a load that failed forgot the import plan
- *      of a dialog it left up; and the export's two views switched in
- *      a DOM handler, out of the machine.
+ *      And a dialog that outlives its screen through a move sent by the
+ *      host: its Save answered "Event NOT DEFINED", and a confirmation
+ *      answered after a move to another treedb deleted there.
  *
  *      Driven through the FSM on a document double, with a fake
  *      transport whose state is the one the library reads.
@@ -63,8 +61,10 @@ vi.mock("./shell_modals.js", () => ({
         }};
     },
     yui_shell_confirm_danger: (shell, message, opts) => {
-        confirms.push({message, opts});
-        return new Promise(() => {});
+        /*  Answered by the test that needs it (`resolve`), or never.  */
+        return new Promise((resolve) => {
+            confirms.push({message, opts, resolve});
+        });
     },
 }));
 
@@ -316,6 +316,8 @@ const WAIT = "the schemas are loading: wait for them";
 const STALE = "the schemas were read again: open the dialog again";
 const KEPT = "cannot read the schemas again: the ones shown may be out of date, your next change reads them first";
 const OWED = "the schemas shown may be out of date: they are read again, try again when they are in";
+const OWED_FORM = "the schemas shown may be out of date: they are read again, and the form opens again on them with your changes";
+const GONE = "the schemas were read again and what the form was editing is not there any more";
 const NOT_SENT = "the treedb did not describe a write back: the writes after it were not sent";
 
 describe("the screen of a reload", () => {
@@ -530,7 +532,7 @@ describe("a write given up that was DONE", () => {
     });
 });
 
-describe("a dialog built on the model a reload replaced (fourth review)", () => {
+describe("a dialog built on the model a reload replaced", () => {
 
     test("an edit form: the load that lands closes it, and its Save writes nothing", () => {
         const {editor, remote, host} = build("s1", "db/users");
@@ -588,7 +590,7 @@ describe("a dialog built on the model a reload replaced (fourth review)", () =>
             r.cols.push({id: "db.users.email", value: "email", order: 2, type: "integer",
                          topics: ["topics^db.users^cols"]});
         }));
-        /*  Forgotten when the load LANDS, not when it leaves (sixth review).  */
+        /*  Forgotten when the load LANDS, not when it leaves.  */
         expect(editor.priv.import_plan).toBe(null);
         expect(dialog.closed).toBe(true);
 
@@ -612,12 +614,13 @@ describe("a dialog built on the model a reload replaced (fourth review)", () =>
     });
 });
 
-describe("a load that fails IN session (fourth review)", () => {
+describe("a load that fails IN session", () => {
 
     test("keeps the model, the screen and the open form, says so, and owes the reload", () => {
         const {editor, remote, host} = build("b1", "db/users");
         gobj_send_event(editor, "EV_EDIT_COLUMN", {col: "id"}, host);
         const form = modals[modals.length - 1];
+        form.$content.querySelector('[data-name="header"]').value = "Identifier";
         gobj_send_event(editor, "EV_REFRESH", {}, host);
         const asked = take("nodes");
         answer(editor, remote, asked[0], -1, null, "deadline");
@@ -634,16 +637,28 @@ describe("a load that fails IN session (fourth review)", () => {
 
         /*  The form was built on a model that may be older than the
          *  store: its Save would write every field of it. It runs the
-         *  reload owed instead (fifth review), and the load that lands
-         *  closes the form.  */
+         *  reload owed instead. The load that lands closes the form,
+         *  and opens it again ON THE SCHEMAS JUST READ with what the
+         *  operator changed: closed alone, what was typed was lost.  */
         form.$content.querySelector(".SCHEMA_COL_FORM_SAVE").click();
         expect(not_defined()).toEqual([]);
         expect(take("update-node")).toEqual([]);
-        expect(shown).toEqual([KEPT, OWED]);
+        expect(shown).toEqual([KEPT, OWED_FORM]);
+        const before = modals.length;
         expect(answer_the_load(editor, remote)).toBe(3);
         expect(form.closed).toBe(true);
-        expect(shown).toEqual([KEPT, OWED, STALE]);
+        expect(modals.length).toBe(before + 1);
+        const again = modals[modals.length - 1];
+        expect(again.closed).toBe(false);
+        expect(again.$content.querySelector('[data-name="header"]').value).toBe("Identifier");
+        expect(shown).toEqual([KEPT, OWED_FORM]);
         expect(editor.priv.reload_on_open).toBe(false);
+
+        /*  Its Save writes, on the record just read.  */
+        again.$content.querySelector(".SCHEMA_COL_FORM_SAVE").click();
+        const [write] = take("update-node");
+        expect(write.kw.record.id).toBe("db.users.id");
+        expect(write.kw.record.header).toBe("Identifier");
         expect(errors()).toEqual([]);
     });
 
@@ -675,7 +690,7 @@ describe("a load that fails IN session (fourth review)", () => {
     });
 });
 
-describe("a late write, in the shape the store answers (fourth review)", () => {
+describe("a late write, in the shape the store answers", () => {
 
     test("a list_dict fkey marks the topic the column belongs to", () => {
         const {editor, remote, host} = build("c1", "db/users");
@@ -692,7 +707,7 @@ describe("a late write, in the shape the store answers (fourth review)", () => {
     });
 });
 
-describe("a write answered with no record (fourth review)", () => {
+describe("a write answered with no record", () => {
 
     test("the reload it asks is the one owed: the next write does not load again", () => {
         const {editor, remote, host} = build("n1", "db/users");
@@ -736,7 +751,7 @@ describe("a write answered with no record (fourth review)", () => {
     });
 });
 
-describe("the toolbar of a treedb that is not there (fourth review)", () => {
+describe("the toolbar of a treedb that is not there", () => {
 
     test("offers Back and Refresh, and nothing that needs the treedb", () => {
         const {editor, remote, host} = build("t1", "db");
@@ -773,7 +788,7 @@ describe("the toolbar of a treedb that is not there (fourth review)", () => {
     });
 });
 
-describe("every control of the editor's dialogs is named (fourth review)", () => {
+describe("every control of the editor's dialogs is named", () => {
 
     /*  A control a wrapping <label> names is the one shape that needs no
      *  attribute (CLAUDE.md, "title + aria-label").  */
@@ -810,7 +825,7 @@ describe("every control of the editor's dialogs is named (fourth review)", () =>
     });
 });
 
-describe("the export's two views are controls (fifth review)", () => {
+describe("the export's two views are controls", () => {
 
     test("each is a named button that says which one is shown, and switches the text", () => {
         const {editor, remote, host} = build("x1", "db");
@@ -840,7 +855,7 @@ describe("the export's two views are controls (fifth review)", () => {
     });
 });
 
-describe("a Refresh asked while a load is in flight (fifth review)", () => {
+describe("a Refresh asked while a load is in flight", () => {
 
     test("keeps the records of the model shown, not the half the first load got", () => {
         const {editor, remote, host} = build("h1", "db/users");
@@ -876,7 +891,7 @@ describe("a Refresh asked while a load is in flight (fifth review)", () => {
     });
 });
 
-describe("the reload a load refused in session owes (fifth review)", () => {
+describe("the reload a load refused in session owes", () => {
 
     function refused_load(name, subpath)
     {
@@ -956,7 +971,7 @@ describe("the reload a load refused in session owes (fifth review)", () => {
     });
 });
 
-describe("the import plan (fifth review)", () => {
+describe("the import plan", () => {
 
     const IMPORT = JSON.stringify({id: "db", topics: [{id: "users", pkey: "id", cols: [
         {id: "id", type: "string", flag: ["persistent", "required"]},
@@ -990,7 +1005,7 @@ describe("the import plan (fifth review)", () => {
     });
 });
 
-describe("a confirmation answered where no treedb is open (fifth review)", () => {
+describe("a confirmation answered where no treedb is open", () => {
 
     test("after a reload that landed on zero treedbs: refused as stale, not NOT DEFINED", () => {
         const {editor, remote, host} = build("e1", "db/users");
@@ -1031,7 +1046,7 @@ describe("a confirmation answered where no treedb is open (fifth review)", () =>
     });
 });
 
-describe("the answers of the editor's confirmations are i18n keys (fifth review, live)", () => {
+describe("the answers of the editor's confirmations are i18n keys", () => {
 
     /*  shell_modals names each answer by its label; its defaults ("Delete",
      *  "Cancel") are not lower-case, so no validated locale holds them and
@@ -1046,7 +1061,7 @@ describe("the answers of the editor's confirmations are i18n keys (fifth review,
     });
 });
 
-describe("the owed reload, settled wherever a load lands (sixth review)", () => {
+describe("the owed reload, settled wherever a load lands", () => {
 
     function refused_load(name, subpath)
     {
@@ -1125,7 +1140,7 @@ describe("the owed reload, settled wherever a load lands (sixth review)", () =>
     });
 });
 
-describe("the import plan outlives a load that fails (sixth review)", () => {
+describe("the import plan outlives a load that fails", () => {
 
     const IMPORT = JSON.stringify({id: "db", topics: [{id: "users", pkey: "id", cols: [
         {id: "id", type: "string", flag: ["persistent", "required"]},
@@ -1173,7 +1188,7 @@ describe("the import plan outlives a load that fails (sixth review)", () => {
     });
 });
 
-describe("the export's two views go through the machine (sixth review)", () => {
+describe("the export's two views go through the machine", () => {
 
     test("a click on a view is an event, and the action switches the text", () => {
         const {editor, remote, host} = build("y1", "db");
@@ -1221,3 +1236,268 @@ describe("the export's two views go through the machine (sixth review)", () => {
         expect(errors().length).toBe(2);
     });
 });
+
+describe("a move sent by the host while a dialog is up", () => {
+
+    /*  C_YUI_SHELL keeps the overlays open on a move that changes only
+     *  the subpath (a url typed in, a link). The dialog of the screen the
+     *  editor left sends what only that screen declares.  */
+    const MOVED = "the view moved: open the dialog again";
+
+    const IMPORT = JSON.stringify({id: "db", topics: [{id: "users", pkey: "id", cols: [
+        {id: "id", type: "string", flag: ["persistent", "required"]},
+        {id: "email", type: "string"}
+    ]}]});
+
+    function settle()
+    {
+        return new Promise((resolve) => {
+            setTimeout(resolve, 0);
+        });
+    }
+
+    test("a column form: closed and said, not left to answer NOT DEFINED", () => {
+        const {editor, remote, host} = build("mv1", "db/users");
+        gobj_send_event(editor, "EV_EDIT_COLUMN", {col: "id"}, host);
+        const form = modals[modals.length - 1];
+        expect(form.closed).toBe(false);
+
+        gobj_send_event(editor, "EV_SHOW", {subpath: "db"}, host);
+        expect(gobj_current_state(editor)).toBe("ST_TOPICS");
+        expect(form.closed).toBe(true);
+        expect(editor.priv.dialog).toBe(null);
+        expect(shown).toEqual([MOVED]);
+        expect(not_defined()).toEqual([]);
+        expect(errors()).toEqual([]);
+        expect(commands).toEqual([]);
+    });
+
+    test("the import dialog: closed, and its plan forgotten", () => {
+        const {editor, remote, host} = build("mv2", "db");
+        gobj_send_event(editor, "EV_IMPORT", {}, host);
+        const dialog = modals[modals.length - 1];
+        gobj_send_event(editor, "EV_PREVIEW_IMPORT", {prune: false, text: IMPORT,
+            model_gen: editor.priv.model_gen}, editor);
+        expect(editor.priv.import_plan).not.toBe(null);
+
+        gobj_send_event(editor, "EV_SHOW", {subpath: ""}, host);
+        expect(gobj_current_state(editor)).toBe("ST_TREEDBS");
+        expect(dialog.closed).toBe(true);
+        expect(editor.priv.import_plan).toBe(null);
+        expect(shown).toEqual([MOVED]);
+        expect(not_defined()).toEqual([]);
+        expect(errors()).toEqual([]);
+    });
+
+    test("a move that arrives during a load that fails: the same, when it is applied", () => {
+        const {editor, remote, host} = build("mv3", "db/users");
+        gobj_send_event(editor, "EV_EDIT_COLUMN", {col: "id"}, host);
+        const form = modals[modals.length - 1];
+        gobj_send_event(editor, "EV_REFRESH", {}, host);
+        gobj_send_event(editor, "EV_SHOW", {subpath: "db"}, host);
+        expect(form.closed).toBe(false);
+        for(const c of take("nodes")) {
+            answer(editor, remote, c, -1, null, "deadline");
+        }
+        expect(gobj_current_state(editor)).toBe("ST_TOPICS");
+        expect(form.closed).toBe(true);
+        expect(shown).toEqual([KEPT, MOVED]);
+        expect(not_defined()).toEqual([]);
+    });
+
+    test("the same position sent again leaves the dialog alone", () => {
+        const {editor, remote, host} = build("mv4", "db/users");
+        gobj_send_event(editor, "EV_EDIT_COLUMN", {col: "id"}, host);
+        const form = modals[modals.length - 1];
+        gobj_send_event(editor, "EV_SHOW", {subpath: "db/users"}, host);
+        expect(form.closed).toBe(false);
+        expect(shown).toEqual([]);
+    });
+
+    test("the export and the check read nothing of the screen: they stay up", () => {
+        const {editor, remote, host} = build("mv5", "db");
+        gobj_send_event(editor, "EV_EXPORT", {}, host);
+        const exported = modals[modals.length - 1];
+        gobj_send_event(editor, "EV_SHOW", {subpath: ""}, host);
+        expect(exported.closed).toBe(false);
+        exported.$content.querySelectorAll(".SCHEMA_EXPORT_TAB")[1].click();
+        expect(exported.$content.querySelector(".SCHEMA_EXPORT_TEXT").value.trim()
+            .startsWith("{")).toBe(true);
+
+        gobj_send_event(editor, "EV_SHOW", {subpath: "db"}, host);
+        gobj_send_event(editor, "EV_VALIDATE", {}, host);
+        const report = modals[modals.length - 1];
+        gobj_send_event(editor, "EV_SHOW", {subpath: "db/users"}, host);
+        expect(report.closed).toBe(false);
+        expect(shown).toEqual([]);
+        expect(not_defined()).toEqual([]);
+        expect(errors()).toEqual([]);
+    });
+
+    test("a confirmation answered after a move to another treedb deletes nothing", async () => {
+        const {editor, remote, host} = build("mv6", "db/users");
+        gobj_send_event(editor, "EV_REFRESH", {}, host);
+        answer_the_load_with(editor, remote, records_with((r) => {
+            r.treedbs.push({id: "db2", schema_version: 1});
+            r.topics.push({id: "db2.users", value: "users", order: 1, pkey: "id",
+                topic_version: 1, treedbs: ["treedbs^db2^topics"]});
+            r.cols.push({id: "db2.users.id", value: "id", order: 1, type: "string",
+                flag: ["persistent", "required"], topics: ["topics^db2.users^cols"]});
+        }));
+        expect(gobj_current_state(editor)).toBe("ST_COLUMNS");
+
+        gobj_send_event(editor, "EV_DELETE_COLUMN", {col: "id"}, host);
+        expect(confirms.length).toBe(1);
+        gobj_send_event(editor, "EV_SHOW", {subpath: "db2/users"}, host);
+        expect(gobj_current_state(editor)).toBe("ST_COLUMNS");
+        confirms[0].resolve(true);
+        await settle();
+
+        expect(take("delete-node")).toEqual([]);
+        expect(commands).toEqual([]);
+        expect(shown).toEqual([MOVED]);
+        expect(errors()).toEqual([]);
+    });
+
+    test("a confirmation answered on the screen it was asked from still runs", async () => {
+        const {editor, remote, host} = build("mv7", "db/users");
+        gobj_send_event(editor, "EV_DELETE_COLUMN", {col: "id"}, host);
+        confirms[0].resolve(true);
+        await settle();
+        expect(take("delete-node").length).toBe(1);
+        expect(shown).toEqual([]);
+    });
+});
+
+describe("the form opened again after the owed reload", () => {
+
+    function owing(name, subpath)
+    {
+        const built = build(name, subpath);
+        built.editor.priv.reload_on_open = true;    /*  as a load refused in session leaves it  */
+        return built;
+    }
+
+    test("only what was CHANGED is carried: a field the store changed meanwhile shows the store's", () => {
+        const {editor, remote, host} = build("ro6", "db/users");
+        gobj_send_event(editor, "EV_EDIT_COLUMN", {col: "id"}, host);
+        editor.priv.reload_on_open = true;
+        const form = modals[modals.length - 1];
+        form.$content.querySelector('[data-name="header"]').value = "Identifier";
+        form.$content.querySelector(".SCHEMA_COL_FORM_SAVE").click();
+        answer_the_load_with(editor, remote, records_with((r) => {
+            r.cols[0].description = "written by somebody else";
+        }));
+        const again = modals[modals.length - 1];
+        expect(again.$content.querySelector('[data-name="header"]').value).toBe("Identifier");
+        expect(again.$content.querySelector('[data-name="description"]').value)
+            .toBe("written by somebody else");
+        again.$content.querySelector(".SCHEMA_COL_FORM_SAVE").click();
+        const [write] = take("update-node");
+        expect(write.kw.record.description).toBe("written by somebody else");
+        expect(write.kw.record.header).toBe("Identifier");
+        expect(errors()).toEqual([]);
+    });
+
+    test("a NEW column comes back whole: its name, its type and its flags", () => {
+        const {editor, remote, host} = owing("ro2", "db/users");
+        /*  The owed reload runs on the form's opening too: open it on a
+         *  model that is current, then owe the reload.  */
+        editor.priv.reload_on_open = false;
+        gobj_send_event(editor, "EV_ADD_COLUMN", {}, host);
+        editor.priv.reload_on_open = true;
+        const form = modals[modals.length - 1];
+        form.$content.querySelector('[data-name="value"]').value = "email";
+        form.$content.querySelector('[data-name="header"]').value = "Email";
+        for(const $box of form.$content.querySelectorAll(".SCHEMA_FLAG_BOX")) {
+            if($box.dataset.flag === "required") {
+                $box.checked = true;
+            }
+        }
+        form.$content.querySelector(".SCHEMA_COL_FORM_SAVE").click();
+        expect(shown).toEqual([OWED_FORM]);
+        answer_the_load(editor, remote);
+        const again = modals[modals.length - 1];
+        expect(again).not.toBe(form);
+        expect(again.$content.querySelector('[data-name="value"]').value).toBe("email");
+        expect(again.$content.querySelector('[data-name="header"]').value).toBe("Email");
+        const on = [...again.$content.querySelectorAll(".SCHEMA_FLAG_BOX")]
+            .filter(($b) => $b.checked).map(($b) => $b.dataset.flag);
+        expect(on).toContain("required");
+        expect(errors()).toEqual([]);
+    });
+
+    test("a topic form comes back the same way", () => {
+        const {editor, remote, host} = build("ro3", "db");
+        gobj_send_event(editor, "EV_EDIT_TOPIC", {topic: "users"}, host);
+        editor.priv.reload_on_open = true;
+        const form = modals[modals.length - 1];
+        form.$content.querySelector('[data-name="tkey"]').value = "tm";
+        form.$content.querySelector(".SCHEMA_TOPIC_FORM_SAVE").click();
+        expect(shown).toEqual([OWED_FORM]);
+        answer_the_load(editor, remote);
+        const again = modals[modals.length - 1];
+        expect(again).not.toBe(form);
+        expect(again.$content.querySelector('[data-name="tkey"]').value).toBe("tm");
+        expect(errors()).toEqual([]);
+    });
+
+    test("what the form edited is gone after the reload: not opened again, and SAID", () => {
+        const {editor, remote, host} = build("ro4", "db/users");
+        gobj_send_event(editor, "EV_EDIT_COLUMN", {col: "id"}, host);
+        editor.priv.reload_on_open = true;
+        const form = modals[modals.length - 1];
+        form.$content.querySelector(".SCHEMA_COL_FORM_SAVE").click();
+        const before = modals.length;
+        answer_the_load_with(editor, remote, records_with((r) => {
+            r.cols = [];
+        }));
+        expect(form.closed).toBe(true);
+        expect(modals.length).toBe(before);
+        expect(shown).toEqual([OWED_FORM, GONE]);
+        expect(errors()).toEqual([]);
+    });
+
+    test("a form closed by the operator while the reload ran is not opened again", () => {
+        const {editor, remote, host} = build("ro5", "db/users");
+        gobj_send_event(editor, "EV_EDIT_COLUMN", {col: "id"}, host);
+        editor.priv.reload_on_open = true;
+        const form = modals[modals.length - 1];
+        form.$content.querySelector(".SCHEMA_COL_FORM_SAVE").click();
+        form.$content.querySelector(".SCHEMA_COL_FORM_CANCEL").click();
+        const before = modals.length;
+        answer_the_load(editor, remote);
+        expect(modals.length).toBe(before);
+        expect(shown).toEqual([OWED_FORM]);
+        expect(errors()).toEqual([]);
+    });
+});
+
+describe("EV_REFRESH while a write is in flight", () => {
+
+    test("waits for the end of the writes: the queue is written whole, then the schemas are read", () => {
+        const {editor, remote, host} = build("rq1", "db");
+        gobj_send_event(editor, "EV_CONFIRMED", {what: "topic", topic: "users",
+            model_gen: editor.priv.model_gen}, editor);
+        expect(gobj_current_state(editor)).toBe("ST_SAVING");
+        const [first] = take("delete-node");
+        expect(first.kw.topic_name).toBe("cols");
+
+        gobj_send_event(editor, "EV_REFRESH", {}, host);
+        expect(gobj_current_state(editor)).toBe("ST_SAVING");
+        expect(take("nodes")).toEqual([]);
+        expect(logged.some((l) => l.level === "warning" &&
+            /EV_REFRESH.*when the writes end/.test(l.msg))).toBe(true);
+
+        answer(editor, remote, first, 0, {});
+        const [second] = take("delete-node");
+        expect(second.kw.topic_name).toBe("topics");
+        answer(editor, remote, second, 0, {});
+
+        expect(gobj_current_state(editor)).toBe("ST_LOADING");
+        expect(answer_the_load(editor, remote)).toBe(3);
+        expect(editor.priv.written).toEqual({});
+        expect(errors()).toEqual([]);
+        expect(not_defined()).toEqual([]);
+    });
+});

package/src/schema_editor_transport.wiring.test.js

@@ -1,8 +1,8 @@
 /***********************************************************************
  *          schema_editor_transport.wiring.test.js
  *
- *      C_YUI_SCHEMA_EDITOR when the transport drops (M-1 of the
- *      independent review of 7.25.4). A drop used to leave the editor
+ *      C_YUI_SCHEMA_EDITOR when the transport drops. A drop used to
+ *      leave the editor
  *      where it was: in ST_SAVING with its body busy, or in ST_LOADING
  *      -- and the reconnect skipped the reload BECAUSE the state was
  *      ST_LOADING. Only a reload of the page got it out.

package/src/schema_version_bump.test.js

@@ -3,7 +3,7 @@
  *
  *      "This topic was written in this session and is not saved."
  *
- *      An edit is a DRAFT (M36 of yunetas' 2026-09-21 review): it moves
+ *      An edit is a DRAFT: it moves
  *      no version, and the host's save-schema raises the versions of what
  *      changed. So "written" alone is the whole question -- the version is
  *      no longer measured against a baseline, which is also why the old

package/src/shell_modals.js

@@ -124,9 +124,8 @@ function maybe_apply_translator($node, opts)
  *      it -- until every handle is closed or has timed out. Handed the
  *      first caller's handle and timer, a repeat asking `timeout: 0`
  *      was dismissed on the first one's timer, and closing one
- *      caller's handle closed a toast another was still showing
- *      (third independent review). The operator's ✕ closes it for
- *      everybody.
+ *      caller's handle closed a toast another was still showing.
+ *      The operator's ✕ closes it for everybody.
  ***************************************************************/
 function show_notification(shell, kind, message, opts)
 {
@@ -614,9 +613,30 @@ function build_dialog(shell, message, buttons, opts)
 }
 
 
+/***************************************************************
+ *  The labels a confirmation shows when the caller names none.
+ *
+ *  They are i18n KEYS, lower-case like every key: a button
+ *  translates its label with the app's t() -- its text, its title
+ *  and its aria-label. Until 7.25.16 they were "OK", "Yes", "No",
+ *  "Delete" and "Cancel", keys that no locale carries, so a dialog
+ *  that took the defaults read in English in every language.
+ *
+ *  Written as `i18n:` entries so the validate-locales script of a
+ *  consumer finds them when it scans this module: an app that
+ *  mounts these dialogs must define the five keys.
+ ***************************************************************/
+const DEFAULT_LABEL = Object.freeze({
+    ok:     Object.freeze({i18n: "ok"}),
+    yes:    Object.freeze({i18n: "yes"}),
+    no:     Object.freeze({i18n: "no"}),
+    delete: Object.freeze({i18n: "delete"}),
+    cancel: Object.freeze({i18n: "cancel"})
+});
+
 export function yui_shell_confirm_ok(shell, message, opts)
 {
-    let label = (opts && opts.ok_label) || "OK";
+    let label = (opts && opts.ok_label) || DEFAULT_LABEL.ok.i18n;
     if(!opts || !opts.type) {
         opts = Object.assign({}, opts, {type: "success"});
     }
@@ -627,8 +647,8 @@ export function yui_shell_confirm_ok(shell, message, opts)
 
 export function yui_shell_confirm_yesno(shell, message, opts)
 {
-    let yes_label = (opts && opts.yes_label) || "Yes";
-    let no_label  = (opts && opts.no_label)  || "No";
+    let yes_label = (opts && opts.yes_label) || DEFAULT_LABEL.yes.i18n;
+    let no_label  = (opts && opts.no_label)  || DEFAULT_LABEL.no.i18n;
     return build_dialog(shell, message, [
         {label: yes_label, value: "yes", kind: "primary"},
         {label: no_label,  value: "no"}
@@ -651,8 +671,8 @@ export function yui_shell_confirm_yesno(shell, message, opts)
  ***************************************************************/
 export function yui_shell_confirm_danger(shell, message, opts)
 {
-    let confirm_label = (opts && opts.confirm_label) || "Delete";
-    let cancel_label  = (opts && opts.cancel_label)  || "Cancel";
+    let confirm_label = (opts && opts.confirm_label) || DEFAULT_LABEL.delete.i18n;
+    let cancel_label  = (opts && opts.cancel_label)  || DEFAULT_LABEL.cancel.i18n;
     if(!opts || !opts.type) {
         opts = Object.assign({}, opts, {type: "danger"});
     }
@@ -664,9 +684,9 @@ export function yui_shell_confirm_danger(shell, message, opts)
 
 export function yui_shell_confirm_yesnocancel(shell, message, opts)
 {
-    let yes_label    = (opts && opts.yes_label)    || "Yes";
-    let no_label     = (opts && opts.no_label)     || "No";
-    let cancel_label = (opts && opts.cancel_label) || "Cancel";
+    let yes_label    = (opts && opts.yes_label)    || DEFAULT_LABEL.yes.i18n;
+    let no_label     = (opts && opts.no_label)     || DEFAULT_LABEL.no.i18n;
+    let cancel_label = (opts && opts.cancel_label) || DEFAULT_LABEL.cancel.i18n;
     return build_dialog(shell, message, [
         {label: yes_label,    value: "yes", kind: "primary"},
         {label: no_label,     value: "no"},